[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-60-g0ac67146b9

Tue May 5 23:35:27 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  0ac67146b97123c2d408c0c72547d92e13368313 (commit)
       via  5576bf647dda24a4f7da56bf86656fe58f05b80d (commit)
       via  cfd8e38fd8c01d0ab1dfd9e1b828b283b1dac64d (commit)
       via  121ea7e96cdaf0e620858ec04ab80213a09a3d44 (commit)
       via  317d2c1de7c7ef234517b99e65df3cab361fc1bb (commit)
       via  b4f47c9a06af45a1524c210f073c07523ff94ce9 (commit)
       via  b2b36b6f447890ec2972cd2b397a23c53fd183f3 (commit)
       via  008b09ce057e117766a95c03f551cab82e90c424 (commit)
      from  0b7d3b4331c69238ae04fdb895baeae9ce0742cf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0ac67146b97123c2d408c0c72547d92e13368313
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 31 16:39:12 2020 +0200

    Bug 25027: Use localStorage instead of sessionStorage for results browser

    Staff side, when a search a done and a result clicked, a browser appears
    on the left, to navigate between the different results.

    We use sessionStorage to know the list of biblionumber from the result.

    As sessionStorage is only for the current tab, we do some ugly things,
    to catch the click events, then open the new tab, attach it to the
    current window, and put the focus back on the result list.

    We really should not do that, and let the user decide what they want to
    do with their clicks!

    To do so, let use the correct storage, localStorage, and have the
    results shared between the windows.

    We may need to clear that at some point, isn't it?

    Test plan:
    Launch a search, click result (left or middle), confirm you see the
    browser and that the window/tab opened like any other websites
    (depending on your web browser settings).

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 5576bf647dda24a4f7da56bf86656fe58f05b80d
Author: David Roberts <david at koha-ptfs.co.uk>
Date:   Mon Apr 13 01:22:07 2020 +0000

    Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it

    This patch changes the wording of the comment

    To test:

    1) Check the wording of Line 67 of Koha/AuthUtils.pm
    2) Apply the patch
    3) Check that the wording has changed from "Encrypt it" to "Hash it"

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit cfd8e38fd8c01d0ab1dfd9e1b828b283b1dac64d
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Thu Apr 9 15:50:04 2020 +0000

    Bug 24993: fix increment

    Aparently ((i++)) isn't portable, changed for an admittedly uglier
    but functional increment.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 121ea7e96cdaf0e620858ec04ab80213a09a3d44
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 8 11:57:06 2020 +0200

    Bug 24993: Make sure we are not going to loop indefinitely

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 317d2c1de7c7ef234517b99e65df3cab361fc1bb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Apr 2 12:36:16 2020 +0200

    Bug 24993: Make sure SIP server is stopped before restarting it

    Sometimes doing koha-sip --restart instance happens too fast and
    the SIP server is not started.

    To test:
    - have SIP enabled and running for your instance
    - issue a restart, make sure it restarts
      sudo koha-sip --restart inst

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b4f47c9a06af45a1524c210f073c07523ff94ce9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Mar 30 10:06:43 2020 -0300

    Bug 25008: Overload Koha::RecordProcessor->options to update filters

    This patch overloads the 'options' accessor generated by Class:Accessor.
    It does so the passed options are used to refresh the loaded filters.

    Tests are added for this overloaded method as well.

    To test:
    1. Apply this patches
    2. Run:
       $ kshell
      k$ prove t/RecordProcessor.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b2b36b6f447890ec2972cd2b397a23c53fd183f3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Mar 30 10:20:11 2020 -0300

    Bug 25008: Tests for ->options

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 008b09ce057e117766a95c03f551cab82e90c424
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Mar 27 17:53:32 2020 -0300

    Bug 25008: Regression tests

    This patch highlights a behaviour of Koha::RecordProcessor that is
    unexpected: if you change the original options using ->options, the
    loaded filters don't pick the change. That's because the filter objects
    are loaded on ->new, and they are never updated.

    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/RecordProcessor.t
    => FAIL: Test prove ->options doesn't update the filters!

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/AuthUtils.pm                     |  2 +-
 Koha/RecordProcessor.pm               | 23 +++++++++++++++
 debian/scripts/koha-sip               | 10 +++++++
 koha-tmpl/intranet-tmpl/js/browser.js | 22 +++-----------
 t/RecordProcessor.t                   | 54 +++++++++++++++++++++++++++++++++++
 5 files changed, 92 insertions(+), 19 deletions(-)

hooks/post-receive
-- 
main Koha release repository