[koha-commits] main Koha release repository branch master updated. v19.11.00-2093-gb422e017ec

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b422e017eca6ad74f0f66d5fea181b01e48d661e (commit)
       via  fdea245e991aca4ca3ddad9d1a15d511e427fc0a (commit)
      from  185d88bac6745f7b76799600f6fd0a16cf09ac93 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b422e017eca6ad74f0f66d5fea181b01e48d661e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 7 18:20:57 2020 -0300

    Bug 23185: Realistic POD for Koha::Objects->search
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit fdea245e991aca4ca3ddad9d1a15d511e427fc0a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 7 18:05:29 2020 -0300

    Bug 23185: ->update can only be called on instantiated classes
    
    Since our use ok Koha::Objects, there's been an implicit instantiation
    happening in ->search that has somehow hidden the fact that classes need
    instantiation...
    
    This change in ->delete and ->update made it clear because of the
    failures/hangs on the tests.
    
    This patch instantiates Koha::Patron::Categories before attempting to
    call ->update.
    
    The original patches for this bug are correct and the only issue here is
    that we need to document better than for some methods, instantiation is
    not implicit and is required first. This is awkward and I would prefer
    to force everyone to call ->new first. But I understand it would be
    inconvenient.
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/Template/Plugin/Categories.t
    => FAIL: Notice it hangs, Ctrl+c to abort
    2. Apply this patch
    3. Repeat 1
    => SUCCESS: Tests dong hang, and in fact pass
    4. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                             | 19 ++++++++++++++++---
 t/db_dependent/Template/Plugin/Categories.t |  2 +-
 2 files changed, 17 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository