[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-151-g93f37f3a03

Mon May 11 19:18:09 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  93f37f3a03fc1205b3c3cb54e650081dc3dd79ea (commit)
       via  18f3661179e6a556fc1c39a8841edb99e4e97cd9 (commit)
       via  e4e31117e7dcdc769f6c94553165202c49c7e0ae (commit)
       via  b325831210dacbb0857f843670eb26b0c5268e6d (commit)
       via  6e53814c58be68bf7392395896c7a66a40d12bd1 (commit)
       via  8dea59bba0c620da41a47698e2142e61f1dba3f9 (commit)
      from  47414f97c1358da9cd79e1e884ab1f9d74516014 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 93f37f3a03fc1205b3c3cb54e650081dc3dd79ea
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Apr 27 13:20:23 2020 +0000

    Bug 22515: Improve logic determining how to show OPAC suggestions

    This patch makes changes to the OPAC suggestions view so that the logic
    around logged in users and the OPACViewOthersSuggestions preference is
    more specific.

    To reproduce the bug you should have pending purchase susggestions in
    your system from more than one patron.

    1. Set the OPACViewOthersSuggestions preference to "Show."
    2. Log in to the OPAC as a user who has not submitted any suggestions.
    3. Follow the link to the purchase suggestions page from the menu under
       the search bar.
    4. The page will say that there are no  purchase suggestions.
    5. Add "?suggested_by_anyone=1" to the end of the page URL.
    6. You should see suggestions from other users.

    To test, apply the patch and repeat steps 2-3 above. The suggestions
    page should show other patrons' suggestions.

    Test with different combinations of factors:

     - Logged in user, OPACViewOthersSuggestions off
     - No logged in user, OPACViewOthersSuggestions on
     - No logged in user, OPACViewOthersSuggestions off

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 18f3661179e6a556fc1c39a8841edb99e4e97cd9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 22 12:11:53 2020 +0000

    Bug 25247: Only convert data ot objects when displaying on screen

    To test:
     1 - Modify a patron
     2 - Circulate some items to the patron
     3 - Click 'Modification log'
     4 - Verify you see your actions
     5 - Under 'Output' select 'To a file'
     6 - Save the output to a file
     7 - View the file
     8 - Not you have references ot objects in stead of patron/item data
     9 - Apply patch
    10 - Repeat
    11 - Note viewing on screen has not changed
    12 - Note exporting to file inlcudes borrower/item numbers and not references
    13 - Sign off

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e4e31117e7dcdc769f6c94553165202c49c7e0ae
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Apr 29 17:57:44 2020 +0000

    Bug 21565: (follow-up) Make confirmation buttons more detailed

    This patch updates the confirmation buttons to be more specific about
    what each one does. My concern was that it wasn't clear that "No" meant
    "No receipt" and not "Cancel logging out."

    The patch also updates the modal confirmation code so that the modal
    body is removed if no message is passed for it.

    To test, apply the patch and repeat the previous test plan. When you
    click "Finish" you should have the options "Print receipt and end
    session" and "End session."

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b325831210dacbb0857f843670eb26b0c5268e6d
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Apr 24 18:39:02 2020 +0000

    Bug 21565: Add modal to SCO confirm

    This patch uses the confirmModal framework to add a modal confirm to
    SCO Finish.

    TO TEST:

    1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure
       SelfCheckReceiptPrompt is set to 'show'
    2. Login and click 'Finish' to see the old print alert box.
    3. Apply patch and repeat steps 1 and 2.
    4. Make sure the modal works for confirming and denying a receipt.
       Checkout some items and make sure everything still functions the
       same.
    5. Make sure when printing a receipt that the print dialog automatally
       shows
    6. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is
       acceptable.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6e53814c58be68bf7392395896c7a66a40d12bd1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Apr 10 06:58:43 2020 -0400

    Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType

    At some point some calls to maybe_add got an extra $server var in their
    parameter lists. This doubled parameter does nothing and should be
    removed.

    Test Plan: No change in behavior should be noted

    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8dea59bba0c620da41a47698e2142e61f1dba3f9
Author: David Roberts <david at koha-ptfs.co.uk>
Date:   Mon Apr 6 23:42:19 2020 +0000

    Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a

    This patch makes the subfield i display before subfield a in the 246 and
    730 fields

    To test:

    1) Create a bibliographic record with data in several subfields in tags
    246 and 730.
    2) See that subfield i displays at the end of the field in the 246
    field, and probably not at all in the 730 field. Check in both the OPAC
    and staff client
    3) Apply the patch.
    4) Check your bib record again in both clients. Subfield i should now
    display before subfield a.

    Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/Sip/MsgType.pm                              | 30 +++++++++++-----------
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     | 15 ++++++++---
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |  6 ++---
 .../bootstrap/en/modules/opac-suggestions.tt       | 18 ++++++++++---
 .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 17 +++++++-----
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    | 15 ++++++++---
 koha-tmpl/opac-tmpl/bootstrap/js/global.js         |  8 ++++--
 tools/viewlog.pl                                   |  4 +--
 8 files changed, 75 insertions(+), 38 deletions(-)

hooks/post-receive
-- 
main Koha release repository