[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-156-gfa24607515

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  fa246075155d6a64cab51f78ccba2ad4ce8108a8 (commit)
       via  65959ccdfbf0b2351f1709fefa5c6c8bf020e696 (commit)
       via  c5f24c2042df50a8b3ef186c9b652565817a2668 (commit)
       via  5a2506a849b3848045482987e166da09e2d72d43 (commit)
       via  cb62a145f5acf596713f1358cac3ed822bf04f97 (commit)
      from  93f37f3a03fc1205b3c3cb54e650081dc3dd79ea (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fa246075155d6a64cab51f78ccba2ad4ce8108a8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 8 08:47:49 2020 +0200

    Bug 24801: (follow-up) Display all the libraries - Selenium fix
    
    We have it failing now for the delete link..
    14:26:50 selenium_1   | 05:26:50.451 WARN - Exception: Unable to locate element: {"method":"xpath","selector":"//*[@id=\"delete_library_UT_BC\"]"}
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 65959ccdfbf0b2351f1709fefa5c6c8bf020e696
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 26 09:59:32 2020 +0100

    Bug 24801: Display all the libraries - Selenium fix
    
    Same as for categories.
    
    22:41:28 koha_1       | STRACE:	/usr/share/perl5/Try/Tiny.pm:104 in Selenium::Remote::Driver::catch {...}
    22:41:28 koha_1       | 	/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:353 in Try::Tiny::try
    22:41:28 koha_1       | 	(eval 1337):1 in Selenium::Remote::Driver::__ANON__
    22:41:28 koha_1       | 	(eval 1339):2 in Selenium::Remote::Driver::__ANON__
    22:41:28 koha_1       | 	/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in Selenium::Remote::Driver::_execute_command
    22:41:28 koha_1       | 	/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in (eval)
    22:41:28 koha_1       | 	/kohadevbox/koha/t/lib/Selenium.pm:174 in Selenium::Remote::Driver::find_element
    22:41:28 koha_1       | 	/kohadevbox/koha/t/lib/Selenium.pm:166 in t::lib::Selenium::click_when_visible
    22:41:28 koha_1       | 	t/db_dependent/selenium/administration_tasks.t:128 in t::lib::Selenium::click
    22:41:28 koha_1       |
    22:41:28 selenium_1   | 14:41:28.273 INFO - Executing: [take screenshot])
    22:41:28 selenium_1   | 14:41:28.873 INFO - Done: [take screenshot]
    22:41:31 koha_1       |
    22:41:31 koha_1       | SCREENSHOT: https://framapic.org/0nvX5dhLHpU1/tAEnENSeLRXB
    22:41:31 koha_1       | An element could not be located on the page using the given search parameters: //div[@class="main container-fluid"]//a[contains(@href, "/admin/branches.pl?op=add_form&branchcode=UT_BC")],xpath at /kohadevbox/koha/t/lib/Selenium.pm line 174.
    
    The screenshot was obvious, the UT_BC was not on the first page.
    There was a total of 33 libraries at this point, which is not expected,
    maybe data not deleted from previous selenium tests.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit c5f24c2042df50a8b3ef186c9b652565817a2668
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 4 15:53:12 2020 +0100

    Bug 24801: Display all the categories - Selenium fix
    
    To make sure we are going to be able to click on the "Delete" button of
    our newly created category PATRON_CAT, we are displaying them all.
    
    Test plan:
    Create several patron categories that will fill the first page:
    
    use t::lib::TestBuilder;
    my $builder = t::lib::TestBuilder->new;
    for my $i ( 1..20 ) {
        $builder->build_object({ class => 'Koha::Patron::Categories', value => { description => "cat_$i" } });
    }
    
    Execute the selenium tests.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 5a2506a849b3848045482987e166da09e2d72d43
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 11 16:04:27 2020 +0200

    Bug 23081: [19.11.x] Set items.issues to 0 if not provided (AddItem)
    
    In master it has been replaced by Koha::Object->store and we deal with
    the default value.
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit cb62a145f5acf596713f1358cac3ed822bf04f97
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jun 19 17:59:14 2019 +0000

    Bug 20816: [19.11.x] Add ability to define custom templated fields in SIP patron responses
    
    To test:
     1 - You will need to enable SIP on your testing instance
        cp etc/SIPconfig.xml /etc/koha/sites/kohadev/
        sudo koha-start-sip
        add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works)
        on koha-testing-docker you should be able to start sip with user koha/koha without any adjustments
     2 - If you copied the above file you should be set to get custom field DE with dateexpiry
         Otherwise edit the sip login for the user to have a custom section like:
    		  <login id="koha"   password="koha"  delimiter="|" error-detect="enabled" institution="kohalibrary" encoding="utf8" >
    			  <custom_patron_field field="DE" template="[% patron.dateexpiry %]" />
    		  </login>
     3 - send a status test using the sip cli tester:
         perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_status_request
     4 - send an information test using the sip cli tester:
         perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_information
     5 - confirm you receive the DE field with a dateexpiry
     6 - Add your own custom fields and confirm it works with several
             <custom_patron_field field="EW" template="Phone: [% patron.phone %] Email: [% patron.email %]" />
     7 - prove -v t/db_dependent/SIP/Patron.t
     8 - prove -v t/db_dependent/SIP/
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Bug 20816: Make SIP tests pass under ES
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                                    |  2 +-
 C4/SIP/ILS/Patron.pm                           | 47 ++++++++++++++++++++++----
 C4/SIP/Sip.pm                                  |  1 -
 C4/SIP/Sip/MsgType.pm                          | 17 ++++++++--
 etc/SIPconfig.xml                              |  1 +
 t/db_dependent/SIP/Message.t                   | 17 ++++++----
 t/db_dependent/SIP/Patron.t                    | 46 ++++++++++++++++++++++++-
 t/db_dependent/SIP/Transaction.t               | 21 +++++-------
 t/db_dependent/selenium/administration_tasks.t |  9 +++++
 9 files changed, 128 insertions(+), 33 deletions(-)


hooks/post-receive
-- 
main Koha release repository