[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-176-g75e7861df4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  75e7861df4834d7172b55552d1b7a03d3ab3b537 (commit)
       via  8048acf2255034bac433c654e66597e8da24ee99 (commit)
       via  bb3893720d55100380bf431cf6aea8a044a9bd04 (commit)
       via  aa9a4fc3f64787e536faabd4b49be76d1e8144f1 (commit)
      from  a0ee80a3038dc275b99ae781530f483c2fb425ad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75e7861df4834d7172b55552d1b7a03d3ab3b537
Author: Joy Nelson <joy at bywatersolutions.com>
Date:   Mon May 11 21:56:04 2020 +0000

    Bug 25184: (follow-up) fix number of tests
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 8048acf2255034bac433c654e66597e8da24ee99
Author: Joy Nelson <joy at bywatersolutions.com>
Date:   Mon May 11 21:52:39 2020 +0000

    Bug 25184: DBRev 19.11.05.005
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit bb3893720d55100380bf431cf6aea8a044a9bd04
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Apr 21 12:52:38 2020 -0400

    Bug 25184: Add syspref
    
    It's entirely possible that some libraries are relying on the current
    before for part of their workflow. Do to this possibility, it seems like
    a good idea to control this behavior via a system preference.
    
    Test Plan:
    1) Apply this patch set
    2) Run updatedatabase.pl
    3) Set TrapHoldsOnOrder to "don't trap"
    4) Set an item's notforloan value to -1
    5) Place a hold on that item
    6) Check in the item
    7) Note the item is not trapped for hold
    9) Set TrapHoldsOnOrder to "trap"
    10) Check in the item
    11) Koha should now ask if you'd like to trap the item for the hold!
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit aa9a4fc3f64787e536faabd4b49be76d1e8144f1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Apr 17 14:06:32 2020 -0400

    Bug 25184: Items with a negative notforloan status should not be captured for holds
    
    Negative notforloan statuses should allow holds to be placed but not captured.
    
    Due to coronavirus, we have libraries setting all returned materials to a negative notforloan value of Quarantine for several days.
    They're using UpdateNotForLoanStatusOnCheckin to set that status automatically. However, those items are still capturing for holds,
    even though those items cannot be checked out until the notforloan status is removed.
    
    In cases like an On Order item where we do want the hold to fill at checkin,
    UpdateNotForLoanStatusOnCheckin should be used to clear that notforloan status so the hold can fill.
    
    In master, if I set an item to a not for loan but holdable status ( < 0 ) I can place the hold,
    capture the hold and set it to waiting, but *not* check it out to the patron!
    This does not make sense. I should not be able to trap an item for checkout unless it can be checked out.
    
    Test Plan:
    1) Set an item's notforloan value to -1
    2) Place a hold on that item
    3) Check in the item
    4) Trap the item for that hold
    5) Attempt to check the item out to the patron, you will be unable to
       because it is notforloan
    6) Apply this patch
    7) Restart all the things!
    8) Repeat steps 1-3
    9) The screen should no longer ask if the item should be trapped
       to fill the hold!
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Catherine Ingram <Catherine.Ingram at cedarparktexas.gov>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                                     |  5 ++++-
 Koha.pm                                            |  2 +-
 installer/data/mysql/sysprefs.sql                  |  1 +
 installer/data/mysql/updatedatabase.pl             | 10 ++++++++++
 .../en/modules/admin/preferences/circulation.pref  |  6 ++++++
 t/db_dependent/Holds.t                             | 23 +++++++++++++++++++++-
 6 files changed, 44 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository