[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-182-g629d9dc21e
Git repo owner
gitmaster at git.koha-community.org
Tue May 12 00:35:11 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 629d9dc21e0df630c71eb53a219b01be72d3cf3d (commit)
via 96202ca7bb533ddf6bcb1c8486b8ae5a9591f1a1 (commit)
via b48282ba825870f11c10edc7aee44f4b0db52435 (commit)
via 34c07a58f8cdbe9a4c36b93b7c680837499f3018 (commit)
via e5372db43e8094fc491b861db7defb8e36e6b7db (commit)
via a53d63e0f7720321715e75be1147d8ea4df9a3aa (commit)
from 75e7861df4834d7172b55552d1b7a03d3ab3b537 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 629d9dc21e0df630c71eb53a219b01be72d3cf3d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu May 7 14:57:25 2020 +0000
Bug 25343: Use of item in review/comment feature is misleading
This patch updates the terminology associated with leaving a comment in
the OPAC. the word "item" is replaced with the more specific "title."
To test, apply the patch and make sure the reviewson system preference
is enabled.
- Log in to the OPAC and view a bibliographic record which has no
comments.
- Under the "comments" tab, verify that the text in the tab says
"There are no comments on this title. Post your comments on this
title."
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 96202ca7bb533ddf6bcb1c8486b8ae5a9591f1a1
Author: George Veranis <gveranis at dataly.gr>
Date: Wed Apr 22 11:43:53 2020 +0200
Bug 19312: Fix typo in template
This patch fixes a simple typo
Test plan:
1) Go to Administration -> MARC bibliographic framework
2) Select a framework and add plugin unimarc_field_121a.pl to 121 field
3) Open cataloguing screen
4) Go to 121 field and check if for subfield a shows two times the value
2-dimensional
5) Apply the patch
6) Go to 121 field again and check if it shows 2 different values
Mentored-by: Andreas Roussos <a.roussos at dataly.gr>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit b48282ba825870f11c10edc7aee44f4b0db52435
Author: David Roberts <david at koha-ptfs.co.uk>
Date: Thu May 7 18:07:21 2020 +0000
Bug 25388: There is no link for the "online help"
This patch removes a non-existent link to the online help from the marc
subfield editor.
To test:
1) Go to Admin > MARC Bibliographic framework > Edit MARC structure >
Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR)
2) Check that the Max Length value in the Advanced constraints area
contains text saying "See online help"
3) Apply patch
4) Check that the reference to the online help has disappeared.
Remove tabs from start of line
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 34c07a58f8cdbe9a4c36b93b7c680837499f3018
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Thu Apr 9 16:50:55 2020 +0200
Bug 25099: Sending a LANG variable to plug-in template
To make internationalised plug-ins, it may be useful to get the lang
from C4::Languages::getlanguage. This patch adds
C4::Languages::getlanguage result to a LANG variable which is sent to
the template plugin.
In your plugin, you can add a i18n directory containing
lang[-DIALECT].inc files with a TOKENS hash like this:
[%
TOKENS = {
PLUGIN_NAME = "Mannequin"
PRESENTATION = "Voici un example d'outil."
CLICK_ME = "Cliquez moi !"
}
%]
The plugin template can then include such a lang[-DIALECT].inc with a
hash containing all the plugin strings:
[% TRY %]
[% PROCESS "$PLUGIN_DIR/i18n/${LANG}.inc" %]
[% CATCH %]
[% PROCESS "$PLUGIN_DIR/i18n/default.inc" %]
[% END %]
The strings are then printed in the template with something like:
[% TOKENS.PRESENTATION %]
Test plan:
1. apply patch
2. install, enable and run BULAC Mannequin plugin
3. it should print stuff in english by default
4. install french French (fr-FR)
5. change you Koha lang to French
6. run again the plugin
7. ho là là! French!
Thanks to Tomàs Cohen and his pay via paypal plug-in from which most
ideas in this patch are taken.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit e5372db43e8094fc491b861db7defb8e36e6b7db
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue May 5 11:43:39 2020 +0000
Bug 25082: Don't remove characters from string
At the moment, show-lang-041 will either get a code
or an AV description to deal with. If it's a description,
we don't want to remove spaces and other chars from it.
To test:
- Repeat tests from first patch with an AV in LANG category
that consists of multiple words, has a - and other possible
punctuation.
- The description should show correctly in OPAC and staff.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit a53d63e0f7720321715e75be1147d8ea4df9a3aa
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Apr 12 16:30:05 2020 +0000
Bug 25082: Make 041 descriptions display, if authorised value list is used
When 041$a or another subfield is linked to an authorised value list,
Koha will replace the codes with the descriptions from the authorised
value in the MARCXML before passing it to the XSLT.
The XSLT was made to translate codes into descriptions - as there is
no code now, this fails and 'unknown language' is shown.
The patch changes the handling so that when the XSLT is handled something
that doesn't match a known code, it displays the subfield without
processing.
To test:
- Create some records with 041.
Examples: http://www.loc.gov/marc/bibliographic/bd041.html
- Verify this displays nicely in staff and OPAC
- Apply patch
- Verify display is unchanged
- Remove the patch
- Change one of your MARC frameworks (use another framework than
for your first test records)
and link the 041 subfields to the LANG authorised value list
- Go to administration and create some entries for LANG with language
codes and descriptions
- Catalog a 041 using the normal editor (not advanced)
- You can now use a pull down to select the values you want
- Verify the display is now 'Unknown language' for this record
- Apply patch
- Verify all records display the language descriptions now, using
an authorised value or not
- Run misc/maintenance/generate_MARC21Languages.pl
Verify the output at the end reads like:
<xsl:otherwise>
<!-- when 041\$a is mapped to an authorised value list, this will show the description -->
<xsl:value-of select="\$code" />
</xsl:otherwise>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Plugins/Base.pm | 2 +-
.../intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt | 2 +-
.../prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt | 4 ++--
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21Languages.xsl | 3 ++-
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 4 ++--
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21Languages.xsl | 3 ++-
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl | 4 ++--
misc/maintenance/generate_MARC21Languages.pl | 3 ++-
9 files changed, 16 insertions(+), 13 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list