[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-206-g4c201630ff

Wed May 13 21:47:20 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  4c201630ff3c8239c33588a3ffd82156a3c762ec (commit)
       via  6f9dda2f295a2d25c01ad48fd3f54fb25735f60b (commit)
       via  e21179fd9bad471c931ce0e89cd8f4df145af8f1 (commit)
       via  180360e3fde1befd73fb0d626d0fc7ddebc057de (commit)
       via  4550e7c6d90679d6b5a3ed067b43ecc214a22942 (commit)
       via  a64a5311f46f90cc33f6668eb0e4e6e317ca0f76 (commit)
       via  b08fff84bd88e22e1a5eb522a6f11d6db7621f09 (commit)
       via  44f4267cfc1097b5048cd2e49da73d4cbe7c69ed (commit)
       via  f0ecc011f0d91f86f2994bdda3c7e15d5d52592a (commit)
      from  1e2cb846ecab70a6bdad0d960e4609c954f6583e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c201630ff3c8239c33588a3ffd82156a3c762ec
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon May 11 17:08:35 2020 +0000

    Bug 25418: (QA follow-up) Raise size of input box

    In twelve hour format the length of the string is 20 characters
    we need the box to fit all of them

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 6f9dda2f295a2d25c01ad48fd3f54fb25735f60b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 7 17:18:35 2020 +0200

    Bug 25418: (bug 25133 follow-up) Display due date with hours

    And not as due date, it's not a display-only info, but an input.

    This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr

    == Test plan ==
    1. create checkouts with the following params and results
    2. tomorrow 11:59 PM timeformat syspref: 12h
       - item is due without a specific time, only date (after-checkout green box)
    3. backdate 11:59 PM timeformat syspref: 12h
       - note the yellow confirm box has only the date
       - item is due at 12:00 PM (after-checkout green box)
    4. tomorrow 11:23 AM timeformat syspref: 12h
       - item is due at 11:23 AM (after-checkout green box)
    5. backdate 11:23 AM timeformat syspref: 12h
       - note the yellow confirm box has the date and time
       - item is due 11:23 AM (after-checkout green box)
    6. tomorrow 23:59 timeformat syspref: 24h
       - item is due without a specific time, only date (after-checkout green box)
    7. backdate 23:59 timeformat syspref: 24h
       - note the yellow confirm box has only the date
       - item is due at 00:00 (after-checkout green box)
    8. tomorrow 11:23 timeformat syspref: 24h
       - item is due at 11:23 (after-checkout green box)
    9. backdate 11:23 timeformat syspref: 24h
       - note the yellow confirm box has the date and time
       - item is due 11:23 (after-checkout green box)
    10. apply patch
    11. create checkouts with the following params and results
    12. tomorrow 11:59 PM timeformat syspref: 12h
        - item is due without a specific time, only date (after-checkout green box)
    13. backdate 11:59 PM timeformat syspref: 12h
        - note the yellow confirm box has the date and time
          - CHANGE COMPARED TO BEFORE THE PATCH
        - item is due without a specific time, only date (after-checkout green box)
          - CHANGE COMPARED TO BEFORE THE PATCH
    14. tomorrow 11:23 AM timeformat syspref: 12h
        - item is due 11:23 AM (after-checkout green box)
    15. backdate 11:23 AM timeformat syspref: 12h
        - note the yellow confirm box has the date and time
        - item is due 11:23 AM (after-checkout green box)
    16. tomorrow 23:59 timeformat syspref: 24h
        - item is due without a specific time, only date (after-checkout green box)
    17. backdate 23:59 timeformat syspref: 24h
        - note the yellow confirm box has the date and time
          - CHANGE COMPARED TO BEFORE THE PATCH
        - item is due without a specific time, only date (after-checkout green box)
          - CHANGE COMPARED TO BEFORE THE PATCH
    18. tomorrow 11:23 timeformat syspref: 24h
        - item is due at 11:23 (after-checkout green box)
    19. backdate 11:23 timeformat syspref: 24h
        - note the yellow confirm box has the date and time
        - item is due 11:23 (after-checkout green box)

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit e21179fd9bad471c931ce0e89cd8f4df145af8f1
Author: Slava Shishkin <slavashishkin at gmail.com>
Date:   Sun May 10 18:15:09 2020 +0300

    Bug 25409: Add missing "Required" text and "required" classes

    Highlight text with red by adding “required” class to the label and added red
    “Required” text next to select field in "onboardingstep5.tt" template.

    To test:
        1) Start new installation. During onboarding tool phase you will be
           requested to create a new circulation rule.
        2) Observe that "Units" label has no "required" class and that
           there’s no “Required” text next to a select field.
        3) Apply patch.
        4) Repeat step 2 (you can reload circulation rule creation page).
        5) Observe the error is gone.

    Mentored-by: Peter Vashchuk <stalkernoid at gmail.com>
    Mentored-by: Andrew Nugged <nugged at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 180360e3fde1befd73fb0d626d0fc7ddebc057de
Author: Slava Shishkin <slavashishkin at gmail.com>
Date:   Thu May 7 14:24:31 2020 +0300

    Bug 25409: Add missing "required" class to template

    Added "required" class to "itemtype" label in "onboardingstep5.tt"
    template.

    To test:
        1) Start new instalation. During onboarding tool phase you will be
           requested to create a new circulation rule.
        2) Observe that "itemtype" label has no "required" class.
        3) Apply patch.
        4) Repeat step 2 (you can reload circulation rule creation page).
        5) Observe the error is gone.

    Mentored-by: Peter Vashchuk <stalkernoid at gmail.com>
    Mentored-by: Andrew Nugged <nugged at gmail.com>
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 4550e7c6d90679d6b5a3ed067b43ecc214a22942
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue May 12 09:24:28 2020 +0100

    Bug 25417: (QA follow-up) Add integration test for AddReturn

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit a64a5311f46f90cc33f6668eb0e4e6e317ca0f76
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon May 11 21:14:24 2020 +0100

    Bug 25417: (QA follow-up) Restore 'fixing' of fines

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b08fff84bd88e22e1a5eb522a6f11d6db7621f09
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon May 11 21:13:47 2020 +0100

    Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 44f4267cfc1097b5048cd2e49da73d4cbe7c69ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri May 8 12:28:46 2020 +0200

    Bug 25417: Prevent negative debit amount on backdating returns

    Koha::Account->add_credit is expecting a positive amount.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit f0ecc011f0d91f86f2994bdda3c7e15d5d52592a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu May 7 14:21:59 2020 -0400

    Bug 25417: Add unit test

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |  4 +-
 .../prog/en/modules/circ/circulation.tt            |  6 +-
 .../prog/en/modules/onboarding/onboardingstep5.tt  |  5 +-
 t/db_dependent/Circulation.t                       | 66 +++++++++++++++++++++-
 4 files changed, 71 insertions(+), 10 deletions(-)

hooks/post-receive
-- 
main Koha release repository