[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-40-gd1db7aeca5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  d1db7aeca5a238d5b7cc172778d142b45dd073bf (commit)
       via  427f564c4de3e4e71c183bc793260b16fdb05c93 (commit)
       via  da64d7ceb9bed580f4bf6230312c94a00d8fdbc3 (commit)
      from  0d06d789f7fa6dfaee7b208d2775a3f51e60477d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d1db7aeca5a238d5b7cc172778d142b45dd073bf
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Mar 30 10:06:43 2020 -0300

    Bug 25008: Overload Koha::RecordProcessor->options to update filters
    
    This patch overloads the 'options' accessor generated by Class:Accessor.
    It does so the passed options are used to refresh the loaded filters.
    
    Tests are added for this overloaded method as well.
    
    To test:
    1. Apply this patches
    2. Run:
       $ kshell
      k$ prove t/RecordProcessor.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit b4f47c9a06af45a1524c210f073c07523ff94ce9)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 427f564c4de3e4e71c183bc793260b16fdb05c93
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Mar 30 10:20:11 2020 -0300

    Bug 25008: Tests for ->options
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit b2b36b6f447890ec2972cd2b397a23c53fd183f3)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit da64d7ceb9bed580f4bf6230312c94a00d8fdbc3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Mar 27 17:53:32 2020 -0300

    Bug 25008: Regression tests
    
    This patch highlights a behaviour of Koha::RecordProcessor that is
    unexpected: if you change the original options using ->options, the
    loaded filters don't pick the change. That's because the filter objects
    are loaded on ->new, and they are never updated.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/RecordProcessor.t
    => FAIL: Test prove ->options doesn't update the filters!
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 008b09ce057e117766a95c03f551cab82e90c424)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/RecordProcessor.pm | 23 +++++++++++++++++++++
 t/RecordProcessor.t     | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+)


hooks/post-receive
-- 
main Koha release repository