[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-55-gb04b8d0061

Git repo owner gitmaster at git.koha-community.org
Thu May 14 18:23:26 CEST 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  b04b8d006172894e132a4c6d2be37498370d0f1a (commit)
       via  7725c1f9daa604d29355513ad51a70031df6cb5c (commit)
      from  16af0a42e9f663bc0e9019465b5bf03db967a2ca (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b04b8d006172894e132a4c6d2be37498370d0f1a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Sat Mar 28 17:42:50 2020 +0000

    Bug 25007: (follow-up) Fix the way image check alters layout
    
    A question in the bug report asks: Why is is necessary to change the
    Bootstrap class to col-xs-12? The JavaScript which checks for the
    existence of an Amazon cover image is designed to remove the Amazon
    cover's container if there is none. Changing the class of
    cover image column is gone.
    
    However, the check is incorrect because it doesn't account for Local
    Covers. There might be both a 1 x 1 pixel Amazon image and a local cover
    image, so the layout shouldn't be changed unless there are no images
    present.
    
    To test, apply the patch and view the bibliographic details page of
    various titles including:
    - Amazon cover present, no local cover
    - No Amazon cover, local cover image present
    - Both Amazon and local cover image
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 05c4248721cfcbb9967b42e2bacf1a82eb845f1a)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 7725c1f9daa604d29355513ad51a70031df6cb5c
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Mar 27 20:40:30 2020 +0000

    Bug 25007: Check for normaalized ISBN when building Amazon link
    
    TO RECREATE:
    -Have Amazon images turned on and local images too.
    -Have a record with a local cover image
    -Make sure the record has no ISBN in 020 field.
    -Load detail page of that record and see that the local cover images is
     not on the right hand side like it should be but forced underneath
     'catalogue_detail_biblio' in an odd spot.
    -Apply patch and reload page
    -The image should be back in its normal spot
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 8c09c5ee80d59aae134454375f260c47a6af2f16)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list