[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-59-ga6162e45fd

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  a6162e45fd89adae6cff599393d8f7905c00c505 (commit)
      from  ffdd8a78175b5afd22d8739cdf637716e56746e3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a6162e45fd89adae6cff599393d8f7905c00c505
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Apr 14 16:57:38 2020 +0000

    Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account
    
    When using sort1/sort2 with authorised values to create a pull down
    list, there will be no empty entry unless one is manually added to
    the authorised values list.
    
    This is not a good default behaviour, as it can easily
    cause errors on patron creation. Without the empty entry, the first
    alphabetic value is pre-selected and will be saved if not explicitly
    changed. It also doesn't allow to mark sort1/sort2 as mandatory,
    as the value is always 'set', the required message won't be triggered.
    
    This adds an empty parameter to av-build-dropbox.inc to allow selectively
    adding this empty entry without causing side-effects in other places
    this include is used.
    
    To test:
    - Create authorised values for either Bsort1 or Bsort2 authorised
      value category
    - Create a new patron:
      - you should see a pull down list on one and an input field for the other
      - for the pull down list, there will be no empty entry and the first
        alphabetic value will be preselected
    - Make your sort1 and sort2 mandatory using BorrowerMandatoryField
    - Verify there is still on empty entry
    - Apply patch
    - Repeat tests and verify that the behaviour is as expected
      - There should now be an empty entry
      - When the field is marked mandatory and empty is left, the required
        warning will be shown.
    
    Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit a934499b8cc192781f263b0ba2b3edd5374e64cf)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc     | 6 ++++--
 koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository