[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-67-g0fec1317e9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  0fec1317e9c3ff028141ac784c03a83850ac8772 (commit)
      from  6bbb4fc7c061839edb76f8ecee39f8fdb0732760 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0fec1317e9c3ff028141ac784c03a83850ac8772
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 12 03:19:03 2020 +0000

    Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields
    
    This is the same fix as on bug 14662, which fixed the behaviour in
    cataloguing, but for the item form in acquisitions.
    
    The code assumes that if a subfield is marked as mandatory, there
    should be no empty entry in the pull downs.
    
    This assumption is not correct, as it leads to the first entry of the
    pull down being preselected if there is no default set. As the field
    can never be 'unset', there will never be a 'required' warning.
    Furthermore, it might be counterproductive to use mandatory fields,
    as it might be easily forgotten to change the preselected value and
    those mistakes will be hard to find.
    
    Correct behaviour would be to preselect the empty value when there is
    no default. This means on saving the item an error message is triggered
    and the cataloger is forced to set the value.
    
    To test:
    - This is best tested with an ACQ framework, but default can be used
      when no ACQ framework was created.
    - In your MARC bibliographic framework:
      - In 952 make itemtype, classification source and some other pull downs
        like location or collection mandatory and set them to visibel if needed
    - Create a new basket with 'items created while ordering'
    - Add a new order, an existing record with 942$c set will work best
    - Add items for your order line
      - Verify that the first value of each pull down is preselected,
        there is no way to trigger the 'required' error
    - Apply patch
      - Add a new order line
        - Verify that classification source is preselected according to the
          DefaultClassificationSource system preference (try unsetting it later)
        - Verify all mandatory fields can be set to empty
        - Verify that you can't save before correctly setting them
      - Change your frameworks and set a default for itemtype (Ex: BK) and
        another mandatory and non-mandatory field of your choice
      - Add a new order line and item and verify the defaults are selected
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 77a59b5b3ab8a8870ca9bf9842d1ad30104a05d3)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository