[koha-commits] main Koha release repository branch master updated. v19.11.00-2213-g883b36da92
Git repo owner
gitmaster at git.koha-community.org
Fri May 15 11:26:09 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 883b36da925c25dff38a435f648491dbafb1a1a7 (commit)
via 741fa0b0065cf3309d02dc709292d71405f2260a (commit)
via 9ed284c0a49c280daf217240e03142ac701e8e06 (commit)
via 29f797b9808f513ca4ba662729f6a8a81edcda68 (commit)
via b720285bdba315944e303ef166e5c89c4c591ddf (commit)
via 23dd6651f83e42200185130bd340520ea2e945f1 (commit)
via d69ab6ee9185d124e8d282608e279d8590a6180f (commit)
via 0524f3b6d6a96e9016802a2a4d4ea3a27ef0d2fa (commit)
via 009007b8092d2973e66cbabd782613ee72265763 (commit)
via a81b9d3fadd5604cd2cabf44455d563b0f53e7a7 (commit)
via 2a216e206c13585308fbfb8897f78f9672bd81e0 (commit)
from 7e720e7e820408e7e2b7b03f65cbdd1435a2d031 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 883b36da925c25dff38a435f648491dbafb1a1a7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue May 12 10:49:51 2020 -0400
Bug 25468: Preserve line breaks in hold notes
In a hold note, line breaks are not preserved when viewing the note. A
note like:
--
Test 1
Test 2
--
will be rendered as:
--
Test 1 Test 2
--
Test Plan:
1) Place a hold with a note, use line breaks in the note.
2) Note the lines all run together when viewing the hold.
3) Apply this patch.
4) Reload the page.
5) Notes should now display with the original line breaks!
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 741fa0b0065cf3309d02dc709292d71405f2260a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 13 13:05:48 2020 +0200
Bug 25480: Don't hide apache error and display incorrect error
When searching if some apache mod are enable we are hiding the error (2> /dev/null) and display an error about the (guessed) missing module.
It can lead to wrong tracks, let display the original apache error if there is one.
This is linked with https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/119
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9ed284c0a49c280daf217240e03142ac701e8e06
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Apr 13 15:51:36 2020 +0000
Bug 23403: Catch other cases of ->{patron}
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 29f797b9808f513ca4ba662729f6a8a81edcda68
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 23 15:57:14 2020 +0100
Bug 23403: List borrowernumber in the ILS::Patron fields
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b720285bdba315944e303ef166e5c89c4c591ddf
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Mar 23 08:52:58 2020 -0400
Bug 23403: Fix whitespace
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 23dd6651f83e42200185130bd340520ea2e945f1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Nov 21 18:39:15 2019 +0100
Bug 23403: Remove cardnumber from SIP
== Test plan ==
1 - Have two patrons with userids and no cardnumber
2 - Note which of these has the higher borrower number
3 - Use the SIP cli emulator to connect and checkout a book to the patron with higher borrowernumber
See example after
4 - Note the book may checkout to the wrong patron!
5 - Apply patch
6 - Checkout to both patrons via sip
7 - The patrons get the correct checkouts
=== SIP CLI emulator ===
./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \
-l CPL --patron 23529001000463 -m checkout --item 39999000001259
translation: via the koha user term1, checkout item 39999000001259 to
patron 23529001000463
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d69ab6ee9185d124e8d282608e279d8590a6180f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 11 10:10:39 2020 -0300
Bug 24458: Use the ViewPolicy filter on search results
This patch implements the use of the ViewPolicy record processor filter
inside C4::Search::searchResults. The idea is that the $record_processor
is instantiated once and reused inside the loop. This leaves options for
further optimizations I will do on a follow-up bug.
The filter is applied to the MARC data before it is passed to the XSLT
processor.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Search.t
=> FAIL: This is not implemented, tests fail
3. Apply this patch
4. Repeat 2
5. Feel the joy in your body from a long standing bug being solved
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0524f3b6d6a96e9016802a2a4d4ea3a27ef0d2fa
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 11 10:08:36 2020 -0300
Bug 24458: Regression tests
This patch introduces tests for searchResults. The idea is to set a
subfield as hidden in OPAC and another on the staff interface, and see
if searchResults honours this on the XSLTResultsRecord contents.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Search.t
=> FAIL: This is not really implemented
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 009007b8092d2973e66cbabd782613ee72265763
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue May 12 09:09:22 2020 -0300
Bug 25416: (follow-up) Remove useless use statement
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a81b9d3fadd5604cd2cabf44455d563b0f53e7a7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 11 08:38:49 2020 -0300
Bug 25416: Unit tests
This patch adds tests for the new 'feature': i.e. searchResults passes
the added $xslt_variables to the XSLTParse4Display method.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2a216e206c13585308fbfb8897f78f9672bd81e0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 7 14:23:40 2020 -0300
Bug 25416: Let OPAC XSLTs know if the context is an anonymous session
This patch makes use of the 'variables' parameter in XSLTParse4Display
method in the different places that it is used in the OPAC. It does by
passing this parameter with
anonymous_session => 1|0
The value will depend on the output from get_template_and_user (i.e. if
there's a returned borrowernumber).
A special case takes place in search results, as the call to
XSLTParse4Display happens in C4::Search::searchResults. So a new
parameter 'xslt_variables' is added to it.
To test:
1. Apply the [DO NOT PUSH] patch
2. Open the OPAC in your browser
3. Try detail pages, search results, tags and lists/shelves pages with
or without an active session
=> FAIL: It always says (somewhere) 'Anonymous session: Yes'
4. Apply this patch, restart_all
5. Repeat 3
=> SUCCESS: It will tell the Yes/No correctly regarding anonymous
sessions!
6. Sign off :-D
Sponsored-by: Universidad ORT Uruguay
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/ILS.pm | 16 +++---
C4/SIP/ILS/Item.pm | 8 +--
C4/SIP/ILS/Patron.pm | 1 +
C4/SIP/ILS/Transaction/Checkout.pm | 44 ++++++++--------
C4/SIP/ILS/Transaction/Hold.pm | 39 +++++---------
C4/SIP/ILS/Transaction/Renew.pm | 3 +-
C4/Search.pm | 15 +++++-
debian/scripts/koha-create | 12 ++---
.../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +-
opac/opac-detail.pl | 11 ++--
opac/opac-search.pl | 6 ++-
opac/opac-shelves.pl | 14 +++--
opac/opac-tags.pl | 12 +++--
t/db_dependent/Search.t | 60 +++++++++++++++++++++-
14 files changed, 158 insertions(+), 85 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list