[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-86-g5872bc5a5b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  5872bc5a5b8789e5695db843577156bfc06ff64d (commit)
       via  2715cd95c0bd92d31aae07c3772258db9579666f (commit)
      from  3f4f576ba0195010d42d059e83528f8cf085acfd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5872bc5a5b8789e5695db843577156bfc06ff64d
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Apr 30 11:29:56 2020 +0000

    Bug 24043: (QA follow-up) Fix another TypeError when retrieving status name
    
    Test plan:
    1) Apply first patch, and have the same requests as in previous patch
    test plan
    2) Load ill requests list
    2a) You can see another TypeError in console
    2b) You can notice, the Placed on and Updated on columns have prepended
    another columns with unformatted dates and without header label
    3) Apply this patch
    4) Reload page (be sure it is not loaded from cache - Ctrl+F5)
    5) Errors from 2a and 2b are gone
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 243e94598e5f3d84b7b53b67c5bc38a1eecee5e0)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 2715cd95c0bd92d31aae07c3772258db9579666f
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Mon Jan 13 10:18:19 2020 +0000

    Bug 24043: Fix retrieval of of status name
    
    This patch modifies the way in which a request's status name is
    retrieved. I think the previous way it was done (which can never have
    worked properly) must have come from a time when we weren't embedding
    the request's backend capabilities in each request. So now we can just use
    the current row.
    
    Test plan:
    
    1. *Before applying the patch*:
    2. Ensure you have at least two requests, from two different backends.
    One of the backends you are using must have a possible status that
    doesn't exist in the other. For example, the BLDSS backend has a status
    of STAT, that doesn't not exist in any other backends.
    3. Ensure that the request who's backend has the unique status is *not*
    the first request in the returned list.
    4. Load the "View ILL requests" page
    5. Observe that the page JS fails with a "Cannot read property 'name' of
    undefined" error
    6. Apply the patch
    7. Reload the page (maybe doing a hard reload to ensure the JS is not
    cached)
    8. TEST: Observe that the error no longer occurs and the requests all
    have their statuses displayed correctly.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 40f4e9437cb012f93de7ac3b66bcb649617f13f5)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository