[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-91-gc8aaa47e82

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  c8aaa47e828dce6a9632dac671899aadff5a640d (commit)
       via  0283892d44189b9339f8e4eb230d936d329c9ee8 (commit)
      from  cacaebca32de1baa70a0e0ca57d3618a900d5046 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c8aaa47e828dce6a9632dac671899aadff5a640d
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Apr 29 17:57:44 2020 +0000

    Bug 21565: (follow-up) Make confirmation buttons more detailed
    
    This patch updates the confirmation buttons to be more specific about
    what each one does. My concern was that it wasn't clear that "No" meant
    "No receipt" and not "Cancel logging out."
    
    The patch also updates the modal confirmation code so that the modal
    body is removed if no message is passed for it.
    
    To test, apply the patch and repeat the previous test plan. When you
    click "Finish" you should have the options "Print receipt and end
    session" and "End session."
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e4e31117e7dcdc769f6c94553165202c49c7e0ae)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 0283892d44189b9339f8e4eb230d936d329c9ee8
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Apr 24 18:39:02 2020 +0000

    Bug 21565: Add modal to SCO confirm
    
    This patch uses the confirmModal framework to add a modal confirm to
    SCO Finish.
    
    TO TEST:
    
    1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure
       SelfCheckReceiptPrompt is set to 'show'
    2. Login and click 'Finish' to see the old print alert box.
    3. Apply patch and repeat steps 1 and 2.
    4. Make sure the modal works for confirming and denying a receipt.
       Checkout some items and make sure everything still functions the
       same.
    5. Make sure when printing a receipt that the print dialog automatally
       shows
    6. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is
       acceptable.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b325831210dacbb0857f843670eb26b0c5268e6d)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt      | 17 +++++++++++------
 koha-tmpl/opac-tmpl/bootstrap/js/global.js              |  8 ++++++--
 2 files changed, 17 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository