[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-93-gc8da8f1b64

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  c8da8f1b64776134402d76100e2b88c424283541 (commit)
      from  5a8cd7fc0d8acb1b0b01814442f6845e6df44ac2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c8da8f1b64776134402d76100e2b88c424283541
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Apr 27 13:20:23 2020 +0000

    Bug 22515: Improve logic determining how to show OPAC suggestions
    
    This patch makes changes to the OPAC suggestions view so that the logic
    around logged in users and the OPACViewOthersSuggestions preference is
    more specific.
    
    To reproduce the bug you should have pending purchase susggestions in
    your system from more than one patron.
    
    1. Set the OPACViewOthersSuggestions preference to "Show."
    2. Log in to the OPAC as a user who has not submitted any suggestions.
    3. Follow the link to the purchase suggestions page from the menu under
       the search bar.
    4. The page will say that there are no  purchase suggestions.
    5. Add "?suggested_by_anyone=1" to the end of the page URL.
    6. You should see suggestions from other users.
    
    To test, apply the patch and repeat steps 2-3 above. The suggestions
    page should show other patrons' suggestions.
    
    Test with different combinations of factors:
    
     - Logged in user, OPACViewOthersSuggestions off
     - No logged in user, OPACViewOthersSuggestions on
     - No logged in user, OPACViewOthersSuggestions off
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 93f37f3a03fc1205b3c3cb54e650081dc3dd79ea)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc |  6 ++----
 .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 18 +++++++++++++++---
 2 files changed, 17 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository