[koha-commits] main Koha release repository branch master updated. v19.11.00-2236-g067aa1c5f7
Git repo owner
gitmaster at git.koha-community.org
Mon May 18 16:56:53 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 067aa1c5f731bc9eac40ff53e6c3be2e58ef1c0f (commit)
via 0899d99b7c2ce5920664f4d4710869b2f0d25b81 (commit)
via 3f4ae28cd8de3ae60ab85bc914840a59ae4b1ec2 (commit)
via f04129ca45171f8e9c115ca8e25b7dc4b9f9686e (commit)
via 48ea8edb6188045f24aa3508a4fdb209369b1720 (commit)
via 68bcc31dfcdfd48614843ff27a4594a69ef95ed7 (commit)
via 0a24e721dda54e67759c7c10d956ee63da6b8ec5 (commit)
via 8371d10fa5639690a3deb77b64f8079325993ff4 (commit)
via 05705ab2ad12aff3627eb53e7e4d56d6a4b20bcd (commit)
via 48e3e6aafb04fbe6eea33da8550c9952a3f52a11 (commit)
from 5117fab4890f86b8f11a129485917db3d357b920 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 067aa1c5f731bc9eac40ff53e6c3be2e58ef1c0f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri May 15 11:46:07 2020 +0000
Bug 25278: add clear_search_fields_cache method
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0899d99b7c2ce5920664f4d4710869b2f0d25b81
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Apr 27 14:05:46 2020 +0000
Bug 25278: (follow-up) Fix other occurrences
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3f4ae28cd8de3ae60ab85bc914840a59ae4b1ec2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 24 15:52:50 2020 +0000
Bug 25278: Retrieve correct search fields for authorities
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f04129ca45171f8e9c115ca8e25b7dc4b9f9686e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 24 16:32:06 2020 +0000
Bug 25278: Unit tests
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 48ea8edb6188045f24aa3508a4fdb209369b1720
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 24 16:08:44 2020 +0000
Bug 25277: Unit test
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 68bcc31dfcdfd48614843ff27a4594a69ef95ed7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 24 13:34:31 2020 +0000
Bug 25277: Don't specify a field in query if none passed
== test plan ==
To test:
0 - Have Koha running with ES 6 enabled
1 - Launch the z3950 responder:
perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug
2 - Connect using yaz-client:
yaz-client localhost:2100
2.1 Alternative, if you add the responder as a Z39.50 server in Koha and
do a catalogue Z39.50 search. Don't forget to search in the keywords
field. Not the title field.
3 - base biblios
4 - find bruce
5 - No results
6 - Stop the responder
7 - Apply patch
8 - Repeat
9 - This time you get results
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0a24e721dda54e67759c7c10d956ee63da6b8ec5
Author: Phil Ringnalda <phil at chetcolibrary.org>
Date: Tue Apr 28 17:16:51 2020 -0700
Bug 25308: Escape querystring for Z39.50 popup from cataloging
Test plan:
1. For bonus fun, Administration -> MARC Frameworks -> New framework,
with the code A&B and description Ants & Bees
2. In the A&B Actions menu, choose MARC structure since Import won't
work
3. Accept the offer to copy in structure from default
4. Cataloging -> New record -> Ants & Bees
5. Type This & That in the 245$a (and for extra credit, in 020$a, and
create an author authority with an & in it so you can put it in the
100/110)
6. Click Z39.50/SRU search, make sure everything you typed is prefilled
including the parts after &
7. Search for anything that will retrieve a record (the ISBN This &
That probably won't), choose Import
8. Check that the record came back, and verify in the Settings menu that
it's still in the Ants & Bees framework.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8371d10fa5639690a3deb77b64f8079325993ff4
Author: Phil Ringnalda <phil at chetcolibrary.org>
Date: Fri Apr 24 11:34:29 2020 -0700
Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin
While adding the data from the existing field to the auth_finder URI,
we're using encodeURI(), which is meant for an entire URI and thus
doesn't escape &. Things that are going into a querystring need
encodeURIComponent() instead.
Test plan:
1. Enable the system preference EnableAdvancedCatalogingEditor
2. Clear your browser cache, even a shift+reload won't get you a fresh
marc-editor.js for the advanced editor
3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk
4. In the Basic editor, use the authority plugin on the 650 field to
select that authority.
5. Click the authority plugin again, verify that the popup contains This
& That and Stuff & Junk rather than just This and Stuff
6. From the Cataloging home page choose Advanced editor
7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk
8. Type ctrl+shift+L and verify the popup shows both words in both
fields
9. When you remember the plugin exists there too, edit your
Stuff & Junk authority, and in a 550 tag type One & Two in
$a and Three & Four in $x and click the plugin link, verify that
the search window has your search terms not cut off.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 05705ab2ad12aff3627eb53e7e4d56d6a4b20bcd
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 18 09:26:09 2020 -0300
Bug 25527: Add logger to Koha::ExternalContent
This patch makes Koha::Logger initialization happen in the ->new method
for the Koha::ExternalContent-derived classes. In the case of RecordedBooks,
it doesn't look like it is used at all.
In the case of OverDrive, it will now use the Koha::ExternalContent
exported logger accessor.
I added tests for this addition to Koha::ExternalContent to the
OverDrive tests.
I also removed references to Test::DBIx::Class as it is not used at all.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha_ExternalContent_OverDrive.t
=> SUCCESS: Tests pass!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 48e3e6aafb04fbe6eea33da8550c9952a3f52a11
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 18 09:23:42 2020 -0300
Bug 25527: Initialize the logger when required
In an OO package, the logger initialization should happen in the
constructor. This is not an OO package and the initialization is
happening on loading it. This is a wrong behaviour and certainly breaks
in environments where initialization cannot happen (package building,
for example). There could be several options to solve this, as it is
used in a single sub on this package, I opted for initializing on that
sub.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/ImportBatch.pm | 4 +-
Koha/ExternalContent.pm | 6 ++-
Koha/ExternalContent/OverDrive.pm | 4 +-
Koha/ExternalContent/RecordedBooks.pm | 3 --
Koha/SearchEngine/Elasticsearch.pm | 22 ++++++--
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +-
Koha/Z3950Responder/RPN.pm | 13 +++--
admin/searchengine/elasticsearch/mappings.pl | 4 +-
etc/z3950/attribute_mappings.yaml | 2 -
.../lib/koha/cateditor/marc-editor.js | 2 +-
.../prog/en/modules/cataloguing/addbiblio.tt | 4 +-
koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 +-
.../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 44 +++++++++++++---
.../Koha/SearchEngine/Elasticsearch/Reset.t | 4 +-
.../Koha/Z3950Responder/GenericSession.t | 7 ++-
t/db_dependent/Koha_ExternalContent_OverDrive.t | 61 +++++++++++-----------
16 files changed, 114 insertions(+), 70 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list