[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-225-g5f8d94c98a

Wed May 20 01:57:43 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  5f8d94c98a1f8df817fb4df07574fc20ee125107 (commit)
       via  301488f66dd81ba5d585400a41b4c58d893bc744 (commit)
       via  07eefd07b635cc50b5210bccf5c56e283db63680 (commit)
       via  c42e3d94ac42389b6ede92bb56cc1e2288c9fa00 (commit)
       via  d8b49065d1b86cb49e9c894db5640d4eb33db4c6 (commit)
       via  dcae6b8b940df6855e1200aedcafe3b2978146c2 (commit)
      from  359b9f2029a8171d673bbc84d21797283822b7e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5f8d94c98a1f8df817fb4df07574fc20ee125107
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Feb 20 17:15:57 2020 +0000

    Bug 23727: (QA follow-up) Fix for boolean flags

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 301488f66dd81ba5d585400a41b4c58d893bc744
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Feb 20 17:10:49 2020 +0000

    Bug 23727: (QA follow-up) Fix script tags

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 07eefd07b635cc50b5210bccf5c56e283db63680
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 14 15:22:17 2020 -0500

    Bug 23727: Editing course reserve items is broken

    Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged".

    This patch set adds two new sets of columns to the course_items table.

    The first set determines if the specified column should be swapped or
    not. The was previously 'implied' by the column being set to undef which
    has been the root problem with that way of knowing if a column should
    swap or not.

    The second set of new columns are for storing the item field values
    while the item is on course reserve. Previously, the column values
    were swapped between the items table and the course_items table,
    which leaves ambiguity as to what each value is. Now, the original
    columns *always* store the value when the item is on course reserve,
    and the new storage columns store the original item value while the
    item is on reserve, and are NULL when an item is *not* on reserve.

    Test Plan:
    1) Apply this patch
    2) Add and edit course items, not the new checkboxes for enabling fields
    3) Everything should function as before

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit c42e3d94ac42389b6ede92bb56cc1e2288c9fa00
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 14 08:57:05 2020 -0500

    Bug 23727: Add Koha Object(s) related to course reserves

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit d8b49065d1b86cb49e9c894db5640d4eb33db4c6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 14 08:45:11 2020 -0500

    Bug 23727: Update Schema

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit dcae6b8b940df6855e1200aedcafe3b2978146c2
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 14 08:41:28 2020 -0500

    Bug 23727: Add new columns

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/CourseReserves.pm                               | 172 +++++++++++----------
 Koha/{Tag.pm => Course.pm}                         |   6 +-
 Koha/{Tags/Approval.pm => Course/Instructor.pm}    |   6 +-
 Koha/{Tags/Approvals.pm => Course/Instructors.pm}  |  10 +-
 .../Routinglist.pm => Course/Item.pm}              |  51 +++---
 Koha/{Tags.pm => Course/Items.pm}                  |  10 +-
 Koha/{Tag.pm => Course/Reserve.pm}                 |   6 +-
 Koha/{ApiKeys.pm => Course/Reserves.pm}            |  13 +-
 Koha/{Tags.pm => Courses.pm}                       |  10 +-
 Koha/Schema/Result/CourseItem.pm                   |  74 ++++++++-
 course_reserves/add_items.pl                       |  32 +++-
 course_reserves/batch_add_items.pl                 |  19 ++-
 installer/data/mysql/atomicupdate/bug_23727.perl   |  69 +++++++++
 installer/data/mysql/kohastructure.sql             |   8 +
 .../en/modules/course_reserves/add_items-step2.tt  |  91 +++++++++--
 .../en/modules/course_reserves/batch_add_items.tt  |  41 +++--
 .../en/modules/course_reserves/course-details.tt   |  24 ++-
 t/db_dependent/CourseReserves/CourseItems.t        | 101 +++++++-----
 18 files changed, 514 insertions(+), 229 deletions(-)
 copy Koha/{Tag.pm => Course.pm} (91%)
 copy Koha/{Tags/Approval.pm => Course/Instructor.pm} (87%)
 copy Koha/{Tags/Approvals.pm => Course/Instructors.pm} (81%)
 copy Koha/{Subscription/Routinglist.pm => Course/Item.pm} (63%)
 copy Koha/{Tags.pm => Course/Items.pm} (84%)
 copy Koha/{Tag.pm => Course/Reserve.pm} (88%)
 copy Koha/{ApiKeys.pm => Course/Reserves.pm} (83%)
 copy Koha/{Tags.pm => Courses.pm} (87%)
 create mode 100644 installer/data/mysql/atomicupdate/bug_23727.perl

hooks/post-receive
-- 
main Koha release repository