[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-235-ged219bda7e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  ed219bda7e0ff0cbd888c2c8c4318201472fb17d (commit)
       via  1d0bcbac9aa24f89d146133fd017100238d4c0db (commit)
       via  22825f95811d679cae0f87fdc0b6cdef3a2db264 (commit)
       via  60d890a2b70cc0a15e985d9044ac18ce72a7ce7f (commit)
      from  c441ee3c3f98a03e9abb5508385d9bf385f9761e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ed219bda7e0ff0cbd888c2c8c4318201472fb17d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 29 14:57:57 2020 +0200

    Bug 25309: Limit size of streetnumber field to 10
    
    It's its size in DB (varchar(10))
    
    Test plan:
    Create or editing a patron and confirm that you fill in more than 10
    characters in the streetnumber field
    Save
    => The patron has been correctly created/updated
    
    Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 1d0bcbac9aa24f89d146133fd017100238d4c0db
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Fri May 1 22:04:15 2020 +0000

    Bug 25311: (QA follow-up) Add misssing filter
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 22825f95811d679cae0f87fdc0b6cdef3a2db264
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 29 14:48:38 2020 +0200

    Bug 25311: Better error handling when updating a patron
    
    Same as the precedent patch for patron's modification
    
    Test plan is identical but with an existing patron
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 60d890a2b70cc0a15e985d9044ac18ce72a7ce7f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 29 14:38:41 2020 +0200

    Bug 25311: Better error handling when creating a patron
    
    This is still not ideal but brings a bit of enhancement.
    
    One possible problem is that the patron creation will fail if the
    streetnumber field is too long (borrowers.streetnumber is varchar(10).
    
    Test plan:
    0. Don't apply this patch
    1. Create a new patron with a streetnumber longer than 10 characters
    2. Save
    => The patron has not been created and the app explodes
    The error is about extended_attributes and not meaningful
    Can't call method "extended_attributes" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 560
    3. Apply the patch
    4. Repeat 1. and 2
    => You get a warning on the interface and you still see the creation
    form
    5. Check the logs
    => The error is meaningful
    "Data too long for column 'streetnumber'"
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../en/includes/member-main-address-style-de.inc   |   2 +-
 .../en/includes/member-main-address-style-fr.inc   |   2 +-
 .../en/includes/member-main-address-style-us.inc   |   2 +-
 .../prog/en/modules/members/memberentrygen.tt      |  13 +++
 members/memberentry.pl                             | 125 ++++++++++++---------
 5 files changed, 88 insertions(+), 56 deletions(-)


hooks/post-receive
-- 
main Koha release repository