[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-242-g4178233de1
Git repo owner
gitmaster at git.koha-community.org
Wed May 20 23:18:28 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 (commit)
via 0ab0f61657d7a93b5eab1fe4327b7254c10032e3 (commit)
from dbcae29fa74f592deb8ef638179eae1bd451c076 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon May 11 08:38:49 2020 -0300
Bug 25416: Unit tests
This patch adds tests for the new 'feature': i.e. searchResults passes
the added $xslt_variables to the XSLTParse4Display method.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 0ab0f61657d7a93b5eab1fe4327b7254c10032e3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 7 14:23:40 2020 -0300
Bug 25416: Let OPAC XSLTs know if the context is an anonymous session
This patch makes use of the 'variables' parameter in XSLTParse4Display
method in the different places that it is used in the OPAC. It does by
passing this parameter with
anonymous_session => 1|0
The value will depend on the output from get_template_and_user (i.e. if
there's a returned borrowernumber).
A special case takes place in search results, as the call to
XSLTParse4Display happens in C4::Search::searchResults. So a new
parameter 'xslt_variables' is added to it.
To test:
1. Apply the [DO NOT PUSH] patch
2. Open the OPAC in your browser
3. Try detail pages, search results, tags and lists/shelves pages with
or without an active session
=> FAIL: It always says (somewhere) 'Anonymous session: Yes'
4. Apply this patch, restart_all
5. Repeat 3
=> SUCCESS: It will tell the Yes/No correctly regarding anonymous
sessions!
6. Sign off :-D
Sponsored-by: Universidad ORT Uruguay
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Search.pm | 4 ++--
opac/opac-detail.pl | 11 ++++++++---
opac/opac-search.pl | 6 ++++--
opac/opac-shelves.pl | 14 +++++++++++---
opac/opac-tags.pl | 12 +++++++++---
t/db_dependent/Search.t | 12 +++++++++++-
6 files changed, 45 insertions(+), 14 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list