[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-257-g0c238db2f5

Thu May 21 23:18:00 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  0c238db2f5763db48fe3d451b599ffd6b0e42869 (commit)
       via  6066bb39a5ed9b284bf2344e4b98394e89f809a3 (commit)
       via  b0551cfd178565b5b30980096f53d4fffcfca454 (commit)
       via  403c2a4753db50897370442f907438357bc5f03b (commit)
       via  840b417890cdd341922cb3a086b08946bb96736d (commit)
       via  20a6b0f7dbe6db1f5b47b8bb7371b7b0cd192062 (commit)
       via  dbc4e4c63d83beed132a4d9b20ef47b2327f4f67 (commit)
       via  7e4296c4194afaa722a20b114cf928e2f17d7ad0 (commit)
      from  40f8cba93b5ec052fd0de1f41a85d5f03dd3a147 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0c238db2f5763db48fe3d451b599ffd6b0e42869
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 18 17:50:11 2020 +0200

    Bug 25531: Debar patron if needed when checkin is backdated

    If think this case does not apply to real-life, but the logic needs to
    be fixed.
    If an item is due now, and AddReturn is called now with a return date in
    the future, the issue is overdue and the patron must be debarred.
    However it is not as we compare with now and not the return date

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 6066bb39a5ed9b284bf2344e4b98394e89f809a3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 18 17:49:37 2020 +0200

    Bug 25531: Add tests

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b0551cfd178565b5b30980096f53d4fffcfca454
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 16 17:19:22 2020 +0100

    Bug 24881: [19.11.x] Try to fix random failure from Circulation.t

    This is a follow-up of bug 22917.

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 403c2a4753db50897370442f907438357bc5f03b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 14 16:04:20 2020 +0200

    Bug 25481: Pass --user to start-stop-daemon when a pidfile is used

    Since D10, the behaviour of start-stop-daemon changed, see from its
    manual:
    """
    Warning:  using this match option with a world-writable pidfile or using it alone with a daemon that writes the pidfile as an unprivileged (non-root) user will be refused with an error (since
    version 1.19.3) as this is a security risk, because either any user can write to it, or if the daemon gets compromised, the contents of the pidfile cannot be trusted, and  then  a  privileged
    runner (such as an init script executed as root) would end up acting on any system process.  Using /dev/null is exempt from these checks.
    """

    Test plan:
    koha-plack --restart kohadev
    should success with this patch.
    Without this patch you get:
    start-stop-daemon: matching only on non-root pidfile /var/run/koha/kohadev/plack.pid is insecure

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 840b417890cdd341922cb3a086b08946bb96736d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 13 15:51:36 2020 +0000

    Bug 23403: Catch other cases of ->{patron}

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 20a6b0f7dbe6db1f5b47b8bb7371b7b0cd192062
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 23 15:57:14 2020 +0100

    Bug 23403: List borrowernumber in the ILS::Patron fields

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit dbc4e4c63d83beed132a4d9b20ef47b2327f4f67
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Mar 23 08:52:58 2020 -0400

    Bug 23403: Fix whitespace

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 7e4296c4194afaa722a20b114cf928e2f17d7ad0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 21 18:39:15 2019 +0100

    Bug 23403: Remove cardnumber from SIP

    == Test plan ==
    1 - Have two patrons with userids and no cardnumber
    2 - Note which of these has the higher borrower number
    3 - Use the SIP cli emulator to connect and checkout a book to the patron with higher borrowernumber
          See example after
    4 - Note the book may checkout to the wrong patron!
    5 - Apply patch
    6 - Checkout to both patrons via sip
    7 - The patrons get the correct checkouts

    === SIP CLI emulator ===
    ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \
    -l CPL --patron 23529001000463 -m checkout --item 39999000001259

    translation: via the koha user term1, checkout item 39999000001259 to
    patron 23529001000463

    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                  |  2 +-
 C4/SIP/ILS.pm                      | 16 ++++----
 C4/SIP/ILS/Item.pm                 |  8 ++--
 C4/SIP/ILS/Patron.pm               |  1 +
 C4/SIP/ILS/Transaction/Checkout.pm | 22 +++++-----
 C4/SIP/ILS/Transaction/Hold.pm     | 39 ++++++------------
 C4/SIP/ILS/Transaction/Renew.pm    |  3 +-
 debian/scripts/koha-functions.sh   |  2 +
 debian/scripts/koha-plack          |  2 +-
 t/db_dependent/Circulation.t       | 82 +++++++++++++++++++++++---------------
 10 files changed, 90 insertions(+), 87 deletions(-)

hooks/post-receive
-- 
main Koha release repository