[koha-commits] main Koha release repository branch master updated. v19.11.00-2298-g0b5a8f6c19

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0b5a8f6c19c2705ed72c57185aee12b1333cf5ae (commit)
       via  652b0ec817e1c3e9d25c9a2945c721c8cb896cf8 (commit)
      from  fc0292195bc9d85159dbd5fae6cfaf57f7d55115 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0b5a8f6c19c2705ed72c57185aee12b1333cf5ae
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 26 14:41:04 2020 +0200

    Bug 20116: Fix package install path for clear_cache.pl
    
    root at koha-debian10:~# koha-translate --install es-ES
    /bin/bash: /usr/share/koha/misc/bin/clear_cache.pl: No such file or directory
    
    The script is in /usr/share/koha/bin/clear_cache.pl
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 652b0ec817e1c3e9d25c9a2945c721c8cb896cf8
Author: Petro Vashchuk <stalkernoid at gmail.com>
Date:   Mon May 25 17:39:58 2020 +0300

    Bug 25556: fix for unnecessary empty name/value pairs creation
    
    During the web-install onboarding process, when the default circulation rule gets created, "circulation_rules" table gets populated with empty rule_name/rule_value items. This behavior differs from how the "unset" button on the smart-rules.pl page in "Default checkout, hold and return policy" group acts and leads to unpredictable bug when empty "holdallowed" rule_name prevents holds from any user.
    This fix removes creation of these empty name/value pairs.
    
    To reproduce:
        1) Start with an empty installation (or delete all circulation rules and press "unset" in hold and return policy section on /cgi-bin/koha/admin/smart-rules.pl page). This is to have the circulation_rules table empty so onboarding.pl will work.
        2) Go through the onboarding.pl process and create a default circulation rule.
        3) Make sure that circulation_rules table contains will contain empty "patron_maxonsiteissueqty", "max_holds", "patron_maxissueqty", "returnbranch", "holdallowed" and "hold_fulfillment_policy" fields.
        4) Apply the patch.
        5) Repeat steps 1 and 2.
        6) Observe that there are none of six mentioned above name/value pairs appeared.
    
    To reproduce the bug with empty "holdallowed" rule_name:
        1) Repeat steps 1, 2 and 3 that are listed in the previous instruction of reproduction, in order to get empty "holdallowed" field.
        2) Find existing or create a new book with available status and place a holding on it.
        3) Observe the yellow notification window with "Cannot place hold. No items are available to be placed on hold." warning.
        4) Apply the patch.
        5) Repeat steps 1 and 2.
        6) Observe that hold was successfully placed and yellow notification does not appear anymore.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 debian/scripts/koha-translate |  2 +-
 installer/onboarding.pl       | 22 ----------------------
 2 files changed, 1 insertion(+), 23 deletions(-)


hooks/post-receive
-- 
main Koha release repository