[koha-commits] main Koha release repository branch master updated. v19.11.00-2310-ga7778ed858

Fri May 29 12:15:00 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a7778ed8586b00bdf79dbd5db02c525d108ea8ea (commit)
       via  7b1e8c59fe0edc2faab878c6bd9d45de9f720e81 (commit)
       via  46e23b3a035e9c326c50aaa2dfba62667a9aca4b (commit)
       via  dd0c7c55fc2b5f0a312055d0c051b166d75ea82d (commit)
       via  a79cf4150e8a08e743acc7d7147af91757d7a9b8 (commit)
       via  9d8f9f1d3b0a10bc677904cd39764acbf4f75e13 (commit)
       via  f1cc9d6b599ae423d8024fb11f3f601d57ab9963 (commit)
       via  218322597e7a7104a15229e333ae7c1a917a675c (commit)
       via  051b2d014241ea6f71084227b05023808cff0212 (commit)
       via  6b1a53da6d38e5bba7317e8b24be1df501ed0db0 (commit)
       via  84230706499b4673d9061adc2d2ac025fa31a342 (commit)
       via  5818d900e8e7927bc437dc60cd992c6a18ceb16f (commit)
      from  0b5a8f6c19c2705ed72c57185aee12b1333cf5ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a7778ed8586b00bdf79dbd5db02c525d108ea8ea
Author: Devinim <kohadevinim at devinim.com.tr>
Date:   Fri May 22 22:11:31 2020 +0000

    Bug 25592: Add Devinim to about page

    This adds Devinim to the 'Contributing companies and
    institutions' section on Koha's about page.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7b1e8c59fe0edc2faab878c6bd9d45de9f720e81
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 28 15:30:02 2020 +0200

    Bug 25618: Fix wrong package install path for misc dir

    root at koha-debian9:/# koha-z3950-responder --start d9
    [....] Starting Z39.50/SRU daemon for d9:Can't open perl script "/usr/share/koha/bin/z3950_responder.pl/z3950_responder.pl": Not a directory
     failed!

    Test plan:
    On a dev install, copy the debian script and run it
    Same on a package install

    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 46e23b3a035e9c326c50aaa2dfba62667a9aca4b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu May 28 17:37:20 2020 +0000

    Bug 25617: (QA follow-up) Add responses to tests

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit dd0c7c55fc2b5f0a312055d0c051b166d75ea82d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 28 16:12:57 2020 +0200

    Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0

    There was an error in the precedent code, in 12hr format, 12PM is
    actually 00:00

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a79cf4150e8a08e743acc7d7147af91757d7a9b8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri May 22 14:29:20 2020 +0200

    Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON

    This patch removes a problematic integer casting happening in TO_JSON.
    The original need for this cast (a DBD::mysql bug) is now fixed. We
    remove the cast as it is causing random failures.

    To test:
    1. Apply the regression tests
    2. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/acquisitions_orders.t
    => FAIL: Tests fail with select high values (i.e. casting gives wrong
            results)
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests now pass!
    5. Sign off :-D

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9d8f9f1d3b0a10bc677904cd39764acbf4f75e13
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed May 27 09:55:16 2020 -0300

    Bug 25513: Regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f1cc9d6b599ae423d8024fb11f3f601d57ab9963
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 26 10:10:52 2020 +0200

    Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch"

    returnbranch has to pass an itemtype key when setting the rule (here
    setting it to unlimited for any item types)

    Test plan:
    1. Go the "Circulation and fine rules" admin page
    2. Set a rule for "Default checkout, hold and return policy"
    3. Unset it
    4. Select a library
    5. Set a rule for "Default checkout, hold and return policy"
    6. Unset it

    Display should be consistent with what you selected

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 218322597e7a7104a15229e333ae7c1a917a675c
Author: Didier Gautheron <didier.gautheron at biblibre.com>
Date:   Wed May 27 04:18:58 2020 +0200

    Bug 25608: (bug 23463 follow-up) Fix inventory regression

    Follow-up work
      commit bbb504c86f5ca0a474365d4839177412f415c4ee
      Bug 23463: Replace ModItem with Koha::Item->store

    Test plan :
        - Create a biblio with default framework
        - Create an item with barcode='000AAA1', callnumber='ZZZAAA1'
        - Create an item with barcode='000AAA2', callnumber='ZZZAAA2'
        - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2'
        - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl
        - Choose file in 'Barcode file'
        - Enter item callnumber between 'ZZZ' and 'ZZZa'
        - Check 'Compare barcodes list to results'
        - Submit
        => without patch, you get an error trace
        - Apply patch, it works

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Amended commit title.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 051b2d014241ea6f71084227b05023808cff0212
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed May 27 06:28:40 2020 -0400

    Bug 25444: More minor improvements to simplified loop

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6b1a53da6d38e5bba7317e8b24be1df501ed0db0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 27 10:25:15 2020 +0200

    Bug 25444: Simplify the code using a loop

    In order to prevent typos or further regressions it is better (I think)
    to have this code into a loop

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 84230706499b4673d9061adc2d2ac025fa31a342
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue May 26 09:08:15 2020 -0400

    Bug 25444: Backup/restore course items fields correctly

    This patch makes the code set the *_storage fields when adding new
    fields to an existing course item. And reverts those fields correctly
    when removing the item from the course.

    If a new field is enabled on an existing course reserve, the storage
    field is not given a value, so when the item goes off reserve, the
    item field will always be updated to NULL.

    To test:
    1. Apply the regression tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/CourseReserves/CourseItems.t
    => FAIL: Tests fail, data is not reverted correctly
    3. Apply this patch and repeat 2
    => SUCCESS: Tests pass! Data is correctly reverted
    4. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 5818d900e8e7927bc437dc60cd992c6a18ceb16f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue May 26 13:04:11 2020 -0400

    Bug 25444: Add unit tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/CourseReserves.pm                             |  38 +++++--
 Koha/DateUtils.pm                                |   9 +-
 Koha/Object.pm                                   |   9 --
 admin/smart-rules.pl                             |   3 +-
 debian/scripts/koha-z3950-responder              |   8 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt |   1 +
 t/DateUtils.t                                    |  27 ++++-
 t/db_dependent/CourseReserves/CourseItems.t      | 133 ++++++++++++++++++++++-
 t/db_dependent/api/v1/acquisitions_orders.t      |  19 +++-
 tools/inventory.pl                               |   7 +-
 10 files changed, 220 insertions(+), 34 deletions(-)

hooks/post-receive
-- 
main Koha release repository