From gitmaster at git.koha-community.org Mon Nov 2 11:35:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Nov 2020 10:35:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1533-g48b1e28015 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 48b1e28015ba9928b558a3507c0e1887242d7ef8 (commit) via 8a23d322811daf79825c01cc1ccb76d6cd10abff (commit) via 1f1b5318589e5951f0dbf57fc7f3374c38bb26de (commit) via 7aeb13461d4d618dc698c5ff3d32757394e87b5e (commit) via 95f4014f045d00c9372f04fb3b8cbb52647802e2 (commit) via c52a9e4cf362949192d3d58adab287cd82effbf1 (commit) via 8dd8f3e5a3fcae140ec58af6c59d831512ae4ae1 (commit) via daca3478f48ece4f92957eb4b4638d5aa18844a5 (commit) via 190f7155f1e9b3100a0dfb91279228033fc28546 (commit) via d2af19dd31d0846ee0c852304b01f1d060e0ba48 (commit) via 7bbf4f7b5fe54a46d2c54a4dc445a0400dfbef23 (commit) via e1a5fc85a6b829f93d8cc84cc7fb474016e8df61 (commit) via dc4639b3f72c84cea3aa950f8350bdfb1f534a80 (commit) via bc0c687ca5e20447ff72917cf1c2734f580ac7a2 (commit) via 3fd7d5974a0952ea4cf677ca83c18db46e637b5a (commit) via 0ee41b53168c3a5275533a731160b643909cd110 (commit) via 6e37dcafee872cdea378ba845ef49d702a3fbfc5 (commit) via dc71c1ee48194574493d1b6b4488a09c649692d8 (commit) via 36342731edd05df2f7ff64964e439c3e38aa82ae (commit) via 6d361af6423cfd605519c4e9302c43f34c352d08 (commit) via ddc3459ba5e72f0619a42dacd0f027998f6d3f81 (commit) via 4d92e3d284e392ad681b095c02965fe57a85a5a1 (commit) via 59588c3a3e3390c2796ac417696829fd26fcb4f0 (commit) via 74605e72aa74524984f0411f8db6fd55f2f12148 (commit) from 1c46ebbb2e9728ff9f466eaba48af53840ff4a27 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48b1e28015ba9928b558a3507c0e1887242d7ef8 Author: Lisette Scheer Date: Tue Oct 27 15:39:38 2020 +0000 Bug 26724: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8a23d322811daf79825c01cc1ccb76d6cd10abff Author: Alex Buckley Date: Sat Oct 24 17:13:14 2020 +0000 Bug 13701: Remove hardcoded "two weeks" text from list share confirmation Test plan: 1. Enable the OpacAllowSharingPrivateLists system preference 2. Create a private list and add items to it 3. In the OPAC click on the private list name and select 'Share list' 4. Input an email address and observe the text: "You will receive an email notification if someone accepts your share within two weeks." 5. Apply patch 6. Restart services 7. Repeat step 3 & 4 and observe the text now displays: "You will receive an email notification if someone accepts your share before it expires." Sponsored-By: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 1f1b5318589e5951f0dbf57fc7f3374c38bb26de Author: Séverine QUEUNE Date: Fri Oct 30 18:12:56 2020 +0100 Bug 25700: (follow-up) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 7aeb13461d4d618dc698c5ff3d32757394e87b5e Author: Martin Renvoize Date: Thu Oct 22 08:58:15 2020 +0100 Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 95f4014f045d00c9372f04fb3b8cbb52647802e2 Author: Séverine QUEUNE Date: Wed Oct 21 18:13:30 2020 +0200 Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c52a9e4cf362949192d3d58adab287cd82effbf1 Author: Phil Ringnalda Date: Fri Oct 2 14:52:57 2020 -0700 Bug 26605: Correctly URI-encode query string in call number browse plugin If you search for a call number like "M KRUEGER CO #11" in the cn_browser.pl plugin, your query is cut off at "M KRUEGER CO " because the hash isn't escaped, so the browser thinks you are opening a window and trying to navigate to the element with the id 11 rather than passing the #11 to the server. To test: 1) Find the record you will use to test, determing the MARC framework it uses by going to Edit > Edit record > Settings 2) In Administration > MARC bibliographic framework, click MARC structure in the Actions menu for that framework 3) Navigate to the 952 tag, in the Actions menu click Edit subfields 4) In the tab for o, choose the Plugin cn_browser.pl and click Save Changes 5) Click the Edit button next to one of the items on your record 6) In the Full call number field, add " CO #11" to the call number 7) Click the ... next to the field to open the Tag editor 8) In the popup window, verify that the search field includes the " CO #11" you added to the call number Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8dd8f3e5a3fcae140ec58af6c59d831512ae4ae1 Author: David Cook Date: Fri Oct 16 00:59:58 2020 +0000 Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in libnet-stomp-perl is added to debian/control via __AUTODEPENDS__, so we don't need to add it manually into debian/control.in Signed-off-by: Mason James Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit daca3478f48ece4f92957eb4b4638d5aa18844a5 Author: Lisette Scheer Date: Sat Oct 24 18:18:54 2020 +0000 Bug 26723: Improve link text on OverDriveAuthName system preference The OverDriveAuthName system preference contains a link labeled "here" to a seperate administration page that should be labeled better. This patch renames the link. To test: 1. Go to administration 2. Search the system preferences for OverDriveAuthName 3. Obeserve the "here" link in the preference. 4. Apply the patch. 5. Repeat steps 1-2. 6. Observe the new link text. 7. Sign off. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 190f7155f1e9b3100a0dfb91279228033fc28546 Author: Owen Leonard Date: Mon Oct 26 11:55:57 2020 +0000 Bug 26816: Chomp whitespace around i18n strings This patch adds the chomp shorthand [%- -%] to the output of i18n.inc to prevent extra spaces from being inserted. To test, apply the patch and perform a catalog search in the staff interface which will return results with multiple items. In the items column, the availability information should not have unwanted spaces: 3 items, 3 available: ...instead of 3 items , 3 available: Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d2af19dd31d0846ee0c852304b01f1d060e0ba48 Author: Owen Leonard Date: Tue Oct 27 13:50:12 2020 +0000 Bug 26833: Logged in library doesn't show with suggestions count This patch corrects the template variables used by the suggestions counts shown on the staff interface home page and the acquisitions home page. They should use [% Branches.GetLoggedInBranchname %] To test you should have some suggestions from multiple libraries. - Log in to the staff interface. - On the home page you should see "Suggestions pending approval," followed by the name of your logged-in library and the count of suggestions for your library. - Go to the acquisitions page. - In the "Pending suggestions" section you should see the same information: Your logged-in library name, suggestion count, and the count of suggestions at all libraries. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 7bbf4f7b5fe54a46d2c54a4dc445a0400dfbef23 Author: Nick Clemens Date: Tue Oct 27 15:59:46 2020 +0000 Bug 17515: Order Z3950 server by rank and preserve ordering Previously we put all the servers into an object with keys of the server id This patch converts it to an array of objects to preserve order, and adjusts code to use the array index where necessary and store the server id within the array To test: 1 - Add some new Z3950 servers, they don't need to be valid FIRST SECOND THIRD FOURTH 2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4 3 - Enable and launch the advanced editor 4 - Click 'Advanced' under search on the left 5 - Note the list displays in the order you entered the servers 6 - Apply patch 7 - Reload 8 - Order is correct 9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results https://bugs.koha-community.org/show_bug.cgi?id=17515 Signed-off-by: B Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e1a5fc85a6b829f93d8cc84cc7fb474016e8df61 Author: Arthur Suzuki Date: Wed Sep 30 10:33:12 2020 +0200 Bug 22806: (QA follow-up) Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit dc4639b3f72c84cea3aa950f8350bdfb1f534a80 Author: Arthur Suzuki Date: Wed Jan 8 14:20:38 2020 +0100 Bug 22806: Unit Tests Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit bc0c687ca5e20447ff72917cf1c2734f580ac7a2 Author: Alex Buckley Date: Wed Jul 24 11:33:48 2019 +0000 Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 3fd7d5974a0952ea4cf677ca83c18db46e637b5a Author: Arthur Suzuki Date: Tue May 14 02:30:26 2019 +0200 Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 0ee41b53168c3a5275533a731160b643909cd110 Author: Fridolin Somers Date: Fri Sep 18 15:09:10 2020 +0200 Bug 26487: Add all MARC flavours for not-onloan-count search field In admin/searchengine/elasticsearch/mappings.yaml the search field not-onloan-count is defined for MARC21 on 999x. This should be for all the MARC flavours, like in Zebra config. Test plan: 1) On a UNIMARC database 2) Reset Elasticsearch mappings 3) Check search engine config to see field 'not-onloan-count' on 999$x 4) Same on a NORMARC database Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 6e37dcafee872cdea378ba845ef49d702a3fbfc5 Author: Nick Clemens Date: Thu Oct 1 10:50:17 2020 +0000 Bug 26583: Remove unneccessary code in AddIssue The lines to calc due date are doubled ModDateLastSeen is not needed as we set the item not lost and we can set the date as we do for date last borrowed and save a DB store Largely this is reading the code and confirming the changes make sense To test: 1 - Apply patch 2 - Check out items, confirm it works as before 3 - prove -v t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit dc71c1ee48194574493d1b6b4488a09c649692d8 Author: Owen Leonard Date: Wed Oct 21 01:49:08 2020 +0000 Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 36342731edd05df2f7ff64964e439c3e38aa82ae Author: Jonathan Druart Date: Mon Nov 2 11:02:24 2020 +0100 Bug 26706: Compiled CSS Signed-off-by: Jonathan Druart commit 6d361af6423cfd605519c4e9302c43f34c352d08 Author: Owen Leonard Date: Wed Oct 21 01:48:12 2020 +0000 Bug 26706: Fix btn-default styling for better contrast This patch makes some updates to the OPAC's CSS in order to make Bootstrap button styles more consistent. Some CSS has been simplified and some has been made more specific. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a variety of pages in the OPAC to confirm that button styles look good. For example: - Advanced search. - Catalog search results. - Bibligraphic details (including sidebar menu links and menus). - Subscription details, brief and full - "Your summary" page, various tabs. - Lists The more pages tested the better! Be sure to test the hover and active states of buttons as well. Signed off: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit ddc3459ba5e72f0619a42dacd0f027998f6d3f81 Author: Owen Leonard Date: Sat Oct 24 01:39:56 2020 +0000 Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 4d92e3d284e392ad681b095c02965fe57a85a5a1 Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 +0000 Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 59588c3a3e3390c2796ac417696829fd26fcb4f0 Author: Jonathan Druart Date: Mon Nov 2 08:42:20 2020 +0100 Bug 26673: Fix perlcritic complains This patch fixes the following perlcritic complain: Package declaration must match filename at line 19, column 1. Correct the filename or package statement. Signed-off-by: Jonathan Druart commit 74605e72aa74524984f0411f8db6fd55f2f12148 Author: Nick Clemens Date: Tue Oct 27 14:36:24 2020 +0000 Bug 26581: (follow-up) Restore unsetting of doreturn Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 2 + C4/Circulation.pm | 13 +- C4/Reserves.pm | 12 ++ Koha/MetaSearcher.pm | 5 +- Koha/Z3950Responder/RPN.pm | 2 + admin/searchengine/elasticsearch/mappings.yaml | 10 ++ cataloguing/editor.pl | 2 +- cataloguing/value_builder/cn_browser.pl | 2 +- debian/control.in | 2 - docs/history.txt | 21 +-- .../intranet-tmpl/lib/koha/cateditor/search.js | 4 +- .../prog/en/includes/cateditor-ui.inc | 33 ++--- koha-tmpl/intranet-tmpl/prog/en/includes/i18n.inc | 18 +-- .../prog/en/modules/acqui/acqui-home.tt | 2 +- .../admin/preferences/enhanced_content.pref | 2 +- .../prog/en/modules/circ/circulation.tt | 4 +- .../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +- .../prog/en/modules/tools/import_borrowers.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss | 142 +++++++++++---------- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 19 ++- .../bootstrap/en/modules/opac-illrequests.tt | 16 +-- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 12 +- .../bootstrap/en/modules/opac-shareshelf.tt | 2 +- opac/opac-reserve.pl | 9 +- reserve/request.pl | 14 +- svc/cataloguing/metasearch | 1 + t/db_dependent/ILSDI_Services.t | 44 +++++-- t/db_dependent/Reserves.t | 39 +++++- 32 files changed, 265 insertions(+), 179 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 2 14:21:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Nov 2020 13:21:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1536-g80c3e54316 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 80c3e543163053836a171bde03c9afd70e5b838a (commit) via 03742a1e246e68fa62c2f2fff963beba28f35c80 (commit) via 46c29c8e46670d8ae663a41487b4be37978a6d20 (commit) from 48b1e28015ba9928b558a3507c0e1887242d7ef8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 80c3e543163053836a171bde03c9afd70e5b838a Author: Nick Clemens Date: Mon Nov 2 12:46:59 2020 +0000 Bug 26581: (follow-up) Skip merge when deleting authority Tests failing, seems to be because the indexes haven't been created yet. When deleting authority we perform a 'merge' where we search for biblios containing the authority. Since these are simply tets we can skip this step, avoid the search, and avoid a crash Signed-off-by: Jonathan Druart commit 03742a1e246e68fa62c2f2fff963beba28f35c80 Author: Nick Clemens Date: Mon Nov 2 11:24:02 2020 +0000 Bug 26781: (follow-up) Adjust tests as fields are no longer completely removed Signed-off-by: Jonathan Druart commit 46c29c8e46670d8ae663a41487b4be37978a6d20 Author: Jonathan Druart Date: Mon Nov 2 11:30:04 2020 +0100 Bug 22806: Remove perlcritic errors Subroutine "new" called using indirect syntax at line 415, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 420, column 14. See page 349 of PBP. (Severity: 4) Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/ILSDI_Services.t | 4 ++-- t/db_dependent/Koha/SearchEngine/Indexer.t | 2 +- t/db_dependent/MarcModificationTemplates.t | 12 ++++++++++++ 3 files changed, 15 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 2 16:28:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Nov 2020 15:28:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1539-gbd63fb2bb9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bd63fb2bb941294371a072fea9fc2f930ff5bf3f (commit) via 165a1bcef8fe59e7bfd5571de5fd76e3b5560e93 (commit) via 9c2f9a021ad619a426b395c7e540f7ede70382b1 (commit) from 80c3e543163053836a171bde03c9afd70e5b838a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 165a1bcef8fe59e7bfd5571de5fd76e3b5560e93 Author: Jonathan Druart Date: Thu Oct 15 15:42:09 2020 +0200 Bug 26592: (follow-up) fix typo Signed-off-by: Jonathan Druart commit 9c2f9a021ad619a426b395c7e540f7ede70382b1 Author: Jonathan Druart Date: Thu Oct 1 11:22:46 2020 +0200 Bug 26592: Prevent XSS vulnerabilities when circ/ysearch.pl is used Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 1 + .../intranet-tmpl/prog/en/includes/js_includes.inc | 24 ++++++++++++++++++---- .../prog/en/modules/circ/request-article.tt | 21 +++++++++++++++---- .../prog/en/modules/course_reserves/course.tt | 20 ++++++++++++++++-- .../prog/en/modules/reserve/request.tt | 21 +++++++++++++++---- 5 files changed, 73 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 3 11:32:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 03 Nov 2020 10:32:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1570-gfa3829b120 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fa3829b120c1909dd1a1408392c3f27479779b03 (commit) via b3b87dc7d909997f0af47e02462e87eae2aee308 (commit) via 93176f9e613175244504afeae6c1a902c6d52e33 (commit) via 689f1f9b1f5f53c18c2a351f0fb2195631749de6 (commit) via 296189dc6c92aa691c96ee3012834cd83990aca5 (commit) via 919ea33639714dd6a0d5e0550af2dda6ad6e687e (commit) via bc1152bf3c6fefdbfa72dab8dbbd5c1307183920 (commit) via 72842e85dd60d216c9b929e819ff360079a54383 (commit) via 231f99e3e1d892864aebab229d0c312a2f31182c (commit) via 8220aa14f92ecae8f55138e7570fcb41a1ad1872 (commit) via ff52478d09b522974c436904b0145bab83d88127 (commit) via 7ea60c0bd94cbbcd22e88e59d95131078aa2bc50 (commit) via 74aba6abb57421a8c333974d3e5a48a9c46381ea (commit) via b08444d31c663345d04011c061585c53d99076c5 (commit) via 7815e37258498bf4034c738af17c64bf5941eff5 (commit) via 27735ed40deaf438e622acee0d41147bdbe2d5e1 (commit) via b127f862ee991aefba80f9d7238615a93953370b (commit) via 42060794fc48dfe649a1a8aba1d7db2e7ff1c09d (commit) via 9be2c3639b28b8820e67911f88d642992cd1f7d9 (commit) via d0a42b7ed53fd043c9a96817f91416d1cfe7a6c9 (commit) via adfed0a945eb00ff0fe501ff1c90e25076777a34 (commit) via ba865cc532e5150882398f5958968bd4bd549a12 (commit) via 7a87cc310b5836b6808c8836ee9e38b3dd725160 (commit) via 1181402eee9392fddf0e3a64de5941880485c074 (commit) via cd83a9b6bc1eaf27d6522b824da76f5e9e5f0be4 (commit) via 915b4431e5d8cb45c644bb383adbccc41813e4fc (commit) via 3dee550e346d8a998335eb7ce77b4a064a1d129a (commit) via 80d3f7f910e11c36b5dc20535bc18faf9fbfa8a1 (commit) via 507c9a64479ace842558e04b1f565ab38086954c (commit) via 8b70bd03f7371deb8dd7ef25e2036c0bbc9b1698 (commit) via e39b9684d5cd0ce15a3d1f07d7691b832309287b (commit) from bd63fb2bb941294371a072fea9fc2f930ff5bf3f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa3829b120c1909dd1a1408392c3f27479779b03 Author: Jonathan Druart Date: Tue Nov 3 10:46:10 2020 +0100 Bug 26806: Remove 1 remaining occurrence of jquery.checkboxes.min.js Signed-off-by: Jonathan Druart commit b3b87dc7d909997f0af47e02462e87eae2aee308 Author: Owen Leonard Date: Fri Oct 23 18:45:37 2020 +0000 Bug 26806: Remove the jquery.checkboxes plugin from the staff client This patch removes the jquery.checkboxes plugin from the staff client. It also removes some leftover instances of the "checkboxed" class which was used in some cases to enable the checkbox plugin on selected elements. To test, apply the patch and check that the jquery.checkboxes plugin no longer exists in /intranet-tmpl/lib/jquery/plugins. To test changes to the templates, confirm that "Check all" and "Check none" links still work on these pages: - The tags review page. See the test plan for Bug 26120. - The inventory page. See the test plan for Bug 26150. - The list contents page. See the test plan for Bug 26204. The other modified templates contained the "checkboxed" class but it served no purpose: - Serials -> Serials collection - Labels -> Edit label batch - Patron cards -> Edit card batch If you search the Koha codebase for instances of "checkboxed" the only results should be from the OPAC (if Bug 26805 hasn't been applied) and in Z39.50 templates where the class is still used by JavaScript. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 93176f9e613175244504afeae6c1a902c6d52e33 Author: Owen Leonard Date: Fri Oct 23 14:42:35 2020 +0000 Bug 26800: Remove the use of jquery.checkboxes plugin from checkout page This patch removes inclusion of the jquery.checkboxes plugin from the patron checkout page (circulation.tt). The plugin is unused. To test, apply the patch and check out to a patron with checkouts. - Open the checkouts tab and click "Show checkouts" if necessary. - In the table of checkouts, confirm that the "select all" and "none" links in the "Renew" and "Check in" column headers work correctly. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 689f1f9b1f5f53c18c2a351f0fb2195631749de6 Author: Owen Leonard Date: Fri Oct 23 13:54:01 2020 +0000 Bug 26799: Remove the use of jquery.checkboxes plugin from patron payment page This patch removes the use of the jquery.checkboxes plugin from the patron payment screen (members/pay.tt). To test, apply the patch and locate a patron with unpaid fines. - View the "Accounting" page for that patron. - In the table of outstanding fines, test the "Select all" and "Clear all" links work correctly to check the checkboxes corresponding to each fine. - Confirm that the "Select all" action enables the "Pay selected" and "Write off selected" buttons. - Confirm that the "Clear all" action disables the "Pay selected" and "Write off selected" buttons. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 296189dc6c92aa691c96ee3012834cd83990aca5 Author: Owen Leonard Date: Fri Oct 23 13:34:36 2020 +0000 Bug 26798: Remove the use of jquery.checkboxes plugin from patron detail page This patch removes inclusion of the jquery.checkboxes plugin from the patron detail page (moremember.tt). The plugin is unused. To test, apply the patch and locate a patron with checkouts. - View the details for that patron. - Open the checkouts tab and click "Show checkouts" if necessary. - In the table of checkouts, confirm that the "select all" and "none" links in the "Renew" and "Check in" column headers work correctly. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 919ea33639714dd6a0d5e0550af2dda6ad6e687e Author: Owen Leonard Date: Fri Oct 23 12:41:50 2020 +0000 Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit bc1152bf3c6fefdbfa72dab8dbbd5c1307183920 Author: Owen Leonard Date: Thu Oct 22 10:33:41 2020 +0000 Bug 26769: Remove the use of jquery.checkboxes plugin from staff interface search history This patch modifies the staff interface search history page to eliminate theuse of the jquery.checkboxes plugin. To test you should have some search history items for bibliographic and authority records, both from today and from days previous. Apply the patch and click the logged-in-user link in the staff client header. Choose "Search history." On the search history page, test the "Select all" and "Clear selection" links corresponding to all four tables: - Catalog: Current session - Catalog: Previous sessions - Authority: Current session - Authority: Previous sessions In all cases the links should work correctly, affecting only the corresponding tables. Confirm that the "Select all" action enables the corresponding "Delete" link for each table. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 72842e85dd60d216c9b929e819ff360079a54383 Author: Owen Leonard Date: Wed Oct 21 17:25:47 2020 +0000 Bug 26768: Remove the use of jquery.checkboxes plugin from library transfer limits page This patch modifies the library transfer limits page to eliminate the use of the jquery.checkboxes plugin. To test, apply the patch and go to Administration -> Library transfer limits. - Test the "For all collection codes" links, "Select all" and "Clear all." Each should affect all checkboxes on all tabs. - Click various tabs and confirm that the "select all" and "clear all" links within that tab work correctly, affecting only the checkboxes in that tab. Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 231f99e3e1d892864aebab229d0c312a2f31182c Author: Owen Leonard Date: Wed Oct 21 17:26:56 2020 +0000 Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template This patch removes the use of the jquery.checkboxes plugin from the duplicate orders template in acquisitions. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Click "Add to basket." - Click "From existing orders (copy)." - Perform a search which will return some orders. - Test the "Select all" and "Clear all" links. Confirm that they work correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8220aa14f92ecae8f55138e7570fcb41a1ad1872 Author: Owen Leonard Date: Fri Oct 23 18:14:34 2020 +0000 Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ff52478d09b522974c436904b0145bab83d88127 Author: Owen Leonard Date: Mon Oct 19 17:55:26 2020 +0000 Bug 26694: Set focus for cursor to search input box on guarantor_search.pl This patch adds the "focus" class to the patron search field so that cursor focus is set when the page loads. To test, apply the patch and view an adult patron record in the staff client. - Click the "Add guaratee" button in the patron toolbar. - On the following "Add patron" page, click the "Search to add" button in the "Patron guarantor" section. - A popup window should appear, and the focus should automatically be on the first form field. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 7ea60c0bd94cbbcd22e88e59d95131078aa2bc50 Author: Owen Leonard Date: Mon Oct 19 15:15:13 2020 +0000 Bug 26695: Add modal "shown" event to set cursor focus This patch attaches a focus() call to the login modal's "shown.bs.modal" event so that the cursor focus is set to the username field when the login modal is displayed. To test, apply the patch and confirm that your OPAC uses the regular login process--not casAuthentication or GoogleOpenIDConnect. Click the "Log in to your account" link in the header. A the login form should appear in a modal dialog, and the focus should be on the username field. The same should be true if you trigger the modal from other locations, for instance: "Log in to add tags" on the bibliographic detail page or the tag cloud page. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 74aba6abb57421a8c333974d3e5a48a9c46381ea Author: Owen Leonard Date: Mon Oct 19 14:16:41 2020 +0000 Bug 26712: Set focus for cursor to basket name input box on basketheader.pl This patch adds the "focus" class to the basket name field in the form for creating a new basket in acquisitions. To test, apply the patch and go to Acquisitions -> Vendor -> New basket. - Upon page load the cursor should be focused on the basket name field. - The same should be true if you edit an existing basket. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit b08444d31c663345d04011c061585c53d99076c5 Author: Owen Leonard Date: Tue Oct 20 15:38:21 2020 +0000 Bug 26753: Set focus for cursor to password field on Overdrive login popup on OPAC This patch modifies the OverDrive login process so that clicking the "Log in to your OverDrive account" link automatically puts the focus on the password field when the modal displays. Unrelated change: A redundant "document.ready" function has been removed. To test you must have OverDrive credentials set in system preferences. - Log in to the OPAC. - On the "Your summary" page, open the "OverDrive account" tab. - Click the "Log in to your OverDrive account" link. - A modal dialog should appear, and the cursor focus should automatically be on the password field. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 7815e37258498bf4034c738af17c64bf5941eff5 Author: Owen Leonard Date: Mon Oct 26 20:59:52 2020 +0000 Bug 26826: Set focus for cursor to name input box when creating a new list This patch adds the "focus" class to the list name input field so that it automatically has focus when the page loads. To test, apply the patch and open the lists page in the staff client. - Click "New list." - When the list creation page loads the "Name" field should have focus. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 27735ed40deaf438e622acee0d41147bdbe2d5e1 Author: Owen Leonard Date: Tue Oct 27 10:45:18 2020 +0000 Bug 26828: Set focus for cursor to current password field when updating in the OPAC This patch adds the "focus" class to the first field in the OPAC's password update form so that the field automatically receives focus upon page load. To test, apply the patch and make sure the OpacPasswordChange system preference is enabled. - Log in to the OPAC - Open the "Change your password" page - The cursor should automatically be in the "Current password" field when the page loads. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit b127f862ee991aefba80f9d7238615a93953370b Author: Owen Leonard Date: Mon Oct 26 19:46:30 2020 +0000 Bug 26830: Set focus for cursor to name input box when creating a new list in the OPAC This patch adds the "focus" class to the list name input box in order to automatically set focus on the field. To test, apply the patch and log in to the OPAC. - Go to Lists -> New list. - The cursor focus should automatically be on the "list name" field. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 42060794fc48dfe649a1a8aba1d7db2e7ff1c09d Author: Andrew Fuerste-Henry Date: Fri Oct 30 19:03:18 2020 +0000 Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change.
Any items with existing course reserves will have their on reserve values updated." Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 9be2c3639b28b8820e67911f88d642992cd1f7d9 Author: Andrew Fuerste-Henry Date: Fri Oct 30 20:58:30 2020 +0000 Bug 26881: Remove period on limit to available items on opac To test: 1- do a search on the opac 2- on the results page, it says "Limit to currently available items." 3- apply patch, restart, reload 4- period is gone Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d0a42b7ed53fd043c9a96817f91416d1cfe7a6c9 Author: Owen Leonard Date: Mon Nov 2 12:28:09 2020 +0000 Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit adfed0a945eb00ff0fe501ff1c90e25076777a34 Author: Katrin Fischer Date: Fri Oct 16 01:23:41 2020 +0200 Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit ba865cc532e5150882398f5958968bd4bd549a12 Author: Jonathan Druart Date: Mon Nov 2 11:26:44 2020 +0100 Bug 26892: Remove warnings from Koha/Patrons.t Test plan: Confirm that the warnings "item-level_itypes set but no itemtype set for item" disappear after applying this patch Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 7a87cc310b5836b6808c8836ee9e38b3dd725160 Author: Nick Clemens Date: Sat Oct 24 01:51:55 2020 +0000 Bug 25167: (QA follow-up) Don't add a new variable Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 1181402eee9392fddf0e3a64de5941880485c074 Author: Didier Gautheron Date: Wed Apr 8 09:33:44 2020 +0200 Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit cd83a9b6bc1eaf27d6522b824da76f5e9e5f0be4 Author: Martin Renvoize Date: Mon Sep 7 13:08:46 2020 +0100 Bug 26398: Restore translations for credit/debit type dropdown 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 915b4431e5d8cb45c644bb383adbccc41813e4fc Author: Katrin Fischer Date: Sun Oct 18 15:14:48 2020 +0000 Bug 26721: Fix permission check on debit and credit type admin pages At the moment the pages falsely check for parameters_remaining_permissions, but they should check the specific manage_accounts permission. To test: - Create a new staff user with only catalog and manage_acccounts permissions - Log in with this staff user and go to the admin page - You will see the debit and credit type sections, but won't be able to access them - Apply the patch - Veriy the links still show, but pages are now accessible Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 3dee550e346d8a998335eb7ce77b4a064a1d129a Author: Blou Date: Mon Nov 2 14:24:50 2020 -0500 Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 80d3f7f910e11c36b5dc20535bc18faf9fbfa8a1 Author: Jonathan Druart Date: Tue Nov 3 10:57:13 2020 +0100 Bug 26853: DBIC schema changes Signed-off-by: Jonathan Druart commit 507c9a64479ace842558e04b1f565ab38086954c Author: Jonathan Druart Date: Tue Nov 3 09:50:14 2020 +0000 Bug 26853: DBRev 20.06.00.056 Signed-off-by: Jonathan Druart commit 8b70bd03f7371deb8dd7ef25e2036c0bbc9b1698 Author: David Cook Date: Thu Oct 29 05:23:10 2020 +0000 Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit e39b9684d5cd0ce15a3d1f07d7691b832309287b Author: David Cook Date: Thu Oct 29 05:20:53 2020 +0000 Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 2 +- C4/Reserves.pm | 2 +- Koha.pm | 2 +- Koha/Schema/Result/ImportBiblio.pm | 24 ++++----- admin/credit_types.pl | 2 +- admin/debit_types.pl | 2 +- installer/data/mysql/kohastructure.sql | 12 ++--- installer/data/mysql/updatedatabase.pl | 15 ++++++ .../lib/jquery/plugins/jquery.checkboxes.min.js | 13 ----- .../intranet-tmpl/prog/en/includes/accounts.inc | 62 ++++++++++++---------- .../prog/en/includes/checkouts-table.inc | 2 +- .../prog/en/modules/acqui/basketheader.tt | 2 +- .../prog/en/modules/acqui/duplicate_orders.tt | 11 ++-- .../en/modules/admin/branch_transfer_limits.tt | 46 ++++++++++------ .../prog/en/modules/catalogue/itemsearch.tt | 56 +++++++++---------- .../prog/en/modules/catalogue/search-history.tt | 61 +++++++++++---------- .../prog/en/modules/circ/circulation.tt | 1 - .../prog/en/modules/common/patron_search.tt | 2 +- .../en/modules/course_reserves/add_items-step2.tt | 5 +- .../en/modules/course_reserves/batch_add_items.tt | 1 + .../prog/en/modules/ill/ill-requests.tt | 1 - .../prog/en/modules/labels/label-edit-batch.tt | 2 +- .../prog/en/modules/members/ill-requests.tt | 1 - .../prog/en/modules/members/mancredit.tt | 5 +- .../prog/en/modules/members/maninvoice.tt | 7 ++- .../prog/en/modules/members/moremember.tt | 1 - .../intranet-tmpl/prog/en/modules/members/pay.tt | 15 +++--- .../prog/en/modules/patroncards/edit-batch.tt | 2 +- .../prog/en/modules/serials/serials-collection.tt | 6 +-- .../intranet-tmpl/prog/en/modules/tags/review.tt | 2 +- .../prog/en/modules/tools/inventory.tt | 2 +- .../prog/en/modules/virtualshelves/shelves.tt | 5 +- .../bootstrap/en/includes/opac-facets.inc | 2 +- .../bootstrap/en/includes/overdrive-login.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 13 +++-- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 17 +++--- .../bootstrap/en/modules/opac-search-history.tt | 5 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 21 ++++---- .../bootstrap/en/modules/opac-suggestions.tt | 17 +++--- koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js | 6 ++- koha-tmpl/opac-tmpl/bootstrap/js/script.js | 3 ++ .../lib/jquery/plugins/jquery.checkboxes.min.js | 13 ----- t/db_dependent/Koha/Patrons.t | 12 ++--- tools/inventory.pl | 4 ++ 45 files changed, 254 insertions(+), 235 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.checkboxes.min.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.checkboxes.min.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 4 13:36:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Nov 2020 12:36:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1645-g6ba108f4eb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6ba108f4eb18eb27a1b8be55b33b4e28df4b806f (commit) via ceee890899c54e113a0a787016ae52e40f3817bb (commit) via a8e5d9ab9f3dc690f007bb6893af71edf26a473f (commit) via 973e1b1d5d3d381e90bd405d220e7d418ca1c818 (commit) via d1f412bd76adb4ec54db3b5991b03e9fb2bdecd2 (commit) via 3ef31a0b77133e4c3eacc1c7d46d917746e438d7 (commit) via 38507b041ba3a448315d91294f032267679810bd (commit) via c2293d5c602b27b8f88d64d15eaa4de94e6bc16c (commit) via ee028855c246b1496003fbfccfd20042594ac4bf (commit) via 42ab7b80d4f1d13e15f991d3c4fa161ffca0726f (commit) via 043f3f0fd022b70323e2e681b3560bf0915fe845 (commit) via f2876ef4d481cd037b2b08a3240f14e44f0882f5 (commit) via f0b3bbb3276741961d5e8e8da88aa3076b255eeb (commit) via 7f2e2a4dbdaf066cf6002ad1d6f1241273ce5705 (commit) via 4dd798302a84acf5d4474affeaa61fc9c97ed68a (commit) via ab2e3b0e890a45202a9c360f444917a0ff336d50 (commit) via 96be711d0333a531051cdbd6f194a2eb05071c60 (commit) via 98ab9863929799a8e42f7b8ce23ba5d70c822b14 (commit) via 3bfc54d44a53a4235e171858f75a6fc4bdc3eb9c (commit) via 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa (commit) via a27c22bffc2fbd48951192dbff846b35766d4123 (commit) via e42b4088ed83eb093389f3f5a841095ecc8f036f (commit) via 018720aa5e0c82ad52821789f8878905f1d9affb (commit) via 66289610fa34574e09bd25a95c104a5c03a9cc7f (commit) via 0ddb841d22a41fafee5164967ef8ec449cae06dc (commit) via c65e7ba177e37125de208d9612b74cc9ad3d2b52 (commit) via 9a113663820634d2d718c8a979e8e70f64b8744a (commit) via b5dc71be2ee6d49335d9b4ee79edcf68882c555d (commit) via f010b8fd168a10cd380131fc2bb5360538524655 (commit) via 579608808c4ec81f469e4c48627525d17a16194d (commit) via b1e2693ce529a7af2646ba770269cf32e991ff7d (commit) via 657df01fec106e9a0e2afee7518c8b95537c93d4 (commit) via dcbc856b60436aa1341beb7da75ac3665d4e5f92 (commit) via dbe8c14bbf3ff8a3bc2daa07ab52e02e2a28ef77 (commit) via 5f498d250cdbe50bede11a1e550f385de6ae3d06 (commit) via 37a7a1bb5042e839151185aa40449cad9c6260b6 (commit) via 52be44f406e108544f21e6d45055a9ea9e86c075 (commit) via 975e06bd7c3e198048c60d4a0f9968ba89079de7 (commit) via 14f99da17c38ca352939be48eae0a11523e787e0 (commit) via 4e3bcc9a2578b3821ff8f39554976fb7b76456db (commit) via 6f272a16b2eb6d200402489b26435eea282ec622 (commit) via 617a012a4cbe1e8ada09c0db3d8e464c36b97255 (commit) via 291df4e09206399f4de26ef0214db2b8784c9e20 (commit) via 93c66100733db0aea73a3e59841981e4ee85e717 (commit) via cb4df3b29a57b62b82cf7652b40d30aea4a92d9b (commit) via 781b5a41188c958213f409310f38ba49dcd13159 (commit) via d80763c3714457bf14fd585513ab07d02b82c819 (commit) via d23c58e9084176fac3e64b8edbbaa64ddcc164d4 (commit) via bd0674ac1009420ba94fb005560e11c883003d73 (commit) via 9cbbd6b2ca436990f51b8d1b1985074c2620259c (commit) via 55f2279314edf390e6257942a84f9f9b058c84cf (commit) via e7c134e27e044ad4ebe9a0e4aa220f4a05208215 (commit) via e91b565055892e6c79cd842a975efd83bd566f52 (commit) via 0833724afe7cb0d2f2db32c7e87f3df064e6a016 (commit) via 07cab93d5d9bd292368e097305f309419e746e2f (commit) via 8a874de3f42ef02d0eb9e7e8512f952da5a7152a (commit) via 5da551a6a219436b001ebb0dd35b98414de1d378 (commit) via 77365090f57fe83eff37402f6dcc725fdee00c92 (commit) via 80bf7abb5cd309ae28cd588df9037231e11683e5 (commit) via e0b41a7c5a9634c3229b25424dd449e0bebcf6f6 (commit) via ebbee18822f73c8e8f2236b13a66ba653bebe03f (commit) via 301528d6df117f9183d09189d7a596cdf431f77e (commit) via 4cf9a59b400a97b51ab25720eaf40c60d81e2d42 (commit) via a1c5c5b060115f9e025fce17d602509738319b90 (commit) via 8ccc73353c651659c7e0816bfa57fe2d7b8d82b5 (commit) via b72de018132acaae77ebc3852ed369cf45edc8fb (commit) via 8ba1d7a22b2fccb093fcdb9f20b6bf2dfec04e91 (commit) via 9adafd6404cfdc3f1fc52445e32d8f8b121ccc4e (commit) via c7938f5f86ca4d54e230af415ecae87eda38a324 (commit) via 76da06b6a30a8df29353fa5fabc825e609b2a0d7 (commit) via d80421ce855fd9069dbe1e7cd6b1ea42a665899b (commit) via 9441537e5436b43805d578108ebee0c8394eb5aa (commit) via d34b54ab6954d4c162d0f83a3cad96e4a61bab2d (commit) via cd742a15dd0a889b158f4e841918175763ae83f9 (commit) via 20431a03360583b705d3e2b2e3a60b2ff1f29474 (commit) from fa3829b120c1909dd1a1408392c3f27479779b03 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ba108f4eb18eb27a1b8be55b33b4e28df4b806f Author: Owen Leonard Date: Thu Oct 15 13:01:50 2020 +0000 Bug 26439: (QA follow-up) Correct MSG instances in cart.js To test, add some items to the cart in the staff interface and open the cart window. Test the "Selected items" links (Remove, add to list, etc.) without checking any checkboxes. You should get an alert, "No item was selected." Signed-off-by: Jonathan Druart commit ceee890899c54e113a0a787016ae52e40f3817bb Author: Owen Leonard Date: Fri Sep 11 19:17:10 2020 +0000 Bug 26439: Move cart-related strings out of js_includes.inc and into basket.js This patch moves strings defined for translation in js_includes.inc into basket.js for translation using the new double-underscore i81n function. To test, apply the patch and perform a catalog search in the staff client. - Click the Cart link in the header menu. A pop-up should appear saying "Your cart is currently empty." - On the search results page, click the "Add to cart" link next to any search result. The text should change to "In your cart." - Click the "Remove" link. The text should change to "Add to cart." - Check the box next to a title in the search results and click the "Add to cart" button in the search results toolbar. A message should appear, "1 item(s) added to your cart." - Click the "Add to cart" button again. You should see the message "No item was added to your cart (already in your cart)!" - Uncheck all check boxes on the search results page and click "Add to cart." You should see "No item was selected." - Add more items to your cart so that it contains more than one item. - Click the "Cart" link to open it. - Click the "Empty and close" button. You should be asked to confirm, "Are you sure you want to empty your cart?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/basket.js for translation, e.g.: msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit a8e5d9ab9f3dc690f007bb6893af71edf26a473f Author: Katrin Fischer Date: Fri Sep 25 00:24:29 2020 +0200 Bug 19351: Add items.copynumber to the checkouts table This adds the items.copynumber to the checkouts table in the patron account in the staff interface. To test: - Apply patch - Check out some items with and without copy number in the item to any patron - In the checkouts table on the Checkouts and Details tabs: - Verify that a new column shows 'copy no' shows after 'call no' - Verify the information displays correctly - Verify that the column configuration settings for the new column works Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 973e1b1d5d3d381e90bd405d220e7d418ca1c818 Author: Katrin Fischer Date: Thu Sep 17 11:52:10 2020 +0000 Bug 15780: Add inventory number to checkout list on summary print This will add the inventory number to the list of checkouts that can be printed using the 'Print summary' feature from the patron account in staff. To test: - Apply patch - Make sure you have some items with and without inventory number set - Check them out to any patron - Go to Print > Print summary - Verify the inventory number column is showing up and the numbers show with their items. Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit d1f412bd76adb4ec54db3b5991b03e9fb2bdecd2 Author: Katrin Fischer Date: Mon Sep 21 12:21:23 2020 +0000 Bug 21882: Show price information in acqusitions tab on staff detail page This adds a new 'Price' column to the acqusition details tab. To test: - Apply patch - Add one or more orders for a record. - Before closing the basket: go to the detail page in the catalog - Verify that the price estimated/budgetet price now shows in a new column - Add actual cost to the basket or close the basket and receive the item - Verify the column now shows the updated actual cost - Verfy the tooltip on the table heading works - Verify the column configuration for the new column works as well Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 3ef31a0b77133e4c3eacc1c7d46d917746e438d7 Author: Owen Leonard Date: Thu Oct 15 13:33:29 2020 +0000 Bug 26572: (QA follow-up) Escape strings in autocomplete This patch updates the construction of the autocomplete dropdown so that values are escaped. Signed-off-by: Jonathan Druart commit 38507b041ba3a448315d91294f032267679810bd Author: Owen Leonard Date: Tue Sep 29 11:12:31 2020 +0000 Bug 26572: Add autocomplete to librarian field in log viewer This patch adds patron autocomplete to the librarian field in the log viewer search form. Also changed: Some HTML markup errors in the template have been corrected: Labels with invalid corresponding ids or with no valid id. To test, apply the patch and go to Tools -> Log Viewer. Type a name or cardnumber into the "Librarian" form field. This should trigger an autocomplete dropdown. Select a patron and confirm that the field is populated with the correct borrowernumber. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c2293d5c602b27b8f88d64d15eaa4de94e6bc16c Author: Tomas Cohen Arazi Date: Mon Jul 13 10:25:02 2020 -0300 Bug 21111: Add --exclude-indexes to koha-run-backups This patch adds a trivial switch so koha-run-backups can pass the --exclude-indexes option switch to koha-dump. This way if the sysadmin doesn't want to backup the Zebra indexes, it can be controlled by tweaking the cron definition. To test: 1. Apply this patch 2. Run: $ debian/scripts/koha-run-backups --days 2 --output /var/spool/koha 3. Notice the size of the backups: $ ls -lh /var/spool/koha/kohadev 4. Try the new option switch: $ debian/scripts/koha-run-backups \ --exclude-indexes \ --days 2 --output /var/spool/koha 5. Repeat 3 => SUCCESS: Backups are smaller! 6. Sign off :-D Signed-off-by: David Nind Signed-off-by: Nick Clemens JD amended patch: fix --exclude_indexes vs --exclude-indexes in koha-run-backups.xml Signed-off-by: Jonathan Druart commit ee028855c246b1496003fbfccfd20042594ac4bf Author: Katrin Fischer Date: Sun Sep 13 21:45:25 2020 +0000 Bug 15329: Add new column for budget to the late orders table The table currently displays the fund, but as late orders can be from a past budget with the same fund names, this can be confusing. So adding the budget in addition to the fund will be helpful. To test: - Add a basket and an order, close the basket - Go to the late oder page - Make sure your order shows up there - Apply the patch - Reload the late orders page - Verify a new column budget shows in the table - Verify the table configuration settings work for the new column - Run t/db_dependent/Koha/Acquisition/Fund.t Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 42ab7b80d4f1d13e15f991d3c4fa161ffca0726f Author: Katrin Fischer Date: Sun Sep 13 16:07:44 2020 +0000 Bug 15141: Add MARC21 770/772 Supplement (parent) to OPAC and staff detail pages Adds the 2 corresponding linking fields to the staff and OPAC detail pages: 770 - Supplement/Special Issue Entry (R) https://www.loc.gov/marc/bibliographic/bd770.html 772 - Supplement Parent Entry (R) https://www.loc.gov/marc/bibliographic/bd772.html To test: - Catalog records with 770/772 in Koha, examples can be found in the LOC documentation. - When UseControlNumber is set to Use and $w is added, a link will be built using $w - If there is no $w or UseControlNumber is Don't use, a link will be build using the title - Verify that they display nicely in the OPAC and staff detail pages Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 043f3f0fd022b70323e2e681b3560bf0915fe845 Author: Martin Renvoize Date: Wed Oct 14 12:45:01 2020 +0100 Bug 24834: (follow-up) Improve breadcrumb This patch updates the breadcrumb navigation to be consistent for View, Edit and Run with the report name (and id in brackets) appropraitely placed in the breadcrumb with a link back to the view and the 'Action' clearly listed as the final part of the breadcrumb path. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f2876ef4d481cd037b2b08a3240f14e44f0882f5 Author: Martin Renvoize Date: Wed Oct 14 08:49:50 2020 +0100 Bug 24834: (QA follow-up) Add missing filter Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f0b3bbb3276741961d5e8e8da88aa3076b255eeb Author: Katrin Fischer Date: Thu Sep 24 23:35:19 2020 +0200 Bug 24834: (follow-up) Add report id to page titles See test plan of previous patch! Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 7f2e2a4dbdaf066cf6002ad1d6f1241273ce5705 Author: Katrin Fischer Date: Mon Sep 21 12:46:48 2020 +0000 Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Michael A Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 4dd798302a84acf5d4474affeaa61fc9c97ed68a Author: David Cook Date: Sun Oct 11 23:47:45 2020 +0000 Bug 26641: Optimize CatalogModuleRelink lookup This patch moves the CatalogModuleRelink lookup outside the loop to improve performance (especially for large databases), and includes a tester friendly test plan. Test plan: 0. Using koha-testing-docker 1. koha-shell -c "./misc/link_bibs_to_authorities.pl -l --test" kohadev 2. Note 436 bibs checked, 1315 headings linked, 676 headings unlinked 3. koha-shell -c "./misc/link_bibs_to_authorities.pl -l --test -g 700" kohadev 4. Note 436 bibs checked, 248 headings linked, 111 headings unlinked 5. Note output appear to all be names (rather than subjects or other authorities) 6. Note also that the 2nd run with -g 700 is almost 2x faster than without Signed-off-by: Andreas Roussos Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit ab2e3b0e890a45202a9c360f444917a0ff336d50 Author: Andreas Roussos Date: Fri Oct 9 13:39:52 2020 +0200 Bug 26641: pass the MARC field as an argument to link_bibs_to_authorities.pl When running link_bibs_to_authorities.pl, it could be useful to have the ability to specify which MARC field the script should operate on. For example, when you have a catalog where most links are in place, and you don't want the script to process every MARC field but rather limit it to a specific MARC field (e.g. 700) because you've observed that there are many missing links for that particular MARC field. This patch provides that enhancement. Test plan: 1) Run the script as follows (preferably in a test DB): time link_bibs_to_authorities.pl -v -l --test ... and notice how long it takes to complete. 2) Apply the patch. 3) Run the script again, this time providing the MARC field to work on: time link_bibs_to_authorities.pl -v -l --test -g=700 ... and, again, notice how long it takes to complete. The 2nd run should run faster than the 1st one. Signed-off-by: David Cook Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 96be711d0333a531051cdbd6f194a2eb05071c60 Author: Jonathan Druart Date: Wed Nov 4 10:57:45 2020 +0100 Bug 21898: Add basket for TT syntax Without this patch the basket's info won't be available for the TT syntax. With this patch you can now use [% basket.basketname %] Signed-off-by: Jonathan Druart commit 98ab9863929799a8e42f7b8ce23ba5d70c822b14 Author: Martin Renvoize Date: Thu Oct 1 09:04:43 2020 +0100 Bug 21898: Add aqbasket to available tables for ACQORDER This patch should allow <> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <> into the ACQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer JD amended patch: fix alignment in hashref, edit commit message to fix letter code "AQORDER" vs "ACQORDER" Signed-off-by: Jonathan Druart commit 3bfc54d44a53a4235e171858f75a6fc4bdc3eb9c Author: Katrin Fischer Date: Sat Oct 17 14:14:00 2020 +0200 Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa Author: Katrin Fischer Date: Sat Oct 17 22:47:49 2020 +0000 Bug 26190: Allow to close a basket with only cancelled order lines At the moment there are several cases, when closing a basket is not possible: - when there are no order lines in it - when there are order lines with uncertain prices - when the basket is marked as a standing order The first case wasn't checked correctly as only pending/received orders would be counted, but not cancelled orders. To test: - Create a basket - Create an order line - Verify the "close this basket" button shows - Cancel the order line - the button disappears - Apply the patch - Verify the button appears and works now - Create another basket - make sure you cannot close it without order lines - Create an order line with uncertain price checked - you cannot close it - Resolve the uncertain price - you can now close the basket. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit a27c22bffc2fbd48951192dbff846b35766d4123 Author: Katrin Fischer Date: Sat Oct 17 14:04:33 2020 +0200 Bug 26718: Rename "reading history" to "checkout history" This changes all occurences of reading history to the more accurate term 'checokut history' as it was correctly pointed out that 'reading' doesn't apply to all kind of items available at the library (audio books, games, etc.) To test: - Verify that the term reding history has been replaced by checkout history in: - System preferences - OPAC tab "your checkout history" - OPAC tab "your privacy" (switch OpacPrivacy pref first) - Staff permission for patron batch anonymization Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit e42b4088ed83eb093389f3f5a841095ecc8f036f Author: Nick Clemens Date: Fri Aug 7 13:15:36 2020 +0000 Bug 26180: Add descending option to rebuild_elasticsearch.pl While the ES index is incremental and provides results as it commits, we currently index from the oldest records to the newest. This patch provides the option to go the other direction To test: 1 - Have ES setup and running for Koha 2 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b 3 - Note the biblios index from number 1 the end 4 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a 5 - Notice the same 6 - Apply patch 7 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b 8 - Still in ascending order 9 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b --desc 10 - Now records index in descending order 11 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a 12 - Still ascending 13 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a --desc 14 - Now descending Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize JD amended patch: fix typo "inde" vs "index" and add commit body Signed-off-by: Jonathan Druart commit 018720aa5e0c82ad52821789f8878905f1d9affb Author: Owen Leonard Date: Thu Oct 22 12:27:17 2020 +0000 Bug 12533: (follow-up) Add CSS to preview display of authority MARC This patch adds the same CSS used by authorities/detail.tt to the modal preview of the authority record shown in the authorities search result popup. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 66289610fa34574e09bd25a95c104a5c03a9cc7f Author: Owen Leonard Date: Wed Oct 21 13:04:42 2020 +0000 Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely Signed-off-by: Marjorie Barry-Vila Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 0ddb841d22a41fafee5164967ef8ec449cae06dc Author: Tal Rogoff Date: Fri Oct 23 23:39:06 2020 +0000 Bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit c65e7ba177e37125de208d9612b74cc9ad3d2b52 Author: Martin Renvoize Date: Wed Aug 19 12:32:08 2020 +0100 Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 9a113663820634d2d718c8a979e8e70f64b8744a Author: Martin Renvoize Date: Thu Oct 22 16:26:03 2020 +0100 Bug 12656: Allow --reason to be passed to cancel_expired_holds This patch adds the --reason option to cancel_expired_holds which allows the library to optionally set a reason for cancellation when running the cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the patron. To test: 1/ Ensure the unit tests continue to pass after the patch (t/db_dependent/Reserves/CancelExpiredReserves.t) Also: 1 - Add an expired hold for a patron: INSERT INTO RESERVES (borrowernumber, biblionumber, expirationdate, found,branchcode,itemnumber) VALUES (5,5,'2020-01-01','W','CPL',983); 2 - Set ExpireReservesMaxPickUpDelay to Allow 3 - Run the cronjob: perl misc/cronjobs/hold/cancel_expired_holds.pl --reason EXPIRED 4 - Visit the patron's notices tab 5 - Confirm they have been sent a cancellation notice Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit b5dc71be2ee6d49335d9b4ee79edcf68882c555d Author: Owen Leonard Date: Mon Oct 19 10:35:20 2020 +0000 Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f010b8fd168a10cd380131fc2bb5360538524655 Author: Owen Leonard Date: Fri Oct 16 19:03:13 2020 +0000 Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 579608808c4ec81f469e4c48627525d17a16194d Author: Owen Leonard Date: Tue Jul 14 18:46:19 2020 +0000 Bug 22399: Improve responsive behavior of the basic marc editor This patch makes markup and style changes to the basic MARC editor in order to improve the page's handling of smaller browser widths. It adds flexbox styling to elements of the form to help accomplish this. To test, apply the patch and load a record for editing in the basic MARC editor. - Adjust your browser width and confirm that the form adjusts well to various widths. - Test that the markup changes haven't broken the JavaScript-driven features in the editor: - Clone tags - Delete tags - Expand and collapse tags - Clone subfields - Delete subfields - Re-order subfields - Cataloging plugins: - Focus-driven plugins like on tag 000 - Popup plugins like 008 or authority-linked tags - Select2-styled dropdowns (e.g. 942$c Item type). - Test the add/edit items form to confirm that it is still styled as it was before. Edit: The Select2 plugin JavaScript file now accepts a variable to set the "width" configuration option. It still defaults to "element." Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit b1e2693ce529a7af2646ba770269cf32e991ff7d Author: Owen Leonard Date: Wed Oct 21 12:07:19 2020 +0000 Bug 26763: Use standard information style for multi-hold message This patch modifies the markup of the message which is displayed when the patron tries to place a hold on a title they already have a hold on. Now the message is styled consistently with other similar messages. To test, apply the patch and follow the steps used to test Bug 19718: - In Administration -> Circulation and fine rules, set a rule to allow multiple holds on a title. - Log in to the OPAC as a user covered by the above rule and locate a bibliographic record on which multiple holds can be placed. - Place a hold on the record. - Return to the record details for that title and place another hold. - You should see a correctly-styled message about having at least one other hold on the record. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 657df01fec106e9a0e2afee7518c8b95537c93d4 Author: Jonathan Druart Date: Wed Nov 4 11:53:04 2020 +0000 Bug 19482: DBRev 20.06.00.059 Signed-off-by: Jonathan Druart commit dcbc856b60436aa1341beb7da75ac3665d4e5f92 Author: Nick Clemens Date: Sun Oct 25 02:16:42 2020 +0000 Bug 19482: (follow-up) Fix update, add tests, restore closing To test: 1 - View the mappings page, confirm table is correctly structured 2 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t t/db_dependent/Koha/SearchField.t 3 - Confirm update statement works and table is ordered correctly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit dbe8c14bbf3ff8a3bc2daa07ab52e02e2a28ef77 Author: Nick Clemens Date: Fri Oct 16 16:13:32 2020 +0000 Bug 19482: (follow-up) Don't set readonly as a variable, use conditionals Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5f498d250cdbe50bede11a1e550f385de6ae3d06 Author: Nick Clemens Date: Fri Oct 16 14:37:24 2020 +0000 Bug 19482: DBIC schema changes Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 37a7a1bb5042e839151185aa40449cad9c6260b6 Author: Nick Clemens Date: Fri Oct 16 14:30:00 2020 +0000 Bug 19482: (follow-up) Add missing filters and boolean switch to schema Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 52be44f406e108544f21e6d45055a9ea9e86c075 Author: Nick Clemens Date: Tue Aug 18 11:32:51 2020 +0000 Bug 19482: (follow-up) Fix select and adjust export of new field Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 975e06bd7c3e198048c60d4a0f9968ba89079de7 Author: Nick Clemens Date: Wed Oct 18 13:06:22 2017 +0000 Bug 19482: Add support for defining 'mandatory' mappings To test: 1 - Apply patch 2 - ./installer/data/mysql/updatedatabase.pl 3 - Reset ES mapping: Administration->Search engine configuration , button at bottom of page 4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and not editable 5 - On 'Bibliographic records' tab you should not be able to delete the single entry for issues 6 - You should be able to delete 'title' mappings, however, at the final one you should be stopped by javascript 7 - Bonus: force remove the last mapping from the page using developer tools - attempt to save and should be warned of missing mandatory mapping Signed-off-by: Nicolas Legrand Signed-off-by: Bouzid Fergani Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 14f99da17c38ca352939be48eae0a11523e787e0 Author: Nick Clemens Date: Wed Oct 18 13:05:40 2017 +0000 Bug 19482: DB changes Signed-off-by: Nicolas Legrand Signed-off-by: Bouzid Fergani Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 4e3bcc9a2578b3821ff8f39554976fb7b76456db Author: Lisette Scheer Date: Sat Oct 24 19:45:28 2020 +0000 Bug 25834: Relabel "Search to add" to "Add guarantor" on patron form. The "search to add" label on the button for adding guarantors is a bit hard to translate and is inaccessable. This patch updated the button label to "Add guarantor" to fix these issues. To test: 1. Go to patrons 2. Add a new child patron 3. Observe the button with "search to add" 4. Save the patron 5. Edit the patron and observe the "search to add" button. 6. Apply patch. 7. Add a new patron 8. Observe new text on button. 9. Edit a child patron 10. Observe new text on button 11. Sign off Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 6f272a16b2eb6d200402489b26435eea282ec622 Author: Frédéric Demians Date: Fri Oct 23 18:17:49 2020 +0200 Bug 26803: Fix PLUGIN_DIR when plugin_dirs is multivalued When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. See bug 23237 Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 617a012a4cbe1e8ada09c0db3d8e464c36b97255 Author: Jonathan Druart Date: Tue Nov 3 15:28:56 2020 +0100 Bug 23979: Remove final dot Signed-off-by: Jonathan Druart commit 291df4e09206399f4de26ef0214db2b8784c9e20 Author: Nick Clemens Date: Tue Oct 6 16:00:30 2020 +0000 Bug 23979: Move locked message to patron info section To test: 1 - Set failed login attempts to some number 2 - Attempt enough logins with a patront o lock them, or: UPDATE borrowers SET login_attempts = 500 WHERE borrowernumber=5; 3 - Attempt to checkout to borrower, no notice of lock 4 - View patron details tab, see the locked message 5 - Apply patch 6 - Note the message is now in patron info and visible on all tabs for the member Signed-off-by: George Williams Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 93c66100733db0aea73a3e59841981e4ee85e717 Author: Matthias Meusburger Date: Mon Jan 20 15:44:44 2020 +0100 Bug 20888: (follow-up) revert unecessary change on jquery selector Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit cb4df3b29a57b62b82cf7652b40d30aea4a92d9b Author: Matthias Meusburger Date: Mon Jan 20 15:36:21 2020 +0100 Bug 20888: (follow-up) 'is not' operator behaves as 'not like' Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 781b5a41188c958213f409310f38ba49dcd13159 Author: Matthias Meusburger Date: Thu Jan 10 10:48:38 2019 +0100 Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values Signed-off-by: Amandine Zocca Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit d80763c3714457bf14fd585513ab07d02b82c819 Author: Owen Leonard Date: Tue Oct 27 15:02:43 2020 +0000 Bug 26825: Add span for publication date in OPAC This patch modifies the XSL templates for OPAC results and OPAC details so that the parts of the publisher details are wrapped separate s: Publisher place, name, and date. To test, apply the patch "restart_all" if necessary. You can add this to the OPACUserCSS system preference to better see the change: .publisher_place { color: red; } .publisher_name { color: green; } .publisher_date { color: orange; } - Peform a search in the OPAC - In the search results, confirm that the publisher plac, name, and date are wrapped in separate s, either by confirming the custom colors or by inspecting the source. - View the details for one of the results. Confirm that the same change has been made to the detail page. Signed-off-by: B Johnson Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit d23c58e9084176fac3e64b8edbbaa64ddcc164d4 Author: Katrin Fischer Date: Mon Oct 26 23:12:11 2020 +0000 Bug 16696: Rename 'Publisher' to 'Publication details' on detail and result lists To test: 1) Do a catalog search in staff client 2) Confirm 'Publisher' says 'Publication details' for each result in search 3) Click on a record to go to the detail page 4) Confirm 'Publisher' says 'Publication details' 5) Click the Items tab on the left 6) Confirm 'Publisher' says 'Publication details' 7) Do a search in the OPAC 8) Confirm 'Publisher' says 'Published' for each result in search 9) Click on a record to go to the detail page and switch to the items tab 10) Confirm 'Publisher' says 'Publication details' on top of the page Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit bd0674ac1009420ba94fb005560e11c883003d73 Author: Nick Clemens Date: Wed Oct 28 12:34:01 2020 +0000 Bug 26844: Add warning to disabled logs on log viewer To test: 1 - Go to Admin->System preferences->Logs tab 2 - Make sure some logs are disabled 3 - Go to Tools->Log viewer 4 - Note you can select logs that are disabled 5 - Apply patch 6 - Reload page 7 - Note disabled logs have a warning icon and hover text Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 9cbbd6b2ca436990f51b8d1b1985074c2620259c Author: Tomas Cohen Arazi Date: Fri Oct 30 12:10:03 2020 -0300 Bug 26310: (QA follow-up) koha-conf-site.xml.in tweaks Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 55f2279314edf390e6257942a84f9f9b058c84cf Author: Nick Clemens Date: Thu Aug 27 15:24:58 2020 +0000 Bug 26310: Allow setting trace_to parameter in Elaasticsearch config For debugging purposes we may wish to see the requests and responses made to Elasticsearch To test: 1 - prove -v t/Koha/SearchEngine/Elasticsearch.t 2 - Set Stderr in koha-conf 3 - Restart all 4 - perl misc/search_tools/rebuild_elasticsearch.pl 5 - Note requests are shown 6 - Set File /var/log/koha/kohadev/plack-error.log in koha-conf 7 - Restart all 8 - perl misc/search_tools/rebuild_elasticsearch.pl 9 - Check the plack log and see the ES requests Signed-off-by: Bob Bennhoff Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e7c134e27e044ad4ebe9a0e4aa220f4a05208215 Author: Fridolin Somers Date: Thu Oct 15 10:48:52 2020 +0200 Bug 26687: Add a Font Awesome icon for superlibrarian patrons Bug 26534 adds a shield Font Awesome icon to help identify staff patrons. I propose to add an icon when patron is a superlibrarian. Patch adds 'is-superlibrarian' class that may be used for more CSS tuning. Test plan: 1) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access 2) Patron B has only shield icon 3) Patron A has shield icon and bolt icon 4) Check a patron without permissions has no shield icon Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e91b565055892e6c79cd842a975efd83bd566f52 Author: Owen Leonard Date: Mon Oct 26 12:31:16 2020 +0000 Bug 26817: Change checkouts table footer colspan based on ExportCircHistory This patch makes a minor change to the include file which generates the checkouts table footer. It now includes some logic checking for the ExportCircHistory system preference, adjusting the colspan accordingly. To test, apply the patch and enable the ExportCircHistory system preference. - Check out to a patron who has checkouts. In the table of checkouts there should be an "Export" column. The footer at the bottom of the table should span the width of the table. - Disable the ExportCircHistory preference. - View the checkout page again and confirm that table footer still looks correct. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 0833724afe7cb0d2f2db32c7e87f3df064e6a016 Author: Fridolin Somers Date: Mon Oct 26 10:49:49 2020 +0100 Bug 26032: (follow-up) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 07cab93d5d9bd292368e097305f309419e746e2f Author: Fridolin Somers Date: Fri Oct 16 10:45:41 2020 +0200 Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8a874de3f42ef02d0eb9e7e8512f952da5a7152a Author: Fridolin Somers Date: Tue Jul 21 11:43:55 2020 +0200 Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5da551a6a219436b001ebb0dd35b98414de1d378 Author: Fridolin Somers Date: Tue Jul 21 12:26:55 2020 +0200 Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 77365090f57fe83eff37402f6dcc725fdee00c92 Author: Jonathan Druart Date: Wed Nov 4 11:53:04 2020 +0000 Bug 25333: DBRev 20.06.00.058 Signed-off-by: Jonathan Druart commit 80bf7abb5cd309ae28cd588df9037231e11683e5 Author: Katrin Fischer Date: Sun Nov 1 03:45:56 2020 +0000 Bug 25333: (QA follow-up) Change phone to itiva on overduerules.tt Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e0b41a7c5a9634c3229b25424dd449e0bebcf6f6 Author: Kyle M Hall Date: Thu Oct 29 14:17:55 2020 -0400 Bug 25333: (QA follow-up) Update opac messaging for new transport name Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ebbee18822f73c8e8f2236b13a66ba653bebe03f Author: Kyle M Hall Date: Thu Apr 30 14:09:02 2020 -0400 Bug 25333: Change message transport type for Talking Tech from "phone" to "itiva" From its inception, phone notices via Talking Tech have not behaved like other notices. Instead of reading notices generated by Koha, the Talking Tech scripts largely generate their own notices. We would like to pave the way to having "generic" phone notices that can be processed by plugins to support arbitrary telephony vendors ( we will be targeting Twilio initially ). To that end, it seems sensible to begin by changing the messaage transport type for Talking Tech from 'phone' to 'itiva' to highlight its specificity and difference from standard message transports. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Test Talking Tech outbound script 5) Note no changes in functionality Signed-off-by: Christopher Zorn Signed-off-by: Katrin Fischer JD amended patch: remove uneeded indentation change in sample_notices_message_transports.sql Signed-off-by: Jonathan Druart commit 301528d6df117f9183d09189d7a596cdf431f77e Author: Owen Leonard Date: Mon Nov 2 15:16:40 2020 +0000 Bug 25469: Typo: Item does not belongs to your library This patch makes corrections to two strings in the batch delete template to correct a typo. Before: t("Item does not belongs to your library") ...after, t("Item does not belong to your library") To test, apply the patch and inspect the template to confirm that the string is correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 4cf9a59b400a97b51ab25720eaf40c60d81e2d42 Author: Katrin Fischer Date: Sun Nov 1 02:02:04 2020 +0000 Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit a1c5c5b060115f9e025fce17d602509738319b90 Author: Alex Buckley Date: Sat Oct 24 18:02:59 2020 +0000 Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart commit 8ccc73353c651659c7e0816bfa57fe2d7b8d82b5 Author: Martin Renvoize Date: Tue Nov 3 08:09:22 2020 +0000 Bug 25897: (QA follow-up) Add filters Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b72de018132acaae77ebc3852ed369cf45edc8fb Author: Katrin Fischer Date: Mon Oct 19 00:38:31 2020 +0000 Bug 25897: Use cn_sort for sorting callnumbers in inventory table Instead of using the machine sortable form of the callnumber from cn_sort the table was only sorting on the callnumber. This tries to fix it using the same technique as for sorting the differently formatted dates. To test: - If your database has items with suitably cataloged items, use these. Otherwise you could use the examples from the bug report: - Catalog items with the following barcodes: B 29 V55 1998 B29 .C55 2008 B29 .L24 1983 B29 .L264 1998 B29 .P666 2004 Make sure the LOC is selected in $2 as source of classification This makes sure the sortable form of the callnumber is calculated correctly. - Go to inventory - Search for your items - Before patch, they should sort on callnumber as above, after the patch the correct sort order should be: B29 .C55 2008 B29 .L24 1983 B29 .L264 1998 B29 .P666 2004 B 29 V55 1998 Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 8ba1d7a22b2fccb093fcdb9f20b6bf2dfec04e91 Author: Martin Renvoize Date: Tue Nov 3 08:09:35 2020 +0000 Bug 26664: (QA follow-up) Add filters Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 9adafd6404cfdc3f1fc52445e32d8f8b121ccc4e Author: Katrin Fischer Date: Mon Oct 5 17:48:45 2020 +0000 Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit c7938f5f86ca4d54e230af415ecae87eda38a324 Author: Jonathan Druart Date: Wed Nov 4 11:53:04 2020 +0000 Bug 26638: DBRev 20.06.00.057 Signed-off-by: Jonathan Druart commit 76da06b6a30a8df29353fa5fabc825e609b2a0d7 Author: Katrin Fischer Date: Sat Oct 17 16:02:55 2020 +0000 Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit d80421ce855fd9069dbe1e7cd6b1ea42a665899b Author: Katrin Fischer Date: Mon Oct 26 22:40:50 2020 +0000 Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference The mapping in the itemcallnumber system preference is only valid for MARC21 libraries using DDC classification, but not for libraries using UNIMARC or other classification. This patch suggests to remove the default mapping and start new installations with an empty value. To test: - On an emtpy database - Apply patch - Run the web installer, selecting either MARC21 or UNIMARC - Verify that the itemcallnumber system preference is empty - Verify the description now also include examples for UNIMARC Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 9441537e5436b43805d578108ebee0c8394eb5aa Author: Fridolin Somers Date: Tue Oct 27 09:03:16 2020 +0100 Bug 26832: Make Elasticsearch mappings export use UTF-8 Script misc/search_tools/export_elasticsearch_mappings.pl allows to export current search engine configuration into a YAML file. This export should use UTF-8 encoding, like other exports. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Edit a field label to use a diacrtic, for example local-number => Numéro 3) Save 4) Edit file etc/koha-conf.xml to enable 'elasticsearch_index_mappings' 5) Export mappings to file via misc/search_tools/export_elasticsearch_mappings.pl -t $MARCFLAVOUR 6) Reset memcached and plack 7) Back to Administration > Search engine configuration (Elasticsearch) 8) Click on 'Reset Mappings' and accept 9) Look at field 'local-number' => Without patch diacritic 'é' is broken 10) You may try with an emoji B-) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit d34b54ab6954d4c162d0f83a3cad96e4a61bab2d Author: Tomas Cohen Arazi Date: Tue Nov 3 10:35:17 2020 -0300 Bug 26738: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit cd742a15dd0a889b158f4e841918175763ae83f9 Author: Jonathan Druart Date: Mon Nov 2 15:01:32 2020 +0100 Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 20431a03360583b705d3e2b2e3a60b2ff1f29474 Author: Kyle M Hall Date: Mon Nov 2 09:50:42 2020 -0500 Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Matthias Meusburger Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Accounts.pm | 76 ------ C4/Biblio.pm | 4 + C4/Items.pm | 12 +- C4/Letters.pm | 12 +- C4/Reserves.pm | 6 +- C4/SIP/ILS/Transaction/Checkin.pm | 10 +- Koha.pm | 2 +- Koha/Acquisition/Fund.pm | 16 ++ Koha/BiblioUtils.pm | 7 +- Koha/MetadataRecord/Authority.pm | 7 +- Koha/Plugins/Base.pm | 18 +- Koha/Schema/Result/SearchField.pm | 17 +- Koha/SearchEngine/Elasticsearch.pm | 5 +- acqui/basket.pl | 2 +- admin/columns_settings.yml | 8 + admin/searchengine/elasticsearch/mappings.pl | 9 +- admin/searchengine/elasticsearch/mappings.yaml | 2 + api/v1/swagger/definitions/patron.json | 2 +- catalogue/itemsearch.pl | 9 +- debian/docs/koha-run-backups.xml | 7 + debian/scripts/koha-run-backups | 17 +- debian/templates/koha-conf-site.xml.in | 2 + etc/koha-conf.xml | 2 + installer/data/mysql/kohastructure.sql | 5 +- .../mysql/mandatory/message_transport_types.sql | 2 +- .../sample_notices_message_transports.sql | 6 +- installer/data/mysql/mandatory/sysprefs.sql | 14 +- installer/data/mysql/mandatory/userpermissions.sql | 2 +- installer/data/mysql/updatedatabase.pl | 32 +++ koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 103 ++++++-- .../en/includes/authorities-search-results.inc | 6 +- .../prog/en/includes/checkouts-table-footer.inc | 8 +- .../prog/en/includes/checkouts-table.inc | 1 + .../intranet-tmpl/prog/en/includes/circ-menu.inc | 18 +- .../intranet-tmpl/prog/en/includes/js_includes.inc | 17 -- .../prog/en/includes/messaging-preference-form.inc | 22 +- .../intranet-tmpl/prog/en/includes/permissions.inc | 2 +- .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 +- .../prog/en/modules/acqui/lateorders.tt | 5 +- .../prog/en/modules/admin/aqbudgetperiods.tt | 4 +- .../en/modules/admin/preferences/cataloguing.pref | 3 +- .../prog/en/modules/admin/preferences/opac.pref | 6 +- .../prog/en/modules/admin/preferences/patrons.pref | 2 +- .../admin/searchengine/elasticsearch/mappings.tt | 269 ++++++++++++--------- .../authorities/blinddetail-biblio-search.tt | 214 ++++++++-------- .../prog/en/modules/authorities/detail.tt | 38 --- .../modules/authorities/searchresultlist-auth.tt | 41 +++- .../en/modules/authorities/searchresultlist.tt | 7 +- .../prog/en/modules/catalogue/detail.tt | 3 + .../prog/en/modules/catalogue/itemsearch.tt | 22 +- .../prog/en/modules/catalogue/moredetail.tt | 2 +- .../prog/en/modules/cataloguing/addbiblio.tt | 134 +++++----- .../value_builder/unimarc_field_210c.tt | 41 +++- .../prog/en/modules/common/patron_search.tt | 6 +- .../prog/en/modules/members/memberentrygen.tt | 2 +- .../prog/en/modules/members/moremember-print.tt | 4 +- .../prog/en/modules/members/moremember.tt | 7 - .../en/modules/reports/guided_reports_start.tt | 12 +- .../prog/en/modules/suggestion/suggestion.tt | 30 ++- .../modules/suggestion/tables/suggester_search.tt | 36 --- .../prog/en/modules/tools/batchMod-del.tt | 4 +- .../prog/en/modules/tools/batch_delete_records.tt | 2 +- .../en/modules/tools/batch_record_modification.tt | 2 +- .../prog/en/modules/tools/inventory.tt | 11 +- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +- .../prog/en/modules/tools/overduerules.tt | 4 +- .../prog/en/modules/tools/upload-images.tt | 215 +++++++++------- .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 49 ++-- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 88 ++++++- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 4 +- koha-tmpl/intranet-tmpl/prog/js/basket.js | 46 ++-- koha-tmpl/intranet-tmpl/prog/js/cart.js | 9 +- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 70 +++--- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 + koha-tmpl/intranet-tmpl/prog/js/select2.js | 2 +- koha-tmpl/intranet-tmpl/prog/js/suggestions.js | 17 -- koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 28 +++ .../opac-tmpl/bootstrap/en/includes/usermenu.inc | 2 +- .../bootstrap/en/modules/opac-messaging.tt | 12 +- .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 16 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 +- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 129 ++++++++-- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 34 +-- misc/cronjobs/holds/cancel_expired_holds.pl | 52 +++- .../thirdparty/TalkingTech_itiva_outbound.pl | 10 +- misc/link_bibs_to_authorities.pl | 23 +- misc/search_tools/export_elasticsearch_mappings.pl | 1 + misc/search_tools/rebuild_elasticsearch.pl | 17 +- suggestion/add_user_search.pl | 7 +- suggestion/suggester_search.pl | 57 ----- suggestion/suggestion.pl | 14 +- svc/checkouts | 4 +- t/db_dependent/Accounts.t | 30 +-- t/db_dependent/Items.t | 25 +- t/db_dependent/Koha/Acquisition/Fund.t | 19 +- t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 7 +- .../Koha/SearchEngine/Elasticsearch/ExportConfig.t | 4 +- .../Koha/SearchEngine/Elasticsearch/Reset.t | 6 +- t/db_dependent/Koha/SearchField.t | 9 +- t/db_dependent/Reserves/CancelExpiredReserves.t | 26 +- t/db_dependent/SIP/Message.t | 5 +- 101 files changed, 1515 insertions(+), 943 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/js/suggestions.js delete mode 100755 suggestion/suggester_search.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 4 18:05:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Nov 2020 17:05:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1661-g31e9ac9a2c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 31e9ac9a2c6e54e458a7f5bc49b83a2d05a83d2c (commit) via fe7abf020c6c13978ce84393b4877688b6f3ebce (commit) via e700fb8f4ec323102d4cd6967bc4fb589ddc4032 (commit) via fbeb3d547f1bacccfa585ec02e72494decc0e1a0 (commit) via 6884665d55a304cb07c2e385a22e4a2868a66486 (commit) via 43e6557a2ae1082f684fd073b476511730d05f66 (commit) via 62bf6ed986c26bf2802757a829546642206b9987 (commit) via 8066a1a6eb6260724d42d4416ee762a13bcc1629 (commit) via 7c9e44b24ec7f6cbe203ae5832924316a7601193 (commit) via 2b1da2aa0ced03f8afe56c4624ec77d49e5000a2 (commit) via 8ce23ea0e9a8820ff3a298e7f553e1bbf54d4bed (commit) via ece8a0c35c5843f0a0cd4ef94ff405e306aedef1 (commit) via 48880284867a96d8767e7d15f6bfe1a035b2ee6e (commit) via ea7e83b2712c48a0c9a157b2fb36eb782b26f34b (commit) via 6ce56f1134d99280af30e128f57189b285966180 (commit) via 0b565d1c7a46291bae89c5cc33fca246202c6988 (commit) from 6ba108f4eb18eb27a1b8be55b33b4e28df4b806f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31e9ac9a2c6e54e458a7f5bc49b83a2d05a83d2c Author: Joonas Kylmälä Date: Wed Nov 4 17:05:28 2020 +0200 Bug 26132: (follow-up) Fix broken code in TooMany function The $checkouts variable was not defined in the PatronLibrary case at all and in the else case the SQL join was totally missing. To test: 1) Without this patch notice prove t/db_dependent/Circulation/TooMany.t fails 2) With this patch notice prove t/db_dependent/Circulation/TooMany.t succeeds Signed-off-by: Jonathan Druart commit fe7abf020c6c13978ce84393b4877688b6f3ebce Author: Joonas Kylmälä Date: Wed Nov 4 17:00:02 2020 +0200 Bug 26132: (follow-up) Add test to show errors in max issues amount calculation If you set default branch limits for issue quantity circulation rules you will get errors when calling TooMany function. To reproduce the error: 1) Apply this patch 2) Run prove t/db_dependent/Circulation/TooMany.t and notice the following error: No method count found for Koha::Checkouts DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'item.homebranch' in 'where clause' [...] Signed-off-by: Jonathan Druart commit e700fb8f4ec323102d4cd6967bc4fb589ddc4032 Author: Nick Clemens Date: Fri Oct 16 11:47:24 2020 +0000 Bug 23823: (QA follow-up) Fix filter in link Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit fbeb3d547f1bacccfa585ec02e72494decc0e1a0 Author: Ivan Masár Date: Thu Oct 17 13:49:16 2019 +0200 Bug 23823: (follow-up) minor visual fix Do not allow a line break between the bookmark icon and syspref name. Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 6884665d55a304cb07c2e385a22e4a2868a66486 Author: Katrin Fischer Date: Fri Oct 11 02:18:41 2019 +0000 Bug 23823: (follow-up) Get rid of some tabs in favor of spaces In the paragraph touched by this patch, there were some whitespace issues. This patch does some tab to space replacement and reindentation to make the code more readable. Signed-off-by: Katrin Fischer Signed-off-by: Ivan Masár Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 43e6557a2ae1082f684fd073b476511730d05f66 Author: Ivan Masár Date: Wed Oct 16 13:17:37 2019 +0200 Bug 23823: Allow system preferences to be bookmarked Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference Signed-off-by: Katrin Fischer Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 62bf6ed986c26bf2802757a829546642206b9987 Author: Owen Leonard Date: Mon Oct 19 14:36:34 2020 +0000 Bug 26729: Add focus class to vendor name field in vendor add form This patch adds the "focus" class to the vendor name field in the form for adding or editing a vendor in acquisitions. To test, apply the patch and go to Acquisitions -> New vendor. On page load the cursor focus should automatically be on the vendor name field. The same should true when editing an existing vendor. Signed-off-by: Séverine QUEUNE Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8066a1a6eb6260724d42d4416ee762a13bcc1629 Author: Martin Renvoize Date: Wed Nov 4 11:08:30 2020 +0000 Bug 26745: (QA follow-up) Add Unit Tests Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 7c9e44b24ec7f6cbe203ae5832924316a7601193 Author: Martin Renvoize Date: Tue Oct 20 09:43:22 2020 +0100 Bug 26745: Add TT support to 'title' in notices This patch adds support for using TT syntax in the title element of the notices system. Test plan 1/ Edit an easily triggerable email notice such that the title contains some template toolkit markup. Example: Edit the 'CHECKOUT' notice to include [% today %] in the title field. 2/ Trigger the notice (For 'CHECKOUT' that means checking an item out to a user (Preferably with 'email' selected in their advanced messaging preferences for the notice) 3/ Either, navigate to the 'Notices' tab for the user, or run the message queue and inspect the subject line of the recieved email. 4/ Prior to the patch the TT syntax would remain 'as is'.. i.e '[% today %]'. 5/ After the patch, the TT syntax should have been properly replaced. 6/ Signoff Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2b1da2aa0ced03f8afe56c4624ec77d49e5000a2 Author: Lucas Gass Date: Mon Nov 2 23:39:21 2020 +0000 Bug 26804: (QA follow-up) add modal-lg class and intent markup correctly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8ce23ea0e9a8820ff3a298e7f553e1bbf54d4bed Author: Lucas Gass Date: Wed Oct 28 04:22:54 2020 +0000 Bug 26804: Add modal content preview This patch turns the 'News' column into a preview button. That preview button displays a modal with content of that rows news item. To test: 1. Apply patch 2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. ''. 3. Make sure and have some content with a lot of width and some content with a lot of height. 4. Test the Preview content button 5. Make sure you can scroll through long modals and across modals that are wide 6. Try at different screen sizes and with different combonations of News items Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ece8a0c35c5843f0a0cd4ef94ff405e306aedef1 Author: Jonathan Druart Date: Wed Nov 4 17:32:20 2020 +0100 Bug 26886: Compiled CSS Signed-off-by: Jonathan Druart commit 48880284867a96d8767e7d15f6bfe1a035b2ee6e Author: Owen Leonard Date: Mon Nov 2 13:43:27 2020 +0000 Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit ea7e83b2712c48a0c9a157b2fb36eb782b26f34b Author: Joonas Kylmälä Date: Tue Nov 3 12:27:14 2020 +0200 Bug 24567: (QA follow-up) Remove warning in regex Without this patch we get Use of uninitialized value $3 in concatenation (.) or string at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 943. This converts the | OR operator to two different regexes so that the capture group variables will be defined in every case. Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart commit 6ce56f1134d99280af30e128f57189b285966180 Author: Nick Clemens Date: Tue Oct 27 11:26:53 2020 +0000 Bug 24567: Don't strip spaces along with dangling colons This updates the regex used for removing colons to capture those with space on either side, and remove the colon while preserving the space To test: 1 - Have Koha using ES 2 - Search for: ti:chess AND chess 3 - You should get a result in sample data, otherwise replace 'chess' with a title in your catalogue 4 - Search for: ti:chess AND kw:chess 5 - No result 6 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate 7 - Repeate search and check page source 8 - search_query has: title:chess ANDchess 9 - Apply patch 10 - Repeat 11 - Seaerch works! 12 - query is now: title:chess AND chess Signed-off-by: Séverine QUEUNE Signed-off-by: Joonas Kylmälä Bug 24567: (follow-up) Use dollar sign to refer to captures Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart commit 0b565d1c7a46291bae89c5cc33fca246202c6988 Author: Owen Leonard Date: Mon Oct 19 13:36:04 2020 +0000 Bug 26736: Compare values of reports log entries This patch adds the ability to compare the log entries for reports in the system log. The user can select two entries in the log search results and view a diff of the two versions. To test, apply the patch and check that the ReportsLog system preference is enabled. If it isn't, enable it and make some changes to saved SQL reports so that you have log entries to test with. This is a trivial patch that simply adds "REPORTS" type log entries to the list of modules which can be selected for comparison. The full test plan is basically the same as that for Bug 26207: - Perform a search for log entries in the "Reports" module. - In the results, each entry for a report update should have a "Compare" checkbox." - Check one of the checkboxes. - The table should now be filtered by the report title. This facilitates meaningful selections for comparison. - You should see a message displayed onscreen, "Showing results for...[report name]" - The "Check none" link in the toolbar above the table should now be enabled. - If youy click the "Compare selected" link in the toolbar at this stage you should get a message, "You must select two entries to compare." - If you uncheck the checkbox the table should return to an unfiltered state. - Check two checkboxes. - The "Compare selected" link in the toolbar should now be enabled. - Next to each of the checkboxes you checked should be a "View comparison" link. - Clicking either of the "View comparison" links or the "Compare selected" link should trigger a modal with the diff view of the two reports log entries. - Try to select a third checkbox. You should get a message, "You can select a maximum of two checkboxes." The box should remain unchecked. - Test that unchecking both checkboxes manually clears the table filter. - Test that the "Check none" link works to uncheck checked boxes and clear the table filter. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 5 ++- C4/Letters.pm | 9 ++++ Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 3 +- .../prog/en/modules/acqui/supplier.tt | 2 +- .../prog/en/modules/admin/preferences.tt | 16 ++++--- .../prog/en/modules/tools/koha-news.tt | 24 ++++++++++- .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss | 5 +++ t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 9 ++-- t/db_dependent/Circulation/TooMany.t | 12 ++++++ t/db_dependent/Letters/TemplateToolkit.t | 50 +++++++++++++--------- 15 files changed, 103 insertions(+), 42 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Nov 5 01:55:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Nov 2020 00:55:08 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-1-g868319a463 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 868319a463631a27a5703e477c4387b6f37d4517 (commit) from 124a10469345ea4fcf8a2cddd914929ba25efdfe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 868319a463631a27a5703e477c4387b6f37d4517 Author: Owen Leonard Date: Mon Sep 21 10:59:56 2020 +0000 Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl This patch updates the JavaScript for checking and unchecking checkboxes on the Acquisitions planning page so that it doesn't require the checkboxes plugin. To test, apply the patch and go to Administration -> Budgets -> Budget details -> Planning. On the planning page, test the "Show all columns" and "Hide all columns" checkboxes. They should work correctly to show and hide the correct columns. Signed-off-by: Henry Bolshaw Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit be7c705d3bfba2044d4656e86b9e94c537c26945) Signed-off-by: Lucas Gass (cherry picked from commit 870369ae5732cc05ac681c70c8ef5191c9946497) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/acq.js | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Nov 5 02:10:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Nov 2020 01:10:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-3-g5add311155 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5add311155c577ace9d3990430b63f9b19af8733 (commit) via 241c22d337f35d06a0f9b6721a19f53f5f5f02c4 (commit) from 868319a463631a27a5703e477c4387b6f37d4517 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5add311155c577ace9d3990430b63f9b19af8733 Author: Aleisha Amohia Date: Thu Nov 5 13:29:15 2020 +1300 Bug 25242: Compile CSS Signed-off-by: Aleisha Amohia commit 241c22d337f35d06a0f9b6721a19f53f5f5f02c4 Author: Martin Renvoize Date: Tue Sep 1 17:11:24 2020 +0100 Bug 25242: Improve column wrapping for holdingst This patch attempts to improve the column wrapping for the holdingst datatable and sets the tabel to fixed width to prevent overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to an item with holdings visible in the OPAC 3/ 'Play' with various window sizes and zoom levels. 4/ The table should not overlap with right navigation content 5/ Signoff NOTE: This is an alternative patch to those pushed and reverted that attempted to provide a global fix to overlap issues. This patch specifically targets just the holdings table in the opac detail view. Signed-off-by: Timothy Alexis Vass Signed-off-by: Alexis Ripetti Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 6e5142e61be8604c5144077d15e3782e6853677b) Signed-off-by: Lucas Gass (cherry picked from commit 0c6c443d798c154057e76fd7dcc5803f17fe1fd8) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Nov 5 15:58:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Nov 2020 14:58:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1688-g6dd1dbc3a1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6dd1dbc3a117e8aa4a320b4d3c87458b4e74333d (commit) via 0efa25c86afad07cfcb4cd8a0ffe23e0e0c50dc7 (commit) via d31403133d7c54d5ceb0c095859f3d01d3c39d3a (commit) via 6dad46e0ec84a71e34fe8b7c557512b8da1ded97 (commit) via 946edb595b96c4e53a996461757770b6aa53d6e9 (commit) via 08ef42582fea11a4283a386ce6744939ee574e22 (commit) via f11659c48b55eefe02bd1e829b396cd68d8a105d (commit) via 2b298ece04d7d055acc38e56904b1c9e7bf7949e (commit) via ff87a03f94d352b55271ae2355498f71a8cd938a (commit) via d6b9032073f6ed95a09417cc5e02841184df0dbb (commit) via 932e2d05bca743d1862efd123f485d8c352fa778 (commit) via 57f58f29b158e0910c5c33d66619c07f88e7157c (commit) via 0351013fdf7bec4df828962d16716135ceae1a9a (commit) via ff5c4f151fa32d43858cef7619e7b6a34d30bc97 (commit) via eaabed085f9b7afcab53d793c5a8c796ad3b75f3 (commit) via d12c1f6a25ad74a11d2b57447791e5fba78e921a (commit) via 88b5b5d00ac04c5286dfeb5c05c674e82b3f2728 (commit) via a851aaeebf60e2da4ea9381151521e5f03a994c8 (commit) via 83bb93ccc96b69739900af559c5112602bc13490 (commit) via ddf8dfcad06f4ecc99495754299cea65e3be0ea2 (commit) via bea89005ca2e59dc3c082e872f2ba3c1872a2dd3 (commit) via cb3753d29254cb2f17661a36ddece56919ba980d (commit) via a10db1347dfbe5a444e669e363aab9b635d74069 (commit) via 0d438de0186fb08d2a1f8eb82b0df0204efff5ef (commit) via 31e38bc371943d1e76f49aacd1dd159a254f71e7 (commit) via 42c0475a948577442e44b11dbb12b45b25171418 (commit) via d3f8624315dc1c9327c0c7eaa23e9ff21d15032e (commit) from 31e9ac9a2c6e54e458a7f5bc49b83a2d05a83d2c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6dd1dbc3a117e8aa4a320b4d3c87458b4e74333d Author: Jonathan Druart Date: Thu Nov 5 11:07:01 2020 +0000 Bug 25334: DBRev 20.06.00.060 Signed-off-by: Jonathan Druart commit 0efa25c86afad07cfcb4cd8a0ffe23e0e0c50dc7 Author: Jonathan Druart Date: Thu Nov 5 14:12:56 2020 +0100 Bug 25334: MTT is itiva not talkingtech Signed-off-by: Jonathan Druart commit d31403133d7c54d5ceb0c095859f3d01d3c39d3a Author: Kyle M Hall Date: Tue Nov 3 13:21:24 2020 -0500 Bug 25334: (QA follow-up) Update overduerules.tt Signed-off-by: Jonathan Druart commit 6dad46e0ec84a71e34fe8b7c557512b8da1ded97 Author: Kyle M Hall Date: Tue Nov 3 18:13:28 2020 +0000 Bug 25334: (QA follow-up) Update opac messaging Signed-off-by: Jonathan Druart commit 946edb595b96c4e53a996461757770b6aa53d6e9 Author: Kyle M Hall Date: Thu Apr 30 13:35:48 2020 -0400 Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices Signed-off-by: Christopher Zorn Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 08ef42582fea11a4283a386ce6744939ee574e22 Author: Julian Maurice Date: Tue Jun 2 11:27:02 2020 +0400 Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Test plan: 1. Create a record with an item, and set the item's shelving location and itemtype. 2. Go to http:///cgi-bin/koha/ilsdi.pl?service=GetRecords&id= 3. Check that there is and and that their value is correct. Signed-off-by: Arthur Suzuki Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit f11659c48b55eefe02bd1e829b396cd68d8a105d Author: Owen Leonard Date: Mon Nov 2 18:13:04 2020 +0000 Bug 26148: OpenLibrary "Preview" link target is unclear to patrons This patch makes changes to the display of the Open Library "read" links in the OPAC search results and detail page. The link is now grouped with other details about the record ("Publisher," "Location(s)," etc. On the detail page, the "Preview" link will no longer appear under the cover image. The label is changed to "Found in Open Library," and the link now opens the Open Library reader in a new window. The patch also changes the Open Library button image links so that they use https and makes it so that the "Found in Open Library" information is hidden until the availability information has loaded. To test, apply the patch and enable the OpenLibrarySearch system preference. - Perform a search in the OPAC which will return results found in Open Library, e.g. "poetry" in the sample data. - Confirm that the "Read now" images from Open Library appear on some search results. - View the detail page for one of these titles. - Confirm that the "Read now" button appears in the same format on the detail page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 2b298ece04d7d055acc38e56904b1c9e7bf7949e Author: Jonathan Druart Date: Thu Nov 5 12:06:33 2020 +0100 Bug 26172: Compiled CSS Signed-off-by: Jonathan Druart commit ff87a03f94d352b55271ae2355498f71a8cd938a Author: Jonathan Druart Date: Tue Nov 3 11:40:57 2020 +0100 Bug 26172: Replace _result[set] calls Signed-off-by: Jonathan Druart commit d6b9032073f6ed95a09417cc5e02841184df0dbb Author: Martin Renvoize Date: Thu Oct 15 14:05:45 2020 +0100 Bug 26172: (QA follow-up) Add tests for previous cashups Signed-off-by: Jonathan Druart commit 932e2d05bca743d1862efd123f485d8c352fa778 Author: Jonathan Druart Date: Thu Oct 15 11:45:26 2020 +0200 Bug 26172: Fix return value for ->register There is a ON DELETE CASCADE clause on this FK Signed-off-by: Jonathan Druart commit 57f58f29b158e0910c5c33d66619c07f88e7157c Author: Martin Renvoize Date: Wed Oct 14 17:15:30 2020 +0100 Bug 26172: (QA follow-up) Add Unit Test Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 0351013fdf7bec4df828962d16716135ceae1a9a Author: Martin Renvoize Date: Wed Oct 14 17:14:47 2020 +0100 Bug 26172: (QA follow-up) Fix order of summary Signed-off-by: Jonathan Druart commit ff5c4f151fa32d43858cef7619e7b6a34d30bc97 Author: Katrin Fischer Date: Sun Oct 4 15:54:31 2020 +0000 Bug 26172: (QA follow-up) Add missing filter Signed-off-by: Jonathan Druart commit eaabed085f9b7afcab53d793c5a8c796ad3b75f3 Author: Martin Renvoize Date: Fri Aug 21 14:45:28 2020 +0100 Bug 26172: (follow-up) Add print option Signed-off-by: Sally Signed-off-by: Jonathan Druart commit d12c1f6a25ad74a11d2b57447791e5fba78e921a Author: Martin Renvoize Date: Fri Aug 21 14:09:46 2020 +0100 Bug 26172: (follow-up) Summary by payment_type This patch alters the modal so that the totals are broken down by payment type's available on the system. Signed-off-by: Sally Signed-off-by: Jonathan Druart commit 88b5b5d00ac04c5286dfeb5c05c674e82b3f2728 Author: Martin Renvoize Date: Fri Aug 7 10:15:20 2020 +0100 Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information Signed-off-by: Sally Signed-off-by: Jonathan Druart commit a851aaeebf60e2da4ea9381151521e5f03a994c8 Author: Tomas Cohen Arazi Date: Wed Sep 30 15:39:05 2020 -0300 Bug 26584: Remove unused C4::Acquisition::CloseBasket function This patch makes code use the new Koha::Acquisition::Basket->close method and makes CloseBasket obsolete. It then removes it, and adapts the few places in which it was used. 1. Apply this patch 2. Run: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 3. Try playing with baskets, closing them => SUCCESS: All works as expected! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 83bb93ccc96b69739900af559c5112602bc13490 Author: Tomas Cohen Arazi Date: Thu Oct 15 11:33:33 2020 -0300 Bug 26582: (QA follow-up) Rename closed => is_closed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ddf8dfcad06f4ecc99495754299cea65e3be0ea2 Author: Tomas Cohen Arazi Date: Wed Sep 30 14:40:54 2020 -0300 Bug 26582: Add Koha::Acquisition::Basket->close This patch adds two methods to Koha::Acquisition::Basket: - 'closed': that tells if the basket is closed - 'close': that closes the basket It inherits the behaviour from CloseBasket (as it actually makes sense). It improves CloseBasket by wrapping the action inside a transaction. It uses the $orders->update call with no_trigger as there's no trigger to trigger and the update can be done on a single DB call. A new exceptions file is added for basket-related exceptions. The only specific exception that gets added is Koha::Exceptions::Acquisition::Basket::AlreadyClosed To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit bea89005ca2e59dc3c082e872f2ba3c1872a2dd3 Author: Tomas Cohen Arazi Date: Wed Sep 30 14:40:36 2020 -0300 Bug 26582: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit cb3753d29254cb2f17661a36ddece56919ba980d Author: Jonathan Druart Date: Thu Nov 5 09:12:12 2020 +0100 Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, but more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit a10db1347dfbe5a444e669e363aab9b635d74069 Author: Martin Renvoize Date: Thu Nov 5 12:42:47 2020 +0000 Bug 26908: (follow-up) Alter template check This alters the template check to use the presence of the plugins arrayref rather than requiring a second call to check for plugins_enabled. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 0d438de0186fb08d2a1f8eb82b0df0204efff5ef Author: Kyle M Hall Date: Tue Nov 3 08:31:39 2020 -0500 Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 31e38bc371943d1e76f49aacd1dd159a254f71e7 Author: Jonathan Druart Date: Tue Nov 3 16:45:33 2020 +0100 Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules UPDATE: changed queries to not touch * values To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-5 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 42c0475a948577442e44b11dbb12b45b25171418 Author: Jonathan Druart Date: Wed Nov 4 09:04:19 2020 +0100 Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit d3f8624315dc1c9327c0c7eaa23e9ff21d15032e Author: Jonathan Druart Date: Wed Nov 4 17:36:06 2020 +0100 Bug 7143: Update about page for new dev - Ivan Masár Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 24 +- C4/ILSDI/Services.pm | 14 + C4/Letters.pm | 8 +- C4/Reserves.pm | 1 + Koha.pm | 2 +- Koha/Acquisition/Basket.pm | 48 +++ Koha/Cash/Register/Action.pm | 109 +++++++ Koha/EDI.pm | 4 +- .../Exceptions/{Token.pm => Acquisition/Basket.pm} | 23 +- acqui/basket.pl | 31 +- docs/contributors.yaml | 3 + .../mysql/mandatory/message_transport_types.sql | 1 + .../sample_notices_message_transports.sql | 9 +- installer/data/mysql/mandatory/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 42 +++ .../intranet-tmpl/prog/css/src/staff-global.scss | 33 ++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/includes/messaging-preference-form.inc | 34 +- .../prog/en/modules/admin/edi_accounts.tt | 2 +- .../prog/en/modules/admin/preferences/patrons.pref | 8 + .../intranet-tmpl/prog/en/modules/pos/register.tt | 78 ++++- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 9 +- .../prog/en/modules/tools/overduerules.tt | 4 + .../bootstrap/en/includes/opac-bottom.inc | 1 - .../bootstrap/en/includes/openlibrary-readapi.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +- .../bootstrap/en/modules/opac-messaging.tt | 20 ++ .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 5 +- koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 13 +- members/pay.pl | 2 +- t/db_dependent/Acquisition.t | 2 +- .../Acquisition/GetBasketsInfosByBookseller.t | 4 +- t/db_dependent/Acquisition/close_reopen_basket.t | 6 +- t/db_dependent/Koha/Acquisition/Basket.t | 76 ++++- t/db_dependent/Koha/Cash/Register/Action.t | 350 +++++++++++++++++++++ t/db_dependent/Letters.t | 2 +- 36 files changed, 894 insertions(+), 85 deletions(-) copy Koha/Exceptions/{Token.pm => Acquisition/Basket.pm} (58%) create mode 100755 t/db_dependent/Koha/Cash/Register/Action.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Nov 5 17:00:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Nov 2020 16:00:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1689-g880c9242a9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 880c9242a976e1b824af2ab5f048b1a0aa7b5496 (commit) from 6dd1dbc3a117e8aa4a320b4d3c87458b4e74333d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 880c9242a976e1b824af2ab5f048b1a0aa7b5496 Author: Jonathan Druart Date: Thu Nov 5 16:27:29 2020 +0100 Bug 16696: Fix search_utf8.t Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/www/search_utf8.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 6 16:27:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Nov 2020 15:27:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1755-gebb437349e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ebb437349ebbadf90599c23a46126e5d8eda72da (commit) via 76c95e585d7470905701ee469b1042474fce0604 (commit) via 234768752fd7448fcafe69d54772507c3492a6c3 (commit) via d1bc1015d9b61b4e9b67fd751e05275548d59f46 (commit) via 1deb47e793b6b3c146839e9d5fc29ff535fd13a2 (commit) via 8bd02f991942e307a8603304ffd29d8eb42343c4 (commit) via 671b013961037ab535693c2edce2eabb0fe0f128 (commit) via 1527fbd4ae3131611957a8d320f0890396b3d27f (commit) via 7d93405e599a4840f75a9a0fde8884f4f14ff4d9 (commit) via 0c6faea274318fd96311d91db28421f3886cb2db (commit) via d643bf75a032fddc4d7cefb8489182ae13b899a5 (commit) via 1008e21d430177ebf41f6a22ba29299228dba949 (commit) via b59799f298aab7b04547bcd7c29a2777e015a106 (commit) via e7d4bacfc67af5eaae7c477b2ac71753c76778ce (commit) via 7a07e111288de820e535dd35c024917d141129ad (commit) via ed0df15f5094c5cf5462488fd0aac48ddd613b35 (commit) via 2f7d2e327cb8631e2f1099a2169f439acc42da94 (commit) via c0830466c120ba9e0551cc40995b94e3c16ac7a1 (commit) via a008ad788c9a551c689ea616ac6191e409098284 (commit) via f806ae6277e95048851b32ecc70772e1793a5d43 (commit) via 3de906ac139852793ea06a41d7af284d6059e7bf (commit) via 351eb6c26d68342d8dc20fb8f68b7e28ba007820 (commit) via 66205054352cde0f597ff4236e0d95c34ebc8519 (commit) via ef8357437423e2b830af955b477be22ddb208d1c (commit) via 22029a296bb6f2581fead171cf98f4410ef4acb2 (commit) via 37f410a436ffc11a147f18e65911e9e2b17298aa (commit) via 47b32572d4d9c3195cf52ba02f1b6f845173c173 (commit) via d87090f3bb6d8761a485e35bbf4488339b84f6c1 (commit) via 017036f695df46df1fe3c2106b96b6285b0b9e83 (commit) via df2a7e4aa200ea9648d993241e75ef27e12fa103 (commit) via b7dd0d62ddf324a6f54dd3c6f7cb6babcd61ad2d (commit) via e5162d9135876227745f7e91fbd6fd9a61879a64 (commit) via 89b0a0563ca77f82e2915390b55d9f94fed71e68 (commit) via 47731f187f32d889ea45a2c2d567d67189d4753a (commit) via f7030fc0e1eea06f783fc98bfa95fb5c655143ae (commit) via 349591b3a4ee9620f4f4f337173efd84ab3227cf (commit) via 3865e38ebbb945ae8b7943d301a119da0e28b5c9 (commit) via 858c8943b7c3760fa7677077668c7d104dd5f9bc (commit) via 27c6399fb0fd3bd394cc010d31dc44f57dff79ee (commit) via c551b0719d40159fc145f56308eb368dea6f2acf (commit) via d5e3f431e77be4d80405aedd2ca36c23a4e4c413 (commit) via 085e5739db71e782fe5a848e0e2585c0f3c52f56 (commit) via 66444caeebfe1939edb1e886373fd38b360b9335 (commit) via 1e9b6e0e2aab88da4930e7cc35d0bec9c0c59f77 (commit) via c153adac098096ce3fa491a4d7b7a419ffc9f960 (commit) via 8ece86e769e4876f19df8e8a22c2d0774c55aed2 (commit) via 1bc723b33c1b3cb6baa67c277fe3ce64779fede1 (commit) via 114e851f8f3b3dd7c7d0fca627d3c0a4ff655302 (commit) via 24804aa4c61de8044e3666d7c3d010f65ecaf493 (commit) via 086927c9766faedce0dd73a5cd5a180000da2056 (commit) via 30b23c5f1df45ab2ffadc94494021b1189e75e13 (commit) via 5b1934312b87f8458de84d96421106774dbd95a8 (commit) via 3e1e9ddfcb7063e02ec0384d35ddb485ac3292de (commit) via f446debd6ea6410f57f26f4ccf63a65239710a09 (commit) via 3cfc2ec7bd1becef4386404fe7fc9f12740e8c97 (commit) via d5d736909ccd24b38e90e89b1484da73972d8645 (commit) via bbf0d21284924d6b7529017fc78178b98242aaee (commit) via b092bdd20d94a516db0b7c4533149ac52f96aac5 (commit) via 1e37d9c5f7af0f7e0efb226c171da52f03bc80eb (commit) via 709f307af7b51f42d79a68a09b31249daef32ec1 (commit) via e2032ccfd3102247ed2fe639ed0117ba7ac602d8 (commit) via d9a54e0d3387c3ad057a67c7e2b5c668154f65f6 (commit) via f18118f18f8930d4765abecafe43776ef42877d4 (commit) via 63960cbb89ec22c0f984c8d02d140e76af03c18a (commit) via b0ce0d646323de43739c454d0b8e665370768df1 (commit) via c1af56eb54043909f7e32b4597baa4f2d4d3e7dd (commit) from 880c9242a976e1b824af2ab5f048b1a0aa7b5496 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ebb437349ebbadf90599c23a46126e5d8eda72da Author: Kyle M Hall Date: Thu Nov 5 06:40:42 2020 -0500 Bug 26627: (QA follow-up) Remove barcode input by id Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart commit 76c95e585d7470905701ee469b1042474fce0604 Author: Jonathan Druart Date: Fri Nov 6 12:03:17 2020 +0000 Bug 14866: DBRev 20.06.00.063 Signed-off-by: Jonathan Druart commit 234768752fd7448fcafe69d54772507c3492a6c3 Author: Jonathan Druart Date: Tue Nov 3 16:57:52 2020 +0100 Bug 14866: Trivial code simplification Signed-off-by: Jonathan Druart commit d1bc1015d9b61b4e9b67fd751e05275548d59f46 Author: Katrin Fischer Date: Thu Oct 22 12:15:51 2020 +0000 Bug 14866: (QA follow-up) Add hint to system preferences Adds a hint about the new configuration option to the existing system preference sectoin. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 1deb47e793b6b3c146839e9d5fc29ff535fd13a2 Author: Aleisha Amohia Date: Mon Apr 20 14:31:27 2020 +0000 Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer Signed-off-by: Henry Bolshaw Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8bd02f991942e307a8603304ffd29d8eb42343c4 Author: Jonathan Druart Date: Fri Nov 6 12:03:17 2020 +0000 Bug 23091: DBRev 20.06.00.062 Signed-off-by: Jonathan Druart commit 671b013961037ab535693c2edce2eabb0fe0f128 Author: Tomas Cohen Arazi Date: Mon Oct 19 08:47:50 2020 -0300 Bug 23091: (QA follow-up) POD fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 1527fbd4ae3131611957a8d320f0890396b3d27f Author: Tomas Cohen Arazi Date: Fri Oct 16 16:51:07 2020 -0300 Bug 23091: Simplify tests by turning off AccountAutoReconcile Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 7d93405e599a4840f75a9a0fde8884f4f14ff4d9 Author: Tomas Cohen Arazi Date: Fri Oct 16 16:30:49 2020 -0300 Bug 23091: Add tests for \->credits and \->debits Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 0c6faea274318fd96311d91db28421f3886cb2db Author: Martin Renvoize Date: Wed Jul 15 11:23:38 2020 +0100 Bug 23091: Unit Tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit d643bf75a032fddc4d7cefb8489182ae13b899a5 Author: Martin Renvoize Date: Thu Sep 3 17:12:47 2020 +0100 Bug 23091: Move _Restore to Koha::Item store trigger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 1008e21d430177ebf41f6a22ba29299228dba949 Author: Martin Renvoize Date: Fri Jun 5 09:19:48 2020 +0100 Bug 23091: Add template handling for new messages This patch adds handling for the display of the two new messages added by this patchset in the returns screen. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b59799f298aab7b04547bcd7c29a2777e015a106 Author: Martin Renvoize Date: Tue Jul 14 13:59:06 2020 +0100 Bug 23091: Make relations more explicit This patch simply makes the queries built for the ->debits and ->credits relations in Koha::Account::Line more explicit. Test plan 1/ Ensure tests continue to pass 2/ Run tests with DBIC_TRACE=1 DBIC_TRACE_PROFILE=console and note that the related queries not include 'credit.' and 'debit.' as appropriate. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e7d4bacfc67af5eaae7c477b2ac71753c76778ce Author: Martin Renvoize Date: Mon Jul 13 15:51:24 2020 +0100 Bug 23091: Add tests for _RestoreOverdueForLostAndFound This patch adds unit tests for the newly introduced _RestoreOverdueForLostAndFound method in C4::Circulation. Test plan 1/ Read the new tests added to t/db_dependent/Circuation.t to ensure they make sense 2/ Run the tests and verify they pass 3/ Signoff Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7a07e111288de820e535dd35c024917d141129ad Author: Martin Renvoize Date: Wed Oct 23 11:32:28 2019 +0100 Bug 23091: Add handling for new lostreturn rules This patch adds handing for the new values available for the lostreturn policy settings. * undef - Do nothing, leave fees and fines as they were at the point of lose. * refund - Refund the lost item fee only * charge - Refund the lost item fee and charge a fresh overdue fine dated for a return on the date the item is 'found' * restore - Refund the lost item fee and restore the original overdue fine (dated for a 'return' on the date the item was 'lost' Test plan 1/ apply patch 2/ updatedatabase, restart_all 3/ verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee are on 4/ verify WhenLostForgiveFine is set to "Forgive" 5/ verify circ rules include fines 6/ set Default lost item fee refund on return policy to "Refund lost item charge" 7/ create 4 overdue checkouts that will incur fines 8/ run fines.pl 9/ confirm 4 items checked out with accruing fines 10/ confirm all 4 items have a replacement price Item 1 11/ mark the first item lost 12/ verify that fine is gone and lost fee has been charged 13/ check item in 14/ verify that lost fee is gone and overdue charge has not returned Item 2 15/ set Default lost item fee refund on return policy to "Refund lost item charge and charge new overdue fine" 16/ mark second item lost 17/ verify that fine is gone and lost fee has been charged 18/ check item in 19/ verify that lost fee is gone and a new overdue charge has been made Item 3 20/ set Default lost item fee refund on return policy to "Refund lost item charge and restore overdue fine" 21/ mark third item lost 22/ verify that fine is gone and lost fee has been charged 23/ check item in 24/ verify that lost fee is gone and the old overdue charge has been restored Item 4 25/ set Default lost item fee refund on return policy to "Leave lost item charge" 26/ mark fourth item lost 27/ verify that fine is gone and lost fee has been charged 28/ check item in 29/ verify that lost fee remains and the overdue charge is still gone Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ed0df15f5094c5cf5462488fd0aac48ddd613b35 Author: Martin Renvoize Date: Wed Jun 3 16:25:31 2020 +0100 Bug 23091: Update unit test This patch updates the unit test for get_lostreturn_policy to reflect the rule_name and return code changes. Test plan: 1/ Read the code changes in t/db_dependant/Koha/CirculationRules and t/db_dependant/Koha/IssuingRules and confirm they make sense. 2/ Run the updated tests and ensure they pass. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2f7d2e327cb8631e2f1099a2169f439acc42da94 Author: Martin Renvoize Date: Wed Jun 3 16:01:39 2020 +0100 Bug 23091: Database update This patch updates the 'refund' circulation rule to be called 'lostreturn' and populates the value with 'refund' where appropriate. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit c0830466c120ba9e0551cc40995b94e3c16ac7a1 Author: Jonathan Druart Date: Fri Nov 6 12:03:17 2020 +0000 Bug 24412: DBRev 20.06.00.061 Signed-off-by: Jonathan Druart commit a008ad788c9a551c689ea616ac6191e409098284 Author: Jonathan Druart Date: Fri Nov 6 12:01:11 2020 +0100 Bug 24412: DBIC schema changes Signed-off-by: Jonathan Druart commit f806ae6277e95048851b32ecc70772e1793a5d43 Author: Nicolas Legrand Date: Thu Nov 5 14:52:02 2020 +0100 Bug 24412: (follow-up) prevent js injection Some js variables are not properly escaped and can be executed if containing javascript. 1. have some waiting reserve attached to a desk 2. change this desk name to : 3. go to user's checkout page (circulation.pl) and click on the Hold(s) tab 4. you should see some popup with a ❤ in it. 5. apply patch and refresh page 6. now you should see the desk name printed properly in the page: Signed-off-by: Jonathan Druart commit 3de906ac139852793ea06a41d7af284d6059e7bf Author: Nicolas Legrand Date: Thu Nov 5 14:10:09 2020 +0100 Bug 24412: (follow-up) prevent request.pl from failing When no desk is defined request.pl returns an internal server error. Check a desk is defined before asking for reservation deskname. Plan test: 1. log in with a library with no desk 2. check in a reserved book so it'll be switch to “waiting reserve” 3. go to the book notice and click the Holds tab (request.pl page) 4. boum 5. apply patch, restart plack 6. refresh page 7. now loading properly Signed-off-by: Jonathan Druart commit 351eb6c26d68342d8dc20fb8f68b7e28ba007820 Author: Martin Renvoize Date: Fri Oct 23 15:46:03 2020 +0100 Bug 24412: (QA follow-up) Change CASCADE DELETE to SET NULL I don't believe waiting reserves should be removed if a desk is deleted, we should instead simply unset the desk. Signed-off-by: Jonathan Druart commit 66205054352cde0f597ff4236e0d95c34ebc8519 Author: Nicolas Legrand Date: Thu Oct 22 18:17:47 2020 +0200 Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit ef8357437423e2b830af955b477be22ddb208d1c Author: Nicolas Legrand Date: Thu Oct 22 13:31:15 2020 +0200 Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 22029a296bb6f2581fead171cf98f4410ef4acb2 Author: Nicolas Legrand Date: Wed Oct 21 13:29:00 2020 +0200 Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 37f410a436ffc11a147f18e65911e9e2b17298aa Author: Nicolas Legrand Date: Wed Oct 21 12:10:19 2020 +0200 Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 47b32572d4d9c3195cf52ba02f1b6f845173c173 Author: Nicolas Legrand Date: Mon Jan 13 17:56:41 2020 +0100 Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Bug 24412: (follow-up) Fix POD Koha::Desk and not Koha::Library... Signed-off-by: Jonathan Druart commit d87090f3bb6d8761a485e35bbf4488339b84f6c1 Author: Nicolas Legrand Date: Mon Jan 13 17:55:46 2020 +0100 Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 017036f695df46df1fe3c2106b96b6285b0b9e83 Author: Tomas Cohen Arazi Date: Tue Oct 20 14:36:22 2020 -0300 Bug 24633: (follow-up) Tweak sample plugin targets Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit df2a7e4aa200ea9648d993241e75ef27e12fa103 Author: Tomas Cohen Arazi Date: Tue Oct 20 14:29:38 2020 -0300 Bug 24633: Add support for gitlab searching of plugins This patch adds the option to add Gitlab repositories to look for Koha plugins. As with Github, plugin projects need to be named koha-plugin-* and the release file needs to be named with the .kpz extension. To test: 1. Apply this patchset 2. Check either koha-conf.xml or koha-conf.site.xml.in for sample configurations of gitlab targets. 3. Tweak your koha-conf.xml accordingly. You could have: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions gitlab PTFS Europe ptfs-europe github 4. Flush memcached and restart plack: $ flush_memcached $ koha-plack --restart kohadev 5. Open the plugins page, search for anything, like 'gobi' or 'a' => SUCCESS: You get Theke results! 6. Pick a gitlab plugin for install => SUCCESS: It is installed! 7. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b7dd0d62ddf324a6f54dd3c6f7cb6babcd61ad2d Author: Martin Renvoize Date: Fri Nov 6 12:48:28 2020 +0000 Bug 24665: (QA follow-up) Fix selection default This patch updates the html_helper for the cash register selection block to remove the 'empty option' such that it can be correclty set for each select case and updates all existing cases where we used the process block previously to include the relevant blank option '-- Select an option --', '-- None --', 'Library default' and finally the new '-- All --' options introduced with this bug. Signed-off-by: Jonathan Druart commit e5162d9135876227745f7e91fbd6fd9a61879a64 Author: Martin Renvoize Date: Tue Jul 21 14:54:09 2020 +0100 Bug 24665: Add support for filtering by cash register This patch makes it possible to filter on cash register on the cash register statistics page. To test: - Activate UseCashRegisters - Create a cash register or more to use - Create some manual fees and fines - Pay some of them off - Go to Tools > Cash register statistics - Test if the new filter for cash registers works as it should Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 89b0a0563ca77f82e2915390b55d9f94fed71e68 Author: Martin Renvoize Date: Fri Nov 6 14:42:42 2020 +0000 Bug 24786: (QA follow-up) Ensure tests pass with existing data The tests for Koha::Template::Plugin::Registers assumed that no registers were pre-set in the database. This patch updates the test to ignore pre-existing data or take it into account in totals. Signed-off-by: Jonathan Druart commit 47731f187f32d889ea45a2c2d567d67189d4753a Author: Martin Renvoize Date: Fri Nov 6 14:04:49 2020 +0000 Bug 24786: (QA follow-up) Reset beenSubmitted on validation failure When the form submision fails due to validation errors we need to also reset the preventFormDoubleSubmit state to allow for a second submission with corrected form fields. Signed-off-by: Jonathan Druart commit f7030fc0e1eea06f783fc98bfa95fb5c655143ae Author: Martin Renvoize Date: Fri Nov 6 11:51:30 2020 +0000 Bug 24786: (QA follow-up) Do not use 'hidden' attribute The hidden attribute for loading an element hidden is known to have issues and inconsistencies accross browsers. This patch instead updates the relevent input options to use an inline style of 'display: none' to hide the elements on page load and then .show, .hide for subsquent changes linked to the library branch picker change. Signed-off-by: Jonathan Druart commit 349591b3a4ee9620f4f4f337173efd84ab3227cf Author: Martin Renvoize Date: Fri Nov 6 10:55:13 2020 +0000 Bug 24786: (QA follow-up) Hide archived registers This patch hides archived registers from the list when useing the Registers template plugin. It also includes a check for UseCashRegisters so that if the preference is disabled after some registers have been defined then the plugin will no longer return the list regardless. Signed-off-by: Jonathan Druart commit 3865e38ebbb945ae8b7943d301a119da0e28b5c9 Author: Martin Renvoize Date: Fri Nov 6 10:53:56 2020 +0000 Bug 24786: (QA follow-up) Handle no defined registers This patch hides the register selection option from the login page if no registers have yet been defined on the system. Signed-off-by: Jonathan Druart commit 858c8943b7c3760fa7677077668c7d104dd5f9bc Author: Martin Renvoize Date: Wed Nov 4 12:53:59 2020 +0000 Bug 24786: (QA follow-up) Remove trailing space in classes The trailing space after branch in the class attribute for the register select options cause issues in the 'hasClass' javascript selector Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 27c6399fb0fd3bd394cc010d31dc44f57dff79ee Author: Martin Renvoize Date: Wed Nov 4 11:52:06 2020 +0000 Bug 24786: (QA follow-up) String fix This patch updates 'Branch default' to 'Library default' on the login page to match the coding terminology guidelines. We also update the table heading on the cash registers management page to match the terminology above for clarity. Signed-off-by: Jonathan Druart commit c551b0719d40159fc145f56308eb368dea6f2acf Author: Martin Renvoize Date: Thu Oct 15 17:03:04 2020 +0100 Bug 24786: (QA follow-up) Unit tests for Registers plugin To test: 1. Run the new unit test: t/db_dependent/Koha/Template/Plugin/Registers.t Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d5e3f431e77be4d80405aedd2ca36c23a4e4c413 Author: Martin Renvoize Date: Thu Oct 15 13:41:16 2020 +0100 Bug 24786: (QA follow-up) Add validation to paycollect This patch adds conditional validation to the cash register field on paycollect such that if 'CASH' is selected as the payment type and cash registers are enabled, then a cash register will be required. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 085e5739db71e782fe5a848e0e2585c0f3c52f56 Author: Martin Renvoize Date: Wed Oct 14 13:42:32 2020 +0100 Bug 24786: (QA follow-up) Fix Registers Plugin For the QA script we do not set a userenv, so we result in a failure due to a lack of checking for userenv prior to using it. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 66444caeebfe1939edb1e886373fd38b360b9335 Author: Martin Renvoize Date: Wed Oct 14 13:08:45 2020 +0100 Bug 24786: (QA follow-up) Make QA script happy with html_helpers Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 1e9b6e0e2aab88da4930e7cc35d0bec9c0c59f77 Author: Martin Renvoize Date: Wed Oct 14 13:01:38 2020 +0100 Bug 24786: (QA follow-up) POD Fixes Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c153adac098096ce3fa491a4d7b7a419ffc9f960 Author: Martin Renvoize Date: Fri Oct 2 10:19:14 2020 +0100 Bug 24786: Add validation to point of sale The Point of Sale page relied upon serverside validation prior to this patch; As such with the introduction of the ability to select '--None--' at the session register level (to require the librarian to pick their register for every transaction) we could result in a server error page. This patch introduced clientside validation to add checks for both the 'collected' and 'registerid' form fields. Test plan: 1/ Select a branch with cash registers available 2/ Select the '--None--' option for the session cash register 3/ Navigate to the point of sale page 4/ Attempt to make a sale without having picked your cash register 5/ Note that the submission was prevented and the fiedl is highlighted as required in red. 6/ Signoff Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8ece86e769e4876f19df8e8a22c2d0774c55aed2 Author: Martin Renvoize Date: Tue Aug 11 14:24:19 2020 +0100 Bug 24786: Default to 'branch default' on auth. If no branch is selected (i.e. 'My library') then we should default to 'branch default' if one is defined for the users library at login. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 1bc723b33c1b3cb6baa67c277fe3ce64779fede1 Author: Martin Renvoize Date: Tue Aug 4 13:27:06 2020 +0100 Bug 24786: (follow-up) Cache the register_name in the session This leads to one DB hit less per page load in the staff client when cash registers are enabled. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 114e851f8f3b3dd7c7d0fca627d3c0a4ff655302 Author: Martin Renvoize Date: Tue Jul 21 10:52:49 2020 +0100 Bug 24786: Update borroaccount to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the refund or payout action. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 24804aa4c61de8044e3666d7c3d010f65ecaf493 Author: Martin Renvoize Date: Tue Jul 21 10:30:09 2020 +0100 Bug 24786: Update paycollect to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the payment. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 086927c9766faedce0dd73a5cd5a180000da2056 Author: Martin Renvoize Date: Tue Jul 21 13:08:18 2020 +0100 Bug 24786: Update point of sale to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the sale. Test plan 1/ Enable cash registers via the 'UseCashRegisters' system preference 2/ Enable point of sale via the 'EnablePointOfSale' system preference 3/ Navigate to the point of sale page 4/ Note that if you are logged in at a branch with no cash registers yet defined, then an alert should appear 5/ Note that when you are logged in at a branch with cash regsiters defined, but without a cash register associated with your session then the cash 'Cash register' select box is populated with '-- None --' and you are required to select a register prior to submission 6/ Note that upon selection, the '-- None --' option is disabled 7/ Note that when you have a register associated with your session then the 'Cash register' select box is pre-populated with that register. 8/ Signoff Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 30b23c5f1df45ab2ffadc94494021b1189e75e13 Author: Martin Renvoize Date: Tue Jul 21 13:37:16 2020 +0100 Bug 24786: Allow selection of cash register at login Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5b1934312b87f8458de84d96421106774dbd95a8 Author: Martin Renvoize Date: Mon Jul 20 16:14:17 2020 +0100 Bug 24786: Allow setting a register for the session This patch adds the ability to set a register for the current session from the 'set library' page. Upon entering the page, the current selection will be displayed. Changing the branch will trigger the register select list to update to display only those registers associated with the updated branch and will automatically select either 'no register' or the 'branch default' register. The user can then override that selection to choose a different register for the session. Test plan 1/ Enable cash registers with the 'UseCashRegisters' system preference 2/ Select the 'Set library' option from the top right menu 3/ Note that you can now select a cash register from the subsequent page 4/ Change the branch and note that the cash register selection is updated to reflect the change 5/ Note that the 'branch default' register is auto-selected upon branch selection if one has been defined, otherwise '-- None --' is selected 6/ You can then alter the selection before submitting the form 7/ Once submitted note that you are returned to the page you were on prior to attempting to change the library and register 8/ Note the present of the register name next to the library name at the top of the screen. 9/ Signoff Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 3e1e9ddfcb7063e02ec0384d35ddb485ac3292de Author: Jonathan Druart Date: Fri Nov 6 15:30:39 2020 +0100 Bug 25067: Move the tests to db_dependent To not break the package workflow Signed-off-by: Jonathan Druart commit f446debd6ea6410f57f26f4ccf63a65239710a09 Author: Katrin Fischer Date: Sun Oct 4 18:07:08 2020 +0000 Bug 25067: (QA follow-up) Add +x on test files Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 3cfc2ec7bd1becef4386404fe7fc9f12740e8c97 Author: Julian Maurice Date: Sun Mar 29 14:56:20 2020 +0200 Bug 25067: Move PO file manipulation code into gulp tasks misc/translator/translate was doing three different things: - extract translatable strings - create or update PO files - install translated templates This patch separates responsibilities by moving the string extraction code into several 'xgettext-like' scripts and adds gulp tasks to automate string extraction and PO files update This has several benefits: - gulp runs tasks in parallel, so it's a lot faster (updating all PO files is at least 10 times faster with my 4-cores CPU) - there is no need for $KOHA_CONF to be defined LangInstaller.pm relied on $KOHA_CONF to get the different paths needed. I'm not sure why, since string extraction and PO update should work on source files, not installed files - string extraction code can be more easily tested This patch also brings a couple of fixes and improvements: - TT string extraction (strings wrapped in [% t(...) %]) was done with Template::Parser and PPI, which was extremely slow, and had some problems (see bug 24797). This is now done with Locale::XGettext::TT2 (new dependency) which is a lot faster, and fixes bug 24797 - Fix header in 4 PO files For backward compatibility, 'create' and 'update' commands of misc/translator/translate can still be used and will execute the corresponding gulp task Test plan: 1. Run `yarn install` and install Locale::XGettext::TT2 2. Run `gulp po:update` 3. Verify the contents of updated PO files 4. Run `cd misc/translator && ./translate install ` 5. Verify that all (templates, sysprefs, xslt, installer files) is correctly translated 6. Run `gulp po:create --lang ` and verify that it created all PO files for that language 7. Run `prove t/misc/translator` Signed-off-by: Bernardo Gonzalez Kriegel Need to install yarn & gulp, no errors Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d5d736909ccd24b38e90e89b1484da73972d8645 Author: Owen Leonard Date: Tue Nov 3 18:00:57 2020 +0000 Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the

is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary

is removed. - In the merge patrons template the submit button is now in a

as is consistent with other forms. - In the MARC modifications template I've added
s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a
and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit bbf0d21284924d6b7529017fc78178b98242aaee Author: Katrin Fischer Date: Sun Oct 18 16:30:24 2020 +0000 Bug 26727: Fix

appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b092bdd20d94a516db0b7c4533149ac52f96aac5 Author: Tomas Cohen Arazi Date: Thu Nov 5 11:53:43 2020 -0300 Bug 14708: (QA follow-up) Add tests This patch adds tests for the change. It also simplifies the delete() method structure a bit. It fixes the error 500 the tests were raising. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! The new behaviour (code 403) is tested! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 1e37d9c5f7af0f7e0efb226c171da52f03bc80eb Author: Kyle M Hall Date: Tue Nov 3 08:55:04 2020 -0500 Bug 14708: (QA follow-up) Use try/catch blocks when calling delete() on a patron Signed-off-by: Jonathan Druart commit 709f307af7b51f42d79a68a09b31249daef32ec1 Author: Kyle M Hall Date: Mon Nov 2 08:11:58 2020 -0500 Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower Signed-off-by: Jonathan Druart commit e2032ccfd3102247ed2fe639ed0117ba7ac602d8 Author: Kyle M Hall Date: Wed Apr 29 07:22:26 2020 -0400 Bug 14708: Don't allow merging of other patron records into Anonymous Patron Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d9a54e0d3387c3ad057a67c7e2b5c668154f65f6 Author: Kyle M Hall Date: Wed Apr 15 13:48:09 2020 -0400 Bug 14708: Don't allow merging of Anonymous Patron into other patron records Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f18118f18f8930d4765abecafe43776ef42877d4 Author: Kyle M Hall Date: Wed Apr 15 13:31:59 2020 -0400 Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 63960cbb89ec22c0f984c8d02d140e76af03c18a Author: Kyle M Hall Date: Wed Apr 15 12:48:02 2020 -0400 Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit b0ce0d646323de43739c454d0b8e665370768df1 Author: Kyle M Hall Date: Wed Feb 27 12:00:03 2019 -0500 Bug 14708: Enforce restriction in delete_patrons.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c1af56eb54043909f7e32b4597baa4f2d4d3e7dd Author: Kyle M Hall Date: Wed Feb 27 06:59:08 2019 -0500 Bug 14708: The patron set as the anonymous patron should not be deletable. Right now it's possible to delete the anonymous patron at any time. When this happens the system will break just as if anonymouspatron was unset but patrons still have an "always anonymize" privacy setting. This issue occurs more frequently than one would expect. We should make it so that the patron set in AnonymousPatron is not deletable. Test Plan: 1) Apply this patch 2) Set a patron to by AnonymousPatron 3) Attempt to delete that patron from the members toolbar 4) Note the error message! Signed-off-by: Devinim Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 32 +- C4/Circulation.pm | 86 ++- C4/Context.pm | 22 +- C4/Members.pm | 5 + C4/Reserves.pm | 6 +- Koha.pm | 2 +- Koha/Account/Line.pm | 8 +- Koha/CirculationRules.pm | 25 +- Koha/Exceptions/Patron.pm | 3 + Koha/Hold.pm | 16 +- Koha/Item.pm | 191 +++-- Koha/Patron.pm | 9 + Koha/REST/V1/Patrons.pm | 25 +- Koha/Schema/Result/Desk.pm | 19 +- Koha/Schema/Result/OldReserve.pm | 11 +- Koha/Schema/Result/Reserve.pm | 32 +- Koha/Template/Plugin/Registers.pm | 109 +++ admin/smart-rules.pl | 18 +- circ/returns.pl | 11 +- circ/set-library.pl | 31 +- cpanfile | 2 +- debian/templates/koha-conf-site.xml.in | 2 +- docs/development/internationalization.md | 121 ++++ etc/koha-conf.xml | 2 +- gulpfile.js | 302 +++++++- installer/data/mysql/kohastructure.sql | 6 +- installer/data/mysql/updatedatabase.pl | 32 + installer/onboarding.pl | 1 + koha-tmpl/intranet-tmpl/prog/css/login.css | 4 + .../intranet-tmpl/prog/en/includes/header.inc | 27 +- .../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- .../prog/en/includes/html_helpers.inc | 16 +- .../prog/en/includes/waiting_holds.inc | 2 +- .../prog/en/modules/admin/cash_registers.tt | 6 +- .../en/modules/admin/preferences/circulation.pref | 1 + .../prog/en/modules/admin/smart-rules.tt | 94 ++- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 13 + .../prog/en/modules/catalogue/detail.tt | 2 +- .../modules/cataloguing/value_builder/EXAMPLE.tt | 6 +- .../prog/en/modules/circ/request-article.tt | 1 - .../intranet-tmpl/prog/en/modules/circ/returns.tt | 9 +- .../prog/en/modules/circ/set-library.tt | 29 +- .../prog/en/modules/members/boraccount.tt | 30 +- .../prog/en/modules/members/merge-patrons.tt | 14 +- .../prog/en/modules/members/moremember.tt | 4 + .../prog/en/modules/members/paycollect.tt | 37 +- koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 25 +- .../prog/en/modules/reports/cash_register_stats.tt | 15 +- .../modules/tools/marc_modification_templates.tt | 142 ++-- koha-tmpl/intranet-tmpl/prog/js/holds.js | 9 +- .../intranet-tmpl/prog/js/register_selection.js | 27 + .../bootstrap/en/includes/holds-table.inc | 1 + members/boraccount.pl | 27 +- members/deletemem.pl | 18 +- members/paycollect.pl | 28 +- misc/cronjobs/delete_patrons.pl | 8 + misc/translator/LangInstaller.pm | 779 +++------------------ misc/translator/po/dz-pref.po | 10 +- misc/translator/po/gd-pref.po | 10 +- misc/translator/po/lv-pref.po | 10 +- misc/translator/po/te-pref.po | 10 +- misc/translator/tmpl_process3.pl | 122 +--- misc/translator/translate | 58 +- misc/translator/xgettext-installer | 158 +++++ misc/translator/xgettext-pref | 151 ++++ misc/translator/xgettext-tt2 | 56 ++ misc/translator/xgettext.pl | 17 +- package.json | 3 + plugins/plugins-home.pl | 32 + pos/pay.pl | 22 - reports/cash_register_stats.pl | 9 + reserve/request.pl | 1 + svc/holds | 7 + t/LangInstaller.t | 109 --- t/db_dependent/Circulation.t | 466 +++++++++++- t/db_dependent/DecreaseLoanHighHolds.t | 37 +- t/db_dependent/Koha/Account/Line.t | 13 +- t/db_dependent/Koha/CirculationRules.t | 60 +- t/db_dependent/Koha/Holds.t | 42 +- t/db_dependent/Koha/IssuingRules.t | 12 +- t/db_dependent/Koha/Items.t | 334 ++++++++- t/db_dependent/Koha/Patrons.t | 26 +- t/db_dependent/Koha/Template/Plugin/Registers.t | 183 +++++ t/db_dependent/Members.t | 12 +- t/db_dependent/api/v1/patrons.t | 8 +- t/db_dependent/misc/translator/sample.pref | 14 + .../misc/translator/sample.tt} | 2 +- t/db_dependent/misc/translator/sample.yml | 15 + .../misc/translator/xgettext-installer.t | 32 + t/db_dependent/misc/translator/xgettext-pref.t | 54 ++ t/db_dependent/misc/translator/xgettext-tt2.t | 74 ++ t/lib/Mocks.pm | 11 +- yarn.lock | 115 ++- 93 files changed, 3389 insertions(+), 1411 deletions(-) create mode 100644 Koha/Template/Plugin/Registers.pm create mode 100644 docs/development/internationalization.md create mode 100644 koha-tmpl/intranet-tmpl/prog/js/register_selection.js create mode 100755 misc/translator/xgettext-installer create mode 100755 misc/translator/xgettext-pref create mode 100755 misc/translator/xgettext-tt2 delete mode 100755 t/LangInstaller.t create mode 100755 t/db_dependent/Koha/Template/Plugin/Registers.t create mode 100644 t/db_dependent/misc/translator/sample.pref rename t/{LangInstaller/templates/simple.tt => db_dependent/misc/translator/sample.tt} (96%) create mode 100644 t/db_dependent/misc/translator/sample.yml create mode 100755 t/db_dependent/misc/translator/xgettext-installer.t create mode 100755 t/db_dependent/misc/translator/xgettext-pref.t create mode 100755 t/db_dependent/misc/translator/xgettext-tt2.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 12:14:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 11:14:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1761-g2ad424704f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2ad424704fc2ec7c6978fb24c1a292c52d188659 (commit) via 629c77b1af4dde6f0dceae1ce7a2d29fa2cf0eee (commit) via ee1c4ab7bf0bee9f8244fb3e03de438a56f0a1ba (commit) via f5017e4ed6c96b28780126e62b95d60210fd9eec (commit) via 47047348baa32646102258cfc92a9f1f77bf3153 (commit) via fbbd1695043c221f88b9f718f17b3297a94b1d66 (commit) from ebb437349ebbadf90599c23a46126e5d8eda72da (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ad424704fc2ec7c6978fb24c1a292c52d188659 Author: Jonathan Druart Date: Mon Nov 9 11:20:43 2020 +0100 Bug 26971: Remove obsolete test file translatable-templates.t After bug 25067 we found that this test file is failing with # Failed test 'opac_bootstrap templates are translatable' # at xt/author/translatable-templates.t line 91. # Unknown action specified. The original patches forgot to update this file. However when we tried to adjust it, we found that those tests are never working. Tried on 18.11.00 with a very ugly modified intranet-main.tt, the test was still passing. No idea how we can make it display warnings and so hard to fix the expected behaviour. I decided to remove it for now and see later if we need an updated test for the translate script. See also 25067 comment 84 Signed-off-by: Jonathan Druart commit 629c77b1af4dde6f0dceae1ce7a2d29fa2cf0eee Author: Martin Renvoize Date: Fri Nov 6 16:27:47 2020 +0000 Bug 24665: (QA follow-up) Add tests for 'selected' Add a unit test to prove the 'selected' param passed to Koha::Template::Plugin::Registers is adhered to. Signed-off-by: Jonathan Druart commit ee1c4ab7bf0bee9f8244fb3e03de438a56f0a1ba Author: Martin Renvoize Date: Fri Nov 6 16:19:15 2020 +0000 Bug 24786: (QA follow-up) Mock UseCashRegister in tests Signed-off-by: Jonathan Druart commit f5017e4ed6c96b28780126e62b95d60210fd9eec Author: Jonathan Druart Date: Fri Nov 6 17:06:44 2020 +0100 Bug 25067: Fix perlcritic errors Signed-off-by: Jonathan Druart commit 47047348baa32646102258cfc92a9f1f77bf3153 Author: Jonathan Druart Date: Fri Nov 6 17:03:33 2020 +0100 Bug 24786: Fix Script_cron.t and t/Koha/Script.t Signed-off-by: Jonathan Druart commit fbbd1695043c221f88b9f718f17b3297a94b1d66 Author: Jonathan Druart Date: Fri Nov 6 16:59:40 2020 +0100 Bug 25067: Adjust paths in tests Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: misc/translator/xgettext-installer | 6 +- t/Koha/Script.t | 2 + t/Koha/Script_cron.t | 2 + t/db_dependent/Koha/Template/Plugin/Registers.t | 28 ++++++- .../misc/translator/xgettext-installer.t | 2 +- t/db_dependent/misc/translator/xgettext-pref.t | 2 +- t/db_dependent/misc/translator/xgettext-tt2.t | 2 +- xt/author/translatable-templates.t | 94 ---------------------- 8 files changed, 35 insertions(+), 103 deletions(-) delete mode 100755 xt/author/translatable-templates.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 20:03:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 19:03:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-1-gf095fc1aef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via f095fc1aeffaabd9d54f7df0378f226b0d2e0729 (commit) from 9c29220b0c2d4b225622b662efb3bea5185bca11 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f095fc1aeffaabd9d54f7df0378f226b0d2e0729 Author: Marcel de Rooy Date: Tue Aug 11 11:22:22 2020 +0000 Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b827acf53ffde71d787123095b8524ea6bd08fd6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 20:10:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 19:10:12 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-2-g48757bd379 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 48757bd3790dbf6d3091ea3b3f78acbe82be2f01 (commit) from f095fc1aeffaabd9d54f7df0378f226b0d2e0729 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48757bd3790dbf6d3091ea3b3f78acbe82be2f01 Author: Owen Leonard Date: Mon Sep 28 11:46:17 2020 +0000 Bug 26551: Correct modal markup to prevent long heading from overflowing This patch modifies the markup of the MARC framework import and export modals so that CSS intended only for Bootstrap buttons isn't applied to content in the modal. The modal dialog markup was nested inside a ".btn-group"

, which carries with it CSS that prevents text wrapping. Moving the modal markup out of the button group while keeping it inside the corrects the problem. Lines have only been shifted and reindented. To test, apply the patch and go to Administration -> MARC bibliographic framework. - In the table of frameworks, from the "Actions" menu, test both the "Import" and "Export" links. Both should work as expected. - Confirm that the text of the heading on the "Import" modal wraps correctly. - Test the same operations for a framework other than the default one. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit c21de86ab2d1bf5c147dfd453b195a441603e118) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/biblio_framework.tt | 192 ++++++++++----------- 1 file changed, 96 insertions(+), 96 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 20:13:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 19:13:29 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-3-gcdae3766a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cdae3766a41948ca846a6a3642d747b8e6ea210a (commit) from 48757bd3790dbf6d3091ea3b3f78acbe82be2f01 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cdae3766a41948ca846a6a3642d747b8e6ea210a Author: Andreas Roussos Date: Mon Sep 14 09:39:44 2020 +0200 Bug 26449: fix web installer typo The onboarding segment of the web installer contains a small typo in Step 4: "Importantl:" (should be "Important:"). This patch fixes that. Test plan: apply the patch and access the web installer, Step 4 of the onboarding tool should no longer display the typo. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 5f5e6c85d9d86196da802b2d9155b0d7cafad2da) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 20:17:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 19:17:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-4-g6dbbd46149 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6dbbd46149e951473d00700916b31ab209682883 (commit) from cdae3766a41948ca846a6a3642d747b8e6ea210a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6dbbd46149e951473d00700916b31ab209682883 Author: Lucas Gass Date: Fri Aug 7 18:17:49 2020 +0000 Bug 26184: Add div element to 'items available' note in OPAC reserve template Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit bc61f27b2203d8f7f0dadbf7a13bb4c66e346244) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 20:26:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 19:26:44 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-5-gcfc14edbcc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cfc14edbccce05f2983677a147d56781bc111cfa (commit) from 6dbbd46149e951473d00700916b31ab209682883 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cfc14edbccce05f2983677a147d56781bc111cfa Author: Marcel de Rooy Date: Fri Oct 2 06:28:06 2020 +0000 Bug 26600: Missing module in Elasticsearch/Indexer.pm Just formally needed. It is already loaded somewhere. That is: Koha::SearchEngine::Elasticsearch. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 6deb177576f8cb6d1fc02da6555f023f6c27e1d5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/Indexer.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 20:32:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 19:32:46 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-6-g1ee8f1f1c2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 1ee8f1f1c205d2c532ef028cf86a83405ba9e469 (commit) from cfc14edbccce05f2983677a147d56781bc111cfa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1ee8f1f1c205d2c532ef028cf86a83405ba9e469 Author: Marcel de Rooy Date: Fri Oct 2 06:20:38 2020 +0000 Bug 26599: Unused parameter name in POD of ModZebra This patch removes the $record reference in POD. Nothing else ;) Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 0113df1a7a9495423533b3fe75b8a90c04d056be) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 22:00:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 21:00:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-7-g8a5898aab8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8a5898aab879989490ac1fcdb0dce0c7436e6cb5 (commit) from 1ee8f1f1c205d2c532ef028cf86a83405ba9e469 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8a5898aab879989490ac1fcdb0dce0c7436e6cb5 Author: Matthias Meusburger Date: Tue Sep 22 15:16:23 2020 +0200 Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Currently, Koha::Account::pay will fail if no user is logged-in when it is called. In this case, this patch will use undef instead of 0 for $manager_id in order to comply with the foreign key constraint on manager_id. Signed-off-by: Magnus Enger Biblibre and Libriotech have created a OPAC payment plugin that was having problems because of this bug. Applying the fix in this patch to a live server solved the problem. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 63c93d3c114c6720100cd2b843e8989a1a0eecb7) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Account.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 9 22:04:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Nov 2020 21:04:02 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-8-g2138e5af52 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2138e5af52fa27eab17c9ec5adda4d73b837a71f (commit) from 8a5898aab879989490ac1fcdb0dce0c7436e6cb5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2138e5af52fa27eab17c9ec5adda4d73b837a71f Author: Martin Renvoize Date: Thu Oct 1 14:33:46 2020 +0100 Bug 26506: (QA follow-up) Add Unit Test Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit ae475eb15a4b1c8b5c49c1c4f79388c9e1d7686a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Account.t | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 10 15:32:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Nov 2020 14:32:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1791-gf8206ca60c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f8206ca60cb1bbd32a90b7898a6877166026b8bb (commit) via bd66a2e175e062b662652f81efcafb48b6d230d7 (commit) via e5ba5f406899c554ccc71212cbee5531b91c3f41 (commit) via df9b697cd4a24dce2a385ba34e8c98ff4135d527 (commit) via e00d07fe793e3bdc383c5a9963427a39a735b1f3 (commit) via 8dd313fc4ab40843210eaa32454e306cbbc20bba (commit) via 61a39b0dd52df4f6d743671823449e265d6add26 (commit) via b854e285f1b77b62bb8b9e28c5b532e1c4dead94 (commit) via aebf7f2756c585512576ea5dc3ff03f17ba1610a (commit) via 2de7a4c04e4924ee316623f8ab89be8e16461ee4 (commit) via 3c388b88c4e6638d545dd0c99574107f9af7477a (commit) via 27d64e1720f79d95013de80278fcd71fbf765c04 (commit) via 4defe532df94d515c850423c2f9b0a18c9dfdbae (commit) via 55ac67d95b6b4cd2459385a7aae2e24de410925a (commit) via 838be5e5168e96f1c0f212019af4909abb42f5c2 (commit) via 87e305a401d778f1d28bc74086d050ea8f42f7a2 (commit) via b676dd376bd3695db1581d0ad4a883b5ac286f1a (commit) via e7587f6c8bfa4e992408cfa16bb835e9edfdc1a3 (commit) via eb283d13fab70d8a32216a5bee8fb4a71e6d875e (commit) via d01f78e2d573076df71e0505548193da736b05bd (commit) via b46c1a037809a92c6ee0667dd5e559dc2f743f6a (commit) via 4dfa570936db87dfe79fcb0a8830054065efa077 (commit) via 0ad4e7c7c3904ad9e2feec9f6fb0ffb274998491 (commit) via 6f1aa37cc5bfd7ec0e3f29ce74657ba62867c45c (commit) via 381d46341c7061f649400975a3c5b7a008feba64 (commit) via 960d282e3b99ae5f4e7a6522824e0fa1edb394ed (commit) via 9bf00d32489edf78db92139d2d87841b6e970882 (commit) via 9c709b871f5f5c2887eefb81a3f93a8ad76fb8d0 (commit) via 8d2259b67443f75675733d41773d153d889dffd7 (commit) via 904e926ba0f407b24aa3d94be5afe37b5e3ec075 (commit) from 2ad424704fc2ec7c6978fb24c1a292c52d188659 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8206ca60cb1bbd32a90b7898a6877166026b8bb Author: Kyle M Hall Date: Thu Nov 5 06:48:04 2020 -0500 Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method Signed-off-by: Jonathan Druart commit bd66a2e175e062b662652f81efcafb48b6d230d7 Author: Fridolin Somers Date: Thu Oct 1 14:19:05 2020 +0200 Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit e5ba5f406899c554ccc71212cbee5531b91c3f41 Author: Fridolin Somers Date: Fri Oct 2 09:22:36 2020 +0200 Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit df9b697cd4a24dce2a385ba34e8c98ff4135d527 Author: Jonathan Druart Date: Tue Nov 10 13:32:09 2020 +0000 Bug 23916: DBRev 20.06.00.065 Signed-off-by: Jonathan Druart commit e00d07fe793e3bdc383c5a9963427a39a735b1f3 Author: Tomas Cohen Arazi Date: Tue Nov 10 08:53:16 2020 -0300 Bug 23916: Allow embedding the issuer object Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 8dd313fc4ab40843210eaa32454e306cbbc20bba Author: Jonathan Druart Date: Tue Nov 10 14:45:57 2020 +0100 Bug 23916: (follow-up) Adapt all the things to the new column and accessor names Signed-off-by: Jonathan Druart commit 61a39b0dd52df4f6d743671823449e265d6add26 Author: Tomas Cohen Arazi Date: Tue Nov 10 08:47:29 2020 -0300 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b854e285f1b77b62bb8b9e28c5b532e1c4dead94 Author: Tomas Cohen Arazi Date: Tue Nov 10 08:46:43 2020 -0300 Bug 23916: Add new attribute to API Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit aebf7f2756c585512576ea5dc3ff03f17ba1610a Author: Tomas Cohen Arazi Date: Tue Nov 10 08:46:18 2020 -0300 Bug 23916: (QA follow-up) Rename issuer => issuer_id [DB] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2de7a4c04e4924ee316623f8ab89be8e16461ee4 Author: Jonathan Druart Date: Mon Nov 9 14:24:22 2020 +0100 Bug 23916: (follow-up) Add unit tests Fix perlcritic error Subroutine "new" called using indirect syntax at line 128, column 14. See page 349 of PBP. (Severity: 4) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 3c388b88c4e6638d545dd0c99574107f9af7477a Author: Nick Clemens Date: Sat Oct 24 02:56:15 2020 +0000 Bug 23916: (QA follow-up) Remove stray changes and fix typo There were a couple changes that had no effect, so cleaned those up Typo 'is' for 'if' Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 27d64e1720f79d95013de80278fcd71fbf765c04 Author: Andrew Isherwood Date: Fri Oct 23 11:55:44 2020 +0100 Bug 23916: (follow-up) Fix unit test This commit responds to the comment made by Katrin in comment #73. I have removed the lines cited as causing the contraint violation. The were added in the original iteration of the bug patches and, despite spending time trying to get to the bottom of it, I cannot figure out why. There are no changes in the patchset relating to Koha/Patron.pm and removing the lines does not cause any of the tests in files that *are* affected by this patchset to fail. I do not know why these lines were ever added in the first place, unfortunately I did not add comments explaining (lesson learned)! Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 4defe532df94d515c850423c2f9b0a18c9dfdbae Author: Andrew Isherwood Date: Mon Oct 19 12:55:18 2020 +0100 Bug 23916: (follow-up) Rebase unit tests This commit is a response to Katrin's comments in comment #62: - Fixed merge conflict It also fixes a test which now fails due to an upstream change in C4::Circulation Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 55ac67d95b6b4cd2459385a7aae2e24de410925a Author: Andrew Isherwood Date: Mon Oct 12 10:28:33 2020 +0100 Bug 23916: (follow-up) Fix terminology, use patron-title and make column consistent in issues and old_issues This commit makes the changes suggested by Katrin in comment #50: - Changed syspref from RecordIssuer to RecordStaffUserOnCheckout - Changed terminology from "issue" to "check out" and variations - Fixed name display to use patron-title.inc - Made issuer column DEFAULT NULL consistently between issues and old_issues and between the DB update and kohastructure.sql Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 838be5e5168e96f1c0f212019af4909abb42f5c2 Author: Andrew Isherwood Date: Thu Sep 24 13:55:55 2020 +0100 Bug 23916: (follow-up) Don't anonymise issuer and don't update action_logs on upgrade This commit implements the two suggestions made by Nick in comment #41: - Removes the attempted retrospective addition of issuers to old issues. It was not particularly reliable, it also is not appropriate if the user does not wish to make use of this functionality - Removes the conversion of a NULL issuer to the anonymous borrowernumber when anonymising checkouts Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 87e305a401d778f1d28bc74086d050ea8f42f7a2 Author: Andrew Isherwood Date: Mon Nov 18 12:30:27 2019 +0000 Bug 23916: (follow-up) Fix column name collision Seems that joining 'borrowers' into the query run in C4::Members::GetAllIssues caused a column name collision, which blatted the retrieval of issues.branchcode. So we now are being a bit more specific in what is coming from where in the query. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b676dd376bd3695db1581d0ad4a883b5ac286f1a Author: Andrew Isherwood Date: Thu Oct 31 14:26:18 2019 +0000 Bug 23916: Add unit tests This patch adds unit tests for the new functions Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e7587f6c8bfa4e992408cfa16bb835e9edfdc1a3 Author: Andrew Isherwood Date: Thu Oct 31 10:45:41 2019 +0000 Bug 23916: Anonymise 'issuer' when required This patch adds the anonymisation of 'old_issues.issuer' alongside the existing anonymisation of 'old_issues.borrowernumber' Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit eb283d13fab70d8a32216a5bee8fb4a71e6d875e Author: Andrew Isherwood Date: Mon Mar 2 11:04:59 2020 +0000 Bug 23916: Record and display item issuer This patch adds the recording and display of the item issuer. This behaviour is governed by the RecordIssuer syspref, if disabled (the default), no recording or display of issuer will take place. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit d01f78e2d573076df71e0505548193da736b05bd Author: Andrew Isherwood Date: Thu Oct 31 10:22:24 2019 +0000 Bug 23916: Add "RecordIssuer" syspref This patch adds the "RecordIssuer" syspref, which is disabled by default Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b46c1a037809a92c6ee0667dd5e559dc2f743f6a Author: Andrew Isherwood Date: Thu Oct 31 10:08:42 2019 +0000 Bug 23916: Add issues.issuer column and FK This patch adds the issues.issuer column which is a foreign key to borrowers.borrowernumber Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 4dfa570936db87dfe79fcb0a8830054065efa077 Author: Martin Renvoize Date: Fri Oct 16 15:57:30 2020 +0100 Bug 26697: Make account.inc consistent between staff and opac Test plan - Regression 1/ Login to the OPAC as a user with various account charges and payments. 2/ Navigate to the 'Your charges' page. 3/ Compare the display of the table before and after applying the patchset. They should match. Test plan - Sync 1/ Compare koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc with koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc. 2/ They files should match after the patch is applied. Test plan - Translation 1) ./translate update fr-CA 2) Open fr-CA-opac-bootstrap.po and translated this part msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %s%s %s %s %s " 3) ./translate install fr-CA 4) Login to the OPAC as a patron with various charges 5) Check 'My charges' (in fr-CA) to confirm the translations have been picked up. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 0ad4e7c7c3904ad9e2feec9f6fb0ffb274998491 Author: Jonathan Druart Date: Tue Nov 10 13:32:09 2020 +0000 Bug 24603: DBRev 20.06.00.064 Signed-off-by: Jonathan Druart commit 6f1aa37cc5bfd7ec0e3f29ce74657ba62867c45c Author: Jonathan Druart Date: Thu Nov 5 14:40:29 2020 +0100 Bug 24603: Simplify tests using TestBuilder Signed-off-by: Jonathan Druart commit 381d46341c7061f649400975a3c5b7a008feba64 Author: Jonathan Druart Date: Thu Nov 5 14:39:53 2020 +0100 Bug 24603: Adjust permissions for cancel-charge.pl members/cancel-charge.pl should have the same permissions check than boraccount (borrowers => edit_borrowers was missing) Signed-off-by: Jonathan Druart commit 960d282e3b99ae5f4e7a6522824e0fa1edb394ed Author: Martin Renvoize Date: Fri Oct 16 16:23:10 2020 +0100 Bug 24603: (QA follow-up) Add translation to OPAC Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 9bf00d32489edf78db92139d2d87841b6e970882 Author: Katrin Fischer Date: Mon Oct 5 13:24:40 2020 +0000 Bug 24603: (QA follow-up) Make the new credit type translatable and shorten description a bit Adding the new offset type and credit type to the include so it can be translated. Also suggest shortening the db description a bit. Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 Signed-off-by: Jonathan Druart commit 9c709b871f5f5c2887eefb81a3f93a8ad76fb8d0 Author: Martin Renvoize Date: Fri Jul 10 14:49:35 2020 +0100 Bug 24603: (follow-up) Update to double entry accounting This patch updates the logic to create a cancellation accountline and apply it to the charge line so we correction record the transaction in terms of double entry accounting standards. Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. A cancellation line should be associated with the original charge. 5. Create another manual invoice 6. Pay it (partially or fully) 7. Notice that the 'Cancel charge' button is not available 8. Void the payment 9. 'Cancel charge' button is available again. Click on it and verify that it still works 10. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 Bug 24603: Fix number of unit tests Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 Signed-off-by: Jonathan Druart commit 8d2259b67443f75675733d41773d153d889dffd7 Author: Julian Maurice Date: Thu Feb 6 14:13:44 2020 +0100 Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 904e926ba0f407b24aa3d94be5afe37b5e3ec075 Author: Fridolin Somers Date: Tue Nov 3 09:19:34 2020 +0100 Bug 26904: OPAC password recovery allows regexp in email When using OPAC password recovery form, opac/opac-password-recovery.pl : if one provides correct login and an email, there is a check that this email is one of patron's. This check uses RegExp with case insensitive : if ( $email && !( any { /^$email$/i } @emails ) ) This is a security issue since one can simply enter '.*'. Severity is normal because the login must be a correct. I propose to use simple string compare with lowercase to be case insensitive. Test plan : 1) Don't apply patch 2) Enable system preference 'OpacResetPassword' 3) Go to 'OPAC > Log in to your account > Forgot your password?' 4) Enter an existing userid or cardnumber and '.*' in 'Email' 5) The password recovery is created ! (check table 'borrower_password_recovery') 6) Apply patch 7) Enter an existing userid or cardnumber and '.*' in 'Email' 8) You get the message 'No account was found with the provided information.' 9) Enter an existing userid or cardnumber and in 'Email' the corresponding email but with different case 10) The password recovery is created (check table 'borrower_password_recovery') Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 12 +++ C4/Members.pm | 10 +- Koha.pm | 2 +- Koha/Account/Line.pm | 97 +++++++++++++++++- Koha/Checkout.pm | 15 +++ Koha/Old/Checkout.pm | 15 +++ Koha/Patron.pm | 4 + Koha/Patron/Debarments.pm | 14 +-- Koha/Schema/Result/Borrower.pm | 34 ++++++- Koha/Schema/Result/Issue.pm | 32 +++++- Koha/Schema/Result/OldIssue.pm | 32 +++++- api/v1/swagger/definitions/checkout.json | 13 ++- api/v1/swagger/paths/checkouts.json | 10 +- installer/data/mysql/kohastructure.sql | 9 +- .../data/mysql/mandatory/account_credit_types.sql | 3 +- .../data/mysql/mandatory/account_offset_types.sql | 3 +- installer/data/mysql/mandatory/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 35 +++++++ .../intranet-tmpl/prog/en/includes/accounts.inc | 71 ++++++------- .../en/modules/admin/preferences/circulation.pref | 7 ++ .../prog/en/modules/catalogue/issuehistory.tt | 10 ++ .../prog/en/modules/members/boraccount.tt | 17 +++- .../prog/en/modules/members/readingrec.tt | 6 ++ .../bootstrap/en/includes/account-table.inc | 48 +-------- .../bootstrap}/en/includes/accounts.inc | 71 ++++++------- members/boraccount.pl | 6 ++ members/cancel-charge.pl | 57 +++++++++++ opac/opac-password-recovery.pl | 2 +- t/db_dependent/Circulation.t | 49 ++++++++- t/db_dependent/Koha/Account/Line.t | 111 ++++++++++++++++++++- t/db_dependent/Koha/Checkouts.t | 32 +++++- t/db_dependent/Patron/Borrower_Debarments.t | 35 ++++++- 32 files changed, 708 insertions(+), 155 deletions(-) copy koha-tmpl/{intranet-tmpl/prog => opac-tmpl/bootstrap}/en/includes/accounts.inc (81%) create mode 100755 members/cancel-charge.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 10 23:59:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Nov 2020 22:59:50 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-9-gd031520710 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d031520710b85061051edc6ed4890aa9374bdf92 (commit) from 2138e5af52fa27eab17c9ec5adda4d73b837a71f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d031520710b85061051edc6ed4890aa9374bdf92 Author: Jonathan Druart Date: Thu Oct 8 11:33:23 2020 +0200 Bug 26137: Remove warnings from viewlog.pl The warnings are Use of uninitialized value $val in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 138. Problem = a value of has been passed to param without key at /kohadevbox/koha/C4/Templates.pm line 138. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 8b541714a177fc141c77967c8fc528c5c5453139) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: tools/viewlog.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 11 00:07:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Nov 2020 23:07:45 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-10-g8c527522ec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8c527522ec02c4b07c57c5a211d846856c936018 (commit) from d031520710b85061051edc6ed4890aa9374bdf92 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c527522ec02c4b07c57c5a211d846856c936018 Author: Kyle M Hall Date: Fri Oct 2 12:11:48 2020 -0400 Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott Signed-off-by: Martin Renvoize JD Test plan: 1. Create a new subscription * When there is an irregular issue: Skip issue number * Select a frequency (not irregular) * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field 2. Receive a first serial (mark it arrived, an "expected" one is created) 3. Claim the expected one => You have 1 arrived and 1 claimed. It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl 4. Generate next => boom Signed-off-by: Jonathan Druart (cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: serials/serials-collection.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 11 00:23:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Nov 2020 23:23:39 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-11-g97cb735a7f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 97cb735a7f4402822ba1c4f9cf6141187be10348 (commit) from 8c527522ec02c4b07c57c5a211d846856c936018 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 97cb735a7f4402822ba1c4f9cf6141187be10348 Author: Jonathan Druart Date: Wed Oct 14 11:17:46 2020 +0200 Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan Signed-off-by: Jonathan Druart (cherry picked from commit c32503fcb685e3bba209ba7baba1abe560fda94c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: offline_circ/process_koc.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 11 00:28:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Nov 2020 23:28:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-12-gd3254f7e57 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d3254f7e5726cdfb3572ae42eec057e90c25407d (commit) from 97cb735a7f4402822ba1c4f9cf6141187be10348 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3254f7e5726cdfb3572ae42eec057e90c25407d Author: Alex Buckley Date: Tue Sep 29 05:53:34 2020 +0000 Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Test plan: 1. Check the OAI-PMH:AutoUpdateSets syspref is disabled 2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass successfully 3. Enabled the OAI-PMH:AutoUpdateSets syspref 4. Repeat step 2 and confirm the tests fail 5. Apply this patch and restart plack: sudo koha-plack --restart 6. Repeat step 2 and confirm the tests now pass 7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and confirm tests still pass Sponsored-By: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 913897f3a484ea31a2373de7aac2cc8298319575) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/OAI/Sets.t | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 11 00:36:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Nov 2020 23:36:12 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-13-ge6752ed581 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e6752ed58166407bf8e2e353e4acde5815df2a02 (commit) from d3254f7e5726cdfb3572ae42eec057e90c25407d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e6752ed58166407bf8e2e353e4acde5815df2a02 Author: Fridolin Somers Date: Fri Sep 25 17:08:38 2020 +0200 Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 5a669249148d3f874ebc9977be9d4be6a6d92f8d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/member-alt-address-style.inc | 4 ++-- .../intranet-tmpl/prog/en/includes/member-alt-contact-style.inc | 5 +++-- .../intranet-tmpl/prog/en/includes/member-main-address-style.inc | 4 ++-- 3 files changed, 7 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 11 16:41:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 11 Nov 2020 15:41:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1842-gf11484ae7f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f11484ae7f43092352f7b9376e86328e9fd7f66d (commit) via 031ce225455decf24dbff53670136fdae49cf7c1 (commit) via fb28f35021247fbfdee428253ee2a557cac90d23 (commit) via 887022e0d23050d586970ef306df0d5630e1dd65 (commit) via 98f0e5047d8538f31ef9854395b5979e815f1bfb (commit) via b2093e41620f92987c5f1a17d8b22597837f66a1 (commit) via 6e311a1be124cc93756183aefea7768be74849ad (commit) via e429d90fb3065a7c7c4bd6951ffb9d47135aa5ce (commit) via bbfdc72303a2ebd5130c39c743a2d0040b2c0e2c (commit) via 5b80d3ba6532dd0ae911ff4a7ce5f266f30dc6f8 (commit) via b2110746d44861c55714e8bb68ab665247b6cbd8 (commit) via 8595e80b7858c7eeb7b11a1dd33f338fce12791c (commit) via d67b2b5d46cef3dc221c05431a5ce5f7d2563cf1 (commit) via 07bc35615649f466674ce2e6f2534d47926b02e8 (commit) via dc465736cd14a860ffbda1571012fe94fb1e65fa (commit) via 6adc4514c69a5fa95ff54caf73d2542e97769863 (commit) via 6853a2d7f6bf8795b204beeeaa65a8eb61f09308 (commit) via aa36a4c22f81d2d20fb862baf09cd4121f82afb2 (commit) via 9f5596afd66b1757092f252a7e9496d125e45315 (commit) via 2d53ae88b617638215c0e2fafd6e3db1d3b8eb40 (commit) via 9721e6775185f956e7c7808cadb81c60a61f8902 (commit) via 0001155429a7c163d697d8950a139f14644ef940 (commit) via 2bf1d0f1d21e7228904c0bb00f2c1388fb1a3df2 (commit) via 8b3a1085587d3275a95a5a1a4a84591e6f3ed034 (commit) via 4685b3de0b7433f338a617713fac66562fb3a53c (commit) via bff3fb91eb6af3d964936640c08e2ff2d4add94a (commit) via 0cbf32886499c26f5da650aea16de5e30a0d0390 (commit) via a7d834d2e57144807d43b3fdb7e8a4a42151cc3a (commit) via 47f4ae3fe7958c708bf3af887721b829ca8a8182 (commit) via d812bf9d276b47d048b81bbe8fab3f4c913e8330 (commit) via 6d36793174cf6f9a42f46b1109497bc0bd9bbc57 (commit) via 10e23507f5b4c6faf202122e81175ebc033bdee6 (commit) via 5bab8b0fec65e5b12da3545dd021509669fce5c3 (commit) via ff0be50cded5cc2fac175a305dd3554c8463bbe8 (commit) via 657a1a18b0657a54a9318d374b530e439c0bfbb5 (commit) via 046e32bccc8bca83ff558126b2288e5a13c64df3 (commit) via 080ef802e2da9ed0fecf6136b1ed8b57f3ad57e8 (commit) via adce91dc250ac711cdeae03d84b07a8e790355f3 (commit) via d193883868b3b223c7167b870a55b85bc1ecfa2e (commit) via afd13b6a9b2b980872a0dc18d3fcc207f2f2cd3e (commit) via 30af45ccf126979c0bddcc69992b7e33516dfea0 (commit) via ccdba691ff9685a252e44a4f6e9371b97e51b518 (commit) via 14986fce53b8bfa6fe3d597f6c255ca742ef17c5 (commit) via 51d73f839381144aac32f11d10d2971e3d558918 (commit) via c87ed242098a60881ef1b3777bd0d4e3307e0771 (commit) via 78d2b65313ad188756983ea46a8f57cf4e7804db (commit) via ed7e74307edaa767ce283b59467a982fa420bf4a (commit) via 2baa9a1b5a844cc3f45df2cce273d3ddb92c0bc9 (commit) via 1a7f09709abc1d89f9ff0b6ccd160c55eb139449 (commit) via ef07ad1044e172e3b0079025ad9ea04fb074f9e0 (commit) via 51895cd7fb5ac56d8e4a2ffb78ba2efccec3d83f (commit) from f8206ca60cb1bbd32a90b7898a6877166026b8bb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f11484ae7f43092352f7b9376e86328e9fd7f66d Author: Jonathan Druart Date: Wed Nov 11 14:38:12 2020 +0000 Bug 24083: DBRev 20.06.00.069 Signed-off-by: Jonathan Druart commit 031ce225455decf24dbff53670136fdae49cf7c1 Author: Jonathan Druart Date: Wed Nov 11 15:36:26 2020 +0100 Bug 24083: Compiled CSS Signed-off-by: Jonathan Druart commit fb28f35021247fbfdee428253ee2a557cac90d23 Author: Jonathan Druart Date: Wed Nov 11 15:34:51 2020 +0100 Bug 24083: DBIC schema changes Signed-off-by: Jonathan Druart commit 887022e0d23050d586970ef306df0d5630e1dd65 Author: Andrew Isherwood Date: Wed Nov 11 13:19:18 2020 +0000 Bug 24083: (follow-up) Make requested changes This commit makes the changes requested in comment #120 Signed-off-by: Jonathan Druart commit 98f0e5047d8538f31ef9854395b5979e815f1bfb Author: Jonathan Druart Date: Mon Nov 9 16:11:02 2020 +0100 Bug 24083: Swap the column for "Unlimited" handling Signed-off-by: Jonathan Druart commit b2093e41620f92987c5f1a17d8b22597837f66a1 Author: Jonathan Druart Date: Mon Nov 9 16:10:39 2020 +0100 Bug 24083: Delete the new rule when needed Signed-off-by: Jonathan Druart commit 6e311a1be124cc93756183aefea7768be74849ad Author: Andrew Isherwood Date: Mon Oct 5 12:39:48 2020 +0100 Bug 24083: (follow-up) Squashed follow ups This squashed commit fixes: - a small error in the checkouts related JS - GetRenewCount now returns 6 values when a call to it succeeds, a failed call should also return the same number of values. This commit adds these additional values. - Some changes in issue.t had broken the tests for unseen renewals (the unseen tests were using variables that had been moved out of the tests' scope). - Also now using Koha::CirculationRules::set_rules to set circ rules rather than using SQL queries. - Fixed expected number of return values from GetRenewCount - Moved unseen tests in issue.t to the bottom of the file to remove the risk of interference with other test circ rules. - There was a real mess in C4/Circulation.pm due to a bad rebase back in February. Frankly it's a wonder anything worked at all. This commit fixes that problem and reinstates the correct patch for C4/Circulation.pm - Somehow I'd never noticed this before but the columns in smart-rules.tt were misaligned when UnseenRenewals was turned off. This was due to the display of a not being conditional when it should have been. This is now fixed. - This commit also fixes items 1 & 2 descibed by Katrin in comment #74 -> comment #76. - Fixed missing check for too_unseen in opac-user.tt, this test did used to exist but got lost during sizeable rebase a few weeks ago :-( - Added test for too_unseen to all AUTO_RENEWAL notice templates apart from de-DE (as previously requested by Katrin) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e429d90fb3065a7c7c4bd6951ffb9d47135aa5ce Author: Andrew Isherwood Date: Mon Oct 5 12:37:01 2020 +0100 Bug 24083: (follow-up) Include SelfCheckInModule As highlighted by Katrin, the selfcheckin module was not aware of this work. This commits gives it awareness of the too_unseen renew error and the "seen" argument that can be passed to AddRenewal Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit bbfdc72303a2ebd5130c39c743a2d0040b2c0e2c Author: Andrew Isherwood Date: Thu Nov 5 10:41:56 2020 +0000 Bug 24083: (follow-up) Respond to QA feedback This patch implements changes requested by Katrin in QA feedback (comment #38): - Fix QA script failures - Fix alter table column order mismatch - Use new convention for JS strings - Fix terminology Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5b80d3ba6532dd0ae911ff4a7ce5f266f30dc6f8 Author: Andrew Isherwood Date: Mon Mar 9 16:04:46 2020 +0000 Bug 24083: (follow-up) Fix params to AddRenewal The merging of Bug 23051 has added a paramter that can be passed to C4::AddRenewal. This bug does also, so the offset of this bug's new paramter was wrong. This patch fixes it. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit b2110746d44861c55714e8bb68ab665247b6cbd8 Author: Andrew Isherwood Date: Thu Nov 28 09:04:38 2019 +0000 Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8595e80b7858c7eeb7b11a1dd33f338fce12791c Author: Andrew Isherwood Date: Fri Nov 22 11:08:53 2019 +0000 Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d67b2b5d46cef3dc221c05431a5ce5f7d2563cf1 Author: Andrew Isherwood Date: Thu Nov 21 14:37:05 2019 +0000 Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 07bc35615649f466674ce2e6f2534d47926b02e8 Author: Andrew Isherwood Date: Thu Nov 21 14:35:41 2019 +0000 Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit dc465736cd14a860ffbda1571012fe94fb1e65fa Author: Jonathan Druart Date: Tue Nov 10 14:11:10 2020 +0100 Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable $serialitem is not a Koha::Item there, we need to fetch the item before. Test plan: Turn makePreviousSerialAvailable on Create a subscription Receive an serial item, mark it "arrived" Without this patch Koha explodes with No property notforloan for Koha::Serial::Item at /usr/share/perl5/Exception/Class/Base.pm line 88 Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)', 'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line 273 With this patch applied the notforloan and itype values are correctly set for the new serial item. Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 6adc4514c69a5fa95ff54caf73d2542e97769863 Author: Jonathan Druart Date: Wed Nov 11 14:38:12 2020 +0000 Bug 23019: DBRev 20.06.00.068 Signed-off-by: Jonathan Druart commit 6853a2d7f6bf8795b204beeeaa65a8eb61f09308 Author: Agustin Moyano Date: Tue Nov 10 13:59:01 2020 -0300 Bug 23019: (follow-up) Fix test permissions and API definition bugs Signed-off-by: Jonathan Druart commit aa36a4c22f81d2d20fb862baf09cd4121f82afb2 Author: Jonathan Druart Date: Mon Nov 9 14:46:49 2020 +0100 Bug 23019: (follow-up 2) set table name to import_batch_profiles Signed-off-by: Jonathan Druart commit 9f5596afd66b1757092f252a7e9496d125e45315 Author: Agustin Moyano Date: Fri Nov 6 14:50:29 2020 -0300 Bug 23019: (follow-up) Fix other things This patch: * Fixes table name change * Adds schema file * Changes api parameter name * Fixes string escaping * Fixes error handling Signed-off-by: Jonathan Druart commit 2d53ae88b617638215c0e2fafd6e3db1d3b8eb40 Author: Agustin Moyano Date: Fri Nov 6 14:49:20 2020 -0300 Bug 23019: (follow-up) set table name to import_batch_profiles Signed-off-by: Jonathan Druart commit 9721e6775185f956e7c7808cadb81c60a61f8902 Author: Nick Clemens Date: Fri Oct 30 15:34:24 2020 +0000 Bug 23019: (QA follow-up) fix test fiule permissions Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 0001155429a7c163d697d8950a139f14644ef940 Author: Agustin Moyano Date: Thu Aug 27 19:09:05 2020 -0300 Bug 23019: (follow-up) Fix usability issues This patch place profile buttons in the bottom of the page, next to "Stage for import" It removes the "Update profile" button, and changes "Add profile" to "Save profile". Save profile can be used to add and to update a profile. It also adds feedback when a profile was saved or deleted. Last, it also replaces input-batch-profile endpoint name for input_batch_profile, which is more aligned with other endpoint names. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 2bf1d0f1d21e7228904c0bb00f2c1388fb1a3df2 Author: Agustin Moyano Date: Wed Jul 1 07:25:14 2020 +0000 Bug 23019: (QA follow-up) Fix typo Pre fill Signed-off-by: Agustin Moyano Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 8b3a1085587d3275a95a5a1a4a84591e6f3ed034 Author: Agustin Moyano Date: Fri May 15 11:09:49 2020 -0300 Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages This patch adds the logic and the needed UI elements to be able to pre-load an import profile. It also displays which profile was used to stage an import in staged import manager. To test: 1. Apply all patches 2. Updatedatabase 3. Go to Stage MARC records for Import tool in admin, and upload a file with MARC records. CHECK => after uploading, there is a fieldset with the legend “Profile settings” => inside the fieldset there is a select labeled “Pre fill values with profile”. The only value it has is “Do not use profile”. 4. Change some settings, and set “profile 1” as profile name and click on “Add profile” SUCCESS => The select now has the new profile selected 5. Change profile select to “Do not use profile” SUCCESS => Default values are now displayed in the form 6. Reload the page and upload the file again SUCCESS => the select still has the profile recently added 7. Select the profile, change some parameter in the form and set the profile name to “profile 2”, and click add profile SUCCESS => there are two profiles now, and if you toggle between them, the parameter changes 8. Select profile 1, change one parameter and click on update profile SUCCESS => if you toggle that profile with the other, the new parameter of the value is shown when you select profile 1 9. Select profile 2, change some parameter and click Add profile (leaving the name as profile 2) SUCCESS => the page complains there is another profile with the same name, and asks if you want to replace it. 10. Click on accept SUCCESS => profile 2 now has the new value in the parameter 11. Select profile 2 and change the name to profile 1 SUCCESS => the page complains there is another profile with that name, and asks if you want to replace it 12. Click on accept SUCCESS => in profile select there is only one profile called profile 1 that has the values of profile 2 13. Select profile 1 and click remove profile SUCCESS => there is no profile in profile select. 14. Create a profile and click on “Stage for import” 15. Go to Staged MARC management page SUCCESS => Improt should have the name of the profile in profile column, and when you click on the file name, there should be the name of the profile in the details. 16. prove t/db_dependent/ImportBatch.t t/db_dependent/api/v1/import_batch_profiles.t 17. Sign off Signed-off-by: Abbey Holt Signed-off-by: Abbey Holt Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 4685b3de0b7433f338a617713fac66562fb3a53c Author: Agustin Moyano Date: Fri May 15 11:09:56 2020 -0300 Bug 23019: Add tests Signed-off-by: Abbey Holt Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit bff3fb91eb6af3d964936640c08e2ff2d4add94a Author: Agustin Moyano Date: Fri May 15 11:09:51 2020 -0300 Bug 23019: Add ImportBatchesProfile schema and set is_boolean to parse_items column Signed-off-by: Abbey Holt Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 0cbf32886499c26f5da650aea16de5e30a0d0390 Author: Agustin Moyano Date: Fri May 15 11:09:51 2020 -0300 Bug 23019: Add koha_object_class and koha_objects_class methods to ImportBatch.pm schema Signed-off-by: Abbey Holt Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit a7d834d2e57144807d43b3fdb7e8a4a42151cc3a Author: Agustin Moyano Date: Fri May 15 11:09:53 2020 -0300 Bug 23019: Update database structure and add atomic update Signed-off-by: Abbey Holt Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 47f4ae3fe7958c708bf3af887721b829ca8a8182 Author: Jonathan Druart Date: Wed Nov 11 14:38:12 2020 +0000 Bug 20936: DBRev 20.06.00.067 Signed-off-by: Jonathan Druart commit d812bf9d276b47d048b81bbe8fab3f4c913e8330 Author: Agustin Moyano Date: Tue Nov 10 19:23:49 2020 -0300 Bug 20936: (follow-up) add biblio and item relation to old holds and set a limit on search holds Signed-off-by: Jonathan Druart commit 6d36793174cf6f9a42f46b1109497bc0bd9bbc57 Author: Nick Clemens Date: Fri Oct 30 17:28:52 2020 +0000 Bug 20936: (QA follow-up) Use Branches template plugin Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 10e23507f5b4c6faf202122e81175ebc033bdee6 Author: Agustin Moyano Date: Wed May 6 19:38:19 2020 -0300 Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds 6. Change order, and list limit SUCCESS => All controls work as expected 7. Sign off. Signed-off-by: Todd Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 5bab8b0fec65e5b12da3545dd021509669fce5c3 Author: Agustin Moyano Date: Sun Feb 9 17:53:55 2020 -0300 Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit ff0be50cded5cc2fac175a305dd3554c8463bbe8 Author: Jonathan Druart Date: Wed Nov 11 14:38:12 2020 +0000 Bug 22818: DBRev 20.06.00.066 Signed-off-by: Jonathan Druart commit 657a1a18b0657a54a9318d374b530e439c0bfbb5 Author: Jonathan Druart Date: Wed Nov 11 15:35:33 2020 +0100 Bug 22818: DBIC schema changes Signed-off-by: Jonathan Druart commit 046e32bccc8bca83ff558126b2288e5a13c64df3 Author: Katrin Fischer Date: Fri Oct 16 17:13:48 2020 +0200 Bug 22818: (QA follow-up) Add hint to new library ILL email setting Copies the hints on the other email fields highlighting the existing global pref. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 080ef802e2da9ed0fecf6136b1ed8b57f3ad57e8 Author: Katrin Fischer Date: Fri Oct 16 17:07:26 2020 +0200 Bug 22818: (QA follow-up) Add some punctuation and terminology fixes to pref descriptions Just branch => library and some ending punctuation. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit adce91dc250ac711cdeae03d84b07a8e790355f3 Author: Katrin Fischer Date: Fri Oct 16 16:51:09 2020 +0200 Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer Run: prove xt/sample_notices.t de-DE are missing on purpose because of bug 24972. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d193883868b3b223c7167b870a55b85bc1ecfa2e Author: Andrew Isherwood Date: Fri Oct 16 15:08:59 2020 +0100 Bug 22818: (follow-up) Respond to feedback This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit afd13b6a9b2b980872a0dc18d3fcc207f2f2cd3e Author: Andrew Isherwood Date: Thu Oct 15 14:57:19 2020 +0100 Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 30af45ccf126979c0bddcc69992b7e33516dfea0 Author: Martin Renvoize Date: Wed Sep 16 14:57:36 2020 +0100 Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ccdba691ff9685a252e44a4f6e9371b97e51b518 Author: Martin Renvoize Date: Thu Jul 9 11:18:26 2020 +0100 Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 14986fce53b8bfa6fe3d597f6c255ca742ef17c5 Author: Martin Renvoize Date: Thu Jul 9 10:25:26 2020 +0100 Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 51d73f839381144aac32f11d10d2971e3d558918 Author: Martin Renvoize Date: Thu Jul 9 09:42:20 2020 +0100 Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c87ed242098a60881ef1b3777bd0d4e3307e0771 Author: Martin Renvoize Date: Thu Jul 9 09:14:57 2020 +0100 Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 78d2b65313ad188756983ea46a8f57cf4e7804db Author: Martin Renvoize Date: Thu Jul 9 08:40:22 2020 +0100 Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ed7e74307edaa767ce283b59467a982fa420bf4a Author: Andrew Isherwood Date: Thu May 9 15:35:07 2019 +0100 Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 2baa9a1b5a844cc3f45df2cce273d3ddb92c0bc9 Author: Andrew Isherwood Date: Thu May 9 12:21:27 2019 +0100 Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 1a7f09709abc1d89f9ff0b6ccd160c55eb139449 Author: Andrew Isherwood Date: Wed May 8 10:42:22 2019 +0100 Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ef07ad1044e172e3b0079025ad9ea04fb074f9e0 Author: Andrew Isherwood Date: Tue May 7 17:37:02 2019 +0100 Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 51895cd7fb5ac56d8e4a2ffb78ba2efccec3d83f Author: Andrew Isherwood Date: Tue May 7 11:09:58 2019 +0100 Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 67 +++- C4/ILSDI/Services.pm | 2 +- C4/ImportBatch.pm | 10 +- C4/Letters.pm | 7 + C4/SIP/ILS/Transaction/Renew.pm | 1 + Koha.pm | 2 +- Koha/CirculationRules.pm | 3 + Koha/Illrequest.pm | 326 ++++++++++++++----- Koha/Illrequest/Logger.pm | 41 ++- Koha/ImportBatch.pm | 41 +++ Koha/ImportBatchProfile.pm | 54 ++++ Koha/ImportBatchProfiles.pm | 51 +++ Koha/ImportBatches.pm | 51 +++ Koha/Library.pm | 19 ++ Koha/{Tag.pm => MessageAttribute.pm} | 8 +- Koha/{ApiKeys.pm => MessageAttributes.pm} | 13 +- Koha/REST/V1/Checkouts.pm | 11 +- Koha/REST/V1/{Cities.pm => ImportBatchProfiles.pm} | 102 +++--- Koha/Schema/Result/Branch.pm | 11 +- Koha/Schema/Result/ImportBatch.pm | 52 ++- Koha/Schema/Result/ImportBatchProfile.pm | 197 +++++++++++ Koha/Schema/Result/Issue.pm | 12 +- Koha/Schema/Result/OldIssue.pm | 12 +- Koha/Schema/Result/OldReserve.pm | 24 ++ admin/branches.pl | 1 + admin/smart-rules.pl | 3 + api/v1/swagger/definitions.json | 6 + api/v1/swagger/definitions/checkout.json | 4 + .../swagger/definitions/import_batch_profile.json | 53 +++ .../swagger/definitions/import_batch_profiles.json | 6 + api/v1/swagger/definitions/library.json | 4 + api/v1/swagger/parameters.json | 6 + api/v1/swagger/parameters/checkout.json | 7 + .../swagger/parameters/import_batch_profile.json | 9 + api/v1/swagger/paths.json | 6 + api/v1/swagger/paths/checkouts.json | 7 +- api/v1/swagger/paths/import_batch_profiles.json | 360 +++++++++++++++++++++ circ/renew.pl | 11 +- ill/ill-requests.pl | 36 ++- .../data/mysql/en/mandatory/sample_notices.yml | 234 ++++++++++++++ .../mysql/fr-CA/obligatoire/sample_notices.sql | 13 + .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 13 + installer/data/mysql/it-IT/necessari/notices.sql | 13 + installer/data/mysql/kohastructure.sql | 30 +- .../sample_notices_message_attributes.sql | 4 +- .../sample_notices_message_transports.sql | 8 +- installer/data/mysql/mandatory/sysprefs.sql | 4 + .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 13 + .../data/mysql/pl-PL/mandatory/sample_notices.sql | 13 + .../data/mysql/ru-RU/mandatory/sample_notices.sql | 13 + .../data/mysql/uk-UA/mandatory/sample_notices.sql | 13 + installer/data/mysql/updatedatabase.pl | 103 ++++++ .../intranet-tmpl/prog/css/src/staff-global.scss | 12 + koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/includes/checkouts-table.inc | 4 + .../prog/en/includes/messaging-preference-form.inc | 3 + .../prog/en/modules/admin/branches.tt | 4 + .../prog/en/modules/admin/categories.tt | 3 + .../en/modules/admin/preferences/circulation.pref | 14 + .../prog/en/modules/admin/preferences/opac.pref | 6 + .../prog/en/modules/admin/smart-rules.tt | 17 +- .../prog/en/modules/circ/circulation.tt | 1 + .../intranet-tmpl/prog/en/modules/circ/renew.tt | 38 ++- .../prog/en/modules/ill/ill-requests.tt | 39 +++ .../prog/en/modules/ill/log/patron_notice.tt | 6 + .../prog/en/modules/members/moremember.tt | 1 + .../intranet-tmpl/prog/en/modules/tools/letter.tt | 7 + .../prog/en/modules/tools/manage-marc-import.tt | 3 + .../prog/en/modules/tools/stage-marc-import.tt | 182 ++++++++++- .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 3 +- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 28 +- .../opac-tmpl/bootstrap/en/includes/usermenu.inc | 9 + .../bootstrap/en/modules/opac-holdshistory.tt | 185 +++++++++++ .../bootstrap/en/modules/opac-illrequests.tt | 2 +- .../bootstrap/en/modules/opac-messaging.tt | 3 + .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 46 ++- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 + misc/cronjobs/automatic_renewals.pl | 3 +- offline_circ/download.pl | 1 + opac/opac-holdshistory.pl | 95 ++++++ opac/opac-illrequests.pl | 2 + opac/opac-renew.pl | 2 +- opac/opac-user.pl | 10 +- opac/sco/sco-main.pl | 2 +- serials/serials-edit.pl | 3 +- svc/checkouts | 12 +- svc/renew | 3 +- t/db_dependent/Circulation.t | 32 +- t/db_dependent/Circulation/issue.t | 50 ++- t/db_dependent/Illrequests.t | 140 +++++++- t/db_dependent/ImportBatch.t | 4 + t/db_dependent/Koha/Libraries.t | 53 ++- t/db_dependent/api/v1/import_batch_profiles.t | 241 ++++++++++++++ tools/letter.pl | 4 + tools/manage-marc-import.pl | 2 + tools/stage-marc-import.pl | 7 + 96 files changed, 3171 insertions(+), 225 deletions(-) create mode 100644 Koha/ImportBatch.pm create mode 100644 Koha/ImportBatchProfile.pm create mode 100644 Koha/ImportBatchProfiles.pm create mode 100644 Koha/ImportBatches.pm copy Koha/{Tag.pm => MessageAttribute.pm} (83%) copy Koha/{ApiKeys.pm => MessageAttributes.pm} (81%) copy Koha/REST/V1/{Cities.pm => ImportBatchProfiles.pm} (50%) create mode 100644 Koha/Schema/Result/ImportBatchProfile.pm create mode 100644 api/v1/swagger/definitions/import_batch_profile.json create mode 100644 api/v1/swagger/definitions/import_batch_profiles.json create mode 100644 api/v1/swagger/parameters/import_batch_profile.json create mode 100644 api/v1/swagger/paths/import_batch_profiles.json create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt create mode 100755 opac/opac-holdshistory.pl create mode 100755 t/db_dependent/api/v1/import_batch_profiles.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 11 18:37:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 11 Nov 2020 17:37:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1843-gcdbc04f69d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cdbc04f69d751d2b08dc256d61972330512c3a0d (commit) from f11484ae7f43092352f7b9376e86328e9fd7f66d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cdbc04f69d751d2b08dc256d61972330512c3a0d Author: Jonathan Druart Date: Wed Nov 11 18:03:08 2020 +0100 Bug 22818: Fix TestBuilder.t t/db_dependent/TestBuilder.t .. 12/13 # Failed test 'build_object() tests' # at t/db_dependent/TestBuilder.t line 429. Can't locate object method "_new_from_dbic" via package "Koha::MessageAttribute" (perhaps you forgot to load "Koha::MessageAttribute"?) at /kohadevbox/koha/Koha/Objects.pm line 98. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/MessageAttributes.pm | 1 + t/db_dependent/Illrequests.t | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Nov 12 18:01:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Nov 2020 17:01:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1849-g64ee6f0b2b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 64ee6f0b2bbcc9b23520c689146f1c5cf905e997 (commit) via 4415fdb0f4785dff24c9773f85a9b32885c385ac (commit) via fbd0bbf98f574a7eb804673978a198eea6fdd798 (commit) via 1dadf8823357573b740b0c259f16cf18ab4e8904 (commit) via 0423d09e57f6a64656dc0f82a10c82962960e049 (commit) via 552ea4e9d27a1d075e009e13bde63b2c91962644 (commit) from cdbc04f69d751d2b08dc256d61972330512c3a0d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 64ee6f0b2bbcc9b23520c689146f1c5cf905e997 Author: Martin Renvoize Date: Thu Nov 12 13:36:00 2020 +0000 Bug 26948: Regression tests We already mock the send_or_die method from Email::Stuffer; This patch updates that mock to extract the internal representation of the email encoded message and looks for a known double encoded representation of a character in the sample body. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 4415fdb0f4785dff24c9773f85a9b32885c385ac Author: Joonas Kylmälä Date: Fri Nov 6 13:35:39 2020 +0200 Bug 26948: Remove double encoding from sent emails The sent emails from Koha were garbled / double encoded because Koha::Email now after the refactoring and moving to use Email::Stuffer handles the encoding itself. Previously the Koha::Email callee had to handle the encoding. This patch removes the double encoding in the email subject and content. To test: 1) Put some UTF-8 characters like ä in the HOLD template subject and body 2) Create hold and check-in an item to make it Waiting and cause the email to be send 3) Notice the email comes garbled / double encoded 4) Apply patch 5) Repeat step 2) and notice the email comes without any issues in encoding and look OK. 6) Make sure "prove t/Koha/Email.t" and "prove t/db_dependent/Letters.t" and passes Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit fbd0bbf98f574a7eb804673978a198eea6fdd798 Author: Jonathan Druart Date: Wed Nov 11 14:55:27 2020 +0100 Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred There is a missing parameter to CanItemBeReserved, we need to know if the hold can be placed at a given pickup library. Test plan: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item (with a pickup library different than Centerville) => Without this patch you are taken to the holds list, but your hold is not placed Nothing indicates why hold has failed => With this patch you cannot select the item from Centerville "Cannot be transferred to pickup library" Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 1dadf8823357573b740b0c259f16cf18ab4e8904 Author: Andrew Isherwood Date: Thu Nov 12 11:30:33 2020 +0000 Bug 22818: (QA follow-up) Respond to feedback This commit addresses the requests from Jonathan in comment #188 Signed-off-by: Jonathan Druart commit 0423d09e57f6a64656dc0f82a10c82962960e049 Author: Andrew Isherwood Date: Thu Nov 12 13:38:49 2020 +0000 Bug 24083: (QA follow-up) Fix DB upgrade This commit makes the addition of the 'unseen_renewals_allowed' circulation rule idempotent, as highlighted by Jonathan in comment #140 Bug 24083: (QA follow-up) Fix for previous It helps if you don't commit commented out code... Signed-off-by: Jonathan Druart commit 552ea4e9d27a1d075e009e13bde63b2c91962644 Author: Andrew Isherwood Date: Thu Nov 12 10:36:08 2020 +0000 Bug 24083: (QA follow-up) Fix failing tests This commit fixes the failing tests mentioned by Jonathan in comment Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 4 +--- installer/data/mysql/updatedatabase.pl | 21 +++++++++++++++------ .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- reserve/request.pl | 2 +- t/db_dependent/Letters.t | 14 +++++++++----- t/db_dependent/api/v1/checkouts.t | 2 ++ 6 files changed, 29 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 08:46:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 07:46:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1850-gdcc1b96ea9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dcc1b96ea9cba850b1d5cfb84a171685b1b2a5ad (commit) from 64ee6f0b2bbcc9b23520c689146f1c5cf905e997 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dcc1b96ea9cba850b1d5cfb84a171685b1b2a5ad Author: Jonathan Druart Date: Fri Nov 13 08:14:40 2020 +0100 Bug 22818: Fix the last_insert_id call DBI last_insert_id: invalid number of arguments: got handle + 3, expected handle + between 4 and 5 Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, \%attr ]) at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23326. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 14:56:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 13:56:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1868-g91e21d3a95 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 91e21d3a95520f19fa3632d87f2c8f32b11ea1eb (commit) via 7f83e703abd69383cb80ca36cd8219959f1ab205 (commit) via 7edb1a55bc54fd5c68700e703be9deff3d6a0199 (commit) via 19a30acaece904aeedcc6a3728e3815895d10c56 (commit) via 4388d20fb12f77aa733498baa4a287e4fb7c6998 (commit) via 14506040292201a78733a9c1746bf7f590205fe3 (commit) via 75456ba973f87d3c46d045811ad32dfe2a153e3f (commit) via 83d471394562b8137fce9b3a538d19efc41fa1e1 (commit) via b6deb941dc95f8642ef8d20da7f2fcabbc0a15d7 (commit) via e61bcc270e8bc9a13939af60df45a1db53e51530 (commit) via 7a42c85889bf779bbcaf82a31793438ebcffc076 (commit) via 04a4a34d6e9b7a235ae238b82b991795ca5abb8a (commit) via 7b09e86a8d3609e03988be4ad387f018a91d0fd7 (commit) via b6a7a3c8a8fa040409f4c42d10149b72a427cf54 (commit) via 7179a29feaf994f35de871d06084f71dfc9eebcc (commit) via 5b06c361d6c9a45fb07c853f07fb9aa5d4d77c37 (commit) via 780ced27f5ac90d227c88e6fcab2fa43c0b3ffb5 (commit) via db1865ba346704d47be28cf8afdcc6052f55d61a (commit) from dcc1b96ea9cba850b1d5cfb84a171685b1b2a5ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 91e21d3a95520f19fa3632d87f2c8f32b11ea1eb Author: Nick Clemens Date: Fri Nov 13 13:15:29 2020 +0000 Bug 26988: Adjust for bug 26963 Signed-off-by: Jonathan Druart commit 7f83e703abd69383cb80ca36cd8219959f1ab205 Author: Jonathan Druart Date: Fri Nov 13 11:07:53 2020 +0100 Bug 26988: No need to check if hold is linked to a patron Holds are deleted along with patrons. Signed-off-by: Jonathan Druart commit 7edb1a55bc54fd5c68700e703be9deff3d6a0199 Author: Agustin Moyano Date: Wed Nov 11 12:22:20 2020 -0300 Bug 26988: (follow-up) Change event to focus Click event on select element if Firefox does not work as expected, so this patch changes the event to focus for it to work seamlessly in both browsers. https://bugs.koha-community.org/show_bug.cgi?id=26899 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 19a30acaece904aeedcc6a3728e3815895d10c56 Author: Nick Clemens Date: Wed Nov 11 03:11:56 2020 +0000 Bug 26988: (follow-up) Fix filter and encode api values and escape rendered values This patch makes the QA tools happy and follows correct procedures for passing data to and rendering data from the api Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 4388d20fb12f77aa733498baa4a287e4fb7c6998 Author: Nick Clemens Date: Wed Nov 11 02:53:46 2020 +0000 Bug 26988: (follow-up) Adjust code to use api field names Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 14506040292201a78733a9c1746bf7f590205fe3 Author: Tomas Cohen Arazi Date: Tue Nov 10 17:38:26 2020 -0300 Bug 26988: (QA follow-up) Make the API return proper library objects Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 75456ba973f87d3c46d045811ad32dfe2a153e3f Author: Tomas Cohen Arazi Date: Tue Nov 10 17:37:21 2020 -0300 Bug 26988: Make ->patron prefetchable Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 83d471394562b8137fce9b3a538d19efc41fa1e1 Author: Nick Clemens Date: Tue Nov 10 13:35:14 2020 +0000 Bug 26988: Add API route to fetch hold pickup locations and use it in the holds table To test: 1 - Place a number of holds on a record 2 - Have different pickup locations for the holds 3 - Have some libraries that are not pickup locations 4 - Load the holds tab for the record and note libraries not pickup locations are not in dropdowns 5 - Apply patch and restart all things 6 - Reload the holds table 7 - Click on a dropdown, note the spinner, should load successfully 8 - Confirm the dropdown matches the options before the patch 9 - Confirm updating the hold location works Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Bob Bennhoff Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b6deb941dc95f8642ef8d20da7f2fcabbc0a15d7 Author: Jonathan Druart Date: Fri Nov 13 09:23:51 2020 +0100 Bug 26963: Ignore existing libraries Signed-off-by: Jonathan Druart commit e61bcc270e8bc9a13939af60df45a1db53e51530 Author: Nick Clemens Date: Wed Nov 11 13:26:58 2020 +0000 Bug 26963: (QA follow-up) Fix up tests and cover case of undefined ccode While this technically shouldn't happen, if a library creates itemtype limits, then flips the pref, those rules are still in the db until a ccode rule is saved. To be extra safe, when checking for rules of one type, we should make sure the other type is undef - i.e. if looking for ccode rules, we should confirm the itype is undef for those rules Additionally, we shouldn't set the barcode now that we are not deleting all items, so we use copynumber for our item identification field as it doesn't need to be unique in the DB Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7a42c85889bf779bbcaf82a31793438ebcffc076 Author: Nick Clemens Date: Wed Nov 11 14:09:24 2020 +0000 Bug 26963: (QA follow-up) Fix cases where we expected a list Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 04a4a34d6e9b7a235ae238b82b991795ca5abb8a Author: Martin Renvoize Date: Wed Nov 11 15:43:57 2020 +0000 Bug 26963: (QA follow-up) Update mocked return of pickup_locations Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7b09e86a8d3609e03988be4ad387f018a91d0fd7 Author: Nick Clemens Date: Wed Nov 11 12:49:00 2020 +0000 Bug 26963: (QA follow-up) Don't delete existing data before tests Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b6a7a3c8a8fa040409f4c42d10149b72a427cf54 Author: Martin Renvoize Date: Wed Nov 11 16:06:21 2020 +0000 Bug 26963: (QA follow-up) Migrate unit tests into pickup_location We wrote unit tests for _can_pickup_locations as part of this patchset, but then I inlined the method whilst golfing. This patch moves those tests into the existing pickup_locations test so we more thoroughly cover the case where branch transfer limits are in play. NOTE: The tests all assume that all items have an effective_itemtype and ccode. I'm pretty sure items all have a type at this point, but I'm less sure we enforce collection codes? Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7179a29feaf994f35de871d06084f71dfc9eebcc Author: Martin Renvoize Date: Wed Nov 11 08:57:21 2020 +0000 Bug 26963: (QA follow-up) Convert to ResultSets This patch removes the previously introduced private method by converting the arrayref returns to ResultSets appropriately and inlining the filter search queries. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 5b06c361d6c9a45fb07c853f07fb9aa5d4d77c37 Author: Nick Clemens Date: Wed Nov 11 02:37:55 2020 +0000 Bug 26963: (follow-up) Change subroutine name for QA tools It didn't like the ending _at Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 780ced27f5ac90d227c88e6fcab2fa43c0b3ffb5 Author: Nick Clemens Date: Mon Nov 9 13:53:51 2020 +0000 Bug 26963: Don't call 'can_be_transferred' for each possible library for each item Currently When calling Koha::Template::Plugin::Branches::pickup_locations we call pickup_location for each item of the bib, and for each item we get a list of possible branches, we then check those branches against the transfer limits, this is inefficent Given a system with 100 branches, and each branch having an item attached to one bib (100 items) we will call can_be_transferred ~10000 times - and that will happen for each hold placed on the bib For me this patch reduced load time from 77 seconds to 18 seconds To test: 1 - Find a bib 2 - Place 4 title level holds 3 - Add some branches and items for this bib to your system: INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"A"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"B"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"C"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"D"),pickup_location FROM branches; INSERT INTO items (biblionumber,biblioitemnumber,barcode,itype,homebranch,holdingbranch) SELECT 1,1,CONCAT("test-",branchcode),'BKS',branchcode,branchcode FROM branches; 4 - Set systempreferences: UseBranchTransferLimits = 'enforce' BranchTransferLimitsType = 'item type' 5 - Find the bib and click the holds tab 6 - Wait for a long time, it shoudl eventually load 7 - Apply patch and restart al the things 8 - Load the page again, it should be much faster Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Bob Bennhoff Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit db1865ba346704d47be28cf8afdcc6052f55d61a Author: Nick Clemens Date: Wed Nov 11 01:24:15 2020 +0000 Bug 26963: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 2 +- Koha/Hold.pm | 13 ++ Koha/Item.pm | 61 +++-- Koha/Library.pm | 2 +- Koha/REST/V1/Holds.pm | 38 ++++ Koha/Schema/Result/Reserve.pm | 7 + Koha/Template/Plugin/Branches.pm | 2 +- api/v1/swagger/paths.json | 3 + api/v1/swagger/paths/holds.json | 63 ++++++ .../intranet-tmpl/prog/en/includes/holds_table.inc | 6 +- .../prog/en/modules/reserve/request.tt | 1 + koha-tmpl/intranet-tmpl/prog/js/holds.js | 30 +++ reserve/request.pl | 2 +- t/db_dependent/Koha/{Checkout.t => Hold.t} | 20 +- t/db_dependent/Koha/Item.t | 247 ++++++++++++++------- t/db_dependent/Template/Plugin/Branches.t | 3 +- 16 files changed, 387 insertions(+), 113 deletions(-) copy t/db_dependent/Koha/{Checkout.t => Hold.t} (70%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 15:46:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 14:46:49 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-14-g497435fa84 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 497435fa842ca6ac8c80942283c5c3663563b4fa (commit) from e6752ed58166407bf8e2e353e4acde5815df2a02 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 497435fa842ca6ac8c80942283c5c3663563b4fa Author: Emmi Takkinen Date: Fri Sep 25 13:52:06 2020 +0300 Bug 26429: Show correct expiration date at the request.pl Bug 25789 changed holds tables expriration input class as "datepickerto". This results to past expiration date to be displayed as tomorrows date. Class "futuredate" should have been used instead. To test: 1. Have waiting hold with expiration date in past (e.g 24.9) 2. Observe that waiting reserves table displays correct expiration date 3. At the request.pl page expiration date is however displayed as 26.9 => Apply patch 4. Confirm that expiration date at the request.pl is now 24.9 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1b40ee8d18b7fee42193cfb2bac5e44146a1afd9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 15:50:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 14:50:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-15-g5fe8bc1af7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5fe8bc1af7b9a0f1a79e40fec2e0b5bde9d6d799 (commit) from 497435fa842ca6ac8c80942283c5c3663563b4fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5fe8bc1af7b9a0f1a79e40fec2e0b5bde9d6d799 Author: Lucas Gass Date: Sat Sep 5 05:26:47 2020 +0000 Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ace5b632a6ed965931e1332cacb1419c16286d65) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 15:57:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 14:57:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-17-ga5a46d48f9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a5a46d48f979e780207f69686bdd1bab0d801405 (commit) via 0dbce3e180267f89bfbc0d15d944374aada3ba2c (commit) from 5fe8bc1af7b9a0f1a79e40fec2e0b5bde9d6d799 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5a46d48f979e780207f69686bdd1bab0d801405 Author: Katrin Fischer Date: Sun Oct 4 03:23:24 2020 +0000 Bug 9118: (QA follow-up) Fix spelling on "To Date :" Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 57182d6a043a25bda74de0e9e1320adfe930016c) Signed-off-by: Lucas Gass commit 0dbce3e180267f89bfbc0d15d944374aada3ba2c Author: Emmi Takkinen Date: Mon Oct 5 11:19:44 2020 +0300 Bug 9118: Do not show option to create exception on range for unique holiday When an unique holiday is edited one can choose option 'Generate exceptions on a range of dates.' Exceptions are meant to be used with repeating holidays and it makes no sense to have option to be able to create one for an unique holiday. This patch hides exception on range option when editing an unique holiday. Also fixes a minor spelling error. To test: 1. Create unique holiday and edit it. 2. Note that option to create exception on range is shown. 3. Apply patch. => Option is now hidden. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 683d6ced64a92cc391ac81b4a046bcdf2110bb83) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/holidays.tt | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 16:00:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 15:00:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-18-g7837657e04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7837657e04bb8f25d31bf6a39f87bf9f757f88de (commit) from a5a46d48f979e780207f69686bdd1bab0d801405 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7837657e04bb8f25d31bf6a39f87bf9f757f88de Author: Katrin Fischer Date: Sat Jul 18 14:52:06 2020 +0200 Bug 26018: Fix frameworks errors with subfields in wrong tab All subfields for a MARC21 field should always be in the same tab. There were some mistakes found by the "MARC bibliographic framework test" this fixes. Before you apply the patch: - Check the "MARC bibliographic framework test" page - Ideally you should see the "wrong tab" mistakes - Reset your db (reset_all) or drop your db and run the web installer - Verify the page no longer points out any issues Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart (cherry picked from commit 1cd22331732f6ffef3478ebbc034aa0fba154dba) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../marc21/mandatory/marc21_framework_DEFAULT.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 16:08:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 15:08:44 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-20-g78e8c65bf5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 78e8c65bf5fa8db6b9a8e8f3313359a4f295c00d (commit) via 356d1ca888b3591bde960f30c43e6afcd93b66dc (commit) from 7837657e04bb8f25d31bf6a39f87bf9f757f88de (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 78e8c65bf5fa8db6b9a8e8f3313359a4f295c00d Author: Jonathan Druart Date: Thu Jul 30 15:15:46 2020 +0200 Bug 20804: Add support for "days" to the timeout syspref If the timeout syspref did not contain an integer, or was not matching integer.'d|D', then it "fallback" to 0 We can easily add support for hours and fallback to 600 if the value is not correct. It will prevent the session to timeout immediately Test plan: 0. Do not apply the patches 1. Fill the timeout syspref with "5h" 2. Login 3. Click somewhere => Notice that the session timed out 4. Apply the patches, restart_all 5. Login 6. Click somewhere => You have 5 hours to enjoy Koha 7. Fill the pref with an incorrect value ("5x" for instance) 8. Logout, login 9. There is a warning in the log, and you have 10 minutes (600 secondes) to enjoy Koha Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 97b9eab178f0b45b38662747a4e009e71d8b73ff) Signed-off-by: Lucas Gass commit 356d1ca888b3591bde960f30c43e6afcd93b66dc Author: Jonathan Druart Date: Thu Jul 30 15:15:36 2020 +0200 Bug 20804: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c9c7f4543a06553c6cbf04ff58a82eb6a40fc9c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 14 ++++++++++++-- t/db_dependent/Auth.t | 21 ++++++++++++++++++++- 2 files changed, 32 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 16:27:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 15:27:14 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-21-gaf4bee8623 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via af4bee862335289c2c7e35e04d7541a220d805d7 (commit) from 78e8c65bf5fa8db6b9a8e8f3313359a4f295c00d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit af4bee862335289c2c7e35e04d7541a220d805d7 Author: Timothy Alexis Vass Date: Fri Oct 9 14:54:01 2020 +0000 Bug 26647: Add translation context to cancel hold button in OPAC 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 096327cfcd27d7abf484c3653b13e059bb9152e5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 17:37:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 16:37:15 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-22-g7f4b2f2099 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7f4b2f20991fd04da0703fafb7b643a03fcc7e14 (commit) from af4bee862335289c2c7e35e04d7541a220d805d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7f4b2f20991fd04da0703fafb7b643a03fcc7e14 Author: David Cook Date: Mon Sep 21 02:02:27 2020 +0000 Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fd35df346f73a00b643e675853ba2c8ef321cf66) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 17:48:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 16:48:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-24-gc3f61d3bd9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c3f61d3bd9792f4bb535401748fd614579378e54 (commit) via e0cf8315e15b4c5b9e862ffa1968db5aff78686a (commit) from 7f4b2f20991fd04da0703fafb7b643a03fcc7e14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c3f61d3bd9792f4bb535401748fd614579378e54 Author: Nick Clemens Date: Wed Sep 16 11:31:54 2020 +0000 Bug 23828: Elasticsearch - Preserve record order when combining subfield in mappings Currently if you combine subfields in the marc mappings the subfields are indexed in the order listed in the mapping. i.e. 650(avxyz) in mapping and in record: 650 $aHeading $zGeosubdiv $vFormsubdiv is indexed as: Heading Formsubdiv Geosubdiv We should preserve the order and index as: Heading Geosubdiv Formsubdiv We can use built in function in Marc::Field to achieve this To test: 1 - It is easy to find examples of this using authorities 2 - Find or create a record with subfields order azv e.g. 150$aActresses$zUnited states$vBiography 3 - Add or have a second authority e.g. 150$aActresses$vPortraits 4 - Set an authorities mapping for 'Heading' to 150(abgvxyz) find at: Administration->Search engine configuration (Elasticsearch)->Authorities tab 5 - Index the records in Elasticsearch perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1691 -ai 1692 6 - View the first record in the ES index curl es:9200/koha_kohadev_authorities/data/1692?pretty 7 - Note 'Heading' field is ordered as in the mapping 8 - Search authorities for 'contains' "act" 9 - Note the records sort incorrectly 10 - Apply patches 11 - perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1692 12 - curl es:9200/koha_kohadev_authorities/data/1692?pretty 13 - Note the order is now preserved 14 - Search authorities for 'contains' "act" 15 - Note the records sort correctly Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer JD amended patch: Fix FAIL spelling combind ==> combined Signed-off-by: Jonathan Druart (cherry picked from commit 890fd6ff068f58da4c72194ebc14be2cf479040b) Signed-off-by: Lucas Gass commit e0cf8315e15b4c5b9e862ffa1968db5aff78686a Author: Nick Clemens Date: Wed Sep 16 11:31:48 2020 +0000 Bug 23828: Unit tests Signed-off-by: Heather Hernandez Bug 23828: (follow-up) fix unit test merge Signed-off-by: Katrin Fischer Bug 23828: (QA follow-up) Fix number of tests Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0cb4300675405d37230ee427137daff2d6bdb4d9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 11 ++----- t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 39 ++++++++++++++++++------ 2 files changed, 32 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 19:07:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 18:07:11 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-26-gacd96409ea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via acd96409ea869862506233cee3404e14254e5725 (commit) via bd2347fbf85083fe6204dcaaf1cc98826219eaed (commit) from c3f61d3bd9792f4bb535401748fd614579378e54 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit acd96409ea869862506233cee3404e14254e5725 Author: Martin Renvoize Date: Wed Oct 7 16:37:06 2020 +0100 Bug 25549: Add error reporting to plugins-home This patch adds handling for the newly introduced 'errors' option in GetPlugins and reports erroroneos plugins to the user. To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - The plugin should display as installed in the table at tools/plugins. 5 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 6 - Add a line to break compilation, like: this won't compile 7 - Restart all 8 - Your Koha is not broken, but is no longer orange (The plugin is not loading). 9 - The plugin should display as unable to load in the table at tools/plugins. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 759ff4519961d0c256eb05a4797fb21c3b2c22d9) Signed-off-by: Lucas Gass commit bd2347fbf85083fe6204dcaaf1cc98826219eaed Author: Nick Clemens Date: Wed May 20 11:12:12 2020 +0000 Bug 25549: Remove plugin methods for broken plugins To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 5 - Add a line to break compilation, like: this won't compile 6 - Restart all 7 - Your koha is now broken 8 - kshell 9 - perl misc/devel/install_plugins.pl 10 - Restart all 11 - Koha remains broken 12 - Apply patch 13 - kshell 14 - perl misc/devel/install_plugins.pl 15 - Koha now works! 16 - Koha is not orange because the plugin methods are removed Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0eae966d257fa2ecc6a6506e2515691e092a701c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Plugins.pm | 39 ++++++++++++---------- .../prog/en/modules/plugins/plugins-home.tt | 15 +++++++++ misc/devel/install_plugins.pl | 10 ++++-- plugins/plugins-home.pl | 11 +++--- 4 files changed, 50 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 19:50:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 18:50:47 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-27-g710c9039ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 710c9039ee6a1f465d1615f56ceafd3cb26fb184 (commit) from acd96409ea869862506233cee3404e14254e5725 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 710c9039ee6a1f465d1615f56ceafd3cb26fb184 Author: Tomas Cohen Arazi Date: Tue Oct 20 14:40:50 2020 -0300 Bug 26751: Fix fatal exception if only one repo defined This patch fixes this nasty problem with how XML is parsed: if more than one entry is found, repo => [] is generated. If only one, repo => {}. To test: 1. Have more than one entries in the plugins_repo entry: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions github PTFS Europe ptfs-europe github 2. Search for plugins => SUCCESS: Searching works! 3. Leave only one entry 4. Restart all to refresh things 5. Try searching for plugins => FAIL: Fatal error 6. Apply this patch 7. Repeat 5 => SUCCESS: It doesn't explode anymore! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 9e5ea4f5ab81cb500f112a5858130f82a6b4fd65) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: plugins/plugins-home.pl | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 19:55:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 18:55:00 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-28-gaeb33f91a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via aeb33f91a500c9b022777e858df9c916932f50e0 (commit) from 710c9039ee6a1f465d1615f56ceafd3cb26fb184 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit aeb33f91a500c9b022777e858df9c916932f50e0 Author: Björn Nylén Date: Tue Oct 20 14:11:16 2020 +0200 Bug 26750: Deleted items not indexed After deleting an item it is still searchable in the index. Similar to bug 26507 where record is reindexed before the database is changed. To test: 1. Delete an item 2. Search the barcode in the main search box. You'll find the original record but wiht hte deleted item missing. 3. Apply patch. 4. Repeat steps 1-2 (with another item). No record should be found. Note to test you have to have the indexer running, not the cron job, and it needs to be running fast so that the index is updated before the delete takes place Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 395bb760394e6947303de7e342882148944e9026) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Item.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 19:58:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 18:58:56 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-30-ge3c24d9549 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e3c24d9549d04a90a24d08f463f19e7a933b5ff7 (commit) via aec2d4a8f62fb4be19bddd3fe69663c3df93f1be (commit) from aeb33f91a500c9b022777e858df9c916932f50e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e3c24d9549d04a90a24d08f463f19e7a933b5ff7 Author: Didier Gautheron Date: Tue Aug 18 07:40:50 2020 +0200 Bug 26232: Empty smart rule fine grace period Staff can create smart rules with empty (undefined) fine grace period. In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm. To test: 1. Apply these patches 2. Run: kshell prove t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7e66d6d190af4bd27739bdfe88049899f927c123) Signed-off-by: Lucas Gass commit aec2d4a8f62fb4be19bddd3fe69663c3df93f1be Author: Didier Gautheron Date: Tue Aug 18 07:39:53 2020 +0200 Bug 26232: Test for empty smart rule fine grace period Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit f6d614d4596728a3a2808eac2539754023e42262) ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- t/db_dependent/Circulation.t | 34 +++++++++++++++++++++++++++++++++- 2 files changed, 34 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 20:05:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 19:05:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-32-gbd163aa599 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via bd163aa5999e32e6f92b50f4b29d3ee4b22de94c (commit) via 67197c359eab0fb92c5df49edbb16008b3b33e92 (commit) from e3c24d9549d04a90a24d08f463f19e7a933b5ff7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd163aa5999e32e6f92b50f4b29d3ee4b22de94c Author: Nick Clemens Date: Sat Oct 24 23:53:21 2020 +0000 Bug 23432: (QA follow-up) Add a unit test prove -v t/db_dependent/StockRotationItems.t Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 23292b53a8bc672f66ae95b1cfb7db5994d1eea5) Signed-off-by: Lucas Gass commit 67197c359eab0fb92c5df49edbb16008b3b33e92 Author: Martin Renvoize Date: Wed Sep 23 12:28:22 2020 +0100 Bug 23432: Replace 'die' with 'warn' This patch simply replaced the die statement with a warn such that the cron script may continue to rotate other items even if this item cannot be properly rotated due to corrupt data. Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 6adb1891d2bf602b0434eb87508568e73faa763e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/StockRotationItem.pm | 2 +- t/db_dependent/StockRotationItems.t | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 20:09:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 19:09:59 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-33-gae2bce1312 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ae2bce1312b63d732ec07df21ef16740a8d179d2 (commit) from bd163aa5999e32e6f92b50f4b29d3ee4b22de94c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ae2bce1312b63d732ec07df21ef16740a8d179d2 Author: Nick Clemens Date: Thu Sep 3 16:23:04 2020 +0000 Bug 8437: Exclude export.pl from plack When attempting to download large files from Koha plack can timeout Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1 - Try to export your entire DB from Tools->Export 2 - If big enough, it fails 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4 - Restart all the things 5 - Repeat export, it succeeds Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 564ade93cce9231b01db1c4ebfc8f4e5b31e1acd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet-plack.conf | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 20:17:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 19:17:34 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-35-g86f801f350 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 86f801f350520910f78b78bfdaaa2783d7364929 (commit) via 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90 (commit) from ae2bce1312b63d732ec07df21ef16740a8d179d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 86f801f350520910f78b78bfdaaa2783d7364929 Author: Lucas Gass Date: Fri Nov 13 18:43:14 2020 +0000 Bug 26569: DBRev 20.05.05.001 Signed-off-by: Lucas Gass commit 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90 Author: Andrew Fuerste-Henry Date: Wed Sep 30 13:14:12 2020 +0000 Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a96f5deef04bb74fbd826449b4d82f651a67512c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 12 ++++++------ installer/data/mysql/updatedatabase.pl | 13 +++++++++++++ 3 files changed, 20 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 20:23:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 19:23:23 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-36-g3973ef10b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3973ef10b6b68eb4550dacf2c5a99475040dfdd1 (commit) from 86f801f350520910f78b78bfdaaa2783d7364929 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3973ef10b6b68eb4550dacf2c5a99475040dfdd1 Author: John Fawcett Date: Mon Oct 12 13:06:40 2020 +0200 Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 7c74c6636f779bbbaceee74f8704df9ec625815d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 20:28:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 19:28:54 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-37-gacc93b31ce Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via acc93b31cef93765f09b6585dbaad69d190b8fa2 (commit) from 3973ef10b6b68eb4550dacf2c5a99475040dfdd1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit acc93b31cef93765f09b6585dbaad69d190b8fa2 Author: John Fawcett Date: Mon Oct 12 11:18:30 2020 +0200 Bug 26613: Fix it-IT unimarc_framework.sql installer file This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3bd23a3287345167de50d994d737351174c04936) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 20:32:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 19:32:10 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-38-gb1d76c5d08 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b1d76c5d08af71c06cc03cfa06d46b46959dcbcf (commit) from acc93b31cef93765f09b6585dbaad69d190b8fa2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b1d76c5d08af71c06cc03cfa06d46b46959dcbcf Author: Jonathan Druart Date: Thu Oct 15 10:47:55 2020 +0200 Bug 26445: Fix "back to result" link of the search result browser Not sure what was the expected behaviour, I am suggesting the following one: If you are browsing and you click "back to result", you will be redirected to the page where the record appear on the search result list. Say you search for "something" that returns 10 page (20 results per page) Click on first result first page Click back to result => You see the first page with the first result at the top Click on second page, 3rd result Click back to result => You see the second page with the biblio you clicked at the 3rd position Click on second page, 3rd result Click next/previous Click back to result => You see the page where you last result were. I think the existing expected behaviour was to have the result you clicked at the first position of the result page, but I am not sure it really makes sense. Hope this makes sense however! Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 3edbe7d7dc9358e55b4ecc9da5b292a32cadcce9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/js/browser.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 21:56:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 20:56:41 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-39-gd3466bf7a3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d3466bf7a3ba554d0ecd0fe0143628a468b4b7ff (commit) from b1d76c5d08af71c06cc03cfa06d46b46959dcbcf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3466bf7a3ba554d0ecd0fe0143628a468b4b7ff Author: Katrin Fischer Date: Tue Oct 20 16:55:37 2020 +0000 Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit b3be51d4ef2145b7db7b48c9ee32f86ddd34a964) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/notices.tt | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 22:00:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 21:00:08 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-40-g61362fd043 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 61362fd0431c6bc439507cc4e49c0810a704f925 (commit) from d3466bf7a3ba554d0ecd0fe0143628a468b4b7ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 61362fd0431c6bc439507cc4e49c0810a704f925 Author: Mark Hofstetter Date: Mon Oct 19 17:28:19 2020 +0000 Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc /cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. Signed-off-by: Jonathan Druart (cherry picked from commit 28d20b92be91ae509a7f71586ada2535d3c2007d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/overdue_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 22:14:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 21:14:56 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-42-g50b6f91094 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 50b6f91094b11df73021be162c7c49dd6ca1c615 (commit) via 8c1c56d94c9221c67025c10c580e0f84cbe3074e (commit) from 61362fd0431c6bc439507cc4e49c0810a704f925 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50b6f91094b11df73021be162c7c49dd6ca1c615 Author: Kyle M Hall Date: Thu Nov 5 06:40:42 2020 -0500 Bug 26627: (QA follow-up) Remove barcode input by id Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart (cherry picked from commit ebb437349ebbadf90599c23a46126e5d8eda72da) Signed-off-by: Lucas Gass commit 8c1c56d94c9221c67025c10c580e0f84cbe3074e Author: Kyle M Hall Date: Wed Oct 7 11:01:02 2020 -0400 Bug 26627: Print and confirming a hold can cause an infinite loop Test plan: 1) Place a hold for pickup at library A 2) Confirm the hold and print slip 3) Checkin the item again 4) Confirm the hold and print slip 5) The modal returns, do it again 6) Apply this patch 7) Reload the page 8) Repeat steps 1-3 9) No loop! Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a71596fb395d449a62f5a6417780ed23948755c4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 22:23:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 21:23:04 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-44-g3a671b0ca6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3a671b0ca6b414d62cd652dafa83d2828b7020a2 (commit) via 06150351b431064bbc9cf343b459276820d649fc (commit) from 50b6f91094b11df73021be162c7c49dd6ca1c615 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3a671b0ca6b414d62cd652dafa83d2828b7020a2 Author: Nick Clemens Date: Mon Nov 2 11:24:02 2020 +0000 Bug 26781: (follow-up) Adjust tests as fields are no longer completely removed Signed-off-by: Jonathan Druart (cherry picked from commit 03742a1e246e68fa62c2f2fff963beba28f35c80) Signed-off-by: Lucas Gass commit 06150351b431064bbc9cf343b459276820d649fc Author: Nick Clemens Date: Thu Oct 22 10:59:17 2020 +0000 Bug 26781: Check for subfield defined rather than truth To recreate: 1 - Have a record with 100$0 defined 2 - Define a Marc Modification template: Delete field 100$0 3 - Perform Batch record modification, enter the record above in the list of records 4 - Preview the MARC 5 - Note the entire 100 field has been deleted, don't modify the record 6 - Apply patch 7 - Restart all the things 8 - Test the modification again 9 - This time the preview confirms only the subfield 0 deleted 10 - Modify the record 11 - Confirm the record is correctly updated Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer JD amended patch: Fix typo ony vs only Signed-off-by: Jonathan Druart (cherry picked from commit be4f0c7639a679b1ec808e6e9cf9af0fc9576e79) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SimpleMARC.pm | 2 +- t/SimpleMARC.t | 14 +++++++++++++- t/db_dependent/MarcModificationTemplates.t | 12 ++++++++++++ 3 files changed, 26 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 22:25:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 21:25:34 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-45-g5b85449898 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5b8544989846db705747ec0738ad24cddd012ad4 (commit) from 3a671b0ca6b414d62cd652dafa83d2828b7020a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5b8544989846db705747ec0738ad24cddd012ad4 Author: Nick Clemens Date: Thu Oct 22 12:36:13 2020 +0000 Bug 26784: Silence warns about comparing undefined values for MARC modification templates This patch simply checks if conditionals are defined before comparing We don't need to check actions because you cannot save an action without an action :-) To test: 1 - Define several actions for a MARC modification template 2 - Ensure you have actions with no conditionals 3 - Tail the intranet logs 4 - Browse to Tools->MARC modification templates 5 - Click 'Edit actions' for the template you setup above 6 - Note warns like: [2020/10/22 12:30:18] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/tools/marc_modification_templates.pl line 127. 7 - Apply patch 8 - Restart all the things 9 - Edit actions again and note no more warns Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2dd19840449beadd1f1752bd8cc18f0163f7f8a4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: tools/marc_modification_templates.pl | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 22:39:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 21:39:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-48-g7485f479fa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7485f479fafb1b04d7681432c5cc421ab3f2afae (commit) via 7a1fe44a376d594d2b7c7ce26d0bae421bf109b4 (commit) via 3890be5ba9f8f082c8ea8bf227411e97f624f251 (commit) from 5b8544989846db705747ec0738ad24cddd012ad4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7485f479fafb1b04d7681432c5cc421ab3f2afae Author: Jonathan Druart Date: Mon Nov 2 08:42:20 2020 +0100 Bug 26673: Fix perlcritic complains This patch fixes the following perlcritic complain: Package declaration must match filename at line 19, column 1. Correct the filename or package statement. Signed-off-by: Jonathan Druart (cherry picked from commit 59588c3a3e3390c2796ac417696829fd26fcb4f0) Signed-off-by: Lucas Gass commit 7a1fe44a376d594d2b7c7ce26d0bae421bf109b4 Author: David Cook Date: Wed Oct 14 22:53:24 2020 +0000 Bug 26673: Remove #!/usr/bin/env perl from .pm modules too Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e692b40523839bda45a20e4cf1cac7cdfbf53a13) Signed-off-by: Lucas Gass commit 3890be5ba9f8f082c8ea8bf227411e97f624f251 Author: Jonathan Druart Date: Wed Oct 14 11:24:33 2020 +0200 Bug 26673: Remove shebangs from Perl modules It's not needed. Signed-off-by: David Cook Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9f47b4ffd72211a216df67ef912b5eddb2b954db) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 5 ++--- C4/SIP/Logger.pm | 1 - C4/SIP/SIPServer.pm | 1 - C4/ShelfBrowser.pm | 2 -- C4/TTParser.pm | 2 -- Koha/Z3950Responder.pm | 2 -- Koha/Z3950Responder/GenericSession.pm | 2 -- Koha/Z3950Responder/RPN.pm | 5 +++-- Koha/Z3950Responder/Session.pm | 2 -- Koha/Z3950Responder/ZebraSession.pm | 2 -- 10 files changed, 5 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 22:56:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 21:56:22 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-54-g076fcca891 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 076fcca891258e9f9800066f4f6a33889247a5c3 (commit) via a88f367c63a2d649625fe367fa64ce3c888638ab (commit) via 5fc0d24ca8c58407e4461142054cb67a4aec5a00 (commit) via 9999d88169db3bd51d30b489d762a615c1872f7f (commit) via 610fab83e0c8d0304f695e95174ae5804cb2ed72 (commit) via fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de (commit) from 7485f479fafb1b04d7681432c5cc421ab3f2afae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 076fcca891258e9f9800066f4f6a33889247a5c3 Author: Lucas Gass Date: Fri Nov 13 21:20:24 2020 +0000 Bug 18050: DBRev 20.05.05.002 Signed-off-by: Lucas Gass commit a88f367c63a2d649625fe367fa64ce3c888638ab Author: Katrin Fischer Date: Mon Oct 5 06:17:34 2020 +0000 Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d) Signed-off-by: Lucas Gass commit 5fc0d24ca8c58407e4461142054cb67a4aec5a00 Author: Agustin Moyano Date: Fri Oct 9 15:14:26 2020 -0300 Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1193dddd8beb4a10a78e385b221c0f908d92dcf6) Signed-off-by: Lucas Gass commit 9999d88169db3bd51d30b489d762a615c1872f7f Author: Katrin Fischer Date: Sun Sep 13 23:31:52 2020 +0000 Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35) Signed-off-by: Lucas Gass commit 610fab83e0c8d0304f695e95174ae5804cb2ed72 Author: Lucas Gass Date: Fri Nov 13 21:15:16 2020 +0000 Bug 18050: DBIC Signed-off-by: Lucas Gass commit fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de Author: Katrin Fischer Date: Sun Sep 13 22:42:27 2020 +0000 Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0ce62b29bf5ebe30125eb4c631de11391134f109) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Aqbudget.pm | 33 +++++++++++++++++++++++++--- Koha/Schema/Result/Aqbudgetperiod.pm | 21 ++++++++++++++++-- installer/data/mysql/kohastructure.sql | 3 ++- installer/data/mysql/updatedatabase.pl | 39 ++++++++++++++++++++++++++++++++++ 5 files changed, 91 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:00:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:00:23 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-55-ge7c500439c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e7c500439c323fb2bee3d5f1a4ec848bdf600cbf (commit) from 076fcca891258e9f9800066f4f6a33889247a5c3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e7c500439c323fb2bee3d5f1a4ec848bdf600cbf Author: Katrin Fischer Date: Sat Oct 17 15:08:59 2020 +0000 Bug 26526: Relabel checkout note column in OPAC When checkout notes are active, there is currently a new column labelled 'Note' in the checkouts table in OPAC. When a note is added, this is sent to the library. For the user it's not clear from the label, that these notes are not personal, but for reporting to the library. The new label "Report a problem" aims to make this clearer. To test: - Turn on AllowCheckoutNotes system preference - Check out some items to your account - Go to the OPAC - Look at the list of checkouts - Apply patch - Reload the page and check the checkouts table again - Verify the heading has changed from "Notes" to "Report a problem" - Hover over the heading with your cursor to see some more info Bonus: Patch adds an id "checkout-notes" to the header cell, that will make it easier for libraries to change text or style if needed. Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 70c64fad46a91f910a00d59149000b982705fd24) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:02:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:02:48 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-56-g8232e315ad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8232e315ad9b08a33e0f7b0a5a5c06a5a00f823d (commit) from e7c500439c323fb2bee3d5f1a4ec848bdf600cbf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8232e315ad9b08a33e0f7b0a5a5c06a5a00f823d Author: Owen Leonard Date: Mon Oct 19 18:32:18 2020 +0000 Bug 25353: Correct eslint errors in additems.js This patch makes minor changes to additem.js to correct errors highlighted by eslint: - Consistent indentation - Notation of global and exported variables and functions - Consistent use of the "var" declaration for all new variables - Remove variables from function calls which aren't used To test, apply the patch and use your preferred eslint-enabled tool to check for errors. There should be none. If you don't have eslint integrated in your development environment you could use the online ESLint demo at https://eslint.org/demo. The demo isn't configured to assume a browser environment with jQuery present, so you'll have to modify the top line after pasting the contents of additem.js: /* global $ alert window __ */ Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit ebe08fb745b04899404bed5ceb00c891a518e89c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/additem.js | 52 +++++++++++++++--------------- 1 file changed, 26 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:06:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:06:50 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-57-ge47f2132ad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e47f2132add2b132806caeeff1631059b0f1cba8 (commit) from 8232e315ad9b08a33e0f7b0a5a5c06a5a00f823d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e47f2132add2b132806caeeff1631059b0f1cba8 Author: Owen Leonard Date: Tue Oct 20 11:22:07 2020 +0000 Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode This patch adds the "Print" string to datatables.js so that it can be picked up for translation. To test, apply the patch and add some items to the cart in the OPAC. - Open the cart. You should see a button labeled "Print." - The print button should work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/opac-tmpl/bootstrap/js/datatables.js for translation: msgid "Print" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the OPAC and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 599a6cb92e26e37857b344484d6c8b233555f0dc) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:10:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:10:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-58-gc854580e90 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c854580e90f934bab6361bc3d8f72101f578dbfb (commit) from e47f2132add2b132806caeeff1631059b0f1cba8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c854580e90f934bab6361bc3d8f72101f578dbfb Author: Lucas Gass Date: Fri Nov 13 21:36:34 2020 +0000 Revert "Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode" This reverts commit e47f2132add2b132806caeeff1631059b0f1cba8. Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:12:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:12:26 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-59-g468ede88c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 468ede88c555c0192a940fc2bb214a26cad85920 (commit) from c854580e90f934bab6361bc3d8f72101f578dbfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 468ede88c555c0192a940fc2bb214a26cad85920 Author: Owen Leonard Date: Tue Oct 20 16:04:11 2020 +0000 Bug 26756: Fix quotes showing behind some system preference descriptions This patch adds matching quotes to two OPAC preference descriptions which were missing them. To test, apply the patch and go to Administration -> System preferences. - Open the "OPAC" tab. - Check the descriptions of these preferences: - AllowPatronToSetCheckoutsVisibilityForGuarantor - AllowPatronToSetFinesVisibilityForGuarantor There should be no trailing quotation mark. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2dab6ab31626970e3c9be841b610575060f8f344) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:15:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:15:01 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-60-g79a8302b65 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 79a8302b6531a1be10f16003808cf7bb97e24575 (commit) from 468ede88c555c0192a940fc2bb214a26cad85920 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 79a8302b6531a1be10f16003808cf7bb97e24575 Author: Owen Leonard Date: Wed Oct 21 11:57:26 2020 +0000 Bug 26762: Modify template logic in opac-reserves.tt to avoid error This patch makes a change to the OPAC hold template to prevent certain cases where the output is invalid. To reproduce, perform a search in the OPAC which will return some titles which can be placed on hold and some which cannot. - Select all results (some holdable, some not) - Click the "Place hold" link - On the "Confirm holds" page the layout will be broken after the first instance of the message "There are no items that can be placed on hold." To test, apply the patch and repeat the process above. After the patch has been applied the "confirm holds" page should look correct. Validating the HTML source should return no errors. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit d10d24e42aaaf4b2e23b52b94aa14ab8745b396f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:17:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:17:30 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-61-g3b8ca43be9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3b8ca43be9aeed02982170a58a62388bed220d80 (commit) from 79a8302b6531a1be10f16003808cf7bb97e24575 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b8ca43be9aeed02982170a58a62388bed220d80 Author: Owen Leonard Date: Wed Oct 21 17:15:30 2020 +0000 Bug 26766: Correct selection of title during OPAC note confirmation This patch modifies the JavaScript in opac-user.tt which executes when the user submits a checkout note. The script tries to grab the checkout's title from an earlier cell in the table row so that it can display it in the confirmation message. Before start ratings were enabled on this page, the title of each checked-out item was the only HTML inside this table cell, so it was necessary only to grab the HTML contents of the . Now that star ratings might be displayed as well we must make the selection more specific. To test, apply the patch and enable both the OpacStarRatings and AllowCheckoutNotes preferences. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, fill out and submit the "Note" field for one of your checkouts. - In the confirmation message, confirm that the correct title information is displayed as a link to the bibliographic detail page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 54dcce14139bf5c60e98603a667629141296580e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:23:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:23:05 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-62-g5436293590 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 54362935908bd9c2061598a9a150c721e620456d (commit) from 3b8ca43be9aeed02982170a58a62388bed220d80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 54362935908bd9c2061598a9a150c721e620456d Author: Phil Ringnalda Date: Fri Oct 2 15:35:04 2020 -0700 Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:26:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:26:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-65-g27e540206b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 27e540206b7d175d665e4e4c95588b931970d27e (commit) via 8505b729a62250c7e7734efedf47a939bf6a258e (commit) via dbeb06986be273c53846333dd5e17e5acd04b44c (commit) from 54362935908bd9c2061598a9a150c721e620456d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 27e540206b7d175d665e4e4c95588b931970d27e Author: Nick Clemens Date: Sat Oct 24 00:42:31 2020 +0000 Bug 26725: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 17723b5423fcf644026130d8cc75e58986c55efb) Signed-off-by: Lucas Gass commit 8505b729a62250c7e7734efedf47a939bf6a258e Author: Tal Rogoff Date: Fri Oct 23 22:45:58 2020 +0000 Bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 46b371a057e619264ad1c8d39abbcce7745ae734) Signed-off-by: Lucas Gass commit dbeb06986be273c53846333dd5e17e5acd04b44c Author: Tal Rogoff Date: Fri Oct 23 22:10:59 2020 +0000 Bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit b3a51fbc552ad89d7ee4604ac502cd2e7a7a8667) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 13 23:29:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Nov 2020 22:29:31 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-67-gdeaa657362 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via deaa657362567308aa9837004376d3275e78bedf (commit) via 160f871856975f1a87ea23137267012086328877 (commit) from 27e540206b7d175d665e4e4c95588b931970d27e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit deaa657362567308aa9837004376d3275e78bedf Author: Nick Clemens Date: Sat Oct 24 02:07:51 2020 +0000 Bug 26450: (QA follow-up) Replace tabs with spaces Signed-off-by: Jonathan Druart (cherry picked from commit cf12049ca1b71a5c5ef12092499fb39aea8f36e9) Signed-off-by: Lucas Gass commit 160f871856975f1a87ea23137267012086328877 Author: Andreas Roussos Date: Mon Sep 14 09:59:34 2020 +0200 Bug 26450: fix typo in plugin template The UNIMARC field 105 plugin template contains some dropdown menu options with unnecessary capitalisation: "w - Religious text". This patch fixes that. Test plan: apply the patch, and confirm that the dropdown menu options appear in all lowercase. Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 17f307285f5d877806ac95fe64ce154be03948b6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../cataloguing/value_builder/unimarc_field_105.tt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Nov 14 03:53:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Nov 2020 02:53:50 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-70-ge564d2e63b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e564d2e63b631edcfa7a7b9ae81b5aa8562de31b (commit) via 885791f964e8bcc359d5af70cf5309ee5dabeeb9 (commit) via 2b3e477be3690d4e718bc683e87e73065aaf0d6b (commit) from deaa657362567308aa9837004376d3275e78bedf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e564d2e63b631edcfa7a7b9ae81b5aa8562de31b Author: Nick Clemens Date: Thu Oct 1 10:50:17 2020 +0000 Bug 26583: Remove unneccessary code in AddIssue The lines to calc due date are doubled ModDateLastSeen is not needed as we set the item not lost and we can set the date as we do for date last borrowed and save a DB store Largely this is reading the code and confirming the changes make sense To test: 1 - Apply patch 2 - Check out items, confirm it works as before 3 - prove -v t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 6e37dcafee872cdea378ba845ef49d702a3fbfc5) Signed-off-by: Lucas Gass commit 885791f964e8bcc359d5af70cf5309ee5dabeeb9 Author: Nick Clemens Date: Sat Oct 24 00:21:55 2020 +0000 Bug 26726: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 6da94551f122373e9ec418d3c80035c599c18fb5) Signed-off-by: Lucas Gass commit 2b3e477be3690d4e718bc683e87e73065aaf0d6b Author: Tal Rogoff Date: Fri Oct 23 23:02:29 2020 +0000 Bug 26726: changed the text of the "here" link on the transport cost matrix administration page test plan: 1.Set the UseTransportCostMatrix system to disabled 2.Go to Administration>Transport cost matrix 3.Blue box at top of the page contains link labelled "here" 4.Apply patch 5.Refresh page 6.Link should now be labelled "UseTransportCostMatrix" Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit c85b3ee07f551644891c86a74d6d2f87bfc9bdeb) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 12 +++--------- .../prog/en/modules/admin/transport-cost-matrix.tt | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 14:21:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 13:21:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1875-g55835ccfaf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 55835ccfaffef48b924857e18bfd964aebda3a0a (commit) via a386954b8b17925ed213a56878e1d453ba8c7635 (commit) via 36d46c6510ee93ffc52f6b914389c66351b16f33 (commit) via ea725f472426caab9bcdbef128fd5693f795fe17 (commit) via f6323ee5351a6801321c0938690344f04aef6c54 (commit) via 8b21682c332b63afd3be74073e5eeaf531dadeac (commit) via a408fcc0b662c31a8911728ab3d6816ada4c3491 (commit) from 91e21d3a95520f19fa3632d87f2c8f32b11ea1eb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 55835ccfaffef48b924857e18bfd964aebda3a0a Author: Tomas Cohen Arazi Date: Fri Nov 13 15:54:32 2020 -0300 Bug 27021: Make chaining ->empty always return an empty resultset This patch borrows the implementation Martin did on bug 27002, to woraround this issue, and implements it properly on the Koha::Objects->empty method. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Tests fail! The resultset should be empty and it isn't! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off! Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit a386954b8b17925ed213a56878e1d453ba8c7635 Author: Tomas Cohen Arazi Date: Fri Nov 13 15:47:39 2020 -0300 Bug 27021: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 36d46c6510ee93ffc52f6b914389c66351b16f33 Author: Colin Campbell Date: Thu Nov 12 11:42:05 2020 +0000 Bug 18267: Refactored Edifact Price Calculations Refactored the price calculations for Quotes and Invoices This takes in to account various combinations used by different vendors. Makes the extraction of basic price, quantity and tax information more reliable. Tests are in Edifact.t and EdiInvoice.t Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit ea725f472426caab9bcdbef128fd5693f795fe17 Author: Martin Renvoize Date: Fri Nov 13 12:12:20 2020 +0000 Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart commit f6323ee5351a6801321c0938690344f04aef6c54 Author: Kyle M Hall Date: Mon Jun 15 12:26:14 2020 -0400 Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart commit 8b21682c332b63afd3be74073e5eeaf531dadeac Author: Joonas Kylmälä Date: Fri Nov 13 12:07:22 2020 +0200 Bug 27012: Fix incorrect SQL syntax in hold merging If you merge two records with holds in them following error happens without this patch: [WARN] DBD::mysql::st execute failed: called with 4 bind variables when 3 are needed [for Statement "SELECT * FROM reserves WHERE biblionumber = ? AND (found <> ? AND found <> ? OR found is NULL) ORDER BY reservedate ASC" with ParamValues: 0=Null!, 1=Null!, 2=Null!] at /kohadevbox/koha/C4/Reserves.pm line 2002. To test: 1) Notice prove t/db_dependent/Reserves.t fails with above error 2) Apply patch 3) Notice prove t/db_dependent/Reserves.t passes Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit a408fcc0b662c31a8911728ab3d6816ada4c3491 Author: Joonas Kylmälä Date: Fri Nov 13 13:41:16 2020 +0200 Bug 27012: Add test for C4::Reserves::MergeHolds This does a basic check whether a hold gets moved to another biblio when MergeHolds() is called. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 4 +- C4/SIP/Sip/MsgType.pm | 10 ++-- Koha/EDI.pm | 132 ++++++++++++++++++++++++++++------------- Koha/Edifact/Line.pm | 74 +++++++++++++++++++++-- Koha/Objects.pm | 1 + debian/templates/SIPconfig.xml | 3 +- etc/SIPconfig.xml | 3 +- t/EdiInvoice.t | 26 +++++++- t/Edifact.t | 15 ++++- t/db_dependent/Koha/Objects.t | 12 ++-- t/db_dependent/Reserves.t | 29 ++++++++- 11 files changed, 247 insertions(+), 62 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 16:18:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 15:18:57 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-71-g694f5ee9d8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 694f5ee9d8b21532c04598498e10f9f6c7e542c0 (commit) from e564d2e63b631edcfa7a7b9ae81b5aa8562de31b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 694f5ee9d8b21532c04598498e10f9f6c7e542c0 Author: Mason James Date: Tue Oct 27 07:41:03 2020 +1300 Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error 00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1. 00:02:16.310 koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `aqbudgets` ( -- information related to Funds Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3df7a02d8198e7a0a0af5459c4c3d2192177b27f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 37 +++++++++++++++++----------------- 1 file changed, 18 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 19:36:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 18:36:53 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-74-gcc36475cff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cc36475cff550beed85c646dd4ed0d45ac8918b3 (commit) via 0cca3766be6e1bc13fbb0c33e02d708ac70fc946 (commit) via e5367af11159b33f43c0cef0968f204366dbad99 (commit) from 694f5ee9d8b21532c04598498e10f9f6c7e542c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cc36475cff550beed85c646dd4ed0d45ac8918b3 Author: Nick Clemens Date: Mon Nov 2 12:46:59 2020 +0000 Bug 26581: (follow-up) Skip merge when deleting authority Tests failing, seems to be because the indexes haven't been created yet. When deleting authority we perform a 'merge' where we search for biblios containing the authority. Since these are simply tets we can skip this step, avoid the search, and avoid a crash Signed-off-by: Lucas Gass commit 0cca3766be6e1bc13fbb0c33e02d708ac70fc946 Author: Nick Clemens Date: Tue Oct 27 14:36:24 2020 +0000 Bug 26581: (follow-up) Restore unsetting of doreturn Signed-off-by: Lucas Gass commit e5367af11159b33f43c0cef0968f204366dbad99 Author: Martin Renvoize Date: Fri Oct 16 15:04:31 2020 +0100 Bug 26581: [20.05.x] Only reindex records once per checkin This patch simply passes skip_record_index calls to Koha:Item:store for all the changes done in AddReturn. Testing is really verifiying that items are still correctly indexed at the end For both search engines To test: 1 - Find or create a record with multipel items 2 - Populate both: UpdateItemLocationOnCheckin UpdateNotForLoanStatusOnCheckin 3 - Confirm that checking in an item correctly updates the item status in search results 4 - Test with items issued, and items not issued 5 - Test when generating a transfer (checkin at different branch) 6 - Test when item was marked lost 7 - Test when filling transfer Signed-off-by: Séverine Queune Signed-off-by: Christoper Brannon Signed-off-by: Martin Renvoize Bug 26581: Unit tests These tests cover the changes to ensure the AddReturn calls index_records once per call and that other calls pass the skip_record_index parameter correctly Signed-off-by: Séverine Queune Signed-off-by: Christoper Brannon Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 39 +++++++++++------ C4/Items.pm | 18 +++++--- t/db_dependent/Koha/SearchEngine/Indexer.t | 68 +++++++++++++++++++++++++++--- 3 files changed, 99 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 19:40:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 18:40:45 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-75-g5b5c58e08b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5b5c58e08b04fa6c329d30d834329194ffd422bf (commit) from cc36475cff550beed85c646dd4ed0d45ac8918b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5b5c58e08b04fa6c329d30d834329194ffd422bf Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 +0000 Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4d92e3d284e392ad681b095c02965fe57a85a5a1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/MetaSearcher.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 19:48:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 18:48:34 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-76-geb4533babb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via eb4533babb0ba78f2a50a7c1fc60864e17b3f27d (commit) from 5b5c58e08b04fa6c329d30d834329194ffd422bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb4533babb0ba78f2a50a7c1fc60864e17b3f27d Author: Fridolin Somers Date: Fri Sep 18 15:09:10 2020 +0200 Bug 26487: Add all MARC flavours for not-onloan-count search field In admin/searchengine/elasticsearch/mappings.yaml the search field not-onloan-count is defined for MARC21 on 999x. This should be for all the MARC flavours, like in Zebra config. Test plan: 1) On a UNIMARC database 2) Reset Elasticsearch mappings 3) Check search engine config to see field 'not-onloan-count' on 999$x 4) Same on a NORMARC database Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0ee41b53168c3a5275533a731160b643909cd110) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: admin/searchengine/elasticsearch/mappings.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 20:04:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 19:04:46 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-77-g17571f824d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 17571f824d391989247465c7ae18c92c744464c2 (commit) from eb4533babb0ba78f2a50a7c1fc60864e17b3f27d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17571f824d391989247465c7ae18c92c744464c2 Author: Nick Clemens Date: Tue Oct 27 15:59:46 2020 +0000 Bug 17515: Order Z3950 server by rank and preserve ordering Previously we put all the servers into an object with keys of the server id This patch converts it to an array of objects to preserve order, and adjusts code to use the array index where necessary and store the server id within the array To test: 1 - Add some new Z3950 servers, they don't need to be valid FIRST SECOND THIRD FOURTH 2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4 3 - Enable and launch the advanced editor 4 - Click 'Advanced' under search on the left 5 - Note the list displays in the order you entered the servers 6 - Apply patch 7 - Reload 8 - Order is correct 9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results https://bugs.koha-community.org/show_bug.cgi?id=17515 Signed-off-by: B Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 7bbf4f7b5fe54a46d2c54a4dc445a0400dfbef23) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/MetaSearcher.pm | 2 +- cataloguing/editor.pl | 2 +- .../intranet-tmpl/lib/koha/cateditor/search.js | 4 +-- .../prog/en/includes/cateditor-ui.inc | 33 ++++++++++++---------- svc/cataloguing/metasearch | 1 + 5 files changed, 23 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 20:10:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 19:10:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-78-g2fa997f9a9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2fa997f9a947aced8ae7ab7337a27e127909d5d3 (commit) from 17571f824d391989247465c7ae18c92c744464c2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2fa997f9a947aced8ae7ab7337a27e127909d5d3 Author: Owen Leonard Date: Mon Oct 26 11:55:57 2020 +0000 Bug 26816: Chomp whitespace around i18n strings This patch adds the chomp shorthand [%- -%] to the output of i18n.inc to prevent extra spaces from being inserted. To test, apply the patch and perform a catalog search in the staff interface which will return results with multiple items. In the items column, the availability information should not have unwanted spaces: 3 items, 3 available: ...instead of 3 items , 3 available: Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 190f7155f1e9b3100a0dfb91279228033fc28546) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/i18n.inc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 20:12:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 19:12:30 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-79-g940fdc447a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 940fdc447a0312a10903a7ae49e1a4b7d88c4521 (commit) from 2fa997f9a947aced8ae7ab7337a27e127909d5d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 940fdc447a0312a10903a7ae49e1a4b7d88c4521 Author: Lisette Scheer Date: Sat Oct 24 18:18:54 2020 +0000 Bug 26723: Improve link text on OverDriveAuthName system preference The OverDriveAuthName system preference contains a link labeled "here" to a seperate administration page that should be labeled better. This patch renames the link. To test: 1. Go to administration 2. Search the system preferences for OverDriveAuthName 3. Obeserve the "here" link in the preference. 4. Apply the patch. 5. Repeat steps 1-2. 6. Observe the new link text. 7. Sign off. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit daca3478f48ece4f92957eb4b4638d5aa18844a5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/enhanced_content.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 20:15:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 19:15:59 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-80-g7ac243c96f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7ac243c96fef9fcf728d647f1e9d301506ccf08a (commit) from 940fdc447a0312a10903a7ae49e1a4b7d88c4521 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ac243c96fef9fcf728d647f1e9d301506ccf08a Author: Phil Ringnalda Date: Fri Oct 2 14:52:57 2020 -0700 Bug 26605: Correctly URI-encode query string in call number browse plugin If you search for a call number like "M KRUEGER CO #11" in the cn_browser.pl plugin, your query is cut off at "M KRUEGER CO " because the hash isn't escaped, so the browser thinks you are opening a window and trying to navigate to the element with the id 11 rather than passing the #11 to the server. To test: 1) Find the record you will use to test, determing the MARC framework it uses by going to Edit > Edit record > Settings 2) In Administration > MARC bibliographic framework, click MARC structure in the Actions menu for that framework 3) Navigate to the 952 tag, in the Actions menu click Edit subfields 4) In the tab for o, choose the Plugin cn_browser.pl and click Save Changes 5) Click the Edit button next to one of the items on your record 6) In the Full call number field, add " CO #11" to the call number 7) Click the ... next to the field to open the Tag editor 8) In the popup window, verify that the search field includes the " CO #11" you added to the call number Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c52a9e4cf362949192d3d58adab287cd82effbf1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/value_builder/cn_browser.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 20:23:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 19:23:27 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-81-g493e62aad8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 493e62aad82931304bdcf2c63152451aed781b16 (commit) from 7ac243c96fef9fcf728d647f1e9d301506ccf08a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 493e62aad82931304bdcf2c63152451aed781b16 Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 20:49:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 19:49:57 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-85-g6add1365f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6add1365f6ed5827f684b8328852c54e2ab13690 (commit) via 3006eb144ce2af13c5317bcc835b8874e0b44216 (commit) via e65776a6d208667058918ab03fa36c8da243c082 (commit) via 3d554f7ff6b0c76ae674893fcbf0273c80885815 (commit) from 493e62aad82931304bdcf2c63152451aed781b16 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6add1365f6ed5827f684b8328852c54e2ab13690 Author: Lucas Gass Date: Mon Nov 16 19:13:14 2020 +0000 Bug 26853: DBIC changes Signed-off-by: Lucas Gass commit 3006eb144ce2af13c5317bcc835b8874e0b44216 Author: Lucas Gass Date: Mon Nov 16 19:10:46 2020 +0000 Bug 26853: DBRev 20.05.05.003 Signed-off-by: Lucas Gass commit e65776a6d208667058918ab03fa36c8da243c082 Author: David Cook Date: Thu Oct 29 05:23:10 2020 +0000 Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 8b70bd03f7371deb8dd7ef25e2036c0bbc9b1698) Signed-off-by: Lucas Gass commit 3d554f7ff6b0c76ae674893fcbf0273c80885815 Author: David Cook Date: Thu Oct 29 05:20:53 2020 +0000 Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit e39b9684d5cd0ce15a3d1f07d7691b832309287b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 2 +- Koha.pm | 2 +- Koha/Schema/Result/ImportBiblio.pm | 24 ++++++++++-------------- installer/data/mysql/kohastructure.sql | 12 ++++++------ installer/data/mysql/updatedatabase.pl | 16 ++++++++++++++++ 5 files changed, 34 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 22:06:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 21:06:12 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-86-gabff9a9cd8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via abff9a9cd8fb82bafe5bc38f44a030950fb6e86e (commit) from 6add1365f6ed5827f684b8328852c54e2ab13690 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit abff9a9cd8fb82bafe5bc38f44a030950fb6e86e Author: Blou Date: Mon Nov 2 14:24:50 2020 -0500 Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3dee550e346d8a998335eb7ce77b4a064a1d129a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 22:14:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 21:14:37 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-88-g949abc2074 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 949abc20748c696cbe8a60addff5f91970e199ab (commit) via c724a3db1d83447459b488ee7911a821720a5da1 (commit) from abff9a9cd8fb82bafe5bc38f44a030950fb6e86e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 949abc20748c696cbe8a60addff5f91970e199ab Author: Nick Clemens Date: Sat Oct 24 01:51:55 2020 +0000 Bug 25167: (QA follow-up) Don't add a new variable Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7a87cc310b5836b6808c8836ee9e38b3dd725160) Signed-off-by: Lucas Gass commit c724a3db1d83447459b488ee7911a821720a5da1 Author: Didier Gautheron Date: Wed Apr 8 09:33:44 2020 +0200 Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 1181402eee9392fddf0e3a64de5941880485c074) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: tools/inventory.pl | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 22:19:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 21:19:53 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-89-gc5d3b86019 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c5d3b86019c475dad701167e519b2feec45becdb (commit) from 949abc20748c696cbe8a60addff5f91970e199ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c5d3b86019c475dad701167e519b2feec45becdb Author: Katrin Fischer Date: Fri Oct 16 01:23:41 2020 +0200 Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit adfed0a945eb00ff0fe501ff1c90e25076777a34) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 22:38:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 21:38:48 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-90-g45f356ad97 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 45f356ad97a84af3f28b298ac6d5f9ce17a6075e (commit) from c5d3b86019c475dad701167e519b2feec45becdb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45f356ad97a84af3f28b298ac6d5f9ce17a6075e Author: Fridolin Somers Date: Tue Oct 27 09:03:16 2020 +0100 Bug 26832: Make Elasticsearch mappings export use UTF-8 Script misc/search_tools/export_elasticsearch_mappings.pl allows to export current search engine configuration into a YAML file. This export should use UTF-8 encoding, like other exports. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Edit a field label to use a diacrtic, for example local-number => Numéro 3) Save 4) Edit file etc/koha-conf.xml to enable 'elasticsearch_index_mappings' 5) Export mappings to file via misc/search_tools/export_elasticsearch_mappings.pl -t $MARCFLAVOUR 6) Reset memcached and plack 7) Back to Administration > Search engine configuration (Elasticsearch) 8) Click on 'Reset Mappings' and accept 9) Look at field 'local-number' => Without patch diacritic 'é' is broken 10) You may try with an emoji B-) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 9441537e5436b43805d578108ebee0c8394eb5aa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/search_tools/export_elasticsearch_mappings.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 22:41:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 21:41:56 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-91-g7c505acfe4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7c505acfe4b7031a428ee95afaf3cacd6ccabdec (commit) from 45f356ad97a84af3f28b298ac6d5f9ce17a6075e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7c505acfe4b7031a428ee95afaf3cacd6ccabdec Author: Katrin Fischer Date: Mon Oct 26 22:40:50 2020 +0000 Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference The mapping in the itemcallnumber system preference is only valid for MARC21 libraries using DDC classification, but not for libraries using UNIMARC or other classification. This patch suggests to remove the default mapping and start new installations with an empty value. To test: - On an emtpy database - Apply patch - Run the web installer, selecting either MARC21 or UNIMARC - Verify that the itemcallnumber system preference is empty - Verify the description now also include examples for UNIMARC Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit d80421ce855fd9069dbe1e7cd6b1ea42a665899b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- .../intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 22:50:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 21:50:09 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-92-g87cbd07be8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 87cbd07be836291f860ecbd5cea5538863317164 (commit) from 7c505acfe4b7031a428ee95afaf3cacd6ccabdec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87cbd07be836291f860ecbd5cea5538863317164 Author: Katrin Fischer Date: Sat Oct 17 22:47:49 2020 +0000 Bug 26190: Allow to close a basket with only cancelled order lines At the moment there are several cases, when closing a basket is not possible: - when there are no order lines in it - when there are order lines with uncertain prices - when the basket is marked as a standing order The first case wasn't checked correctly as only pending/received orders would be counted, but not cancelled orders. To test: - Create a basket - Create an order line - Verify the "close this basket" button shows - Cancel the order line - the button disappears - Apply the patch - Verify the button appears and works now - Create another basket - make sure you cannot close it without order lines - Create an order line with uncertain price checked - you cannot close it - Resolve the uncertain price - you can now close the basket. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: acqui/basket.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 23:18:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 22:18:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-93-gaeef2fadc3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via aeef2fadc39ce019e4f665621d282b088f9a2704 (commit) from 87cbd07be836291f860ecbd5cea5538863317164 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit aeef2fadc39ce019e4f665621d282b088f9a2704 Author: Jonathan Druart Date: Wed Nov 4 09:04:19 2020 +0100 Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 42c0475a948577442e44b11dbb12b45b25171418) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: members/pay.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 23:22:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 22:22:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-94-g5cba820797 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5cba820797f8cc83dfd271efb208da676da12eec (commit) from aeef2fadc39ce019e4f665621d282b088f9a2704 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5cba820797f8cc83dfd271efb208da676da12eec Author: Jonathan Druart Date: Tue Nov 3 16:45:33 2020 +0100 Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules UPDATE: changed queries to not touch * values To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-5 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 31e38bc371943d1e76f49aacd1dd159a254f71e7) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 15 +++++++++++++++ 1 file changed, 15 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 23:25:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 22:25:04 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-96-g2db5e8beb2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2db5e8beb29e7ba2e438f0363a53f72c4cc49b80 (commit) via dd60ec0813ac3c68b032c08a674a166dea0eee78 (commit) from 5cba820797f8cc83dfd271efb208da676da12eec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2db5e8beb29e7ba2e438f0363a53f72c4cc49b80 Author: Martin Renvoize Date: Thu Nov 5 12:42:47 2020 +0000 Bug 26908: (follow-up) Alter template check This alters the template check to use the presence of the plugins arrayref rather than requiring a second call to check for plugins_enabled. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit a10db1347dfbe5a444e669e363aab9b635d74069) Signed-off-by: Lucas Gass commit dd60ec0813ac3c68b032c08a674a166dea0eee78 Author: Kyle M Hall Date: Tue Nov 3 08:31:39 2020 -0500 Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0d438de0186fb08d2a1f8eb82b0df0204efff5ef) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 23:43:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 22:43:31 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-98-g45c29bbccf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 45c29bbccf624a210f79ab6294df97038fb2bd29 (commit) via 5643d5432906776d34ea5a13296b0f607fcae306 (commit) from 2db5e8beb29e7ba2e438f0363a53f72c4cc49b80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45c29bbccf624a210f79ab6294df97038fb2bd29 Author: Owen Leonard Date: Tue Nov 3 18:00:57 2020 +0000 Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the

is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary

is removed. - In the merge patrons template the submit button is now in a

as is consistent with other forms. - In the MARC modifications template I've added
s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a
and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit d5d736909ccd24b38e90e89b1484da73972d8645) Signed-off-by: Lucas Gass commit 5643d5432906776d34ea5a13296b0f607fcae306 Author: Katrin Fischer Date: Sun Oct 18 16:30:24 2020 +0000 Bug 26727: Fix

appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit bbf0d21284924d6b7529017fc78178b98242aaee) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../modules/cataloguing/value_builder/EXAMPLE.tt | 6 +- .../prog/en/modules/circ/request-article.tt | 1 - .../prog/en/modules/members/merge-patrons.tt | 14 +- .../modules/tools/marc_modification_templates.tt | 142 +++++++++++---------- koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- 5 files changed, 87 insertions(+), 78 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 16 23:56:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 22:56:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-100-g97dac5e513 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 97dac5e5136f2a2a3d0e49c862c0b058bedafac8 (commit) via a230dda60451b3443575941fc50478034538a43c (commit) from 45c29bbccf624a210f79ab6294df97038fb2bd29 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 97dac5e5136f2a2a3d0e49c862c0b058bedafac8 Author: Tomas Cohen Arazi Date: Tue Oct 20 14:36:22 2020 -0300 Bug 24633: (follow-up) Tweak sample plugin targets Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 017036f695df46df1fe3c2106b96b6285b0b9e83) Signed-off-by: Lucas Gass commit a230dda60451b3443575941fc50478034538a43c Author: Tomas Cohen Arazi Date: Tue Oct 20 14:29:38 2020 -0300 Bug 24633: Add support for gitlab searching of plugins This patch adds the option to add Gitlab repositories to look for Koha plugins. As with Github, plugin projects need to be named koha-plugin-* and the release file needs to be named with the .kpz extension. To test: 1. Apply this patchset 2. Check either koha-conf.xml or koha-conf.site.xml.in for sample configurations of gitlab targets. 3. Tweak your koha-conf.xml accordingly. You could have: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions gitlab PTFS Europe ptfs-europe github 4. Flush memcached and restart plack: $ flush_memcached $ koha-plack --restart kohadev 5. Open the plugins page, search for anything, like 'gobi' or 'a' => SUCCESS: You get Theke results! 6. Pick a gitlab plugin for install => SUCCESS: It is installed! 7. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit df2a7e4aa200ea9648d993241e75ef27e12fa103) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/templates/koha-conf-site.xml.in | 2 +- etc/koha-conf.xml | 2 +- plugins/plugins-home.pl | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 00:08:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 23:08:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-103-gcebd342a49 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cebd342a49bf4218c6f937278b7d90641a88ca47 (commit) via bafef273577c4513a6929265d7408fe567afa6f1 (commit) via 03562822ec2f774fb0a659809ef3e3b3587befd6 (commit) from 97dac5e5136f2a2a3d0e49c862c0b058bedafac8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cebd342a49bf4218c6f937278b7d90641a88ca47 Author: Kyle M Hall Date: Thu Nov 5 06:48:04 2020 -0500 Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method Signed-off-by: Jonathan Druart (cherry picked from commit f8206ca60cb1bbd32a90b7898a6877166026b8bb) Signed-off-by: Lucas Gass commit bafef273577c4513a6929265d7408fe567afa6f1 Author: Fridolin Somers Date: Thu Oct 1 14:19:05 2020 +0200 Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit bd66a2e175e062b662652f81efcafb48b6d230d7) commit 03562822ec2f774fb0a659809ef3e3b3587befd6 Author: Fridolin Somers Date: Fri Oct 2 09:22:36 2020 +0200 Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit e5ba5f406899c554ccc71212cbee5531b91c3f41) ----------------------------------------------------------------------- Summary of changes: Koha/Patron.pm | 4 ++++ Koha/Patron/Debarments.pm | 14 ++++++------ t/db_dependent/Patron/Borrower_Debarments.t | 35 ++++++++++++++++++++++++++++- 3 files changed, 45 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 00:13:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 23:13:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-104-g8ea97143a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8ea97143a53baf145fe2bb707760a4631a18096a (commit) from cebd342a49bf4218c6f937278b7d90641a88ca47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ea97143a53baf145fe2bb707760a4631a18096a Author: Jonathan Druart Date: Tue Nov 10 14:11:10 2020 +0100 Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable $serialitem is not a Koha::Item there, we need to fetch the item before. Test plan: Turn makePreviousSerialAvailable on Create a subscription Receive an serial item, mark it "arrived" Without this patch Koha explodes with No property notforloan for Koha::Serial::Item at /usr/share/perl5/Exception/Class/Base.pm line 88 Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)', 'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line 273 With this patch applied the notforloan and itype values are correctly set for the new serial item. Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit dc465736cd14a860ffbda1571012fe94fb1e65fa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: serials/serials-edit.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 00:17:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Nov 2020 23:17:58 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-105-ge0ec375ee3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e0ec375ee31270a8ee123e116355086ad58fa36d (commit) from 8ea97143a53baf145fe2bb707760a4631a18096a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e0ec375ee31270a8ee123e116355086ad58fa36d Author: Jonathan Druart Date: Wed Nov 11 14:55:27 2020 +0100 Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred There is a missing parameter to CanItemBeReserved, we need to know if the hold can be placed at a given pickup library. Test plan: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item (with a pickup library different than Centerville) => Without this patch you are taken to the holds list, but your hold is not placed Nothing indicates why hold has failed => With this patch you cannot select the item from Centerville "Cannot be transferred to pickup library" Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit fbd0bbf98f574a7eb804673978a198eea6fdd798) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 04:55:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 03:55:00 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-4-g3d1d81014d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3d1d81014db886e35a18ee546c9a9e2dfb011ce9 (commit) from 5add311155c577ace9d3990430b63f9b19af8733 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d1d81014db886e35a18ee546c9a9e2dfb011ce9 Author: Marcel de Rooy Date: Tue Aug 11 11:22:22 2020 +0000 Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b827acf53ffde71d787123095b8524ea6bd08fd6) Signed-off-by: Lucas Gass (cherry picked from commit f095fc1aeffaabd9d54f7df0378f226b0d2e0729) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:16:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:16:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-5-g35cafa56f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 35cafa56f424a81ae98113d4f1db376987787849 (commit) from 3d1d81014db886e35a18ee546c9a9e2dfb011ce9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35cafa56f424a81ae98113d4f1db376987787849 Author: Kyle M Hall Date: Fri Oct 2 12:11:48 2020 -0400 Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott Signed-off-by: Martin Renvoize JD Test plan: 1. Create a new subscription * When there is an irregular issue: Skip issue number * Select a frequency (not irregular) * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field 2. Receive a first serial (mark it arrived, an "expected" one is created) 3. Claim the expected one => You have 1 arrived and 1 claimed. It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl 4. Generate next => boom Signed-off-by: Jonathan Druart (cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e) Signed-off-by: Lucas Gass (cherry picked from commit 8c527522ec02c4b07c57c5a211d846856c936018) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: serials/serials-collection.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:20:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:20:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-6-g4e55967da5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4e55967da50418ab5f58b96171e7dc1b7ac01c85 (commit) from 35cafa56f424a81ae98113d4f1db376987787849 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4e55967da50418ab5f58b96171e7dc1b7ac01c85 Author: Alex Buckley Date: Tue Sep 29 05:53:34 2020 +0000 Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Test plan: 1. Check the OAI-PMH:AutoUpdateSets syspref is disabled 2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass successfully 3. Enabled the OAI-PMH:AutoUpdateSets syspref 4. Repeat step 2 and confirm the tests fail 5. Apply this patch and restart plack: sudo koha-plack --restart 6. Repeat step 2 and confirm the tests now pass 7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and confirm tests still pass Sponsored-By: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 913897f3a484ea31a2373de7aac2cc8298319575) Signed-off-by: Lucas Gass (cherry picked from commit d3254f7e5726cdfb3572ae42eec057e90c25407d) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: t/db_dependent/OAI/Sets.t | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:25:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:25:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-7-g5ffa2a41f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5ffa2a41f177f247e76b181e047496839c050836 (commit) from 4e55967da50418ab5f58b96171e7dc1b7ac01c85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5ffa2a41f177f247e76b181e047496839c050836 Author: Emmi Takkinen Date: Fri Sep 25 13:52:06 2020 +0300 Bug 26429: Show correct expiration date at the request.pl Bug 25789 changed holds tables expriration input class as "datepickerto". This results to past expiration date to be displayed as tomorrows date. Class "futuredate" should have been used instead. To test: 1. Have waiting hold with expiration date in past (e.g 24.9) 2. Observe that waiting reserves table displays correct expiration date 3. At the request.pl page expiration date is however displayed as 26.9 => Apply patch 4. Confirm that expiration date at the request.pl is now 24.9 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1b40ee8d18b7fee42193cfb2bac5e44146a1afd9) Signed-off-by: Lucas Gass (cherry picked from commit 497435fa842ca6ac8c80942283c5c3663563b4fa) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:37:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:37:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-9-g775f958575 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 775f958575e462372517286e38cbf093da5bd53f (commit) via a57d0fe74597680ff24968e1596857c9a7133072 (commit) from 5ffa2a41f177f247e76b181e047496839c050836 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 775f958575e462372517286e38cbf093da5bd53f Author: Jonathan Druart Date: Thu Jul 30 15:15:46 2020 +0200 Bug 20804: Add support for "days" to the timeout syspref If the timeout syspref did not contain an integer, or was not matching integer.'d|D', then it "fallback" to 0 We can easily add support for hours and fallback to 600 if the value is not correct. It will prevent the session to timeout immediately Test plan: 0. Do not apply the patches 1. Fill the timeout syspref with "5h" 2. Login 3. Click somewhere => Notice that the session timed out 4. Apply the patches, restart_all 5. Login 6. Click somewhere => You have 5 hours to enjoy Koha 7. Fill the pref with an incorrect value ("5x" for instance) 8. Logout, login 9. There is a warning in the log, and you have 10 minutes (600 secondes) to enjoy Koha Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 97b9eab178f0b45b38662747a4e009e71d8b73ff) Signed-off-by: Lucas Gass (cherry picked from commit 78e8c65bf5fa8db6b9a8e8f3313359a4f295c00d) Signed-off-by: Aleisha Amohia commit a57d0fe74597680ff24968e1596857c9a7133072 Author: Jonathan Druart Date: Thu Jul 30 15:15:36 2020 +0200 Bug 20804: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c9c7f4543a06553c6cbf04ff58a82eb6a40fc9c) Signed-off-by: Lucas Gass (cherry picked from commit 356d1ca888b3591bde960f30c43e6afcd93b66dc) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 14 ++++++++++++-- t/db_dependent/Auth.t | 21 ++++++++++++++++++++- 2 files changed, 32 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:42:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:42:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-10-gfc31bc6cee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fc31bc6cee24e07d254155bc5f30a3ad022fa523 (commit) from 775f958575e462372517286e38cbf093da5bd53f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc31bc6cee24e07d254155bc5f30a3ad022fa523 Author: David Cook Date: Mon Sep 21 02:02:27 2020 +0000 Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fd35df346f73a00b643e675853ba2c8ef321cf66) Signed-off-by: Lucas Gass (cherry picked from commit 7f4b2f20991fd04da0703fafb7b643a03fcc7e14) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:45:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:45:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-12-g1fee97d513 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1fee97d513294322e08d43d3c2089756ffd8fb8d (commit) via 7ce97d4b17482b865f51a2e6fb0db0c1821cadff (commit) from fc31bc6cee24e07d254155bc5f30a3ad022fa523 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1fee97d513294322e08d43d3c2089756ffd8fb8d Author: Martin Renvoize Date: Wed Oct 7 16:37:06 2020 +0100 Bug 25549: Add error reporting to plugins-home This patch adds handling for the newly introduced 'errors' option in GetPlugins and reports erroroneos plugins to the user. To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - The plugin should display as installed in the table at tools/plugins. 5 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 6 - Add a line to break compilation, like: this won't compile 7 - Restart all 8 - Your Koha is not broken, but is no longer orange (The plugin is not loading). 9 - The plugin should display as unable to load in the table at tools/plugins. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 759ff4519961d0c256eb05a4797fb21c3b2c22d9) Signed-off-by: Lucas Gass (cherry picked from commit acd96409ea869862506233cee3404e14254e5725) Signed-off-by: Aleisha Amohia commit 7ce97d4b17482b865f51a2e6fb0db0c1821cadff Author: Nick Clemens Date: Wed May 20 11:12:12 2020 +0000 Bug 25549: Remove plugin methods for broken plugins To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 5 - Add a line to break compilation, like: this won't compile 6 - Restart all 7 - Your koha is now broken 8 - kshell 9 - perl misc/devel/install_plugins.pl 10 - Restart all 11 - Koha remains broken 12 - Apply patch 13 - kshell 14 - perl misc/devel/install_plugins.pl 15 - Koha now works! 16 - Koha is not orange because the plugin methods are removed Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0eae966d257fa2ecc6a6506e2515691e092a701c) Signed-off-by: Lucas Gass (cherry picked from commit bd2347fbf85083fe6204dcaaf1cc98826219eaed) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha/Plugins.pm | 39 ++++++++++++---------- .../prog/en/modules/plugins/plugins-home.tt | 15 +++++++++ misc/devel/install_plugins.pl | 10 ++++-- plugins/plugins-home.pl | 11 +++--- 4 files changed, 50 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 05:57:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 04:57:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-13-g7d5d0a4885 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 7d5d0a488596e6594d934ca60e1ad79902c1368d (commit) from 1fee97d513294322e08d43d3c2089756ffd8fb8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d5d0a488596e6594d934ca60e1ad79902c1368d Author: Nick Clemens Date: Thu Sep 3 16:23:04 2020 +0000 Bug 8437: Exclude export.pl from plack When attempting to download large files from Koha plack can timeout Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1 - Try to export your entire DB from Tools->Export 2 - If big enough, it fails 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4 - Restart all the things 5 - Repeat export, it succeeds Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 564ade93cce9231b01db1c4ebfc8f4e5b31e1acd) Signed-off-by: Lucas Gass (cherry picked from commit ae2bce1312b63d732ec07df21ef16740a8d179d2) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet-plack.conf | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:04:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:04:13 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-15-g70348d8d4d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 70348d8d4da5d777a08cb3ad6908ad0719c4b544 (commit) via f48c2578e87641aaab2826c84ba396ae83bf64ad (commit) from 7d5d0a488596e6594d934ca60e1ad79902c1368d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70348d8d4da5d777a08cb3ad6908ad0719c4b544 Author: Aleisha Amohia Date: Tue Nov 17 17:32:14 2020 +1300 Bug 26569: DBRev 19.11.11.001 Signed-off-by: Aleisha Amohia commit f48c2578e87641aaab2826c84ba396ae83bf64ad Author: Andrew Fuerste-Henry Date: Wed Sep 30 13:14:12 2020 +0000 Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a96f5deef04bb74fbd826449b4d82f651a67512c) Signed-off-by: Lucas Gass (cherry picked from commit 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/.updatedatabase.pl.swp | Bin 0 -> 28672 bytes installer/data/mysql/sysprefs.sql | 12 ++++++------ installer/data/mysql/updatedatabase.pl | 13 +++++++++++++ 4 files changed, 20 insertions(+), 7 deletions(-) create mode 100644 installer/data/mysql/.updatedatabase.pl.swp hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:05:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:05:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-16-gec86fa6ea7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via ec86fa6ea75264058cc137e103adc25a8dae3b6c (commit) from 70348d8d4da5d777a08cb3ad6908ad0719c4b544 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ec86fa6ea75264058cc137e103adc25a8dae3b6c Author: John Fawcett Date: Mon Oct 12 13:06:40 2020 +0200 Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 7c74c6636f779bbbaceee74f8704df9ec625815d) Signed-off-by: Lucas Gass (cherry picked from commit 3973ef10b6b68eb4550dacf2c5a99475040dfdd1) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:07:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:07:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-17-gdb2e177ac1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via db2e177ac1327497868e3457899745c6d9ff4e83 (commit) from ec86fa6ea75264058cc137e103adc25a8dae3b6c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit db2e177ac1327497868e3457899745c6d9ff4e83 Author: John Fawcett Date: Mon Oct 12 11:18:30 2020 +0200 Bug 26613: Fix it-IT unimarc_framework.sql installer file This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3bd23a3287345167de50d994d737351174c04936) Signed-off-by: Lucas Gass (cherry picked from commit acc93b31cef93765f09b6585dbaad69d190b8fa2) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:11:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:11:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-18-g8cd87230b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8cd87230b188d6677b58d222049919dcd9467401 (commit) from db2e177ac1327497868e3457899745c6d9ff4e83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8cd87230b188d6677b58d222049919dcd9467401 Author: Mark Hofstetter Date: Mon Oct 19 17:28:19 2020 +0000 Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc /cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. Signed-off-by: Jonathan Druart (cherry picked from commit 28d20b92be91ae509a7f71586ada2535d3c2007d) Signed-off-by: Lucas Gass (cherry picked from commit 61362fd0431c6bc439507cc4e49c0810a704f925) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/overdue_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:29:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:29:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-24-g026316d551 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 026316d5515621aa3a096850754d2fae5b6f01dc (commit) via b70d602694ae45ec059f7b1d2763534c3f0a66c4 (commit) via 7c8e7bd18004e17a854433a0a1fcacabaf18d248 (commit) via 6a9cc05a0a046ba7535e7258e563fb8ec16d9ee3 (commit) via 3ff1ddc4b926b7c0dce6a66833ac7b85cf36ac41 (commit) via af2146e565d5eb7c2ad95b744706f9a0c147af50 (commit) from 8cd87230b188d6677b58d222049919dcd9467401 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 026316d5515621aa3a096850754d2fae5b6f01dc Author: Aleisha Amohia Date: Tue Nov 17 17:56:18 2020 +1300 Bug 18050: DBRev 19.11.11.002 Signed-off-by: Aleisha Amohia commit b70d602694ae45ec059f7b1d2763534c3f0a66c4 Author: Katrin Fischer Date: Mon Oct 5 06:17:34 2020 +0000 Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d) Signed-off-by: Lucas Gass (cherry picked from commit a88f367c63a2d649625fe367fa64ce3c888638ab) Signed-off-by: Aleisha Amohia commit 7c8e7bd18004e17a854433a0a1fcacabaf18d248 Author: Agustin Moyano Date: Fri Oct 9 15:14:26 2020 -0300 Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1193dddd8beb4a10a78e385b221c0f908d92dcf6) Signed-off-by: Lucas Gass (cherry picked from commit 5fc0d24ca8c58407e4461142054cb67a4aec5a00) Signed-off-by: Aleisha Amohia commit 6a9cc05a0a046ba7535e7258e563fb8ec16d9ee3 Author: Katrin Fischer Date: Sun Sep 13 23:31:52 2020 +0000 Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35) Signed-off-by: Lucas Gass (cherry picked from commit 9999d88169db3bd51d30b489d762a615c1872f7f) Signed-off-by: Aleisha Amohia commit 3ff1ddc4b926b7c0dce6a66833ac7b85cf36ac41 Author: Aleisha Amohia Date: Tue Nov 17 17:51:14 2020 +1300 Bug 18050: DBIC Signed-off-by: Aleisha Amohia commit af2146e565d5eb7c2ad95b744706f9a0c147af50 Author: Katrin Fischer Date: Sun Sep 13 22:42:27 2020 +0000 Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0ce62b29bf5ebe30125eb4c631de11391134f109) Signed-off-by: Lucas Gass (cherry picked from commit fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Aqbudget.pm | 33 +++++++++++++++++++++++++--- Koha/Schema/Result/Aqbudgetperiod.pm | 21 ++++++++++++++++-- installer/data/mysql/kohastructure.sql | 3 ++- installer/data/mysql/updatedatabase.pl | 40 ++++++++++++++++++++++++++++++++++ 5 files changed, 92 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:36:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:36:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-25-g3447a782c2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 (commit) from 026316d5515621aa3a096850754d2fae5b6f01dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 Author: Phil Ringnalda Date: Fri Oct 2 15:35:04 2020 -0700 Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass (cherry picked from commit 54362935908bd9c2061598a9a150c721e620456d) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:41:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:41:45 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-26-g3c48826637 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3c488266373ab3be3c96e0966bd0c29f6d41d9f4 (commit) from 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3c488266373ab3be3c96e0966bd0c29f6d41d9f4 Author: Mason James Date: Tue Oct 27 07:41:03 2020 +1300 Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error 00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1. 00:02:16.310 koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `aqbudgets` ( -- information related to Funds Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3df7a02d8198e7a0a0af5459c4c3d2192177b27f) Signed-off-by: Lucas Gass (cherry picked from commit 694f5ee9d8b21532c04598498e10f9f6c7e542c0) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 37 +++++++++++++++++----------------- 1 file changed, 18 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:44:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:44:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-27-gb5121e77fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b5121e77fe703df81942cdac89829bf6848829db (commit) from 3c488266373ab3be3c96e0966bd0c29f6d41d9f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5121e77fe703df81942cdac89829bf6848829db Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 +0000 Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4d92e3d284e392ad681b095c02965fe57a85a5a1) Signed-off-by: Lucas Gass (cherry picked from commit 5b5c58e08b04fa6c329d30d834329194ffd422bf) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha/MetaSearcher.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:47:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:47:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-28-g5321c20a8f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5321c20a8f99bd1e63b85f46a27c87280a607de2 (commit) from b5121e77fe703df81942cdac89829bf6848829db (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5321c20a8f99bd1e63b85f46a27c87280a607de2 Author: Phil Ringnalda Date: Fri Oct 2 14:52:57 2020 -0700 Bug 26605: Correctly URI-encode query string in call number browse plugin If you search for a call number like "M KRUEGER CO #11" in the cn_browser.pl plugin, your query is cut off at "M KRUEGER CO " because the hash isn't escaped, so the browser thinks you are opening a window and trying to navigate to the element with the id 11 rather than passing the #11 to the server. To test: 1) Find the record you will use to test, determing the MARC framework it uses by going to Edit > Edit record > Settings 2) In Administration > MARC bibliographic framework, click MARC structure in the Actions menu for that framework 3) Navigate to the 952 tag, in the Actions menu click Edit subfields 4) In the tab for o, choose the Plugin cn_browser.pl and click Save Changes 5) Click the Edit button next to one of the items on your record 6) In the Full call number field, add " CO #11" to the call number 7) Click the ... next to the field to open the Tag editor 8) In the popup window, verify that the search field includes the " CO #11" you added to the call number Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c52a9e4cf362949192d3d58adab287cd82effbf1) Signed-off-by: Lucas Gass (cherry picked from commit 7ac243c96fef9fcf728d647f1e9d301506ccf08a) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: cataloguing/value_builder/cn_browser.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 06:49:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 05:49:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-29-g81be2e66f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 81be2e66f63ce49730c822173ceddf857b0eb845 (commit) from 5321c20a8f99bd1e63b85f46a27c87280a607de2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81be2e66f63ce49730c822173ceddf857b0eb845 Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f) Signed-off-by: Lucas Gass (cherry picked from commit 493e62aad82931304bdcf2c63152451aed781b16) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 07:01:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 06:01:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-30-gf402c9366f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f402c9366f2f1e192ac054aab34fa5e2cadde6d1 (commit) from 81be2e66f63ce49730c822173ceddf857b0eb845 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f402c9366f2f1e192ac054aab34fa5e2cadde6d1 Author: Katrin Fischer Date: Sat Oct 17 22:47:49 2020 +0000 Bug 26190: Allow to close a basket with only cancelled order lines At the moment there are several cases, when closing a basket is not possible: - when there are no order lines in it - when there are order lines with uncertain prices - when the basket is marked as a standing order The first case wasn't checked correctly as only pending/received orders would be counted, but not cancelled orders. To test: - Create a basket - Create an order line - Verify the "close this basket" button shows - Cancel the order line - the button disappears - Apply the patch - Verify the button appears and works now - Create another basket - make sure you cannot close it without order lines - Create an order line with uncertain price checked - you cannot close it - Resolve the uncertain price - you can now close the basket. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa) Signed-off-by: Lucas Gass (cherry picked from commit 87cbd07be836291f860ecbd5cea5538863317164) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: acqui/basket.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 07:08:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 06:08:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-32-gf7a46d6d80 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f7a46d6d80abee30ffd1ff3919d70d278faae61a (commit) via b7653e20a8d93ce9b47590df24b5d1cc9cca7731 (commit) from f402c9366f2f1e192ac054aab34fa5e2cadde6d1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f7a46d6d80abee30ffd1ff3919d70d278faae61a Author: Owen Leonard Date: Tue Nov 3 18:00:57 2020 +0000 Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the

is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary

is removed. - In the merge patrons template the submit button is now in a

as is consistent with other forms. - In the MARC modifications template I've added
s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a
and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit d5d736909ccd24b38e90e89b1484da73972d8645) Signed-off-by: Lucas Gass (cherry picked from commit 45c29bbccf624a210f79ab6294df97038fb2bd29) Signed-off-by: Aleisha Amohia commit b7653e20a8d93ce9b47590df24b5d1cc9cca7731 Author: Katrin Fischer Date: Sun Oct 18 16:30:24 2020 +0000 Bug 26727: Fix

appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit bbf0d21284924d6b7529017fc78178b98242aaee) Signed-off-by: Lucas Gass (cherry picked from commit 5643d5432906776d34ea5a13296b0f607fcae306) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: .../modules/cataloguing/value_builder/EXAMPLE.tt | 6 +- .../prog/en/modules/circ/request-article.tt | 1 - .../prog/en/modules/members/merge-patrons.tt | 14 +- .../modules/tools/marc_modification_templates.tt | 142 +++++++++++---------- koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- 5 files changed, 87 insertions(+), 78 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 11:10:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 10:10:53 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-7-g4efb21d5f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4efb21d5f862f748f4b33750794275eaf2051921 (commit) via e49596dbca7ed54dcb8f107bead6899a300b65b7 (commit) from f9dbb4b1e97d5456ba742bcee3284c33b0fdc501 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4efb21d5f862f748f4b33750794275eaf2051921 Author: Alex Buckley Date: Tue Sep 29 05:53:34 2020 +0000 Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Test plan: 1. Check the OAI-PMH:AutoUpdateSets syspref is disabled 2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass successfully 3. Enabled the OAI-PMH:AutoUpdateSets syspref 4. Repeat step 2 and confirm the tests fail 5. Apply this patch and restart plack: sudo koha-plack --restart 6. Repeat step 2 and confirm the tests now pass 7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and confirm tests still pass Sponsored-By: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 913897f3a484ea31a2373de7aac2cc8298319575) Signed-off-by: Lucas Gass (cherry picked from commit d3254f7e5726cdfb3572ae42eec057e90c25407d) Signed-off-by: Aleisha Amohia (cherry picked from commit 4e55967da50418ab5f58b96171e7dc1b7ac01c85) Signed-off-by: Victor Grousset/tuxayo commit e49596dbca7ed54dcb8f107bead6899a300b65b7 Author: Kyle M Hall Date: Fri Oct 2 12:11:48 2020 -0400 Bug 26604: "Generate next" button gives error on serials-collection.pl In serials-collection.pl, the line $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity}); causes the error Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198. This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down. Signed-off-by: kelly mcelligott Signed-off-by: Martin Renvoize JD Test plan: 1. Create a new subscription * When there is an irregular issue: Skip issue number * Select a frequency (not irregular) * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field 2. Receive a first serial (mark it arrived, an "expected" one is created) 3. Claim the expected one => You have 1 arrived and 1 claimed. It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl 4. Generate next => boom Signed-off-by: Jonathan Druart (cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e) Signed-off-by: Lucas Gass (cherry picked from commit 8c527522ec02c4b07c57c5a211d846856c936018) Signed-off-by: Aleisha Amohia (cherry picked from commit 35cafa56f424a81ae98113d4f1db376987787849) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: serials/serials-collection.pl | 3 +-- t/db_dependent/OAI/Sets.t | 30 ++++++++++++++++++++++++++++-- 2 files changed, 29 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 12:58:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 11:58:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1883-g836d9a3872 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 836d9a38727859f06902a7be6790592431fe812e (commit) via 5c70587c088241e30e6fe0e5f9bb858a0a165293 (commit) via 853a56cc7ae6c089f0f113943b77530d8c3a15c8 (commit) via 8a955f9a0ac65866541111e6242f2b57e4465ce5 (commit) via 6bbd13ba031cf4ba592b989e869cba3a95405d4b (commit) via 9935c0bdbfc22096640b79e998cf39118deb969e (commit) via 7db88b60441e69d3d2478276d13977bbf21a8ae5 (commit) via e1400890ec8040ced8e3550eddbfd0d4e8af2347 (commit) from 55835ccfaffef48b924857e18bfd964aebda3a0a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 836d9a38727859f06902a7be6790592431fe812e Author: Jonathan Druart Date: Tue Nov 10 11:37:55 2020 +0100 Bug 26986: Prevent Selenium's StaleElementReferenceException This is a follow-up bug for bug 26162 By finding the element before the click I hope to get the good element, even if the page changed in the meanwhile. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 5c70587c088241e30e6fe0e5f9bb858a0a165293 Author: Jonathan Druart Date: Tue Nov 10 12:55:17 2020 +0100 Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Sally Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 853a56cc7ae6c089f0f113943b77530d8c3a15c8 Author: Nick Clemens Date: Fri Nov 13 16:33:40 2020 +0000 Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 8a955f9a0ac65866541111e6242f2b57e4465ce5 Author: Nick Clemens Date: Fri Nov 13 16:33:12 2020 +0000 Bug 26903: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 6bbd13ba031cf4ba592b989e869cba3a95405d4b Author: Tomas Cohen Arazi Date: Mon Nov 16 12:54:13 2020 -0300 Bug 26988: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 9935c0bdbfc22096640b79e998cf39118deb969e Author: Martin Renvoize Date: Fri Nov 13 13:53:15 2020 +0000 Bug 27002: Update callers for changed return Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 7db88b60441e69d3d2478276d13977bbf21a8ae5 Author: Martin Renvoize Date: Thu Nov 12 08:09:56 2020 +0000 Bug 27002: Update Koha::Biblio->pickup_locations to return a resultset Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit e1400890ec8040ced8e3550eddbfd0d4e8af2347 Author: Nick Clemens Date: Wed Sep 23 14:42:40 2020 +0000 Bug 26516: Don't accept incorrect values for copyrightdate/publicationyear The previous patch rejects incorrect values when saving to the db specifically for copyrightdate An error is thrown for the int conversion when it fails Rather than catching things when saving we can fix the value when generated, simply returning null when parsing the record To test: 1 - Add a new record to Koha making sure data is valid except 260$c: 198- 2 - Save the record 3 - It fails 4 - Apply this patch 5 - Restart all the thigns 6 - Repeat 7 - Success! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 2 + Koha/Biblio.pm | 19 ++-- Koha/REST/V1/Holds.pm | 2 +- Koha/SearchEngine/Elasticsearch/Indexer.pm | 5 +- Koha/Template/Plugin/Branches.pm | 4 +- .../prog/en/modules/admin/patron-attr-types.tt | 2 +- .../bootstrap/en/modules/opac-memberentry.tt | 2 +- t/db_dependent/Biblio/TransformMarcToKoha.t | 8 +- t/db_dependent/Koha/Biblio.t | 2 +- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 33 ++++++- t/db_dependent/Template/Plugin/Branches.t | 3 +- t/db_dependent/api/v1/holds.t | 108 ++++++++++++++++++++- t/lib/Selenium.pm | 2 +- 13 files changed, 166 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 13:26:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 12:26:57 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-13-g6fe294e731 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6fe294e731dd76eb3f37e6df570be0398dae2519 (commit) via a25696fb12a117a4bd357e5189104dc11fe8546a (commit) via fb36dfd6fa08265e6d5baae83737f6eb740920c6 (commit) via cd71f5ba7228858926edf220f74eff9b4e1bd114 (commit) via 4be96d4f9e9bfd1e5a6b4a7d72cf347463fa03b6 (commit) via 87664a5ea7296186627a8ae277be69b1bd9a2037 (commit) from 4efb21d5f862f748f4b33750794275eaf2051921 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6fe294e731dd76eb3f37e6df570be0398dae2519 Author: Mark Hofstetter Date: Mon Oct 19 17:28:19 2020 +0000 Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc /cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. Signed-off-by: Jonathan Druart (cherry picked from commit 28d20b92be91ae509a7f71586ada2535d3c2007d) Signed-off-by: Lucas Gass (cherry picked from commit 61362fd0431c6bc439507cc4e49c0810a704f925) Signed-off-by: Aleisha Amohia (cherry picked from commit 8cd87230b188d6677b58d222049919dcd9467401) Signed-off-by: Victor Grousset/tuxayo commit a25696fb12a117a4bd357e5189104dc11fe8546a Author: John Fawcett Date: Mon Oct 12 11:18:30 2020 +0200 Bug 26613: Fix it-IT unimarc_framework.sql installer file This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3bd23a3287345167de50d994d737351174c04936) Signed-off-by: Lucas Gass (cherry picked from commit acc93b31cef93765f09b6585dbaad69d190b8fa2) Signed-off-by: Aleisha Amohia (cherry picked from commit db2e177ac1327497868e3457899745c6d9ff4e83) Signed-off-by: Victor Grousset/tuxayo commit fb36dfd6fa08265e6d5baae83737f6eb740920c6 Author: John Fawcett Date: Mon Oct 12 13:06:40 2020 +0200 Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 7c74c6636f779bbbaceee74f8704df9ec625815d) Signed-off-by: Lucas Gass (cherry picked from commit 3973ef10b6b68eb4550dacf2c5a99475040dfdd1) Signed-off-by: Aleisha Amohia (cherry picked from commit ec86fa6ea75264058cc137e103adc25a8dae3b6c) Signed-off-by: Victor Grousset/tuxayo commit cd71f5ba7228858926edf220f74eff9b4e1bd114 Author: Aleisha Amohia Date: Tue Nov 17 17:32:14 2020 +1300 Bug 26569: DBRev 19.05.16.001 Signed-off-by: Aleisha Amohia (cherry picked from commit 70348d8d4da5d777a08cb3ad6908ad0719c4b544) Signed-off-by: Victor Grousset/tuxayo commit 4be96d4f9e9bfd1e5a6b4a7d72cf347463fa03b6 Author: Andrew Fuerste-Henry Date: Wed Sep 30 13:14:12 2020 +0000 Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a96f5deef04bb74fbd826449b4d82f651a67512c) Signed-off-by: Lucas Gass (cherry picked from commit 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90) Signed-off-by: Aleisha Amohia (cherry picked from commit f48c2578e87641aaab2826c84ba396ae83bf64ad) Signed-off-by: Victor Grousset/tuxayo commit 87664a5ea7296186627a8ae277be69b1bd9a2037 Author: David Cook Date: Mon Sep 21 02:02:27 2020 +0000 Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fd35df346f73a00b643e675853ba2c8ef321cf66) Signed-off-by: Lucas Gass (cherry picked from commit 7f4b2f20991fd04da0703fafb7b643a03fcc7e14) Signed-off-by: Aleisha Amohia (cherry picked from commit fc31bc6cee24e07d254155bc5f30a3ad022fa523) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/.updatedatabase.pl.swp | Bin 0 -> 28672 bytes .../marcflavour/unimarc/necessari/unimarc_framework.sql | 8 ++++---- installer/data/mysql/sysprefs.sql | 10 +++++----- installer/data/mysql/updatedatabase.pl | 12 ++++++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 1 + misc/cronjobs/overdue_notices.pl | 2 +- 7 files changed, 24 insertions(+), 11 deletions(-) create mode 100644 installer/data/mysql/.updatedatabase.pl.swp hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 14:26:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 13:26:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-19-g23970975e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 23970975e358ea93624ca5c8559475e3a01bb1d6 (commit) via 74a7504ad126c6edef39371240a8524fab0fc2ea (commit) via ad2b4c88545ea1343a7820d53ed0acb510724671 (commit) via 82c553ca9021853b0d63d02782e31bd68730339c (commit) via 385e11f950a1f91aecc109e0a057036409f1ed07 (commit) via 9d3b7e470e8db9d8c27fc858a620408e547c0198 (commit) from 6fe294e731dd76eb3f37e6df570be0398dae2519 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 23970975e358ea93624ca5c8559475e3a01bb1d6 Author: Aleisha Amohia Date: Tue Nov 17 17:56:18 2020 +1300 Bug 18050: DBRev 19.05.16.002 Signed-off-by: Aleisha Amohia (cherry picked from commit 026316d5515621aa3a096850754d2fae5b6f01dc) Signed-off-by: Victor Grousset/tuxayo commit 74a7504ad126c6edef39371240a8524fab0fc2ea Author: Katrin Fischer Date: Mon Oct 5 06:17:34 2020 +0000 Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d) Signed-off-by: Lucas Gass (cherry picked from commit a88f367c63a2d649625fe367fa64ce3c888638ab) Signed-off-by: Aleisha Amohia (cherry picked from commit b70d602694ae45ec059f7b1d2763534c3f0a66c4) Signed-off-by: Victor Grousset/tuxayo commit ad2b4c88545ea1343a7820d53ed0acb510724671 Author: Agustin Moyano Date: Fri Oct 9 15:14:26 2020 -0300 Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1193dddd8beb4a10a78e385b221c0f908d92dcf6) Signed-off-by: Lucas Gass (cherry picked from commit 5fc0d24ca8c58407e4461142054cb67a4aec5a00) Signed-off-by: Aleisha Amohia (cherry picked from commit 7c8e7bd18004e17a854433a0a1fcacabaf18d248) Signed-off-by: Victor Grousset/tuxayo commit 82c553ca9021853b0d63d02782e31bd68730339c Author: Katrin Fischer Date: Sun Sep 13 23:31:52 2020 +0000 Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35) Signed-off-by: Lucas Gass (cherry picked from commit 9999d88169db3bd51d30b489d762a615c1872f7f) Signed-off-by: Aleisha Amohia (cherry picked from commit 6a9cc05a0a046ba7535e7258e563fb8ec16d9ee3) Signed-off-by: Victor Grousset/tuxayo commit 385e11f950a1f91aecc109e0a057036409f1ed07 Author: Victor Grousset/tuxayo Date: Tue Nov 17 13:37:48 2020 +0100 Bug 18050: DBIC Signed-off-by: Victor Grousset/tuxayo commit 9d3b7e470e8db9d8c27fc858a620408e547c0198 Author: Katrin Fischer Date: Sun Sep 13 22:42:27 2020 +0000 Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0ce62b29bf5ebe30125eb4c631de11391134f109) Signed-off-by: Lucas Gass (cherry picked from commit fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de) Signed-off-by: Aleisha Amohia (cherry picked from commit af2146e565d5eb7c2ad95b744706f9a0c147af50) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Aqbudget.pm | 33 +++++++++++++++++++++++++--- Koha/Schema/Result/Aqbudgetperiod.pm | 21 ++++++++++++++++-- installer/data/mysql/kohastructure.sql | 3 ++- installer/data/mysql/updatedatabase.pl | 40 ++++++++++++++++++++++++++++++++++ 5 files changed, 92 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 14:30:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 13:30:40 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-20-g7d6fc1ec20 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 7d6fc1ec20f4f01497226bc6ee72849005c4d9e4 (commit) from 23970975e358ea93624ca5c8559475e3a01bb1d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d6fc1ec20f4f01497226bc6ee72849005c4d9e4 Author: Mason James Date: Tue Oct 27 07:41:03 2020 +1300 Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error 00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1. 00:02:16.310 koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `aqbudgets` ( -- information related to Funds Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3df7a02d8198e7a0a0af5459c4c3d2192177b27f) Signed-off-by: Lucas Gass (cherry picked from commit 694f5ee9d8b21532c04598498e10f9f6c7e542c0) Signed-off-by: Aleisha Amohia (cherry picked from commit 3c488266373ab3be3c96e0966bd0c29f6d41d9f4) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 37 +++++++++++++++++----------------- 1 file changed, 18 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 14:31:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 13:31:31 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-21-g53b7843ee9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 53b7843ee9d507e2dff85d45e0f14ae5122c7abd (commit) from 7d6fc1ec20f4f01497226bc6ee72849005c4d9e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 53b7843ee9d507e2dff85d45e0f14ae5122c7abd Author: Phil Ringnalda Date: Fri Oct 2 15:35:04 2020 -0700 Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass (cherry picked from commit 54362935908bd9c2061598a9a150c721e620456d) Signed-off-by: Aleisha Amohia (cherry picked from commit 3447a782c2c3f95eee8dafb8bb5f450c044c4c17) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 15:59:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 14:59:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-23-ga5c2090ff5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a5c2090ff5853f839a8021d52494cfcba9a2c1be (commit) via 5f59c30c9f3c50229c85fd34bbedbe5b75c07310 (commit) from 53b7843ee9d507e2dff85d45e0f14ae5122c7abd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5c2090ff5853f839a8021d52494cfcba9a2c1be Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f) Signed-off-by: Lucas Gass (cherry picked from commit 493e62aad82931304bdcf2c63152451aed781b16) Signed-off-by: Aleisha Amohia (cherry picked from commit 81be2e66f63ce49730c822173ceddf857b0eb845) Signed-off-by: Victor Grousset/tuxayo commit 5f59c30c9f3c50229c85fd34bbedbe5b75c07310 Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 +0000 Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4d92e3d284e392ad681b095c02965fe57a85a5a1) Signed-off-by: Lucas Gass (cherry picked from commit 5b5c58e08b04fa6c329d30d834329194ffd422bf) Signed-off-by: Aleisha Amohia (cherry picked from commit b5121e77fe703df81942cdac89829bf6848829db) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 1 + Koha/MetaSearcher.pm | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 17:01:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 16:01:10 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-106-ge7bfecc25c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e7bfecc25c07252c1558cf828d4a7fddb2ad1720 (commit) from e0ec375ee31270a8ee123e116355086ad58fa36d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e7bfecc25c07252c1558cf828d4a7fddb2ad1720 Author: Nick Clemens Date: Wed Nov 11 01:24:15 2020 +0000 Bug 26963: [20.05.x] Bug 26963: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: Don't call 'can_be_transferred' for each possible library for each item Currently When calling Koha::Template::Plugin::Branches::pickup_locations we call pickup_location for each item of the bib, and for each item we get a list of possible branches, we then check those branches against the transfer limits, this is inefficent Given a system with 100 branches, and each branch having an item attached to one bib (100 items) we will call can_be_transferred ~10000 times - and that will happen for each hold placed on the bib For me this patch reduced load time from 77 seconds to 18 seconds To test: 1 - Find a bib 2 - Place 4 title level holds 3 - Add some branches and items for this bib to your system: INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"A"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"B"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"C"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"D"),pickup_location FROM branches; INSERT INTO items (biblionumber,biblioitemnumber,barcode,itype,homebranch,holdingbranch) SELECT 1,1,CONCAT("test-",branchcode),'BKS',branchcode,branchcode FROM branches; 4 - Set systempreferences: UseBranchTransferLimits = 'enforce' BranchTransferLimitsType = 'item type' 5 - Find the bib and click the holds tab 6 - Wait for a long time, it shoudl eventually load 7 - Apply patch and restart al the things 8 - Load the page again, it should be much faster Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Bob Bennhoff Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (follow-up) Change subroutine name for QA tools It didn't like the ending _at Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (QA follow-up) Convert to ResultSets This patch removes the previously introduced private method by converting the arrayref returns to ResultSets appropriately and inlining the filter search queries. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (QA follow-up) Migrate unit tests into pickup_location We wrote unit tests for _can_pickup_locations as part of this patchset, but then I inlined the method whilst golfing. This patch moves those tests into the existing pickup_locations test so we more thoroughly cover the case where branch transfer limits are in play. NOTE: The tests all assume that all items have an effective_itemtype and ccode. I'm pretty sure items all have a type at this point, but I'm less sure we enforce collection codes? Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (QA follow-up) Don't delete existing data before tests Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (QA follow-up) Update mocked return of pickup_locations Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (QA follow-up) Fix cases where we expected a list Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: (QA follow-up) Fix up tests and cover case of undefined ccode While this technically shouldn't happen, if a library creates itemtype limits, then flips the pref, those rules are still in the db until a ccode rule is saved. To be extra safe, when checking for rules of one type, we should make sure the other type is undef - i.e. if looking for ccode rules, we should confirm the itype is undef for those rules Additionally, we shouldn't set the barcode now that we are not deleting all items, so we use copynumber for our item identification field as it doesn't need to be unique in the DB Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Bug 26963: Ignore existing libraries Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 2 +- Koha/Item.pm | 61 ++++--- Koha/Library.pm | 2 +- Koha/Template/Plugin/Branches.pm | 2 +- reserve/request.pl | 2 +- t/db_dependent/Koha/Item.t | 275 ++++++++++++++++++++---------- t/db_dependent/Template/Plugin/Branches.t | 3 +- 7 files changed, 231 insertions(+), 116 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 17:18:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 16:18:49 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-107-gac5a9f2694 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ac5a9f2694cc6c1ac2929268024eff520602d20d (commit) from e7bfecc25c07252c1558cf828d4a7fddb2ad1720 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ac5a9f2694cc6c1ac2929268024eff520602d20d Author: Jonathan Druart Date: Tue Nov 10 12:55:17 2020 +0100 Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 19:23:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 18:23:54 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-108-g7045235a8d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 (commit) from ac5a9f2694cc6c1ac2929268024eff520602d20d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 Author: Jonathan Druart Date: Mon Nov 2 15:01:32 2020 +0100 Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Bug 26738: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/common/patron_search.tt | 6 ++- .../prog/en/modules/suggestion/suggestion.tt | 30 ++++++++++-- .../modules/suggestion/tables/suggester_search.tt | 36 -------------- koha-tmpl/intranet-tmpl/prog/js/suggestions.js | 17 ------- suggestion/add_user_search.pl | 7 +-- suggestion/suggester_search.pl | 57 ---------------------- suggestion/suggestion.pl | 14 +++++- 7 files changed, 48 insertions(+), 119 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/js/suggestions.js delete mode 100755 suggestion/suggester_search.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 17 21:57:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Nov 2020 20:57:57 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-33-g4a2fcd6604 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4a2fcd6604ec4f7490334ba98b038d46bf3a8cfb (commit) from f7a46d6d80abee30ffd1ff3919d70d278faae61a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4a2fcd6604ec4f7490334ba98b038d46bf3a8cfb Author: Jonathan Druart Date: Tue Nov 10 12:55:17 2020 +0100 Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Lucas Gass (cherry picked from commit ac5a9f2694cc6c1ac2929268024eff520602d20d) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 18 12:36:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 18 Nov 2020 11:36:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1891-gd4a15b27b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d4a15b27b8359a13fa80952ed7e920b7388527fb (commit) via 517dcabdf73acfaf01cde461beb8bac84f86c82e (commit) via 7abee7fd6913c178baffafe2ea8cfc33f38c87f6 (commit) via e8f39a001c979fb0ef7ac342dd07062285d0264d (commit) via 308b03a31b95a8808751b98d3b285adcb370f47f (commit) via bf8ab094705163f50f46451b0dffa00cdd1d4ab9 (commit) via 49658d43c3e3bb4064afdad824153325d2216083 (commit) via 258d475d5f4bb306496dc90b9c602fd776a6c545 (commit) from 836d9a38727859f06902a7be6790592431fe812e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d4a15b27b8359a13fa80952ed7e920b7388527fb Author: Tomas Cohen Arazi Date: Tue Aug 11 09:32:10 2020 -0300 Bug 25313: (QA follow-up) DelAuthority tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 517dcabdf73acfaf01cde461beb8bac84f86c82e Author: Marcel de Rooy Date: Wed Apr 29 16:19:00 2020 +0200 Bug 25313: Add skip_merge to ModAuthority Sometimes you know that the merge is useless, since the reporting tag did not change. Might be handy in batch processing of authority records. Test plan: Pick an authority with a few linked biblio recs (so that it will immediately merge; lower than MergeLimit). Open authority record and save it. Verify that a linked biblio record was merged. Check time in 005. You proved that this patch does not break the regular process. Signed-off-by: Marcel de Rooy Signed-off-by: Phil Ringnalda Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7abee7fd6913c178baffafe2ea8cfc33f38c87f6 Author: Tomas Cohen Arazi Date: Tue Aug 11 09:26:50 2020 -0300 Bug 25313: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e8f39a001c979fb0ef7ac342dd07062285d0264d Author: Nick Clemens Date: Tue Sep 1 13:32:46 2020 +0000 Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same Signed-off-by: David Nind Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 308b03a31b95a8808751b98d3b285adcb370f47f Author: Andrew Fuerste-Henry Date: Thu Nov 5 20:28:11 2020 +0000 Bug 26944: Point help link to automatic item mod in manual To test: 1 - go to automatic item mod, click help, end up at manual homepage 2 - apply patch, restart, reload page 3 - click link again, go to auto item mod in manual Signed-off-by: Sally Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit bf8ab094705163f50f46451b0dffa00cdd1d4ab9 Author: Jonathan Druart Date: Tue Nov 10 12:32:04 2020 +0100 Bug 26846: Fix regressions - Preselect expected and late serials This is a follow-up for bug 17674. Expected and late serials must be checked by default. Test plan: Have some serial collection and notice that the checkboxes are checked for expected and late serials /serials/serials-collection.pl?subscriptionid=42 Signed-off-by: Timothy Alexis Vass Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 49658d43c3e3bb4064afdad824153325d2216083 Author: Martin Renvoize Date: Tue Nov 3 09:57:32 2020 +0000 Bug 26939: Use AV description in sales table display Content should use the description rather than the code Test plan 1/ Enable 'UseCashRegisters' 2/ Make some payments against a cash register 3/ Navigate to the cash register summary page via tools > cashup registers > register name 4/ Note that the payment type you selected at payment time appears as the code of the authorized value as aposed to the description. 5/ Apply patch 6/ Refresh page 7/ The payment type should now contain the description Signed-off-by: David Nind Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 258d475d5f4bb306496dc90b9c602fd776a6c545 Author: Martin Renvoize Date: Tue Nov 3 09:47:12 2020 +0000 Bug 26938: Prevent flash of unstyled sales table On the registers page the table has come complex data structures embedded to allow for all the functionality we bring into the datatable. We should hide the table on page load and only display it at DataTables init time once the weird content has been beautified by DataTables. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Add a cash register and make some transactions against it. 3/ Navigate to the 'Register details' page 4/ Note that some 'funky' JSON strings appear in the table briefly before it is restyled when DataTables loads. 5/ Apply the patch 6/ Rebuild the CSS from the SCSS files 7/ Reload the page (hard reload to get the CSS changes) 8/ Note that the table now only appears once the nice formatting that DataTables adds is applied. Signed-off-by: David Nind Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 7 ++- Koha/Manual.pm | 1 + .../intranet-tmpl/prog/css/src/staff-global.scss | 4 ++ .../intranet-tmpl/prog/en/modules/pos/register.tt | 7 ++- .../prog/en/modules/serials/serials-collection.tt | 6 +- misc/migration_tools/remove_unused_authorities.pl | 2 +- t/db_dependent/AuthoritiesMarc.t | 68 +++++++++++++++++++++- 7 files changed, 87 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Nov 18 15:41:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 18 Nov 2020 14:41:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1892-g9f8ae9498d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9f8ae9498d45b248189c804a7c3626803abbacf3 (commit) from d4a15b27b8359a13fa80952ed7e920b7388527fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9f8ae9498d45b248189c804a7c3626803abbacf3 Author: Jonathan Druart Date: Wed Nov 18 15:09:14 2020 +0100 Bug 26939: Add missing filters Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 20 08:50:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Nov 2020 07:50:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1902-g1aeeaf4c2b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1aeeaf4c2b6f4c8f79e2472b7c66a832d0daf802 (commit) via 43b66ccfae07d8a72e7fe5433dafa69f4c870602 (commit) via 59e4b03d73cb4a103acdf25f858af4efaf6c491f (commit) via a25b651cf257f41fd0a8c601e70acad74b479724 (commit) via dff16710ae53ebfab8596f27b35a7c8e35f81edf (commit) via c056385669cefa02e2a94f96d8edea570f3c887e (commit) via f3cacc62cda58798e8f2de6cfdd636772d2158f0 (commit) via ba04deb9c36feedd1e0659d2d78b9327ce54ff4c (commit) via b4ffaeaec1fdc9ee7c33ee419139def9d62c586e (commit) via 9dcb51a8387f65fa2d9ff47afa9c7bb91be95e90 (commit) from 9f8ae9498d45b248189c804a7c3626803abbacf3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1aeeaf4c2b6f4c8f79e2472b7c66a832d0daf802 Author: Jonathan Druart Date: Thu Nov 19 17:15:32 2020 +0100 Bug 22343: (follow-up) Correctly handle password on editing Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 43b66ccfae07d8a72e7fe5433dafa69f4c870602 Author: Jonathan Druart Date: Thu Nov 19 17:25:14 2020 +0100 Bug 26938: Compiled CSS Signed-off-by: Jonathan Druart commit 59e4b03d73cb4a103acdf25f858af4efaf6c491f Author: Nick Clemens Date: Tue Nov 17 12:11:21 2020 +0000 Bug 26984: (follow-up) Don't delete patrons and checkouts in Objects.t Rather than counting all and assuriing we get 10, we can count all, add 10, and ensure the numbers still match Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit a25b651cf257f41fd0a8c601e70acad74b479724 Author: Jonathan Druart Date: Thu Nov 12 13:11:13 2020 +0100 Bug 26984: Make tests pass if AnonymousPatron is set There is only 1 place where it can be tricky to not remove them as we want exactly 10 patrons to be present in the DB Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit dff16710ae53ebfab8596f27b35a7c8e35f81edf Author: Frédéric Demians Date: Tue Nov 10 17:00:09 2020 +0100 Bug 26992: Fix serial issue and related items deletion on serial collection page serial-collection.pl uses C4::Items::DelItemCheck() function which is obsolete. Test plan: 1. Create a subscription with items created when receiving. 2. Receive several issues, and create corresponding items. 3. On Serial collection page (serial-collection.pl), select several issues. 4. Click on button Delete selected issues 5. A confirmation page is displayed. Enable "Delete associated items?". Then click on "Yes, delete" button. You get this error: Undefined subroutine &C4::Items::DelItemCheck 6. Apply the patch an repeat steps 3-5. Check that issues and related items are deleted. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit c056385669cefa02e2a94f96d8edea570f3c887e Author: Jonathan Druart Date: Thu Nov 19 11:13:34 2020 +0100 Bug 26854: Remove log of STDERR See discussion on comments 12-20 Signed-off-by: Jonathan Druart commit f3cacc62cda58798e8f2de6cfdd636772d2158f0 Author: David Cook Date: Thu Oct 29 04:24:31 2020 +0000 Bug 26854: Close STDERR when forking stage-marc-import.pl We need to close STDERR when forking stage-marc-import.pl, or else the CGI session with Apache httpd does not properly finish. This leads to unexpected behaviour across different httpd versions, operating systems, etc. This patch closes the STDERR file handle when forking a child process to do MARC imports, and it re-opens STDERR to a log file in the logdir directory to catch any import errors. Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 3. Upload a MARC file with a large number of records (e.g. 30,000 records) 4. Open F12 dev tools 5. Click on "Network" tab 6. Clear all existing network logs 7. Click "Stage for import" 8. After ~30 seconds, the request to stage-marc-import.pl should return a 200 code 9. Immediately, calls to background-job-progress.pl should start, and the "Job progress" bar should update at a maximum rate of every .5 seconds (or more realistically 1-2 seconds) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit ba04deb9c36feedd1e0659d2d78b9327ce54ff4c Author: Jonathan Druart Date: Thu Nov 19 14:24:59 2020 +0100 Bug 26031: Remove the failing tests and the diag Signed-off-by: Jonathan Druart commit b4ffaeaec1fdc9ee7c33ee419139def9d62c586e Author: Mason James Date: Fri Nov 20 02:10:28 2020 +1300 Bug 26031: Remove 4 failing tests from t/db_dependent/www/search_utf8.t to test... 1/ apply patch 2/ run test 3/ observe PASS root at kohadevbox:/kohadevbox/koha# export KOHA_INTRANET_URL="http://kohadev-intra.myDNSname.org:8081" root at kohadevbox:/kohadevbox/koha# export KOHA_OPAC_URL="http://kohadev.myDNSname.org:8080" root at kohadevbox:/kohadevbox/koha# prove -v ./t/db_dependent/www/search_utf8.t 1..87 ok 1 - connect to intranet ok 2 - login to staff interface ok 3 - load main page ok 4 - open tools module ok 5 - go to stage MARC ok 6 - uploaded file ok 7 - upload succeeded ok 8 - reopen stage MARC page ok 9 - stage MARC ok 10 - have job ID ok 11 - job was completed ok 12 - reopen stage MARC page at end of upload ok 13 - stage MARC ok 14 - view batch ok 15 - imported records into catalog ok 16 - got search on intranet ok 17 - got search on intranet ok 18 - Base is like "(?^u:search.pl\?advsearch=1&idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)" ok 19 - UTF-8 are multi-byte. Good ok 20 - UTF-8 chars are correctly present. Good ok 21 - got opac ok 22 - got opac ok 23 - Base is like "(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)" ok 24 - Base does not contain an idx ok 25 - UTF-8 are multi-byte. Good ok 26 - UTF-8 chars are correctly present. Good ok 27 - view and clean batch ok 28 - biblio on intranet ok 29 - biblio deleted ok 30 - connect to intranet ok 31 - login to staff interface ok 32 - load main page ok 33 - open tools module ok 34 - go to stage MARC ok 35 - uploaded file ok 36 - upload succeeded ok 37 - reopen stage MARC page ok 38 - stage MARC ok 39 - have job ID ok 40 - job was completed ok 41 - reopen stage MARC page at end of upload ok 42 - stage MARC ok 43 - view batch ok 44 - imported records into catalog ok 45 - got search on intranet ok 46 - got search on intranet ok 47 - Base is like "(?^u:search.pl\?advsearch=1&idx=kw&q=Ram%C3%B2n)" ok 48 - UTF-8 are multi-byte. Good ok 49 - UTF-8 chars are correctly present. Good ok 50 - got opac ok 51 - got opac ok 52 - Base is like "(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)" ok 53 - Base does not contain an idx ok 54 - UTF-8 are multi-byte. Good ok 55 - UTF-8 chars are correctly present. Good ok 56 - view and clean batch ok 57 - biblio on intranet ok 58 - biblio deleted ok 59 - connect to intranet ok 60 - login to staff interface ok 61 - load main page ok 62 - open tools module ok 63 - go to stage MARC ok 64 - uploaded file ok 65 - upload succeeded ok 66 - reopen stage MARC page ok 67 - stage MARC ok 68 - have job ID ok 69 - job was completed ok 70 - reopen stage MARC page at end of upload ok 71 - stage MARC ok 72 - view batch ok 73 - imported records into catalog ok 74 - got search on intranet ok 75 - got search on intranet ok 76 - Base is like "(?^u:search.pl\?advsearch=1&idx=kw&q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)" ok 77 - UTF-8 are multi-byte. Good ok 78 - UTF-8 chars are correctly present. Good ok 79 - got opac ok 80 - got opac ok 81 - Base is like "(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)" ok 82 - Base does not contain an idx ok 83 - UTF-8 are multi-byte. Good ok 84 - UTF-8 chars are correctly present. Good ok 85 - view and clean batch ok 86 - biblio on intranet ok 87 - biblio deleted ok All tests successful. Files=1, Tests=87, 127 wallclock secs ( 0.06 usr 0.02 sys + 3.00 cusr 0.99 csys = 4.07 CPU) Result: PASS real 2m6.709s user 0m3.124s sys 0m1.032s Signed-off-by: Jonathan Druart commit 9dcb51a8387f65fa2d9ff47afa9c7bb91be95e90 Author: Nick Clemens Date: Thu Nov 19 13:58:07 2020 +0000 Bug 24083: (follow-up) Assign renewals remaining string to content Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: admin/smtp_servers.pl | 7 ++---- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +- serials/serials-collection.pl | 14 +++++++----- t/db_dependent/Accounts.t | 26 ++++------------------- t/db_dependent/Koha/Biblio.t | 20 ++++++++--------- t/db_dependent/Koha/Objects.t | 9 ++++---- t/db_dependent/Template/Plugin/Categories.t | 14 ++++-------- t/db_dependent/www/search_utf8.t | 13 +----------- tools/stage-marc-import.pl | 6 +++--- 10 files changed, 38 insertions(+), 75 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 20 11:09:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Nov 2020 10:09:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1905-g926ad3c1a6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 926ad3c1a69074b2905d9ef03e639db6ba8d6865 (commit) via 05085ddc61332bfb82401a7d5b8d5b0fa24cdea6 (commit) via 3376a9440050d795ce0738e20b0616b782143f4b (commit) from 1aeeaf4c2b6f4c8f79e2472b7c66a832d0daf802 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 926ad3c1a69074b2905d9ef03e639db6ba8d6865 Author: Jonathan Druart Date: Tue Nov 10 11:56:31 2020 +0100 Bug 25514: Try to fix random failure from REST/Plugin/Objects.t It's causing a "Premature connection close" error https://docs.mojolicious.org/Mojolicious/Guides/FAQ#What-does-Premature-connection-close-mean This is just a guess but maybe it would help to have the Test::Mojo object initiated just before the get? Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart commit 05085ddc61332bfb82401a7d5b8d5b0fa24cdea6 Author: Jonathan Druart Date: Fri Nov 20 10:31:33 2020 +0100 Bug 27062: Fix pickup_location tests when existing libraries exist If there are existing libraries in the DB, the tests will fail. There were several changes related to those tests recently, this bug report is a follow-up for them. bug 26984, bug 27002 and bug 26963. Signed-off-by: Jonathan Druart commit 3376a9440050d795ce0738e20b0616b782143f4b Author: Jonathan Druart Date: Fri Nov 13 09:32:50 2020 +0100 Bug 27007: Don't call GetMarcSubfieldStructure with unsafe in tests It does not feel correct to call GetMarcSubfieldStructure with the unsafe flag set in tests: my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } ); Some tests are failing is run twice Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. [x~10] Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. # Failed test 'Value is mapped correctly for column biblionumber' # at t/db_dependent/Koha/Item.t line 115. # got: undef # expected: '483' [etc.] Test plan: Run the tests twice, without the patch it fails, with the patch it passes Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Biblio.t | 17 +++---- t/db_dependent/Koha/Item.t | 77 +++++++++++++++++++------------ t/db_dependent/Koha/REST/Plugin/Objects.t | 12 ++++- 3 files changed, 63 insertions(+), 43 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 20 16:16:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Nov 2020 15:16:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1913-g9d8523ed2b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9d8523ed2b88c8fbf18fc61835967ff555a5dc55 (commit) via a9e3db201e1863b30ac0e2654d82a15f0f8e44c0 (commit) via 279ce72e4ced3ca191a8ee4e109c28df169dfc20 (commit) via 6267eb7cba91ad8177cc60c4c7cba0b26b473cee (commit) via 181125242c33d439fb6bdbddccb6a86a03fa8c15 (commit) via 36a6ce301f961b0cefdca70ed9a903a1216e071f (commit) via a508d3fcbec2c1d64b94fe66b288b28cc6998e37 (commit) via cc970464ec7c881aaa9d8a33931a29a5951e6103 (commit) from 926ad3c1a69074b2905d9ef03e639db6ba8d6865 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d8523ed2b88c8fbf18fc61835967ff555a5dc55 Author: Tomas Cohen Arazi Date: Fri Nov 20 11:04:04 2020 -0300 Bug 26922: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit a9e3db201e1863b30ac0e2654d82a15f0f8e44c0 Author: Tomas Cohen Arazi Date: Thu Nov 19 13:09:47 2020 -0300 Bug 26922: Better error handling in SendAlerts This patch makes SendAlerts display a better error message when sending fails. To test: 1. Set KohaAdminEmailAddress to admin at example.org 2. Edit a vendor, set a valid email address 3. Create a new basket, a new order. Send the basket => FAIL: As you did not configure a valid SMTP server, the email is not sent and logs displayed "unable to establish SMTP connection to (localhost) port 25", with the stracktrace. 4. Apply this patch and reload all 5. Repeat 3 => SUCCESS: A simpler message is displayed, the stacktrace remains in the logs 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 279ce72e4ced3ca191a8ee4e109c28df169dfc20 Author: Jonathan Druart Date: Thu Nov 19 15:16:36 2020 +0100 Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records contain itemnumber Prior to ug 23463 AddItemFromMarc where calling AddItem, that did not take into account the itemnumber field. Now that we are using Koha::Item, we need to remove the items.itemnumber field from the MARC record Test plan: 1 - find an existing bib in your system with just one item 2 - export that bib with the item attached 3 - delete the barcode from your item in Koha 4 - stage your exported marc file for reimport, match on biblionumber, set it to Always Add Items 5 - confirm that the bib matches and the incoming 952 is parsed 6 - click "Import this batch into the catalog" => Without this patch you get (in the logs, or hidden) manage-marc-import.pl: DBD::mysql::st execute failed: Duplicate entry '23' for key 'PRIMARY' [for Statement "INSERT INTO `items` ( `barcode`, `biblioitemnumber`, `biblionumber`, `ccode`, `cn_sort`, `cn_source`, `damaged_on`, `dateaccessioned`, `datelastborrowed`, `datelastseen`, `holdingbranch`, `homebranch`, `itemcallnumber`, `itemlost_on`, `itemnumber`, `itype`, `location`, `more_subfields_xml`, `onloan`, `permanent_location`, `replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues: 0="BC_23", 1=8, 2=8, 3="REF", 4='CN__23', 5=undef, 6=undef, 7="2014-09-04", 8=undef, 9="2014-09-04", 10="FPL", 11="FPL", 12="CN_23", 13=undef, 14="23", 15="BK", 16="GEN", 17=undef, 18=undef, 19="GEN", 20="2014-09-04", 21=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. manage-marc-import.pl: DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '23' for key 'PRIMARY' at /kohadevbox/koha/Koha/Object.pm line 169 manage-marc-import.pl: {UNKNOWN}: Transaction aborted: Duplicate ID. Rollback failed: DBIx::Class::Storage::txn_rollback(): Refusing to roll back without a started transaction at /kohadevbox/koha/tools/manage-marc-import.pl line 253 at /kohadevbox/koha/tools/manage-marc-import.pl line 253 => With this patch applied, the new item must be added to the existing bibliographic record Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 6267eb7cba91ad8177cc60c4c7cba0b26b473cee Author: Fridolin Somers Date: Wed Sep 30 14:54:57 2020 +0200 Bug 25548: (follow-up) Remove those rewrite redirects in koha-httpd.conf In etc/koha-httpd.conf for dev install, those rewrite redirects are already commented. Just remove them. Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 181125242c33d439fb6bdbddccb6a86a03fa8c15 Author: David Cook Date: Wed May 20 15:08:05 2020 +1000 Bug 25548: Remove Apache rewrite directives that trigger redirects Historically, we have used Apache rewrite directives to strip query parameters with no arguments from the query string (e.g. PARAM=&), and then redirect to the new URL. However, this slows down user activity, and depending on your HTTPS and proxy setup can cause suboptimal HTTP downgrades and upgrades. Test Plan: 0) Apply patch 1) Build Debian package 2) Install Debian package and reload Apache 3) Open developer tools on your favourite browser 4) Go to Network tab in developer tools 5) Go to /cgi-bin/koha/opac-main.pl 6) Search for "test" 7) Note a 200 status for "opac-search.pl?idx=&q=test" If you got a 302 status for "opac-search.pl?idx=&q=test" followed by a 200 status for "opac-search.pl?q=test", you will know that your Apache configuration wasn't updated. Signed-off-by: Fridolin Somers Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 36a6ce301f961b0cefdca70ed9a903a1216e071f Author: Nick Clemens Date: Wed Nov 18 13:15:04 2020 +0000 Bug 7607: (follow-up) Address OPAC and limits This patch adds the same function to the OPAC and adds support for limits I adjust the class on staff side to match the one already existing on OPAC On the OPAC when you click the back button the fields are not enabled - on the staff side they are, I leave this problem for someone else to solve Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit a508d3fcbec2c1d64b94fe66b288b28cc6998e37 Author: Nick Clemens Date: Thu Nov 5 19:00:32 2020 +0000 Bug 7607: (follow-up) Disable rather than remove inputs Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit cc970464ec7c881aaa9d8a33931a29a5951e6103 Author: Nick Clemens Date: Tue Nov 3 11:19:23 2020 +0000 Bug 7607: Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind Signed-off-by: David Cook Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 4 ++ C4/Letters.pm | 33 ++++++++-- debian/templates/apache-shared-intranet.conf | 2 - debian/templates/apache-shared-opac.conf | 2 - etc/koha-httpd.conf | 6 -- .../prog/en/modules/catalogue/advsearch.tt | 6 +- koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 17 +++++ .../bootstrap/en/modules/opac-advsearch.tt | 12 ++++ t/db_dependent/Letters.t | 73 ++++++++++++++++++---- 9 files changed, 127 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 20 21:39:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Nov 2020 20:39:50 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-109-gb0eeddf4bc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b0eeddf4bc159e0a638f9e79acf21e98d6230048 (commit) from 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b0eeddf4bc159e0a638f9e79acf21e98d6230048 Author: Jonathan Druart Date: Thu Nov 19 15:16:36 2020 +0100 Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records contain itemnumber Prior to ug 23463 AddItemFromMarc where calling AddItem, that did not take into account the itemnumber field. Now that we are using Koha::Item, we need to remove the items.itemnumber field from the MARC record Test plan: 1 - find an existing bib in your system with just one item 2 - export that bib with the item attached 3 - delete the barcode from your item in Koha 4 - stage your exported marc file for reimport, match on biblionumber, set it to Always Add Items 5 - confirm that the bib matches and the incoming 952 is parsed 6 - click "Import this batch into the catalog" => Without this patch you get (in the logs, or hidden) manage-marc-import.pl: DBD::mysql::st execute failed: Duplicate entry '23' for key 'PRIMARY' [for Statement "INSERT INTO `items` ( `barcode`, `biblioitemnumber`, `biblionumber`, `ccode`, `cn_sort`, `cn_source`, `damaged_on`, `dateaccessioned`, `datelastborrowed`, `datelastseen`, `holdingbranch`, `homebranch`, `itemcallnumber`, `itemlost_on`, `itemnumber`, `itype`, `location`, `more_subfields_xml`, `onloan`, `permanent_location`, `replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues: 0="BC_23", 1=8, 2=8, 3="REF", 4='CN__23', 5=undef, 6=undef, 7="2014-09-04", 8=undef, 9="2014-09-04", 10="FPL", 11="FPL", 12="CN_23", 13=undef, 14="23", 15="BK", 16="GEN", 17=undef, 18=undef, 19="GEN", 20="2014-09-04", 21=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. manage-marc-import.pl: DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '23' for key 'PRIMARY' at /kohadevbox/koha/Koha/Object.pm line 169 manage-marc-import.pl: {UNKNOWN}: Transaction aborted: Duplicate ID. Rollback failed: DBIx::Class::Storage::txn_rollback(): Refusing to roll back without a started transaction at /kohadevbox/koha/tools/manage-marc-import.pl line 253 at /kohadevbox/koha/tools/manage-marc-import.pl line 253 => With this patch applied, the new item must be added to the existing bibliographic record Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 20 21:47:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Nov 2020 20:47:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-110-g4c10f83dc0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 (commit) from b0eeddf4bc159e0a638f9e79acf21e98d6230048 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 Author: Nick Clemens Date: Fri Sep 4 12:47:58 2020 +0000 Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve For cron purposes this is the correct behaviour. For display purposes we wish to see on_reserve over too_soon This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses To test: 1 - set NoRenewalBeforePrecision to date only 2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days 3 - check item out 4 - confirm item shows Scheduled For Automatic Renewal in issues table 5 - place a hold on the item for another patron 6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold" 7 - change No Renewal Before value to 7 8 - reload issues table for patron 1, confirm checkout now shows "on hold" 9 - Apply patch 10 - restart_all 11 - Reload the issues table - confirm 'on_hold' still shows 12 - Change No Renewal Before to 0 13 - Refresh issues table, still shows 'On hold' 14 - perl misc/cronjobs/automatic_renewals.pl -v 15 - Result shows 'auto_too_soon' 16 - prove -v t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ff08e99965ccb60092b5bdd5181fd517e1fab161) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 26 ++++++++++++++++---------- misc/cronjobs/automatic_renewals.pl | 2 +- t/db_dependent/Circulation.t | 10 ++++++++-- 3 files changed, 25 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 23 18:26:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 23 Nov 2020 17:26:49 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.05.17 created. v19.05.17 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.05.17 has been created at 5c1a54bc0741f88bb02b905f7482382bddd6947d (tag) tagging cd251c73174f269a9da3ba4bc119f94dcf98c566 (commit) replaces v19.05.16 tagged by Victor Grousset/tuxayo on Mon Nov 23 16:36:12 2020 +0100 - Log ----------------------------------------------------------------- Koha release 19.05.17 -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRT86JTIbcYFBCjtfABQKyjt9hwuwUCX7vW7QAKCRABQKyjt9hw uwACAP0YzkOn+Xi/vHON4paqG+gy6/09anvGmFU0F+TWVCzirQD9EQoTwMEp7Y3R B5BC0w4NGAgJAYuZ3NZfzOjPqE0RLQ0= =10nS -----END PGP SIGNATURE----- Agustín Moyano (1): Bug 18050: (follow-up) Force adding FK constraint Aleisha Amohia (2): Bug 26569: DBRev 19.05.16.001 Bug 18050: DBRev 19.05.16.002 Alex Buckley (1): Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Andrew Fuerste-Henry (1): Bug 26569: Use gender neutral pronouns in system prefernece explanations David Cook (1): Bug 26496: Add op field to Budget Planning Fridolin Somers (1): Bug 26904: OPAC password recovery allows regexp in email John Fawcett (2): Bug 26612: Error during web install for it-IT translation Bug 26613: Fix it-IT unimarc_framework.sql installer file Jonathan Druart (2): Bug 26260: Add missing elastic>cnx_pool to koha-conf-site.xml.in Bug 26639: Add auto_savepoint to DBIC connection Katrin Fischer (4): Bug 24780: Make items.stocknumber show up in batch item modification Bug 18050: Add FK constraint on aqbudgets.budget_period_id Bug 18050: Add relation alias to schema Bug 18050: (QA follow-up) Adjust conditions and make use of message text Koha translators (1): Translation updates for Koha 19.05.17 Kyle M Hall (1): Bug 26604: "Generate next" button gives error on serials-collection.pl Mark Hofstetter (1): Bug 26601: Add utf8 encoding to text output of overdue_notices.pl Martin Renvoize (2): Bug 25665: (Bug 23382: (RM follow-up) Revert "hours_between should match...") Bug 25665: (Bug 23382: (RM follow-up) Ensure tests pass on Wednesdays) Mason James (1): Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error Nick Clemens (2): Bug 26224: Prevent double submit of header check in form Bug 18051: Set UTF8 Flag for record searches/imports from rancor Phil Ringnalda (1): Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record Victor Grousset (4): Bug 18050: DBIC Fix translations for Koha 19.05.17 Increment version for 19.05.17 release Update release notes for 19.05.17 release ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 23 18:26:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 23 Nov 2020 17:26:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.17 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via cd251c73174f269a9da3ba4bc119f94dcf98c566 (commit) via a8a868935f63063e71a77f56b0f1fe0fba472691 (commit) via c3e648207c82784dc3d469cae035a199ebf94a0c (commit) via c016454fa6aefdce4e70ce5d76542173395409e4 (commit) via e9b9e1510641c8385d2a7b8d53fc799f9224464e (commit) from a5c2090ff5853f839a8021d52494cfcba9a2c1be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cd251c73174f269a9da3ba4bc119f94dcf98c566 Author: Victor Grousset/tuxayo Date: Mon Nov 23 16:22:33 2020 +0100 Update release notes for 19.05.17 release Signed-off-by: Victor Grousset/tuxayo commit a8a868935f63063e71a77f56b0f1fe0fba472691 Author: Victor Grousset/tuxayo Date: Mon Nov 23 15:14:12 2020 +0100 Increment version for 19.05.17 release Signed-off-by: Victor Grousset/tuxayo commit c3e648207c82784dc3d469cae035a199ebf94a0c Author: Victor Grousset/tuxayo Date: Mon Nov 23 15:06:58 2020 +0100 Fix translations for Koha 19.05.17 Signed-off-by: Victor Grousset/tuxayo commit c016454fa6aefdce4e70ce5d76542173395409e4 Author: Koha translators <> Date: Mon Nov 23 10:23:10 2020 -0300 Translation updates for Koha 19.05.17 Signed-off-by: Victor Grousset/tuxayo commit e9b9e1510641c8385d2a7b8d53fc799f9224464e Author: Fridolin Somers Date: Tue Nov 3 09:19:34 2020 +0100 Bug 26904: OPAC password recovery allows regexp in email When using OPAC password recovery form, opac/opac-password-recovery.pl : if one provides correct login and an email, there is a check that this email is one of patron's. This check uses RegExp with case insensitive : if ( $email && !( any { /^$email$/i } @emails ) ) This is a security issue since one can simply enter '.*'. Severity is normal because the login must be a correct. I propose to use simple string compare with lowercase to be case insensitive. Test plan : 1) Don't apply patch 2) Enable system preference 'OpacResetPassword' 3) Go to 'OPAC > Log in to your account > Forgot your password?' 4) Enter an existing userid or cardnumber and '.*' in 'Email' 5) The password recovery is created ! (check table 'borrower_password_recovery') 6) Apply patch 7) Enter an existing userid or cardnumber and '.*' in 'Email' 8) You get the message 'No account was found with the provided information.' 9) Enter an existing userid or cardnumber and in 'Email' the corresponding email but with different case 10) The password recovery is created (check table 'borrower_password_recovery') Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Backport to 19.05.x: Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 7 + ...s_19_05_16.html => release_notes_19_05_17.html} | 164 +++++++++++++-------- ...notes_19_05_16.md => release_notes_19_05_17.md} | 153 +++++++++++-------- misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 40 ++--- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 40 ++--- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 40 ++--- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 40 ++--- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 40 ++--- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 40 ++--- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 40 ++--- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 40 ++--- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 6 +- misc/translator/po/cs-CZ-pref.po | 8 +- misc/translator/po/cs-CZ-staff-prog.po | 60 ++++---- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 40 ++--- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 40 ++--- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 40 ++--- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 2 +- misc/translator/po/de-DE-staff-prog.po | 48 +++--- misc/translator/po/dz-marc-MARC21.po | 2 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 2 +- misc/translator/po/dz-staff-prog.po | 40 ++--- misc/translator/po/el-GR-marc-MARC21.po | 9 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 10 +- misc/translator/po/el-GR-pref.po | 6 +- misc/translator/po/el-GR-staff-prog.po | 48 +++--- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 12 +- misc/translator/po/en-GB-staff-prog.po | 40 ++--- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 40 ++--- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 131 ++++++++-------- misc/translator/po/eo-staff-prog.po | 40 ++--- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 12 +- misc/translator/po/es-ES-staff-prog.po | 52 +++---- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-staff-prog.po | 40 ++--- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 52 +++---- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 40 ++--- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 40 ++--- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 10 +- misc/translator/po/fr-CA-staff-prog.po | 40 ++--- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 48 +++--- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 2 +- misc/translator/po/ga-staff-prog.po | 40 ++--- misc/translator/po/gd-marc-MARC21.po | 2 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 2 +- misc/translator/po/gd-staff-prog.po | 40 ++--- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-staff-prog.po | 40 ++--- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 40 ++--- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-staff-prog.po | 40 ++--- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 40 ++--- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 40 ++--- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 2 +- misc/translator/po/hy-Armn-pref.po | 12 +- misc/translator/po/hy-Armn-staff-prog.po | 40 ++--- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-staff-prog.po | 40 ++--- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 40 ++--- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 40 ++--- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 40 ++--- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 2 +- misc/translator/po/it-IT-pref.po | 24 +-- misc/translator/po/it-IT-staff-prog.po | 60 ++++---- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 40 ++--- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 40 ++--- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 16 +- misc/translator/po/ka-staff-prog.po | 40 ++--- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 40 ++--- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 40 ++--- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 40 ++--- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 40 ++--- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 40 ++--- misc/translator/po/lv-marc-MARC21.po | 2 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 2 +- misc/translator/po/lv-staff-prog.po | 40 ++--- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 40 ++--- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-staff-prog.po | 40 ++--- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-staff-prog.po | 40 ++--- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-staff-prog.po | 40 ++--- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 40 ++--- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-staff-prog.po | 40 ++--- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 40 ++--- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 40 ++--- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 48 +++--- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 17 +-- misc/translator/po/nl-NL-staff-prog.po | 58 ++++---- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 40 ++--- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 2 +- misc/translator/po/oc-staff-prog.po | 40 ++--- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-staff-prog.po | 40 ++--- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 40 ++--- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-staff-prog.po | 40 ++--- misc/translator/po/pt-BR-marc-MARC21.po | 12 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 54 +++---- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 40 ++--- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 40 ++--- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-pref.po | 6 +- misc/translator/po/ru-RU-staff-prog.po | 40 ++--- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 40 ++--- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 40 ++--- misc/translator/po/sk-SK-marc-MARC21.po | 14 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 10 +- misc/translator/po/sk-SK-opac-bootstrap.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 53 +++---- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 40 ++--- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 40 ++--- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 40 ++--- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 40 ++--- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 40 ++--- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 40 ++--- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-staff-prog.po | 40 ++--- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-staff-prog.po | 40 ++--- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 40 ++--- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 40 ++--- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 2 +- misc/translator/po/tr-TR-pref.po | 11 +- misc/translator/po/tr-TR-staff-prog.po | 40 ++--- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 2 +- misc/translator/po/tvl-staff-prog.po | 40 ++--- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 6 +- misc/translator/po/uk-UA-staff-prog.po | 44 +++--- misc/translator/po/ur-Arab-marc-MARC21.po | 12 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 44 +++--- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 40 ++--- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 40 ++--- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 40 ++--- opac/opac-password-recovery.pl | 2 +- 441 files changed, 2495 insertions(+), 2426 deletions(-) copy misc/release_notes/{release_notes_19_05_16.html => release_notes_19_05_17.html} (59%) copy misc/release_notes/{release_notes_19_05_16.md => release_notes_19_05_17.md} (52%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 00:40:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 23 Nov 2020 23:40:50 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-111-g57a9bf3ef2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 57a9bf3ef2e4f25227a10f16cec7fb34e162199e (commit) from 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 57a9bf3ef2e4f25227a10f16cec7fb34e162199e Author: Fridolin Somers Date: Tue Nov 3 09:19:34 2020 +0100 Bug 26904: OPAC password recovery allows regexp in email When using OPAC password recovery form, opac/opac-password-recovery.pl : if one provides correct login and an email, there is a check that this email is one of patron's. This check uses RegExp with case insensitive : if ( $email && !( any { /^$email$/i } @emails ) ) This is a security issue since one can simply enter '.*'. Severity is normal because the login must be a correct. I propose to use simple string compare with lowercase to be case insensitive. Test plan : 1) Don't apply patch 2) Enable system preference 'OpacResetPassword' 3) Go to 'OPAC > Log in to your account > Forgot your password?' 4) Enter an existing userid or cardnumber and '.*' in 'Email' 5) The password recovery is created ! (check table 'borrower_password_recovery') 6) Apply patch 7) Enter an existing userid or cardnumber and '.*' in 'Email' 8) You get the message 'No account was found with the provided information.' 9) Enter an existing userid or cardnumber and in 'Email' the corresponding email but with different case 10) The password recovery is created (check table 'borrower_password_recovery') Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 904e926ba0f407b24aa3d94be5afe37b5e3ec075) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: opac/opac-password-recovery.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 00:57:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 23 Nov 2020 23:57:37 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-113-g604b0c5b75 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 604b0c5b75a78196f394298781fb881204da25a5 (commit) via 63191a724e6970f3a683f29d56f32442bd59a908 (commit) from 57a9bf3ef2e4f25227a10f16cec7fb34e162199e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 604b0c5b75a78196f394298781fb881204da25a5 Author: Lucas Gass Date: Mon Nov 23 23:24:28 2020 +0000 Increment version for 20.05.06 release Signed-off-by: Lucas Gass commit 63191a724e6970f3a683f29d56f32442bd59a908 Author: Koha translators <> Date: Mon Nov 23 20:13:16 2020 -0300 Translation updates for Koha 20.05.06 Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 4 +- misc/translator/po/am-Ethi-messages-js.po | 8 +- misc/translator/po/am-Ethi-messages.po | 7 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 449 +- misc/translator/po/am-Ethi-pref.po | 12 +- misc/translator/po/am-Ethi-staff-prog.po | 972 ++-- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 14 +- misc/translator/po/ar-Arab-messages-js.po | 30 +- misc/translator/po/ar-Arab-messages.po | 11 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 451 +- misc/translator/po/ar-Arab-pref.po | 28 +- misc/translator/po/ar-Arab-staff-prog.po | 998 ++-- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 4 +- misc/translator/po/as-IN-messages-js.po | 8 +- misc/translator/po/as-IN-messages.po | 7 +- misc/translator/po/as-IN-opac-bootstrap.po | 449 +- misc/translator/po/as-IN-pref.po | 12 +- misc/translator/po/as-IN-staff-prog.po | 972 ++-- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 8 +- misc/translator/po/az-AZ-messages-js.po | 8 +- misc/translator/po/az-AZ-messages.po | 7 +- misc/translator/po/az-AZ-opac-bootstrap.po | 449 +- misc/translator/po/az-AZ-pref.po | 12 +- misc/translator/po/az-AZ-staff-prog.po | 972 ++-- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 6 +- misc/translator/po/be-BY-messages-js.po | 8 +- misc/translator/po/be-BY-messages.po | 7 +- misc/translator/po/be-BY-opac-bootstrap.po | 449 +- misc/translator/po/be-BY-pref.po | 12 +- misc/translator/po/be-BY-staff-prog.po | 972 ++-- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 4 +- misc/translator/po/bg-Cyrl-messages-js.po | 8 +- misc/translator/po/bg-Cyrl-messages.po | 7 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 449 +- misc/translator/po/bg-Cyrl-pref.po | 12 +- misc/translator/po/bg-Cyrl-staff-prog.po | 972 ++-- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 4 +- misc/translator/po/bn-IN-messages-js.po | 31 +- misc/translator/po/bn-IN-messages.po | 64 +- misc/translator/po/bn-IN-opac-bootstrap.po | 478 +- misc/translator/po/bn-IN-pref.po | 12 +- misc/translator/po/bn-IN-staff-prog.po | 996 ++-- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 4 +- misc/translator/po/ca-ES-messages-js.po | 8 +- misc/translator/po/ca-ES-messages.po | 7 +- misc/translator/po/ca-ES-opac-bootstrap.po | 450 +- misc/translator/po/ca-ES-pref.po | 12 +- misc/translator/po/ca-ES-staff-prog.po | 990 ++-- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 6 +- misc/translator/po/cs-CZ-messages-js.po | 34 +- misc/translator/po/cs-CZ-messages.po | 7 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 451 +- misc/translator/po/cs-CZ-pref.po | 14 +- misc/translator/po/cs-CZ-staff-prog.po | 1000 ++-- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 8 +- misc/translator/po/cy-GB-messages-js.po | 8 +- misc/translator/po/cy-GB-messages.po | 14 +- misc/translator/po/cy-GB-opac-bootstrap.po | 449 +- misc/translator/po/cy-GB-pref.po | 12 +- misc/translator/po/cy-GB-staff-prog.po | 972 ++-- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 6 +- misc/translator/po/da-DK-messages-js.po | 8 +- misc/translator/po/da-DK-messages.po | 7 +- misc/translator/po/da-DK-opac-bootstrap.po | 449 +- misc/translator/po/da-DK-pref.po | 12 +- misc/translator/po/da-DK-staff-prog.po | 976 ++-- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 6 +- misc/translator/po/de-CH-messages-js.po | 8 +- misc/translator/po/de-CH-messages.po | 7 +- misc/translator/po/de-CH-opac-bootstrap.po | 453 +- misc/translator/po/de-CH-pref.po | 14 +- misc/translator/po/de-CH-staff-prog.po | 979 ++-- misc/translator/po/de-DE-installer.po | 355 +- misc/translator/po/de-DE-marc-MARC21.po | 10 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 10 +- misc/translator/po/de-DE-messages-js.po | 8 +- misc/translator/po/de-DE-messages.po | 11 +- misc/translator/po/de-DE-opac-bootstrap.po | 479 +- misc/translator/po/de-DE-pref.po | 57 +- misc/translator/po/de-DE-staff-prog.po | 1001 ++-- misc/translator/po/dz-marc-MARC21.po | 2 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 4 +- misc/translator/po/dz-messages-js.po | 8 +- misc/translator/po/dz-messages.po | 7 +- misc/translator/po/dz-opac-bootstrap.po | 449 +- misc/translator/po/dz-pref.po | 12 +- misc/translator/po/dz-staff-prog.po | 972 ++-- misc/translator/po/el-GR-marc-MARC21.po | 10 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 6 +- misc/translator/po/el-GR-messages-js.po | 14 +- misc/translator/po/el-GR-messages.po | 16 +- misc/translator/po/el-GR-opac-bootstrap.po | 464 +- misc/translator/po/el-GR-pref.po | 18 +- misc/translator/po/el-GR-staff-prog.po | 1031 ++-- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 6 +- misc/translator/po/en-GB-messages-js.po | 8 +- misc/translator/po/en-GB-messages.po | 7 +- misc/translator/po/en-GB-opac-bootstrap.po | 459 +- misc/translator/po/en-GB-pref.po | 16 +- misc/translator/po/en-GB-staff-prog.po | 980 ++-- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 6 +- misc/translator/po/en-NZ-messages-js.po | 8 +- misc/translator/po/en-NZ-messages.po | 7 +- misc/translator/po/en-NZ-opac-bootstrap.po | 452 +- misc/translator/po/en-NZ-pref.po | 14 +- misc/translator/po/en-NZ-staff-prog.po | 978 ++-- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 4 +- misc/translator/po/eo-messages-js.po | 8 +- misc/translator/po/eo-messages.po | 7 +- misc/translator/po/eo-opac-bootstrap.po | 472 +- misc/translator/po/eo-pref.po | 12 +- misc/translator/po/eo-staff-prog.po | 972 ++-- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 18 +- misc/translator/po/es-ES-messages-js.po | 360 +- misc/translator/po/es-ES-messages.po | 13 +- misc/translator/po/es-ES-opac-bootstrap.po | 461 +- misc/translator/po/es-ES-pref.po | 59 +- misc/translator/po/es-ES-staff-prog.po | 1028 ++-- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 6 +- misc/translator/po/eu-messages-js.po | 8 +- misc/translator/po/eu-messages.po | 7 +- misc/translator/po/eu-opac-bootstrap.po | 451 +- misc/translator/po/eu-pref.po | 14 +- misc/translator/po/eu-staff-prog.po | 974 ++-- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 6 +- misc/translator/po/fa-Arab-messages-js.po | 8 +- misc/translator/po/fa-Arab-messages.po | 7 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 449 +- misc/translator/po/fa-Arab-pref.po | 12 +- misc/translator/po/fa-Arab-staff-prog.po | 988 ++-- misc/translator/po/fi-FI-marc-MARC21.po | 1175 +++-- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 6 +- misc/translator/po/fi-FI-messages-js.po | 8 +- misc/translator/po/fi-FI-messages.po | 7 +- misc/translator/po/fi-FI-opac-bootstrap.po | 453 +- misc/translator/po/fi-FI-pref.po | 14 +- misc/translator/po/fi-FI-staff-prog.po | 1153 ++--- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 6 +- misc/translator/po/fo-FO-messages-js.po | 8 +- misc/translator/po/fo-FO-messages.po | 7 +- misc/translator/po/fo-FO-opac-bootstrap.po | 449 +- misc/translator/po/fo-FO-pref.po | 12 +- misc/translator/po/fo-FO-staff-prog.po | 972 ++-- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 16 +- misc/translator/po/fr-CA-messages-js.po | 130 +- misc/translator/po/fr-CA-messages.po | 7 +- misc/translator/po/fr-CA-opac-bootstrap.po | 461 +- misc/translator/po/fr-CA-pref.po | 32 +- misc/translator/po/fr-CA-staff-prog.po | 1008 ++-- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 6 +- misc/translator/po/fr-FR-messages-js.po | 8 +- misc/translator/po/fr-FR-messages.po | 7 +- misc/translator/po/fr-FR-opac-bootstrap.po | 469 +- misc/translator/po/fr-FR-pref.po | 18 +- misc/translator/po/fr-FR-staff-prog.po | 994 ++-- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 4 +- misc/translator/po/ga-messages-js.po | 8 +- misc/translator/po/ga-messages.po | 7 +- misc/translator/po/ga-opac-bootstrap.po | 449 +- misc/translator/po/ga-pref.po | 12 +- misc/translator/po/ga-staff-prog.po | 972 ++-- misc/translator/po/gd-marc-MARC21.po | 2 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 4 +- misc/translator/po/gd-messages-js.po | 8 +- misc/translator/po/gd-messages.po | 7 +- misc/translator/po/gd-opac-bootstrap.po | 449 +- misc/translator/po/gd-pref.po | 12 +- misc/translator/po/gd-staff-prog.po | 972 ++-- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 4 +- misc/translator/po/gl-messages-js.po | 8 +- misc/translator/po/gl-messages.po | 7 +- misc/translator/po/gl-opac-bootstrap.po | 449 +- misc/translator/po/gl-pref.po | 12 +- misc/translator/po/gl-staff-prog.po | 972 ++-- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 4 +- misc/translator/po/he-Hebr-messages-js.po | 8 +- misc/translator/po/he-Hebr-messages.po | 7 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 449 +- misc/translator/po/he-Hebr-pref.po | 12 +- misc/translator/po/he-Hebr-staff-prog.po | 972 ++-- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 6 +- misc/translator/po/hi-messages-js.po | 39 +- misc/translator/po/hi-messages.po | 10 +- misc/translator/po/hi-opac-bootstrap.po | 452 +- misc/translator/po/hi-pref.po | 30 +- misc/translator/po/hi-staff-prog.po | 979 ++-- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 8 +- misc/translator/po/hr-HR-messages-js.po | 8 +- misc/translator/po/hr-HR-messages.po | 7 +- misc/translator/po/hr-HR-opac-bootstrap.po | 453 +- misc/translator/po/hr-HR-pref.po | 12 +- misc/translator/po/hr-HR-staff-prog.po | 972 ++-- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 8 +- misc/translator/po/hu-HU-messages-js.po | 8 +- misc/translator/po/hu-HU-messages.po | 7 +- misc/translator/po/hu-HU-opac-bootstrap.po | 449 +- misc/translator/po/hu-HU-pref.po | 12 +- misc/translator/po/hu-HU-staff-prog.po | 972 ++-- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 10 +- misc/translator/po/hy-Armn-messages-js.po | 8 +- misc/translator/po/hy-Armn-messages.po | 11 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 459 +- misc/translator/po/hy-Armn-pref.po | 62 +- misc/translator/po/hy-Armn-staff-prog.po | 990 ++-- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 4 +- misc/translator/po/ia-messages-js.po | 8 +- misc/translator/po/ia-messages.po | 7 +- misc/translator/po/ia-opac-bootstrap.po | 449 +- misc/translator/po/ia-pref.po | 12 +- misc/translator/po/ia-staff-prog.po | 972 ++-- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 4 +- misc/translator/po/id-ID-messages-js.po | 8 +- misc/translator/po/id-ID-messages.po | 7 +- misc/translator/po/id-ID-opac-bootstrap.po | 449 +- misc/translator/po/id-ID-pref.po | 12 +- misc/translator/po/id-ID-staff-prog.po | 972 ++-- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 4 +- misc/translator/po/iq-CA-messages-js.po | 8 +- misc/translator/po/iq-CA-messages.po | 7 +- misc/translator/po/iq-CA-opac-bootstrap.po | 449 +- misc/translator/po/iq-CA-pref.po | 12 +- misc/translator/po/iq-CA-staff-prog.po | 972 ++-- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 4 +- misc/translator/po/is-IS-messages-js.po | 8 +- misc/translator/po/is-IS-messages.po | 7 +- misc/translator/po/is-IS-opac-bootstrap.po | 450 +- misc/translator/po/is-IS-pref.po | 12 +- misc/translator/po/is-IS-staff-prog.po | 972 ++-- misc/translator/po/it-IT-installer.po | 16 +- misc/translator/po/it-IT-marc-MARC21.po | 8 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 10 +- misc/translator/po/it-IT-messages-js.po | 8 +- misc/translator/po/it-IT-messages.po | 11 +- misc/translator/po/it-IT-opac-bootstrap.po | 461 +- misc/translator/po/it-IT-pref.po | 1052 ++-- misc/translator/po/it-IT-staff-prog.po | 5249 ++++++++++---------- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 4 +- misc/translator/po/iu-CA-messages-js.po | 8 +- misc/translator/po/iu-CA-messages.po | 7 +- misc/translator/po/iu-CA-opac-bootstrap.po | 449 +- misc/translator/po/iu-CA-pref.po | 12 +- misc/translator/po/iu-CA-staff-prog.po | 972 ++-- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 4 +- misc/translator/po/ja-Jpan-JP-messages-js.po | 8 +- misc/translator/po/ja-Jpan-JP-messages.po | 7 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 451 +- misc/translator/po/ja-Jpan-JP-pref.po | 12 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 972 ++-- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 4 +- misc/translator/po/ka-messages-js.po | 8 +- misc/translator/po/ka-messages.po | 7 +- misc/translator/po/ka-opac-bootstrap.po | 449 +- misc/translator/po/ka-pref.po | 12 +- misc/translator/po/ka-staff-prog.po | 972 ++-- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 4 +- misc/translator/po/km-KH-messages-js.po | 8 +- misc/translator/po/km-KH-messages.po | 7 +- misc/translator/po/km-KH-opac-bootstrap.po | 449 +- misc/translator/po/km-KH-pref.po | 12 +- misc/translator/po/km-KH-staff-prog.po | 972 ++-- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 4 +- misc/translator/po/kn-Knda-messages-js.po | 8 +- misc/translator/po/kn-Knda-messages.po | 7 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 449 +- misc/translator/po/kn-Knda-pref.po | 12 +- misc/translator/po/kn-Knda-staff-prog.po | 972 ++-- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 4 +- misc/translator/po/ko-Kore-KP-messages-js.po | 8 +- misc/translator/po/ko-Kore-KP-messages.po | 7 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 449 +- misc/translator/po/ko-Kore-KP-pref.po | 12 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 976 ++-- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 6 +- misc/translator/po/ku-Arab-messages-js.po | 8 +- misc/translator/po/ku-Arab-messages.po | 7 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 449 +- misc/translator/po/ku-Arab-pref.po | 12 +- misc/translator/po/ku-Arab-staff-prog.po | 974 ++-- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 4 +- misc/translator/po/lo-Laoo-messages-js.po | 8 +- misc/translator/po/lo-Laoo-messages.po | 7 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 449 +- misc/translator/po/lo-Laoo-pref.po | 12 +- misc/translator/po/lo-Laoo-staff-prog.po | 972 ++-- misc/translator/po/lv-marc-MARC21.po | 2 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 4 +- misc/translator/po/lv-messages-js.po | 8 +- misc/translator/po/lv-messages.po | 7 +- misc/translator/po/lv-opac-bootstrap.po | 449 +- misc/translator/po/lv-pref.po | 12 +- misc/translator/po/lv-staff-prog.po | 972 ++-- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 4 +- misc/translator/po/mi-NZ-messages-js.po | 8 +- misc/translator/po/mi-NZ-messages.po | 7 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 466 +- misc/translator/po/mi-NZ-pref.po | 12 +- misc/translator/po/mi-NZ-staff-prog.po | 972 ++-- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 4 +- misc/translator/po/ml-messages-js.po | 8 +- misc/translator/po/ml-messages.po | 7 +- misc/translator/po/ml-opac-bootstrap.po | 449 +- misc/translator/po/ml-pref.po | 12 +- misc/translator/po/ml-staff-prog.po | 972 ++-- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 4 +- misc/translator/po/mon-messages-js.po | 8 +- misc/translator/po/mon-messages.po | 7 +- misc/translator/po/mon-opac-bootstrap.po | 449 +- misc/translator/po/mon-pref.po | 12 +- misc/translator/po/mon-staff-prog.po | 972 ++-- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 4 +- misc/translator/po/mr-messages-js.po | 8 +- misc/translator/po/mr-messages.po | 7 +- misc/translator/po/mr-opac-bootstrap.po | 449 +- misc/translator/po/mr-pref.po | 12 +- misc/translator/po/mr-staff-prog.po | 972 ++-- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 4 +- misc/translator/po/ms-MY-messages-js.po | 8 +- misc/translator/po/ms-MY-messages.po | 7 +- misc/translator/po/ms-MY-opac-bootstrap.po | 449 +- misc/translator/po/ms-MY-pref.po | 12 +- misc/translator/po/ms-MY-staff-prog.po | 981 ++-- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 4 +- misc/translator/po/my-messages-js.po | 8 +- misc/translator/po/my-messages.po | 7 +- misc/translator/po/my-opac-bootstrap.po | 449 +- misc/translator/po/my-pref.po | 12 +- misc/translator/po/my-staff-prog.po | 972 ++-- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 6 +- misc/translator/po/nb-NO-messages-js.po | 8 +- misc/translator/po/nb-NO-messages.po | 7 +- misc/translator/po/nb-NO-opac-bootstrap.po | 452 +- misc/translator/po/nb-NO-pref.po | 14 +- misc/translator/po/nb-NO-staff-prog.po | 978 ++-- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 4 +- misc/translator/po/ne-NE-messages-js.po | 8 +- misc/translator/po/ne-NE-messages.po | 7 +- misc/translator/po/ne-NE-opac-bootstrap.po | 449 +- misc/translator/po/ne-NE-pref.po | 12 +- misc/translator/po/ne-NE-staff-prog.po | 972 ++-- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 8 +- misc/translator/po/nl-BE-messages-js.po | 8 +- misc/translator/po/nl-BE-messages.po | 7 +- misc/translator/po/nl-BE-opac-bootstrap.po | 451 +- misc/translator/po/nl-BE-pref.po | 12 +- misc/translator/po/nl-BE-staff-prog.po | 976 ++-- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 8 +- misc/translator/po/nl-NL-messages-js.po | 8 +- misc/translator/po/nl-NL-messages.po | 16 +- misc/translator/po/nl-NL-opac-bootstrap.po | 484 +- misc/translator/po/nl-NL-pref.po | 12 +- misc/translator/po/nl-NL-staff-prog.po | 980 ++-- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 8 +- misc/translator/po/nn-NO-messages-js.po | 8 +- misc/translator/po/nn-NO-messages.po | 7 +- misc/translator/po/nn-NO-opac-bootstrap.po | 449 +- misc/translator/po/nn-NO-pref.po | 12 +- misc/translator/po/nn-NO-staff-prog.po | 972 ++-- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 6 +- misc/translator/po/oc-messages-js.po | 8 +- misc/translator/po/oc-messages.po | 7 +- misc/translator/po/oc-opac-bootstrap.po | 449 +- misc/translator/po/oc-pref.po | 12 +- misc/translator/po/oc-staff-prog.po | 976 ++-- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 4 +- misc/translator/po/pbr-messages-js.po | 8 +- misc/translator/po/pbr-messages.po | 7 +- misc/translator/po/pbr-opac-bootstrap.po | 449 +- misc/translator/po/pbr-pref.po | 12 +- misc/translator/po/pbr-staff-prog.po | 972 ++-- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 6 +- misc/translator/po/pl-PL-messages-js.po | 284 +- misc/translator/po/pl-PL-messages.po | 11 +- misc/translator/po/pl-PL-opac-bootstrap.po | 456 +- misc/translator/po/pl-PL-pref.po | 14 +- misc/translator/po/pl-PL-staff-prog.po | 978 ++-- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 4 +- misc/translator/po/prs-messages-js.po | 8 +- misc/translator/po/prs-messages.po | 7 +- misc/translator/po/prs-opac-bootstrap.po | 449 +- misc/translator/po/prs-pref.po | 12 +- misc/translator/po/prs-staff-prog.po | 972 ++-- misc/translator/po/pt-BR-installer.po | 18 +- misc/translator/po/pt-BR-marc-MARC21.po | 8 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 6 +- misc/translator/po/pt-BR-messages-js.po | 18 +- misc/translator/po/pt-BR-messages.po | 7 +- misc/translator/po/pt-BR-opac-bootstrap.po | 452 +- misc/translator/po/pt-BR-pref.po | 20 +- misc/translator/po/pt-BR-staff-prog.po | 1005 ++-- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 6 +- misc/translator/po/pt-PT-messages-js.po | 8 +- misc/translator/po/pt-PT-messages.po | 7 +- misc/translator/po/pt-PT-opac-bootstrap.po | 453 +- misc/translator/po/pt-PT-pref.po | 20 +- misc/translator/po/pt-PT-staff-prog.po | 978 ++-- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 6 +- misc/translator/po/ro-RO-messages-js.po | 8 +- misc/translator/po/ro-RO-messages.po | 7 +- misc/translator/po/ro-RO-opac-bootstrap.po | 449 +- misc/translator/po/ro-RO-pref.po | 12 +- misc/translator/po/ro-RO-staff-prog.po | 972 ++-- misc/translator/po/ru-RU-installer-MARC21.po | 71 +- misc/translator/po/ru-RU-installer.po | 81 +- misc/translator/po/ru-RU-marc-MARC21.po | 114 +- misc/translator/po/ru-RU-marc-NORMARC.po | 16 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 53 +- misc/translator/po/ru-RU-messages-js.po | 69 +- misc/translator/po/ru-RU-messages.po | 19 +- misc/translator/po/ru-RU-opac-bootstrap.po | 1288 ++--- misc/translator/po/ru-RU-pref.po | 943 ++-- misc/translator/po/ru-RU-staff-prog.po | 5917 ++++++++++++----------- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 4 +- misc/translator/po/rw-RW-messages-js.po | 8 +- misc/translator/po/rw-RW-messages.po | 7 +- misc/translator/po/rw-RW-opac-bootstrap.po | 449 +- misc/translator/po/rw-RW-pref.po | 12 +- misc/translator/po/rw-RW-staff-prog.po | 972 ++-- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 4 +- misc/translator/po/sd-PK-messages-js.po | 8 +- misc/translator/po/sd-PK-messages.po | 7 +- misc/translator/po/sd-PK-opac-bootstrap.po | 449 +- misc/translator/po/sd-PK-pref.po | 12 +- misc/translator/po/sd-PK-staff-prog.po | 972 ++-- misc/translator/po/sk-SK-installer-MARC21.po | 10 +- misc/translator/po/sk-SK-marc-MARC21.po | 14 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 14 +- misc/translator/po/sk-SK-messages-js.po | 361 +- misc/translator/po/sk-SK-messages.po | 7 +- misc/translator/po/sk-SK-opac-bootstrap.po | 517 +- misc/translator/po/sk-SK-pref.po | 28 +- misc/translator/po/sk-SK-staff-prog.po | 1064 ++-- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 4 +- misc/translator/po/sl-SI-messages-js.po | 8 +- misc/translator/po/sl-SI-messages.po | 7 +- misc/translator/po/sl-SI-opac-bootstrap.po | 449 +- misc/translator/po/sl-SI-pref.po | 12 +- misc/translator/po/sl-SI-staff-prog.po | 972 ++-- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 4 +- misc/translator/po/sq-AL-messages-js.po | 8 +- misc/translator/po/sq-AL-messages.po | 7 +- misc/translator/po/sq-AL-opac-bootstrap.po | 449 +- misc/translator/po/sq-AL-pref.po | 12 +- misc/translator/po/sq-AL-staff-prog.po | 973 ++-- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 4 +- misc/translator/po/sr-Cyrl-messages-js.po | 8 +- misc/translator/po/sr-Cyrl-messages.po | 7 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 449 +- misc/translator/po/sr-Cyrl-pref.po | 12 +- misc/translator/po/sr-Cyrl-staff-prog.po | 972 ++-- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 6 +- misc/translator/po/sv-SE-messages-js.po | 8 +- misc/translator/po/sv-SE-messages.po | 7 +- misc/translator/po/sv-SE-opac-bootstrap.po | 467 +- misc/translator/po/sv-SE-pref.po | 22 +- misc/translator/po/sv-SE-staff-prog.po | 1004 ++-- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 4 +- misc/translator/po/sw-KE-messages-js.po | 8 +- misc/translator/po/sw-KE-messages.po | 7 +- misc/translator/po/sw-KE-opac-bootstrap.po | 449 +- misc/translator/po/sw-KE-pref.po | 12 +- misc/translator/po/sw-KE-staff-prog.po | 972 ++-- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 4 +- misc/translator/po/ta-LK-messages-js.po | 8 +- misc/translator/po/ta-LK-messages.po | 7 +- misc/translator/po/ta-LK-opac-bootstrap.po | 449 +- misc/translator/po/ta-LK-pref.po | 12 +- misc/translator/po/ta-LK-staff-prog.po | 972 ++-- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 4 +- misc/translator/po/ta-messages-js.po | 8 +- misc/translator/po/ta-messages.po | 7 +- misc/translator/po/ta-opac-bootstrap.po | 449 +- misc/translator/po/ta-pref.po | 12 +- misc/translator/po/ta-staff-prog.po | 972 ++-- misc/translator/po/te-marc-MARC21.po | 2 +- misc/translator/po/te-marc-NORMARC.po | 2 +- misc/translator/po/te-marc-UNIMARC.po | 4 +- misc/translator/po/te-messages-js.po | 8 +- misc/translator/po/te-messages.po | 14 +- misc/translator/po/te-opac-bootstrap.po | 451 +- misc/translator/po/te-pref.po | 20 +- misc/translator/po/te-staff-prog.po | 978 ++-- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 6 +- misc/translator/po/tet-messages-js.po | 8 +- misc/translator/po/tet-messages.po | 7 +- misc/translator/po/tet-opac-bootstrap.po | 449 +- misc/translator/po/tet-pref.po | 12 +- misc/translator/po/tet-staff-prog.po | 972 ++-- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 4 +- misc/translator/po/th-TH-messages-js.po | 8 +- misc/translator/po/th-TH-messages.po | 7 +- misc/translator/po/th-TH-opac-bootstrap.po | 449 +- misc/translator/po/th-TH-pref.po | 12 +- misc/translator/po/th-TH-staff-prog.po | 972 ++-- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 4 +- misc/translator/po/tl-PH-messages-js.po | 8 +- misc/translator/po/tl-PH-messages.po | 7 +- misc/translator/po/tl-PH-opac-bootstrap.po | 449 +- misc/translator/po/tl-PH-pref.po | 12 +- misc/translator/po/tl-PH-staff-prog.po | 972 ++-- misc/translator/po/tr-TR-installer.po | 88 +- misc/translator/po/tr-TR-marc-MARC21.po | 42 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 18 +- misc/translator/po/tr-TR-messages-js.po | 406 +- misc/translator/po/tr-TR-messages.po | 14 +- misc/translator/po/tr-TR-opac-bootstrap.po | 668 +-- misc/translator/po/tr-TR-pref.po | 105 +- misc/translator/po/tr-TR-staff-prog.po | 1077 +++-- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 4 +- misc/translator/po/tvl-messages-js.po | 8 +- misc/translator/po/tvl-messages.po | 7 +- misc/translator/po/tvl-opac-bootstrap.po | 449 +- misc/translator/po/tvl-pref.po | 12 +- misc/translator/po/tvl-staff-prog.po | 972 ++-- misc/translator/po/uk-UA-marc-MARC21.po | 12 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 22 +- misc/translator/po/uk-UA-messages-js.po | 21 +- misc/translator/po/uk-UA-messages.po | 11 +- misc/translator/po/uk-UA-opac-bootstrap.po | 461 +- misc/translator/po/uk-UA-pref.po | 32 +- misc/translator/po/uk-UA-staff-prog.po | 997 ++-- misc/translator/po/ur-Arab-installer-MARC21.po | 13 +- misc/translator/po/ur-Arab-marc-MARC21.po | 10 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 4 +- misc/translator/po/ur-Arab-messages-js.po | 8 +- misc/translator/po/ur-Arab-messages.po | 7 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 449 +- misc/translator/po/ur-Arab-pref.po | 12 +- misc/translator/po/ur-Arab-staff-prog.po | 972 ++-- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 6 +- misc/translator/po/vi-VN-messages-js.po | 8 +- misc/translator/po/vi-VN-messages.po | 7 +- misc/translator/po/vi-VN-opac-bootstrap.po | 449 +- misc/translator/po/vi-VN-pref.po | 12 +- misc/translator/po/vi-VN-staff-prog.po | 976 ++-- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 6 +- misc/translator/po/zh-Hans-CN-messages-js.po | 8 +- misc/translator/po/zh-Hans-CN-messages.po | 7 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 449 +- misc/translator/po/zh-Hans-CN-pref.po | 12 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 976 ++-- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 6 +- misc/translator/po/zh-Hant-TW-messages-js.po | 12 +- misc/translator/po/zh-Hant-TW-messages.po | 7 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 451 +- misc/translator/po/zh-Hant-TW-pref.po | 21 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 1007 ++-- 706 files changed, 74724 insertions(+), 70022 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 01:03:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 00:03:34 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-114-gbf38a864d4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via bf38a864d493fc246d51ff6711b362a359d48617 (commit) from 604b0c5b75a78196f394298781fb881204da25a5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bf38a864d493fc246d51ff6711b362a359d48617 Author: Lucas Gass Date: Mon Nov 23 23:31:13 2020 +0000 Update release notes for 20.05.06 release Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_20_05_06.html | 619 +++++++++++++++++++++++++ misc/release_notes/release_notes_20_05_06.md | 498 ++++++++++++++++++++ 2 files changed, 1117 insertions(+) create mode 100644 misc/release_notes/release_notes_20_05_06.html create mode 100644 misc/release_notes/release_notes_20_05_06.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 01:06:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 00:06:20 +0000 Subject: [koha-commits] main Koha release repository annotated tag v20.05.06 created. v20.05.06 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v20.05.06 has been created at d7cd4b33df36e3b3e65bd057d52461c0cb9979bf (tag) tagging bf38a864d493fc246d51ff6711b362a359d48617 (commit) replaces v20.05.05 tagged by Lucas Gass on Mon Nov 23 16:34:14 2020 -0700 - Log ----------------------------------------------------------------- Koha release 20.05.06 -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEiuLrhIFCDD7BMEVj+cc4/xIeRdoFAl+8RvYACgkQ+cc4/xIe RdqqMQgAiL1P0sOjSYoPFVLep5AFWwmuY0ur7WyDbhSS/Ir7S/jXqP8euHHRkc3i ewemsPyVX4LTz30BzLiErDOzOnDXdP5bc/O6Nd+gWhFbAnPFIr3DkK0MCXnp4BW3 NRpN7AKPs1P0r++Sy/1h279GXucYNKWG0AYFP56JZs/hxO5Pvalzf6rsqKDMQmk6 2S1cv2exFPs71tMq9QdlO9Dbxv0nNz9wx064i7ILT0RIObWkmzOdH6RPvUGTiDCk pxlCBJISuhN/e0E/XQa9kpjICm+jJ4eHuj3g3EGnXN7a4myZ/20C7VGVZQgQCPI0 BcF3dKWWH8dQgZxSfCzNLXSiefVHMw== =j20G -----END PGP SIGNATURE----- Agustín Moyano (1): Bug 18050: (follow-up) Force adding FK constraint Alex Buckley (1): Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Andreas Roussos (2): Bug 26449: fix web installer typo Bug 26450: fix typo in plugin template Andrew Fuerste-Henry (1): Bug 26569: Use gender neutral pronouns in system prefernece explanations Björn Nylén (1): Bug 26750: Deleted items not indexed Blou (1): Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm David Cook (4): Bug 26496: Add op field to Budget Planning Bug 26673: Remove #!/usr/bin/env perl from .pm modules too Bug 26853: Harmonize import_biblios with biblio and biblioitems Bug 26853: Throw a fatal error if import_biblios insert fails Didier Gautheron (3): Bug 26232: Test for empty smart rule fine grace period Bug 26232: Empty smart rule fine grace period Bug 25167: Fix to a fix wrong inventory results Emmi Takkinen (2): Bug 26429: Show correct expiration date at the request.pl Bug 9118: Do not show option to create exception on range for unique holiday Fridolin Somers (6): Bug 26538: Display cities list before input text Bug 26487: Add all MARC flavours for not-onloan-count search field Bug 26832: Make Elasticsearch mappings export use UTF-8 Bug 26594: add Unit Test Bug 26594: Fix patrons merge problem with restrictions Bug 26904: OPAC password recovery allows regexp in email John Fawcett (2): Bug 26612: Error during web install for it-IT translation Bug 26613: Fix it-IT unimarc_framework.sql installer file Jonathan Druart (15): Bug 26137: Remove warnings from viewlog.pl Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan Bug 20804: Add tests Bug 20804: Add support for "days" to the timeout syspref Bug 26445: Fix "back to result" link of the search result browser Bug 26673: Remove shebangs from Perl modules Bug 26673: Fix perlcritic complains Bug 26639: Add auto_savepoint to DBIC connection Bug 26915: Fix FinePaymentAutoPopup behaviour Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records contain itemnumber Katrin Fischer (11): Bug 9118: (QA follow-up) Fix spelling on "To Date :" Bug 26018: Fix frameworks errors with subfields in wrong tab Bug 26686: Fix sorting of "updated on" and "time created" on notices tab Bug 18050: Add FK constraint on aqbudgets.budget_period_id Bug 18050: Add relation alias to schema Bug 18050: (QA follow-up) Adjust conditions and make use of message text Bug 26526: Relabel checkout note column in OPAC Bug 26696: Fix colspan in payment table when credit exists Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference Bug 26190: Allow to close a basket with only cancelled order lines Bug 26727: Fix

appearing in the templates Koha translators (1): Translation updates for Koha 20.05.06 Kyle M Hall (5): Bug 26604: "Generate next" button gives error on serials-collection.pl Bug 26627: Print and confirming a hold can cause an infinite loop Bug 26627: (QA follow-up) Remove barcode input by id Bug 26908: Restore ability to view and select EDI plugins for a vendor account Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method Lisette Scheer (1): Bug 26723: Improve link text on OverDriveAuthName system preference Lucas Gass (10): Bug 26184: Add div element to 'items available' note in OPAC reserve template Bug 26389: Add auto renewal error to opac-user.tt Bug 26569: DBRev 20.05.05.001 Bug 18050: DBIC Bug 18050: DBRev 20.05.05.002 Revert "Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode" Bug 26853: DBRev 20.05.05.003 Bug 26853: DBIC changes Increment version for 20.05.06 release Update release notes for 20.05.06 release Marcel de Rooy (3): Bug 26191: Relocate track_login call in Auth.pm Bug 26600: Missing module in Elasticsearch/Indexer.pm Bug 26599: Unused parameter name in POD of ModZebra Mark Hofstetter (1): Bug 26601: Add utf8 encoding to text output of overdue_notices.pl Martin Renvoize (5): Bug 26506: (QA follow-up) Add Unit Test Bug 25549: Add error reporting to plugins-home Bug 23432: Replace 'die' with 'warn' Bug 26581: [20.05.x] Only reindex records once per checkin Bug 26908: (follow-up) Alter template check Mason James (1): Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error Matthias Meusburger (1): Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Nick Clemens (19): Bug 23828: Unit tests Bug 23828: Elasticsearch - Preserve record order when combining subfield in mappings Bug 25549: Remove plugin methods for broken plugins Bug 23432: (QA follow-up) Add a unit test Bug 8437: Exclude export.pl from plack Bug 26781: Check for subfield defined rather than truth Bug 26781: (follow-up) Adjust tests as fields are no longer completely removed Bug 26784: Silence warns about comparing undefined values for MARC modification templates Bug 26725: (QA follow-up) Add line break and 'the' for readability Bug 26450: (QA follow-up) Replace tabs with spaces Bug 26726: (QA follow-up) Add line break and 'the' for readability Bug 26583: Remove unneccessary code in AddIssue Bug 26581: (follow-up) Restore unsetting of doreturn Bug 26581: (follow-up) Skip merge when deleting authority Bug 18051: Set UTF8 Flag for record searches/imports from rancor Bug 17515: Order Z3950 server by rank and preserve ordering Bug 25167: (QA follow-up) Don't add a new variable Bug 26963: [20.05.x] Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Owen Leonard (8): Bug 26551: Correct modal markup to prevent long heading from overflowing Bug 25353: Correct eslint errors in additems.js Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode Bug 26756: Fix quotes showing behind some system preference descriptions Bug 26762: Modify template logic in opac-reserves.tt to avoid error Bug 26766: Correct selection of title during OPAC note confirmation Bug 26816: Chomp whitespace around i18n strings Bug 26727: (follow-up) More markup corrections Phil Ringnalda (2): Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record Bug 26605: Correctly URI-encode query string in call number browse plugin Tal Rogoff (3): Bug 26725: changed the text of the "here" link on the patron attributes administration page Bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Bug 26726: changed the text of the "here" link on the transport cost matrix administration page Timothy Alexis Vass (1): Bug 26647: Add translation context to cancel hold button in OPAC Tomás Cohen Arazi (3): Bug 26751: Fix fatal exception if only one repo defined Bug 24633: Add support for gitlab searching of plugins Bug 24633: (follow-up) Tweak sample plugin targets ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 01:36:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 00:36:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-34-g321afcfe74 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 321afcfe745e1423f106bfa435e452191c4a7fd7 (commit) from 4a2fcd6604ec4f7490334ba98b038d46bf3a8cfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 321afcfe745e1423f106bfa435e452191c4a7fd7 Author: Nick Clemens Date: Fri Sep 4 12:47:58 2020 +0000 Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve For cron purposes this is the correct behaviour. For display purposes we wish to see on_reserve over too_soon This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses To test: 1 - set NoRenewalBeforePrecision to date only 2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days 3 - check item out 4 - confirm item shows Scheduled For Automatic Renewal in issues table 5 - place a hold on the item for another patron 6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold" 7 - change No Renewal Before value to 7 8 - reload issues table for patron 1, confirm checkout now shows "on hold" 9 - Apply patch 10 - restart_all 11 - Reload the issues table - confirm 'on_hold' still shows 12 - Change No Renewal Before to 0 13 - Refresh issues table, still shows 'On hold' 14 - perl misc/cronjobs/automatic_renewals.pl -v 15 - Result shows 'auto_too_soon' 16 - prove -v t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 26 ++++++++++++++++---------- misc/cronjobs/automatic_renewals.pl | 2 +- t/db_dependent/Circulation.t | 10 ++++++++-- 3 files changed, 25 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 01:39:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 00:39:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-35-gf287fdfd81 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f287fdfd81a2b0c1868c7d089b99ffee4d2e62b3 (commit) from 321afcfe745e1423f106bfa435e452191c4a7fd7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f287fdfd81a2b0c1868c7d089b99ffee4d2e62b3 Author: Fridolin Somers Date: Tue Nov 3 09:19:34 2020 +0100 Bug 26904: OPAC password recovery allows regexp in email When using OPAC password recovery form, opac/opac-password-recovery.pl : if one provides correct login and an email, there is a check that this email is one of patron's. This check uses RegExp with case insensitive : if ( $email && !( any { /^$email$/i } @emails ) ) This is a security issue since one can simply enter '.*'. Severity is normal because the login must be a correct. I propose to use simple string compare with lowercase to be case insensitive. Test plan : 1) Don't apply patch 2) Enable system preference 'OpacResetPassword' 3) Go to 'OPAC > Log in to your account > Forgot your password?' 4) Enter an existing userid or cardnumber and '.*' in 'Email' 5) The password recovery is created ! (check table 'borrower_password_recovery') 6) Apply patch 7) Enter an existing userid or cardnumber and '.*' in 'Email' 8) You get the message 'No account was found with the provided information.' 9) Enter an existing userid or cardnumber and in 'Email' the corresponding email but with different case 10) The password recovery is created (check table 'borrower_password_recovery') Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 904e926ba0f407b24aa3d94be5afe37b5e3ec075) Signed-off-by: Lucas Gass (cherry picked from commit 57a9bf3ef2e4f25227a10f16cec7fb34e162199e) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: opac/opac-password-recovery.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 02:17:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 01:17:45 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-38-gfd6ccb4a54 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fd6ccb4a54281a3799f3646280233f8871aeab3b (commit) via 66170d0b530d56716739eaada912fbd9d3148c68 (commit) via 0e9bbcb6072960b7784107732c08d47dc9ab9aa1 (commit) from f287fdfd81a2b0c1868c7d089b99ffee4d2e62b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fd6ccb4a54281a3799f3646280233f8871aeab3b Author: Aleisha Amohia Date: Tue Nov 24 13:45:39 2020 +1300 Increment version for 19.11.12 release Signed-off-by: Aleisha Amohia commit 66170d0b530d56716739eaada912fbd9d3148c68 Author: Aleisha Amohia Date: Tue Nov 24 13:42:58 2020 +1300 Fixing po files for 19.11.12 Signed-off-by: Aleisha Amohia commit 0e9bbcb6072960b7784107732c08d47dc9ab9aa1 Author: Koha translators <> Date: Mon Nov 23 21:32:06 2020 -0300 Translation updates for Koha 19.11.12 Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 334 ++--- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 334 ++--- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 334 ++--- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 334 ++--- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 334 ++--- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 334 ++--- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 334 ++--- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 342 ++--- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 6 +- misc/translator/po/cs-CZ-staff-prog.po | 338 ++--- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 334 ++--- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 334 ++--- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 334 ++--- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 2 +- misc/translator/po/de-DE-staff-prog.po | 342 ++--- misc/translator/po/dz-marc-MARC21.po | 2 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 2 +- misc/translator/po/dz-staff-prog.po | 334 ++--- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 15 +- misc/translator/po/el-GR-pref.po | 6 +- misc/translator/po/el-GR-staff-prog.po | 349 ++--- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 344 ++--- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 334 ++--- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 2 +- misc/translator/po/eo-staff-prog.po | 334 ++--- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 12 +- misc/translator/po/es-ES-pref.po | 20 +- misc/translator/po/es-ES-staff-prog.po | 371 +++--- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-staff-prog.po | 334 ++--- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 346 ++--- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 334 ++--- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 334 ++--- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 10 +- misc/translator/po/fr-CA-staff-prog.po | 336 ++--- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 16 +- misc/translator/po/fr-FR-staff-prog.po | 391 +++--- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 2 +- misc/translator/po/ga-staff-prog.po | 334 ++--- misc/translator/po/gd-marc-MARC21.po | 2 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 2 +- misc/translator/po/gd-staff-prog.po | 334 ++--- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-staff-prog.po | 334 ++--- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 334 ++--- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-staff-prog.po | 334 ++--- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 334 ++--- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 334 ++--- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 338 ++--- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-staff-prog.po | 334 ++--- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 334 ++--- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 334 ++--- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 334 ++--- misc/translator/po/it-IT-marc-MARC21.po | 411 +++--- misc/translator/po/it-IT-marc-NORMARC.po | 10 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-messages.po | 8 +- misc/translator/po/it-IT-opac-bootstrap.po | 2 +- misc/translator/po/it-IT-pref.po | 124 +- misc/translator/po/it-IT-staff-prog.po | 334 ++--- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 334 ++--- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 334 ++--- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-staff-prog.po | 334 ++--- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 334 ++--- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 334 ++--- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 334 ++--- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 334 ++--- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 334 ++--- misc/translator/po/lv-marc-MARC21.po | 2 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 2 +- misc/translator/po/lv-staff-prog.po | 334 ++--- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 334 ++--- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-staff-prog.po | 334 ++--- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-staff-prog.po | 334 ++--- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-staff-prog.po | 334 ++--- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 334 ++--- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-staff-prog.po | 334 ++--- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 334 ++--- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 334 ++--- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 334 ++--- misc/translator/po/nl-NL-marc-MARC21.po | 1617 ++++++++++++----------- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 396 +++--- misc/translator/po/nl-NL-messages-js.po | 6 +- misc/translator/po/nl-NL-messages.po | 8 +- misc/translator/po/nl-NL-opac-bootstrap.po | 257 ++-- misc/translator/po/nl-NL-pref.po | 32 +- misc/translator/po/nl-NL-staff-prog.po | 720 +++++----- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 334 ++--- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 2 +- misc/translator/po/oc-staff-prog.po | 334 ++--- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-staff-prog.po | 334 ++--- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 334 ++--- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-staff-prog.po | 334 ++--- misc/translator/po/pt-BR-marc-MARC21.po | 10 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 348 ++--- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 334 ++--- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 334 ++--- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-pref.po | 6 +- misc/translator/po/ru-RU-staff-prog.po | 368 +++--- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 334 ++--- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 334 ++--- misc/translator/po/sk-SK-marc-MARC21.po | 14 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 10 +- misc/translator/po/sk-SK-opac-bootstrap.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 353 ++--- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 334 ++--- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 334 ++--- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 334 ++--- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 334 ++--- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 334 ++--- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 334 ++--- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-staff-prog.po | 334 ++--- misc/translator/po/te-marc-MARC21.po | 2 +- misc/translator/po/te-marc-NORMARC.po | 2 +- misc/translator/po/te-marc-UNIMARC.po | 2 +- misc/translator/po/te-opac-bootstrap.po | 2 +- misc/translator/po/te-staff-prog.po | 356 ++--- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-staff-prog.po | 334 ++--- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 334 ++--- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 334 ++--- misc/translator/po/tr-TR-marc-MARC21.po | 10 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 338 ++--- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 2 +- misc/translator/po/tvl-staff-prog.po | 334 ++--- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 6 +- misc/translator/po/uk-UA-staff-prog.po | 338 ++--- misc/translator/po/ur-Arab-marc-MARC21.po | 12 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 334 ++--- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 334 ++--- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 334 ++--- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 350 ++--- 445 files changed, 17917 insertions(+), 15491 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 02:23:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 01:23:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-39-gd1fcec2101 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d1fcec21015cf4f725e0632b2aeb2cb7280dea5d (commit) from fd6ccb4a54281a3799f3646280233f8871aeab3b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d1fcec21015cf4f725e0632b2aeb2cb7280dea5d Author: Aleisha Amohia Date: Tue Nov 24 13:51:36 2020 +1300 Update release notes for 19.11.12 release Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: ...s_19_11_11.html => release_notes_19_11_12.html} | 225 +++++++----- misc/release_notes/release_notes_19_11_12.md | 381 +++++++++++++++++++++ 2 files changed, 529 insertions(+), 77 deletions(-) copy misc/release_notes/{release_notes_19_11_11.html => release_notes_19_11_12.html} (57%) create mode 100644 misc/release_notes/release_notes_19_11_12.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Nov 24 02:24:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Nov 2020 01:24:18 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.11.12 created. v19.11.12 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.11.12 has been created at 7dca1a4b7be8f063f884c26f35e5460d270eda3e (tag) tagging d1fcec21015cf4f725e0632b2aeb2cb7280dea5d (commit) replaces v19.11.11 tagged by Aleisha Amohia on Tue Nov 24 13:52:31 2020 +1300 - Log ----------------------------------------------------------------- Koha release 19.11.12 -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEsrg4Ma6lEmRo36iNRUuHZJtbty8FAl+8WU8ACgkQRUuHZJtb ty87zw//dTpbjtQIgH4MtzCOzMBMObcofFhxjNd+Xxng7zuvgxyn8p1ytda2HBxt 4+1Ri+USlI/NkwteqsysQ3SWgrrz6sODESF4d2G4NH7TqhXhLGV8mzQw4ueHEwOV ib5EtjyTGI5zt1s1mfpc27x1Cx4p+uztSAWk/G1O4DYaPzgG/31BYBneQ40grTb0 drF4ixwgsvXiLpXBc/nnVsLWGmlrcvhgogzye983/rkIaBmvrB3o2j3sV2MiICnh tCcXu6Ri2cIjmfFqildnAftPQr5XsKgWbJndTQ786h//4oeh70UW7c6AjyURlQj+ gtzKSIVl9v7zmPXymzOhQBsvY3QIojjZUZ1KTwLnZfZjnwiqLYSPCTE4zrwrFdz2 3i9GvKEFzugmGHPMnypf5/ji0Z7WuM90EocchUdoJSDUQ/3XpRywAf85OheDv5QP hMopK+lN/+Ego8cFx9OtD++Nn4FxeQAfpn9X00/+NLLPYH7iPbyH5rFUhuhfvl8D 8K+Pr+VIlfg5W/hYWbNM6vKf92lSFWAfMh58q3WJ+rrVCGN9LjmDH9G7d9dKvCJD jIlX/FqrDpEZDnqp1vpzld0pcPOb7lr2IWBUulB8bMpn07k8eOms550csd3HTfXY lIF/NF4BFsPZj6Q3SJ0jxPFHtGmutqAzKX5SSs8wKS/NeJyKQ1U= =uhKB -----END PGP SIGNATURE----- Agustín Moyano (1): Bug 18050: (follow-up) Force adding FK constraint Aleisha Amohia (7): Bug 25242: Compile CSS Bug 26569: DBRev 19.11.11.001 Bug 18050: DBIC Bug 18050: DBRev 19.11.11.002 Fixing po files for 19.11.12 Increment version for 19.11.12 release Update release notes for 19.11.12 release Alex Buckley (1): Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Andrew Fuerste-Henry (1): Bug 26569: Use gender neutral pronouns in system prefernece explanations David Cook (1): Bug 26496: Add op field to Budget Planning Emmi Takkinen (1): Bug 26429: Show correct expiration date at the request.pl Fridolin Somers (1): Bug 26904: OPAC password recovery allows regexp in email John Fawcett (2): Bug 26612: Error during web install for it-IT translation Bug 26613: Fix it-IT unimarc_framework.sql installer file Jonathan Druart (4): Bug 20804: Add tests Bug 20804: Add support for "days" to the timeout syspref Bug 26639: Add auto_savepoint to DBIC connection Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration Katrin Fischer (5): Bug 18050: Add FK constraint on aqbudgets.budget_period_id Bug 18050: Add relation alias to schema Bug 18050: (QA follow-up) Adjust conditions and make use of message text Bug 26190: Allow to close a basket with only cancelled order lines Bug 26727: Fix

appearing in the templates Koha translators (1): Translation updates for Koha 19.11.12 Kyle M Hall (1): Bug 26604: "Generate next" button gives error on serials-collection.pl Marcel de Rooy (1): Bug 26191: Relocate track_login call in Auth.pm Mark Hofstetter (1): Bug 26601: Add utf8 encoding to text output of overdue_notices.pl Martin Renvoize (2): Bug 25242: Improve column wrapping for holdingst Bug 25549: Add error reporting to plugins-home Mason James (1): Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error Nick Clemens (4): Bug 25549: Remove plugin methods for broken plugins Bug 8437: Exclude export.pl from plack Bug 18051: Set UTF8 Flag for record searches/imports from rancor Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Owen Leonard (2): Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl Bug 26727: (follow-up) More markup corrections Phil Ringnalda (2): Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record Bug 26605: Correctly URI-encode query string in call number browse plugin ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository