[koha-commits] main Koha release repository branch master updated. v20.05.00-1645-g6ba108f4eb
Git repo owner
gitmaster at git.koha-community.org
Wed Nov 4 13:36:12 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 6ba108f4eb18eb27a1b8be55b33b4e28df4b806f (commit)
via ceee890899c54e113a0a787016ae52e40f3817bb (commit)
via a8e5d9ab9f3dc690f007bb6893af71edf26a473f (commit)
via 973e1b1d5d3d381e90bd405d220e7d418ca1c818 (commit)
via d1f412bd76adb4ec54db3b5991b03e9fb2bdecd2 (commit)
via 3ef31a0b77133e4c3eacc1c7d46d917746e438d7 (commit)
via 38507b041ba3a448315d91294f032267679810bd (commit)
via c2293d5c602b27b8f88d64d15eaa4de94e6bc16c (commit)
via ee028855c246b1496003fbfccfd20042594ac4bf (commit)
via 42ab7b80d4f1d13e15f991d3c4fa161ffca0726f (commit)
via 043f3f0fd022b70323e2e681b3560bf0915fe845 (commit)
via f2876ef4d481cd037b2b08a3240f14e44f0882f5 (commit)
via f0b3bbb3276741961d5e8e8da88aa3076b255eeb (commit)
via 7f2e2a4dbdaf066cf6002ad1d6f1241273ce5705 (commit)
via 4dd798302a84acf5d4474affeaa61fc9c97ed68a (commit)
via ab2e3b0e890a45202a9c360f444917a0ff336d50 (commit)
via 96be711d0333a531051cdbd6f194a2eb05071c60 (commit)
via 98ab9863929799a8e42f7b8ce23ba5d70c822b14 (commit)
via 3bfc54d44a53a4235e171858f75a6fc4bdc3eb9c (commit)
via 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa (commit)
via a27c22bffc2fbd48951192dbff846b35766d4123 (commit)
via e42b4088ed83eb093389f3f5a841095ecc8f036f (commit)
via 018720aa5e0c82ad52821789f8878905f1d9affb (commit)
via 66289610fa34574e09bd25a95c104a5c03a9cc7f (commit)
via 0ddb841d22a41fafee5164967ef8ec449cae06dc (commit)
via c65e7ba177e37125de208d9612b74cc9ad3d2b52 (commit)
via 9a113663820634d2d718c8a979e8e70f64b8744a (commit)
via b5dc71be2ee6d49335d9b4ee79edcf68882c555d (commit)
via f010b8fd168a10cd380131fc2bb5360538524655 (commit)
via 579608808c4ec81f469e4c48627525d17a16194d (commit)
via b1e2693ce529a7af2646ba770269cf32e991ff7d (commit)
via 657df01fec106e9a0e2afee7518c8b95537c93d4 (commit)
via dcbc856b60436aa1341beb7da75ac3665d4e5f92 (commit)
via dbe8c14bbf3ff8a3bc2daa07ab52e02e2a28ef77 (commit)
via 5f498d250cdbe50bede11a1e550f385de6ae3d06 (commit)
via 37a7a1bb5042e839151185aa40449cad9c6260b6 (commit)
via 52be44f406e108544f21e6d45055a9ea9e86c075 (commit)
via 975e06bd7c3e198048c60d4a0f9968ba89079de7 (commit)
via 14f99da17c38ca352939be48eae0a11523e787e0 (commit)
via 4e3bcc9a2578b3821ff8f39554976fb7b76456db (commit)
via 6f272a16b2eb6d200402489b26435eea282ec622 (commit)
via 617a012a4cbe1e8ada09c0db3d8e464c36b97255 (commit)
via 291df4e09206399f4de26ef0214db2b8784c9e20 (commit)
via 93c66100733db0aea73a3e59841981e4ee85e717 (commit)
via cb4df3b29a57b62b82cf7652b40d30aea4a92d9b (commit)
via 781b5a41188c958213f409310f38ba49dcd13159 (commit)
via d80763c3714457bf14fd585513ab07d02b82c819 (commit)
via d23c58e9084176fac3e64b8edbbaa64ddcc164d4 (commit)
via bd0674ac1009420ba94fb005560e11c883003d73 (commit)
via 9cbbd6b2ca436990f51b8d1b1985074c2620259c (commit)
via 55f2279314edf390e6257942a84f9f9b058c84cf (commit)
via e7c134e27e044ad4ebe9a0e4aa220f4a05208215 (commit)
via e91b565055892e6c79cd842a975efd83bd566f52 (commit)
via 0833724afe7cb0d2f2db32c7e87f3df064e6a016 (commit)
via 07cab93d5d9bd292368e097305f309419e746e2f (commit)
via 8a874de3f42ef02d0eb9e7e8512f952da5a7152a (commit)
via 5da551a6a219436b001ebb0dd35b98414de1d378 (commit)
via 77365090f57fe83eff37402f6dcc725fdee00c92 (commit)
via 80bf7abb5cd309ae28cd588df9037231e11683e5 (commit)
via e0b41a7c5a9634c3229b25424dd449e0bebcf6f6 (commit)
via ebbee18822f73c8e8f2236b13a66ba653bebe03f (commit)
via 301528d6df117f9183d09189d7a596cdf431f77e (commit)
via 4cf9a59b400a97b51ab25720eaf40c60d81e2d42 (commit)
via a1c5c5b060115f9e025fce17d602509738319b90 (commit)
via 8ccc73353c651659c7e0816bfa57fe2d7b8d82b5 (commit)
via b72de018132acaae77ebc3852ed369cf45edc8fb (commit)
via 8ba1d7a22b2fccb093fcdb9f20b6bf2dfec04e91 (commit)
via 9adafd6404cfdc3f1fc52445e32d8f8b121ccc4e (commit)
via c7938f5f86ca4d54e230af415ecae87eda38a324 (commit)
via 76da06b6a30a8df29353fa5fabc825e609b2a0d7 (commit)
via d80421ce855fd9069dbe1e7cd6b1ea42a665899b (commit)
via 9441537e5436b43805d578108ebee0c8394eb5aa (commit)
via d34b54ab6954d4c162d0f83a3cad96e4a61bab2d (commit)
via cd742a15dd0a889b158f4e841918175763ae83f9 (commit)
via 20431a03360583b705d3e2b2e3a60b2ff1f29474 (commit)
from fa3829b120c1909dd1a1408392c3f27479779b03 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6ba108f4eb18eb27a1b8be55b33b4e28df4b806f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Oct 15 13:01:50 2020 +0000
Bug 26439: (QA follow-up) Correct MSG instances in cart.js
To test, add some items to the cart in the staff interface and open the
cart window. Test the "Selected items" links (Remove, add to list,
etc.) without checking any checkboxes. You should get an alert, "No item
was selected."
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ceee890899c54e113a0a787016ae52e40f3817bb
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 11 19:17:10 2020 +0000
Bug 26439: Move cart-related strings out of js_includes.inc and into basket.js
This patch moves strings defined for translation in js_includes.inc
into basket.js for translation using the new double-underscore
i81n function.
To test, apply the patch and perform a catalog search in the staff
client.
- Click the Cart link in the header menu. A pop-up should appear saying
"Your cart is currently empty."
- On the search results page, click the "Add to cart" link next to any
search result. The text should change to "In your cart."
- Click the "Remove" link. The text should change to "Add to cart."
- Check the box next to a title in the search results and click the "Add
to cart" button in the search results toolbar. A message should
appear, "1 item(s) added to your cart."
- Click the "Add to cart" button again. You should see the message "No
item was added to your cart (already in your cart)!"
- Uncheck all check boxes on the search results page and click "Add to
cart." You should see "No item was selected."
- Add more items to your cart so that it contains more than one item.
- Click the "Cart" link to open it.
- Click the "Empty and close" button. You should be asked to confirm,
"Are you sure you want to empty your cart?"
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/basket.js for
translation, e.g.:
msgid "Your cart is currently empty"
msgstr ""
- Edit the "msgstr" string however you want (it's just for
testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a8e5d9ab9f3dc690f007bb6893af71edf26a473f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Sep 25 00:24:29 2020 +0200
Bug 19351: Add items.copynumber to the checkouts table
This adds the items.copynumber to the checkouts table in the
patron account in the staff interface.
To test:
- Apply patch
- Check out some items with and without copy number in the item
to any patron
- In the checkouts table on the Checkouts and Details tabs:
- Verify that a new column shows 'copy no' shows after 'call no'
- Verify the information displays correctly
- Verify that the column configuration settings for the new column works
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 973e1b1d5d3d381e90bd405d220e7d418ca1c818
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Sep 17 11:52:10 2020 +0000
Bug 15780: Add inventory number to checkout list on summary print
This will add the inventory number to the list of checkouts that
can be printed using the 'Print summary' feature from the patron
account in staff.
To test:
- Apply patch
- Make sure you have some items with and without inventory number set
- Check them out to any patron
- Go to Print > Print summary
- Verify the inventory number column is showing up and the numbers
show with their items.
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d1f412bd76adb4ec54db3b5991b03e9fb2bdecd2
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Sep 21 12:21:23 2020 +0000
Bug 21882: Show price information in acqusitions tab on staff detail page
This adds a new 'Price' column to the acqusition details tab.
To test:
- Apply patch
- Add one or more orders for a record.
- Before closing the basket: go to the detail page in the catalog
- Verify that the price estimated/budgetet price now shows in a new column
- Add actual cost to the basket or close the basket and receive the item
- Verify the column now shows the updated actual cost
- Verfy the tooltip on the table heading works
- Verify the column configuration for the new column works as well
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3ef31a0b77133e4c3eacc1c7d46d917746e438d7
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Oct 15 13:33:29 2020 +0000
Bug 26572: (QA follow-up) Escape strings in autocomplete
This patch updates the construction of the autocomplete dropdown so that
values are escaped.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 38507b041ba3a448315d91294f032267679810bd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 29 11:12:31 2020 +0000
Bug 26572: Add autocomplete to librarian field in log viewer
This patch adds patron autocomplete to the librarian field in the log
viewer search form.
Also changed: Some HTML markup errors in the template have been
corrected: Labels with invalid corresponding ids or with no valid id.
To test, apply the patch and go to Tools -> Log Viewer.
Type a name or cardnumber into the "Librarian" form field. This should
trigger an autocomplete dropdown.
Select a patron and confirm that the field is populated with the correct
borrowernumber.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c2293d5c602b27b8f88d64d15eaa4de94e6bc16c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jul 13 10:25:02 2020 -0300
Bug 21111: Add --exclude-indexes to koha-run-backups
This patch adds a trivial switch so koha-run-backups can pass the
--exclude-indexes option switch to koha-dump. This way if the sysadmin
doesn't want to backup the Zebra indexes, it can be controlled by
tweaking the cron definition.
To test:
1. Apply this patch
2. Run:
$ debian/scripts/koha-run-backups --days 2 --output /var/spool/koha
3. Notice the size of the backups:
$ ls -lh /var/spool/koha/kohadev
4. Try the new option switch:
$ debian/scripts/koha-run-backups \
--exclude-indexes \
--days 2 --output /var/spool/koha
5. Repeat 3
=> SUCCESS: Backups are smaller!
6. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
JD amended patch: fix --exclude_indexes vs --exclude-indexes in koha-run-backups.xml
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee028855c246b1496003fbfccfd20042594ac4bf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Sep 13 21:45:25 2020 +0000
Bug 15329: Add new column for budget to the late orders table
The table currently displays the fund, but as late orders can be
from a past budget with the same fund names, this can be confusing.
So adding the budget in addition to the fund will be helpful.
To test:
- Add a basket and an order, close the basket
- Go to the late oder page
- Make sure your order shows up there
- Apply the patch
- Reload the late orders page
- Verify a new column budget shows in the table
- Verify the table configuration settings work for the new column
- Run t/db_dependent/Koha/Acquisition/Fund.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 42ab7b80d4f1d13e15f991d3c4fa161ffca0726f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Sep 13 16:07:44 2020 +0000
Bug 15141: Add MARC21 770/772 Supplement (parent) to OPAC and staff detail pages
Adds the 2 corresponding linking fields to the staff and OPAC detail pages:
770 - Supplement/Special Issue Entry (R)
https://www.loc.gov/marc/bibliographic/bd770.html
772 - Supplement Parent Entry (R)
https://www.loc.gov/marc/bibliographic/bd772.html
To test:
- Catalog records with 770/772 in Koha, examples can be found in the LOC
documentation.
- When UseControlNumber is set to Use and $w is added, a link will be built using $w
- If there is no $w or UseControlNumber is Don't use, a link will be build using the title
- Verify that they display nicely in the OPAC and staff detail pages
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 043f3f0fd022b70323e2e681b3560bf0915fe845
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 14 12:45:01 2020 +0100
Bug 24834: (follow-up) Improve breadcrumb
This patch updates the breadcrumb navigation to be consistent for View,
Edit and Run with the report name (and id in brackets) appropraitely
placed in the breadcrumb with a link back to the view and the 'Action'
clearly listed as the final part of the breadcrumb path.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f2876ef4d481cd037b2b08a3240f14e44f0882f5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 14 08:49:50 2020 +0100
Bug 24834: (QA follow-up) Add missing filter
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f0b3bbb3276741961d5e8e8da88aa3076b255eeb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Sep 24 23:35:19 2020 +0200
Bug 24834: (follow-up) Add report id to page titles
See test plan of previous patch!
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7f2e2a4dbdaf066cf6002ad1d6f1241273ce5705
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Sep 21 12:46:48 2020 +0000
Bug 24834: Display report number on editing or running a report
The only place the report ID was shown when editing or running a
report was in the URL. With this patch, we also show it in the
heading, the breadcrumbs and the page title.
To test:
- Create a new SQL report.
- Save the report.
- Edit the report.
- Verify that the report id now shows in the breadcrumbs and page title.
- Run your report.
- Verify the report id shows in the page heading, title and breadcrumbs.
Signed-off-by: Michael A <madamyk at ckls.org>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4dd798302a84acf5d4474affeaa61fc9c97ed68a
Author: David Cook <dcook at prosentient.com.au>
Date: Sun Oct 11 23:47:45 2020 +0000
Bug 26641: Optimize CatalogModuleRelink lookup
This patch moves the CatalogModuleRelink lookup outside the loop to
improve performance (especially for large databases), and includes a
tester friendly test plan.
Test plan:
0. Using koha-testing-docker
1. koha-shell -c "./misc/link_bibs_to_authorities.pl -l --test" kohadev
2. Note 436 bibs checked, 1315 headings linked, 676 headings unlinked
3. koha-shell -c "./misc/link_bibs_to_authorities.pl -l --test -g 700" kohadev
4. Note 436 bibs checked, 248 headings linked, 111 headings unlinked
5. Note output appear to all be names (rather than subjects or other authorities)
6. Note also that the 2nd run with -g 700 is almost 2x faster than without
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ab2e3b0e890a45202a9c360f444917a0ff336d50
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Fri Oct 9 13:39:52 2020 +0200
Bug 26641: pass the MARC field as an argument to link_bibs_to_authorities.pl
When running link_bibs_to_authorities.pl, it could be useful to have
the ability to specify which MARC field the script should operate on.
For example, when you have a catalog where most links are in place,
and you don't want the script to process every MARC field but rather
limit it to a specific MARC field (e.g. 700) because you've observed
that there are many missing links for that particular MARC field.
This patch provides that enhancement.
Test plan:
1) Run the script as follows (preferably in a test DB):
time link_bibs_to_authorities.pl -v -l --test
... and notice how long it takes to complete.
2) Apply the patch.
3) Run the script again, this time providing the MARC field to work on:
time link_bibs_to_authorities.pl -v -l --test -g=700
... and, again, notice how long it takes to complete.
The 2nd run should run faster than the 1st one.
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 96be711d0333a531051cdbd6f194a2eb05071c60
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 4 10:57:45 2020 +0100
Bug 21898: Add basket for TT syntax
Without this patch the basket's info won't be available for the TT
syntax.
With this patch you can now use [% basket.basketname %]
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 98ab9863929799a8e42f7b8ce23ba5d70c822b14
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 1 09:04:43 2020 +0100
Bug 21898: Add aqbasket to available tables for ACQORDER
This patch should allow <<aqbasket.$field>> replacements to work in both
email subject and email content fields for notices.
Test plan
1/ Add <<aqbasket.basketname>> into the ACQORDER notice (In the subject
line and content box)
2/ Trigger said notice to send (before applying the patch)
3/ Note that the replacements have not taken place..
<<aqbasket.basketname>> is present as is.
4/ Apply patch
5/ Trigger the notice again
6/ Note that the replacements are now made.
7/ Signoff
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
JD amended patch: fix alignment in hashref, edit commit message to fix
letter code "AQORDER" vs "ACQORDER"
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3bfc54d44a53a4235e171858f75a6fc4bdc3eb9c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Oct 17 14:14:00 2020 +0200
Bug 26680: Acq - Wrap (rcvd) in a span and change text to received
The new span with the class order-received will allow to have
individual styling on the term to make it stand out more in the
list of order lines of a basket. The text change will ease translation.
To test:
- In acquisitions:
- Create a new basket
- Add at least 2 order lines
- Close the basket
- Receive a new shipment and one of your order lines
- Go back to your basket
- One line should now show "(rcvd)"
- Apply patch
- Reload the basket page
- Verify the text has changed and element now has a class in the
HTML source
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Oct 17 22:47:49 2020 +0000
Bug 26190: Allow to close a basket with only cancelled order lines
At the moment there are several cases, when closing a basket is not
possible:
- when there are no order lines in it
- when there are order lines with uncertain prices
- when the basket is marked as a standing order
The first case wasn't checked correctly as only pending/received
orders would be counted, but not cancelled orders.
To test:
- Create a basket
- Create an order line
- Verify the "close this basket" button shows
- Cancel the order line - the button disappears
- Apply the patch
- Verify the button appears and works now
- Create another basket - make sure you cannot close it
without order lines
- Create an order line with uncertain price checked
- you cannot close it
- Resolve the uncertain price - you can now close the basket.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a27c22bffc2fbd48951192dbff846b35766d4123
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Oct 17 14:04:33 2020 +0200
Bug 26718: Rename "reading history" to "checkout history"
This changes all occurences of reading history to the more
accurate term 'checokut history' as it was correctly pointed out
that 'reading' doesn't apply to all kind of items available
at the library (audio books, games, etc.)
To test:
- Verify that the term reding history has been replaced by checkout
history in:
- System preferences
- OPAC tab "your checkout history"
- OPAC tab "your privacy" (switch OpacPrivacy pref first)
- Staff permission for patron batch anonymization
Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e42b4088ed83eb093389f3f5a841095ecc8f036f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 7 13:15:36 2020 +0000
Bug 26180: Add descending option to rebuild_elasticsearch.pl
While the ES index is incremental and provides results as it commits, we currently index from the oldest records to the newest.
This patch provides the option to go the other direction
To test:
1 - Have ES setup and running for Koha
2 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b
3 - Note the biblios index from number 1 the end
4 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a
5 - Notice the same
6 - Apply patch
7 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b
8 - Still in ascending order
9 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b --desc
10 - Now records index in descending order
11 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a
12 - Still ascending
13 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a --desc
14 - Now descending
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
JD amended patch: fix typo "inde" vs "index" and add commit body
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 018720aa5e0c82ad52821789f8878905f1d9affb
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Oct 22 12:27:17 2020 +0000
Bug 12533: (follow-up) Add CSS to preview display of authority MARC
This patch adds the same CSS used by authorities/detail.tt to the
modal preview of the authority record shown in the authorities search
result popup.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 66289610fa34574e09bd25a95c104a5c03a9cc7f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Oct 21 13:04:42 2020 +0000
Bug 12533: Improve authority search result display
This patch implements a few changes in the way authority records are
displayed in search results.
- In most cases heading type is now displayed as a separate column in
the table of search results.
- The heading itself is now linked rather than a separate "details"
link.
In the authority search results for MARC editor plugins the heading link
triggers a modal with the authority details instead of linking to a
separate page.
To test, apply the patch and go to Authorities.
- Perform an authority search which will return results.
- In the search results headings should be linked to the
corresponding detail page.
- There should be a separate column for heading type.
- Go to Cataloging and create a new record using a framework which has
a field linked to an authority type (e.g. 100a -> PERSO_NAME ).
- Perform a search which will return results.
- In the search results, clicking a heading link should trigger a
modal window with the authority details.
- Test multiple entries in the results and confirm that each
time the correct data is loaded into the modal window.
- Test the same process for a field which is linked to the
unimarc_field_210c.pl plugin.
- Go to Tools -> Batch record modification and submit multiple
authority record numbers.
- In the results list the heading should be linked correctly to the
corresponding detail page. Heading type is not present in this
view.
- Perform the same test with batch record deletion.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0ddb841d22a41fafee5164967ef8ec449cae06dc
Author: Tal Rogoff <tal.rogoff at cass.govt.nz>
Date: Fri Oct 23 23:39:06 2020 +0000
Bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations
test plan:
1.Drop and recreate database
2.Go through web installer
3.Observe that "OpacRenewalAllowed" is set to "Don't Allow"
4.Apply patch
5.Repeat steps 1 and 2
6.Observe that "OpacRenewalAllowed" is now set to "Allow"
sponsored-by: Catalyst
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c65e7ba177e37125de208d9612b74cc9ad3d2b52
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Aug 19 12:32:08 2020 +0100
Bug 22394: Remove C4::Accounts::manualinvoice
This patch removes C4::Accounts::manualinvoice and it's corresponding
test. We have been warning deprecation of this method for 18 months (by
the time of 20.11 release).
Test plan
1/ Apply patch
2/ Ensure no mention of manualinvoice accross the codebase
3/ Run t/db_dependant/Accounts.t and ensure it still passes
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9a113663820634d2d718c8a979e8e70f64b8744a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 22 16:26:03 2020 +0100
Bug 12656: Allow --reason to be passed to cancel_expired_holds
This patch adds the --reason option to cancel_expired_holds which allows
the library to optionally set a reason for cancellation when running the
cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the
patron.
To test:
1/ Ensure the unit tests continue to pass after the patch
(t/db_dependent/Reserves/CancelExpiredReserves.t)
Also:
1 - Add an expired hold for a patron:
INSERT INTO RESERVES (borrowernumber, biblionumber, expirationdate, found,branchcode,itemnumber) VALUES (5,5,'2020-01-01','W','CPL',983);
2 - Set ExpireReservesMaxPickUpDelay to Allow
3 - Run the cronjob:
perl misc/cronjobs/hold/cancel_expired_holds.pl --reason EXPIRED
4 - Visit the patron's notices tab
5 - Confirm they have been sent a cancellation notice
Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b5dc71be2ee6d49335d9b4ee79edcf68882c555d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Oct 19 10:35:20 2020 +0000
Bug 25941: (follow-up) Add markup comments
This patch adds comments to the template to highlight the markup
structure.
This patch should have no effect on the page's appearance or
functionality.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f010b8fd168a10cd380131fc2bb5360538524655
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Oct 16 19:03:13 2020 +0000
Bug 25941: Reindent Upload local cover image page
This patch reindents the "Upload local cover image" template to make
indentation consistent. Some lines have been split up. Some markup
inconsistencies have been corrected.
To test, apply the patch and enable the LocalCoverImages system
preference.
- Go to Tools -> Upload local cover image.
- Test uploading single images or ZIP files of images.
- Confirm that everything works as expected.
Use your preferred method for checking the differences between files
while ignoring whitespace. I use diff with the "-w" flag, but I'm not
some kind of diff deity. The only changes you see should be split lines.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 579608808c4ec81f469e4c48627525d17a16194d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jul 14 18:46:19 2020 +0000
Bug 22399: Improve responsive behavior of the basic marc editor
This patch makes markup and style changes to the basic MARC editor in
order to improve the page's handling of smaller browser widths. It adds
flexbox styling to elements of the form to help accomplish this.
To test, apply the patch and load a record for editing in the basic MARC
editor.
- Adjust your browser width and confirm that the form adjusts well
to various widths.
- Test that the markup changes haven't broken the JavaScript-driven
features in the editor:
- Clone tags
- Delete tags
- Expand and collapse tags
- Clone subfields
- Delete subfields
- Re-order subfields
- Cataloging plugins:
- Focus-driven plugins like on tag 000
- Popup plugins like 008 or authority-linked tags
- Select2-styled dropdowns (e.g. 942$c Item type).
- Test the add/edit items form to confirm that it is still styled as it
was before.
Edit: The Select2 plugin JavaScript file now accepts a variable to set
the "width" configuration option. It still defaults to "element."
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b1e2693ce529a7af2646ba770269cf32e991ff7d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Oct 21 12:07:19 2020 +0000
Bug 26763: Use standard information style for multi-hold message
This patch modifies the markup of the message which is displayed when
the patron tries to place a hold on a title they already have a hold on.
Now the message is styled consistently with other similar messages.
To test, apply the patch and follow the steps used to test Bug 19718:
- In Administration -> Circulation and fine rules, set a rule to allow
multiple holds on a title.
- Log in to the OPAC as a user covered by the above rule and locate
a bibliographic record on which multiple holds can be placed.
- Place a hold on the record.
- Return to the record details for that title and place another hold.
- You should see a correctly-styled message about having at least one
other hold on the record.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 657df01fec106e9a0e2afee7518c8b95537c93d4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 4 11:53:04 2020 +0000
Bug 19482: DBRev 20.06.00.059
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dcbc856b60436aa1341beb7da75ac3665d4e5f92
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Sun Oct 25 02:16:42 2020 +0000
Bug 19482: (follow-up) Fix update, add tests, restore closing </td>
To test:
1 - View the mappings page, confirm table is correctly structured
2 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t t/db_dependent/Koha/SearchField.t
3 - Confirm update statement works and table is ordered correctly
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dbe8c14bbf3ff8a3bc2daa07ab52e02e2a28ef77
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Oct 16 16:13:32 2020 +0000
Bug 19482: (follow-up) Don't set readonly as a variable, use conditionals
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5f498d250cdbe50bede11a1e550f385de6ae3d06
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Oct 16 14:37:24 2020 +0000
Bug 19482: DBIC schema changes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 37a7a1bb5042e839151185aa40449cad9c6260b6
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Oct 16 14:30:00 2020 +0000
Bug 19482: (follow-up) Add missing filters and boolean switch to schema
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 52be44f406e108544f21e6d45055a9ea9e86c075
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 18 11:32:51 2020 +0000
Bug 19482: (follow-up) Fix select and adjust export of new field
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 975e06bd7c3e198048c60d4a0f9968ba89079de7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 18 13:06:22 2017 +0000
Bug 19482: Add support for defining 'mandatory' mappings
To test:
1 - Apply patch
2 - ./installer/data/mysql/updatedatabase.pl
3 - Reset ES mapping: Administration->Search engine configuration , button at bottom of page
4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and not editable
5 - On 'Bibliographic records' tab you should not be able to delete the single entry for issues
6 - You should be able to delete 'title' mappings, however, at the final one you should be stopped by javascript
7 - Bonus: force remove the last mapping from the page using developer tools - attempt to save and should be warned of missing mandatory mapping
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 14f99da17c38ca352939be48eae0a11523e787e0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 18 13:05:40 2017 +0000
Bug 19482: DB changes
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4e3bcc9a2578b3821ff8f39554976fb7b76456db
Author: Lisette Scheer <lisettes at latahlibrary.org>
Date: Sat Oct 24 19:45:28 2020 +0000
Bug 25834: Relabel "Search to add" to "Add guarantor" on patron form.
The "search to add" label on the button for adding guarantors is a bit
hard to translate and is inaccessable. This patch updated the button
label to "Add guarantor" to fix these issues.
To test:
1. Go to patrons
2. Add a new child patron
3. Observe the button with "search to add"
4. Save the patron
5. Edit the patron and observe the "search to add" button.
6. Apply patch.
7. Add a new patron
8. Observe new text on button.
9. Edit a child patron
10. Observe new text on button
11. Sign off
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6f272a16b2eb6d200402489b26435eea282ec622
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Fri Oct 23 18:17:49 2020 +0200
Bug 26803: Fix PLUGIN_DIR when plugin_dirs is multivalued
When plugin_dir koha-conf.xml parameter contains more than one
directory, PLUGIN_DIR parameter sent to templates doesn't contain the
proper value, ie the base directory of the current plugin.
See bug 23237
Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 617a012a4cbe1e8ada09c0db3d8e464c36b97255
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 3 15:28:56 2020 +0100
Bug 23979: Remove final dot
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 291df4e09206399f4de26ef0214db2b8784c9e20
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Oct 6 16:00:30 2020 +0000
Bug 23979: Move locked message to patron info section
To test:
1 - Set failed login attempts to some number
2 - Attempt enough logins with a patront o lock them, or:
UPDATE borrowers SET login_attempts = 500 WHERE borrowernumber=5;
3 - Attempt to checkout to borrower, no notice of lock
4 - View patron details tab, see the locked message
5 - Apply patch
6 - Note the message is now in patron info and visible on all tabs for the member
Signed-off-by: George Williams <george at nekls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 93c66100733db0aea73a3e59841981e4ee85e717
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Mon Jan 20 15:44:44 2020 +0100
Bug 20888: (follow-up) revert unecessary change on jquery selector
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cb4df3b29a57b62b82cf7652b40d30aea4a92d9b
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Mon Jan 20 15:36:21 2020 +0100
Bug 20888: (follow-up) 'is not' operator behaves as 'not like'
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 781b5a41188c958213f409310f38ba49dcd13159
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Thu Jan 10 10:48:38 2019 +0100
Bug 20888: Allow use of boolean operator 'not' in item search
Test plan:
- Apply the patch
- Check that you have a 'is not' option in the third box in item search
- Check that you can exclude items from the search results with this 'is not' option
- Check that you can still combine parameters with 'and' and 'or'
- Check that the exclusion works for custom fields (see Administration > Item search fields)
- Check that the exclusion works for custom fields linked to authorised values
Signed-off-by: Amandine Zocca <azocca at ville-montauban.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d80763c3714457bf14fd585513ab07d02b82c819
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Oct 27 15:02:43 2020 +0000
Bug 26825: Add span for publication date in OPAC
This patch modifies the XSL templates for OPAC results and OPAC details
so that the parts of the publisher details are wrapped separate <span>s:
Publisher place, name, and date.
To test, apply the patch "restart_all" if necessary.
You can add this to the OPACUserCSS system preference to better see the
change:
.publisher_place { color: red; }
.publisher_name { color: green; }
.publisher_date { color: orange; }
- Peform a search in the OPAC
- In the search results, confirm that the publisher plac, name, and date
are wrapped in separate <span>s, either by confirming the custom
colors or by inspecting the source.
- View the details for one of the results. Confirm that the same change
has been made to the detail page.
Signed-off-by: B Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d23c58e9084176fac3e64b8edbbaa64ddcc164d4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Oct 26 23:12:11 2020 +0000
Bug 16696: Rename 'Publisher' to 'Publication details' on detail and result lists
To test:
1) Do a catalog search in staff client
2) Confirm 'Publisher' says 'Publication details' for each result in search
3) Click on a record to go to the detail page
4) Confirm 'Publisher' says 'Publication details'
5) Click the Items tab on the left
6) Confirm 'Publisher' says 'Publication details'
7) Do a search in the OPAC
8) Confirm 'Publisher' says 'Published' for each result in search
9) Click on a record to go to the detail page and switch to the items tab
10) Confirm 'Publisher' says 'Publication details' on top of the page
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bd0674ac1009420ba94fb005560e11c883003d73
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 28 12:34:01 2020 +0000
Bug 26844: Add warning to disabled logs on log viewer
To test:
1 - Go to Admin->System preferences->Logs tab
2 - Make sure some logs are disabled
3 - Go to Tools->Log viewer
4 - Note you can select logs that are disabled
5 - Apply patch
6 - Reload page
7 - Note disabled logs have a warning icon and hover text
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9cbbd6b2ca436990f51b8d1b1985074c2620259c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 30 12:10:03 2020 -0300
Bug 26310: (QA follow-up) koha-conf-site.xml.in tweaks
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 55f2279314edf390e6257942a84f9f9b058c84cf
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 27 15:24:58 2020 +0000
Bug 26310: Allow setting trace_to parameter in Elaasticsearch config
For debugging purposes we may wish to see the requests and responses made to
Elasticsearch
To test:
1 - prove -v t/Koha/SearchEngine/Elasticsearch.t
2 - Set <trace_to>Stderr</trace_to> in koha-conf
3 - Restart all
4 - perl misc/search_tools/rebuild_elasticsearch.pl
5 - Note requests are shown
6 - Set
<trace_to>File</trace_to>
<trace_to>/var/log/koha/kohadev/plack-error.log</trace_to>
in koha-conf
7 - Restart all
8 - perl misc/search_tools/rebuild_elasticsearch.pl
9 - Check the plack log and see the ES requests
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e7c134e27e044ad4ebe9a0e4aa220f4a05208215
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Oct 15 10:48:52 2020 +0200
Bug 26687: Add a Font Awesome icon for superlibrarian patrons
Bug 26534 adds a shield Font Awesome icon to help identify staff
patrons. I propose to add an icon when patron is a superlibrarian.
Patch adds 'is-superlibrarian' class that may be used for more CSS
tuning.
Test plan:
1) Compare display between a patron A beeing superlibarian and a patron
B having only staff interface access
2) Patron B has only shield icon
3) Patron A has shield icon and bolt icon
4) Check a patron without permissions has no shield icon
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e91b565055892e6c79cd842a975efd83bd566f52
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Oct 26 12:31:16 2020 +0000
Bug 26817: Change checkouts table footer colspan based on ExportCircHistory
This patch makes a minor change to the include file which generates the
checkouts table footer. It now includes some logic checking for the
ExportCircHistory system preference, adjusting the colspan accordingly.
To test, apply the patch and enable the ExportCircHistory system
preference.
- Check out to a patron who has checkouts. In the table of checkouts
there should be an "Export" column. The footer at the bottom of the
table should span the width of the table.
- Disable the ExportCircHistory preference.
- View the checkout page again and confirm that table footer still looks
correct.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0833724afe7cb0d2f2db32c7e87f3df064e6a016
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Oct 26 10:49:49 2020 +0100
Bug 26032: (follow-up) show 'is new' filter only if items.new_status is used
Also adds a class 'item-new-status' to this filter to be able to hidde
even if items.new_status used.
Addition to test plan:
1) Apply on a database without Koha to MARC mapping on items.new_status
2) Check you dont see the 'is new' filter in items search form
3) Apply on a database with Koha to MARC mapping on items.new_status
4) Check you see class 'form-field item-new-status'
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 07cab93d5d9bd292368e097305f309419e746e2f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Oct 16 10:45:41 2020 +0200
Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE()
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8a874de3f42ef02d0eb9e7e8512f952da5a7152a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Jul 21 11:43:55 2020 +0200
Bug 26032: Add 'is new' filter in items search
In items search, add a filter on value of items.new_status with a Ignore/Yes/No.
Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0.
This patch adds 'isnull' option to filter, this may be reused on other
fields.
Test plan :
1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1)
2) Edit an item A to set new_status=1
3) Edit an item B to set new_status=0
4) Perform an item search with 'is new' = 'ignore' => you get all items
5) Perform an item search with 'is new' = 'yes' => you get item A
6) Perform an item search with 'is new' = 'no' => you get all items but A
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5da551a6a219436b001ebb0dd35b98414de1d378
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Jul 21 12:26:55 2020 +0200
Bug 26032: Add unit test
Run prove t/db_dependent/Items.t
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 77365090f57fe83eff37402f6dcc725fdee00c92
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 4 11:53:04 2020 +0000
Bug 25333: DBRev 20.06.00.058
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 80bf7abb5cd309ae28cd588df9037231e11683e5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Nov 1 03:45:56 2020 +0000
Bug 25333: (QA follow-up) Change phone to itiva on overduerules.tt
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e0b41a7c5a9634c3229b25424dd449e0bebcf6f6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Oct 29 14:17:55 2020 -0400
Bug 25333: (QA follow-up) Update opac messaging for new transport name
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ebbee18822f73c8e8f2236b13a66ba653bebe03f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 30 14:09:02 2020 -0400
Bug 25333: Change message transport type for Talking Tech from "phone" to "itiva"
From its inception, phone notices via Talking Tech have not behaved like
other notices. Instead of reading notices generated by Koha, the Talking
Tech scripts largely generate their own notices.
We would like to pave the way to having "generic" phone notices that can
be processed by plugins to support arbitrary telephony vendors ( we will
be targeting Twilio initially ).
To that end, it seems sensible to begin by changing the messaage
transport type for Talking Tech from 'phone' to 'itiva' to
highlight its specificity and difference from standard message
transports.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Test Talking Tech outbound script
5) Note no changes in functionality
Signed-off-by: Christopher Zorn <Christofer.Zorn at ajaxlibrary.ca>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
JD amended patch: remove uneeded indentation change in sample_notices_message_transports.sql
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 301528d6df117f9183d09189d7a596cdf431f77e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Nov 2 15:16:40 2020 +0000
Bug 25469: Typo: Item does not belongs to your library
This patch makes corrections to two strings in the batch delete template
to correct a typo. Before:
t("Item does not belongs to your library")
...after,
t("Item does not belong to your library")
To test, apply the patch and inspect the template to confirm that the
string is correct.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4cf9a59b400a97b51ab25720eaf40c60d81e2d42
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Nov 1 02:02:04 2020 +0000
Bug 24012: (QA follow-up) Use standard patterns
- Removes the scss change in favor of adding the space to the
HTML as is the usual pattern when using Font Awesome icons
- Removes the span with the inline style to make things appear as
black by default (no danger here in it being locked?)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a1c5c5b060115f9e025fce17d602509738319b90
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Sat Oct 24 18:02:59 2020 +0000
Bug 24012: Budget 'Locked" text colour changed and lock icon added
Test plan:
1. Go to Administration
2. Click on Budgets
3. Add a new bdget and check the 'Lock budget' box
4. Click on the 'Inactive budgets' tab
5. Note that 'Locked' is displayed in green
6. Apply patch
7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running:
yarn build
8. Refresh the page and notice the 'Locked' text is now red, and there
is a lock icon to the left of the text. There is a space between the
lock icon and the 'Locked' text.
Sponsored-by: Catalyst IT
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8ccc73353c651659c7e0816bfa57fe2d7b8d82b5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Nov 3 08:09:22 2020 +0000
Bug 25897: (QA follow-up) Add filters
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b72de018132acaae77ebc3852ed369cf45edc8fb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Oct 19 00:38:31 2020 +0000
Bug 25897: Use cn_sort for sorting callnumbers in inventory table
Instead of using the machine sortable form of the callnumber from
cn_sort the table was only sorting on the callnumber. This tries
to fix it using the same technique as for sorting the differently
formatted dates.
To test:
- If your database has items with suitably cataloged items, use
these. Otherwise you could use the examples from the bug report:
- Catalog items with the following barcodes:
B 29 V55 1998
B29 .C55 2008
B29 .L24 1983
B29 .L264 1998
B29 .P666 2004
Make sure the LOC is selected in $2 as source of classification
This makes sure the sortable form of the callnumber is calculated
correctly.
- Go to inventory
- Search for your items
- Before patch, they should sort on callnumber as above, after the
patch the correct sort order should be:
B29 .C55 2008
B29 .L24 1983
B29 .L264 1998
B29 .P666 2004
B 29 V55 1998
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8ba1d7a22b2fccb093fcdb9f20b6bf2dfec04e91
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Nov 3 08:09:35 2020 +0000
Bug 26664: (QA follow-up) Add filters
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9adafd6404cfdc3f1fc52445e32d8f8b121ccc4e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Oct 5 17:48:45 2020 +0000
Bug 26664: Fix sorting for date last seen in inventory tool
This adds the standard datatable sorting for dates to the inventory
table as described here:
https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference
To test:
- Go to the inventory tool
- Search for a big sample list of items with different date last seen
- Sort the table now by "date last seen" by clicking on the table header cell
- Try different settings of the DateFormat system preferences
- Verify sorting is incorrect (alphabetic, not by date)
- Apply patch
- Repeat testing and very all is sorting correctly now
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c7938f5f86ca4d54e230af415ecae87eda38a324
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 4 11:53:04 2020 +0000
Bug 26638: DBRev 20.06.00.057
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 76da06b6a30a8df29353fa5fabc825e609b2a0d7
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Oct 17 16:02:55 2020 +0000
Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly
The preference was probably added because of a typo, as there is a
used system preference ArticleRequestsMandatoryFieldsItemOnly
(Item vs Items).
This patch fixes the situation:
- syspref.sql had the pref name with the typo, this is fixed.
- A database update removes the unused variable and makes sure
the used one is added.
To test:
- Look at the local use system preferences, verify the false pref is there
- Look at the other ArticleRequests* preferences, verify the other without "s"
is there
- Apply patch and run database update
- Verify the local use tab one is gone now
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d80421ce855fd9069dbe1e7cd6b1ea42a665899b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Oct 26 22:40:50 2020 +0000
Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference
The mapping in the itemcallnumber system preference is only valid
for MARC21 libraries using DDC classification, but not for libraries
using UNIMARC or other classification.
This patch suggests to remove the default mapping and start new installations
with an empty value.
To test:
- On an emtpy database
- Apply patch
- Run the web installer, selecting either MARC21 or UNIMARC
- Verify that the itemcallnumber system preference is empty
- Verify the description now also include examples for UNIMARC
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9441537e5436b43805d578108ebee0c8394eb5aa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Oct 27 09:03:16 2020 +0100
Bug 26832: Make Elasticsearch mappings export use UTF-8
Script misc/search_tools/export_elasticsearch_mappings.pl allows to export current search engine configuration into a YAML file.
This export should use UTF-8 encoding, like other exports.
Test plan :
1) Go to Administration > Search engine configuration (Elasticsearch)
2) Edit a field label to use a diacrtic, for example local-number => Numéro
3) Save
4) Edit file etc/koha-conf.xml to enable 'elasticsearch_index_mappings'
5) Export mappings to file via misc/search_tools/export_elasticsearch_mappings.pl -t $MARCFLAVOUR
6) Reset memcached and plack
7) Back to Administration > Search engine configuration (Elasticsearch)
8) Click on 'Reset Mappings' and accept
9) Look at field 'local-number'
=> Without patch diacritic 'é' is broken
10) You may try with an emoji B-)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d34b54ab6954d4c162d0f83a3cad96e4a61bab2d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Nov 3 10:35:17 2020 -0300
Bug 26738: (QA follow-up) Add missing filter
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cd742a15dd0a889b158f4e841918175763ae83f9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 2 15:01:32 2020 +0100
Bug 26738: (bug 24819 follow-up) Fix manager selection
Bug 23590 added a new feature to select the manager of a suggestion.
One month later bug 24819 added the ability to pick the suggester.
This second patchset broke the manager selection.
This patch simplifies the way the suggester is selected, using the
generic way and mimicking what is done for the manager.
Test plan:
- create a new purchase suggestion from within acquisitions (suggestion.pl?op=add)
- click "select manager," search for user, click Select
- see that the user you just selected shows under "Created by,"
- see that "Managed by" still says "You"
- modify the suggester
- save your suggestion
=> Everything is saved correctly
QA will test the permission alert:
Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage"
Edit the suggestion, select a manager, pick a patron in the list who
does not have sufficient permissions, save
=> you get the alert
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 20431a03360583b705d3e2b2e3a60b2ff1f29474
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Nov 2 09:50:42 2020 -0500
Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds
It appears that at some point, the actual blocking of checkins on items
with holds got lost from the patch set. This slipped by because the sip
server still outputs everything correctly, but the unit tests don't
actually test to see if the checkout still exists afterward!
Test plan:
1) Apply this patch
2) Prove t/db_dependent/SIP/Message.t
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Accounts.pm | 76 ------
C4/Biblio.pm | 4 +
C4/Items.pm | 12 +-
C4/Letters.pm | 12 +-
C4/Reserves.pm | 6 +-
C4/SIP/ILS/Transaction/Checkin.pm | 10 +-
Koha.pm | 2 +-
Koha/Acquisition/Fund.pm | 16 ++
Koha/BiblioUtils.pm | 7 +-
Koha/MetadataRecord/Authority.pm | 7 +-
Koha/Plugins/Base.pm | 18 +-
Koha/Schema/Result/SearchField.pm | 17 +-
Koha/SearchEngine/Elasticsearch.pm | 5 +-
acqui/basket.pl | 2 +-
admin/columns_settings.yml | 8 +
admin/searchengine/elasticsearch/mappings.pl | 9 +-
admin/searchengine/elasticsearch/mappings.yaml | 2 +
api/v1/swagger/definitions/patron.json | 2 +-
catalogue/itemsearch.pl | 9 +-
debian/docs/koha-run-backups.xml | 7 +
debian/scripts/koha-run-backups | 17 +-
debian/templates/koha-conf-site.xml.in | 2 +
etc/koha-conf.xml | 2 +
installer/data/mysql/kohastructure.sql | 5 +-
.../mysql/mandatory/message_transport_types.sql | 2 +-
.../sample_notices_message_transports.sql | 6 +-
installer/data/mysql/mandatory/sysprefs.sql | 14 +-
installer/data/mysql/mandatory/userpermissions.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 32 +++
koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 103 ++++++--
.../en/includes/authorities-search-results.inc | 6 +-
.../prog/en/includes/checkouts-table-footer.inc | 8 +-
.../prog/en/includes/checkouts-table.inc | 1 +
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 18 +-
.../intranet-tmpl/prog/en/includes/js_includes.inc | 17 --
.../prog/en/includes/messaging-preference-form.inc | 22 +-
.../intranet-tmpl/prog/en/includes/permissions.inc | 2 +-
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 +-
.../prog/en/modules/acqui/lateorders.tt | 5 +-
.../prog/en/modules/admin/aqbudgetperiods.tt | 4 +-
.../en/modules/admin/preferences/cataloguing.pref | 3 +-
.../prog/en/modules/admin/preferences/opac.pref | 6 +-
.../prog/en/modules/admin/preferences/patrons.pref | 2 +-
.../admin/searchengine/elasticsearch/mappings.tt | 269 ++++++++++++---------
.../authorities/blinddetail-biblio-search.tt | 214 ++++++++--------
.../prog/en/modules/authorities/detail.tt | 38 ---
.../modules/authorities/searchresultlist-auth.tt | 41 +++-
.../en/modules/authorities/searchresultlist.tt | 7 +-
.../prog/en/modules/catalogue/detail.tt | 3 +
.../prog/en/modules/catalogue/itemsearch.tt | 22 +-
.../prog/en/modules/catalogue/moredetail.tt | 2 +-
.../prog/en/modules/cataloguing/addbiblio.tt | 134 +++++-----
.../value_builder/unimarc_field_210c.tt | 41 +++-
.../prog/en/modules/common/patron_search.tt | 6 +-
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../prog/en/modules/members/moremember-print.tt | 4 +-
.../prog/en/modules/members/moremember.tt | 7 -
.../en/modules/reports/guided_reports_start.tt | 12 +-
.../prog/en/modules/suggestion/suggestion.tt | 30 ++-
.../modules/suggestion/tables/suggester_search.tt | 36 ---
.../prog/en/modules/tools/batchMod-del.tt | 4 +-
.../prog/en/modules/tools/batch_delete_records.tt | 2 +-
.../en/modules/tools/batch_record_modification.tt | 2 +-
.../prog/en/modules/tools/inventory.tt | 11 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +-
.../prog/en/modules/tools/overduerules.tt | 4 +-
.../prog/en/modules/tools/upload-images.tt | 215 +++++++++-------
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 49 ++--
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 88 ++++++-
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 4 +-
koha-tmpl/intranet-tmpl/prog/js/basket.js | 46 ++--
koha-tmpl/intranet-tmpl/prog/js/cart.js | 9 +-
koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 70 +++---
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 +
koha-tmpl/intranet-tmpl/prog/js/select2.js | 2 +-
koha-tmpl/intranet-tmpl/prog/js/suggestions.js | 17 --
koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 28 +++
.../opac-tmpl/bootstrap/en/includes/usermenu.inc | 2 +-
.../bootstrap/en/modules/opac-messaging.tt | 12 +-
.../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 16 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 +-
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 129 ++++++++--
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 34 +--
misc/cronjobs/holds/cancel_expired_holds.pl | 52 +++-
.../thirdparty/TalkingTech_itiva_outbound.pl | 10 +-
misc/link_bibs_to_authorities.pl | 23 +-
misc/search_tools/export_elasticsearch_mappings.pl | 1 +
misc/search_tools/rebuild_elasticsearch.pl | 17 +-
suggestion/add_user_search.pl | 7 +-
suggestion/suggester_search.pl | 57 -----
suggestion/suggestion.pl | 14 +-
svc/checkouts | 4 +-
t/db_dependent/Accounts.t | 30 +--
t/db_dependent/Items.t | 25 +-
t/db_dependent/Koha/Acquisition/Fund.t | 19 +-
t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 7 +-
.../Koha/SearchEngine/Elasticsearch/ExportConfig.t | 4 +-
.../Koha/SearchEngine/Elasticsearch/Reset.t | 6 +-
t/db_dependent/Koha/SearchField.t | 9 +-
t/db_dependent/Reserves/CancelExpiredReserves.t | 26 +-
t/db_dependent/SIP/Message.t | 5 +-
101 files changed, 1515 insertions(+), 943 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt
delete mode 100644 koha-tmpl/intranet-tmpl/prog/js/suggestions.js
delete mode 100755 suggestion/suggester_search.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list