[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-10-g8c527522ec

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  8c527522ec02c4b07c57c5a211d846856c936018 (commit)
      from  d031520710b85061051edc6ed4890aa9374bdf92 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8c527522ec02c4b07c57c5a211d846856c936018
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Oct 2 12:11:48 2020 -0400

    Bug 26604: "Generate next" button gives error on serials-collection.pl
    
    In serials-collection.pl, the line
    
    $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});
    
    causes the error
    
    Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198.
    
    This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down.
    
    Signed-off-by: kelly mcelligott <kelly at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    JD
    
    Test plan:
    1. Create a new subscription
      * When there is an irregular issue: Skip issue number
      * Select a frequency (not irregular)
      * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field
    2. Receive a first serial (mark it arrived, an "expected" one is created)
    3. Claim the expected one
    => You have 1 arrived and 1 claimed.
    It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl
    4. Generate next => boom
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 serials/serials-collection.pl | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository