[koha-commits] main Koha release repository branch master updated. v20.05.00-1849-g64ee6f0b2b

Thu Nov 12 18:01:54 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  64ee6f0b2bbcc9b23520c689146f1c5cf905e997 (commit)
       via  4415fdb0f4785dff24c9773f85a9b32885c385ac (commit)
       via  fbd0bbf98f574a7eb804673978a198eea6fdd798 (commit)
       via  1dadf8823357573b740b0c259f16cf18ab4e8904 (commit)
       via  0423d09e57f6a64656dc0f82a10c82962960e049 (commit)
       via  552ea4e9d27a1d075e009e13bde63b2c91962644 (commit)
      from  cdbc04f69d751d2b08dc256d61972330512c3a0d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 64ee6f0b2bbcc9b23520c689146f1c5cf905e997
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Nov 12 13:36:00 2020 +0000

    Bug 26948: Regression tests

    We already mock the send_or_die method from Email::Stuffer; This patch
    updates that mock to extract the internal representation of the email
    encoded message and looks for a known double encoded representation of a
    character in the sample body.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4415fdb0f4785dff24c9773f85a9b32885c385ac
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Fri Nov 6 13:35:39 2020 +0200

    Bug 26948: Remove double encoding from sent emails

    The sent emails from Koha were garbled / double encoded because
    Koha::Email now after the refactoring and moving to use Email::Stuffer
    handles the encoding itself. Previously the Koha::Email callee had to
    handle the encoding. This patch removes the double encoding in the
    email subject and content.

    To test:
     1) Put some UTF-8 characters like ä in the HOLD template subject and body
     2) Create hold and check-in an item to make it Waiting and cause the
     email to be send
     3) Notice the email comes garbled / double encoded
     4) Apply patch
     5) Repeat step 2) and notice the email comes without any issues in
        encoding and look OK.
     6) Make sure "prove t/Koha/Email.t" and "prove
        t/db_dependent/Letters.t" and passes

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit fbd0bbf98f574a7eb804673978a198eea6fdd798
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 11 14:55:27 2020 +0100

    Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred

    There is a missing parameter to CanItemBeReserved, we need to know if
    the hold can be placed at a given pickup library.

    Test plan:
    1 - Set preferences:
         UseBranchTransferLimits: enforce
         BranchTransferLimitsType: itype
         AllowHoldPolicyOverride: Don't allow
    2 - Set Centerville 'Book' items to not be allowed to transfer to any other library
    3 - Make sure Hold policy is set to 'any library'
    4 - Find a record with a Centerville item and other items
    5 - Attempt to place an item level hold on the Centerville item (with a
    pickup library different than Centerville)
    => Without this patch you are taken to the holds list, but your hold is not placed
    Nothing indicates why hold has failed
    => With this patch you cannot select the item from Centerville
    "Cannot be transferred to pickup library"

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1dadf8823357573b740b0c259f16cf18ab4e8904
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Nov 12 11:30:33 2020 +0000

    Bug 22818: (QA follow-up) Respond to feedback

    This commit addresses the requests from Jonathan in comment #188

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0423d09e57f6a64656dc0f82a10c82962960e049
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Nov 12 13:38:49 2020 +0000

    Bug 24083: (QA follow-up) Fix DB upgrade

    This commit makes the addition of the 'unseen_renewals_allowed'
    circulation rule idempotent, as highlighted by Jonathan in comment #140

    Bug 24083: (QA follow-up) Fix for previous

    It helps if you don't commit commented out code...

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 552ea4e9d27a1d075e009e13bde63b2c91962644
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Nov 12 10:36:08 2020 +0000

    Bug 24083: (QA follow-up) Fix failing tests

    This commit fixes the failing tests mentioned by Jonathan in comment

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                                       |  4 +---
 installer/data/mysql/updatedatabase.pl              | 21 +++++++++++++++------
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt  |  2 +-
 reserve/request.pl                                  |  2 +-
 t/db_dependent/Letters.t                            | 14 +++++++++-----
 t/db_dependent/api/v1/checkouts.t                   |  2 ++
 6 files changed, 29 insertions(+), 16 deletions(-)

hooks/post-receive
-- 
main Koha release repository