[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-24-gc3f61d3bd9

Git repo owner gitmaster at git.koha-community.org
Fri Nov 13 17:48:33 CET 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  c3f61d3bd9792f4bb535401748fd614579378e54 (commit)
       via  e0cf8315e15b4c5b9e862ffa1968db5aff78686a (commit)
      from  7f4b2f20991fd04da0703fafb7b643a03fcc7e14 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c3f61d3bd9792f4bb535401748fd614579378e54
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Sep 16 11:31:54 2020 +0000

    Bug 23828: Elasticsearch - Preserve record order when combining subfield in mappings
    
    Currently if you combine subfields in the marc mappings the subfields are indexed in the order
    listed in the mapping.
    
    i.e. 650(avxyz) in mapping
    
    and in record:
    650 $aHeading $zGeosubdiv $vFormsubdiv
    
    is indexed as:
    Heading Formsubdiv Geosubdiv
    
    We should preserve the order and index as:
    Heading Geosubdiv Formsubdiv
    
    We can use built in function in Marc::Field to achieve this
    
    To test:
     1 - It is easy to find examples of this using authorities
     2 - Find or create a record with subfields order azv
         e.g. 150$aActresses$zUnited states$vBiography
     3 - Add or have a second authority
         e.g. 150$aActresses$vPortraits
     4 - Set an authorities mapping for 'Heading' to 150(abgvxyz)
         find at:
         Administration->Search engine configuration (Elasticsearch)->Authorities tab
     5 - Index the records in Elasticsearch
         perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1691 -ai 1692
     6 - View the first record in the ES index
         curl es:9200/koha_kohadev_authorities/data/1692?pretty
     7 - Note 'Heading' field is ordered as in the mapping
     8 - Search authorities for 'contains' "act"
     9 - Note the records sort incorrectly
    10 - Apply patches
    11 - perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1692
    12 - curl es:9200/koha_kohadev_authorities/data/1692?pretty
    13 - Note the order is now preserved
    14 - Search authorities for 'contains' "act"
    15 - Note the records sort correctly
    
    Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    JD amended patch: Fix
       FAIL   spelling
         combind ==> combined
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 890fd6ff068f58da4c72194ebc14be2cf479040b)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit e0cf8315e15b4c5b9e862ffa1968db5aff78686a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Sep 16 11:31:48 2020 +0000

    Bug 23828: Unit tests
    
    Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
    
    Bug 23828: (follow-up) fix unit test merge
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Bug 23828: (QA follow-up) Fix number of tests
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 0cb4300675405d37230ee427137daff2d6bdb4d9)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/SearchEngine/Elasticsearch.pm               | 11 ++-----
 t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 39 ++++++++++++++++++------
 2 files changed, 32 insertions(+), 18 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list