[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-45-g5b85449898

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  5b8544989846db705747ec0738ad24cddd012ad4 (commit)
      from  3a671b0ca6b414d62cd652dafa83d2828b7020a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5b8544989846db705747ec0738ad24cddd012ad4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Oct 22 12:36:13 2020 +0000

    Bug 26784: Silence warns about comparing undefined values for MARC modification templates
    
    This patch simply checks if conditionals are defined before comparing
    
    We don't need to check actions because you cannot save an action without an action :-)
    
    To test:
    1 - Define several actions for a MARC modification template
    2 - Ensure you have actions with no conditionals
    3 - Tail the intranet logs
    4 - Browse to Tools->MARC modification templates
    5 - Click 'Edit actions' for the template you setup above
    6 - Note warns like:
        [2020/10/22 12:30:18] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/tools/marc_modification_templates.pl line 127.
    7 - Apply patch
    8 - Restart all the things
    9 - Edit actions again and note no more warns
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 2dd19840449beadd1f1752bd8cc18f0163f7f8a4)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 tools/marc_modification_templates.pl | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository