[koha-commits] main Koha release repository branch master updated. v20.05.00-1875-g55835ccfaf

Mon Nov 16 14:21:36 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  55835ccfaffef48b924857e18bfd964aebda3a0a (commit)
       via  a386954b8b17925ed213a56878e1d453ba8c7635 (commit)
       via  36d46c6510ee93ffc52f6b914389c66351b16f33 (commit)
       via  ea725f472426caab9bcdbef128fd5693f795fe17 (commit)
       via  f6323ee5351a6801321c0938690344f04aef6c54 (commit)
       via  8b21682c332b63afd3be74073e5eeaf531dadeac (commit)
       via  a408fcc0b662c31a8911728ab3d6816ada4c3491 (commit)
      from  91e21d3a95520f19fa3632d87f2c8f32b11ea1eb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 55835ccfaffef48b924857e18bfd964aebda3a0a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 13 15:54:32 2020 -0300

    Bug 27021: Make chaining ->empty always return an empty resultset

    This patch borrows the implementation Martin did on bug 27002, to
    woraround this issue, and implements it properly on the
    Koha::Objects->empty method.

    To test:
    1. Apply the regression tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Objects.t
    => FAIL: Tests fail! The resultset should be empty and it isn't!
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off!

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a386954b8b17925ed213a56878e1d453ba8c7635
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 13 15:47:39 2020 -0300

    Bug 27021: Regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 36d46c6510ee93ffc52f6b914389c66351b16f33
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Nov 12 11:42:05 2020 +0000

    Bug 18267: Refactored Edifact Price Calculations

    Refactored the price calculations for Quotes and Invoices
    This takes in to account various combinations used by different
    vendors. Makes the extraction of basic price, quantity and tax
    information more reliable. Tests are in Edifact.t and EdiInvoice.t

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ea725f472426caab9bcdbef128fd5693f795fe17
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Nov 13 12:12:20 2020 +0000

    Bug 25761: (QA follow-up) Consistent flag names

    This follow-up updates the config flag to be consistent with bug 24449
    and updates the debian template file to match too.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f6323ee5351a6801321c0938690344f04aef6c54
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Jun 15 12:26:14 2020 -0400

    Bug 25761: Implementation of too_many_overdue has unintended consequences

    Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the
    patron status flags ). This has had unintended consequences as
    many library use SIP2 for validation to eresource vendors ( Overdrive,
    Hoopla, etc ), but do not want overdue checkouts to block the
    use of these resources.

    Test Plan:
    1) Apply this patch
    2) Restart all the things!
    3) Find a patron with overdue items
    4) Run a SIP2 patron information request
    5) Note the "too many overdue" flag is set
    6) Set the new SIP config option "disable_too_many_overdue" for the
    account you used for testing
    7) Restart the SIP server
    8) Run the same patron information request
    9) Notice the "too many overdue" flag is no longer set!

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8b21682c332b63afd3be74073e5eeaf531dadeac
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Fri Nov 13 12:07:22 2020 +0200

    Bug 27012: Fix incorrect SQL syntax in hold merging

    If you merge two records with holds in them following error happens
    without this patch:

    [WARN] DBD::mysql::st execute failed: called with 4 bind variables when 3 are needed [for Statement "SELECT * FROM reserves WHERE biblionumber = ? AND (found <> ? AND found <> ? OR found is NULL) ORDER BY reservedate ASC" with ParamValues: 0=Null!, 1=Null!, 2=Null!] at /kohadevbox/koha/C4/Reserves.pm line 2002.

    To test:
       1) Notice prove t/db_dependent/Reserves.t fails with above error
       2) Apply patch
       3) Notice prove t/db_dependent/Reserves.t passes

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a408fcc0b662c31a8911728ab3d6816ada4c3491
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Fri Nov 13 13:41:16 2020 +0200

    Bug 27012: Add test for C4::Reserves::MergeHolds

    This does a basic check whether a hold gets moved to another biblio
    when MergeHolds() is called.

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                 |   4 +-
 C4/SIP/Sip/MsgType.pm          |  10 ++--
 Koha/EDI.pm                    | 132 ++++++++++++++++++++++++++++-------------
 Koha/Edifact/Line.pm           |  74 +++++++++++++++++++++--
 Koha/Objects.pm                |   1 +
 debian/templates/SIPconfig.xml |   3 +-
 etc/SIPconfig.xml              |   3 +-
 t/EdiInvoice.t                 |  26 +++++++-
 t/Edifact.t                    |  15 ++++-
 t/db_dependent/Koha/Objects.t  |  12 ++--
 t/db_dependent/Reserves.t      |  29 ++++++++-
 11 files changed, 247 insertions(+), 62 deletions(-)

hooks/post-receive
-- 
main Koha release repository