[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-7-g4efb21d5f8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  4efb21d5f862f748f4b33750794275eaf2051921 (commit)
       via  e49596dbca7ed54dcb8f107bead6899a300b65b7 (commit)
      from  f9dbb4b1e97d5456ba742bcee3284c33b0fdc501 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4efb21d5f862f748f4b33750794275eaf2051921
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Tue Sep 29 05:53:34 2020 +0000

    Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled
    
    Test plan:
    1. Check the OAI-PMH:AutoUpdateSets syspref is disabled
    2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass
    successfully
    3. Enabled the OAI-PMH:AutoUpdateSets syspref
    4. Repeat step 2 and confirm the tests fail
    
    5. Apply this patch and restart plack: sudo koha-plack --restart
    <instance>
    6. Repeat step 2 and confirm the tests now pass
    7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and
    confirm tests still pass
    
    Sponsored-By: Catalyst IT
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 913897f3a484ea31a2373de7aac2cc8298319575)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit d3254f7e5726cdfb3572ae42eec057e90c25407d)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    (cherry picked from commit 4e55967da50418ab5f58b96171e7dc1b7ac01c85)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit e49596dbca7ed54dcb8f107bead6899a300b65b7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Oct 2 12:11:48 2020 -0400

    Bug 26604: "Generate next" button gives error on serials-collection.pl
    
    In serials-collection.pl, the line
    
    $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});
    
    causes the error
    
    Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198.
    
    This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down.
    
    Signed-off-by: kelly mcelligott <kelly at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    JD
    
    Test plan:
    1. Create a new subscription
      * When there is an irregular issue: Skip issue number
      * Select a frequency (not irregular)
      * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field
    2. Receive a first serial (mark it arrived, an "expected" one is created)
    3. Claim the expected one
    => You have 1 arrived and 1 claimed.
    It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl
    4. Generate next => boom
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 8c527522ec02c4b07c57c5a211d846856c936018)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    (cherry picked from commit 35cafa56f424a81ae98113d4f1db376987787849)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 serials/serials-collection.pl |  3 +--
 t/db_dependent/OAI/Sets.t     | 30 ++++++++++++++++++++++++++++--
 2 files changed, 29 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository