[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-108-g7045235a8d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 (commit)
      from  ac5a9f2694cc6c1ac2929268024eff520602d20d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Nov 2 15:01:32 2020 +0100

    Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection
    
    Bug 23590 added a new feature to select the manager of a suggestion.
    One month later bug 24819 added the ability to pick the suggester.
    
    This second patchset broke the manager selection.
    
    This patch simplifies the way the suggester is selected, using the
    generic way and mimicking what is done for the manager.
    
    Test plan:
    - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add)
    - click "select manager," search for user, click Select
    - see that the user you just selected shows under "Created by,"
    - see that "Managed by" still says "You"
    - modify the suggester
    - save your suggestion
    => Everything is saved correctly
    
    QA will test the permission alert:
    Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage"
    Edit the suggestion, select a manager, pick a patron in the list who
    does not have sufficient permissions, save
    => you get the alert
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Bug 26738: (QA follow-up) Add missing filter
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/common/patron_search.tt        |  6 ++-
 .../prog/en/modules/suggestion/suggestion.tt       | 30 ++++++++++--
 .../modules/suggestion/tables/suggester_search.tt  | 36 --------------
 koha-tmpl/intranet-tmpl/prog/js/suggestions.js     | 17 -------
 suggestion/add_user_search.pl                      |  7 +--
 suggestion/suggester_search.pl                     | 57 ----------------------
 suggestion/suggestion.pl                           | 14 +++++-
 7 files changed, 48 insertions(+), 119 deletions(-)
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/js/suggestions.js
 delete mode 100755 suggestion/suggester_search.pl


hooks/post-receive
-- 
main Koha release repository