[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-110-g4c10f83dc0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 (commit)
      from  b0eeddf4bc159e0a638f9e79acf21e98d6230048 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Sep 4 12:47:58 2020 +0000

    Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron
    
    Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve
    
    For cron purposes this is the correct behaviour.
    
    For display purposes we wish to see on_reserve over too_soon
    
    This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses
    
    To test:
     1 - set NoRenewalBeforePrecision to date only
     2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days
     3 - check item out
     4 - confirm item shows Scheduled For Automatic Renewal in issues table
     5 - place a hold on the item for another patron
     6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold"
     7 - change No Renewal Before value to 7
     8 - reload issues table for patron 1, confirm checkout now shows "on hold"
     9 - Apply patch
    10 - restart_all
    11 - Reload the issues table - confirm 'on_hold' still shows
    12 - Change No Renewal Before to 0
    13 - Refresh issues table, still shows 'On hold'
    14 - perl misc/cronjobs/automatic_renewals.pl -v
    15 - Result shows 'auto_too_soon'
    16 - prove -v t/db_dependent/Circulation.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit ff08e99965ccb60092b5bdd5181fd517e1fab161)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                   | 26 ++++++++++++++++----------
 misc/cronjobs/automatic_renewals.pl |  2 +-
 t/db_dependent/Circulation.t        | 10 ++++++++--
 3 files changed, 25 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
main Koha release repository