[koha-commits] main Koha release repository branch master updated. v20.05.00-1189-ge4fa2eafda
Git repo owner
gitmaster at git.koha-community.org
Thu Oct 1 12:17:00 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e4fa2eafda0575c39ca6deb7e00dc887921f77b3 (commit)
via 189baf8f49cb853e955849dd9a7ad61f6868ac32 (commit)
via 1ab62474357e031c6509abbe0a97e4c0fe079cb6 (commit)
via dc02192eb73486c6f0491dbccc18041db674a90b (commit)
via 3a47b5812a939aaff02871b96411ea17e8d33598 (commit)
via 8988941dbc428b9f197df954f05673f5ab874657 (commit)
via e3a4d74b2f63181c43b0224ca72e868fe8e76b5f (commit)
via d845febfd57288262b2ccf1aec08f8f5f2442fb4 (commit)
via be379b664c1cd2c997dc0af742cf00781f2faea9 (commit)
via 978daf841293cd7fa7dae7163b672d130c006362 (commit)
via e51038687903eb92af4e327333aec027f5fb0247 (commit)
via 334c8e94c11554aaf810db4b4e0b5ad0043c19f7 (commit)
via 0d9fc7331a873835aa7e1fd2f1a112becccfad85 (commit)
via 1e346db48a741d4a8639e9e463cca8a6b13e9109 (commit)
via acf11bacfdf72c5eb08be46a4a814914970a43ae (commit)
via 41589686e8b9aba7123540ff8ad9f186f5726c89 (commit)
via 2146523b2865497fe904d1e182a5193a80752b86 (commit)
via e83978614125437078ba7fed93d79c8843e6f069 (commit)
via 54454554e9d80e6369e3726826abf08a8356c2ea (commit)
via 3e8b9a652b86726f7154c1dac6adb2cc24c5b44f (commit)
via bdfb8a556f02761a7e987659f36e237749e8f23e (commit)
via a6ca5a6e12f0d3023716a06be9e98cbd9fb0d15a (commit)
via 28ecd4cb7e6281260cfc36af6f411cc734201691 (commit)
via 04c499b11dfdebc7efb976952d135a1b1af1a140 (commit)
via 02f65c89255cb93a08b7b3ac3918c04fe085ac1f (commit)
via 3bf7430d1c41bf9acb363f4fff9476f6ee653fdd (commit)
via c72f01d9072a35753d235db26983560a4c984522 (commit)
via fce5887e16c7869eeeea49c4bab6620eaa2f26e3 (commit)
via 817a84001e3a14c0b54b0b36dfef2f7f496aad27 (commit)
via e58689a9b9421ca23bcd29d86403670a39412c3f (commit)
via 87ca07f4231b72c62ad8e9ba895a3e7575b8c114 (commit)
via 7b5a37fa198bacfa6434c235aecf9af2c54e95f4 (commit)
via 6e2aba2c02b0a838a6dd83019e7a64269bc8747b (commit)
via e302abf49d8d4dd6e099b387d2b63fc4c20a14ae (commit)
via fec3cf23f1fe8b71e225fffbc6cd361637b3729e (commit)
via e474df640294abfe852fc8231a4cb7ef7206aa92 (commit)
via 88f34a355443f8cc530315e6117265f0540e3b8c (commit)
via 6824b93b0270a2b2a99b85c36f7a535ec9e4530e (commit)
via 0efa9a917b1333409c7e8e664b95fb1f1afac051 (commit)
via 6e5142e61be8604c5144077d15e3782e6853677b (commit)
via 9aa84cb348731f3429e586ace93d5e54cceb572a (commit)
via 0e55d445e5a814e32efa0313f9147061aa71278a (commit)
via a51e4425571c0923750b99ed58575e2b9494a5cd (commit)
via 4a1c5c13962d01e3c181d2c20fed7efeeed4aecf (commit)
via 2cd12ac4d4cafac7fa48393ad61fa6a3b8995194 (commit)
via 50877291b26b316eacdf0fdca759d9e8c3004a77 (commit)
via 80465d502f2d9d54e65c3f30abfb07134c1fe2ca (commit)
via bf5b8c2be79a9dfd6eee61ccda6f0852bca9f39c (commit)
via d3619c88cdaa093e53e1d9f9b15dad0db0c39ba4 (commit)
via 574e2e80eb0f57838a548f42a0689aa2979b5745 (commit)
via d3d89e629eb984511c71b2844899c08036bfa6fb (commit)
via 33c89690390de2e637dc22855afaf01e12412685 (commit)
via 8e327f696f7ffbdf6346f71b6c0df4d77363d457 (commit)
via 90756266e6766ad4530a561559ddf47de1794a85 (commit)
via 80da74f8d3cc11ee949ea1c36457987c6b0f9176 (commit)
via 9625c409b46cd503a06aab896900926e2b3eb27c (commit)
via d93cbf75a4fbb4fb7b2f81ac82d19e08d2571894 (commit)
via 175838804559e79f365a47aca827a8abb1123d6d (commit)
via 7d2b6a3f3506102dc7cd8ccc729f96579f753fae (commit)
via ff64264092f663cf32ba44f2e46367c237f97ddd (commit)
via f45b3b3f3a6c0ed8cc946b6f65573f041e0e1e72 (commit)
via 5dcca80dc5080dea098938767b1587a42f2ed65b (commit)
via d4013f660c47ad697747e9860e159aa23bc4e409 (commit)
via ebfbefdeb1a0b4db9f7fd7ca003d75c2038c234e (commit)
via fb59f3f0f046c7b08fa509e76c416b2c4db3fa5a (commit)
via d7e9388e4d847ab95b560df98eb78a2ff7ab5f74 (commit)
via 7606cd73e22e64d9464cfca37bc04c8a305eed5a (commit)
via 17c68d11bb76a4134c7f952325d2ec770b873d8b (commit)
via 8a6427e9e28ec927748533e8e7b67e73ed36c9b6 (commit)
via debf8f804c6bc47777f1a239e6b20f78c847e0b2 (commit)
via a2652135f74c6929bedb2452c41b50dc03b7954c (commit)
via 3d37f6f08c5e649ec037ba8bba0fa5adcc814b9e (commit)
via 8de7332a35bba62f55f406727ae8a87b6e270984 (commit)
via d6ddf53ab69cf5f6e0e506b8a39ef782ec47869e (commit)
via 268dfb5455b2663f1cdad886e0bcb7d9b768327c (commit)
via 2900cee991511862501c3902c901f5f9e9289f9b (commit)
via 00e01c5555ff73b00a1dca17e5fc32c93676034a (commit)
via 41f0f22cb2f13d04ad9422b73bddc453591e4732 (commit)
from 1ac0850a336d2bb3e5d0bd3ad990e61a34b3dd65 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e4fa2eafda0575c39ca6deb7e00dc887921f77b3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 14:16:53 2020 +0000
Bug 25261: DBRev 20.06.00.043
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 189baf8f49cb853e955849dd9a7ad61f6868ac32
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 1 11:35:00 2020 +0200
Bug 25261: Prevent tests to fail if CircConfirmItemParts is on
Setting items.materials to NULL at TestBuilder level will (certainly) prevent some
tests to fail if the pref is on
In t/db_dependent/selenium/basic_workflow.t we set 952$3 to an empty
string. The tests will pass even if the pref is turned on.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1ab62474357e031c6509abbe0a97e4c0fe079cb6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Sep 17 15:01:32 2020 +0100
Bug 25261: (QA follow-up) Prevent server error on bad barcode
Prior to this patch if you had CircConfirmParts enabled and you
attempted to checkin a deleted item then you would be met with a server
error.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dc02192eb73486c6f0491dbccc18041db674a90b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Sep 17 12:59:11 2020 +0100
Bug 25261: (QA follow-up) Catch attepts to return via SCO
This patch adds a block to capture attempts to return items with
attached materials when checking in via the self checkout when the
relevant system preference is set.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3a47b5812a939aaff02871b96411ea17e8d33598
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Sep 17 12:21:10 2020 +0100
Bug 25261: (QA follow-up) Make issue and returns messages consistent
This patch makes the confirmation dialogue handing and visuality
consistent between issues and returns.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8988941dbc428b9f197df954f05673f5ab874657
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 16 13:18:09 2020 +0100
Bug 25261: (QA follow-up) Prevent double dialogue
This patch removes the blue information message box if we are using
multi-part confirmations.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e3a4d74b2f63181c43b0224ca72e868fe8e76b5f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Sep 14 07:40:10 2020 +0000
Bug 25261: (QA follow-up) Terminology: checkin/checkout
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d845febfd57288262b2ccf1aec08f8f5f2442fb4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 2 12:17:56 2020 +0100
Bug 25261: (QA follow-up) Restore previously returned list
Test plan
0 - Enable ShowAllCheckins
1 - Check in several regular items
2 - Check in an item with parts
3 - Confirm the checkin in
4 - The list of checkins contains all the previous checkins and the
multi-part checkin too.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit be379b664c1cd2c997dc0af742cf00781f2faea9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 2 12:00:07 2020 +0100
Bug 25261: (QA follow-up) Capitalize return of needsconfirm
This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the
needsconfirm hash return value for CanBookBeIssued to restore
consistency with previous code and ensure SIP Checkout works as
expected.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 978daf841293cd7fa7dae7163b672d130c006362
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 13 17:52:18 2020 +0100
Bug 25261: (QA follow-up) Add handling to SCI
Test plan
1/ Enable the feature as per previous patches
2/ Attempt to return an item with materials attached via the SCI
3/ Note that the return is blocked with the message '(The item
cannot be returned at a self service terminal, please see library
staff for assistance)'
4/ Signoff
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e51038687903eb92af4e327333aec027f5fb0247
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 13 16:44:28 2020 +0100
Bug 25261: (QA follow-up) Catch check in SIP Checkin
Test plan
1/ Enable the feature as per previous patches
2/ Attempt to return an item with materials attached via a SIP unit
3/ Note that the return is blocked with an alert type of '99'
4/ Signoff
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 334c8e94c11554aaf810db4b4e0b5ad0043c19f7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 13 16:27:50 2020 +0100
Bug 25261: (QA follow-up) Add handling to SCO
Test plan
1/ Enable the feature as per previous patches
2/ Attempt to checkout an item with materials attached via the SCO
3/ Note that the checkut is blocked with the message 'Item must be
issued at a circulation desk'
4/ Signoff
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0d9fc7331a873835aa7e1fd2f1a112becccfad85
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 13 16:23:25 2020 +0100
Bug 25261: (QA follow-up) Catch check in SIP Checkout
Test plan
1/ Enable the feature as per previous patches
2/ Attempt to checkout an item with materials attached via a SIP unit
3/ Note that the checkut is blocked with the message 'Item must be
issued at a circulation desk'
4/ Signoff
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1e346db48a741d4a8639e9e463cca8a6b13e9109
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Aug 5 10:52:48 2020 +0100
Bug 25261: (QA follow-up) Add confirmation to issues table
The issues table allows for checkins and was not appropriately
requireing confirmation for the multi-part confirmation added in this
bug.
Test plan
1/ Enable the feature as per previous patches
2/ Checkot an item with attached materials
3/ Navigate to a page that display your users issues table (the checkout
page is a reasonable example)
4/ You should have the option to select items for return in the table
(If not, use the column settings to enable the feature)
5/ Select at least the item with attached materials to return
6/ Upon clicking the return buttton you should find that items without
additional materials are returned as expected, but rows with additional
materials turn yellow and contain a message and additional checkbox for
confirmation in the table.
7/ Ensure the checkbox is selected and click the return button again
8/ This item should have been returned.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit acf11bacfdf72c5eb08be46a4a814914970a43ae
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Jul 24 12:05:29 2020 +0100
Bug 25261: (QA follow-up) Non-confirm on return
This patch updates the confirmation from an alert to a dismissable modal
which allows for optionally not checking the item in
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 41589686e8b9aba7123540ff8ad9f186f5726c89
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jul 24 10:33:26 2020 +0200
Bug 25261: (QA follow-up) Simplify tests and conditions
Use build_sample_item in tests
Simplify tests for the confirmation
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2146523b2865497fe904d1e182a5193a80752b86
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed May 6 10:33:35 2020 +0100
Bug 25261: (QA follow-up) Add unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e83978614125437078ba7fed93d79c8843e6f069
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed May 6 09:25:37 2020 +0100
Bug 25261: (follow-up) item.material may contain non-numerics
Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field,
and thus the item.materials field, may contain arbitrary notes about the
material rather than just numeric values. As such we need to check for
the field being defined as aposed to greater than '0'.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 54454554e9d80e6369e3726826abf08a8356c2ea
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed May 6 09:20:32 2020 +0100
Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts
This clarifies the preference name to make it clear we are talking about
the 'parts' that make up an 'item'. 'Part' is a well known term in
british english libraries and I think perhaps 'Materials' may be
confused with other terms?
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3e8b9a652b86726f7154c1dac6adb2cc24c5b44f
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Thu Apr 30 12:03:19 2020 +0200
Bug 25261: Checkout confirmation depending on syspref
With this follow-up patch, the intended confirmation of checkin based on
CircConfirmParts value is effective.
Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/]
Sponsored-by: PTFS Europe [https://ptfs-europe.com/]
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bdfb8a556f02761a7e987659f36e237749e8f23e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Aug 5 13:52:09 2015 +0100
Bug 25261: Require confirmation of multiple parts items
Test plan
1/ Catalogue an item to contain multiple parts by populating 'Materials
specified (bound volume or other part)'
2/ Enable the new system preference 'CircConfirmParts'
3/ Attempt to checkout the item created in step 1 to a user and note
that confirmation is now required.
4/ Checkout the item
5/ Attempt to checkin the item you have just checked out and note that
confirmation is required.
6/ Signoff
Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/]
Sponsored-by: PTFS Europe [https://ptfs-europe.com/]
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a6ca5a6e12f0d3023716a06be9e98cbd9fb0d15a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 28 13:13:00 2020 +0100
Bug 25261: Add system preference
Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/]
Sponsored-by: PTFS Europe [https://ptfs-europe.com/]
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 28ecd4cb7e6281260cfc36af6f411cc734201691
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 15:16:25 2020 +0200
Bug 14648: Take advantage of I18N to deal with plural
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 04c499b11dfdebc7efb976952d135a1b1af1a140
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Sep 17 09:34:57 2020 +0000
Bug 14648: (QA follow-up) Terminology items-reserves delete-remove
- As we have batch add reserves, we should also have batch remove reserves
- Delete items sounds a bit scary, removed items I think is a little better here
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 02f65c89255cb93a08b7b3ac3918c04fe085ac1f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Sep 17 09:22:39 2020 +0000
Bug 14648: (QA follow-up) Add missing filters
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3bf7430d1c41bf9acb363f4fff9476f6ee653fdd
Author: Joseph Sikowitz <joe at flo.org>
Date: Fri Jul 17 11:34:30 2020 -0400
Bug 14648: Batch remove reserve items
Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of
barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning
before the final deletion is made.
This patch also now moves barcodes that are invalid or not attached to a course reserve to the invalid barcodes output. It also provides
a count of the courses that the deleted items were attached to.
Test Plan
1. Log in as a user with permissions to add and delete course reserves
2. Add the same items to multiple course reserves
3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl)
4. Click the "- Batch remove items" button
5. Enter the barcodes that you added to multiple reserves in step 1
6. Click submit
7. Click Ok if you are ready to delete all of these items
8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else
9. Repeat 2-5
10. Add an invalid barcode and a valid barcode that is not attached to a course reserve
11. Repeat 6-7
12. You should see that the items attached to course reserves were removed while the invalid and unattached barcodes were rejected
13. Log out
14. Log in as a user without permission to delete course reserves
15. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl)
16. You should not longer see the "- Batch remove items" button
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c72f01d9072a35753d235db26983560a4c984522
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 14 13:33:01 2020 +0000
Bug 19322: Typo in UNIMARC field 140 plugin
This patch corrects some incorrect information in the UNIMARC plugin for
tag 140. Literature code "li" should be "mystic literature."
To test you do not need a UNIMARC installation. Apply the patch and go
to Administration -> MARC frameworks and Actions -> MARC structure for
one of your frameworks.
- Edit subfields for a tag, e.g. 245. This is only for testing purposes
so it doesn't have to be any particular tag.
- Change the options for one of the subfields, e.g. $a. Under "Other
options (choose one), set "Plugin" to "unimarc_field_140.pl"
- Save changes.
- Open a bibliographic record for editing using the framework you
modified.
- Click the plugin link next to the subfield you modified, e.c. 245$a.
- This should trigger the "UNIMARC field 140 builder" popup window.
- Find "Literature" and select "Mystic literature." Save.
- In the MARC editor, the field you modified should contain the value
"li" at position 17-18.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fce5887e16c7869eeeea49c4bab6620eaa2f26e3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 14 13:49:14 2020 +0000
Bug 19327: Typo in UNIMARC field 128a plugin
This patch corrects some incorrect information in the UNIMARC plugin for
tag 128$a. The value for "partsong" should be "pt#"
To test you do not need a UNIMARC installation. Apply the patch and go
to Administration -> MARC frameworks and Actions -> MARC structure for
one of your frameworks.
- Edit subfields for a tag, e.g. 245. This is only for testing purposes
so it doesn't have to be any particular tag.
- Change the options for one of the subfields, e.g. $a. Under "Other
options (choose one), set "Plugin" to "unimarc_field_128a.pl"
- Save changes.
- Open a bibliographic record for editing using the framework you
modified.
- Click the plugin link next to the subfield you modified, e.c.
245$a.
- This should trigger the "UNIMARC field 128a builder" popup window.
- Select "partsong" in the dropdown. Save.
- In the MARC editor, the field you modified should contain the
value "pt#"
- Trigger the popup window again and click "Save" without making
changes.
- The value in the MARC editor should be the same.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 817a84001e3a14c0b54b0b36dfef2f7f496aad27
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Sep 25 09:35:49 2020 -0400
Bug 21979: Add unit tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e58689a9b9421ca23bcd29d86403670a39412c3f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Dec 7 14:32:00 2018 -0500
Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead of collection code
Some libraries need to send a different field as the collection code,
depending on how the library catalogs items. We should allow any arbitrary
item field to be used as the value for the CR field.
Test Plan:
1) Apply this patch
2) Set the new option cr_item_field to 'shelving_location'
3) Restart the SIP server
3) Perform a checkin via SIP
4) Note the CR field contains the shelving location code in the response
5) Perform an item information request
6) Note the CR field contains the shelving location code in the response
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 87ca07f4231b72c62ad8e9ba895a3e7575b8c114
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Sep 26 20:36:12 2020 +0200
Bug 23114: (QA follow-up) Slightly rephrase message when both barcode options are used
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7b5a37fa198bacfa6434c235aecf9af2c54e95f4
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Wed Jun 26 14:58:44 2019 +0200
Bug 23114: Inventory: allow to scan barcodes
This patch allows the user to scan barcodes in the inventory tool
(in addition to upload a barcode file, like in other tools)
Test plan:
1) Apply the patch.
2) Check that you can still upload a barcode file.
3) Check that you can scan/enter barcodes in the new textarea.
4) Check that if you both upload a barcode file and enter barcodes,
you will be prompted to choose only one method.
5) Check that you can then proceed to the next step by either resetting the
upload file input or emptying the textarea.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6e2aba2c02b0a838a6dd83019e7a64269bc8747b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 18 15:28:17 2020 +0000
Bug 24155: (follow-up) Template fixes and updates
This patch makes a few minor changes to the OPAC and staff interface
templates:
- In both, the "Apply field weights" checkbox will only appear after the
"More options" button has been clicked. Otherwise a hidden input sets
the value to 1.
- In both, the checkbox now appears below the search fields.
- Checkboxes are now wrapped in the <label> tag to ensure the label is
clickable.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e302abf49d8d4dd6e099b387d2b63fc4c20a14ae
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Aug 31 12:38:02 2020 +0000
Bug 24155: (follow-up) Add span with id to weighted search option
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fec3cf23f1fe8b71e225fffbc6cd361637b3729e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon May 18 17:32:43 2020 +0000
Bug 24155: Apply weights if not advanced search
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e474df640294abfe852fc8231a4cb7ef7206aa92
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Feb 26 14:30:17 2020 +0000
Bug 24155: Make weighting an option on advanced search
Currently we apply weighting to all searches except advanced search. The theory
being that when selecting indexes we don't want to apply weights. When searching
in ES weights are only applied to relevant results so it doesn't matter.
i.e. if weighting author*100 but searching subject, a term matching the subject search in author
is not boosted.
Given this, we should always apply weights, unless the user wishes not to
To test:
1 - Set some weighting
2 - Do some searches
3 - Note your terms and results, try advanced and regular searches specifying indexes or not
4 - Apply patch
5 - Note that opac and staff advanced search have option to apply weights
6 - Compare searches after the patch to see how weighting affects, it should be beneficial or not at all
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 88f34a355443f8cc530315e6117265f0540e3b8c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 14:33:47 2020 +0200
Bug 24322: Simplify condition to separate elements
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6824b93b0270a2b2a99b85c36f7a535ec9e4530e
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at hypernova.fi>
Date: Sun Sep 13 23:57:41 2020 +0200
Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail
This adds MARC21 060 - National Library of Medicine Call Number
https://www.loc.gov/marc/bibliographic/bd060.html
To test:
- Catalog records using the 060, examples can be found in the
LOC documentation.
- Verify that the field displays on the detail pages in staff
and OPAC
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
RRescued this patch by redoing the changes. Only change made
was moving the section up before "Other classification".
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0efa9a917b1333409c7e8e664b95fb1f1afac051
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 1 10:33:08 2020 +0200
Bug 25242: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6e5142e61be8604c5144077d15e3782e6853677b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Sep 1 17:11:24 2020 +0100
Bug 25242: Improve column wrapping for holdingst
This patch attempts to improve the column wrapping for the holdingst
datatable and sets the tabel to fixed width to prevent overlapping
with other content on high zoom levels/low width screen sizes.
Test plan
1/ Build the OPAC CSS from the updated SCSS
2/ Navigate to an item with holdings visible in the OPAC
3/ 'Play' with various window sizes and zoom levels.
4/ The table should not overlap with right navigation content
5/ Signoff
NOTE: This is an alternative patch to those pushed and reverted that
attempted to provide a global fix to overlap issues. This patch
specifically targets just the holdings table in the opac detail view.
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9aa84cb348731f3429e586ace93d5e54cceb572a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jun 16 13:16:30 2020 +0000
Bug 25771: Allow the user to sort checkouts by the renew column in the OPAC
This patch makes it possible for the logged-in OPAC user to sort their
checkouts by the number of renewals they have remaining on their
checkouts.
To test, apply the patch and log in to the OPAC as a user with multiple
checkouts. To fully test the patch's functionality the user's checkouts
should have a varying number of renewals available.
On the "your summary" page, confirm that the "Renew" column is now
sortable and that it sorts correctly by the number of renewals left on
each checked-out item.
Signed-off-by: Henry Bolshaw <bolshawh at parliament.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0e55d445e5a814e32efa0313f9147061aa71278a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 17:33:33 2020 +0200
Bug 25776: DBIC schema changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a51e4425571c0923750b99ed58575e2b9494a5cd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 14:16:31 2020 +0000
Bug 25776: DBRev 20.06.00.042
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4a1c5c13962d01e3c181d2c20fed7efeeed4aecf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Sep 17 09:02:32 2020 +0100
Bug 25776: (QA follow-up) Add missing filter
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2cd12ac4d4cafac7fa48393ad61fa6a3b8995194
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Aug 31 21:53:29 2020 +0000
Bug 25776: (follow-up) Fix sorting by change date in notices table
Some markup was missing to sort the date correctly.
To test:
- Verify date sorting in the notices table works as expected
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 50877291b26b316eacdf0fdca759d9e8c3004a77
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Aug 27 10:38:25 2020 +0000
Bug 25776: Add a 'last updated' column for notices
This add an 'udated_on' column to the letter table and displays
the information in 'slips and notices'.
To test:
- Apply patch
- Run updatedatabase
Note: the existing letters will all be set to the
currnet date).
- Go to Tools > Notices and slips
- Verify there is a new column "Last updated" in the table
Note: The table will always display the newest change date
of the different message transport types.
- Edit any notice
- Verify the "Last updated" is shown for any transport type
with an existing notice definition
- Edit and add a notice
- Verify the dates are correctly stored
- Test the column configuration for the new column works
correctly
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 80465d502f2d9d54e65c3f30abfb07134c1fe2ca
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 18 13:14:33 2020 +0000
Bug 26484: Add serials-related reports to serials sidebar menu
This patch adds a section to the serials sidebar menu for showing
serials reports.
To test, apply the patch and go to Serials.
- If you are logged in as a user with permission to access reports you
should see a new "Reports" heading in the sidebar menu and a link to
the serials statistics wizard.
- Confirm that the link works correctly.
- Log in as a user without reports permission and confirm that the
section doesn't appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bf5b8c2be79a9dfd6eee61ccda6f0852bca9f39c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jul 29 15:18:12 2020 +0000
Bug 26089: Add acquisitions-related reports to acquisitions sidebar menu
This patch adds links to two acquisitions-related reports in the sidebar
menu shown on acquisitions pages: Acquisitions statistics wizard and
orders by fund.
To test, apply the patch and go to the Acquisitions page.
- If you are logged in as a user with permission to access reports you
should see a new "Reports" heading in the sidebar menu and links to
two reports.
- Confirm that the links work correctly.
- Log in as a user without reports permission and confirm that the
section doesn't appear.
Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d3619c88cdaa093e53e1d9f9b15dad0db0c39ba4
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 28 11:09:01 2020 +0000
Bug 26207: (follow-up) Hide comparison toolbar if there are no comparisons
This patch adds a check to the JavaScript so that the comparisons
toolbar will be hidden if there are no system preferences in the results
to compare.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 574e2e80eb0f57838a548f42a0689aa2979b5745
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Aug 20 12:47:01 2020 +0000
Bug 26207: (follow-up) Remove whitespace from markup
Markup indentation around log entries in the template cause extra
whitespace in the diff view. Removing the markup whitespace corrects it.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d3d89e629eb984511c71b2844899c08036bfa6fb
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Aug 14 12:08:10 2020 +0000
Bug 26207: Compare values of system preference log entries
This patch adds the ability to compare the values of system preferences
in the system log. The user can select two entries in the log search
results and view a diff of the two versions.
The feature is designed specifically for CSS and JS preferences like
OpacUserCSS or OpacUserJS where code changes are difficult to track.
To test, apply the patch and go to Tools -> Log viewer. You may need to
add values and make changes to preferences like OpacUserCSS if you don't
already have a history in your logs.
- Perform a search for log entries in the "System prefs" module.
- In the results, each entry for a system preference should have a
"Compare" checkbox."
- Check one of the checkboxes.
- The table should now be filtered by the system preference name. This
facilitates meaningful selections for comparison.
- You should see a message displayed onscreen, "Showing results
for...[ preference name]"
- The "Check none" link in the toolbar above the table should now be
enabled.
- If youy click the "Compare selected" link in the toolbar at this
stage you should get a message, "You must select two entries to
compare."
- If you uncheck the checkbox the table should return to an unfiltered
state.
- Check two checkboxes.
- The "Compare selected" link in the toolbar should now be enabled.
- Next to each of the checkboxes you checked should be a "View
comparison" link.
- Clicking either of the "View comparison" links or the "Compare
selected" link should trigger a modal with the diff view of the two
preferences.
- Try to select a third checkbox. You should get a message, "You can
select a maximum of two checkboxes." The box should remain unchecked.
- Test that unchecking both checkboxes manually clears the table filter.
- Test that the "Check none" link works to uncheck checked boxes and
clear the table filter.
Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 33c89690390de2e637dc22855afaf01e12412685
Author: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Date: Fri Sep 18 05:55:22 2020 +0000
Bug 26266: Add jQuery validator to opac-password-recovery.tt
To test:
0) Activate password reset in system preferences.
1) Initiate a password recovery.
2) Try to submit with an invalid password.
3) Confirm that validation occurs.
4) Try to submit with mismatching passwords.
5) Confirm that validation occurs.
6) Sign off.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8e327f696f7ffbdf6346f71b6c0df4d77363d457
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 17:32:01 2020 +0200
Bug 26268: DBIC schema changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 90756266e6766ad4530a561559ddf47de1794a85
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 14:16:31 2020 +0000
Bug 26268: DBRev 20.06.00.041
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 80da74f8d3cc11ee949ea1c36457987c6b0f9176
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 17:05:54 2020 +0200
Bug 26268: Fix deleteditems query in DB rev
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9625c409b46cd503a06aab896900926e2b3eb27c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Sep 25 20:09:33 2020 +0000
Bug 26268: Remove invalid mappings from MARC frameworks when items.paidfor is removed
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d93cbf75a4fbb4fb7b2f81ac82d19e08d2571894
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Sep 26 23:44:02 2020 +0200
Bug 26268: Correct mapping for internal note to items.itemnotes_nonpublic
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 175838804559e79f365a47aca827a8abb1123d6d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Sep 11 12:51:47 2020 +0100
Bug 26268: (QA follow-up) Conditionally remove
This patch adds conditions to prevent the removal of items.paidfor if it
is populated and also adds the removal fo the marc_subfield_structure
row if it exists.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7d2b6a3f3506102dc7cd8ccc729f96579f753fae
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Sep 4 17:04:53 2020 +0100
Bug 26268: (QA follow-up) Split DB update checks
This patch splits the DB update such that the 'paidfor' field is checked
for distinctly in the deleteditems table rather than assuming if it
exists in the items table it will also exist in deleteditems.
We also correct the check as highlights by Julian.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ff64264092f663cf32ba44f2e46367c237f97ddd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Aug 21 11:29:10 2020 +0100
Bug 26268: Remove final references to paidfor db field
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f45b3b3f3a6c0ed8cc946b6f65573f041e0e1e72
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Aug 21 11:25:12 2020 +0100
Bug 26268: Remove items.paidfor from the database
In bug 19919 we removed all references to setting, unsettling and
referring to the paidfor field but we neglected to actually drop the
field from the database (I think I intended to do this, but was asking
for feedback on the approach before adding the actual db change.. then
completely forgot when it went through SO/QA quickly).
In bug 23463 we inadvertently re-introduced some of the setting code
during a rebase.
In bug 18501 we then moved that inadvertently re-introduced setter into
Koha::Item->store.
We should kill it off once and for all!
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5dcca80dc5080dea098938767b1587a42f2ed65b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Sep 3 13:25:45 2020 +0000
Bug 26299: Use same SMS number help text in OPAC as staff interface
The SMS number help text in the OPAC follows a North American phone
number style. It should be more generic. To that end, this patch
makes the OPAC use the same help text for SMS numbers as
the staff interface
To test:
1) Apply the patch
2) Set "SMSSendDriver" to "Anything" in global system preferences
3) Go to the following link and note the help text by SMS number
http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51
4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl
5) Note that the help text in both interfaces uses the same wording
Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d4013f660c47ad697747e9860e159aa23bc4e409
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Aug 31 16:43:53 2020 +0000
Bug 26325: Add primary_key_exists check to C4::Installer
To test:
1 - prove -v t/db_dependent/Installer.t
Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ebfbefdeb1a0b4db9f7fd7ca003d75c2038c234e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 1 10:32:10 2020 +0200
Bug 26338: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fb59f3f0f046c7b08fa509e76c416b2c4db3fa5a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Sep 1 15:43:19 2020 +0200
Bug 26338: Show tool plugins run in tools home
In tools home there is a link to the table showing tool plugins.
Would be great to be able to run a tool plugin directly from tools home.
Also adds the behavior than if there is no tool plugin, "Tool plugins"
section is not displayed in tools home.
No need of a link that goes to an empty table ;)
Test plan :
1) Enable plugins, dont install any
2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl
3) Check you dont see "Tool plugins"
4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/
5) Refresh /cgi-bin/koha/tools/tools-home.pl
6) Check you see "Tool plugins" and a link to Carrousel
7) Click on link to Carrousel => You see plugin run
8) Disable Carrousel plugin
9) Refresh /cgi-bin/koha/tools/tools-home.pl
10) Check you dont see "Tool plugins"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d7e9388e4d847ab95b560df98eb78a2ff7ab5f74
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 11 09:36:21 2020 +0200
Bug 26425: Update history.txt
With the modifications brought by
https://gitlab.com/koha-community/release-tools/-/issues/18
After the manual changes we can run the script with the 3 commits from
the issue #18 of release-tools.
* Add missing whitespace to align the dates
* Add all the releases (from the tag list) after 3.00.00
There is no change in the developers numbering, neither in the wording.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7606cd73e22e64d9464cfca37bc04c8a305eed5a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 11 09:33:27 2020 +0200
Bug 26425: Manual changes
Patches will be squashed when pushed.
Here the changes are done manually, we add the missing 0 for the
releases after 3.00.00 (with alpha, beta, etc)
And we remove all the laters, that will added automatically by the
release script
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 17c68d11bb76a4134c7f952325d2ec770b873d8b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 11 08:55:28 2020 +0000
Bug 26432: Remove unused ModZebrations
Test plan:
Git grep on ModZebrations
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8a6427e9e28ec927748533e8e7b67e73ed36c9b6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 30 14:16:31 2020 +0000
Bug 26454: DBRev 20.06.00.040
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit debf8f804c6bc47777f1a239e6b20f78c847e0b2
Author: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Date: Wed Sep 16 08:35:15 2020 +0200
Bug 26454: Add system preference to set meta description for the OPAC
Websites should have a meta description tag that shows in search engine results.
The content should also be available to set as a system preference.
To test:
1) Look at opac-main source (in the browser) and see that meta name="description" is missing.
2) Apply patch.
3) Run: perl installer/data/mysql/updatedatabase.pl
4) Go to system preferences > OPAC and add a description to OpacMetaDescription.
5) Look at opac-main source and confirm that meta name="description" now has content equal to the text set in the OpacMetaDescription system preference.
6) Sign off.
Sponsored by: Lunds University Libraries
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Works as advertised. Newlines are preserved. Double quote is rendered
as ". Nice enhancement!
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a2652135f74c6929bedb2452c41b50dc03b7954c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Sep 15 10:11:33 2020 +0000
Bug 26462: Don't delete existing data for tests
These tests generate their own items, patrons, and circ rules. Existing
system data will not affect the results of the tests. We do not need
to delete information.
You may be able to notice the difference in speed of tests depending on your system. It should
be faster after applying
To test:
1 - Before applying patch:
prove -v t/db_dependent/Holds.t
2 - It passes
3 - Apply patch
4 - prove -v t/db_dependent/Holds.t
5 - It passes
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d37f6f08c5e649ec037ba8bba0fa5adcc814b9e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 14 16:56:21 2020 +0000
Bug 26458: Get item details using only itemnumber
This patch modifies moredetail.pl so that it can accept an itemnumber as
a single parameter.
To test, apply the patch and view a bibliographic record in the
catalog which has one or more items.
- In the table showing holdings, click the barcode to view the item
detail page for that item.
- In the location bar, modify the URL so that it uses only the
itemnumber parameter, e.g.
/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=1234
The page should load correctly, showing information about just that
item.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8de7332a35bba62f55f406727ae8a87b6e270984
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Sep 16 15:19:41 2020 +0000
Bug 26473: Get items for editing using only itemnumber
This patch modifies additem.pl so that it can accept an itemnumber as
a single parameter.
To test, apply the patch edit items on a bibliographic record which has
one or more items.
- In the location bar, modify the URL so that it uses only the
itemnumber parameter, e.g.
/cgi-bin/koha/cataloguing/additem.pl?itemnumber=12345
The page should load the correct record's items.
- If you add the "op" parameter it should load the item for editing in
the form:
/cgi-bin/koha/cataloguing/additem.pl?itemnumber=12345&op=edititem
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d6ddf53ab69cf5f6e0e506b8a39ef782ec47869e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Sep 21 11:29:18 2020 +0000
Bug 26501: Add datatables to article-requests form
Actually two tables: one for pending and processing.
Variable active_table has been renamed to active_tab.
To prevent a flickering form we hide stuff until ready.
Test plan:
[1] Submit a few article requests.
[2] Verify that Process, Complete and Cancel still work via Actions.
[3] Test again with multiselect and top Actions menu.
[4] Test Search and Sort on the datatable.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 268dfb5455b2663f1cdad886e0bcb7d9b768327c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 16:06:19 2020 +0200
Bug 26524: Save some processor cycles
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2900cee991511862501c3902c901f5f9e9289f9b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Sep 23 15:56:41 2020 -0300
Bug 26524: Add Koha::Acquisition::Basket->orders
This patch adds a handy accessor for a basket's orders. It can be used
to embed orders on an API call or be used in controller scripts to
replace C4::* methods.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 00e01c5555ff73b00a1dca17e5fc32c93676034a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Sep 23 15:56:32 2020 -0300
Bug 26524: Unit tests
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 41f0f22cb2f13d04ad9422b73bddc453591e4732
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 11 16:32:29 2020 +0000
Bug 26530: Use patron card number as checkbox label during patron merge
This patch makes a minor change the the merge patrons template so that
on the patron selection stage the user can click the card number to
select the radio button.
To test, apply the patch and perform a patron search in the patrons
module.
- In patron search results, select two patrons to merge.
- Click the "Merge selected patrons" button.
- On the page showing the two patrons to merge, click each of the card
numbers to confirm that it selects the correct radio button.
Signed-off-by: Jennifer <jennifer.marlatt at coronaca.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 7 +
C4/Context.pm | 3 -
C4/Installer.pm | 14 +-
C4/SIP/ILS/Item.pm | 4 +
C4/SIP/ILS/Transaction/Checkin.pm | 19 +-
C4/SIP/ILS/Transaction/Checkout.pm | 6 +-
C4/SIP/Sip/MsgType.pm | 25 +-
Koha.pm | 2 +-
Koha/Acquisition/Basket.pm | 17 +
Koha/Item.pm | 2 -
Koha/Schema/Result/Aqbasket.pm | 7 +
Koha/Schema/Result/Deleteditem.pm | 11 +-
Koha/Schema/Result/Item.pm | 11 +-
Koha/Schema/Result/Letter.pm | 18 +-
admin/columns_settings.yml | 2 +
catalogue/moredetail.pl | 12 +-
catalogue/search.pl | 3 +-
cataloguing/addbooks.pl | 2 +-
cataloguing/additem.pl | 14 +-
circ/circulation.pl | 2 +-
circ/returns.pl | 40 +-
course_reserves/batch_rm_items.pl | 90 ++
docs/history.txt | 1097 ++++++++++----------
etc/SIPconfig.xml | 1 +
installer/data/mysql/kohastructure.sql | 3 +-
.../optional/marc21_sample_fastadd_framework.sql | 2 +-
.../unimarc_bibliographic_DEFAULT_local_995.sql | 1 -
...rc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +-
installer/data/mysql/sysprefs.sql | 2 +
.../optional/marc21_bibliographic_FA_local.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 66 ++
.../intranet-tmpl/prog/css/src/staff-global.scss | 3 +-
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../prog/en/includes/acquisitions-menu.inc | 7 +
.../prog/en/includes/serials-menu.inc | 9 +
.../en/modules/admin/preferences/circulation.pref | 6 +
.../prog/en/modules/admin/preferences/items.json | 1 -
.../prog/en/modules/admin/preferences/opac.pref | 4 +
.../prog/en/modules/catalogue/advsearch.tt | 18 +-
.../value_builder/unimarc_field_128a.tt | 2 +-
.../cataloguing/value_builder/unimarc_field_140.tt | 4 +-
.../prog/en/modules/circ/article-requests.tt | 113 +-
.../prog/en/modules/circ/circulation.tt | 14 +-
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 39 +-
.../en/modules/course_reserves/batch_rm_items.tt | 81 ++
.../en/modules/course_reserves/course-reserves.tt | 5 +-
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../prog/en/modules/members/merge-patrons.tt | 8 +-
.../prog/en/modules/tools/inventory.tt | 91 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 9 +
.../prog/en/modules/tools/tools-home.tt | 15 +-
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 103 +-
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 14 +
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 11 +
koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 77 ++
koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 8 +
.../bootstrap/en/includes/doc-head-close.inc | 3 +
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 1 +
.../bootstrap/en/modules/opac-advsearch.tt | 12 +
.../bootstrap/en/modules/opac-messaging.tt | 2 +-
.../bootstrap/en/modules/opac-password-recovery.tt | 25 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 82 +-
.../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 6 +-
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 14 +
opac/opac-password-recovery.pl | 2 +-
opac/opac-search.pl | 3 +-
opac/sci/sci-main.pl | 17 +-
opac/sco/sco-main.pl | 18 +-
svc/checkouts | 8 +
t/db_dependent/Circulation.t | 26 +-
t/db_dependent/Holds.t | 22 -
t/db_dependent/Installer.t | 6 +-
t/db_dependent/Koha/Acquisition/Basket.t | 31 +-
t/db_dependent/SIP/Message.t | 59 +-
t/db_dependent/selenium/basic_workflow.t | 5 +
t/lib/TestBuilder.pm | 1 +
tools/inventory.pl | 18 +-
tools/letter.pl | 3 +-
tools/tools-home.pl | 7 +
82 files changed, 1706 insertions(+), 804 deletions(-)
create mode 100755 course_reserves/batch_rm_items.pl
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_rm_items.tt
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list