[koha-commits] main Koha release repository branch master updated. v20.05.00-1280-gbc61f27b22
Git repo owner
gitmaster at git.koha-community.org
Thu Oct 8 12:09:05 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via bc61f27b2203d8f7f0dadbf7a13bb4c66e346244 (commit)
via 5f5e6c85d9d86196da802b2d9155b0d7cafad2da (commit)
via c21de86ab2d1bf5c147dfd453b195a441603e118 (commit)
via b827acf53ffde71d787123095b8524ea6bd08fd6 (commit)
via 08386fabcbfbc29f23091f6fd7838fcb362abed3 (commit)
via 64c939ca80a306af2560c99da0f58b1aeaed13c6 (commit)
via eb3d0982ae8f22fe5354fae93dc4ea13c4f07ce3 (commit)
via 6cfdd793549d86f9d607c63fceafb64290981204 (commit)
via 33ab3c690076bf78d62105502b6de54e45e766b2 (commit)
via f253c61c652cbad99280d38127bbbdc7a9af4091 (commit)
via c46f7626d4266ff0ae1bff56e5bbfea5897ec97e (commit)
from 880be262da8375edb0e27278dcab0661822f9682 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bc61f27b2203d8f7f0dadbf7a13bb4c66e346244
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Fri Aug 7 18:17:49 2020 +0000
Bug 26184: Add div element to 'items available' note in OPAC reserve template
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5f5e6c85d9d86196da802b2d9155b0d7cafad2da
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Mon Sep 14 09:39:44 2020 +0200
Bug 26449: fix web installer typo
The onboarding segment of the web installer contains a small typo
in Step 4: "Importantl:" (should be "Important:").
This patch fixes that.
Test plan: apply the patch and access the web installer, Step 4 of
the onboarding tool should no longer display the typo.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c21de86ab2d1bf5c147dfd453b195a441603e118
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 28 11:46:17 2020 +0000
Bug 26551: Correct modal markup to prevent long heading from overflowing
This patch modifies the markup of the MARC framework import and export
modals so that CSS intended only for Bootstrap buttons isn't applied to
content in the modal.
The modal dialog markup was nested inside a ".btn-group" <div>, which
carries with it CSS that prevents text wrapping. Moving the modal markup
out of the button group while keeping it inside the <td> corrects the
problem. Lines have only been shifted and reindented.
To test, apply the patch and go to Administration -> MARC bibliographic
framework.
- In the table of frameworks, from the "Actions" menu, test both
the "Import" and "Export" links. Both should work as expected.
- Confirm that the text of the heading on the "Import" modal wraps
correctly.
- Test the same operations for a framework other than the default one.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b827acf53ffde71d787123095b8524ea6bd08fd6
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Aug 11 11:22:22 2020 +0000
Bug 26191: Relocate track_login call in Auth.pm
This is a leftover from bug 22543.
Trivial move.
Test plan:
Do not apply this patch.
Pick a user that has not yet logged in today.
Only login via the opac and immediately check if borrowers.datelastseen did not change.
Apply this patch, restart, flush etc.
Only login via the opac and verify again rightaway (no further opac actions).
Now datelastseen should have been changed already.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 08386fabcbfbc29f23091f6fd7838fcb362abed3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 8 10:58:48 2020 +0200
Bug 25913: Get the correct return of AddBiblio
We need the parenthesis to get the biblionumber and not the
biblioitemnumber, in case there is a discrepancy.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 64c939ca80a306af2560c99da0f58b1aeaed13c6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 10:41:45 2020 +0200
Bug 25913: Prevent get_coins to crash if record does not have title
If a bibliographic record does not have a title, get_coins will crash
with
Can't call method "as_string" on an undefined value at /kohadevbox/koha/Koha/Biblio.pm line 645
Koha::Biblio::get_coins('Koha::Biblio=HASH(0x5558f91bb740)') called at /kohadevbox/koha/catalogue/ISBDdetail.pl line 144
We can handle that situation easily by checking the existence of the
title field.
Test plan:
1. Create a record without 245
2. Enable COinSinOpac
4. Go to the ISBD detail view
=> It must not fail with this patch applied
Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit eb3d0982ae8f22fe5354fae93dc4ea13c4f07ce3
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Sep 28 15:29:51 2020 +0000
Bug 25957: Don't push blank field values to ES document
To test:
1 - Load the sample DB or edit a record (using advanced cataloging editor) to have a blank subfield in a field that is indexed as suggestible
2 - For example 'author' / 100a
100 _ _ ‡a
3 - Index that record into Elasticsearch 5.X:
perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d
4 - Note error 'value must have length > 0'
5 - Edit mappings to set author 100a not suggestible
6 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d
7 - Success
8 - Set field to suggestible again
9 - Apply patch
10 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d
11 - Success!
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6cfdd793549d86f9d607c63fceafb64290981204
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jul 8 17:29:45 2020 +0000
Bug 25957: Unit test
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 33ab3c690076bf78d62105502b6de54e45e766b2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 20 10:10:44 2020 +0200
Bug 26260: Add missing elastic>cnx_pool to koha-conf-site.xml.in
Added by bug 22705, but only in etc/koha-conf.xml
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f253c61c652cbad99280d38127bbbdc7a9af4091
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 10 15:51:17 2020 +0200
Bug 24598: Complete transfer for hold if checked out
When an item that has triggered a hold is in transit to a library,
if the item is accidently shelved instead of scanned at the pickup library,
and then checked out to another patron, the holds shows the item still in transit
in the status, but says that it is waiting at the library, and the since date has vanished!
Test plan:
1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B
2) Check in the item at Library A to trigger the hold transfer
3) At Library B, check out the item to Patron 2 (click Yes)
=> The hold is not marked as in transit and is back to priority 1
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c46f7626d4266ff0ae1bff56e5bbfea5897ec97e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 10 15:51:13 2020 +0200
Bug 24598: Add tests
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
[EDIT] 49 to 50 tests.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 4 +-
C4/Circulation.pm | 26 +--
Koha/Biblio.pm | 3 +-
Koha/SearchEngine/Elasticsearch.pm | 4 +-
debian/templates/koha-conf-site.xml.in | 3 +
.../prog/en/modules/admin/biblio_framework.tt | 192 ++++++++++-----------
.../prog/en/modules/onboarding/onboardingstep4.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +-
t/db_dependent/Circulation.t | 59 ++++++-
t/db_dependent/Koha/Biblio.t | 13 +-
t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 17 +-
11 files changed, 209 insertions(+), 118 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list