[koha-commits] main Koha release repository branch master updated. v20.05.00-1395-g096327cfcd
Git repo owner
gitmaster at git.koha-community.org
Wed Oct 14 15:28:44 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 096327cfcd27d7abf484c3653b13e059bb9152e5 (commit)
via 76eb46f25f5f9b816776b2bf5fe6e11fcedfbad4 (commit)
via 062fce8ef2fdd90b4036454ba151ef58bead91b3 (commit)
via 1ca38d538b0c472416af33a2e6c105b14505b556 (commit)
via bea17b4975b9a8d667290b33d86e80e12eb003ce (commit)
via 0e1d291b14d4ea85ff101296e6c633fce22eb120 (commit)
via 9d76149118b3340ced055bf1b436f458589598f8 (commit)
via 88f7d9f89cb07e8d253571199435e3600f1eb768 (commit)
via 01eebf333d09b13a3a575f1eaa7a8704aeddd691 (commit)
via bb3e76f7f9e7f65fa0de2ee0fe51d09c81368480 (commit)
via 3db0ee00012e975fb18937e36015178a73d30ff0 (commit)
via c760a8d381f185d504477db90b85fc8168a9f769 (commit)
via 71c15cf502b57ad8d149097915cded46a7042326 (commit)
via f3bea26aae222f34eb123469e558196e2daf5de5 (commit)
via 7cd6fa6c6fd6fde0a981bcaa23d94af5f1532ffb (commit)
via 25e8b56b3601a01a71eb2627a39b100bd0d9c52d (commit)
via 119ddb6f12174a0a489fd45ed19e9a50d0a1ffd2 (commit)
via 7e60444b1cdf7b966d9440c2b2fbd5c41ed37e7c (commit)
via 7f61ca7f47b2962b7ffb3813815d029781ee1ebe (commit)
via 2c28e7ac5a444859594e013ee95ac8ebaf2652f8 (commit)
via ea9549ea4e213654c3954a2d247dc2ab18fe8dd1 (commit)
via 899bd08e0c272c8726e045f511a113b2b982dcd9 (commit)
via 7a7a0a2474c958e85b96db55bba04e8d90fbed31 (commit)
via a15a7f5d81bde1a728b77f9ce69d3ff6382782e0 (commit)
via b845c5601a8306704be3c00c33b95da454182359 (commit)
via f04d2accf8a99ffa390ef38cdf2101d04acbe73f (commit)
via 31eb8196ed88850cf56ec84d3bb55354023438c1 (commit)
via 5cf01e6ca06eef4a3377505bae051170fae7a118 (commit)
via 55d7d511b525a8159be3b05d4f52df18c7079ca6 (commit)
via 91ab070e2030e64e3e8615daa8b7dd4e9df54ad1 (commit)
via ac834254ad93c16af45f3c6bc17a7519018b9e03 (commit)
via 40cd70c581a6d68ce8e49f835681b0cf9b648af2 (commit)
via 7ac340e483923af88426b5061597eca80c5c4363 (commit)
via 210c62ad8c75a35fe63d1a564f4bb02f6f4b35d1 (commit)
via d09108919f8430f6d42b448e7da07a749091864b (commit)
via dab160d599ccc127d2b4bd7e50a93a2639abc9a2 (commit)
via 97b9eab178f0b45b38662747a4e009e71d8b73ff (commit)
via 3c9c7f4543a06553c6cbf04ff58a82eb6a40fc9c (commit)
via 1cd22331732f6ffef3478ebbc034aa0fba154dba (commit)
via 57182d6a043a25bda74de0e9e1320adfe930016c (commit)
via 683d6ced64a92cc391ac81b4a046bcdf2110bb83 (commit)
via ace5b632a6ed965931e1332cacb1419c16286d65 (commit)
via 1b40ee8d18b7fee42193cfb2bac5e44146a1afd9 (commit)
via 5a669249148d3f874ebc9977be9d4be6a6d92f8d (commit)
via 5545cf2860ef3f2d58b2a0c9dccccf5f21c1ed1f (commit)
via 913897f3a484ea31a2373de7aac2cc8298319575 (commit)
via c32503fcb685e3bba209ba7baba1abe560fda94c (commit)
from c12ede482f5aad8111a21127e9f42c62f2e3348b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 096327cfcd27d7abf484c3653b13e059bb9152e5
Author: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Date: Fri Oct 9 14:54:01 2020 +0000
Bug 26647: Add translation context to cancel hold button in OPAC
0) Apply the patch and add a hold on an item.
1) Install Swedish language, sv-SE and change interface language to
Swedish
2) Modify sv-SE-opac-bootstrap.po and add this:
msgctxt "Cancel hold button"
msgid "Cancel"
msgstr "Ta bort"
3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds
4) Confirm that the button is translated as "Ta bort"
5) Sign off
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 76eb46f25f5f9b816776b2bf5fe6e11fcedfbad4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 14 12:37:24 2020 +0000
Bug 12556: DBRev 20.06.00.051
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 062fce8ef2fdd90b4036454ba151ef58bead91b3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 14 14:32:48 2020 +0200
Bug 12556: Add missig POD for ->set_processing
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1ca38d538b0c472416af33a2e6c105b14505b556
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Mon Oct 12 10:55:33 2020 +0000
Bug 12556: (follow-up) Fix failing test
The method call set_waiting(1) was renamed to be set_transfer()
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bea17b4975b9a8d667290b33d86e80e12eb003ce
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Oct 12 11:06:51 2020 +0100
Bug 12556: (QA follow-up) Fix QA Script failures
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
JD amended patch, fix:
FAIL C4/RotatingCollections.pm
FAIL pod
*** WARNING: line containing nothing but whitespace in paragraph in file C4/RotatingCollections.pm
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0e1d291b14d4ea85ff101296e6c633fce22eb120
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Wed Jul 22 18:45:36 2020 +0300
Bug 12556: Add new "in processing" state to holds
This adds new syspref, HoldsNeedProcessingSIP, which controls whether
a hold that is related to item will be filled automatically or not. If
the user has enabled the syspref then instead of fulfilling the hold
automatically the hold will go to "in processing" state.
To test:
1. Checkout a book to patron A
2. Place a bib level hold to the book for B
3. Patron A returns the book via SIP, to simulate this use:
./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item <ItemBarcode> -m checkin
4. Notice that no notification is generated for Patron B about hold
and that the hold status in intranet and opac is "In Processing".
5. Notice that patron A (or other patrons) cannot checkout a book
that is in processing, because it is considered to be attached to
the holdee (similarly to the waiting state):
./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron <PatronABarcode> --item <ItemBarcode> -m checkout
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9d76149118b3340ced055bf1b436f458589598f8
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Wed Jul 22 15:44:31 2020 +0000
Bug 12556: Simplify and correct logic in holds-table.inc template
The states is_waiting and is_found are already implied by
is_at_destination. Also we would never get the 'transfered' html class
since transfer's status is T (this might not have been true in the
past but now is).
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 88f7d9f89cb07e8d253571199435e3600f1eb768
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Wed Jul 22 15:44:31 2020 +0000
Bug 12556: reserves/request.pl: Reuse code from Koha::Hold
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 01eebf333d09b13a3a575f1eaa7a8704aeddd691
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Wed Jul 22 15:44:31 2020 +0000
Bug 12556: Reuse code from Koha::Hold instead of duplicating it
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bb3e76f7f9e7f65fa0de2ee0fe51d09c81368480
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Wed Jul 22 15:44:31 2020 +0000
Bug 12556: Remove unused HTML
Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE
code path which would print "Item waiting to be pulled from [...]"
never gets executed.
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3db0ee00012e975fb18937e36015178a73d30ff0
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Wed Jul 22 15:44:31 2020 +0000
Bug 12556: Refactor hold transfer status setting to its own method
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c760a8d381f185d504477db90b85fc8168a9f769
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Sep 21 05:08:32 2020 +0000
Bug 13625: Change messaging preferences descriptions according to RenewalSendNotice
Sending out renewal notices depends on the RenewalSendNotice and the
patron having the checkout notice checked in their messaging
preferences.
To test:
- Apply patch
- Take a look at the messaging preferences table on the following pages:
- OPAC > patron account > your messaging tab
- Staff interface > patron account > details tab
- Staff interface > patron account > edit patron
- Toggle the RenewalSendNotice preferences
- The label on the last notice should switch between "Item checkout"
and "Item checkout and renewal" depending on the pref setting
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 71c15cf502b57ad8d149097915cded46a7042326
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Sep 30 18:09:19 2020 +0000
Bug 19353: Fix tests on UNIMARC
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f3bea26aae222f34eb123469e558196e2daf5de5
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Sep 30 17:40:01 2020 +0000
Bug 19353: Use xslt from distribution, not packaged installed one
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7cd6fa6c6fd6fde0a981bcaa23d94af5f1532ffb
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue Nov 7 11:51:20 2017 +0000
Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider
Test plan:
0) apply the patchset
1) setup oai server with oaiconf file defining xsl_file for metadata
format marcxml or marc21
2) play with your oai and confirm that records are transformed as
expected
3) prove t/db_dependent/OAI/Server.t
Signed-off-by: Martin Šťastný <martin.stastny at teamlibrary.cz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 25e8b56b3601a01a71eb2627a39b100bd0d9c52d
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Dec 4 02:10:31 2017 +0000
Bug 19353: Add test
Signed-off-by: Martin Šťastný <martin.stastny at teamlibrary.cz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 119ddb6f12174a0a489fd45ed19e9a50d0a1ffd2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 14 12:37:24 2020 +0000
Bug 19382: DBRev 20.06.00.050
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7e60444b1cdf7b966d9440c2b2fbd5c41ed37e7c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 14 14:19:27 2020 +0200
Bug 19382: Adjust comment in test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7f61ca7f47b2962b7ffb3813815d029781ee1ebe
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 13 13:42:58 2020 -0400
Bug 19382: (QA follow-up) Fix typos
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2c28e7ac5a444859594e013ee95ac8ebaf2652f8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Sep 10 11:04:18 2020 +0100
Bug 19382: (follow-up) Alternate tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ea9549ea4e213654c3954a2d247dc2ab18fe8dd1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Sep 3 14:25:05 2020 -0400
Bug 19382: (QA follow-up) Throw exception if only_this_guarantor is set for a non-guarantor
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 899bd08e0c272c8726e045f511a113b2b982dcd9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jul 24 09:00:12 2020 -0400
Bug 19382: Add blocking of ability to checkout on circulation.pl
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7a7a0a2474c958e85b96db55bba04e8d90fbed31
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jan 10 11:59:56 2020 -0500
Bug 19382: Add ability to block guarantees based on fees owed by guarantor and other guarantees
Some libraries would like to not only block the circulation of a guarantor based on fines owed by guarantees, but would also like to block circulation for all guarantees as well. Basically, if a family as a whole reaches a certain threshold of fines, the entire family will be blocked from checking out items.
Test Plan:
1) Apply this patch
2) Set NoIssuesChargeGuarantorsWithGuarantees to $14
3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents guarantee both children
4) Give 3 of the 4 a $5 fine
5) None of them should be able to check out items
Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a15a7f5d81bde1a728b77f9ce69d3ff6382782e0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 16 12:56:56 2020 +0200
Bug 23895: Move installer file into the mandatory directory
Prior to this patch we had a confusing situation, mandatory files were
in both installer/data/mysql and installer/data/mysql/mandatory
To make things clearer this patch move them all into the mandatory
subdir.
However kohastructure.sql stay in the "root" directory.
Test plan:
1. Drop and recreate your DB and use the installer to populate the DB
2. Use the merge request code from misc4dev to test the reset_all alias
3. Still with the merge request from misc4dev checkout master (you can
also try 19.11 and/or 19.05) and reset_all again
=> All the data from the SQL mandatory files must have been correctly
inserted into the DB
https://gitlab.com/koha-community/koha-misc4dev/-/issues/46
Note that this patch also remove the x flag for subtag_registry.sql
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b845c5601a8306704be3c00c33b95da454182359
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 25 11:34:25 2020 +0000
Bug 24899: (follow-up) Add markup comments
This patch adds comments to the template to highlight the markup
structure.
This patch should have no effect on the interface or functionality.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f04d2accf8a99ffa390ef38cdf2101d04acbe73f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Mar 18 19:14:40 2020 +0000
Bug 24899: Reindent record matching rules template
This patch reindents the template the record matching rules template.
The only non-whitespace changes where lines were combined or split.
The diff using the '-w' flag to ignore whitespace should
highlight only moved lines.
Test that functionality is unaffected: Administration -> Record matching
rules.
Test adding, editing, and deleting record matching rules. Test adding,
editing, and deleting match points and match checks. Confirm that
changes are saved correctly.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 31eb8196ed88850cf56ec84d3bb55354023438c1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sun May 3 01:04:41 2020 +0000
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts
This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.
These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.
Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.
It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5cf01e6ca06eef4a3377505bae051170fae7a118
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 14 11:49:29 2020 +0200
Bug 26327: Add exec flag on .t file
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 55d7d511b525a8159be3b05d4f52df18c7079ca6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Sep 18 16:40:01 2020 -0300
Bug 26327: (QA follow-up) Fix colspan in boraccount.tt
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 91ab070e2030e64e3e8615daa8b7dd4e9df54ad1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Sep 2 10:06:46 2020 -0300
Bug 26327: (follow-up) Add transacting library to the transactions tab
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ac834254ad93c16af45f3c6bc17a7519018b9e03
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 31 17:10:50 2020 -0300
Bug 26327: Add to columns settings
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 40cd70c581a6d68ce8e49f835681b0cf9b648af2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 31 16:35:10 2020 -0300
Bug 26327: Include transacting library in fines
This patch introduces a new column on the fines table to display the
checkout library when the fine is tied to a checkout.
To test:
1. Have an overdue item that generated a fee
2. Look at the 'Accounting' tab, 'Make a payment'
=> FAIL: There's no information about the library
3. Apply this patch
4. Restart all
5. Reload and repeat 2
=> SUCCESS: There's a column with the library name!
6. Identify the issue_id for the mentioned checkout and:
$ koha-mysql kohadev
> UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11;
(i.e. set the branchcode to an invalid value, to emulate a deleted
branch).
7. Reload
=> SUCCESS: It doesn't explode, it doesn't display a library name.
8. Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7ac340e483923af88426b5061597eca80c5c4363
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 31 15:25:05 2020 -0300
Bug 26327: Add ->library method to Koha::*Checkout
This patch adds a 'library' relationship to the Issue and OldIssue
resultsets, to be used in the Koha::*Checkout classes corresponding
accessors. This way we will be able to eventually embed and filter on
library fields on the API.
The ->library method is then added to the classes-
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 210c62ad8c75a35fe63d1a564f4bb02f6f4b35d1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 14 15:21:55 2020 +0000
Bug 26456: (follow-up) Add markup comments
This patch adds comments to the template to highlight the markup
structure.
Also changed: Some form hints have been wrapped in <div class="hint"> to
make it consistent with other pages.
This patch should have no effect on functionality.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d09108919f8430f6d42b448e7da07a749091864b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 14 15:09:26 2020 +0000
Bug 26456: Reindent MARC subfield structure template
This patch reindents the MARC subfield structure template.
The only non-whitespace changes where lines were combined or split.
The diff using the '-w' flag to ignore whitespace should
highlight only moved lines.
Test that functionality is unaffected: Administration -> MARC
bibliographic framework -> MARC structure -> Edit subfields..
Test adding, editing, and deleting subfields. Confirm that changes are
saved correctly.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dab160d599ccc127d2b4bd7e50a93a2639abc9a2
Author: Henry Bolshaw <bolshawh at parliament.uk>
Date: Sat Oct 10 00:24:36 2020 +0000
Bug 26655: Add ARIA Labels to OPAC Lists
This patch adds ARIA labels to opac-shelves.tt
so that checkboxes for list items are meaningful
to users of screenreaders and other assistive
technology.
Test Plan:
1/ Open an OPAC list
2/ Inspect the checkbox for a list item
3/ Confirm the aria-label is missing
4/ Apply the patch
5/ Refresh the Opac list page
6/ Inspect the checkbox for a list item
7/ Note that there is now an aria-label with a
meaningful description
8/Sign off
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 97b9eab178f0b45b38662747a4e009e71d8b73ff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 15:15:46 2020 +0200
Bug 20804: Add support for "days" to the timeout syspref
If the timeout syspref did not contain an integer, or was not matching
integer.'d|D', then it "fallback" to 0
We can easily add support for hours and fallback to 600 if the value is
not correct.
It will prevent the session to timeout immediately
Test plan:
0. Do not apply the patches
1. Fill the timeout syspref with "5h"
2. Login
3. Click somewhere
=> Notice that the session timed out
4. Apply the patches, restart_all
5. Login
6. Click somewhere
=> You have 5 hours to enjoy Koha
7. Fill the pref with an incorrect value ("5x" for instance)
8. Logout, login
9. There is a warning in the log, and you have 10 minutes (600 secondes) to enjoy Koha
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3c9c7f4543a06553c6cbf04ff58a82eb6a40fc9c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 15:15:36 2020 +0200
Bug 20804: Add tests
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1cd22331732f6ffef3478ebbc034aa0fba154dba
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Jul 18 14:52:06 2020 +0200
Bug 26018: Fix frameworks errors with subfields in wrong tab
All subfields for a MARC21 field should always be in the same tab.
There were some mistakes found by the "MARC bibliographic framework
test" this fixes.
Before you apply the patch:
- Check the "MARC bibliographic framework test" page
- Ideally you should see the "wrong tab" mistakes
- Reset your db (reset_all) or drop your db and run the web installer
- Verify the page no longer points out any issues
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 57182d6a043a25bda74de0e9e1320adfe930016c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Oct 4 03:23:24 2020 +0000
Bug 9118: (QA follow-up) Fix spelling on "To Date :"
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 683d6ced64a92cc391ac81b4a046bcdf2110bb83
Author: Emmi Takkinen <emmi.takkinen at outlook.com>
Date: Mon Oct 5 11:19:44 2020 +0300
Bug 9118: Do not show option to create exception on range for unique holiday
When an unique holiday is edited one can choose
option 'Generate exceptions on a range of dates.'
Exceptions are meant to be used with repeating
holidays and it makes no sense to have option to
be able to create one for an unique holiday.
This patch hides exception on range option when
editing an unique holiday. Also fixes a minor
spelling error.
To test:
1. Create unique holiday and edit it.
2. Note that option to create exception on range is shown.
3. Apply patch.
=> Option is now hidden.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ace5b632a6ed965931e1332cacb1419c16286d65
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Sat Sep 5 05:26:47 2020 +0000
Bug 26389: Add auto renewal error to opac-user.tt
Test plan:
1 Check out an auto-renewing item to a patron
2 confirm in circ rules that the rule allows at least one renewal
3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal
4 click Renew All
5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons
6 Apply patch
7 Repeat 3-5
8 See appropriate error
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1b40ee8d18b7fee42193cfb2bac5e44146a1afd9
Author: Emmi Takkinen <emmi.takkinen at outlook.com>
Date: Fri Sep 25 13:52:06 2020 +0300
Bug 26429: Show correct expiration date at the request.pl
Bug 25789 changed holds tables expriration input class as "datepickerto".
This results to past expiration date to be displayed as tomorrows date.
Class "futuredate" should have been used instead.
To test:
1. Have waiting hold with expiration date in past (e.g 24.9)
2. Observe that waiting reserves table displays correct expiration date
3. At the request.pl page expiration date is however displayed as 26.9
=> Apply patch
4. Confirm that expiration date at the request.pl is now 24.9
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5a669249148d3f874ebc9977be9d4be6a6d92f8d
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Sep 25 17:08:38 2020 +0200
Bug 26538: Display cities list before input text
In patron creation or edition actually the city field is displayed with input text then cities list.
I propose to display cities list first since it is more likely used.
Test plan :
1) Create some cities
2) Open patron creation form
3) Check you see for each city field : cities list, text "or enter", text input
4) Delete all cities
5) Open patron creation form
6) Check you see for each city field : only text input
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5545cf2860ef3f2d58b2a0c9dccccf5f21c1ed1f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Sep 30 15:46:45 2020 +0000
Bug 26576: Subfield descriptions on authority detail view are cut off
This patch corrects the authority detail view on the staff interface so
that subfield descriptions are not longer output as truncated strings.
For instance, before this patch the subfield description for 035$a would
be "System control numbe"
After the patch it should be "System control number."
Based on the assumption that the subfield descriptions were truncated at
some point for readability reasons I've also made some style changes
intended to improve the readability of the page.
To test, apply the patch and go to Authorities.
- Search for and view the details for an authority.
- On the authority detail page, confirm that subfield descriptions are
shown in full.
- Confirm that the style changes look good and make the data more
readable.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 913897f3a484ea31a2373de7aac2cc8298319575
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Tue Sep 29 05:53:34 2020 +0000
Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled
Test plan:
1. Check the OAI-PMH:AutoUpdateSets syspref is disabled
2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass
successfully
3. Enabled the OAI-PMH:AutoUpdateSets syspref
4. Repeat step 2 and confirm the tests fail
5. Apply this patch and restart plack: sudo koha-plack --restart
<instance>
6. Repeat step 2 and confirm the tests now pass
7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and
confirm tests still pass
Sponsored-By: Catalyst IT
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c32503fcb685e3bba209ba7baba1abe560fda94c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 14 11:17:46 2020 +0200
Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 14 +-
C4/Circulation.pm | 15 +
C4/Installer.pm | 15 +-
C4/Reserves.pm | 30 +-
C4/RotatingCollections.pm | 17 +-
C4/SIP/ILS/Item.pm | 24 +-
C4/SIP/ILS/Patron.pm | 10 +-
C4/SIP/ILS/Transaction/Checkout.pm | 6 +-
Koha.pm | 2 +-
Koha/Checkout.pm | 15 +
Koha/Hold.pm | 60 +-
Koha/OAI/Server/Record.pm | 7 +-
Koha/Old/Checkout.pm | 16 +
Koha/Patron.pm | 47 +
Koha/Schema/Result/Issue.pm | 12 +
Koha/Schema/Result/OldIssue.pm | 10 +
admin/columns_settings.yml | 4 +
cataloguing/value_builder/EXAMPLE.pl | 13 +-
cataloguing/value_builder/barcode.pl | 6 +-
cataloguing/value_builder/barcode_manual.pl | 6 +-
cataloguing/value_builder/callnumber-KU.pl | 2 +-
cataloguing/value_builder/callnumber.pl | 2 +-
cataloguing/value_builder/cn_browser.pl | 4 +-
cataloguing/value_builder/dateaccessioned.pl | 4 +-
cataloguing/value_builder/macles.pl | 4 +-
cataloguing/value_builder/marc21_field_005.pl | 6 +-
cataloguing/value_builder/marc21_field_006.pl | 4 +-
cataloguing/value_builder/marc21_field_007.pl | 4 +-
cataloguing/value_builder/marc21_field_008.pl | 4 +-
.../value_builder/marc21_field_008_authorities.pl | 4 +-
.../marc21_field_008_classifications.pl | 4 +-
cataloguing/value_builder/marc21_field_245h.pl | 6 +-
cataloguing/value_builder/marc21_leader.pl | 4 +-
.../value_builder/marc21_leader_authorities.pl | 6 +-
.../value_builder/marc21_linking_section.pl | 2 +-
cataloguing/value_builder/marc21_orgcode.pl | 4 +-
cataloguing/value_builder/normarc_field_007.pl | 4 +-
cataloguing/value_builder/normarc_field_008.pl | 4 +-
cataloguing/value_builder/normarc_leader.pl | 4 +-
cataloguing/value_builder/stocknumber.pl | 4 +-
cataloguing/value_builder/stocknumberam123.pl | 2 +-
cataloguing/value_builder/unimarc_field_010.pl | 2 +-
cataloguing/value_builder/unimarc_field_100.pl | 2 +-
.../value_builder/unimarc_field_100_authorities.pl | 2 +-
cataloguing/value_builder/unimarc_field_105.pl | 2 +-
cataloguing/value_builder/unimarc_field_110.pl | 2 +-
cataloguing/value_builder/unimarc_field_115a.pl | 2 +-
cataloguing/value_builder/unimarc_field_115b.pl | 2 +-
cataloguing/value_builder/unimarc_field_210c.pl | 2 +-
.../value_builder/unimarc_field_210c_bis.pl | 2 +-
cataloguing/value_builder/unimarc_field_225a.pl | 4 +-
.../value_builder/unimarc_field_225a_bis.pl | 2 +-
cataloguing/value_builder/unimarc_field_4XX.pl | 2 +-
cataloguing/value_builder/upload.pl | 2 +-
circ/circulation.pl | 19 +
circ/returns.pl | 26 +-
.../marc21/mandatory/marc21_framework_DEFAULT.yml | 20 +-
.../mysql/{ => mandatory}/account_credit_types.sql | 0
.../mysql/{ => mandatory}/account_debit_types.sql | 0
.../mysql/{ => mandatory}/account_offset_types.sql | 0
.../data/mysql/{ => mandatory}/audio_alerts.sql | 0
installer/data/mysql/mandatory/subtag_registry.sql | 0
installer/data/mysql/{ => mandatory}/sysprefs.sql | 6 +-
installer/data/mysql/{ => mandatory}/userflags.sql | 0
.../data/mysql/{ => mandatory}/userpermissions.sql | 0
installer/data/mysql/updatedatabase.pl | 20 +
.../intranet-tmpl/prog/en/includes/holds_table.inc | 12 +-
.../prog/en/includes/member-alt-address-style.inc | 4 +-
.../prog/en/includes/member-alt-contact-style.inc | 5 +-
.../prog/en/includes/member-main-address-style.inc | 4 +-
.../prog/en/includes/messaging-preference-form.inc | 7 +-
.../en/modules/admin/marc_subfields_structure.tt | 679 +++++++------
.../prog/en/modules/admin/matching-rules.tt | 1074 ++++++++++----------
.../en/modules/admin/preferences/circulation.pref | 11 +
.../prog/en/modules/authorities/detail.tt | 98 +-
.../prog/en/modules/circ/circulation.tt | 22 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 32 +-
.../prog/en/modules/members/boraccount.tt | 8 +-
.../prog/en/modules/members/holdshistory.tt | 2 +
.../intranet-tmpl/prog/en/modules/members/pay.tt | 8 +-
.../prog/en/modules/tools/holidays.tt | 17 +-
.../bootstrap/en/includes/holds-table.inc | 37 +-
.../bootstrap/en/modules/opac-messaging.tt | 7 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 7 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +
offline_circ/process_koc.pl | 2 +-
opac/sco/sco-main.pl | 2 +-
reserve/request.pl | 15 +-
t/db_dependent/Auth.t | 21 +-
t/db_dependent/Hold.t | 22 +-
.../Koha/{Acquisition/Fund.t => Checkout.t} | 24 +-
t/db_dependent/Koha/Old.t | 40 +-
t/db_dependent/Koha/Patron.t | 126 ++-
t/db_dependent/OAI/Server.t | 32 +-
t/db_dependent/OAI/Sets.t | 30 +-
t/db_dependent/OAI/oaiconf.yaml | 7 +
t/db_dependent/api/v1/holds.t | 4 +-
97 files changed, 1738 insertions(+), 1153 deletions(-)
rename installer/data/mysql/{ => mandatory}/account_credit_types.sql (100%)
rename installer/data/mysql/{ => mandatory}/account_debit_types.sql (100%)
rename installer/data/mysql/{ => mandatory}/account_offset_types.sql (100%)
rename installer/data/mysql/{ => mandatory}/audio_alerts.sql (100%)
mode change 100755 => 100644 installer/data/mysql/mandatory/subtag_registry.sql
rename installer/data/mysql/{ => mandatory}/sysprefs.sql (99%)
rename installer/data/mysql/{ => mandatory}/userflags.sql (100%)
rename installer/data/mysql/{ => mandatory}/userpermissions.sql (100%)
copy t/db_dependent/Koha/{Acquisition/Fund.t => Checkout.t} (61%)
create mode 100644 t/db_dependent/OAI/oaiconf.yaml
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list