[koha-commits] main Koha release repository branch master updated. v20.05.00-1442-g7d20cafc4f

Thu Oct 15 15:55:06 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  7d20cafc4f8472fb07ba9ffa8f2a9432bf5847f4 (commit)
       via  8e70a863dd22e3a48c115b43852adda608efd3f7 (commit)
       via  23fd3de316bbd94c691dd3941d31aff84177c389 (commit)
       via  870ef9e2d9046914e198d7c03fa64b4b89de3b41 (commit)
       via  14820607c43b6e760ba2edadfb14436f2685a1fe (commit)
       via  6f940b5fe90518112db612d7e19aa1419a6ef84e (commit)
       via  7941b4b039b3a31a56f9a4bf9d709c546534434e (commit)
       via  be95bc913740d97562f954a8744fc670483db7ec (commit)
       via  a9de5bd0eef958291a9a51cca2de9aa49a248b77 (commit)
       via  2d4d50ab290878a5aafef90470f5a5d977d689d7 (commit)
       via  8f815e748feba1c44ccf8733b6a01642c56f4eec (commit)
       via  1557bf0100f4bf67cf0d98a181a04a2e49b906cd (commit)
       via  d576f887c1a0451d45eb0cda055f974916f011c7 (commit)
       via  aa69ef69722af8c9a2b9afd780b8f1ff68c32a9b (commit)
      from  35a3b9e6b9288558a708f97ae190f96e8bbac8d1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7d20cafc4f8472fb07ba9ffa8f2a9432bf5847f4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 15 15:17:46 2020 +0200

    Bug 26515: Don't need to call safe_to_delete

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8e70a863dd22e3a48c115b43852adda608efd3f7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 30 12:03:41 2020 -0300

    Bug 26580: Remove unused C4::Acquisition::DelBasket function

    Bug 26577 removed the only use of it.

    To test:
    1. Apply this patch
    2. Run:
       $ git grep DelBasket
    => SUCCESS: Only finds references to DelBasketGroup
    3. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 23fd3de316bbd94c691dd3941d31aff84177c389
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 30 11:47:03 2020 -0300

    Bug 26579: Remove unused C4::Acquisition::DelOrder function

    This patch removes an unused function, its tests, and adjusts other test
    files that relied on it by replacing it with $order->cancel calls.

    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/Acquisition.t \
               t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t \
               t/db_dependent/Acquisition/close_reopen_basket.t
    => SUCCESS: Tests pass!
    2. Apply this patch
    3. Repeat (1)
    => SUCCESS: Tests pass!
    4. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 870ef9e2d9046914e198d7c03fa64b4b89de3b41
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 30 11:14:37 2020 -0300

    Bug 26577: Make basket.pl and cancelorder.pl use ->cancel

    This patch makes the mentioned controller scripts use the new
    $order->cancel method instead of DelOrder.

    To test:
    1. Apply this patches
    2. Have a basket with some orders
    3. Play with cancelling orders and removing baskets
    => SUCCESS: No behaviour change!
    => SUCCESS: No errors!
    4. Sign off :-D

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 14820607c43b6e760ba2edadfb14436f2685a1fe
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Oct 15 09:37:56 2020 -0300

    Bug 26515: (QA follow-up) Preserve original behaviour

    This patch removes the use of $self->items->safe_delete, as we don't
    want to change the current behaviour (i.e. delete what can be deleted)
    As safe_delete would rollback entirely, there was a behaviour change.

    Now items are deleted in a loop that catches any problem and reports it
    using the new ->add_message mechanism. The $item object is added to the
    message payload so it doesn't need to be queried by the caller for
    providing UI feedback.

    Tests are augmented accordingly,

    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Acquisition/Order.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6f940b5fe90518112db612d7e19aa1419a6ef84e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Oct 9 17:01:29 2020 -0300

    Bug 26515: Better feedback on errors

    This patch makes the possible causes of biblio removal failure to be
    specified on the passed error message. This way the UI could render
    better reports on the situation.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7941b4b039b3a31a56f9a4bf9d709c546534434e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 8 12:16:49 2020 +0200

    Bug 26515: Remove branchcode from mock_userenv

    It's the default behaviour of mock_userenv

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit be95bc913740d97562f954a8744fc670483db7ec
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 30 11:06:34 2020 -0300

    Bug 26515: (follow-up) Do not count self when checking orders

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a9de5bd0eef958291a9a51cca2de9aa49a248b77
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 23 11:36:21 2020 -0300

    Bug 26515: Add Koha::Acquisition::Order->cancel

    This patch introduces an OO replacement for DelOrder. It does the same
    thing. It doesn't die when trying to delete items or biblio. It sets an
    error message on the order object so the caller knows what happened.

    To test:
    1. Apply this patches
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Acquisition/Order.t
    => SUCCESS: Tests pass!
    3. Read the tests carefully to understand how they cover all use cases.
    4- Sign off :-D

    Sponsored-by: ByWater Solutions
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2d4d50ab290878a5aafef90470f5a5d977d689d7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 23 11:35:53 2020 -0300

    Bug 26515: Unit tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8f815e748feba1c44ccf8733b6a01642c56f4eec
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Oct 15 09:35:43 2020 -0300

    Bug 26555: (QA follow-up) Add a 'payload' attribute for carrying useful things

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1557bf0100f4bf67cf0d98a181a04a2e49b906cd
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 30 09:42:18 2020 -0300

    Bug 26555: Make sure _messages is always initialized

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d576f887c1a0451d45eb0cda055f974916f011c7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Sep 28 10:49:24 2020 -0300

    Bug 26555: Add ->messages and ->add_message to Koha::Object

    This patch adds a way to make Koha::Object-derived classes to carry
    messages around. This targets non-fatal errors, or around action flags
    for the caller, to avoid complex exception handling on the controllers when
    it is not expected to be fatal.

    To test:
    1. Apply this patchset
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Object.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit aa69ef69722af8c9a2b9afd780b8f1ff68c32a9b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Sep 28 10:23:50 2020 -0300

    Bug 26555: Add Koha::Object::Message

    This patch introduces a tiny class for encapsulating execution messages in
    Koha::Object derived classes.

    To test:
    1. Apply this patch
    2. Run;
       $ kshell
      k$ prove t/Koha/Object/Message.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |  91 +------
 Koha/Acquisition/Order.pm                          |  98 +++++++
 Koha/Object.pm                                     |  47 ++++
 Koha/Object/Message.pm                             |  80 ++++++
 acqui/basket.pl                                    |  67 ++---
 acqui/cancelorder.pl                               |  18 +-
 t/Koha/Object/Message.t                            |  56 ++++
 t/db_dependent/Acquisition.t                       |  41 +--
 .../Acquisition/GetBasketsInfosByBookseller.t      |   4 +-
 t/db_dependent/Acquisition/close_reopen_basket.t   |   4 +-
 t/db_dependent/Koha/Acquisition/Order.t            | 303 ++++++++++++++++++++-
 t/db_dependent/Koha/Object.t                       |  33 ++-
 12 files changed, 665 insertions(+), 177 deletions(-)
 create mode 100644 Koha/Object/Message.pm
 create mode 100755 t/Koha/Object/Message.t

hooks/post-receive
-- 
main Koha release repository