[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.10-19-g7499703bf0

Tue Oct 20 05:01:45 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  7499703bf0ff899dd28104c8f083c23aca01a438 (commit)
       via  17c44ac5ca732aa8c913164987478065533c87d3 (commit)
       via  56baaffb559861f2f938eaa5c66088b7f414ea6b (commit)
       via  8383009cc64698a4a0f28255702075e200ef2a98 (commit)
       via  c93f56c5baa6535c160ecb9adfad38a87a04f47a (commit)
       via  f6793697737ec08802cfe9a7f224767e0d0d89fb (commit)
       via  39dd8a565d27ddd70fd7c14abe4770cd6e6cc0ba (commit)
      from  af554209575a7e6f137ec1dd09f3b773c4058e9b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7499703bf0ff899dd28104c8f083c23aca01a438
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Tue Oct 20 14:37:38 2020 +1300

    Bug 18958: DBIC

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit 17c44ac5ca732aa8c913164987478065533c87d3
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Tue Oct 20 14:36:25 2020 +1300

    Bug 18958: DBRev 19.11.10.001

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit 56baaffb559861f2f938eaa5c66088b7f414ea6b
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Oct 16 17:00:17 2020 +0000

    Bug 18958: (Rmaint follow-up) Adjust number of tests

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 2e5961b2c3e3cf9c74ff0689dcd4b38da1154418)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit 8383009cc64698a4a0f28255702075e200ef2a98
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Aug 25 10:35:02 2020 +0000

    Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types

    MapItemsToHoldRequests has three sections: Local holds, item level holds, bib level holds

    Only one of them was setting the reserve_id. This patch makes al three set it and adds tests

    To test:
    1 - Repeat test plan on bug
    2 - sudo koha-mysql kohadev
        SELECT * FROM hold_fill_targets
    3 - Ensure reserve_id is set at appropriate times
    4 - prove -v  t/db_dependent/HoldsQueue.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Bug 18958: (QA follow-up) Fix number of tests

    In HoldsQueue.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit b255ca7c6eec7be3027e6ade00d8477102062281)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit bac2e6892a817482f14249aceb1420c2700416d6)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit c93f56c5baa6535c160ecb9adfad38a87a04f47a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Aug 22 03:12:36 2020 +0000

    Bug 18958: (QA follow-up) Add missing comma to kohastructure.sql

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 5cfbe318d84dbaf1af8699f3e499f2c3e312a7af)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit dbb9e36c68de686a9f6f6b8ba63c2f58006bd6d5)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit f6793697737ec08802cfe9a7f224767e0d0d89fb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Aug 14 11:06:40 2020 +0000

    Bug 18958: Make hold_fill_targets specific to reserves

    After looking at Marcel's comments, the problem is in our matching
    to hold_fill_targets - rather than adjusting to find filled/waiting holds we
    could ensure that hold_fill_targets only refers to the specific hold it
    is intended to

    This patch is clearer, if slightly less performant than last (we now return all
    the reserves and have to find the 'highest')

    Test Plan:
     1 - Create and use a patron that can place multiple record level holds per record
     2 - Create a record with X items, each at a different library
     3 - Place X 'Next available' holds on the record for the patron using the 'Holds to place' box
     4 - perl misc/cronjobs/holds/build_holdsqueue.pl
     5 - Check in LibraryA's copy as LibraryA and confirm the hold
     6 - Revisit request.pl for the record, notice the next hold in line is now item-specific
     7 - Checkout the item to the patron, notice the remaining hold is marked waiting
     8 - Attempt to place another hold for your patron, notice that it requires an item-specific hold
     8 - Apply this patch
     9 - Repeat steps 1-5
    10 - Revisit request.pl for the record, notice the next hold in line has *not* become item-specific
    11 - Checkout the item to the patron, ensure the first hold is filled and the second remains record level
    12 - Repeat whole test plan without building holds queue to confirm holds are still treated correctly

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 0bfe336c7b0a8993411bd45b9e7c66228730f86d)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit a120656eca586ecd2005421e37fbf8485131ea45)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit 39dd8a565d27ddd70fd7c14abe4770cd6e6cc0ba
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Aug 12 18:41:24 2019 +0000

    Bug 18958: Unit tests

    Signed-off-by: Bonnie Gardner <bgardner at cityoflewiston.org>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    JD amended patch: perltidy and simplify item/biblio creation

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 7ee2495f321198548b3ffbf983aa1d13f6c6c2cc)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit e4b60c41566b0e602bde1301d88f3d8803ff75bc)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/HoldsQueue.pm                       | 11 +++--
 C4/Reserves.pm                         |  6 +--
 Koha.pm                                |  2 +-
 Koha/Schema/Result/HoldFillTarget.pm   | 11 ++++-
 installer/data/mysql/kohastructure.sql |  1 +
 installer/data/mysql/updatedatabase.pl | 11 +++++
 t/db_dependent/HoldsQueue.t            | 12 +++--
 t/db_dependent/Reserves.t              | 82 +++++++++++++++++++++++++++++++++-
 8 files changed, 121 insertions(+), 15 deletions(-)

hooks/post-receive
-- 
main Koha release repository