From gitmaster at git.koha-community.org Tue Sep 1 12:53:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Sep 2020 10:53:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-864-g76bd932296 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 76bd9322962ca42e612bf7a7015a3cd0f28922c2 (commit) via 9be6b76a7bd702177bc0e1c32fd321e58f39efae (commit) from 092276f53c0b82c1311afe9425d13d83a528ca12 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 76bd9322962ca42e612bf7a7015a3cd0f28922c2 Author: Jonathan Druart Date: Tue Sep 1 12:22:06 2020 +0200 Bug 19889: Add new attribute to the REST API definition It fixes t/db_dependent/api/v1/items.t Signed-off-by: Jonathan Druart commit 9be6b76a7bd702177bc0e1c32fd321e58f39efae Author: Jonathan Druart Date: Tue Sep 1 12:11:54 2020 +0200 Bug 25504: Fix failing tests Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: api/v1/swagger/definitions/item.json | 4 ++++ t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 17 +++++++++++++---- 2 files changed, 17 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 1 16:33:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Sep 2020 14:33:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-865-g4009bb04ad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4009bb04ad857ef042bba9a4d690dd21d84ac3dd (commit) from 76bd9322962ca42e612bf7a7015a3cd0f28922c2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4009bb04ad857ef042bba9a4d690dd21d84ac3dd Author: Jonathan Druart Date: Tue Sep 1 16:01:49 2020 +0200 Revert "Bug 25242: Improve column wrapping and overflow for tables" This reverts commit a3a09d09e3b32c0a0f2e9b7acf652abeab694353. And also reverts the 3 other commits from bug 25242. Revert "Bug 25242: Compiled CSS" This reverts commit 198bbfa4094da1bfe143eb046d0c36bf68a93ab9. Revert "Bug 25242: (QA follow-up) Remove deprecated break-word" This reverts commit c3680149be734959d8b59223b083efdfb271580d. Revert "Bug 25242: (QA follow-up) Colwidth on results table" This reverts commit 84cbf0b9379d025d68f381e6dc7ca3772cc7d093. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 11 ----------- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- 3 files changed, 2 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 2 00:59:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Sep 2020 22:59:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-2-g7a34b88885 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 7a34b88885c13a89cd713bb76eadef11472c1960 (commit) via 90fdf1fa07e24fa80dac3460849f543565cfcb6a (commit) from d3b130d1ab1f8c751912accc4c5371c7a7298825 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7a34b88885c13a89cd713bb76eadef11472c1960 Author: Jonathan Druart Date: Fri Aug 21 14:00:51 2020 +0200 Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia commit 90fdf1fa07e24fa80dac3460849f543565cfcb6a Author: Nick Clemens Date: Tue Aug 4 13:13:43 2020 +0000 Bug 26136: Prevent double submit on checkin-form To test: 1 - Browse to Circulation->Check-in 2 - Type a barcode into the Check in box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Signed-off-by: Sally Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart (cherry picked from commit 44f54aac602ae99d83d954a2f102d77ff93ecfa7) (cherry picked from commit 9d85636bf0db1350fb4f7e83e6cca2fcc0b1038b) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/XISBN.pm | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 1 + 2 files changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 2 16:04:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 Sep 2020 14:04:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-894-g5b845b9e8a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5b845b9e8ab25001b0682920cea45662165f60f0 (commit) via c41597add3e5cd47109215f30bff889b9ae49176 (commit) via 4c087b1e594fa6a8fa5309baea29a67159c7c229 (commit) via f1658744c6597d3ea8a02e4e9419f133aad830a2 (commit) via bec601db345258bc35ee613943cbf98828ae3541 (commit) via 62acc69c719049ddf36e39b1b29b1fa061b6ab54 (commit) via 8ec59f19302654244f18aa5942aef13acbf24fc9 (commit) via abf63eb93b271a5957bc040c153ea10b9afa867e (commit) via 883d404a1a68031aef60e867434cf513dcc013d7 (commit) via a168e647bbb1da5a338fc4cda618adcde1ac7324 (commit) via ede8546e2b03199832637e7e79b3ab980edc47db (commit) via 75bb7b5b2e27060f1ca25313eac5a003df4f334b (commit) via 9205bc1ec34e71995540d532d22ba4c63a593eaf (commit) via e10dc503289e8d7e8c742af0111acb79d4d53111 (commit) via 2a0ccf7af26236db9a3e40968cf8f43bc308f142 (commit) via 7fc7427dd41ce10070a6a3d3070fb660850be511 (commit) via ce7f4d16d6acdc6a56d40e6ebd96d722f1c77387 (commit) via 024bb186e683f8da9b862ca70a65599325dd4737 (commit) via 17a2d577944e016d597ccc5198793e5b48917e69 (commit) via c3033ae17c2c4c9f846a0c405a682469303c614f (commit) via 60f215b3b8e13d6a41822a83968cf6a5d6f3ee06 (commit) via 5e6f889063f524555fb078927af40b1408a1616a (commit) via cd4d7322962c155f3fd6653feed73cf2e405d3eb (commit) via 0c30554759ccabaa01bb5f566b77dbc63fdda924 (commit) via 10c2eb01c977eeef6c55dc1999c0af8b60055252 (commit) via 9475a7db68c6237d3328c1c978b2ae678bb907f1 (commit) via db47dbe56a2e7930b08c4036afc441a18c74af45 (commit) via b56ad54f49ec50ad5b0df8d7887982a34249b56d (commit) via c0adeab58feaa7fb0b5c97e55b8356bb916aa163 (commit) from 4009bb04ad857ef042bba9a4d690dd21d84ac3dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5b845b9e8ab25001b0682920cea45662165f60f0 Author: Joonas Kylmälä Date: Wed Jul 15 15:50:43 2020 +0000 Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c41597add3e5cd47109215f30bff889b9ae49176 Author: Kyle M Hall Date: Thu Apr 9 13:22:01 2020 -0400 Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer Bug 25101: (QA follow-up) Fix hint for new option Signed-off-by: Jonathan Druart commit 4c087b1e594fa6a8fa5309baea29a67159c7c229 Author: Jonathan Druart Date: Wed Sep 2 15:05:26 2020 +0200 Bug 21066: DBIC schema changes Signed-off-by: Jonathan Druart commit f1658744c6597d3ea8a02e4e9419f133aad830a2 Author: Jonathan Druart Date: Wed Sep 2 14:36:32 2020 +0200 Bug 21066: Rename publicationdate with published_on Signed-off-by: Jonathan Druart commit bec601db345258bc35ee613943cbf98828ae3541 Author: Jonathan Druart Date: Wed Sep 2 14:05:13 2020 +0200 Bug 21066: DBRev 20.06.00.033 Signed-off-by: Jonathan Druart commit 62acc69c719049ddf36e39b1b29b1fa061b6ab54 Author: Marcel de Rooy Date: Mon Aug 31 08:21:34 2020 +0000 Bug 21066: (QA follow-up) Check for field existence in db rev Test plan: Run the upgrade twice. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8ec59f19302654244f18aa5942aef13acbf24fc9 Author: Katrin Fischer Date: Wed Aug 26 21:14:50 2020 +0200 Bug 21066: (QA follow-up) Fix publication date display in OPAC The date would no longer show, changed the variable name and removed the hours, as the field in the database is a date and not a datetime. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit abf63eb93b271a5957bc040c153ea10b9afa867e Author: Marcel de Rooy Date: Tue Aug 4 11:33:44 2020 +0000 Bug 21066: Update translated news and notices Replace timestamp by publicationdate in translations. Applies to sample notices and sample news. Test plan: Run a new install or pick a sql file and run it on cmdline. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 883d404a1a68031aef60e867434cf513dcc013d7 Author: Marcel de Rooy Date: Tue Aug 4 11:30:46 2020 +0000 Bug 21066: Update English sample notices Applies to sample notices and sample news. Replace timestamp by publicationdate. Also adjust notice in TemplateToolkit.t. Test plan: Run dbrev and verify if ISSUESLIP refers to opac_news.publicationdate. Run t/db_dependent/Letters/TemplateToolkit.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit a168e647bbb1da5a338fc4cda618adcde1ac7324 Author: Marcel de Rooy Date: Mon Aug 3 14:27:24 2020 +0000 Bug 21066: Update NewsChannels.t Removing the weird '' => 1 from the hash too. NOTE: The following line in the module seems to be useless: $data->{$data->{'lang'}} = 1 if defined $data->{lang}; Test plan: Run t/db_dependent/NewsChannels.t Run t/db_dependent/Koha/News.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ede8546e2b03199832637e7e79b3ab980edc47db Author: Marcel de Rooy Date: Mon Aug 3 13:41:11 2020 +0000 Bug 21066: Resolve SQL errors in strict mode DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO opac_news ( content,number,lang,title,branchcode,borrowernumber,expirationdate,publicationdate ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0="test", 1="", 2="", 3="test", 4=undef, 5="51", 6='2020-08-11', 7='2020-08-04'] at /usr/share/koha/C4/NewsChannels.pm line 68. DBD::mysql::st execute failed: Incorrect integer value: 'a' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "UPDATE opac_news SET lang = ?,publicationdate = ?,expirationdate = ?,number = ?,content = ?,branchcode = ?,title = ? WHERE idnew = ?;" with ParamValues: 0="", 1='2020-08-03', 2=undef, 3="a", 4="test", 5=undef, 6="test", 7="9"] at /usr/share/koha/C4/NewsChannels.pm line 107. Test plan: Do not apply this patch. Enable strict mode in koha-conf. Add new record in tools/news leaving 'Appear in position' blank. The record is not added; you have a warn in your plack-error log. Apply patch and try again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 75bb7b5b2e27060f1ca25313eac5a003df4f334b Author: Marcel de Rooy Date: Tue Jul 17 16:11:01 2018 +0200 Bug 21066: Code changes needed for replacing opac_news.timestamp Test plan: Perform some CRUD operations on the news page in staff. Verify that news on opac and staff respect publicationdate. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 9205bc1ec34e71995540d532d22ba4c63a593eaf Author: Marcel de Rooy Date: Tue Jul 17 15:47:57 2018 +0200 Bug 21066: Database revision Change timestamp to publicationdate, add updated_on as 'real' timestamp. Test plan: Run install or upgrade. Check table opac_news. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e10dc503289e8d7e8c742af0111acb79d4d53111 Author: Jonathan Druart Date: Thu Aug 20 14:32:43 2020 +0200 Bug 24147: Don't assume search_related will return ordered values This test is failing randomly because it assume the order is always the same. But it's not. Note: Koha::Objects->search_related is never used , last use removed from commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada Bug 19599: Speed anonymise_issue_history up We should keep it however IMO Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 2a0ccf7af26236db9a3e40968cf8f43bc308f142 Author: Tomas Cohen Arazi Date: Thu Aug 27 15:10:08 2020 -0300 Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 7fc7427dd41ce10070a6a3d3070fb660850be511 Author: Tomas Cohen Arazi Date: Thu Aug 27 14:57:45 2020 -0300 Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ce7f4d16d6acdc6a56d40e6ebd96d722f1c77387 Author: Jonathan Druart Date: Mon Aug 31 14:26:26 2020 +0200 Bug 26324: Fix spelling resizable vs resizeable in Dopop The correct spelling of the parameter is resizable https://developer.mozilla.org/fr/docs/Web/API/Window/open Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 024bb186e683f8da9b862ca70a65599325dd4737 Author: David Nind Date: Fri Aug 14 14:23:10 2020 +0200 Bug 25630: (follow-up) Fix capitalization and terminology for system preferences Additional capitalization, punctuation, terminolgy and improvements to text for system preferences: - Punctuation (such as full stops at the end of sentences) - Capitalization - Terminology (staff interface, use of "Don't" instead of "Do not") - Rearranged/rephrased for better readability To test: - Verify that the changes listed are consistent and make sense. - Check that on the staff interface home page that the window title says "Koha staff interface". - Verify that in system preferences the name of the tab for Staff interface displays correctly, and that clicking on it brings up the staff interface preferences. - For Patrons > CollapseFieldsPatronAddForm check that the edit and add patron form works correctly (edit a patron, add a new patron, check that labels display correctly). Staff interface home page ------------------------- - Change the page title in browser from "Koha staff client" to "Koha staff interface". Administration -------------- Google OpenID Connect: . GoogleOpenIDConnectAutoRegister: change "Don't Allow" to "Don't allow" and change "users" to "patrons". . GoogleOpenIDConnectDefaultBranch: move the input field to the end of the sentence. . GoogleOpenIDConnectDefaultCategory: move the input field to the end of the sentence. . GoogleOpenIDConnectDomain: reword to "Restrict Google OpenID Connect to domain (or subdomain of this domain): ____. Leave blank for all Google domains.". Interface options: . SendAllEmailsTo: add a full stop. Share anonymous usage statistics: . UsageStatsLibrariesInfo: change "Do not share" to "Don't share"; add a full stop; for note "Don't share" should be "No". . most preferences: for note "Don't share" should be "No" (don't share) (for preferences UsageStatsCountry, UsageStatsGeolocation, UsageStatsLibrariesInfo, UsageStatsLibraryName, UsageStatsLibraryType, and UsageStatsLibraryUrl), various edits to make more readable and consistent. Authorities ----------- General . AuthorityControlledIndicators: change "biblio field" to "bibliographic field". . AutoCreateAuthorities: change "do not generate" to "don't generate". Linker: . CatalogModuleRelink: change "Do not" to "Don't". . LinkerKeepStale: change "Do not" to "Don't". . LinkerModule: change "Default" to "default". . LinkerOptions: add a full stop. . LinkerRelink: change "Do not" to "Don't". Cataloguing ----------- Display: . MergeReportFields: change "example:" to "Example:" Exporting: . BibtexExportAdditionalFields and RisExportAdditionalFields: change "Include following" to "Include the following"; add ":" at end of sentence, change "specificy" to "specify", and add full stops at end of complete sentences. Interface: . EnableAdvancedCatalogingEditor: format NOTE in bold. Record structure: . AlternateHoldingsField: change "(This" to "(this", change "; for instance" to ", for example", remove full stop. , MarcFieldForCreatorId: format NOTE in bold. . SubfieldsToAllowForRestrictedBatchmod: change "pref" to "system preference". Circulation ----------- Batch checkout: . BatchCheckoutsValidCategories: add a full stop. Checkin policy: . CalculateFinesOnReturn: only bold "NOTE", not the whole sentence (x2). . StoreLastBorrower: change "opacreadinghistory/AnonymousPatron" to "the opacreadinghistory and AnonymousPatron". . UpdateItemLocationOnCheckin: change note "for these locations only can location and permanent_location differ," to "for these locations the location and permanent_location can differ," . UpdateNotForLoanStatusOnCheckin: change "E.g.," to "For example," Checkout policy: . AgeRestrictionMarker: change "E.g.," to ". For example," . AllFinesNeedOverride: change "system preference noissuescharge" to "the noissuescharge system preference". . AllowFineOverride: add "the" before "noissuescharge". . AllowRenewalLimitOverride: change "with respect to" to "for". . AutoRemoveOverduesRestrictions: change "Do not" to "Don't". . DefaultLongOverdueChargeValue: change "user" to "patron". . ItemsDeniedRenewal: change . "e.g.," to "For example:", format the note the same as other notes with NOTE in bold. . OnSiteCheckoutsForce: change "on-site" to "on-site checkout", "(Even" to "(even", and "user" to "patron". . RentalFeesCheckoutConfirmation: change "do not ask" to "don't ask". . RestrictionBlockRenewing: change "If patron" to "If a patron", change "Allow" and "Block" to "allow" and "block". . UseTransportCostMatrix: "Transport" to "the transport". Interface: . AllowOfflineCirculation: change "Do not enable" to "Don't enable". . ExportRemoveFields: add a full stop. . ShowAllCheckins: change "Do not show" to "Don't show". . UpdateTotalIssuesOnCirc: change "Do not" to "Don't". Interlibrary loans: . CirculateILL: add a full stop. . ILLCheckAvailability: add a full stop. Self check-in module (sci-main.pl): . SelfCheckInModule: change "module. (available" to "module (available", add a full stop. Self check-out module (sco-main.pl): . AutoSelfCheckAllowed: change "automatically login" to "automatically log in". . WebBasedSelfCheck: change "system. (available" to "system (available", add a full stop. Enhanced content ---------------- Novelist Select: . NovelistSelectStaffView: change "staff" to "staff interface". Babelthèque: . Babeltheque_url_js: rewitten . from "______ Defined the URL for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js)" . to "Use this URL for the Babelthèque javascript file: ________ (e.g. http://www.babeltheque.com/bw_XX.js)." . Babeltheque_url_update: rewritten . from "______ Defined the URL for the Babeltheque update periodically (eq. http://www.babeltheque.com/.../file.csv.bz2)." . to "Use this URL for the Babelthèque periodic update: _______ (e.g. http://www.babeltheque.com/.../file.csv.bz2)." I18N/L10N --------- . dateformat and TimeFormat: Change "Note" to "NOTE" to be consistent with other notes, change tag to as it is more semantically correct. Logs ---- Debugging: . DumpTemplateVarsIntranet: change "variable" to "variables" and "staff intranet" to "staff interface". . DumpTemplateVarsOpac: change "variable" to "variables". Logging: . AuthFailureLog: add full stop. . AuthSuccessLog: add full stop. OPAC ---- Appearance: . BiblioDefaultView: change "bib" to "bibliographic". . HighlightOwnItemsOnOPAC: change ". (Non-XSLT Only)" to " (non-XSLT only).". . OpacAdditionalStylesheet: change "specified" to "specific". . OPACDisplay856uAsImage: change all options in the drop down list so they start in lowercase. . OpacHighlightedWords: change ";" to a full stop, add a full stop at the end. . OPACHoldingsDefaultSortField: add a full stop. . OpacMaxItemsToDisplay: change "user" to "patron". . OPACMySummaryHTML: change "user" to "patron". . OpacSeparateHoldings: change "user's to "patron's". . OpacStarRatings: change "user" to "patron" for the drop down option. . OPACShowUnusedAuthorities: change "Do not show" to "Don't show". . OPACUserSummary: change "user's to "patron's", change "fines" to "charges". . OPACXSLT*: change "Leave" to "leave". . Remove empty row at bottom of appearance options. Features: . OpacBrowser: change "OPAC" to "the OPAC". . OpacBrowseSearch: reword as "[Enable/Disable] interface for browsing all holdings (Elasticsearch only)." . OpacCloud: change "OPAC" to "the OPAC". . OPACDetailQRCode: change "Don't enable" to "Disable". . OPACFinesTab: change "Fines" to "charges", change "the My Accouunt" to "their account". (Should now show as "..patrons to access the charges tab on their account page on the OPAC." . OpacHoldNotes: change "Do not allow" to "Don't allow", change "users" to "patrons". . OpacResetPassword: change "users" to "patrons", add full stop. . SocialNetworks: change "in opac" to "on the OPAC". Note: Also deleted lines with # in front of them for the OpacBrowser and OpacCloud system preferences in the Policy section - these look like duplicated entries to me (previously lines 600-611). Policy: . OPACFineNoRenewalsIncludeCredits: change "users" to "patrons". Self registration and modification: . PatronSelfRegistrationConfirmEmail: change "Do not require" to "Don't require", change "users" to "patrons". . PatronSelfRegistrationEmailMustBeUnique: change "Do not consider" to "Don't consider". . PatronSelfRegistrationPrefillForm: change "Do not display and prefill" to "Don't display and prefill". Patrons ------- General: . AllowPatronToControlAutorenewal: add full stop. Notices and notifications: . EnhancedMessagingPreferences: change "Staff" to "staff". - FallbackToSMSIfNoEmail: change "Send" to "sending". Patron forms: . BorrowerUnwantedField: add full stop. . CollapseFieldsPatronAddForm: . Dropdown list changes: .. "Organization/Patron identity" => "Patron identity". .. "OPAC/Staff login" to "OPAC/Staff interface login". . Requires changes to the memberentrygen.tt - check that the add and edit form for a patron dispaly correctly: .. change "Contact" to "Contact information". .. change "Library set-up" to "Library setup". .. change "OPAC/Staff login" to "OPAC/Staff interface login". Patron relationships: . PrefillGuaranteeField: change drop down list option "Main address - street number" to "Main address - Street number" to match with format of other entries. Security: . RequireStrongPassword: change "More" to "more". Searching --------- Search form: . AdvancedSearchTypes: change "staff-side" to "staff interface". . expandedSearchOption: change "staff" to "staff interface". Serials ------- . makePreviousSerialAvailable: change "Do not make" to Don't make"; "syspref" to "system preference". . PreserveSerialNotes: change "Do not" to "Don't". . RoutingListNote: change "Include following" to "Include the following" Staff interface --------------- Tab label and link: . This tab was previously labelled "Staff client". . Change tab label on the left hand side from "Staff client" to "Staff interface". . Change URL when selected from "preferences.pl?tab=staff_client" to "preferences.pl?tab=staff_interface". . Check that the link works as expected. Appearance: . IntranetFavicon: change "Staff" to "staff". Tools ----- Reports: . NumSavedReports: change "Saved reports page" to "saved reports page". Web services ------------ IdRef: . IdRef: change "allows to request" to "allows requests for". Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 17a2d577944e016d597ccc5198793e5b48917e69 Author: Katrin Fischer Date: Sun May 31 19:10:37 2020 +0200 Bug 25630: Fix capitalization and terminology for Accounting, Administration and Serials system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AccountAutoReconcile (Do not to Don't for consistency with other prefs) - IndependentBranchesPatronModifications (p) - IndependentBranchesTransfers (p) - GoogleOpenIDConnect (google to Google) - UsageStatsLibrariesInfo (c) - opacSerialDefaultTab (c) - StaffSerialIssueDisplayCount (staff interface) - SubscriptionDuplicateDroppedInput (c) Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit c3033ae17c2c4c9f846a0c405a682469303c614f Author: Katrin Fischer Date: Sat May 30 04:14:58 2020 +0000 Bug 25630: Fix capitalization and terminology for Authorities and Cataloging system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AuthDisplayHierarchy (biblio to bibliographic) - MARCAuthorityControlField008 (p) - UNIMARCAuthorityField100 (p) - LinkerModule (c) - LinkerOptions (p) - SpineLabelShowPrintOnBibDetails (bib to bibliographic) - DefaultLanguageField008 (p) - DefaultCountryField008 (p) - SubfieldsToAllowForRestricted* (p, rephrase) - URLLinkText (added 'and items' - new with 20.05) - IntranetBiblioDefaultView (c) - MergeReportFields (rephrase) - BibtexExportAdditionalFields (marc to MARC) Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit 60f215b3b8e13d6a41822a83968cf6a5d6f3ee06 Author: Katrin Fischer Date: Sat May 30 03:31:51 2020 +0000 Bug 25630: Fix capitalization and terminology for Circulation system preferences - (Ending) punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - CircSidebar (c) - itemBarcodeInputFilter (from to form) - HoldsToPullStartDate (preference to system preference) - NoticeCSS (c) - UpdateTotalIssuesOnCirc (issues to checkouts) - ExportRemovefields (p) - AllowItemsOnHoldCheckoutSIP (c) - OnSiteCheckoutAutoCheck (onsite to on-site) - AllowOfflineCirculation (plugin to add-on) - AllowFineOverride (add 'system preference') - AutomaticItemReturn (returned to checked in) - UseTransportCostMatrix (branches to libraries) - AllowReturnToBranch (materials to items, return to checkin) - RenewalSendNotice (clarify 'messaging preference for 'Item checkout') - TransfersMaxDaysWarning (c) - noissuescharge (books to items) - *NoissuesCharge (add 'system preference') - ReturnBeforeExpiry (books to items) - NoticeBcc (p) - OverdueNoticeCalendar (c, p) - OverduesBlockCirc (p) - DefaultLongOverdueChargeValue (whitespace after :) - OPACFineNoRenewalsBlockAutoRenew (c) - RenewAccruingItemWhenPaid (p, c, syspref to system preference) - RenewAccruingItemInOpac (p, c, syspref to system preference) - HoldsSplitQueue (staff interface) - StaffSearchResultsDisplayBranch (staff interface, rephrase) - HidePersonalPatronDetailOnCirculation (rephrase) - StoreLastBorrower (add 'system preferences') - HoldsSplitQueue (& to and, staff interface) - HouseboundModule (p) - StockRotation (p) - ArticleRequests* (p) - ClaimReturnedLostValue (rephrase) Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit 5e6f889063f524555fb078927af40b1408a1616a Author: Katrin Fischer Date: Sat May 30 02:52:56 2020 +0000 Bug 25630: Fix capitalization and terminology for Logs and I18N system preferences - (Ending) punctuation (p) - Capitalization (p) - Terminology To test: - Verify: - alphabet (p) - TranslateNotics (c) - IllLog (p) - ReturnLog (returned to checked in) - DumpTemplateVars* (HTML) - read correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit cd4d7322962c155f3fd6653feed73cf2e405d3eb Author: Katrin Fischer Date: Sat May 30 02:34:59 2020 +0000 Bug 25630: Fix capitalization and terminology for OPAC system preferences - Ending punctuation (p) - Capitalization (c) - Terminology: library instead of branch, patron instead of borrower, system preferences instead of syspref To test: - Verify: - OPACUserSummary (p, rephrase: mainpage) - HighlightOwnItemsOnOPACWhich (library) - OPACXSLTListsDisplay (p) - OPACXSLTResultsDisplay (p) - OPACXSLTDetailsDisplay (p) - OpacNoItemTypeImages (p) - NotHighlightedWords (p) - opaclayoutstylesheet (CSS) - OPACReportProblem (c) - OpacBrowser (p) - OpacCloud (p) - SocialNetworks (p) - QuoteOfTheDay (c,p) - OpacNewsLibrarySelect (library) - OPACFineNoRenewalsIncludeCredits (p) - AllowPurchaseSuggestionBranchChoice (p) - OpacHiddenItemsExceptions (p, patron) - OpacAllowPublicListCreation (p) - OpacAllowSharingPrivateLists (p) - BlockExpiredPatronOpacActions (whitespace) - MaxOpenSuggestions (p) - AnonSuggestions (p) - OPACPrivacy (p, whitespace) - AnonymousPatron (c,p) - TrackClicks (p) - RestrictedPageLocalIPs (p) - RestrictedPageTitle (p) - OpacAdvSearchOptions (p) - OpacAdvSearchMoreOptions (p) - PayPal* (p) - OPACUserSummary (mainpage to OPAC start page) - read correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit 0c30554759ccabaa01bb5f566b77dbc63fdda924 Author: Katrin Fischer Date: Sat May 30 02:04:27 2020 +0000 Bug 25630: Fix capitalization and terminology for Patrons system preferences - Consistent use of 'staff interface' - Ending punctuation - Rearranged/rephrased for better readability To test: - Verify: - patronimages - PatronsPerPage (rearranged) - PatronQuickAddFields (rearranged) - PrefillGuaranteeField (punctuation) - borrowerRelationship (punctuation) - GDPR_Policy - CollapseFieldsPatronAddForm - read correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit 10c2eb01c977eeef6c55dc1999c0af8b60055252 Author: Katrin Fischer Date: Sun May 31 16:21:48 2020 +0200 Bug 25630: Fix capitalization and terminology for Enhanced content and Web services system preferences - Fixes capitalization, including URL and OPAC - Consistent use of "staff interface" - Ending punctuation - Spelling: web service To test: - Verify: - Enhanced content page heading - Babeltheque_url_js - Babeltheque_url_update - FRBRizeEditions - BakerTaylorEnabled - NovelistSelectStaffProfile - NovelistSelectStaffEnabled - CustomCoverImages - LocalCoverImages - IntranetCoce - AutoShareWithMana - OAI-PMH:AutoUpdateSets - IdRef - read correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit 9475a7db68c6237d3328c1c978b2ae678bb907f1 Author: Katrin Fischer Date: Sun May 31 16:10:23 2020 +0200 Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences - Adds some ending punctuation - Fixes capitalization - Consistent use of "staff interface" To test: - Verify: - NewsAuthorDisplay - EmailPurchaseSuggestions - UseACQFrameworkForBiblioRecords - AcqItemSetSubfieldsWhenReceived - AcqItemSetSubfieldsWhenReceiptIsCancelled - OrderPriceRounding - read correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit db47dbe56a2e7930b08c4036afc441a18c74af45 Author: Katrin Fischer Date: Sun May 31 15:58:42 2020 +0200 Bug 25630: Fix capitalization and terminology fixes for Searching system preferences - Rephrases LoadSearchHistoryToTheFirstLoggedUser system preference - Consistently use "staff interface" - Add ending punctuation to some preferences To test: - Read through the Searching system preferences - Verify consistent use of staff interface - Verify LoadSearchHistoryToTheFirstLoggedUser description is improved Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit b56ad54f49ec50ad5b0df8d7887982a34249b56d Author: Katrin Fischer Date: Sun May 31 15:54:08 2020 +0200 Bug 25630: Fix capitalization and terminology for Staff interface system preferences This changes "staff client" to "staff interface" and fixes capitalization in a couple of cases. For terminology changes see: https://wiki.koha-community.org/wiki/Terminology#S To test: - Read through the preferences of the "staff interface" tab. - Staff interface should be used consistently. - Firefox "PlugIn" was changed to "add-on" reflecting Mozilla's own terminology. Signed-off-by: David Nind Signed-off-by: Jonathan Druart commit c0adeab58feaa7fb0b5c97e55b8356bb916aa163 Author: Katrin Fischer Date: Sat May 23 15:19:37 2020 +0000 Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/NewsChannels.pm | 18 +- Koha.pm | 2 +- Koha/Schema/Result/OpacNews.pm | 16 +- .../data/mysql/de-DE/mandatory/sample_notices.sql | 2 +- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 24 +-- .../optional/marc21_simple_bib_frameworks.sql | 3 + .../data/mysql/de-DE/optional/sample_news.sql | 2 +- .../data/mysql/en/mandatory/sample_notices.yml | 2 +- installer/data/mysql/en/optional/sample_news.yml | 4 +- .../data/mysql/fr-CA/facultatif/sample_news.sql | 2 +- .../mysql/fr-CA/obligatoire/sample_notices.sql | 2 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 2 +- .../data/mysql/fr-FR/2-Optionel/sample_news.sql | 2 +- installer/data/mysql/it-IT/necessari/notices.sql | 2 +- .../data/mysql/it-IT/optional/sample_news.sql | 2 +- installer/data/mysql/kohastructure.sql | 3 +- .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 2 +- .../data/mysql/nb-NO/2-Valgfritt/sample_news.sql | 2 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 2 +- .../data/mysql/pl-PL/optional/sample_news.sql | 2 +- .../data/mysql/ru-RU/optional/sample_news.sql | 16 +- .../data/mysql/uk-UA/mandatory/sample_notices.sql | 2 +- .../data/mysql/uk-UA/optional/sample_news.sql | 18 +- installer/data/mysql/updatedatabase.pl | 24 +++ .../intranet-tmpl/prog/en/includes/prefs-menu.inc | 6 +- .../en/modules/admin/preferences/accounting.pref | 2 +- .../en/modules/admin/preferences/acquisitions.pref | 10 +- .../prog/en/modules/admin/preferences/admin.pref | 51 ++--- .../en/modules/admin/preferences/authorities.pref | 26 +-- .../en/modules/admin/preferences/cataloguing.pref | 53 ++--- .../en/modules/admin/preferences/circulation.pref | 227 +++++++++++---------- .../admin/preferences/enhanced_content.pref | 32 +-- .../en/modules/admin/preferences/i18n_l10n.pref | 9 +- .../prog/en/modules/admin/preferences/logs.pref | 12 +- .../prog/en/modules/admin/preferences/opac.pref | 130 ++++++------ .../prog/en/modules/admin/preferences/patrons.pref | 53 ++--- .../en/modules/admin/preferences/searching.pref | 27 ++- .../prog/en/modules/admin/preferences/serials.pref | 20 +- .../{staff_client.pref => staff_interface.pref} | 36 ++-- .../prog/en/modules/admin/preferences/tools.pref | 9 +- .../en/modules/admin/preferences/web_services.pref | 8 +- .../prog/en/modules/members/memberentrygen.tt | 10 +- .../en/modules/tools/batch_extend_due_dates.tt | 10 + .../prog/en/modules/tools/koha-news.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/global.js | 2 +- t/db_dependent/Koha/Objects.t | 51 +++-- t/db_dependent/Letters/TemplateToolkit.t | 4 +- t/db_dependent/NewsChannels.t | 26 ++- tools/batch_extend_due_dates.pl | 60 ++++-- tools/koha-news.pl | 6 +- 52 files changed, 573 insertions(+), 471 deletions(-) rename koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/{staff_client.pref => staff_interface.pref} (89%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 2 17:13:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 Sep 2020 15:13:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-2-g97aa961df3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 97aa961df3c6815d77da2b703f1d86bb3175cc13 (commit) via 863119f0d51133684fd024d9eca5770db6468e7d (commit) from d3ad3a6c884e426c92c3628d3ab0638299e2075b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 97aa961df3c6815d77da2b703f1d86bb3175cc13 Author: Jonathan Druart Date: Tue Aug 25 15:14:27 2020 +0200 Bug 26265: add a plan for tests Tests were run but no plan was declared and done_testing() was not seen. Signed-off-by: Jonathan Druart (cherry picked from commit 88f64019536887c094b0178007d3583a048917f2) Signed-off-by: Lucas Gass commit 863119f0d51133684fd024d9eca5770db6468e7d Author: Jonathan Druart Date: Fri Aug 21 15:10:18 2020 +0200 Bug 26265: Add missing xt dir Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit f9598240c5d94fa5bd20aac1c25e32ea2b5e57dd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 1 + xt/check_makefile.t | 1 + 2 files changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 2 17:20:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 Sep 2020 15:20:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-3-g7e2df4fbb1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7e2df4fbb13dea4ecd16fa16376e17adfdaa4c36 (commit) from 97aa961df3c6815d77da2b703f1d86bb3175cc13 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e2df4fbb13dea4ecd16fa16376e17adfdaa4c36 Author: Jonathan Druart Date: Fri Aug 21 14:00:51 2020 +0200 Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fe529e3324405b30329054b9e8125babc357e1fe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/XISBN.pm | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 06:45:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 04:45:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-3-gfba279050a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fba279050a344cfb43a189d11e041cdb4326acf4 (commit) from 7a34b88885c13a89cd713bb76eadef11472c1960 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fba279050a344cfb43a189d11e041cdb4326acf4 Author: Jonathan Druart Date: Tue Apr 7 13:32:51 2020 +0200 Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 11:10:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 09:10:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-911-g017e19567a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 017e19567af49a5e53f2d2fdf8713cbdd11666da (commit) via 5efc27ea53b0bb8e75a8bb876f064edfdade1b5b (commit) via 8f40973f0f24fa6ac8c87cabc0754d8cd13dc40e (commit) via 37c5a88157375760f20546cfc8cbbc91e558d383 (commit) via 638786e719fb297ae976061b09a71f3d788416f4 (commit) via 4b9475346e8c3d76923b1ef770af2db5d80ef438 (commit) via db55279886c7ecd13987780b6922d29e8916b267 (commit) via b42d57984bda809f2d8904781b9e7b70120ddf77 (commit) via 72f4765e6f6eb5076d4c05563ad28e05314e2ef4 (commit) via bc97867dfc9a9553be700403746ec09864234366 (commit) via 1a5cf89eb5d72679b693dea1928760e5dc27816a (commit) via 8366baaad5feaae98979312029e13332001a46b7 (commit) via 9524c1d76169e213403e36673fe9542c9dd4943a (commit) via aada130fe995c46bae8af26e223b307983c3e6b8 (commit) via 087af360cca661ecb2522451eeb1bbf2b4d54296 (commit) via 312cd6dfd2bfc9818c676ea2dc3658ad71cddb04 (commit) via 2056ab52bb6ad37b7bd1bf81a6e0dffbb8756537 (commit) from 5b845b9e8ab25001b0682920cea45662165f60f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 017e19567af49a5e53f2d2fdf8713cbdd11666da Author: Jonathan Druart Date: Mon Mar 2 10:08:12 2020 +0100 Bug 24663: (follow-up) Remove authnotrequired if set to 0 2 newly added scripts Signed-off-by: Tomás Cohen Arazi Signed-off-by: Jonathan Druart commit 5efc27ea53b0bb8e75a8bb876f064edfdade1b5b Author: Jonathan Druart Date: Mon Feb 17 16:44:37 2020 +0100 Bug 24663: Handle special cases for recovery password and selfreg The password recovery and self-registration features need to be accessible at the OPAC even if not public. Test plan: Self register a new account, then ask for a new password with OpacPublic turned off Signed-off-by: Martin Renvoize Signed-off-by: Tomás Cohen Arazi Signed-off-by: Jonathan Druart commit 8f40973f0f24fa6ac8c87cabc0754d8cd13dc40e Author: Jonathan Druart Date: Mon Feb 17 13:31:38 2020 +0100 Bug 24663: Force authentication in svc/records/preview (?) Was this wrong? Signed-off-by: Martin Renvoize Signed-off-by: Tomás Cohen Arazi Signed-off-by: Jonathan Druart commit 37c5a88157375760f20546cfc8cbbc91e558d383 Author: Jonathan Druart Date: Mon Feb 17 13:31:17 2020 +0100 Bug 24663: Force auth in adveditorshortcuts.pl This was wrong! Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 638786e719fb297ae976061b09a71f3d788416f4 Author: Jonathan Druart Date: Mon Feb 17 13:20:48 2020 +0100 Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 4b9475346e8c3d76923b1ef770af2db5d80ef438 Author: Jonathan Druart Date: Mon Feb 17 13:16:48 2020 +0100 Bug 24663: Test OpacPublic for all OPAC scripts Prior to this patchset there were 3 different calls to get_template_and_user (or checkauth) with the authnotrequired param: * authnotrequired => 0 * authnotrequired => 1 * authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ) The first one says that an unauthenticated user can access the page, the second that the user has to be authenticated, and the last one that it depends on the OpacPublic syspref. Actually we must replace the first one with the third one, if the OPAC is not public, the authentication must be forced. To do so we are going to remove the "authnotrequired => 0" occurrences, and check the OpacPublic syspref's value in C4::Auth Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit db55279886c7ecd13987780b6922d29e8916b267 Author: Marcel de Rooy Date: Wed Aug 5 13:48:59 2020 +0000 Bug 25360: (follow-up) Remove the https FIXME in Auth.pm The FIXME is no longer valid since we fixed the X-Forwarded headers for Plack. And since we do not even use using_https anymore in the templates (see bug 21094). Test plan: Run Auth.t Git grep for using_https Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b42d57984bda809f2d8904781b9e7b70120ddf77 Author: David Cook Date: Mon May 4 11:12:26 2020 +1000 Bug 25360: Use secure flag for CGISESSID cookie when using HTTPS This patch adds the secure flag to the CGISESSID cookie when using HTTPS. This prevents the cookie being used again over a normal HTTP request. Bug 25360: [Follow-up] Test for "on" or "ON" value for HTTPS env var This patch tests for HTTPS "on" or "ON" before setting the secure cookie. Bug 25360: [Follow-up] Fix typo in C4/InstallAuth.pm Signed-off-by: Marcel de Rooy [EDIT] Amended number of tests in Context.t Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 72f4765e6f6eb5076d4c05563ad28e05314e2ef4 Author: Jonathan Druart Date: Thu Sep 3 10:20:32 2020 +0200 Bug 23634: Make is_superlibrarian return 1 or 0 Signed-off-by: Jonathan Druart commit bc97867dfc9a9553be700403746ec09864234366 Author: Tomas Cohen Arazi Date: Mon Jul 13 12:25:13 2020 -0300 Bug 23634: (QA follow-up) Our PUT is really a PATCH This patch makes the controller not expect that there will always be all the email fields. So it now checks if an email field was passed, and changed, and renders the error if that stands. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests written by Nick highlight a problem 2. Apply this patch 3. Repeat 1 => SUCCESS: Problems solved 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 1a5cf89eb5d72679b693dea1928760e5dc27816a Author: Nick Clemens Date: Mon Jul 13 10:33:11 2020 +0000 Bug 23634: (QA follow-up) Adjust tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8366baaad5feaae98979312029e13332001a46b7 Author: Martin Renvoize Date: Fri Jul 10 09:38:31 2020 +0100 Bug 23634: (QA follow-up) Catch all email cases in API The API was only catching the primary email change case, but we need to catch email, emailpro and B_email. We were also not accounting for any of the emails (on PUT or from the DB) being undefined. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 9524c1d76169e213403e36673fe9542c9dd4943a Author: Martin Renvoize Date: Tue Nov 19 16:59:06 2019 +0000 Bug 23634: (follow-up) Prevent updates on POST Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit aada130fe995c46bae8af26e223b307983c3e6b8 Author: Tomas Cohen Arazi Date: Tue Nov 19 13:16:16 2019 -0300 Bug 23634: Secure the email on the API Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 087af360cca661ecb2522451eeb1bbf2b4d54296 Author: Martin Renvoize Date: Tue Nov 19 14:51:50 2019 +0000 Bug 23634: Prevent non-superlibrarians from editing superlibarian emails This patchset prevents a non-superlibrarian user from editing a superlibrarians email address via memberentry. This is to prevent a privilege escalation vulnerability whereby a user could update a superlibrarians contact details to match their own and then request a password reset via the OPAC. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 312cd6dfd2bfc9818c676ea2dc3658ad71cddb04 Author: Tomas Cohen Arazi Date: Tue Nov 19 13:22:18 2019 -0300 Bug 23634: Add tests for is_superlibrarian Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 2056ab52bb6ad37b7bd1bf81a6e0dffbb8756537 Author: Martin Renvoize Date: Tue Nov 19 14:11:34 2019 +0000 Bug 23634: Add is_superlibrarian method to Koha::Patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 43 +++++++++----- C4/Context.pm | 26 +++++++++ C4/InstallAuth.pm | 8 ++- Koha/Patron.pm | 13 +++++ Koha/REST/V1/Patrons.pm | 32 +++++++++++ about.pl | 1 - acqui/acqui-home.pl | 1 - acqui/add_user_search.pl | 1 - acqui/addorder.pl | 2 - acqui/addorderiso2709.pl | 1 - acqui/basket.pl | 1 - acqui/basketgroup.pl | 1 - acqui/basketheader.pl | 1 - acqui/booksellers.pl | 1 - acqui/cancelorder.pl | 1 - acqui/check_budget_total.pl | 1 - acqui/duplicate_orders.pl | 1 - acqui/edi_ean.pl | 1 - acqui/edifactmsgs.pl | 1 - acqui/edimsg.pl | 1 - acqui/histsearch.pl | 1 - acqui/invoice-files.pl | 1 - acqui/invoice.pl | 1 - acqui/invoices.pl | 1 - acqui/lateorders-export.pl | 1 - acqui/lateorders.pl | 1 - acqui/modordernotes.pl | 1 - acqui/neworderempty.pl | 2 - acqui/newordersubscription.pl | 1 - acqui/ordered.pl | 1 - acqui/orderreceive.pl | 1 - acqui/parcel.pl | 1 - acqui/parcels.pl | 1 - acqui/showorder.pl | 1 - acqui/spent.pl | 1 - acqui/supplier.pl | 1 - acqui/uncertainprice.pl | 1 - admin/add_user_search.pl | 1 - admin/additional-fields.pl | 1 - admin/admin-home.pl | 1 - admin/adveditorshortcuts.pl | 1 - admin/aqbudgetperiods.pl | 1 - admin/aqbudgets.pl | 1 - admin/aqcontract.pl | 1 - admin/aqplan.pl | 1 - admin/audio_alerts.pl | 1 - admin/auth_subfields_structure.pl | 1 - admin/auth_tag_structure.pl | 1 - admin/authorised_values.pl | 1 - admin/authtypes.pl | 1 - admin/biblio_framework.pl | 1 - admin/branches.pl | 1 - admin/cash_registers.pl | 1 - admin/categories.pl | 1 - admin/check_budget_parent.pl | 1 - admin/check_parent_total.pl | 1 - admin/checkmarc.pl | 1 - admin/cities.pl | 1 - admin/classsources.pl | 1 - admin/clone-rules.pl | 1 - admin/columns_settings.pl | 1 - admin/credit_types.pl | 1 - admin/currency.pl | 1 - admin/debit_types.pl | 1 - admin/didyoumean.pl | 1 - admin/edi_accounts.pl | 1 - admin/edi_ean_accounts.pl | 1 - admin/item_circulation_alerts.pl | 1 - admin/items_search_field.pl | 1 - admin/items_search_fields.pl | 1 - admin/itemtypes.pl | 1 - admin/koha2marclinks.pl | 1 - admin/library_groups.pl | 1 - admin/localization.pl | 1 - admin/marc_subfields_structure.pl | 1 - admin/marctagstructure.pl | 1 - admin/matching-rules.pl | 1 - admin/oai_set_mappings.pl | 1 - admin/oai_sets.pl | 1 - admin/overdrive.pl | 1 - admin/patron-attr-types.pl | 1 - admin/preferences.pl | 1 - admin/searchengine/elasticsearch/mappings.pl | 1 - admin/share_content.pl | 1 - admin/smart-rules.pl | 1 - admin/sms_providers.pl | 1 - admin/sru_modmapping.pl | 1 - admin/systempreferences.pl | 1 - admin/transport-cost-matrix.pl | 1 - admin/usage_statistics.pl | 1 - admin/z3950servers.pl | 1 - authorities/auth_finder.pl | 1 - authorities/authorities-home.pl | 3 - authorities/authorities.pl | 1 - authorities/blinddetail-biblio-search.pl | 1 - authorities/detail-biblio-search.pl | 1 - authorities/detail.pl | 1 - authorities/export.pl | 1 - authorities/merge.pl | 1 - basket/downloadcart.pl | 1 - basket/sendbasket.pl | 1 - catalogue/ISBDdetail.pl | 1 - catalogue/MARCdetail.pl | 1 - catalogue/detail.pl | 1 - catalogue/export.pl | 1 - catalogue/imageviewer.pl | 1 - catalogue/issuehistory.pl | 1 - catalogue/item-export.pl | 1 - catalogue/itemsearch.pl | 1 - catalogue/labeledMARCdetail.pl | 1 - catalogue/moredetail.pl | 1 - catalogue/search-history.pl | 1 - catalogue/search.pl | 1 - catalogue/showmarc.pl | 1 - catalogue/stockrotation.pl | 1 - cataloguing/addbiblio.pl | 1 - cataloguing/addbooks.pl | 1 - cataloguing/additem.pl | 1 - cataloguing/editor.pl | 1 - cataloguing/linkitem.pl | 1 - cataloguing/merge.pl | 1 - cataloguing/moveitem.pl | 1 - cataloguing/value_builder/EXAMPLE.pl | 1 - cataloguing/value_builder/callnumber-KU.pl | 1 - cataloguing/value_builder/callnumber.pl | 1 - cataloguing/value_builder/cn_browser.pl | 1 - cataloguing/value_builder/macles.pl | 1 - cataloguing/value_builder/marc21_field_006.pl | 1 - cataloguing/value_builder/marc21_field_007.pl | 1 - cataloguing/value_builder/marc21_field_008.pl | 1 - .../value_builder/marc21_field_008_authorities.pl | 1 - .../marc21_field_008_classifications.pl | 1 - cataloguing/value_builder/marc21_leader.pl | 1 - .../value_builder/marc21_leader_authorities.pl | 1 - .../value_builder/marc21_linking_section.pl | 3 - cataloguing/value_builder/normarc_field_007.pl | 1 - cataloguing/value_builder/normarc_field_008.pl | 1 - cataloguing/value_builder/normarc_leader.pl | 1 - cataloguing/value_builder/stocknumberAV.pl | 1 - cataloguing/value_builder/stocknumberam123.pl | 1 - cataloguing/value_builder/unimarc_field_010.pl | 1 - cataloguing/value_builder/unimarc_field_100.pl | 1 - .../value_builder/unimarc_field_100_authorities.pl | 1 - cataloguing/value_builder/unimarc_field_105.pl | 1 - cataloguing/value_builder/unimarc_field_106.pl | 1 - cataloguing/value_builder/unimarc_field_110.pl | 1 - cataloguing/value_builder/unimarc_field_115a.pl | 1 - cataloguing/value_builder/unimarc_field_115b.pl | 1 - cataloguing/value_builder/unimarc_field_116.pl | 1 - cataloguing/value_builder/unimarc_field_117.pl | 1 - cataloguing/value_builder/unimarc_field_120.pl | 1 - cataloguing/value_builder/unimarc_field_121a.pl | 1 - cataloguing/value_builder/unimarc_field_121b.pl | 1 - cataloguing/value_builder/unimarc_field_122.pl | 1 - cataloguing/value_builder/unimarc_field_123a.pl | 1 - cataloguing/value_builder/unimarc_field_123d.pl | 1 - cataloguing/value_builder/unimarc_field_123e.pl | 1 - cataloguing/value_builder/unimarc_field_123f.pl | 1 - cataloguing/value_builder/unimarc_field_123g.pl | 1 - cataloguing/value_builder/unimarc_field_123i.pl | 1 - cataloguing/value_builder/unimarc_field_123j.pl | 1 - cataloguing/value_builder/unimarc_field_124.pl | 1 - cataloguing/value_builder/unimarc_field_124a.pl | 1 - cataloguing/value_builder/unimarc_field_124b.pl | 1 - cataloguing/value_builder/unimarc_field_124c.pl | 1 - cataloguing/value_builder/unimarc_field_124d.pl | 1 - cataloguing/value_builder/unimarc_field_124e.pl | 1 - cataloguing/value_builder/unimarc_field_124f.pl | 1 - cataloguing/value_builder/unimarc_field_124g.pl | 1 - cataloguing/value_builder/unimarc_field_125.pl | 1 - cataloguing/value_builder/unimarc_field_125a.pl | 1 - cataloguing/value_builder/unimarc_field_125b.pl | 1 - cataloguing/value_builder/unimarc_field_126.pl | 1 - cataloguing/value_builder/unimarc_field_126a.pl | 1 - cataloguing/value_builder/unimarc_field_126b.pl | 1 - cataloguing/value_builder/unimarc_field_127.pl | 1 - cataloguing/value_builder/unimarc_field_128a.pl | 1 - cataloguing/value_builder/unimarc_field_128b.pl | 1 - cataloguing/value_builder/unimarc_field_128c.pl | 1 - cataloguing/value_builder/unimarc_field_130.pl | 1 - cataloguing/value_builder/unimarc_field_135a.pl | 1 - cataloguing/value_builder/unimarc_field_140.pl | 1 - cataloguing/value_builder/unimarc_field_141.pl | 1 - cataloguing/value_builder/unimarc_field_210c.pl | 2 - .../value_builder/unimarc_field_210c_bis.pl | 1 - cataloguing/value_builder/unimarc_field_225a.pl | 1 - .../value_builder/unimarc_field_225a_bis.pl | 1 - cataloguing/value_builder/unimarc_field_4XX.pl | 3 - cataloguing/value_builder/unimarc_field_686a.pl | 1 - cataloguing/value_builder/unimarc_field_700-4.pl | 1 - cataloguing/value_builder/unimarc_leader.pl | 1 - circ/add_message.pl | 1 - circ/article-request-slip.pl | 1 - circ/article-requests.pl | 1 - circ/bookcount.pl | 1 - circ/branchoverdues.pl | 1 - circ/branchtransfers.pl | 1 - circ/checkout-notes.pl | 1 - circ/circulation-home.pl | 1 - circ/circulation.pl | 1 - circ/del_message.pl | 1 - circ/hold-transfer-slip.pl | 1 - circ/offline-mf.pl | 1 - circ/offline.pl | 1 - circ/on-site_checkouts.pl | 1 - circ/overdue.pl | 1 - circ/pendingreserves.pl | 1 - circ/renew.pl | 1 - circ/request-article.pl | 1 - circ/reserveratios.pl | 1 - circ/returns.pl | 1 - circ/set-library.pl | 1 - circ/transfer-slip.pl | 1 - circ/transferstoreceive.pl | 1 - circ/view_holdsqueue.pl | 1 - circ/waitingreserves.pl | 1 - clubs/club-enrollments.pl | 1 - clubs/clubs-add-modify.pl | 1 - clubs/clubs.pl | 1 - clubs/patron-clubs-tab.pl | 1 - clubs/patron-enroll.pl | 1 - clubs/templates-add-modify.pl | 1 - course_reserves/add_items.pl | 1 - course_reserves/batch_add_items.pl | 1 - course_reserves/course-details.pl | 1 - course_reserves/course-reserves.pl | 1 - course_reserves/course.pl | 1 - course_reserves/mod_course.pl | 1 - installer/html-template-to-template-toolkit.pl | 12 ++-- installer/install.pl | 1 - installer/onboarding.pl | 1 - .../prog/en/includes/member-alt-address-style.inc | 4 ++ .../prog/en/modules/members/memberentrygen.tt | 10 +++- labels/label-create-pdf.pl | 1 - labels/label-edit-batch.pl | 1 - labels/label-edit-layout.pl | 1 - labels/label-edit-profile.pl | 1 - labels/label-edit-range.pl | 1 - labels/label-edit-template.pl | 1 - labels/label-home.pl | 1 - labels/label-item-search.pl | 2 - labels/label-manage.pl | 1 - labels/label-print.pl | 1 - labels/spinelabel-home.pl | 1 - labels/spinelabel-print.pl | 1 - mainpage.pl | 1 - members/accountline-details.pl | 1 - members/apikeys.pl | 1 - members/boraccount.pl | 1 - members/deletemem.pl | 1 - members/discharge.pl | 1 - members/discharges.pl | 1 - members/files.pl | 1 - members/guarantor_search.pl | 1 - members/holdshistory.pl | 1 - members/housebound.pl | 1 - members/ill-requests.pl | 1 - members/mancredit.pl | 1 - members/maninvoice.pl | 1 - members/member-flags.pl | 1 - members/member-password.pl | 1 - members/member.pl | 1 - members/memberentry.pl | 18 +++++- members/members-home.pl | 1 - members/members-update-do.pl | 1 - members/members-update.pl | 1 - members/merge-patrons.pl | 1 - members/moremember.pl | 1 - members/notices.pl | 1 - members/pay.pl | 1 - members/paycollect.pl | 1 - members/print_overdues.pl | 1 - members/printfeercpt.pl | 1 - members/printinvoice.pl | 1 - members/printslip.pl | 1 - members/purchase-suggestions.pl | 1 - members/readingrec.pl | 1 - members/routing-lists.pl | 1 - members/statistics.pl | 1 - members/summary-print.pl | 1 - members/update-child.pl | 1 - offline_circ/enqueue_koc.pl | 1 - offline_circ/list.pl | 1 - offline_circ/process.pl | 1 - offline_circ/process_koc.pl | 1 - opac/clubs/clubs-tab.pl | 1 - opac/clubs/enroll.pl | 1 - opac/opac-account-pay-paypal-return.pl | 1 - opac/opac-account-pay.pl | 1 - opac/opac-account.pl | 1 - opac/opac-addbybiblionumber.pl | 1 - opac/opac-article-request-cancel.pl | 1 - opac/opac-ics.pl | 1 - opac/opac-illrequests.pl | 1 - opac/opac-issue-note.pl | 1 - opac/opac-messaging.pl | 1 - opac/opac-modrequest-suspend.pl | 1 - opac/opac-modrequest.pl | 1 - opac/opac-mymessages.pl | 1 - opac/opac-passwd.pl | 1 - opac/opac-patron-consent.pl | 1 - opac/opac-privacy.pl | 1 - opac/opac-readingrecord.pl | 1 - opac/opac-renew.pl | 1 - opac/opac-request-article.pl | 1 - opac/opac-reserve.pl | 1 - opac/opac-routing-lists.pl | 1 - opac/opac-sendbasket.pl | 1 - opac/opac-sendshelf.pl | 1 - opac/opac-suggestions.pl | 1 - opac/opac-user.pl | 1 - opac/sci/sci-main.pl | 1 - opac/sco/sco-main.pl | 1 - opac/svc/auth/googleopenidconnect | 1 - patron_lists/add-modify.pl | 1 - patron_lists/delete.pl | 1 - patron_lists/list.pl | 1 - patron_lists/lists.pl | 1 - patron_lists/patrons.pl | 1 - patroncards/add_user_search.pl | 1 - patroncards/create-pdf.pl | 1 - patroncards/edit-batch.pl | 1 - patroncards/edit-layout.pl | 1 - patroncards/edit-profile.pl | 1 - patroncards/edit-template.pl | 1 - patroncards/home.pl | 1 - patroncards/image-manage.pl | 1 - patroncards/manage.pl | 1 - patroncards/print.pl | 1 - plugins/plugins-home.pl | 1 - plugins/plugins-uninstall.pl | 1 - plugins/plugins-upload.pl | 1 - plugins/run.pl | 1 - pos/pay.pl | 1 - pos/printreceipt.pl | 1 - reports/acquisitions_stats.pl | 1 - reports/bor_issues_top.pl | 1 - reports/borrowers_out.pl | 1 - reports/borrowers_stats.pl | 1 - reports/cash_register_stats.pl | 1 - reports/cat_issues_top.pl | 1 - reports/catalogue_out.pl | 1 - reports/catalogue_stats.pl | 1 - reports/dictionary.pl | 1 - reports/guided_reports.pl | 1 - reports/issues_avg_stats.pl | 1 - reports/issues_stats.pl | 1 - reports/itemslost.pl | 1 - reports/manager.pl | 1 - reports/orders_by_fund.pl | 1 - reports/reports-home.pl | 1 - reports/reserves_stats.pl | 1 - reports/serials_stats.pl | 1 - reserve/modrequest.pl | 1 - reserve/modrequest_suspendall.pl | 1 - reserve/request.pl | 1 - reviews/reviewswaiting.pl | 1 - rotating_collections/addItems.pl | 1 - rotating_collections/editCollections.pl | 1 - rotating_collections/rotatingCollections.pl | 1 - rotating_collections/transferCollection.pl | 1 - serials/acqui-search-result.pl | 1 - serials/acqui-search.pl | 1 - serials/add_user_search.pl | 1 - serials/checkexpiration.pl | 1 - serials/claims.pl | 1 - serials/routing-preview.pl | 2 - serials/routing.pl | 1 - serials/serials-collection.pl | 1 - serials/serials-edit.pl | 1 - serials/serials-home.pl | 1 - serials/serials-search.pl | 1 - serials/showpredictionpattern.pl | 1 - serials/subscription-add.pl | 1 - serials/subscription-batchedit.pl | 1 - serials/subscription-bib-search.pl | 2 - serials/subscription-detail.pl | 1 - serials/subscription-frequencies.pl | 1 - serials/subscription-history.pl | 1 - serials/subscription-numberpatterns.pl | 1 - serials/subscription-renew.pl | 1 - serials/viewalerts.pl | 1 - svc/convert_report | 1 - svc/letters/preview | 1 - svc/mana/search | 1 - svc/members/search | 1 - svc/records/preview | 1 - svc/report | 1 - svc/virtualshelves/search | 1 - t/Context.t | 18 +++++- t/db_dependent/Koha/Patron.t | 29 +++++++++- t/db_dependent/Search/History.t | 2 - t/db_dependent/api/v1/patrons.t | 67 +++++++++++++++++++++- tags/list.pl | 1 - tags/review.pl | 1 - tools/access_files.pl | 1 - tools/automatic_item_modification_by_age.pl | 1 - tools/batchMod.pl | 1 - tools/batch_delete_records.pl | 1 - tools/batch_record_modification.pl | 1 - tools/cleanborrowers.pl | 1 - tools/csv-profiles.pl | 1 - tools/export.pl | 1 - tools/holidays.pl | 1 - tools/import_borrowers.pl | 1 - tools/inventory.pl | 1 - tools/koha-news.pl | 1 - tools/letter.pl | 1 - tools/manage-marc-import.pl | 1 - tools/marc_modification_templates.pl | 1 - tools/modborrowers.pl | 1 - tools/overduerules.pl | 1 - tools/picture-upload.pl | 1 - tools/quotes-upload.pl | 1 - tools/quotes.pl | 1 - tools/scheduler.pl | 1 - tools/showdiffmarc.pl | 1 - tools/stage-marc-import.pl | 1 - tools/stockrotation.pl | 1 - tools/tools-home.pl | 1 - tools/upload-cover-image.pl | 1 - tools/upload.pl | 1 - tools/viewlog.pl | 1 - virtualshelves/addbybiblionumber.pl | 1 - virtualshelves/downloadshelf.pl | 1 - virtualshelves/sendshelf.pl | 2 - virtualshelves/shelves.pl | 1 - 427 files changed, 252 insertions(+), 457 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 15:32:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 13:32:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-941-g83ebab049d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 83ebab049d8d3827226ef1700591ee63702ded17 (commit) via e8a08cdfa7089f2b8147b3d75ce33c9521fd2cd6 (commit) via 85405a2143c4dda5fb5c078a6ee78c5ab6d1b6d8 (commit) via 2804d786c4e47dc0a3949d79f9ba944e8fb1d455 (commit) via 5d05feac31edd214ff47facc8a6d9c78d074da65 (commit) via d8696702cedb46e7667f9398165ee89627219809 (commit) via 8cbf2841ad45dbbddda915873a85fb4569b3bb68 (commit) via 72deefe8cf4f2d1cc24e7577ef2d2b8a44945f18 (commit) via cb272f01f4191b681e25ca5528d87e1c67fb679f (commit) via bed91ac8f73ca83235bf4dceee7123fbb4e14340 (commit) via b48cdd227f12bb43decc9f7108e84ea562d8ebc9 (commit) via 029bdb1fedf73f892f2807a675c0fd19fab06285 (commit) via 002ae7504a856c65bdd9124c80499c008d98a960 (commit) via c4f66a8514e6fada3c54baa1f1ea16f52cfdbd6e (commit) via 5377bfc6240587b113f2b8ee26a8006f65e756a7 (commit) via be92f7e79ce093e251c2489408dce3077f782c0d (commit) via 89cc457ca25e0fbaccba28b249ceedeef6573abf (commit) via 1733944b34499c145c2ae4c68c70efc87a5bec27 (commit) via 089b85758614260b70f43509ccdbc6285629a883 (commit) via 898cd3b82ee84682bdfad1c177e2eb6ae0881428 (commit) via bb73c5343c072bf7e2ff9cc00f840554ce848be8 (commit) via 8da73fe4283198ac93e2f15695f44e0cea7c490f (commit) via 0291c1e7e7a8d24d608830d31a6fdd9d2273f1a7 (commit) via f70df9b19479dc51ddaf76f29aaadafb7907a184 (commit) via 8a37842e1af3fdc9e5e4eb2eb6ec9190ed31915e (commit) via fde7bf5495dedf681acb3193891de44eec4d2bfa (commit) via c53dfb5562a12c1a8d8b9d3d0c28cb17d001edb5 (commit) via b729886216560fdf50d88dc8214c0dbb58720b5c (commit) via b87dc492fe4ea009ad3c72aca43add0515d6da1c (commit) via 2e421ed7a4e9bd3336b8e2b1eb9200c8c6342462 (commit) from 017e19567af49a5e53f2d2fdf8713cbdd11666da (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 83ebab049d8d3827226ef1700591ee63702ded17 Author: Jonathan Druart Date: Thu Sep 3 12:20:57 2020 +0000 Bug 23682: DBRev 20.06.00.035 Signed-off-by: Jonathan Druart commit e8a08cdfa7089f2b8147b3d75ce33c9521fd2cd6 Author: Jonathan Druart Date: Thu Sep 3 14:11:46 2020 +0200 Bug 23682: Fix use Koha::Plugins::Handler statements Signed-off-by: Jonathan Druart commit 85405a2143c4dda5fb5c078a6ee78c5ab6d1b6d8 Author: Kyle M Hall Date: Mon Aug 31 13:02:05 2020 -0400 Bug 23682: Dedup plugin calls my moving to a single call in process_invoice() Signed-off-by: Jonathan Druart commit 2804d786c4e47dc0a3949d79f9ba944e8fb1d455 Author: Katrin Fischer Date: Tue Aug 25 14:18:32 2020 +0000 Bug 23682: INSERT IGORE systen preference in database update Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5d05feac31edd214ff47facc8a6d9c78d074da65 Author: Kyle M Hall Date: Mon Aug 24 13:21:26 2020 -0400 Bug 23682: (QA follow-up) Fix typo in syspref description Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d8696702cedb46e7667f9398165ee89627219809 Author: Kyle M Hall Date: Thu Sep 26 10:39:36 2019 -0400 Bug 23682: Add ability to manually import EDI invoices as an alternative to automatic importing on download Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref EdifactInvoiceImport 4) Run the edi cronjob to import a new invoice file 5) View EDI messages table at /acqui/edifactmsgs.pl 6) Note the invoice files is not processes, and retains the status of 'new' 7) Use the 'import' button to process the invoice 8) Note the invoice is now marked 'received' and the 'import' button is gone 9) Verify the invoice was actually processes Signed-off-by: Debi Stears Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8cbf2841ad45dbbddda915873a85fb4569b3bb68 Author: Jonathan Druart Date: Thu Sep 3 12:20:57 2020 +0000 Bug 24197: DBRev 20.06.00.034 Signed-off-by: Jonathan Druart commit 72deefe8cf4f2d1cc24e7577ef2d2b8a44945f18 Author: Nick Clemens Date: Wed Sep 2 17:32:42 2020 +0000 Bug 24197: (QA follow-up) Shorten syspref name to AddressForFailedEmailNotices If you define the address we use it, if not we fallback, it's not really a redirect, and that just makes the name longer. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit cb272f01f4191b681e25ca5528d87e1c67fb679f Author: Martin Renvoize Date: Wed Sep 2 16:33:06 2020 +0100 Bug 24197: (QA follow-up) Embelished syspref description As requested, I have embelished the syspref description to more accurately depict the fallback sequence for email delivery. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit bed91ac8f73ca83235bf4dceee7123fbb4e14340 Author: Alex Buckley Date: Wed Apr 22 00:01:58 2020 +0000 Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit b48cdd227f12bb43decc9f7108e84ea562d8ebc9 Author: Alex Buckley Date: Tue Apr 21 23:21:20 2020 +0000 Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 029bdb1fedf73f892f2807a675c0fd19fab06285 Author: Martin Renvoize Date: Wed Sep 2 14:40:08 2020 +0100 Bug 25541: (QA follow-up) Default to disabled + Correct message This patch defaults the 'holds_block_checkin' configuration to disabled (to maintain current behaviour on upgrades). It also updates a copy/paste for siplog logging to make the message triggered by this action unique as expected. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 002ae7504a856c65bdd9124c80499c008d98a960 Author: Kyle M Hall Date: Wed Sep 2 08:54:08 2020 -0400 Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit c4f66a8514e6fada3c54baa1f1ea16f52cfdbd6e Author: Kyle M Hall Date: Wed Aug 19 09:10:42 2020 -0400 Bug 25541: Add new param to debian sip config Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 5377bfc6240587b113f2b8ee26a8006f65e756a7 Author: Kyle M Hall Date: Tue May 19 08:35:06 2020 -0400 Bug 25541: Add ability to prevent checkin via SIP of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. Signed-off-by: Peter Lau Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit be92f7e79ce093e251c2489408dce3077f782c0d Author: Martin Renvoize Date: Wed Jul 22 13:28:44 2020 +0100 Bug 26041: Enable keyboard navigation without 'ctrl' This patch enables keyboard navigation using the arrow keys without the need to hold the control key for the jQuery UI datepicker. Test plan 1/ Navigate to an item in the opac and attempt to place a hold 2/ On the resultant screen, use keyboard navigation to trigger the 'Show more options' dropdown. 3/ Focus on one of the date inputs using keyboard navigation. 4/ Use 'ctrl + arrow' keys to navigate the datepicker. 5/ Note that prior to the patch using 'bare' arrow keys does not trigger anything 6/ Apply the patch and confirm that the datepicker can now be naviated using the arrow keys without holding the ctrl key. 7/ Confirm that using the ctrl key combinations continue to work as expected too. 8/ Signoff Signed-off-by: Brandon J Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 89cc457ca25e0fbaccba28b249ceedeef6573abf Author: Andrew Fuerste-Henry Date: Thu Aug 27 18:03:14 2020 +0000 Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 1733944b34499c145c2ae4c68c70efc87a5bec27 Author: Nick Clemens Date: Tue Aug 18 13:33:33 2020 +0000 Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 089b85758614260b70f43509ccdbc6285629a883 Author: Joonas Kylmälä Date: Fri Aug 21 16:23:38 2020 +0300 Bug 26271: Add null to the list of accepted account_line data types The database schema for accountlines table allows the manager_id/user_id column to be NULL. If request to /api/v1/patrons//account returns such an accountline where it is NULL we get 500 error as response. Adding NULL to allowed data types fixes this issue. To test: 1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it doesn't fail Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 898cd3b82ee84682bdfad1c177e2eb6ae0881428 Author: Joonas Kylmälä Date: Fri Aug 21 16:21:42 2020 +0300 Bug 26271: Add failing test to reveal issue with patrons API endpoint When manager_id is null/undef the API returns error code 500. To test: 1) Notice failure when running prove t/db_dependent/api/v1/patrons_accounts.t Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit bb73c5343c072bf7e2ff9cc00f840554ce848be8 Author: Katrin Fischer Date: Tue Sep 1 03:37:22 2020 +0000 Bug 15851: (QA follow-up) Fix booleans to uppercase to make this work for Elasticsearch and UseControlNumber Same test plan as before, but with UseControlNumber = Use and Elasticsearch. Signed-off-by: Jonathan Druart commit 8da73fe4283198ac93e2f15695f44e0cea7c490f Author: Tomas Cohen Arazi Date: Fri Jul 17 09:44:46 2020 -0300 Bug 15851: (follow-up) Only display the analytics link when required (staff) This patch replicates the introduced behaviour, for the admin interface. To test, follow the test plan from the OPAC, but on the intranet. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 0291c1e7e7a8d24d608830d31a6fdd9d2273f1a7 Author: Tomas Cohen Arazi Date: Wed Jun 24 14:50:37 2020 -0300 Bug 15851: Only display the analytics link when required This patch makes opac-detail.pl query for analytics the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Analytics' link. To test: 1. Apply the first patch 2. Have a known record without analytics 3. Open the record in the OPAC => FAIL: It shows the 'Analytics' link 4. Have a record known to have analytics and open in OPAC, on a separate tab => SUCCESS: It shows the 'Analytics' link 5. Apply this patch and restart_all 6. Reload the tabs => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed 7. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f70df9b19479dc51ddaf76f29aaadafb7907a184 Author: Tomas Cohen Arazi Date: Wed Jun 24 13:08:25 2020 -0300 Bug 15851: Display analytics links for more cases The current XSLT displays the link to linked analytics only for serials. This patch makes it show for all the relevant position 7 on the leader values. I left out a and b as recommended by expert librarians on my team, but I can revert that if required. The current implementation adds a new CSS class for each case, so libraries willing to keep the current behaviour or just have more granular control on the cases they want the link to display, just can. This patch makes sense with the follow-up one, which will display the link only if there are really related records. To test: 1. Open a non-serial record, notice there's no link to analytics 2. Apply this patch and reload => SUCCESS: There's an 'Analytics' link 3. Inspect the produced HTML => SUCCESS: A special class with analytic_* value has been added, and thus we now can control its display through CSS 4. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8a37842e1af3fdc9e5e4eb2eb6ec9190ed31915e Author: Katrin Fischer Date: Tue Sep 1 21:22:31 2020 +0200 Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit fde7bf5495dedf681acb3193891de44eec4d2bfa Author: Nick Clemens Date: Tue Sep 1 12:32:56 2020 +0000 Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit c53dfb5562a12c1a8d8b9d3d0c28cb17d001edb5 Author: David Cook Date: Tue Sep 1 15:19:14 2020 +1000 Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b729886216560fdf50d88dc8214c0dbb58720b5c Author: David Cook Date: Thu Sep 3 05:40:57 2020 +0000 Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b87dc492fe4ea009ad3c72aca43add0515d6da1c Author: Nick Clemens Date: Thu Aug 27 15:03:17 2020 +0000 Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 2e421ed7a4e9bd3336b8e2b1eb9200c8c6342462 Author: Nick Clemens Date: Thu Aug 27 15:03:07 2020 +0000 Bug 26309: Unit tests Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 12 +++++- C4/SIP/ILS/Transaction/Checkin.pm | 15 ++++++-- C4/SIP/Sip/MsgType.pm | 2 +- Koha.pm | 2 +- Koha/EDI.pm | 24 ++++++++++-- Koha/SearchEngine/Elasticsearch.pm | 9 ++--- acqui/edifactmsgs.pl | 12 +++++- api/v1/swagger/definitions/account_line.json | 5 ++- catalogue/detail.pl | 29 ++++++++++++-- debian/templates/SIPconfig.xml | 1 + etc/SIPconfig.xml | 3 +- installer/data/mysql/sysprefs.sql | 2 + installer/data/mysql/updatedatabase.pl | 20 ++++++++++ .../prog/en/modules/acqui/edifactmsgs.tt | 3 ++ .../en/modules/admin/preferences/acquisitions.pref | 8 ++++ .../prog/en/modules/admin/preferences/admin.pref | 6 +++ .../intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 +- .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 44 +++++++++++++++------- .../opac-tmpl/bootstrap/en/includes/calendar.inc | 16 ++++++++ .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 44 +++++++++++++++------- misc/cronjobs/edi_cron.pl | 40 ++++++-------------- misc/cronjobs/overdue_notices.pl | 4 +- opac/opac-detail.pl | 18 ++++++++- reports/cat_issues_top.pl | 30 +++++++-------- svc/letters/preview | 0 t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 12 +++++- t/db_dependent/SIP/Message.t | 25 +++++++++++- t/db_dependent/api/v1/patrons_accounts.t | 36 +++++++++++++++++- 29 files changed, 324 insertions(+), 104 deletions(-) mode change 100644 => 100755 svc/letters/preview hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 16:33:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 14:33:55 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-4-g2b6b7cb265 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2b6b7cb265acc77f8925eec9a9f315f249a85348 (commit) from 7e2df4fbb13dea4ecd16fa16376e17adfdaa4c36 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2b6b7cb265acc77f8925eec9a9f315f249a85348 Author: Lucas Gass Date: Thu Sep 3 03:57:01 2020 +0000 Bug 26361: switch TableSettings to ColumnSettings Test Plan: -Be on 20.05.x -Go to returns.tt -See the error Uncaught SyntaxError: expected expression, got keyword 'var'. -Apply patch -Reload returns.tt, no error Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 17:06:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 15:06:04 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-5-g69f16f7469 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 69f16f7469c7cbbf571560d6f9389ef2dd170aa7 (commit) from 2b6b7cb265acc77f8925eec9a9f315f249a85348 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 69f16f7469c7cbbf571560d6f9389ef2dd170aa7 Author: Jonathan Druart Date: Thu Jul 30 14:16:09 2020 +0200 Bug 26090: Fix "item types" report This report was broken with SQL strict mode, but also without. DBD::mysql::st execute failed: 'koha_kohadev.itemtypes.itemtype' isn't in GROUP BY [for Statement " and, if no library was selected: DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'field list' [for Statement " This patch does the minimum to make it usable, but it would need more love. Test plan: To test you will need to try the 4 combinaisons: item-level_itypes = item or biblio With or without a library selected in the dropdown list Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 5bca73080f89bb2f4ca83ce6ceb9fa8e3c4a7d92) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: reports/itemtypes.plugin | 72 ++++++++++++++++-------------------------------- 1 file changed, 24 insertions(+), 48 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 17:11:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 15:11:44 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-7-g0b444c4bc0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 0b444c4bc0f3a677acfc2423b19a04ddea8b9dff (commit) via 8bd9c4b4fd44990c7a806de21e8628e1955a3c56 (commit) from 69f16f7469c7cbbf571560d6f9389ef2dd170aa7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b444c4bc0f3a677acfc2423b19a04ddea8b9dff Author: Nick Clemens Date: Fri Aug 14 11:30:12 2020 +0000 Bug 26078: (follow-up) Use a boolean rather than changing returnbranch Bug 26078: (follow-up) used validTransfer instead of checking WrongTransfer message Signed-off-by: Jonathan Druart (cherry picked from commit d8f3e0ec0dbaf73075299a88a254334cfaf1d29e) Signed-off-by: Lucas Gass commit 8bd9c4b4fd44990c7a806de21e8628e1955a3c56 Author: Nick Clemens Date: Thu Jul 30 16:59:14 2020 +0000 Bug 26078: Prevent generating a new transfer from return policy when resolving a transfer To test: - Have 2+ branches - Set your default return policy to Item returns to issuing library - Find an item with holding branch of Branch A - Set your library to Branch B - Check item in - Koha generates a transfer to Branch A. In doing so, it sets the item holding branch to Branch B - Set your library to Branch A - Check item in - Koha generate a transfer to Branch B. In doing so, it sets the item holding branch to Branch A - Set you library to Branch A - Check the item in . . . Repeat indefinitely. Apply patch Repeat No more loop Signed-off-by: Sally Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 47671123206a475f86de9316d8b256e14aa54bc1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 8 +++++--- t/db_dependent/Circulation/Branch.t | 8 +++++++- 2 files changed, 12 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 17:21:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 15:21:15 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-8-g65f443f22f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 65f443f22f78600979a36a422c8f1e71f580ee18 (commit) from 0b444c4bc0f3a677acfc2423b19a04ddea8b9dff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 65f443f22f78600979a36a422c8f1e71f580ee18 Author: Tomas Cohen Arazi Date: Mon Aug 17 12:12:55 2020 -0300 Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. It also replaces the use of 'gulp-util' (deprecated) by 'minimist' as recommended on their site. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit a7e3c12e6175e19299e7bdbe60d1bc7d41d45ce8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: gulpfile.js | 62 ++-- package.json | 4 +- yarn.lock | 1028 +++++++++++++++++++++++++++++++++++++++++++--------------- 3 files changed, 800 insertions(+), 294 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 17:40:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 15:40:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-9-g75118284ed Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 75118284ed4007d024a4d6a70b970de28ee48ea1 (commit) from 65f443f22f78600979a36a422c8f1e71f580ee18 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75118284ed4007d024a4d6a70b970de28ee48ea1 Author: Andrew Fuerste-Henry Date: Thu Aug 13 13:13:55 2020 +0000 Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other Signed-off-by: Holly Cooper Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9509e834de14b3fd88296143032100f2b1c907fe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 17:56:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 15:56:06 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-10-g12a02a2349 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 12a02a23493062a768e60333b13b323703ea6c74 (commit) from 75118284ed4007d024a4d6a70b970de28ee48ea1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 12a02a23493062a768e60333b13b323703ea6c74 Author: Jonathan Druart Date: Mon Aug 3 15:07:24 2020 +0200 Bug 26127: local_referer should not compare with OPACBaseURL case insensitive In our test data we have OPACBaseURL that is filled with http://kohadev.myDNSname.org:8080, but the CGI referer in local_referer is lowercase We should compare it without case sensitivity Test plan: - Use koha-testing-docker - Notice the value of OPACBaseURL => http://kohadev.myDNSname.org:8080 - Use the "reports a problem" feature at the OPAC - Notice that the "Problem found on page" is correctly filled with the referer Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 7a53c5f04cf2bb03734c82e9f964f108f9198d28) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Util/Navigation.pm | 2 +- t/Koha/Util/Navigation.t | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 18:00:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 16:00:37 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-11-gae54212e7d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ae54212e7d05564332dbb28b99ed61103cdecaae (commit) from 12a02a23493062a768e60333b13b323703ea6c74 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ae54212e7d05564332dbb28b99ed61103cdecaae Author: Jonathan Druart Date: Mon Aug 3 13:09:54 2020 +0200 Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail There is no good reason remove the ability to edit patron's attributes if PatronSelfRegistrationVerifyByEmail is set. We cannot have them in the self-registration form (because we don't store patron's attributes during self-ref), but we can have them when a patron show/edit their information. Test plan: 0. Enable PatronSelfRegistrationVerifyByEmail and create patron's attributes that can be edited at the OPAC 1. Create a new patron using the self-reg feature => You don't have the ability to fill in the patron's attribute 2. Edit your personal details (OPAC) => Without this patch you still don't see the patron's attribute that can be edited at the OPAC => With this patch applied you can! 3. Notice the wording change on the "Modify patron attribute type" form and confirm it makes sense Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fc22fb308bdbfc6d1bda3448e966542f2828ad76) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 18:07:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 16:07:21 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-13-g48507259b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 48507259b413c86a216a127f2ba1457edb3e83d4 (commit) via 7d035b39d20353a004c0f24ce2e2e0d24286e474 (commit) from ae54212e7d05564332dbb28b99ed61103cdecaae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48507259b413c86a216a127f2ba1457edb3e83d4 Author: Nick Clemens Date: Thu Aug 13 12:56:33 2020 +0000 Bug 25872: Fix scoping of $limits The code in build_query_compat contained a 'my' in the assigning of limits for the search in a conditional This meant the limits were being set correctly during the conditional, but we blanked when passed to the rest of the code. The effect was that the searches worked, however, the template params to repeat the search were incomplete. Removing the my ensures the same limits are applied during search and on re-sorting To test: 1 - Enable Elasticsearch 2 - On OPAC perform advanced search, selecting only an itype, ccode, or LOC limit 3 - Attempt to sort results 4 - You are returned to Advanced search 5 - Apply patch 6 - Repeat 7 - It sorts! Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 43dc505a52a2679e40a22ff610c91552cd8f2fd1) Signed-off-by: Lucas Gass commit 7d035b39d20353a004c0f24ce2e2e0d24286e474 Author: Nick Clemens Date: Thu Aug 13 12:55:21 2020 +0000 Bug 25872: Unit tests Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2f3a886f7b23f37f04a687cb0c1755c3195c2ce6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 3 18:13:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Sep 2020 16:13:18 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-14-g3bbf638449 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3bbf6384492834055d38ac844521be6c02d503ab (commit) from 48507259b413c86a216a127f2ba1457edb3e83d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3bbf6384492834055d38ac844521be6c02d503ab Author: Alex Buckley Date: Sun Jun 14 22:41:03 2020 +0000 Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded If 'Actual cost' has not been set then it has the value of 0.00 which Perl evaluates to true so this patchset resets it to 0, so the fallback to ecost_tax_included/ecost_tax_excluded happens. Test plan: 1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax') 2. Set 'Vendor price' = 10 and do not set 'Actual cost' 3. Save order 4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST column has value of -8.70 5. Jump into the database: select tax_value_on_ordering from aqorders where ordernumber=; [You can get the ordernumber from clicking on the 'Modify' line the item is listed in] 6. Observe a negative value: -8.70 7. Apply patch and restart plack 8. Add a second item to the basket 9. Set 'Vendor price' = 10 and don't set 'Actual cost' 10. Save order 11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST has value of 1.30 12. Repeat step 5 and observe tax_value_on_ordering = 1.30 13. Run t/Prices.t unit test: sudo koha-shell prove t/Prices.t Sponsored-by: Horowhenua District Council, NZ Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7b66b90fe707e8ac650a1c85d87560fc2f4a223d) ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 1 + acqui/basket.pl | 2 ++ t/Prices.t | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 54 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 16:40:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 14:40:14 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-15-gc320dfa3be Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c320dfa3beef2bce10e87572ee9dd7f6849a694f (commit) from 3bbf6384492834055d38ac844521be6c02d503ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c320dfa3beef2bce10e87572ee9dd7f6849a694f Author: Jonathan Druart Date: Tue Jun 16 15:44:40 2020 +0200 Bug 25751: Add ORDERED in dropdown list of suggestion's statuses The status "ORDERED" is missing from the pull down list of status values when editing a suggestion, so the first option is selected "No status". This leads to data loss when editing a suggestion in the status "ORDERED". Worse: the status can't be reset to "ORDERED" and so no AVAILABLE notice can be sent to the patron. Test plan: - Create a suggestion, accept it, create a new order from this suggestion. - Verify status is "ORDERED" - Edit the suggestion => Without this patch the dropdown list does not have "Ordered", and if you save you lost the status => With this patch applied the dropdown list has "Ordered" preselected. You can save and preserve the status. Signed-off-by: Holly Cooper Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit eeb7ac6fc0d14c9e731b7759c78f37cadcfa575f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/suggestion/suggestion.tt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 17:13:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 15:13:38 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-16-g729432170d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 729432170d0a18b69f3f4e597c530cfe869f6b15 (commit) from c320dfa3beef2bce10e87572ee9dd7f6849a694f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 729432170d0a18b69f3f4e597c530cfe869f6b15 Author: Jonathan Druart Date: Thu Aug 6 11:28:53 2020 +0200 Bug 23632: Remove C4::Logs::GetLogs Koha::ActionLogs->search must be used instead. There is no call to this subroutine in our code, it should be removed. Test plan: Make sure the 3 test files still return green and that there is no more occurrences of GetLogs in the codebase. Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 807147fb7b20c837f9afc3e2d6ba589d86d86cbe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Log.pm | 77 +------------------ t/db_dependent/Illrequest/Logger.t | 19 ----- t/db_dependent/Koha/Patron/Messages.t | 4 +- t/db_dependent/Log.t | 134 ++++++++++++---------------------- 4 files changed, 49 insertions(+), 185 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 17:43:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 15:43:52 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-25-g7ebeaf8373 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7ebeaf83730282fe5d6647a5c1260e61077990b6 (commit) via 7702608d1aa5ae998ed512396d2aa6b3b0be263e (commit) via 764bffe4030e9117b17ec7b994738fad9adfcb98 (commit) via d9d5edb22aa6701debee402bd39dca76358568a6 (commit) via 8f5f65ed45dee9c90487131df91d7a4e5d56fa2c (commit) via b25d7c9d8ddf58bdc061cf65c7a5c53981ceab1e (commit) via 3e63f7fb2eda12db4c27b23871455225045b63cd (commit) via c6439db535ae78107a56152904013b69f9898732 (commit) via f681964591ba1efde4c1c8c032c344b85c1d1815 (commit) from 729432170d0a18b69f3f4e597c530cfe869f6b15 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ebeaf83730282fe5d6647a5c1260e61077990b6 Author: Owen Leonard Date: Thu Aug 6 11:42:33 2020 +0000 Bug 26159: Remove the use of jquery.checkboxes plugin from batch record delete page This patch removes the use of the jquery.checkboxes plugin from the batch delete records page. To test, apply the patch and go to Tools -> Batch record deletion. - Submit a batch of biblionumbers which includes one or more checked-out items, one or more on-hold items, and one or more records with no items. - On the confirmation page, test the selection links at the top of the results table. Each one should work correctly. - Submit a batch of authority record ids which includes some records which are in use and some which aren't. - On the confirmation page, test the selection links at the top of the results table. Each one should work correctly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4fadb7ac1931b48a4be8160409d35ca97ab6b322) Signed-off-by: Lucas Gass commit 7702608d1aa5ae998ed512396d2aa6b3b0be263e Author: Owen Leonard Date: Thu Aug 13 12:34:19 2020 +0000 Bug 26201: Remove the use of jquery.checkboxes plugin from batch extend due dates page This patch removes the use of the jquery.checkboxes plugin from the batch extend due dates page. Unrelated change: Removed 'enctype="multipart/form-data"' from the form because there is no file upload. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit the form with parameters which will return a set of multiple checkouts. - On the results page, test the "Select all" and "Clear all" links to confirm that they work correctly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 467e491a25652bf8ee85651ab91e3780c66e3aa1) Signed-off-by: Lucas Gass commit 764bffe4030e9117b17ec7b994738fad9adfcb98 Author: Owen Leonard Date: Thu Aug 13 13:19:19 2020 +0000 Bug 26202: Remove the use of jquery.checkboxes plugin from batch record modification page This patch removes the use of the jquery.checkboxes plugin from the batch record modification page. To test, apply the patch and go to Tools -> Batch record modification - Submit a batch of biblionumbers for modification. - On the results page, test the "Select all" and "Clear all" links to confirm that they work correctly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9371685b973a287b7642fb907721f4964d92e65a) Signed-off-by: Lucas Gass commit d9d5edb22aa6701debee402bd39dca76358568a6 Author: Owen Leonard Date: Thu Aug 13 13:54:54 2020 +0000 Bug 26204: Remove the use of jquery.checkboxes plugin from staff interface lists This patch removes the use of the jquery.checkboxes plugin from the staff interface lists page. To test, apply the patch, go to Lists, and view the contents of a list with multiple titles on it. Check that the "Select all" and "Clear all" links work correctly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2de2b1330f540ef9482c1ed547b111757f0a551a) Signed-off-by: Lucas Gass commit 8f5f65ed45dee9c90487131df91d7a4e5d56fa2c Author: Owen Leonard Date: Fri Aug 14 13:39:17 2020 +0000 Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c7174b204a324ee2431012e7f9a3cc09738d57de) Signed-off-by: Lucas Gass commit b25d7c9d8ddf58bdc061cf65c7a5c53981ceab1e Author: Owen Leonard Date: Fri Aug 14 14:47:40 2020 +0000 Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 41205adf34a4cde773fb399728ca74d9dada0e81) Signed-off-by: Lucas Gass commit 3e63f7fb2eda12db4c27b23871455225045b63cd Author: Owen Leonard Date: Fri Aug 14 15:18:37 2020 +0000 Bug 26215: Remove the use of jquery.checkboxes plugin from Z39.50 search pages This patch removes the use of the jquery.checkboxes plugin from three Z39.50 search templates: Acquisitions, Authorities, and Cataloging. To test, apply the patch and test the controls for selecting and deselecting Z39.50 search targets on the following pages: - In Acquisitions: Locate a vendor and add to basket -> From an external source. - In Authorities: Click "New authority" -> "New from Z39.50/SRU." - In Cataloging: Click "New from Z39.50/SRU." Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ff5f7c787482fff5611b3fdeaed89598dfa29d64) Signed-off-by: Lucas Gass commit c6439db535ae78107a56152904013b69f9898732 Author: Owen Leonard Date: Fri Aug 14 17:28:22 2020 +0000 Bug 26216: Remove the use of jquery.checkboxes plugin from catalog search results This patch removes the use of jquery.checkboxes plugin from the staff interface catalog search results page. To test, apply the patch and perform a catalog search in the staff interface which will return results. On the search results page test the "Select all" and "Clear all" links at the top of the results. They should work correctly. Signed-off-by: Amit Gupta Signed-off-by: Jonathan Druart (cherry picked from commit af8aa1ad7eb4857a86d395b3833b8040630306b6) Signed-off-by: Lucas Gass commit f681964591ba1efde4c1c8c032c344b85c1d1815 Author: Owen Leonard Date: Fri Aug 14 14:18:00 2020 +0000 Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 8344ee7b4ced266ac7bd48254f4695175fd8f19b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/acqui/addorderiso2709.tt | 1 - .../prog/en/modules/acqui/lateorders.tt | 23 +++++--- .../prog/en/modules/acqui/z3950_search.tt | 1 - .../prog/en/modules/catalogue/results.tt | 1 - .../en/modules/cataloguing/z3950_auth_search.tt | 1 - .../prog/en/modules/cataloguing/z3950_search.tt | 1 - .../prog/en/modules/offline_circ/list.tt | 30 +++++----- .../prog/en/modules/tools/batch_delete_records.tt | 67 +++++++++++++++------- .../en/modules/tools/batch_extend_due_dates.tt | 21 ++++--- .../en/modules/tools/batch_record_modification.tt | 16 ++++-- .../prog/en/modules/virtualshelves/shelves.tt | 17 ++++-- koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 14 ++--- koha-tmpl/intranet-tmpl/prog/js/pages/results.js | 10 +--- koha-tmpl/intranet-tmpl/prog/js/z3950_search.js | 12 ++-- 14 files changed, 126 insertions(+), 89 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 17:50:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 15:50:20 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-26-g7bc51edc0f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7bc51edc0f028cc73bd3214cf35981c2f4a4ec2e (commit) from 7ebeaf83730282fe5d6647a5c1260e61077990b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7bc51edc0f028cc73bd3214cf35981c2f4a4ec2e Author: Owen Leonard Date: Wed Aug 5 16:35:37 2020 +0000 Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 393ecb4a9cc4c906b4bfcecf6357874e300fa3bd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 17:55:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 15:55:06 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-27-g670193ad16 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 670193ad16c7d5e6f288bc6288a0a033f8e02026 (commit) from 7bc51edc0f028cc73bd3214cf35981c2f4a4ec2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 670193ad16c7d5e6f288bc6288a0a033f8e02026 Author: David Cook Date: Fri Aug 14 01:49:40 2020 +0000 Bug 25778: Fix var scope in koha-plack for PERL5LIB and KOHA_HOME Currently, if a koha-plack is given multiple instances, it will create duplicate $KOHA_HOME/installer and $KOHA_HOME/installer/lib entries in PERL5LIB as these changes are done at the global rather than local level. This issue can only be seen in non-dev Koha, since dev Koha installs rewrite PERL5LIB. This patch localizes PERL5LIB to each instance. To test dev installs: 0. cp debian/scripts/koha-plack /usr/sbin/koha-plack 1. koha-plack --restart kohadev 2. Note that nothing breaks To test non-dev installs: 0. Don't replace /usr/sbin/koha-plack yet 1. Create multiple non-dev installs with plack enabled and running 2. Set up one of these non-dev installs so you can use the web UI (that is beyong the scope of this test plan) 3. koha-plack --restart test1 test2 test3 4. For test3, go to /cgi-bin/koha/about.pl 5. Note that there are duplicate /usr/share/koha/installer and /usr/share/koha/lib/installer entries in PERL5LIB 6. cp debian/scripts/koha-plack /usr/sbin/koha-plack 7. koha-plack --restart test1 test2 test3 8. For test3, go to /cgi-bin/koha/about.pl 9. Note that there are no duplicates entries in PERL5LIB Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 89721cb42b3928c745677c70fd9061273d1848dd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-plack | 90 ++++++++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 41 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 18:10:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 16:10:21 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-28-gaccf08e638 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via accf08e638e39d53db077d6213b631dd30002acb (commit) from 670193ad16c7d5e6f288bc6288a0a033f8e02026 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit accf08e638e39d53db077d6213b631dd30002acb Author: Caroline Cyr La Rose Date: Tue Jul 7 16:01:58 2020 -0400 Bug 25945: Description of AuthoritySeparator is misleading This patch changes the description of the AuthoritySeparator system preference To test: 1. Apply patch 2. Go to Administration > Global system preferences > Cataloging and locate the AuthoritySeparator preference 3. Read the description and make sure it makes sense and that there are no typos or grammatical errors Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 7941d8d3c00086c7990cdfa4c72791ee96addfae) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 18:19:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 16:19:46 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-29-gdf5c9d0725 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via df5c9d0725dec84a3d57f97a7728cbc7e1cac9fc (commit) from accf08e638e39d53db077d6213b631dd30002acb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit df5c9d0725dec84a3d57f97a7728cbc7e1cac9fc Author: Jonathan Druart Date: Tue Aug 18 08:54:43 2020 +0000 Bug 26233: (bug 25553 follow-up) Make date columns sortable on the edit items table We were missing to pass the title-string to datatables. Test plan: Retest bug 26233, with appropriate dates Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 18:23:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 16:23:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-30-g2ea51ab86e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2ea51ab86e7599445c29044c0e7c30db0b3fbbe0 (commit) from df5c9d0725dec84a3d57f97a7728cbc7e1cac9fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ea51ab86e7599445c29044c0e7c30db0b3fbbe0 Author: Owen Leonard Date: Wed Aug 5 18:24:08 2020 +0000 Bug 26153: Remove the use of jquery.checkboxes plugin from items lost report This patch removes the use of the jquery.checkboxes plugin from the lost items report page and replaces it with custom JS. To test, apply the patch and go to Reports -> Lost items. - Run the report with parameters which will return multiple results. - On the results page Create a CSV export profile if there's none. - On the results page test the "Select all" and "Clear all" links at the top of the results. The controls should work correctly. Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e24a294f393defeea12fd0bbfba73839c29d14f0) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 18:38:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 16:38:39 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-31-ga02cfb0c6f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a02cfb0c6f502744e4caeb5a38783623ffde4ca0 (commit) from 2ea51ab86e7599445c29044c0e7c30db0b3fbbe0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a02cfb0c6f502744e4caeb5a38783623ffde4ca0 Author: Didier Gautheron Date: Tue May 26 13:31:31 2020 +0200 Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text Test plan : 1- Create a new report : select * from items; 2- Run it 3- Download the report as a tab separated text 4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.' in plack-error.log 5- Apply patch 6- Restart all 7- Redo 2 and 3 8- No more warning. 9- diff both downloaded files, they must be the same. Signed-off-by: Marco Abi-Ramia Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 392a7e1a1ffb327986a5c0cb6863bbb87e43deaf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 18:48:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 16:48:47 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-32-gf470d3f75d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via f470d3f75d55201e5caa088919fe3d30586c92a9 (commit) from a02cfb0c6f502744e4caeb5a38783623ffde4ca0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f470d3f75d55201e5caa088919fe3d30586c92a9 Author: Marcel de Rooy Date: Wed Aug 19 11:46:16 2020 +0000 Bug 26251: Remove unused routines from svc/split_callnumbers This is just a copy and paste from svc/localization Test plan: Read the code. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 909755e5f66adea521a5b516c86bfdb5a83f6b0d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: svc/split_callnumbers | 74 +-------------------------------------------------- 1 file changed, 1 insertion(+), 73 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 19:07:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 17:07:24 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-33-g8a4a166713 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8a4a1667136332a4a8d84df00617d9e70673fd67 (commit) from f470d3f75d55201e5caa088919fe3d30586c92a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8a4a1667136332a4a8d84df00617d9e70673fd67 Author: Colin Campbell Date: Wed Jul 29 13:23:14 2020 +0100 Bug 26082: Call store on new items to update itemnumber Need to add call to store to Koha::Item->new so that itemnumber is returned - otherwise is not defined and causes an error Bug is a side-effect of Bug 23463 as this was implicitly done in AddItem Also set biblioitemnumber explicitly for item adds this also used to be done explicitly but can now cause an FK error Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit b5a36c20a20721e82820ccaaf139285beadbaaf0) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/EDI.pm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 19:42:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 17:42:53 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-34-ga5d4e0cd66 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a5d4e0cd66dcd9ccfaad7f8c6a4033483ead4769 (commit) from 8a4a1667136332a4a8d84df00617d9e70673fd67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5d4e0cd66dcd9ccfaad7f8c6a4033483ead4769 Author: Jonathan Druart Date: Mon Jun 1 10:19:05 2020 +0200 Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin The 'Sent to' and 'Status' column values were not translatable. Test plan: Translate the interface Report some problems at the OPAC Go to the admin page and notice that all the columns are now translated Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit af0929abbb72c9c2469b1f2ccba338f51801ad98) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/problem-reports.tt | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 20:15:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 18:15:29 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-36-gafd9828ba3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via afd9828ba357fcbd16973c8e84a8a170eaf053ba (commit) via e9591ae761c569b12c7641d9cc1733c4879108fe (commit) from a5d4e0cd66dcd9ccfaad7f8c6a4033483ead4769 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afd9828ba357fcbd16973c8e84a8a170eaf053ba Author: Martin Renvoize Date: Tue Aug 4 15:02:03 2020 +0100 Bug 26023: Properly secure the cashup and refund actions The cash register summary page for cash management is available for users with the 'anonymous_refund' or 'cashup' permission and the actions available are appropriately displayed. However, the actions are not yet correctly tested for at the server and so a user may force submit to accomplish the action. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e0420165694c790f2346fb598862e4aacfdf0fcc) Signed-off-by: Lucas Gass commit e9591ae761c569b12c7641d9cc1733c4879108fe Author: Martin Renvoize Date: Mon Jul 20 09:44:05 2020 +0100 Bug 26023: Properly secure the cashup action for libraries The libraries summary page for cash management is available for users wit the 'anonymous_refund' permission to allow them to navigate to alternate cash registers and search for the prior transaction to refund. However, currently the cashup option appears, and is not blocked at the server, for all user who may access the page. It should be blocked for those users without the 'cashup' permission. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4356e678f2254707c48a6f89658ed089a6b9e662) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/pos/register.tt | 12 ++++ .../intranet-tmpl/prog/en/modules/pos/registers.tt | 20 +++++- pos/register.pl | 82 ++++++++++++---------- pos/registers.pl | 29 ++++---- 4 files changed, 94 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 20:23:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 18:23:21 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-41-geef685ee19 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via eef685ee19e81ea50c90863634922ad62ea6cd1f (commit) via b1b018e04aeff8b59c2707ab28388002150ae65f (commit) via 2d741d4d7158eff6dbeaf64bfc7e1fd9db9458a1 (commit) via 13c5c4d85e8aaf57e511f037cb4e5de32066eebf (commit) via a831c288da603f022a9894d560ed542e69feb5e3 (commit) from afd9828ba357fcbd16973c8e84a8a170eaf053ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eef685ee19e81ea50c90863634922ad62ea6cd1f Author: Andrew Nugged Date: Mon Jul 20 00:16:51 2020 +0300 Bug 24683: IsAvailableForItemLevelRequest sub description expanded Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit d19e76000f02533302d8093e051cf3a0034d1e27) Signed-off-by: Lucas Gass commit b1b018e04aeff8b59c2707ab28388002150ae65f Author: Andrew Nugged Date: Mon Jul 20 00:15:37 2020 +0300 Bug 24683: whole test formatted by 'perltidy' This is complementary patch using styling from bundled /xt/perltidyrc file Almost no code change except a few long constant strings broken to parts by concatenation. Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c4f475d1a4e64e8e437e9b4906af9cba6c0756f) Signed-off-by: Lucas Gass commit 2d741d4d7158eff6dbeaf64bfc7e1fd9db9458a1 Author: Andrew Nugged Date: Mon Jul 20 00:20:56 2020 +0300 Bug 24683: Fix for take smart rules into account in "if all unavailable" Inside of ItemsAnyAvailableAndNotRestricted was no effect from main set of smart rules (per record and other limits): i.e. call to "CanItemBeReserved" was absent totally. Because of this there was a bug: for example none of two items were allowed to be held when first was allowed by one smart rule, BUT on loan, and second was disallowed by another smart rule (for example, 0 "Holds per record"), i.e. in this case both items unavailable: so on-shelf holds setting "allow hold if all unavailable" should allow to hold first one, and not the second one. But it was that both wasn't allowed to be held. Solution: call to sub "CanItemBeReserved" added so it checked for "...->{status} ne 'OK'" so now if item restricted by smart rule it also accounted as "unavailable" and "AnyAvailavble" not counts it. How to reproduce: 1. Add 2 smart rules (/cgi-bin/koha/admin/smart-rules.pl) with "on shelf holds": "if all unavailable" for all rules, no "item level holds", and set "holds per record" to 2 for "books" and "0" for "computer files". 2. Create only 2 items for one biblio, but different types, "book" and "computer file". For example in misc4dev env: /cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additem 3. Check out that item of type "book" to some person, for example, in misc4dev: /cgi-bin/koha/circ/circulation.pl?borrowernumber=2&barcode=3999900000001 4. Open reserve/request, for example, for item 1 and patron 1 in misc4dev env (/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1) 5. It does not allow to hold, both red crossed, but computer file says "Exceeded max holds per record" because of "0" limit set on step 1. 6. Apply the patch. 7. Reload page on step 5 and see that "book" will be available for hold, but "computer file" still will be red-crossed "Exceeded max holds per record", now that's correct because both items unavailable: one because on load, another because of "0" limit for computer files. 8. Check-in book from step 3 so it will be returned to the library, 9. Reload page on step 5 and see that again no any holds available, but it's now also correct: "book" now returned but "on shelf holds" set to "if all unavailable". Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4599fcc59d4036cb5e3d776b9f162062968e8d98) Signed-off-by: Lucas Gass commit 13c5c4d85e8aaf57e511f037cb4e5de32066eebf Author: Andrew Nugged Date: Fri Jul 17 14:59:19 2020 +0300 Bug 24683: Optimize loop in ItemsAnyAvailableAndNotRestricted Add cut-off shortcut (return from inside the loop) when first "Any Available And Not Restricted" item found, because one is enough for "Any". Testing: no change visible for code behavior/results, it is just faster because won't loop over the whole set. Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 720b69780c1f62c61f4b36df02d46d8c85c0d30a) Signed-off-by: Lucas Gass commit a831c288da603f022a9894d560ed542e69feb5e3 Author: Andrew Nugged Date: Fri Jun 5 09:59:48 2020 +0300 Bug 24683: Subroutine name changed (fix), no code logic changed This is the intermediate refactor: renamed subroutine only. Naming mistake came because this sub is used to detect if anything available for hold, but it used in "if ANY UNAVAILABLE rule", so actually results of this sub negated (see below "return" in the code). In details: when previous refactor was done, name for subroutine was chosen wrongly in "opposite" direction from what it actually does: it was named "ItemsAnyAvailableForHold", but this subroutine gave truth (1) if at least one of the items available on shelf, not lost, not on loan, not held, and not restricted by smart rules and damaged status. So, if this sub says that item is still "available", this actually PREVENTS item from hold in parent sub (see negated return): sub IsAvailableForItemLevelRequest { ... my $any_available = ItemsAnyAvailableAndNotRestricted... return $any_available ? 0 : 1; # ^^^ if any available and not restricted - we don't allow # on-shelf holds ... I.e. like it named now: "ItemsAnyAvailableAndNotRestricted". Small aside fix: white space for '&&' inside brackets added to join operation by priority visually. Testing plan not needed: all places where sub used it just renamed. More: all this places/code was introduced in one older commit so there is also no overlaps or other calls/uses for this subroutine. Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 618cf80df9b0b668174b28ff61cad8a938704ec3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 34 +- reserve/request.pl | 2 +- .../Holds/DisallowHoldIfItemsAvailable.t | 367 +++++++++++++-------- 3 files changed, 258 insertions(+), 145 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 20:27:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 18:27:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-43-g3a4f76b60d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3a4f76b60d880fabb5bb6637839d1a83e673e1d6 (commit) via 2e3b3a23fc6c3c1183853a6b5022598930b55b0d (commit) from eef685ee19e81ea50c90863634922ad62ea6cd1f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3a4f76b60d880fabb5bb6637839d1a83e673e1d6 Author: Kyle M Hall Date: Thu Jul 30 09:35:38 2020 -0400 Bug 26076: (QA Follow up) Prevent error by using a fresh resultset Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c9887a87538b2113c48db8cd2751a4bcf2bd2168) Signed-off-by: Lucas Gass commit 2e3b3a23fc6c3c1183853a6b5022598930b55b0d Author: Kyle M Hall Date: Tue Jul 28 12:49:35 2020 -0400 Bug 26076: Sum the amount due in the database query instead of a loop in Perl This appears to be a bug due to inaccuracies in floating point math. I've been unable to reproduce it on demand. Sometimes when using the "Write off selected" button, Koha will give the error that the payment is more than the amount owed, even though they are the same. The solution I've implemented is to move the summation from Perl code to the database query. This video demonstrates the issue and afterward, shows the error goes away after the patch is applied: https://monosnap.com/file/pG69HC7iI9mU9kkuoCtbkVzVTffKlE Test Plan: 1) Apply this patch 2) Restart all the things! 3) Verify that "Write off selected" functions as usual Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 64412969037ac9a9f81f05c69c3dd43bd3cab90b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: members/paycollect.pl | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 20:33:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 18:33:59 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-45-g73c246238b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 73c246238bc21aa48689a8027cd3ae01fb7f9232 (commit) via b870bac520083283abb199a059ed767165ead677 (commit) from 3a4f76b60d880fabb5bb6637839d1a83e673e1d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 73c246238bc21aa48689a8027cd3ae01fb7f9232 Author: Kyle M Hall Date: Thu Aug 20 07:56:12 2020 -0400 Bug 25903: Add unit tests Signed-off-by: Jonathan Druart (cherry picked from commit 49f5200374e9a381ab7398730e42c0beefc0f2a4) Signed-off-by: Lucas Gass commit b870bac520083283abb199a059ed767165ead677 Author: Kyle M Hall Date: Tue Jun 30 14:37:21 2020 -0400 Bug 25903: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server The 'summary' field in the patron information request specifies if detail information should be send for holds, overdues, fines, etc. The field is 10 characters in length (0-9). However, the SIP2 spec only defines indexes 0 though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these undefined indexes. Apparently the 7th field is often used to request 'Fees', as opposed to 'Fines' in some ILS. Some software that integrate via SIP try both the 5th and 7th indexes to ensure they get all fines and fees. The problem is that Koha's SIP server crashes if any 'summary' index beyond 5 is flagged. We should simply ignore flags beyond 5 and act as if no flags were sent. Test Plan: 1) Enable SIP for your instance 2) Send a patron information request with a summary flag in any index beyond 5. i.e.: 6300120200617 124846 Y AOMIDAY|AA21030050054321 3) Note the SIP server just closes the connection without a response 4) Apply this patch 5) Restart the SIP server 6) Send the same request 7) Note you get back the patron information response! Signed-off-by: Kyle M Hall Signed-off-by: Jeff Gaines Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit fd4dbba7fb25bb73bcee152c84e704f9796664fd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 8 +++---- t/db_dependent/SIP/Message.t | 56 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 59 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 20:37:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 18:37:52 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-46-g59b67c3b37 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 59b67c3b37ed92926e9c75c0637c58af255ecec2 (commit) from 73c246238bc21aa48689a8027cd3ae01fb7f9232 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59b67c3b37ed92926e9c75c0637c58af255ecec2 Author: Lucas Gass Date: Wed Jul 15 22:28:07 2020 +0000 Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 6797f07bbdfb90c556f52bfe2f83cefdf91495f3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:05:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:05:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-48-g6bbfedd3f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6bbfedd3f4158c67003b74721bdd3cba6f33e7e7 (commit) via 2c5cd4ffbe762164cfcf5d603e926fe177bb642c (commit) from 59b67c3b37ed92926e9c75c0637c58af255ecec2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6bbfedd3f4158c67003b74721bdd3cba6f33e7e7 Author: Lucas Gass Date: Fri Sep 4 19:34:01 2020 +0000 Bug 26189: Compile CSS Signed-off-by: Lucas Gass commit 2c5cd4ffbe762164cfcf5d603e926fe177bb642c Author: Martin Renvoize Date: Wed Aug 12 13:58:58 2020 +0100 Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit b65efd3f224342be8e751e54f7ada8fc482755bb) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 11 +++++++++++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:09:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:09:12 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-49-g5f6b557599 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5f6b557599b83e0230a3dca5b527924e883d17a3 (commit) from 6bbfedd3f4158c67003b74721bdd3cba6f33e7e7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f6b557599b83e0230a3dca5b527924e883d17a3 Author: Kyle M Hall Date: Wed Oct 10 11:13:37 2018 -0400 Bug 21539: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan Signed-off-by: Daniel Gaghan Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0c79b7d93b96434ddf91c6ddabb1570836736a15) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:13:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:13:13 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-50-g04cea9d7e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 04cea9d7e35c25c9b42d167ceeead892c9cf3ae6 (commit) from 5f6b557599b83e0230a3dca5b527924e883d17a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 04cea9d7e35c25c9b42d167ceeead892c9cf3ae6 Author: Owen Leonard Date: Wed Aug 5 17:00:26 2020 +0000 Bug 26150: Remove the use of jquery.checkboxes plugin from inventory page This patch removes the use of the jquery.checkboxes plugin from the inventory page and replaces it with custom JS. To test, apply the patch and go to Tools -> Inventory. - Submit the form with some selections which will return results on the following page. I filtered by library. - On the page showing results, test that the "Select all" and "Clear all" links work correctly. Signed-off-by: Brandon J Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9655029bca97ab5f159f03acadf6601b5edbc421) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/tools/inventory.tt | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:35:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:35:21 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-54-gb5f0fce5f5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b5f0fce5f53f731df4d4271785eab8e8a3293364 (commit) via 9a544a86dbaa00dfce906f683556fea5d30805fb (commit) via bd56e23748f459f983bbca07bc7b019b70192dd5 (commit) via 411619f209d071a8e2250a8979f3a336827dafb5 (commit) from 04cea9d7e35c25c9b42d167ceeead892c9cf3ae6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5f0fce5f53f731df4d4271785eab8e8a3293364 Author: Lucas Gass Date: Fri Sep 4 19:59:42 2020 +0000 Bug 25958: DB Rev 20.05.03.001 Signed-off-by: Lucas Gass commit 9a544a86dbaa00dfce906f683556fea5d30805fb Author: Kyle M Hall Date: Mon Aug 24 13:13:17 2020 -0400 Bug 25958: (QA follow-up) Implement filter in database query instead of in loop Signed-off-by: Jonathan Druart (cherry picked from commit 66382458dc46356818473935e8d5546f13f05645) Signed-off-by: Lucas Gass commit bd56e23748f459f983bbca07bc7b019b70192dd5 Author: Katrin Fischer Date: Sat Aug 22 02:41:20 2020 +0000 Bug 25958: (QA follow-up) Add some punctuation to new DefaultLongOverdueSkipLostStatuses Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit d99651efd0a9a827b91f4575ab6f1d4344c7cfb0) Signed-off-by: Lucas Gass commit 411619f209d071a8e2250a8979f3a336827dafb5 Author: Kyle M Hall Date: Tue Jul 28 07:55:18 2020 -0400 Bug 25958: Allow LongOverdue cron to exclude specified lost values When lost items are not marked as returned, they are still subject to the long overdue cron, so an item that has already been marked Lost may automatically roll to Long Overdue. In some cases, a library may not want that lost value to change. This becomes especially important with the introduction of Claims Returned, which uses a variety of lost. Test Plan: 1) Set up a long overdue item that would be moved to lost by longoverdue.pl 2) Run the cronjob with the new --skip-lost-value option 3) Note the item is not altered 4) Include that value in the new system preference DefaultLongOverdueSkipLostStatuses 5) Run the cronjob *without* the new option 6) Note the item is not altered 7) Run the cronjob again with the new command line option, but set it to a different value so the item will be affected 8) Note the item is altered as it would have been before this patch was applied Signed-off-by: Lisette Scheer Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 48edb2947163c1e9a70b11de40a71ebed747952f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 +++ .../en/modules/admin/preferences/circulation.pref | 6 ++ misc/cronjobs/longoverdue.pl | 73 +++++++++++++++------- 5 files changed, 67 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:43:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:43:09 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-57-g6c442331b5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6c442331b5bc981ca3be61308a65cbc937bdcb21 (commit) via 3fac75b079299a49f90d0b958753f3c2c7e15b1f (commit) via 163d80a55d2f4f22954a7194ab3dbdc3a1460d31 (commit) from b5f0fce5f53f731df4d4271785eab8e8a3293364 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c442331b5bc981ca3be61308a65cbc937bdcb21 Author: Tomas Cohen Arazi Date: Tue Jun 23 10:35:54 2020 -0300 Bug 25662: (follow-up) Add tests for the wrong patron_id added behaviour This patch adds trivial tests for the new error (400) raised when the passed patron_id doesn't exist. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit deee485a24df0734cace673dc519f15d41a5b575) Signed-off-by: Lucas Gass commit 3fac75b079299a49f90d0b958753f3c2c7e15b1f Author: Tomas Cohen Arazi Date: Tue Jun 23 10:33:14 2020 -0300 Bug 25662: Make the route for holds restpect maxreserves This patch fixes the behaviour for the POST /holds route. It assumed maxreserves was checked in CanItemBeReserved which is not the case. Tests are added to check for this behaviour. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 69bdc94cd4f420094c5706fb2bfc472ba24a5054) Signed-off-by: Lucas Gass commit 163d80a55d2f4f22954a7194ab3dbdc3a1460d31 Author: Tomas Cohen Arazi Date: Tue Jun 23 10:11:58 2020 -0300 Bug 25662: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9a63cf6dec55c67491e5a2807fe74f9083167ccc) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Holds.pm | 12 +++++ t/db_dependent/api/v1/holds.t | 103 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 113 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:49:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:49:54 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-58-g756283883a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 756283883a5682c87d3424eaeaf9f286b8d8f3e2 (commit) from 6c442331b5bc981ca3be61308a65cbc937bdcb21 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 756283883a5682c87d3424eaeaf9f286b8d8f3e2 Author: Fridolin Somers Date: Fri Aug 7 10:58:51 2020 +0200 Bug 26175: Remove warn if undefined barcode in misc/export_records.pl When using misc/export_records.pl --deleted_barcodes if barcode is NULL you get warn : Use of uninitialized value in say at /home/koha/src/misc/export_records.pl Also exporting barcode if empty string makes no sense. Test plan : 1) Delete an item with barcode = NULL 2) Run : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/deleted_barcodes 3) Check you se no warn "Use of uninitialized value in say ..." 4) Delete an item with barcode = '' 5) Run 2) 6) Check there is no empty line in /tmp/deleted_barcodes Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 4d9ab04a9391a4960a6155d983fdf839467bfdf4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/export_records.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 22:53:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 20:53:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-59-gb8d9d6242d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b8d9d6242d837162e210c7adfd486521a6246733 (commit) from 756283883a5682c87d3424eaeaf9f286b8d8f3e2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b8d9d6242d837162e210c7adfd486521a6246733 Author: Katrin Fischer Date: Fri Jul 17 22:03:28 2020 +0000 Bug 26013: Fix formatting for dates on "Manage stage MARC records" page The "staged" dates were not formatted according to system preferences DateFormat and TimeFormat as the appropriate TT filters were missing. To test: - Stage a record in MARC format - Go to Staged MARC management - Check the date in the list of imports - Click on the import and check the "Staged:" date - Apply patch - Repeat and verify formatting is now correct Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart (cherry picked from commit 9e97dbca2983163e1ffc19fc435ac8bea6550c82) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 23:00:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 21:00:35 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-60-g4a2e76d83a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 4a2e76d83ae76f72365f663effa372d018638856 (commit) from b8d9d6242d837162e210c7adfd486521a6246733 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4a2e76d83ae76f72365f663effa372d018638856 Author: Nick Clemens Date: Wed Jul 29 10:56:37 2020 +0000 Bug 25639: Add search query strings as global javascript variables To test: 1 - Search on OPAC for "qwertyuiop" 2 - View the HTML source 3 - Find 'qwertyuiop' in the source, it is not easily accessible via JS 4 - Apply patch 5 - Repeat 6 - Note that now there are global variables with the query strings 7 - Add to OpacUserJs: console.log( query_desc ); console.log( querystring ); console.log( query_cgi ); 8 - Reload page and confirm variables are warned in the JS console (Press F12) 9 - Sign off Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit cf93255428125241745faaaec0a0b1f8455c7526) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 6 ++++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 23:11:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 21:11:08 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-61-g8ff281cca5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8ff281cca587a612628014a45d0211b7295849f8 (commit) from 4a2e76d83ae76f72365f663effa372d018638856 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ff281cca587a612628014a45d0211b7295849f8 Author: Owen Leonard Date: Tue Aug 25 19:30:00 2020 +0000 Bug 26289: Add missing variable definition to templates This patch puts definition of the missing "searchid" variable into an include file to be used by various bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the detail view, ISBD view, MARC view, and items view. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a4e922ffe8a5ea760f2401aca44b1dd9be97c7ec) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 23:12:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 21:12:44 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-62-g8c5b2ddec3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8c5b2ddec3d3f779e5256b6cb2a4869abb21e595 (commit) from 8ff281cca587a612628014a45d0211b7295849f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c5b2ddec3d3f779e5256b6cb2a4869abb21e595 Author: Lucas Gass Date: Fri Sep 4 20:42:21 2020 +0000 Revert "Bug 26289: Add missing variable definition to templates" This reverts commit 8ff281cca587a612628014a45d0211b7295849f8. Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc | 6 ------ 1 file changed, 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 23:18:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 21:18:45 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-65-g81865f7777 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 81865f77777273d96169bfe6afa760e11be0c7da (commit) via f297fb819c38553899f2cde10b108ca8fa712dce (commit) via 0bfeb9990181445a14e4858b3d61954c1daf30ce (commit) from 8c5b2ddec3d3f779e5256b6cb2a4869abb21e595 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81865f77777273d96169bfe6afa760e11be0c7da Author: Jonathan Druart Date: Mon Aug 31 15:25:05 2020 +0200 Bug 17661: Trivial simplification using += operator Signed-off-by: Jonathan Druart (cherry picked from commit c96fabb8c47320dba55372e4b955fb171310adec) Signed-off-by: Lucas Gass commit f297fb819c38553899f2cde10b108ca8fa712dce Author: Nick Clemens Date: Thu Aug 27 16:27:09 2020 +0000 Bug 17661: (follow-up) Update regex to support Unicode characters Rather than limiting initials to [A-Z] we should test for a broad range of uppercase letters. The ES/Zebra changes are slightly different because of Perl vs Java regex conventions. POerl may support either, but I found 'Uppercase' to be a bit more explicit More info here: https://perldoc.perl.org/perlunicode.html TO test: Same plan as before but use Ж. as the ending initial Confirm the period is preserved and other punctuation removed Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 224ac84aeca3b8dba87366925d83b01e0f5c1110) Signed-off-by: Lucas Gass commit 0bfeb9990181445a14e4858b3d61954c1daf30ce Author: Nick Clemens Date: Thu Nov 2 16:52:53 2017 +0000 Bug 17661: Ending punctuation causes duplicate facets The current code for facets doesn't pull strip ending punctuation from facets This causes duplicate facets for terms that should be combined Sometimes series can have different punctuation depending on the field they are in Author initials punctuation should be preserved To test: 1 - Do search and pull up some records 2 - Edit some of the records to have authors like: Date, C.J. Date, C.j. Date, C.J . 3 - Edit the records to have some series statments like: 830 $aDate, C.J. ;$v5 830 $aDate, C.J. ; $v5 830 $aDate, C.J.; $v5 4 - Add some 490s to the record with first indicator 1 and series like: You wouldn't want to-- You wouldn't want to You wouldn't want to.. 5 - Search again and note you have 3 facets each for author and series 6 - Apply patch 7 - Repeat 8 - Now you get 2 facets for author, period not removed when following Upper case immediately, is otherwise 9 - Now you should have a single series facet 10 - Switch search engine to ES (index before applying patch) 11 - Note facets are separate again 12 - Reset mappings and reindex perl misc/search_tools/rebuild_elasticsearch -v -r 13 - Repeat search, facets combined as above Signed-off-by: Sarah Cornell Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e34f95a1f5eb0fce238ab442553bec5233263a9c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 4 +++- admin/searchengine/elasticsearch/field_config.yaml | 1 + admin/searchengine/elasticsearch/index_config.yaml | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 23:33:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 21:33:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-66-g48b10b3cf5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 48b10b3cf5f267b15d8f2008e90e0a88d379fe1d (commit) from 81865f77777273d96169bfe6afa760e11be0c7da (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48b10b3cf5f267b15d8f2008e90e0a88d379fe1d Author: Jonathan Druart Date: Fri Aug 21 16:07:46 2020 +0200 Bug 26069: Pass correct URL to twitter We don't provide the url of the detail page so the twitter JS code retrieve the current location, with the search terms. Test plan: Do a search Click on a result Click on the twitter button and confirm that the link only contain biblionumber=x in the parameter Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 5fd8774c687c6aaf6716485ab9bd72a69a0e2f76) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 4 23:47:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 21:47:11 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-67-g1475ea89e5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 1475ea89e5daedf4a5fea29c09feb4ca5561aa39 (commit) from 48b10b3cf5f267b15d8f2008e90e0a88d379fe1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1475ea89e5daedf4a5fea29c09feb4ca5561aa39 Author: Jonathan Druart Date: Mon Aug 31 14:26:26 2020 +0200 Bug 26324: Fix spelling resizable vs resizeable in Dopop The correct spelling of the parameter is resizable https://developer.mozilla.org/fr/docs/Web/API/Window/open Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ce7f4d16d6acdc6a56d40e6ebd96d722f1c77387) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/global.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Sep 5 00:18:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 22:18:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-69-g81fd27153a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 81fd27153a26154da576eaaba7274968b36f1a3f (commit) via def41d6231ae204022664d6d2b7de02fbb4c1414 (commit) from 1475ea89e5daedf4a5fea29c09feb4ca5561aa39 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81fd27153a26154da576eaaba7274968b36f1a3f Author: Tomas Cohen Arazi Date: Thu Aug 27 15:10:08 2020 -0300 Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2a0ccf7af26236db9a3e40968cf8f43bc308f142) Signed-off-by: Lucas Gass commit def41d6231ae204022664d6d2b7de02fbb4c1414 Author: Tomas Cohen Arazi Date: Thu Aug 27 14:57:45 2020 -0300 Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 7fc7427dd41ce10070a6a3d3070fb660850be511) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Sep 5 00:22:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 Sep 2020 22:22:48 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-70-ge550f25a01 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e550f25a013f43bec8c2ee1694541dafd2a84a85 (commit) from 81fd27153a26154da576eaaba7274968b36f1a3f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e550f25a013f43bec8c2ee1694541dafd2a84a85 Author: Jonathan Druart Date: Thu Aug 20 14:32:43 2020 +0200 Bug 24147: Don't assume search_related will return ordered values This test is failing randomly because it assume the order is always the same. But it's not. Note: Koha::Objects->search_related is never used , last use removed from commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada Bug 19599: Speed anonymise_issue_history up We should keep it however IMO Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e10dc503289e8d7e8c742af0111acb79d4d53111) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Objects.t | 51 +++++++++++++++++++++++++++++++++---------- 1 file changed, 39 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 7 02:21:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Sep 2020 00:21:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-4-g9b3addb185 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 9b3addb185e0b20732c85ccccd07ba518a5cabf0 (commit) from fba279050a344cfb43a189d11e041cdb4326acf4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9b3addb185e0b20732c85ccccd07ba518a5cabf0 Author: Lucas Gass Date: Thu Sep 3 03:57:01 2020 +0000 Bug 26361: switch TableSettings to ColumnSettings Test Plan: -Be on 20.05.x -Go to returns.tt -See the error Uncaught SyntaxError: expected expression, got keyword 'var'. -Apply patch -Reload returns.tt, no error Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass (cherry picked from commit 2b6b7cb265acc77f8925eec9a9f315f249a85348) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 7 04:28:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Sep 2020 02:28:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-7-g85a648431b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 85a648431bfa45de3bf1978319cd46f0632f5c98 (commit) via b8de520952b205d94f97de6ad2d9b94346475a81 (commit) via 97ba8f85d7f4feb6c078714b89fd02d3cd6f2a15 (commit) from 9b3addb185e0b20732c85ccccd07ba518a5cabf0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 85a648431bfa45de3bf1978319cd46f0632f5c98 Author: Kyle M Hall Date: Mon Jun 22 09:25:54 2020 -0400 Bug 25783: Modify calls to AddReserve to match Koha 19.11.x AddReserve prototype Signed-off-by: Aleisha Amohia commit b8de520952b205d94f97de6ad2d9b94346475a81 Author: Kyle M Hall Date: Wed Jun 17 11:41:21 2020 -0400 Bug 25783: Holds Queue treating item-level holds as bib-level The holds queue builder does not honor the new item_level_hold flag. Instead, it only item_level_request if in the loop dealing with item level holds. This is incorrect. Item level holds may be trapped in the local holds priority loop as well. It's trivial to just pass though the correct item/biblio level hold flag. I do not know how to write a reproducable test plan for these issues. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kim Peine Signed-off-by: Jonathan Druart (cherry picked from commit db235d33a4caf64387b86ebab7b658bd7759ff21) (cherry picked from commit aa4eba6d232fd5009312286f5e3575c4ca25e9f3) Signed-off-by: Aleisha Amohia commit 97ba8f85d7f4feb6c078714b89fd02d3cd6f2a15 Author: Tomas Cohen Arazi Date: Wed Jun 17 17:18:12 2020 -0300 Bug 25783: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kim Peine Signed-off-by: Jonathan Druart (cherry picked from commit dd4970860d4299c89ce4a698644c08f990bc1468) (cherry picked from commit ad6b6db41e92168a3e23d64949817fddb8927aa0) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/HoldsQueue.pm | 8 +++--- t/db_dependent/HoldsQueue.t | 63 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 66 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 7 05:46:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Sep 2020 03:46:47 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-8-g5646b2a6f7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5646b2a6f7f1530a6853b493e10b1e3e8fc09995 (commit) from 85a648431bfa45de3bf1978319cd46f0632f5c98 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5646b2a6f7f1530a6853b493e10b1e3e8fc09995 Author: Kyle M Hall Date: Wed Jun 17 12:53:36 2020 -0400 Bug 25786: Holds Queue building may target the wrong item for item level requests that match holds queue priority Bug 23934 removed the limitation that prevented item level holds from getting local holds priority. The problem is the code has never checked if the item level hold matches the given item! This means the wrong item may be requested to fill an item level hold. Test Plan: 1) Create 3 items on a record 2) Place a hold for the 2nd item you created 4) Ensure that hold would be picked up by local holds priority 5) Build the holds queue 6) Note the holds queue is asking for the wrong item! 7) Apply this patch 8) Rebuild the holds queue 9) Holds queue should now be asking for the correct item! Signed-off-by: Kim Peine Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit b17a04dd077bb118086ad9e4bb58eee81ade2cdd) (cherry picked from commit c6a1277fdb84df93be2cfa5cb0fa47c950116c20) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/HoldsQueue.pm | 2 ++ t/db_dependent/HoldsQueue.t | 66 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 67 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 7 19:55:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Sep 2020 17:55:00 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-1-g60f26dfaf5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 60f26dfaf5e2ee164bb1682a0aece62eed05e83c (commit) from e90f88f857fa1a886d9960e1c2aa34a7fe97d509 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 60f26dfaf5e2ee164bb1682a0aece62eed05e83c Author: Jonathan Druart Date: Fri Aug 21 14:00:51 2020 +0200 Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia (cherry picked from commit 7a34b88885c13a89cd713bb76eadef11472c1960) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: C4/XISBN.pm | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 06:28:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 04:28:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-9-g1e0c18d45e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1e0c18d45eca798ac1578f16d7be1dd5f52875e4 (commit) from 5646b2a6f7f1530a6853b493e10b1e3e8fc09995 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e0c18d45eca798ac1578f16d7be1dd5f52875e4 Author: Jonathan Druart Date: Thu Jul 30 14:16:09 2020 +0200 Bug 26090: Fix "item types" report This report was broken with SQL strict mode, but also without. DBD::mysql::st execute failed: 'koha_kohadev.itemtypes.itemtype' isn't in GROUP BY [for Statement " and, if no library was selected: DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'field list' [for Statement " This patch does the minimum to make it usable, but it would need more love. Test plan: To test you will need to try the 4 combinaisons: item-level_itypes = item or biblio With or without a library selected in the dropdown list Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 5bca73080f89bb2f4ca83ce6ceb9fa8e3c4a7d92) Signed-off-by: Lucas Gass (cherry picked from commit 69f16f7469c7cbbf571560d6f9389ef2dd170aa7) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: reports/itemtypes.plugin | 72 ++++++++++++++++-------------------------------- 1 file changed, 24 insertions(+), 48 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 06:32:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 04:32:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-11-gcf9d0e651b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via cf9d0e651b0b7686a25602336b8d3060388de0e9 (commit) via 1b2eedbea95a2d5f2c9cac9999d64941541ae4d5 (commit) from 1e0c18d45eca798ac1578f16d7be1dd5f52875e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cf9d0e651b0b7686a25602336b8d3060388de0e9 Author: Nick Clemens Date: Fri Aug 14 11:30:12 2020 +0000 Bug 26078: (follow-up) Use a boolean rather than changing returnbranch Bug 26078: (follow-up) used validTransfer instead of checking WrongTransfer message Signed-off-by: Jonathan Druart (cherry picked from commit d8f3e0ec0dbaf73075299a88a254334cfaf1d29e) Signed-off-by: Lucas Gass (cherry picked from commit 0b444c4bc0f3a677acfc2423b19a04ddea8b9dff) Signed-off-by: Aleisha Amohia commit 1b2eedbea95a2d5f2c9cac9999d64941541ae4d5 Author: Nick Clemens Date: Thu Jul 30 16:59:14 2020 +0000 Bug 26078: Prevent generating a new transfer from return policy when resolving a transfer To test: - Have 2+ branches - Set your default return policy to Item returns to issuing library - Find an item with holding branch of Branch A - Set your library to Branch B - Check item in - Koha generates a transfer to Branch A. In doing so, it sets the item holding branch to Branch B - Set your library to Branch A - Check item in - Koha generate a transfer to Branch B. In doing so, it sets the item holding branch to Branch A - Set you library to Branch A - Check the item in . . . Repeat indefinitely. Apply patch Repeat No more loop Signed-off-by: Sally Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 47671123206a475f86de9316d8b256e14aa54bc1) Signed-off-by: Lucas Gass (cherry picked from commit 8bd9c4b4fd44990c7a806de21e8628e1955a3c56) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 8 +++++--- t/db_dependent/Circulation/Branch.t | 8 +++++++- 2 files changed, 12 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 06:44:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 04:44:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-12-g518ea70806 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 518ea70806ec765766a31bbcfcbfa216cbf94eb1 (commit) from cf9d0e651b0b7686a25602336b8d3060388de0e9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 518ea70806ec765766a31bbcfcbfa216cbf94eb1 Author: Tomas Cohen Arazi Date: Mon Aug 17 12:12:55 2020 -0300 Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. It also replaces the use of 'gulp-util' (deprecated) by 'minimist' as recommended on their site. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit a7e3c12e6175e19299e7bdbe60d1bc7d41d45ce8) Signed-off-by: Lucas Gass (cherry picked from commit 65f443f22f78600979a36a422c8f1e71f580ee18) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: gulpfile.js | 62 ++-- package.json | 4 +- yarn.lock | 1028 +++++++++++++++++++++++++++++++++++++++++++--------------- 3 files changed, 800 insertions(+), 294 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 07:02:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 05:02:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-13-g104fba4bb0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 104fba4bb0e5dec1914978b324551e443eb51a40 (commit) from 518ea70806ec765766a31bbcfcbfa216cbf94eb1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 104fba4bb0e5dec1914978b324551e443eb51a40 Author: Jonathan Druart Date: Mon Aug 3 13:09:54 2020 +0200 Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail There is no good reason remove the ability to edit patron's attributes if PatronSelfRegistrationVerifyByEmail is set. We cannot have them in the self-registration form (because we don't store patron's attributes during self-ref), but we can have them when a patron show/edit their information. Test plan: 0. Enable PatronSelfRegistrationVerifyByEmail and create patron's attributes that can be edited at the OPAC 1. Create a new patron using the self-reg feature => You don't have the ability to fill in the patron's attribute 2. Edit your personal details (OPAC) => Without this patch you still don't see the patron's attribute that can be edited at the OPAC => With this patch applied you can! 3. Notice the wording change on the "Modify patron attribute type" form and confirm it makes sense Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fc22fb308bdbfc6d1bda3448e966542f2828ad76) Signed-off-by: Lucas Gass (cherry picked from commit ae54212e7d05564332dbb28b99ed61103cdecaae) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 07:12:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 05:12:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-14-gb1924d2127 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b1924d212715c806650a85b781f5ebb3ee531b71 (commit) from 104fba4bb0e5dec1914978b324551e443eb51a40 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b1924d212715c806650a85b781f5ebb3ee531b71 Author: Alex Buckley Date: Sun Jun 14 22:41:03 2020 +0000 Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded If 'Actual cost' has not been set then it has the value of 0.00 which Perl evaluates to true so this patchset resets it to 0, so the fallback to ecost_tax_included/ecost_tax_excluded happens. Test plan: 1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax') 2. Set 'Vendor price' = 10 and do not set 'Actual cost' 3. Save order 4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST column has value of -8.70 5. Jump into the database: select tax_value_on_ordering from aqorders where ordernumber=; [You can get the ordernumber from clicking on the 'Modify' line the item is listed in] 6. Observe a negative value: -8.70 7. Apply patch and restart plack 8. Add a second item to the basket 9. Set 'Vendor price' = 10 and don't set 'Actual cost' 10. Save order 11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST has value of 1.30 12. Repeat step 5 and observe tax_value_on_ordering = 1.30 13. Run t/Prices.t unit test: sudo koha-shell prove t/Prices.t Sponsored-by: Horowhenua District Council, NZ Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7b66b90fe707e8ac650a1c85d87560fc2f4a223d) (cherry picked from commit 3bbf6384492834055d38ac844521be6c02d503ab) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 1 + acqui/basket.pl | 2 ++ t/Prices.t | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 54 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 07:23:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 05:23:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-15-gedb729421f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via edb729421f26d9709140e24da559929d2843169a (commit) from b1924d212715c806650a85b781f5ebb3ee531b71 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit edb729421f26d9709140e24da559929d2843169a Author: Jonathan Druart Date: Tue Jun 16 15:44:40 2020 +0200 Bug 25751: Add ORDERED in dropdown list of suggestion's statuses The status "ORDERED" is missing from the pull down list of status values when editing a suggestion, so the first option is selected "No status". This leads to data loss when editing a suggestion in the status "ORDERED". Worse: the status can't be reset to "ORDERED" and so no AVAILABLE notice can be sent to the patron. Test plan: - Create a suggestion, accept it, create a new order from this suggestion. - Verify status is "ORDERED" - Edit the suggestion => Without this patch the dropdown list does not have "Ordered", and if you save you lost the status => With this patch applied the dropdown list has "Ordered" preselected. You can save and preserve the status. Signed-off-by: Holly Cooper Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit eeb7ac6fc0d14c9e731b7759c78f37cadcfa575f) Signed-off-by: Lucas Gass (cherry picked from commit c320dfa3beef2bce10e87572ee9dd7f6849a694f) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/suggestion/suggestion.tt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 15:06:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 13:06:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-947-g886d570e26 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 886d570e2686355b917bf3ca92c2dad029160352 (commit) via eb7a8db2c085290e5a5af968909964fe230b23ba (commit) via 94c68681181fee606a3c182c234511131dff641d (commit) via 221a40282c9fdd2d14488121d47e1529ec19cfc2 (commit) via 00b1bf3c2cce46878cb12957a8af999e02ec7b40 (commit) via 9cb89b46397efc5e288723829613c33e7eea0d69 (commit) from 83ebab049d8d3827226ef1700591ee63702ded17 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 886d570e2686355b917bf3ca92c2dad029160352 Author: Jonathan Druart Date: Wed Sep 9 12:28:13 2020 +0000 Bug 20168: DBRev 20.06.00.036 Signed-off-by: Jonathan Druart commit eb7a8db2c085290e5a5af968909964fe230b23ba Author: Jonathan Druart Date: Wed Sep 9 14:25:13 2020 +0200 Bug 20168: Compiled CSS Signed-off-by: Jonathan Druart commit 94c68681181fee606a3c182c234511131dff641d Author: Jonathan Druart Date: Wed Sep 9 14:33:23 2020 +0200 Bug 20168: Remove li tags from OPACSearchForTitleIn for new installs Signed-off-by: Jonathan Druart commit 221a40282c9fdd2d14488121d47e1529ec19cfc2 Author: Jonathan Druart Date: Wed Sep 9 14:23:41 2020 +0200 Bug 20168: Consider opaclayoutstylesheet empty if 'opac.css' Signed-off-by: Jonathan Druart commit 00b1bf3c2cce46878cb12957a8af999e02ec7b40 Author: Owen Leonard Date: Fri Sep 4 14:32:04 2020 +0000 Bug 20168: (follow-up) Add automatic creation of RTL CSS Signed-off-by: Jonathan Druart commit 9cb89b46397efc5e288723829613c33e7eea0d69 Author: Owen Leonard Date: Thu May 14 15:54:00 2020 +0000 Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 This patch updates the version of Bootstrap in the OPAC from 2.3.1 to 4.5.0. The Bootstrap JavaScript files have been replaced with custom builds of the 4.5.0 JavaScript source files. The Bootstrap CSS is now built into the OPAC CSS by loading the required Bootstrap 4.5.0 SCSS files in node_modules. OPAC SCSS now starts with Bootstrap customizations: /* Bootstrap variable customizations */ $headings-color: #727272; ... Followed by loading the necessary Bootstrap SCSS files: /* Bootstrap imports */ @import "../../../../../node_modules/bootstrap/scss/functions"; @import "../../../../../node_modules/bootstrap/scss/variables"; ... Followed by our CSS. The build process for generating compiled CSS now creates a file which bundles Bootstrap CSS and ours. Removed from the Koha source: Bootstrap CSS files, Bootstrap "glyphicons" images. The upgrade to Bootstrap 4 involved a lot of markup changes to conform with new Bootstrap classes, especially in classes related to the grid. Besides duplicating the grid we used before, this upgrade adds some new features made possible by Bootstrap 4.5's use of flexbox as a layout tool. This includes custom ordering of columns based on class names: https://getbootstrap.com/docs/4.5/layout/grid/#order-classes. Other areas where the most changes have been made: Navigation menus, breadcrumb menus, buttons, dropdowns. Bootstrap's JavaScript file is now "bootstrap.bundle.min.js" to reflect the fact that a required JavaScript asset is now distributed separately in Bootstrap 4. The "bundle" version includes Popper.js. Unrelated changes: Indentation corrections, removal of invalid "// Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- gulpfile.js | 18 +- installer/data/mysql/localization/de-DE/custom.sql | 6 +- installer/data/mysql/localization/nb-NO/custom.sql | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 8 + .../prog/en/includes/langmenu-staff-top.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/datatables.css | 28 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- .../opac-tmpl/bootstrap/css/right-to-left.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss | 753 ++- koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss | 15 - .../opac-tmpl/bootstrap/css/src/_responsive.scss | 238 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 1122 +--- .../opac-tmpl/bootstrap/css/src/right-to-left.scss | 569 -- koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss | 261 +- .../bootstrap/en/includes/account-table.inc | 329 +- .../opac-tmpl/bootstrap/en/includes/calendar.inc | 2 - .../bootstrap/en/includes/doc-head-close.inc | 26 +- .../bootstrap/en/includes/holds-table.inc | 4 +- .../bootstrap/en/includes/masthead-langmenu.inc | 66 +- .../bootstrap/en/includes/masthead-sci.inc | 53 + .../bootstrap/en/includes/masthead-sco.inc | 62 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 704 +- .../bootstrap/en/includes/opac-bottom.inc | 189 +- .../bootstrap/en/includes/opac-detail-sidebar.inc | 118 +- .../bootstrap/en/includes/opac-topissues.inc | 2 +- .../bootstrap/en/includes/overdrive-checkout.inc | 2 +- .../bootstrap/en/includes/overdrive-login.inc | 2 +- .../bootstrap/en/includes/page-numbers.inc | 28 +- .../en/includes/recordedbooks-checkout.inc | 2 +- .../bootstrap/en/includes/title-actions-menu.inc | 28 +- .../opac-tmpl/bootstrap/en/includes/usermenu.inc | 3 +- .../bootstrap/en/modules/errors/errorpage.tt | 32 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 151 +- .../opac-tmpl/bootstrap/en/modules/maintenance.tt | 8 +- .../bootstrap/en/modules/opac-ISBDdetail.tt | 25 +- .../bootstrap/en/modules/opac-MARCdetail.tt | 24 +- .../bootstrap/en/modules/opac-account-pay-error.tt | 32 +- .../opac-tmpl/bootstrap/en/modules/opac-account.tt | 32 +- .../bootstrap/en/modules/opac-addbybiblionumber.tt | 12 +- .../bootstrap/en/modules/opac-advsearch.tt | 647 +- .../bootstrap/en/modules/opac-alert-subscribe.tt | 14 +- .../bootstrap/en/modules/opac-auth-MARCdetail.tt | 38 +- .../bootstrap/en/modules/opac-auth-detail.tt | 62 +- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 130 +- .../bootstrap/en/modules/opac-authorities-home.tt | 28 +- .../en/modules/opac-authoritiessearchresultlist.tt | 56 +- .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 30 +- .../opac-tmpl/bootstrap/en/modules/opac-blocked.tt | 18 +- .../opac-tmpl/bootstrap/en/modules/opac-browse.tt | 68 +- .../opac-tmpl/bootstrap/en/modules/opac-browser.tt | 107 +- .../bootstrap/en/modules/opac-course-details.tt | 43 +- .../bootstrap/en/modules/opac-course-reserves.tt | 51 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1668 ++--- .../bootstrap/en/modules/opac-discharge.tt | 28 +- .../bootstrap/en/modules/opac-downloadcart.tt | 8 +- .../bootstrap/en/modules/opac-downloadshelf.tt | 90 +- .../en/modules/opac-full-serial-issues.tt | 43 +- .../bootstrap/en/modules/opac-illrequests.tt | 510 +- .../bootstrap/en/modules/opac-imageviewer.tt | 121 +- .../bootstrap/en/modules/opac-issue-note.tt | 32 +- .../opac-tmpl/bootstrap/en/modules/opac-library.tt | 130 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 74 +- .../modules/opac-memberentry-update-submitted.tt | 32 +- .../bootstrap/en/modules/opac-memberentry.tt | 1612 ++--- .../bootstrap/en/modules/opac-messaging.tt | 416 +- .../bootstrap/en/modules/opac-overdrive-search.tt | 284 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 58 +- .../bootstrap/en/modules/opac-password-recovery.tt | 252 +- .../bootstrap/en/modules/opac-patron-consent.tt | 78 +- .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 125 +- .../bootstrap/en/modules/opac-readingrecord.tt | 29 +- .../en/modules/opac-recordedbooks-search.tt | 236 +- .../en/modules/opac-registration-confirmation.tt | 147 +- .../en/modules/opac-registration-email-sent.tt | 38 +- .../en/modules/opac-registration-invalid.tt | 36 +- .../bootstrap/en/modules/opac-reportproblem.tt | 38 +- .../bootstrap/en/modules/opac-request-article.tt | 361 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 26 +- .../bootstrap/en/modules/opac-restrictedpage.tt | 28 +- .../bootstrap/en/modules/opac-results-grouped.tt | 200 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 850 +-- .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 14 +- .../bootstrap/en/modules/opac-routing-lists.tt | 34 +- .../bootstrap/en/modules/opac-search-history.tt | 57 +- .../bootstrap/en/modules/opac-sendbasketform.tt | 12 +- .../bootstrap/en/modules/opac-sendshelfform.tt | 14 +- .../bootstrap/en/modules/opac-serial-issues.tt | 44 +- .../bootstrap/en/modules/opac-shareshelf.tt | 180 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 911 +-- .../bootstrap/en/modules/opac-showreviews.tt | 40 +- .../bootstrap/en/modules/opac-suggestions.tt | 70 +- .../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 58 +- .../bootstrap/en/modules/opac-tags_subject.tt | 35 +- .../bootstrap/en/modules/opac-topissues.tt | 157 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 46 +- .../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 284 +- .../opac-tmpl/bootstrap/en/modules/sco/help.tt | 63 +- .../bootstrap/en/modules/sco/printslip.tt | 6 +- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 361 +- .../bootstrap/en/modules/svc/suggestion.tt | 12 +- koha-tmpl/opac-tmpl/bootstrap/js/global.js | 6 +- koha-tmpl/opac-tmpl/bootstrap/js/script.js | 1 - .../bootstrap/lib/bootstrap/css/bootstrap-rtl.css | 6301 ------------------ .../lib/bootstrap/css/bootstrap-rtl.min.css | 857 --- .../bootstrap/lib/bootstrap/css/bootstrap.css | 6307 ------------------ .../bootstrap/lib/bootstrap/css/bootstrap.min.css | 873 --- .../bootstrap/img/glyphicons-halflings-white.png | Bin 8777 -> 0 bytes .../lib/bootstrap/img/glyphicons-halflings.png | Bin 12799 -> 0 bytes .../bootstrap/lib/bootstrap/js/bootstrap.bundle.js | 7033 ++++++++++++++++++++ .../lib/bootstrap/js/bootstrap.bundle.min.js | 7 + .../bootstrap/lib/bootstrap/js/bootstrap.js | 2486 ------- .../bootstrap/lib/bootstrap/js/bootstrap.min.js | 6 - koha-tmpl/opac-tmpl/bootstrap/lib/respond.min.js | 2 - koha-tmpl/opac-tmpl/bootstrap/lib/respond.src.js | 342 - package.json | 4 +- yarn.lock | 540 +- 119 files changed, 15554 insertions(+), 25418 deletions(-) delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/right-to-left.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sci.inc delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap-rtl.min.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap.min.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/img/glyphicons-halflings-white.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/img/glyphicons-halflings.png create mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.bundle.js create mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.bundle.min.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.min.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/respond.min.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/respond.src.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 16:09:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 14:09:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-967-gf3c199ac14 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f3c199ac140a29fa10c16cbba7507a1c2e34dc34 (commit) via 1a1402d06638811c5f893dc8c238b5b814bac625 (commit) via 52deed335e08c3f8f52c834eead6ab462350cf54 (commit) via e85b200783c1c56b19c515669a149e6b9920393c (commit) via 15d83d44812307f0d37abcf040a357ffab3f27e6 (commit) via 5848da810e412a69932da6935285df4e91058b6f (commit) via e14b779f38f164585f4cce543b6df06b6903b31d (commit) via 84004d0b3ef3af12915897dfe764fb325e5fe75d (commit) via 1be25ee4397916dc929a6838c636caa541c3c1e1 (commit) via 5f7142a89098535674366052812c1ea07f81dd8e (commit) via 6ae7a6f421b6f313e466392722efdf67afe1b51b (commit) via b4d8180d822fc9b51250d4575ada99088e9a8506 (commit) via c95bb26327d11ecf8bf86dcd3996a94b2716da7c (commit) via a937895fdadc9a90c53d31975ca7082516e5cdb9 (commit) via 10d8f8ba93571f590fc424b927b94035dfa0b9d2 (commit) via 54941f8dc558911e4222f7325609839b7c6bae81 (commit) via 763cc4eb2e53f7a44a138d6162bfa4470a484bac (commit) via bdb64657f9c69387f264a333a7d040c9f1dba574 (commit) via 11da7051c2c967e7d9dd10f8511a4a452964341e (commit) via f99976028c51b21458b6aa5eff9fe33a0d1774c4 (commit) from 886d570e2686355b917bf3ca92c2dad029160352 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f3c199ac140a29fa10c16cbba7507a1c2e34dc34 Author: Jonathan Druart Date: Wed Sep 9 13:13:45 2020 +0000 Bug 23816: DBRev 20.06.00.037 Signed-off-by: Jonathan Druart commit 1a1402d06638811c5f893dc8c238b5b814bac625 Author: Katrin Fischer Date: Thu Aug 27 20:07:16 2020 +0200 Bug 23816: (QA follow-up) Use existing form validation to validate min password length The pattern check didn't work for me, but I figured we might want to use the same validation as for the other numeric fields on the form instead (upper age limit, etc.) Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 52deed335e08c3f8f52c834eead6ab462350cf54 Author: Agustin Moyano Date: Thu Aug 27 12:58:56 2020 -0300 Bug 23816: (follow-up) Fix many things This patch: * reverts changes on misc/admin/set_password.pl * makes category param mandatory for AuthUtils::is_valid_password and AuthUtils::generate_password * changes onboarding.pl to set category param in AuthUtils::is_valid_password * Completes t/db_dependent/AuthUtils.t and drops t/AuthUtils.t * Removes offending and replaces it by https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e85b200783c1c56b19c515669a149e6b9920393c Author: Jonathan Druart Date: Wed Aug 19 09:00:12 2020 +0200 Bug 23816: trivial code simplification Ease readability Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 15d83d44812307f0d37abcf040a357ffab3f27e6 Author: Jonathan Druart Date: Wed Aug 19 08:48:19 2020 +0200 Bug 23816: Set default value in tests We tell TestBuilder to generate the categories with NULL (and rely on the sysprefs) Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 5848da810e412a69932da6935285df4e91058b6f Author: Agustin Moyano Date: Wed Apr 15 17:13:02 2020 -0300 Bug 23816: Add minimum password length and require strong password overrides by category This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e14b779f38f164585f4cce543b6df06b6903b31d Author: Agustin Moyano Date: Wed Apr 15 17:13:16 2020 -0300 Bug 23816: Add tests Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 84004d0b3ef3af12915897dfe764fb325e5fe75d Author: Agustin Moyano Date: Thu Apr 16 17:59:17 2020 -0300 Bug 23816: (follow-up) Define boolean column in shcema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 1be25ee4397916dc929a6838c636caa541c3c1e1 Author: Agustin Moyano Date: Wed Apr 15 16:12:16 2020 -0300 Bug 23816: [DO NOT PUSH] Update category schema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 5f7142a89098535674366052812c1ea07f81dd8e Author: Agustin Moyano Date: Wed Apr 15 16:12:16 2020 -0300 Bug 23816: Update kohastructure and atomic update Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 6ae7a6f421b6f313e466392722efdf67afe1b51b Author: David Cook Date: Wed Aug 26 04:05:21 2020 +0000 Bug 26285: Follow E.164 pattern for OPAC too This patch uses the E.164 pattern for phone numbers for the OPAC (and not just the staff interface). To test: 0) Follow the same plan as the staff interface, but go to /cgi-bin/koha/opac-messaging.pl after logging into the OPAC Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit b4d8180d822fc9b51250d4575ada99088e9a8506 Author: David Cook Date: Mon Aug 24 06:42:27 2020 +0000 Bug 26285: Follow E.164 pattern for validating SMS numbers Currently, Koha is not correctly validating SMS numbers using E.164. This causes Australian phone numbers without a country code to fail validation. This patch uses the E.164 pattern of 1-3 digits for country code, prefixed by a + symbol, and followed by up to 12 digits for the remainder of the phone number. To test: 0. Don't apply patch yet 1. Set "SMSSendDriver" to "Anything" 2. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 3. Type in 0455555555 and note "Please enter a valid phone number." message in browser 6. Apply the patch 7. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 8. Type in 0455555555 and note no validation error 9. Type in +61455555555 and note no validation error 10. Type in 123456789012 and note no validation error 11. Type in 1234567890123 and note "Please enter a valid phone number." error 12. Type in +900123456789012 and note no validation error 13. Type in 900123456789012 and note "Please enter a valid phone number." error Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit c95bb26327d11ecf8bf86dcd3996a94b2716da7c Author: Marcel de Rooy Date: Fri Sep 4 09:33:13 2020 +0000 Bug 26007: (QA follow-up) Remove message on marc_subfields_structure Why? Since the combo has been disabled since a few releases. If you want to change this mapping, you should do it on Koha to MARC mappings. This change is no longer per framework, but over all frameworks. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit a937895fdadc9a90c53d31975ca7082516e5cdb9 Author: Marcel de Rooy Date: Fri Sep 4 09:09:00 2020 +0000 Bug 26007: (QA follow-up) Replace wrong link values from sql installer files Field 943$a has link value "130". This does not work; 130 is not a search index. It should be Title-uniform. Note: Only used on a search link in the intranet MARC detail page. In some cases "130" should be replaced by "Title-uniform", but sometimes 130 without quotes had to be replaced. Performed by two sed statements on git grep results. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 10d8f8ba93571f590fc424b927b94035dfa0b9d2 Author: Marcel de Rooy Date: Fri Sep 4 08:38:24 2020 +0000 Bug 26007: (QA follow-up) Add index name to the q parameter The link constructed in MARC-detail is not consistent. It adds an index name but does not show in the query in the search box. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 54941f8dc558911e4222f7325609839b7c6bae81 Author: Katrin Fischer Date: Sun Aug 30 22:31:32 2020 +0200 Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - ÃThe hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message Signed-off-by: David Nind Signed-off-by: Marcel de Rooy This commit message is not completely accurate. See the follow-ups. Signed-off-by: Jonathan Druart commit 763cc4eb2e53f7a44a138d6162bfa4470a484bac Author: Nick Clemens Date: Fri Sep 4 13:18:53 2020 +0000 Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items Additionally, only include renewable items in 'Renew all' To test: 1 - Check out some items to a patron, ideally: Some not renewable because set for auto renewal Some not renewable because of holds Some renewable 2 - Confirm 'Renew selected' and 'Renew all' show on the opac 3 - Click 'Renew all' 4 - You get errors about the non-renewable items? 5 - Check in all renewable items 6 - Confirm you still see renew buttons 7 - Apply patch 8 - Refresh and you shoudl not see renew buttons 9 - Check out a renewable item 10 - Click 'Renew all' 11 - Renewable item is renewed with no error 12 - Try again with 'Renew selected' 13 - Confirm it works as expected Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit bdb64657f9c69387f264a333a7d040c9f1dba574 Author: Owen Leonard Date: Sat Jul 11 13:25:11 2020 +0000 Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 11da7051c2c967e7d9dd10f8511a4a452964341e Author: Jonathan Druart Date: Wed Sep 9 14:46:54 2020 +0200 Bug 24663: Fix one missing occurrence pushed in the meanwhile Signed-off-by: Jonathan Druart commit f99976028c51b21458b6aa5eff9fe33a0d1774c4 Author: Jonathan Druart Date: Wed Sep 9 15:37:39 2020 +0200 Bug 20168: Fix selenium tests Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/AuthUtils.pm | 26 ++-- Koha/Exceptions/Password.pm | 4 + Koha/Patron.pm | 4 +- Koha/Patron/Category.pm | 36 ++++- Koha/Schema/Result/Category.pm | 22 ++- admin/categories.pl | 8 + cataloguing/addbiblio.pl | 1 + cataloguing/value_builder/upload.pl | 1 + .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../Obligatoire/marc21_framework_DEFAULT.sql | 2 +- .../Optionnel/marc21_simple_bib_frameworks.sql | 16 +- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- installer/data/mysql/kohastructure.sql | 2 + .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../optional/marc21_simple_bib_frameworks.sql | 16 +- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../optional/marc21_simple_bib_frameworks.sql | 16 +- .../marc21_bibliographic_DEFAULT_local.sql | 2 +- .../optional/marc21_bibliographic_AR_local.sql | 2 +- .../optional/marc21_bibliographic_BKS_local.sql | 2 +- .../optional/marc21_bibliographic_CF_local.sql | 2 +- .../optional/marc21_bibliographic_IR_local.sql | 2 +- .../optional/marc21_bibliographic_KT_local.sql | 2 +- .../optional/marc21_bibliographic_SER_local.sql | 2 +- .../optional/marc21_bibliographic_SR_local.sql | 2 +- .../optional/marc21_bibliographic_VR_local.sql | 2 +- .../marc21_bibliographic_DEFAULT_local.sql | 2 +- .../optional/marc21_bibliographic_AR_local.sql | 2 +- .../optional/marc21_bibliographic_BKS_local.sql | 2 +- .../optional/marc21_bibliographic_CF_local.sql | 2 +- .../optional/marc21_bibliographic_IR_local.sql | 2 +- .../optional/marc21_bibliographic_KT_local.sql | 2 +- .../optional/marc21_bibliographic_SER_local.sql | 2 +- .../optional/marc21_bibliographic_SR_local.sql | 2 +- .../optional/marc21_bibliographic_VR_local.sql | 2 +- installer/data/mysql/updatedatabase.pl | 12 ++ installer/onboarding.pl | 12 +- .../intranet-tmpl/prog/css/src/staff-global.scss | 9 ++ .../prog/en/includes/password_check.inc | 40 +++-- .../prog/en/modules/admin/categories.tt | 37 +++++ .../prog/en/modules/admin/koha2marclinks.tt | 1 + .../en/modules/admin/marc_subfields_structure.tt | 6 +- .../prog/en/modules/catalogue/MARCdetail.tt | 2 +- .../prog/en/modules/cataloguing/addbiblio.tt | 6 +- .../prog/en/modules/members/member-password.tt | 15 +- .../prog/en/modules/members/memberentrygen.tt | 7 +- .../prog/en/modules/onboarding/onboardingstep3.tt | 5 +- koha-tmpl/intranet-tmpl/prog/js/categories.js | 3 + koha-tmpl/intranet-tmpl/prog/js/members.js | 6 +- .../bootstrap/en/includes/password_check.inc | 44 ++++-- .../bootstrap/en/modules/opac-memberentry.tt | 35 ++++- .../bootstrap/en/modules/opac-messaging.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 9 +- .../bootstrap/en/modules/opac-password-recovery.tt | 6 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +- members/memberentry.pl | 6 +- opac/opac-memberentry.pl | 8 +- opac/opac-password-recovery.pl | 15 +- opac/opac-registration-verify.pl | 3 +- opac/opac-user.pl | 4 +- t/AuthUtils.t | 73 --------- t/db_dependent/AuthUtils.t | 164 +++++++++++++++++++++ t/db_dependent/Koha/Patron/Category.t | 38 ++++- t/db_dependent/selenium/authentication.t | 2 +- t/db_dependent/selenium/regressions.t | 8 +- t/lib/TestBuilder.pm | 2 + tools/batch_extend_due_dates.pl | 1 - 68 files changed, 558 insertions(+), 227 deletions(-) delete mode 100644 t/AuthUtils.t create mode 100644 t/db_dependent/AuthUtils.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 9 17:02:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Sep 2020 15:02:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-968-gde096ab200 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via de096ab20076b185e414dc6c0330f3370e171c49 (commit) from f3c199ac140a29fa10c16cbba7507a1c2e34dc34 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit de096ab20076b185e414dc6c0330f3370e171c49 Author: Jonathan Druart Date: Wed Sep 9 16:31:07 2020 +0200 Bug 26157: Correct two occurrences We don't want to hide the warnings for all tests Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Patron.t | 15 ++++++++------ t/db_dependent/Koha/Patron/Relationship.t | 33 ++++++++++++++++--------------- 2 files changed, 26 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:08:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:08:48 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-16-g760faa0a7a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 760faa0a7ab8cce64d754b93aebdb7cd6dc5d4a2 (commit) from edb729421f26d9709140e24da559929d2843169a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 760faa0a7ab8cce64d754b93aebdb7cd6dc5d4a2 Author: Owen Leonard Date: Fri Aug 14 14:18:00 2020 +0000 Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 8344ee7b4ced266ac7bd48254f4695175fd8f19b) Signed-off-by: Lucas Gass (cherry picked from commit f681964591ba1efde4c1c8c032c344b85c1d1815) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 1 - koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 14 ++++++-------- 2 files changed, 6 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:14:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:14:54 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-17-gb98755e4c9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b98755e4c9dafd53ac32ce23d8d6e3bb6a097625 (commit) from 760faa0a7ab8cce64d754b93aebdb7cd6dc5d4a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b98755e4c9dafd53ac32ce23d8d6e3bb6a097625 Author: David Cook Date: Fri Aug 14 01:49:40 2020 +0000 Bug 25778: Fix var scope in koha-plack for PERL5LIB and KOHA_HOME Currently, if a koha-plack is given multiple instances, it will create duplicate $KOHA_HOME/installer and $KOHA_HOME/installer/lib entries in PERL5LIB as these changes are done at the global rather than local level. This issue can only be seen in non-dev Koha, since dev Koha installs rewrite PERL5LIB. This patch localizes PERL5LIB to each instance. To test dev installs: 0. cp debian/scripts/koha-plack /usr/sbin/koha-plack 1. koha-plack --restart kohadev 2. Note that nothing breaks To test non-dev installs: 0. Don't replace /usr/sbin/koha-plack yet 1. Create multiple non-dev installs with plack enabled and running 2. Set up one of these non-dev installs so you can use the web UI (that is beyong the scope of this test plan) 3. koha-plack --restart test1 test2 test3 4. For test3, go to /cgi-bin/koha/about.pl 5. Note that there are duplicate /usr/share/koha/installer and /usr/share/koha/lib/installer entries in PERL5LIB 6. cp debian/scripts/koha-plack /usr/sbin/koha-plack 7. koha-plack --restart test1 test2 test3 8. For test3, go to /cgi-bin/koha/about.pl 9. Note that there are no duplicates entries in PERL5LIB Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 89721cb42b3928c745677c70fd9061273d1848dd) Signed-off-by: Lucas Gass (cherry picked from commit 670193ad16c7d5e6f288bc6288a0a033f8e02026) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-plack | 90 ++++++++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 41 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:17:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:17:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-18-g2a48a23c42 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 2a48a23c4209fea92fcdaae66268a1af9004a736 (commit) from b98755e4c9dafd53ac32ce23d8d6e3bb6a097625 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a48a23c4209fea92fcdaae66268a1af9004a736 Author: Jonathan Druart Date: Tue Aug 18 08:54:43 2020 +0000 Bug 26233: (bug 25553 follow-up) Make date columns sortable on the edit items table We were missing to pass the title-string to datatables. Test plan: Retest bug 26233, with appropriate dates Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Lucas Gass (cherry picked from commit df5c9d0725dec84a3d57f97a7728cbc7e1cac9fc) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:34:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:34:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-20-ga108d56f91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a108d56f9179ed1be299affb7535e4c198b4aeff (commit) via 6ccd2a55e138fe07aa74742c0df8b44cd7e26619 (commit) from 2a48a23c4209fea92fcdaae66268a1af9004a736 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a108d56f9179ed1be299affb7535e4c198b4aeff Author: Kyle M Hall Date: Thu Jul 30 09:35:38 2020 -0400 Bug 26076: (QA Follow up) Prevent error by using a fresh resultset Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c9887a87538b2113c48db8cd2751a4bcf2bd2168) Signed-off-by: Lucas Gass (cherry picked from commit 3a4f76b60d880fabb5bb6637839d1a83e673e1d6) Signed-off-by: Aleisha Amohia commit 6ccd2a55e138fe07aa74742c0df8b44cd7e26619 Author: Kyle M Hall Date: Tue Jul 28 12:49:35 2020 -0400 Bug 26076: Sum the amount due in the database query instead of a loop in Perl This appears to be a bug due to inaccuracies in floating point math. I've been unable to reproduce it on demand. Sometimes when using the "Write off selected" button, Koha will give the error that the payment is more than the amount owed, even though they are the same. The solution I've implemented is to move the summation from Perl code to the database query. This video demonstrates the issue and afterward, shows the error goes away after the patch is applied: https://monosnap.com/file/pG69HC7iI9mU9kkuoCtbkVzVTffKlE Test Plan: 1) Apply this patch 2) Restart all the things! 3) Verify that "Write off selected" functions as usual Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 64412969037ac9a9f81f05c69c3dd43bd3cab90b) Signed-off-by: Lucas Gass (cherry picked from commit 2e3b3a23fc6c3c1183853a6b5022598930b55b0d) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: members/paycollect.pl | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:37:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:37:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-22-g21f47a0dfd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 21f47a0dfd87ee386f190e77b13a28e2c7bcbd3c (commit) via a43ab3ca9b519828185cfc13a62e61d6d34624b8 (commit) from a108d56f9179ed1be299affb7535e4c198b4aeff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 21f47a0dfd87ee386f190e77b13a28e2c7bcbd3c Author: Kyle M Hall Date: Thu Aug 20 07:56:12 2020 -0400 Bug 25903: Add unit tests Signed-off-by: Jonathan Druart (cherry picked from commit 49f5200374e9a381ab7398730e42c0beefc0f2a4) Signed-off-by: Lucas Gass (cherry picked from commit 73c246238bc21aa48689a8027cd3ae01fb7f9232) Signed-off-by: Aleisha Amohia commit a43ab3ca9b519828185cfc13a62e61d6d34624b8 Author: Kyle M Hall Date: Tue Jun 30 14:37:21 2020 -0400 Bug 25903: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server The 'summary' field in the patron information request specifies if detail information should be send for holds, overdues, fines, etc. The field is 10 characters in length (0-9). However, the SIP2 spec only defines indexes 0 though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these undefined indexes. Apparently the 7th field is often used to request 'Fees', as opposed to 'Fines' in some ILS. Some software that integrate via SIP try both the 5th and 7th indexes to ensure they get all fines and fees. The problem is that Koha's SIP server crashes if any 'summary' index beyond 5 is flagged. We should simply ignore flags beyond 5 and act as if no flags were sent. Test Plan: 1) Enable SIP for your instance 2) Send a patron information request with a summary flag in any index beyond 5. i.e.: 6300120200617 124846 Y AOMIDAY|AA21030050054321 3) Note the SIP server just closes the connection without a response 4) Apply this patch 5) Restart the SIP server 6) Send the same request 7) Note you get back the patron information response! Signed-off-by: Kyle M Hall Signed-off-by: Jeff Gaines Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit fd4dbba7fb25bb73bcee152c84e704f9796664fd) Signed-off-by: Lucas Gass (cherry picked from commit b870bac520083283abb199a059ed767165ead677) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 8 +++---- t/db_dependent/SIP/Message.t | 57 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 60 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:39:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:39:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-23-g25fe729b41 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 25fe729b4112bd856bdea0d178ed55ab9fc191ee (commit) from 21f47a0dfd87ee386f190e77b13a28e2c7bcbd3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25fe729b4112bd856bdea0d178ed55ab9fc191ee Author: Lucas Gass Date: Wed Jul 15 22:28:07 2020 +0000 Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 6797f07bbdfb90c556f52bfe2f83cefdf91495f3) Signed-off-by: Lucas Gass (cherry picked from commit 59b67c3b37ed92926e9c75c0637c58af255ecec2) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 06:46:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 04:46:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-24-g38446b2311 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 38446b23116444cadbcfa04758b108ec81b5f768 (commit) from 25fe729b4112bd856bdea0d178ed55ab9fc191ee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 38446b23116444cadbcfa04758b108ec81b5f768 Author: Kyle M Hall Date: Wed Oct 10 11:13:37 2018 -0400 Bug 21539: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan Signed-off-by: Daniel Gaghan Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0c79b7d93b96434ddf91c6ddabb1570836736a15) Signed-off-by: Lucas Gass (cherry picked from commit 5f6b557599b83e0230a3dca5b527924e883d17a3) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:04:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:04:53 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-28-gec714bc6ce Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via ec714bc6cecc6c9fd3be2216288974d4f71591e2 (commit) via b292346a49dc59b0fdfeb05f66d9108d4a39c8c0 (commit) via ec02cab4ca91c3e76fa737e279784f613396f9db (commit) via 2c122a73443e2605e1d2bed5289170e33ddc0b1d (commit) from 38446b23116444cadbcfa04758b108ec81b5f768 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ec714bc6cecc6c9fd3be2216288974d4f71591e2 Author: Aleisha Amohia Date: Wed Sep 9 21:50:43 2020 +1200 Bug 25958: DBRev 19.11.09.001 Signed-off-by: Aleisha Amohia commit b292346a49dc59b0fdfeb05f66d9108d4a39c8c0 Author: Kyle M Hall Date: Mon Aug 24 13:13:17 2020 -0400 Bug 25958: (QA follow-up) Implement filter in database query instead of in loop Signed-off-by: Jonathan Druart (cherry picked from commit 66382458dc46356818473935e8d5546f13f05645) Signed-off-by: Lucas Gass (cherry picked from commit 9a544a86dbaa00dfce906f683556fea5d30805fb) Signed-off-by: Aleisha Amohia commit ec02cab4ca91c3e76fa737e279784f613396f9db Author: Katrin Fischer Date: Sat Aug 22 02:41:20 2020 +0000 Bug 25958: (QA follow-up) Add some punctuation to new DefaultLongOverdueSkipLostStatuses Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit d99651efd0a9a827b91f4575ab6f1d4344c7cfb0) Signed-off-by: Lucas Gass (cherry picked from commit bd56e23748f459f983bbca07bc7b019b70192dd5) Signed-off-by: Aleisha Amohia commit 2c122a73443e2605e1d2bed5289170e33ddc0b1d Author: Kyle M Hall Date: Tue Jul 28 07:55:18 2020 -0400 Bug 25958: Allow LongOverdue cron to exclude specified lost values When lost items are not marked as returned, they are still subject to the long overdue cron, so an item that has already been marked Lost may automatically roll to Long Overdue. In some cases, a library may not want that lost value to change. This becomes especially important with the introduction of Claims Returned, which uses a variety of lost. Test Plan: 1) Set up a long overdue item that would be moved to lost by longoverdue.pl 2) Run the cronjob with the new --skip-lost-value option 3) Note the item is not altered 4) Include that value in the new system preference DefaultLongOverdueSkipLostStatuses 5) Run the cronjob *without* the new option 6) Note the item is not altered 7) Run the cronjob again with the new command line option, but set it to a different value so the item will be affected 8) Note the item is altered as it would have been before this patch was applied Signed-off-by: Lisette Scheer Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 48edb2947163c1e9a70b11de40a71ebed747952f) Signed-off-by: Lucas Gass (cherry picked from commit 411619f209d071a8e2250a8979f3a336827dafb5) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 11 ++++ .../en/modules/admin/preferences/circulation.pref | 6 ++ misc/cronjobs/longoverdue.pl | 73 +++++++++++++++------- 5 files changed, 68 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:18:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:18:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-31-gc47111785c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c47111785c11b82d39de9e6bc9c2c24bbd5e5528 (commit) via fdf5fd0fc20c847ae059580c5fcb9cf3cee61056 (commit) via 4506ca63e39a682af6c57c9c844d36ec7dcef0f4 (commit) from ec714bc6cecc6c9fd3be2216288974d4f71591e2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c47111785c11b82d39de9e6bc9c2c24bbd5e5528 Author: Jonathan Druart Date: Mon Aug 31 15:25:05 2020 +0200 Bug 17661: Trivial simplification using += operator Signed-off-by: Jonathan Druart (cherry picked from commit c96fabb8c47320dba55372e4b955fb171310adec) Signed-off-by: Lucas Gass (cherry picked from commit 81865f77777273d96169bfe6afa760e11be0c7da) Signed-off-by: Aleisha Amohia commit fdf5fd0fc20c847ae059580c5fcb9cf3cee61056 Author: Nick Clemens Date: Thu Aug 27 16:27:09 2020 +0000 Bug 17661: (follow-up) Update regex to support Unicode characters Rather than limiting initials to [A-Z] we should test for a broad range of uppercase letters. The ES/Zebra changes are slightly different because of Perl vs Java regex conventions. POerl may support either, but I found 'Uppercase' to be a bit more explicit More info here: https://perldoc.perl.org/perlunicode.html TO test: Same plan as before but use Ж. as the ending initial Confirm the period is preserved and other punctuation removed Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 224ac84aeca3b8dba87366925d83b01e0f5c1110) Signed-off-by: Lucas Gass (cherry picked from commit f297fb819c38553899f2cde10b108ca8fa712dce) Signed-off-by: Aleisha Amohia commit 4506ca63e39a682af6c57c9c844d36ec7dcef0f4 Author: Nick Clemens Date: Thu Nov 2 16:52:53 2017 +0000 Bug 17661: Ending punctuation causes duplicate facets The current code for facets doesn't pull strip ending punctuation from facets This causes duplicate facets for terms that should be combined Sometimes series can have different punctuation depending on the field they are in Author initials punctuation should be preserved To test: 1 - Do search and pull up some records 2 - Edit some of the records to have authors like: Date, C.J. Date, C.j. Date, C.J . 3 - Edit the records to have some series statments like: 830 $aDate, C.J. ;$v5 830 $aDate, C.J. ; $v5 830 $aDate, C.J.; $v5 4 - Add some 490s to the record with first indicator 1 and series like: You wouldn't want to-- You wouldn't want to You wouldn't want to.. 5 - Search again and note you have 3 facets each for author and series 6 - Apply patch 7 - Repeat 8 - Now you get 2 facets for author, period not removed when following Upper case immediately, is otherwise 9 - Now you should have a single series facet 10 - Switch search engine to ES (index before applying patch) 11 - Note facets are separate again 12 - Reset mappings and reindex perl misc/search_tools/rebuild_elasticsearch -v -r 13 - Repeat search, facets combined as above Signed-off-by: Sarah Cornell Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e34f95a1f5eb0fce238ab442553bec5233263a9c) Signed-off-by: Lucas Gass (cherry picked from commit 0bfeb9990181445a14e4858b3d61954c1daf30ce) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 4 +++- admin/searchengine/elasticsearch/field_config.yaml | 1 + admin/searchengine/elasticsearch/index_config.yaml | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:22:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:22:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-32-ge489ca4429 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e489ca44290075d14b1c334750d7f2ac01a0c430 (commit) from c47111785c11b82d39de9e6bc9c2c24bbd5e5528 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e489ca44290075d14b1c334750d7f2ac01a0c430 Author: Jonathan Druart Date: Fri Aug 21 16:07:46 2020 +0200 Bug 26069: Pass correct URL to twitter We don't provide the url of the detail page so the twitter JS code retrieve the current location, with the search terms. Test plan: Do a search Click on a result Click on the twitter button and confirm that the link only contain biblionumber=x in the parameter Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 5fd8774c687c6aaf6716485ab9bd72a69a0e2f76) Signed-off-by: Lucas Gass (cherry picked from commit 48b10b3cf5f267b15d8f2008e90e0a88d379fe1d) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:25:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:25:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-33-g1dae354017 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1dae354017fb275398f24effdf22ba6e34a97881 (commit) from e489ca44290075d14b1c334750d7f2ac01a0c430 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1dae354017fb275398f24effdf22ba6e34a97881 Author: Jonathan Druart Date: Mon Aug 31 14:26:26 2020 +0200 Bug 26324: Fix spelling resizable vs resizeable in Dopop The correct spelling of the parameter is resizable https://developer.mozilla.org/fr/docs/Web/API/Window/open Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ce7f4d16d6acdc6a56d40e6ebd96d722f1c77387) Signed-off-by: Lucas Gass (cherry picked from commit 1475ea89e5daedf4a5fea29c09feb4ca5561aa39) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/global.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:26:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:26:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-35-g4eb56562a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4eb56562a5fda5abeeda67e1873c69d6b55e5fcc (commit) via 7a265915aebcede3b262eea95a341e9ad671bfea (commit) from 1dae354017fb275398f24effdf22ba6e34a97881 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4eb56562a5fda5abeeda67e1873c69d6b55e5fcc Author: Tomas Cohen Arazi Date: Thu Aug 27 15:10:08 2020 -0300 Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2a0ccf7af26236db9a3e40968cf8f43bc308f142) Signed-off-by: Lucas Gass (cherry picked from commit 81fd27153a26154da576eaaba7274968b36f1a3f) Signed-off-by: Aleisha Amohia commit 7a265915aebcede3b262eea95a341e9ad671bfea Author: Tomas Cohen Arazi Date: Thu Aug 27 14:57:45 2020 -0300 Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 7fc7427dd41ce10070a6a3d3070fb660850be511) Signed-off-by: Lucas Gass (cherry picked from commit def41d6231ae204022664d6d2b7de02fbb4c1414) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:28:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:28:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-36-gc9d3eb03ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c9d3eb03ba00df3aaca623a2ec2e332878460810 (commit) from 4eb56562a5fda5abeeda67e1873c69d6b55e5fcc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c9d3eb03ba00df3aaca623a2ec2e332878460810 Author: Jonathan Druart Date: Thu Aug 20 14:32:43 2020 +0200 Bug 24147: Don't assume search_related will return ordered values This test is failing randomly because it assume the order is always the same. But it's not. Note: Koha::Objects->search_related is never used , last use removed from commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada Bug 19599: Speed anonymise_issue_history up We should keep it however IMO Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e10dc503289e8d7e8c742af0111acb79d4d53111) Signed-off-by: Lucas Gass (cherry picked from commit e550f25a013f43bec8c2ee1694541dafd2a84a85) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Objects.t | 51 +++++++++++++++++++++++++++++++++---------- 1 file changed, 39 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 07:31:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 05:31:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-37-g47e4752e53 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 47e4752e5320067abd594c4bd1c4f7f8277aa65a (commit) from c9d3eb03ba00df3aaca623a2ec2e332878460810 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 47e4752e5320067abd594c4bd1c4f7f8277aa65a Author: Mason James Date: Thu Jun 18 13:26:20 2020 +1200 Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 to test... 1/ attempt to install koha 20.05 package on deb11, fail :'( 2/ apply patch and build new koha package 3/ attempt to install new koha package on deb11, succeed! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 14932ae7d3bf864f64bffc9b1b015a07e11c8e2e) Signed-off-by: Lucas Gass (cherry picked from commit a224b116882341fe4f0db09b456db1e20d8ad2e0) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 4 ++-- debian/control | 6 +++--- debian/control.in | 6 +++--- debian/templates/koha-conf-site.xml.in | 24 ++++++++++++------------ rewrite-config.PL | 2 +- 5 files changed, 21 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 10:37:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 08:37:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-970-g74dd083f8e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 74dd083f8e6b6cc8c962a42d91132c825dc2713c (commit) via 59b79b6045f0a085b63abf25247f09fe1b7063f3 (commit) from de096ab20076b185e414dc6c0330f3370e171c49 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 74dd083f8e6b6cc8c962a42d91132c825dc2713c Author: Jonathan Druart Date: Thu Sep 10 10:07:05 2020 +0200 Bug 23816: Fix selenium tests Signed-off-by: Jonathan Druart commit 59b79b6045f0a085b63abf25247f09fe1b7063f3 Author: Jonathan Druart Date: Thu Sep 10 09:57:51 2020 +0200 Bug 23816: Fix patron edition The patron edition was broken, we always got the pattern alert Password: Password must contain at least 8 characters, including UPPERCASE, lowercase and numbers Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc | 2 +- t/db_dependent/selenium/authentication.t | 4 ++-- t/db_dependent/selenium/regressions.t | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 10 11:12:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Sep 2020 09:12:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-971-ga259f6f53d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a259f6f53d28ad30b7c943a2a50e6e3217c0ccad (commit) from 74dd083f8e6b6cc8c962a42d91132c825dc2713c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a259f6f53d28ad30b7c943a2a50e6e3217c0ccad Author: Jonathan Druart Date: Thu Sep 10 10:41:32 2020 +0200 Bug 26250: Fix regressions.t when SearchEngine=ES Prior to this patch it failed with: t/db_dependent/selenium/regressions.t .. 5/5 Can't call method "leader" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 548. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/regressions.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 11 10:26:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 11 Sep 2020 08:26:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-978-g51fd1db1cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 51fd1db1cf8ee39d74be436d4bab83955a3c8a18 (commit) via 3fb268cd4bb6723daa72ce46c08cefc02e788acc (commit) via a1644cbf298d2178b57b7f4d5163f13e2d4c39ee (commit) via 0ebe27c982c4bbc2fd51112f381d2ca3be28e1e8 (commit) via f1f9c6dc746db9c58ce4eaca10ee9a4a7137c6f4 (commit) via ac304e93d89e1af2247b68aaad25b1b7e1fd2a51 (commit) via 67b30bc20163599332e587e0222ad0af6057a7f0 (commit) from a259f6f53d28ad30b7c943a2a50e6e3217c0ccad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 51fd1db1cf8ee39d74be436d4bab83955a3c8a18 Author: Jonathan Druart Date: Fri Sep 4 18:25:45 2020 +0200 Bug 26394: Update .mailmap The .mailmap file used to generate the stats is different from the one we have in our repo. It's much more complete and should be integrated into Koha. Test plan: Confirm that the different mappings are correct Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 3fb268cd4bb6723daa72ce46c08cefc02e788acc Author: Jonathan Druart Date: Thu Sep 3 11:58:14 2020 +0200 Bug 26365: Remove comparison with 0000-00-00 for datecancellationprinted Using MySQL 8: t/db_dependent/Koha/Acquisition/Order.t .. 10/11 No method count found for Koha::Acquisition::Orders DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement "SELECT COUNT( * ) FROM `aqorders` `me` WHERE ( ( ( `datecancellationprinted` IS NULL OR `datecancellationprinted` = ? ) AND `ordernumber` IN ( ?, ?, ? ) ) )" with ParamValues: 0='0000-00-00', 1=23, 2=24, 3=25] at /kohadevbox/koha/Koha/Objects.pm line 597 We must remove the comparison with 0000-00-00 Highlighted by bug 23166. I wanted to provide a DB rev but we (obviously) cannot: MySQL [koha_kohadev]> UPDATE aqorders SET datecancellationprinted=NULL WHERE datecancellationprinted="0000-00-00"; ERROR 1292 (22007): Incorrect date value: '0000-00-00' for column 'datecancellationprinted' at row 1 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit a1644cbf298d2178b57b7f4d5163f13e2d4c39ee Author: Marcel de Rooy Date: Fri Sep 11 07:11:22 2020 +0000 Bug 26384: (QA follow-up) Fix two exceptions AuthUtils.t went back to 644, but should be 755 Adding an exception in the xt test for fix-old-fsf-address.exclude Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 0ebe27c982c4bbc2fd51112f381d2ca3be28e1e8 Author: Jonathan Druart Date: Mon Sep 7 11:31:52 2020 +0200 Bug 26384: Add test to catch for missing or extra execution flags Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit f1f9c6dc746db9c58ce4eaca10ee9a4a7137c6f4 Author: Jonathan Druart Date: Mon Sep 7 11:33:08 2020 +0200 Bug 26384: Fix executable flags .pm must not have -x .t must have -x .pl must have -x Test plan: Apply only the first patch, run the tests and confirm that the failures make sense Apply this patch and confirm that the test now returns green Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ac304e93d89e1af2247b68aaad25b1b7e1fd2a51 Author: Jonathan Druart Date: Mon Sep 7 11:25:38 2020 +0200 Bug 26401: Remove xt/fix-old-fsf-address* On bug 24545 we fixed all the license statements and added a QA check + a test in our test suite. We do not longer need this script. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 67b30bc20163599332e587e0222ad0af6057a7f0 Author: Marcel de Rooy Date: Fri Sep 11 06:31:04 2020 +0000 Bug 26007: (QA follow-up) Fix English yml file git grep -l -E "link:\s*\"?[0-9]" | xargs sed -i -e "/link:/ s/130/\"Title-uniform\"/" Only one occurrence without quotes around 130. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: .mailmap | 308 ++++++++++++++++++++- C4/HoldsQueue.pm | 0 C4/SIP/SIPServer.pm | 0 C4/SIP/t/000_sc_config_auth.t | 0 C4/SIP/t/00sc_status.t | 0 C4/SIP/t/01patron_status.t | 0 C4/SIP/t/02patron_info.t | 0 C4/SIP/t/03checkout.t | 0 C4/SIP/t/04patron_status.t | 0 C4/SIP/t/05block_patron.t | 0 C4/SIP/t/06patron_enable.t | 0 C4/SIP/t/07hold.t | 0 C4/SIP/t/08checkin.t | 0 C4/SIP/t/09renew.t | 0 C4/SIP/t/10renew_all.t | 0 C4/SIP/t/11item_info.t | 0 Koha/Acquisition/Orders.pm | 5 +- cataloguing/value_builder/EXAMPLE.pl | 0 .../marc21/mandatory/marc21_framework_DEFAULT.yml | 2 +- kohaversion.pl | 0 misc/load_testing/benchmark_staff.pl | 0 misc/maintenance/compare_es_to_db.pl | 0 t/00-checkdatabase-version.t | 0 t/00-load.t | 0 t/00-merge-conflict-markers.t | 0 t/00-valid-xml.t | 0 t/Acquisition/CanUserManageBasket.t | 0 t/Auth.t | 0 t/Auth_with_shibboleth.t | 0 t/Biblio/TransformHtmlToXml.t | 0 t/Biblio2.t | 0 t/Budgets/CanUserModifyBudget.t | 0 t/Budgets/CanUserUseBudget.t | 0 t/Circulation/AgeRestrictionMarkers.t | 0 t/Circulation_barcodedecode.t | 0 t/EdiTransport.t | 0 t/Images.t | 0 t/ImportBatch.t | 0 t/Koha/Authority/ControlledIndicators.t | 0 t/Koha/Config.t | 0 t/Koha/Exceptions.t | 0 t/Koha/Middleware/RealIP.t | 0 t/Koha/Plugins/Tab.t | 0 t/Koha/RDF.t | 0 t/Koha/REST/Plugin/Pagination.t | 0 t/Koha/REST/Plugin/Query.t | 0 t/Koha/Script.t | 0 t/Koha/Script_cron.t | 0 t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 0 t/Koha/SearchEngine/Elasticsearch/Search.t | 0 t/Koha/SearchEngine/Zebra/QueryBuilder.t | 0 t/Koha/Util/MARC.t | 0 t/Koha/Util/Navigation.t | 0 t/Koha/Util/Normalize.t | 0 t/Koha/Util/OpenDocument.t | 0 t/Koha/Z3950responder.t | 0 t/Koha_Template_Plugin_Cache.t | 0 t/Koha_Template_Plugin_Koha.t | 0 t/Labels.t | 0 t/LangInstaller.t | 0 t/Languages.t | 0 t/Logger.t | 0 t/Makefile.t | 0 t/Members/cardnumber.t | 0 t/Number/Price.t | 0 t/OpenLibrarySearch.t | 0 t/Prices.t | 0 t/Scheduler.t | 0 t/Search/History.t | 0 t/Serials/GetNextSeq.t | 0 t/SimpleMARC.t | 0 t/SocialData.t | 0 t/Test/Dates.t | 0 t/Token.t | 0 t/db_dependent/01-test_dbic.t | 0 t/db_dependent/Accounts.t | 0 t/db_dependent/Acquisition/CancelReceipt.t | 0 t/db_dependent/Acquisition/GetBasketAsCSV.t | 0 .../Acquisition/GetBasketsInfosByBookseller.t | 0 .../Acquisition/GetOrdersByBiblionumber.t | 0 t/db_dependent/Acquisition/Invoices.t | 0 t/db_dependent/Acquisition/NewOrder.t | 0 t/db_dependent/Acquisition/OrderFromSubscription.t | 0 t/db_dependent/Acquisition/OrderUsers.t | 0 t/db_dependent/Acquisition/StandingOrders.t | 0 t/db_dependent/Acquisition/TransferOrder.t | 0 t/db_dependent/Acquisition/close_reopen_basket.t | 0 .../Acquisition/populate_order_with_prices.t | 0 t/db_dependent/Auth.t | 0 t/db_dependent/Auth/haspermission.t | 0 t/db_dependent/AuthUtils.t | 0 t/db_dependent/AuthorisedValues.t | 0 t/db_dependent/Authority/MergeRequests.t | 0 t/db_dependent/Authority/Subfields.t | 0 t/db_dependent/Authority/Tags.t | 0 t/db_dependent/BackgroundJob.t | 0 t/db_dependent/Barcodes_ValueBuilder.t | 0 t/db_dependent/Biblio/Isbd.t | 0 t/db_dependent/Biblio/ModBiblioMarc.t | 0 t/db_dependent/Biblio/TransformHtmlToMarc.t | 0 t/db_dependent/Biblio/TransformKohaToMarc.t | 0 t/db_dependent/Biblio/TransformMarcToKoha.t | 0 t/db_dependent/Cache.t | 0 t/db_dependent/Calendar.t | 0 t/db_dependent/Charset.t | 0 t/db_dependent/Circulation/Branch.t | 0 t/db_dependent/Circulation/CalcDateDue.t | 0 t/db_dependent/Circulation/CalcFine.t | 0 t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 0 t/db_dependent/Circulation/CheckValidBarcode.t | 0 t/db_dependent/Circulation/GetHardDueDate.t | 0 .../Circulation/GetPendingOnSiteCheckouts.t | 0 t/db_dependent/Circulation/GetTopIssues.t | 0 t/db_dependent/Circulation/IsItemIssued.t | 0 .../Circulation/IssuingRules/maxsuspensiondays.t | 0 t/db_dependent/Circulation/MarkIssueReturned.t | 0 .../Circulation/NoIssuesChargeGuarantees.t | 0 t/db_dependent/Circulation/OfflineOperation.t | 0 t/db_dependent/Circulation/ReturnClaims.t | 0 t/db_dependent/Circulation/Returns.t | 0 t/db_dependent/Circulation/StoreLastBorrower.t | 0 t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 0 t/db_dependent/Circulation/TooMany.t | 0 t/db_dependent/Circulation/dateexpiry.t | 0 t/db_dependent/Circulation/issue.t | 0 t/db_dependent/Circulation/transferbook.t | 0 t/db_dependent/Circulation/transfers.t | 0 t/db_dependent/Contract.t | 0 t/db_dependent/CourseReserves/CourseItems.t | 0 t/db_dependent/Creators/Lib.t | 0 t/db_dependent/Exporter/Record.t | 0 t/db_dependent/Filter_MARC_ViewPolicy.t | 0 t/db_dependent/Fines.t | 0 t/db_dependent/FrameworkPlugin.t | 0 t/db_dependent/Holds/HoldItemtypeLimit.t | 0 t/db_dependent/Holds/WaitingReserves.t | 0 t/db_dependent/ILSDI_Services.t | 0 t/db_dependent/Illcomments.t | 0 t/db_dependent/Illrequest/Availability.t | 0 t/db_dependent/Illrequest/Config.t | 0 t/db_dependent/Illrequest/Logger.t | 0 t/db_dependent/Illrequestattributes.t | 0 t/db_dependent/Illrequests.t | 0 t/db_dependent/ImportBatch.t | 0 t/db_dependent/ImportExportFramework.t | 0 t/db_dependent/Installer.t | 0 .../Items/AutomaticItemModificationByAge.t | 0 t/db_dependent/Items/GetHostItemsInfo.t | 0 t/db_dependent/Items/MoveItemFromBiblio.t | 0 t/db_dependent/Koha.t | 0 t/db_dependent/Koha/Account/DebitType.t | 0 t/db_dependent/Koha/Account/DebitTypes.t | 0 t/db_dependent/Koha/Account/Line.t | 0 t/db_dependent/Koha/Acquisition/Basket.t | 0 t/db_dependent/Koha/Acquisition/Baskets.t | 0 t/db_dependent/Koha/Acquisition/Booksellers.t | 0 t/db_dependent/Koha/Acquisition/Budgets.t | 0 t/db_dependent/Koha/Acquisition/Currencies.t | 0 t/db_dependent/Koha/Acquisition/Fund.t | 0 t/db_dependent/Koha/Acquisition/Funds.t | 0 t/db_dependent/Koha/Acquisition/Invoice.t | 0 .../Koha/Acquisition/Invoice/Adjustments.t | 0 t/db_dependent/Koha/Acquisition/Order.t | 0 t/db_dependent/Koha/ActionLogs.t | 0 t/db_dependent/Koha/Authorities.t | 0 t/db_dependent/Koha/Biblio.t | 0 t/db_dependent/Koha/Biblio/Metadata.t | 0 t/db_dependent/Koha/BiblioFrameworks.t | 0 t/db_dependent/Koha/BiblioUtils/Iterator.t | 0 t/db_dependent/Koha/Biblios.t | 0 t/db_dependent/Koha/Cash/Register.t | 0 t/db_dependent/Koha/Charges/Fees.t | 0 t/db_dependent/Koha/Charges/Sales.t | 0 t/db_dependent/Koha/Checkouts.t | 0 t/db_dependent/Koha/Checkouts/ReturnClaim.t | 0 t/db_dependent/Koha/CirculationRules.t | 0 t/db_dependent/Koha/Cities.t | 0 t/db_dependent/Koha/ClassSortRules.t | 0 t/db_dependent/Koha/ClassSources.t | 0 t/db_dependent/Koha/ClassSplitRules.t | 0 t/db_dependent/Koha/Club/Enrollment.t | 0 t/db_dependent/Koha/Club/Hold.t | 0 t/db_dependent/Koha/Config/SysPrefs.t | 0 t/db_dependent/Koha/CsvProfiles.t | 0 t/db_dependent/Koha/Database.t | 0 t/db_dependent/Koha/Desks.t | 0 t/db_dependent/Koha/Holds.t | 0 t/db_dependent/Koha/IssuingRules.t | 0 .../guess_article_requestable_itemtypes.t | 0 t/db_dependent/Koha/Item.t | 0 t/db_dependent/Koha/Item/Transfers.t | 0 t/db_dependent/Koha/Items.t | 0 t/db_dependent/Koha/KeyboardShortcuts.t | 0 t/db_dependent/Koha/Libraries.t | 0 t/db_dependent/Koha/Library/OverDriveInfos.t | 0 t/db_dependent/Koha/MarcSubfieldStructures.t | 0 t/db_dependent/Koha/News.t | 0 t/db_dependent/Koha/Notices.t | 0 t/db_dependent/Koha/Objects.t | 0 t/db_dependent/Koha/Old.t | 0 t/db_dependent/Koha/Patron.t | 0 t/db_dependent/Koha/Patron/Attribute/Types.t | 0 t/db_dependent/Koha/Patron/Attributes.t | 0 t/db_dependent/Koha/Patron/Categories.t | 0 t/db_dependent/Koha/Patron/Category.t | 0 t/db_dependent/Koha/Patron/Consents.t | 0 t/db_dependent/Koha/Patron/Images.t | 0 t/db_dependent/Koha/Patron/Messages.t | 0 t/db_dependent/Koha/Patron/Relationship.t | 0 t/db_dependent/Koha/Patrons.t | 0 t/db_dependent/Koha/Patrons/Import.t | 0 t/db_dependent/Koha/Plugins/Patron.t | 0 t/db_dependent/Koha/Plugins/z_reset.t | 0 t/db_dependent/Koha/Pseudonymization.t | 0 t/db_dependent/Koha/Quotes.t | 0 t/db_dependent/Koha/REST/Plugin/Objects.t | 0 t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 0 t/db_dependent/Koha/REST/V1.t | 0 t/db_dependent/Koha/Reports.t | 0 t/db_dependent/Koha/Reviews.t | 0 t/db_dependent/Koha/SMS_Providers.t | 0 t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 0 .../Koha/SearchEngine/Elasticsearch/ExportConfig.t | 0 .../Koha/SearchEngine/Elasticsearch/Indexer.t | 0 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 0 .../Koha/SearchEngine/Elasticsearch/Reset.t | 0 .../Koha/SearchEngine/Elasticsearch/Search.t | 0 t/db_dependent/Koha/SearchEngine/Search.t | 0 t/db_dependent/Koha/SearchField.t | 0 t/db_dependent/Koha/SharedContent.t | 0 t/db_dependent/Koha/Statistics.t | 0 t/db_dependent/Koha/Subscription.t | 0 t/db_dependent/Koha/Subscription/Numberpatterns.t | 0 t/db_dependent/Koha/Subscription/Routinglists.t | 0 t/db_dependent/Koha/Suggestion.t | 0 t/db_dependent/Koha/Suggestions.t | 0 t/db_dependent/Koha/Tags.t | 0 t/db_dependent/Koha/Tags/Approvals.t | 0 t/db_dependent/Koha/Tags/Indexes.t | 0 t/db_dependent/Koha/Template/Plugin/Asset.t | 0 .../Koha/Template/Plugin/TablesSettings.t | 0 t/db_dependent/Koha/XSLT/Base.t | 0 t/db_dependent/Koha/XSLT/Security.t | 0 .../Koha/Z3950Responder/GenericSession.t | 0 t/db_dependent/Koha/Z3950Responder/Session.t | 0 t/db_dependent/Koha/Z3950Responder/Session2.t | 0 t/db_dependent/Koha/Z3950Responder/ZebraSession.t | 0 t/db_dependent/Koha/Z3950Servers.t | 0 t/db_dependent/Koha_Database.t | 0 t/db_dependent/Koha_Elasticsearch.t | 0 t/db_dependent/Labels/t_Batch.t | 0 t/db_dependent/Labels/t_Label.t | 0 t/db_dependent/Labels/t_Layout.t | 0 t/db_dependent/Labels/t_Profile.t | 0 t/db_dependent/Labels/t_Template.t | 0 t/db_dependent/Letters.t | 0 t/db_dependent/Letters/GetLetterTemplates.t | 0 .../Letters/GetLettersAvailableForALibrary.t | 0 t/db_dependent/Letters/TemplateToolkit.t | 0 t/db_dependent/LibraryGroups.t | 0 t/db_dependent/Log.t | 0 t/db_dependent/MarcModificationTemplates.t | 0 t/db_dependent/Members/GetAllIssues.t | 0 t/db_dependent/Members/IssueSlip.t | 0 t/db_dependent/Members/Statistics.t | 0 t/db_dependent/NewsChannels.t | 0 t/db_dependent/OAI/AndSets.t | 0 t/db_dependent/OAI/Server.t | 0 t/db_dependent/OAI/Sets.t | 0 t/db_dependent/Overdues.t | 0 t/db_dependent/Patron/Borrower_Discharge.t | 0 t/db_dependent/Patron/Borrower_Files.t | 0 t/db_dependent/Patron/Borrower_PrevCheckout.t | 0 t/db_dependent/Patron/HouseboundProfiles.t | 0 t/db_dependent/Patron/HouseboundRoles.t | 0 t/db_dependent/Patron/HouseboundVisits.t | 0 t/db_dependent/Patron/Messages.t | 0 t/db_dependent/Record/marcrecord2csv.t | 0 t/db_dependent/Reports/Guided.t | 0 t/db_dependent/Reserves/AutoUnsuspendReserves.t | 0 t/db_dependent/Reserves/CancelExpiredReserves.t | 0 t/db_dependent/Reserves/ReserveSlip.t | 0 t/db_dependent/RotatingCollections.t | 0 t/db_dependent/Search.t | 0 t/db_dependent/Search/History.t | 0 t/db_dependent/Serials/Claims.t | 0 t/db_dependent/Serials/Frequency.t | 0 t/db_dependent/Serials/GetFictiveIssueNumber.t | 0 t/db_dependent/Serials/GetNextDate.t | 0 t/db_dependent/Serials/GetNextSeq.t | 0 t/db_dependent/Serials/Numberpattern.t | 0 t/db_dependent/Serials/ReNewSubscription.t | 0 t/db_dependent/Serials_2.t | 0 t/db_dependent/ShelfBrowser.t | 0 t/db_dependent/Stats.t | 0 t/db_dependent/StockRotationItems.t | 0 t/db_dependent/StockRotationRotas.t | 0 t/db_dependent/StockRotationStages.t | 0 t/db_dependent/SuggestionEngine_ExplodedTerms.t | 0 t/db_dependent/Suggestions.t | 0 t/db_dependent/TablesSettings.t | 0 t/db_dependent/Template/Plugin/AuthorisedValues.t | 0 t/db_dependent/Template/Plugin/Branches.t | 0 t/db_dependent/Template/Plugin/Categories.t | 0 t/db_dependent/Template/Plugin/KohaDates.t | 0 t/db_dependent/Template/Plugin/To.t | 0 t/db_dependent/TestBuilder.t | 0 t/db_dependent/Upload.t | 0 t/db_dependent/UsageStats.t | 0 t/db_dependent/Utils/Datatables_Members.t | 0 t/db_dependent/Utils/Datatables_Virtualshelves.t | 0 t/db_dependent/Virtualshelves.t | 0 t/db_dependent/XSLT.t | 0 t/db_dependent/api/v1/acquisitions_funds.t | 0 t/db_dependent/api/v1/acquisitions_orders.t | 0 t/db_dependent/api/v1/acquisitions_vendors.t | 0 t/db_dependent/api/v1/advanced_editor_macros.t | 0 t/db_dependent/api/v1/auth.t | 0 t/db_dependent/api/v1/auth_basic.t | 0 t/db_dependent/api/v1/biblios.t | 0 t/db_dependent/api/v1/checkouts.t | 0 t/db_dependent/api/v1/cities.t | 0 t/db_dependent/api/v1/clubs_holds.t | 0 t/db_dependent/api/v1/holds.t | 0 t/db_dependent/api/v1/illrequests.t | 0 t/db_dependent/api/v1/items.t | 0 t/db_dependent/api/v1/libraries.t | 0 t/db_dependent/api/v1/patrons.t | 0 t/db_dependent/api/v1/patrons_accounts.t | 0 t/db_dependent/api/v1/patrons_password.t | 0 t/db_dependent/api/v1/return_claims.t | 0 t/db_dependent/api/v1/stockrotationstage.t | 0 t/db_dependent/check_kohastructure.t | 0 t/db_dependent/cronjobs/advance_notices_digest.t | 0 t/db_dependent/db_structure.t | 0 t/db_dependent/rollingloans.t | 0 t/db_dependent/selenium/administration_tasks.t | 0 t/db_dependent/selenium/authentication.t | 0 t/db_dependent/selenium/basic_workflow.t | 0 t/db_dependent/selenium/patrons_search.t | 0 t/db_dependent/selenium/regressions.t | 0 t/db_dependent/selenium/update_child_to_adult.t | 0 t/db_dependent/www/auth_values_input_www.t | 0 t/db_dependent/www/batch.t | 0 t/db_dependent/www/history.t | 0 t/db_dependent/www/regressions.t | 0 t/db_dependent/www/search_utf8.t | 0 t/etc/schema.pl | 0 t/template_filters.t | 0 t/timezones.t | 0 xt/author/icondirectories.t | 0 xt/author/podcorrectness.t | 0 xt/author/translatable-templates.t | 0 xt/author/valid-templates.t | 0 xt/find-misplaced-executables | 52 ++-- xt/fix-old-fsf-address | 164 ----------- xt/fix-old-fsf-address.exclude | 6 - 357 files changed, 344 insertions(+), 193 deletions(-) mode change 100755 => 100644 C4/HoldsQueue.pm mode change 100755 => 100644 C4/SIP/SIPServer.pm mode change 100644 => 100755 C4/SIP/t/000_sc_config_auth.t mode change 100644 => 100755 C4/SIP/t/00sc_status.t mode change 100644 => 100755 C4/SIP/t/01patron_status.t mode change 100644 => 100755 C4/SIP/t/02patron_info.t mode change 100644 => 100755 C4/SIP/t/03checkout.t mode change 100644 => 100755 C4/SIP/t/04patron_status.t mode change 100644 => 100755 C4/SIP/t/05block_patron.t mode change 100644 => 100755 C4/SIP/t/06patron_enable.t mode change 100644 => 100755 C4/SIP/t/07hold.t mode change 100644 => 100755 C4/SIP/t/08checkin.t mode change 100644 => 100755 C4/SIP/t/09renew.t mode change 100644 => 100755 C4/SIP/t/10renew_all.t mode change 100644 => 100755 C4/SIP/t/11item_info.t mode change 100644 => 100755 cataloguing/value_builder/EXAMPLE.pl mode change 100644 => 100755 kohaversion.pl mode change 100644 => 100755 misc/load_testing/benchmark_staff.pl mode change 100644 => 100755 misc/maintenance/compare_es_to_db.pl mode change 100644 => 100755 t/00-checkdatabase-version.t mode change 100644 => 100755 t/00-load.t mode change 100644 => 100755 t/00-merge-conflict-markers.t mode change 100644 => 100755 t/00-valid-xml.t mode change 100644 => 100755 t/Acquisition/CanUserManageBasket.t mode change 100644 => 100755 t/Auth.t mode change 100644 => 100755 t/Auth_with_shibboleth.t mode change 100644 => 100755 t/Biblio/TransformHtmlToXml.t mode change 100644 => 100755 t/Biblio2.t mode change 100644 => 100755 t/Budgets/CanUserModifyBudget.t mode change 100644 => 100755 t/Budgets/CanUserUseBudget.t mode change 100644 => 100755 t/Circulation/AgeRestrictionMarkers.t mode change 100644 => 100755 t/Circulation_barcodedecode.t mode change 100644 => 100755 t/EdiTransport.t mode change 100644 => 100755 t/Images.t mode change 100644 => 100755 t/ImportBatch.t mode change 100644 => 100755 t/Koha/Authority/ControlledIndicators.t mode change 100644 => 100755 t/Koha/Config.t mode change 100644 => 100755 t/Koha/Exceptions.t mode change 100644 => 100755 t/Koha/Middleware/RealIP.t mode change 100644 => 100755 t/Koha/Plugins/Tab.t mode change 100644 => 100755 t/Koha/RDF.t mode change 100644 => 100755 t/Koha/REST/Plugin/Pagination.t mode change 100644 => 100755 t/Koha/REST/Plugin/Query.t mode change 100644 => 100755 t/Koha/Script.t mode change 100644 => 100755 t/Koha/Script_cron.t mode change 100644 => 100755 t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t mode change 100644 => 100755 t/Koha/SearchEngine/Elasticsearch/Search.t mode change 100644 => 100755 t/Koha/SearchEngine/Zebra/QueryBuilder.t mode change 100644 => 100755 t/Koha/Util/MARC.t mode change 100644 => 100755 t/Koha/Util/Navigation.t mode change 100644 => 100755 t/Koha/Util/Normalize.t mode change 100644 => 100755 t/Koha/Util/OpenDocument.t mode change 100644 => 100755 t/Koha/Z3950responder.t mode change 100644 => 100755 t/Koha_Template_Plugin_Cache.t mode change 100644 => 100755 t/Koha_Template_Plugin_Koha.t mode change 100644 => 100755 t/Labels.t mode change 100644 => 100755 t/LangInstaller.t mode change 100644 => 100755 t/Languages.t mode change 100644 => 100755 t/Logger.t mode change 100644 => 100755 t/Makefile.t mode change 100644 => 100755 t/Members/cardnumber.t mode change 100644 => 100755 t/Number/Price.t mode change 100644 => 100755 t/OpenLibrarySearch.t mode change 100644 => 100755 t/Prices.t mode change 100644 => 100755 t/Scheduler.t mode change 100644 => 100755 t/Search/History.t mode change 100644 => 100755 t/Serials/GetNextSeq.t mode change 100644 => 100755 t/SimpleMARC.t mode change 100644 => 100755 t/SocialData.t mode change 100644 => 100755 t/Test/Dates.t mode change 100644 => 100755 t/Token.t mode change 100644 => 100755 t/db_dependent/01-test_dbic.t mode change 100644 => 100755 t/db_dependent/Accounts.t mode change 100644 => 100755 t/db_dependent/Acquisition/CancelReceipt.t mode change 100644 => 100755 t/db_dependent/Acquisition/GetBasketAsCSV.t mode change 100644 => 100755 t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t mode change 100644 => 100755 t/db_dependent/Acquisition/GetOrdersByBiblionumber.t mode change 100644 => 100755 t/db_dependent/Acquisition/Invoices.t mode change 100644 => 100755 t/db_dependent/Acquisition/NewOrder.t mode change 100644 => 100755 t/db_dependent/Acquisition/OrderFromSubscription.t mode change 100644 => 100755 t/db_dependent/Acquisition/OrderUsers.t mode change 100644 => 100755 t/db_dependent/Acquisition/StandingOrders.t mode change 100644 => 100755 t/db_dependent/Acquisition/TransferOrder.t mode change 100644 => 100755 t/db_dependent/Acquisition/close_reopen_basket.t mode change 100644 => 100755 t/db_dependent/Acquisition/populate_order_with_prices.t mode change 100644 => 100755 t/db_dependent/Auth.t mode change 100644 => 100755 t/db_dependent/Auth/haspermission.t mode change 100644 => 100755 t/db_dependent/AuthUtils.t mode change 100644 => 100755 t/db_dependent/AuthorisedValues.t mode change 100644 => 100755 t/db_dependent/Authority/MergeRequests.t mode change 100644 => 100755 t/db_dependent/Authority/Subfields.t mode change 100644 => 100755 t/db_dependent/Authority/Tags.t mode change 100644 => 100755 t/db_dependent/BackgroundJob.t mode change 100644 => 100755 t/db_dependent/Barcodes_ValueBuilder.t mode change 100644 => 100755 t/db_dependent/Biblio/Isbd.t mode change 100644 => 100755 t/db_dependent/Biblio/ModBiblioMarc.t mode change 100644 => 100755 t/db_dependent/Biblio/TransformHtmlToMarc.t mode change 100644 => 100755 t/db_dependent/Biblio/TransformKohaToMarc.t mode change 100644 => 100755 t/db_dependent/Biblio/TransformMarcToKoha.t mode change 100644 => 100755 t/db_dependent/Cache.t mode change 100644 => 100755 t/db_dependent/Calendar.t mode change 100644 => 100755 t/db_dependent/Charset.t mode change 100644 => 100755 t/db_dependent/Circulation/Branch.t mode change 100644 => 100755 t/db_dependent/Circulation/CalcDateDue.t mode change 100644 => 100755 t/db_dependent/Circulation/CalcFine.t mode change 100644 => 100755 t/db_dependent/Circulation/CheckIfIssuedToPatron.t mode change 100644 => 100755 t/db_dependent/Circulation/CheckValidBarcode.t mode change 100644 => 100755 t/db_dependent/Circulation/GetHardDueDate.t mode change 100644 => 100755 t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t mode change 100644 => 100755 t/db_dependent/Circulation/GetTopIssues.t mode change 100644 => 100755 t/db_dependent/Circulation/IsItemIssued.t mode change 100644 => 100755 t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t mode change 100644 => 100755 t/db_dependent/Circulation/MarkIssueReturned.t mode change 100644 => 100755 t/db_dependent/Circulation/NoIssuesChargeGuarantees.t mode change 100644 => 100755 t/db_dependent/Circulation/OfflineOperation.t mode change 100644 => 100755 t/db_dependent/Circulation/ReturnClaims.t mode change 100644 => 100755 t/db_dependent/Circulation/Returns.t mode change 100644 => 100755 t/db_dependent/Circulation/StoreLastBorrower.t mode change 100644 => 100755 t/db_dependent/Circulation/SwitchOnSiteCheckouts.t mode change 100644 => 100755 t/db_dependent/Circulation/TooMany.t mode change 100644 => 100755 t/db_dependent/Circulation/dateexpiry.t mode change 100644 => 100755 t/db_dependent/Circulation/issue.t mode change 100644 => 100755 t/db_dependent/Circulation/transferbook.t mode change 100644 => 100755 t/db_dependent/Circulation/transfers.t mode change 100644 => 100755 t/db_dependent/Contract.t mode change 100644 => 100755 t/db_dependent/CourseReserves/CourseItems.t mode change 100644 => 100755 t/db_dependent/Creators/Lib.t mode change 100644 => 100755 t/db_dependent/Exporter/Record.t mode change 100644 => 100755 t/db_dependent/Filter_MARC_ViewPolicy.t mode change 100644 => 100755 t/db_dependent/Fines.t mode change 100644 => 100755 t/db_dependent/FrameworkPlugin.t mode change 100644 => 100755 t/db_dependent/Holds/HoldItemtypeLimit.t mode change 100644 => 100755 t/db_dependent/Holds/WaitingReserves.t mode change 100644 => 100755 t/db_dependent/ILSDI_Services.t mode change 100644 => 100755 t/db_dependent/Illcomments.t mode change 100644 => 100755 t/db_dependent/Illrequest/Availability.t mode change 100644 => 100755 t/db_dependent/Illrequest/Config.t mode change 100644 => 100755 t/db_dependent/Illrequest/Logger.t mode change 100644 => 100755 t/db_dependent/Illrequestattributes.t mode change 100644 => 100755 t/db_dependent/Illrequests.t mode change 100644 => 100755 t/db_dependent/ImportBatch.t mode change 100644 => 100755 t/db_dependent/ImportExportFramework.t mode change 100644 => 100755 t/db_dependent/Installer.t mode change 100644 => 100755 t/db_dependent/Items/AutomaticItemModificationByAge.t mode change 100644 => 100755 t/db_dependent/Items/GetHostItemsInfo.t mode change 100644 => 100755 t/db_dependent/Items/MoveItemFromBiblio.t mode change 100644 => 100755 t/db_dependent/Koha.t mode change 100644 => 100755 t/db_dependent/Koha/Account/DebitType.t mode change 100644 => 100755 t/db_dependent/Koha/Account/DebitTypes.t mode change 100644 => 100755 t/db_dependent/Koha/Account/Line.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Basket.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Baskets.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Booksellers.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Budgets.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Currencies.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Fund.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Funds.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Invoice.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t mode change 100644 => 100755 t/db_dependent/Koha/Acquisition/Order.t mode change 100644 => 100755 t/db_dependent/Koha/ActionLogs.t mode change 100644 => 100755 t/db_dependent/Koha/Authorities.t mode change 100644 => 100755 t/db_dependent/Koha/Biblio.t mode change 100644 => 100755 t/db_dependent/Koha/Biblio/Metadata.t mode change 100644 => 100755 t/db_dependent/Koha/BiblioFrameworks.t mode change 100644 => 100755 t/db_dependent/Koha/BiblioUtils/Iterator.t mode change 100644 => 100755 t/db_dependent/Koha/Biblios.t mode change 100644 => 100755 t/db_dependent/Koha/Cash/Register.t mode change 100644 => 100755 t/db_dependent/Koha/Charges/Fees.t mode change 100644 => 100755 t/db_dependent/Koha/Charges/Sales.t mode change 100644 => 100755 t/db_dependent/Koha/Checkouts.t mode change 100644 => 100755 t/db_dependent/Koha/Checkouts/ReturnClaim.t mode change 100644 => 100755 t/db_dependent/Koha/CirculationRules.t mode change 100644 => 100755 t/db_dependent/Koha/Cities.t mode change 100644 => 100755 t/db_dependent/Koha/ClassSortRules.t mode change 100644 => 100755 t/db_dependent/Koha/ClassSources.t mode change 100644 => 100755 t/db_dependent/Koha/ClassSplitRules.t mode change 100644 => 100755 t/db_dependent/Koha/Club/Enrollment.t mode change 100644 => 100755 t/db_dependent/Koha/Club/Hold.t mode change 100644 => 100755 t/db_dependent/Koha/Config/SysPrefs.t mode change 100644 => 100755 t/db_dependent/Koha/CsvProfiles.t mode change 100644 => 100755 t/db_dependent/Koha/Database.t mode change 100644 => 100755 t/db_dependent/Koha/Desks.t mode change 100644 => 100755 t/db_dependent/Koha/Holds.t mode change 100644 => 100755 t/db_dependent/Koha/IssuingRules.t mode change 100644 => 100755 t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t mode change 100644 => 100755 t/db_dependent/Koha/Item.t mode change 100644 => 100755 t/db_dependent/Koha/Item/Transfers.t mode change 100644 => 100755 t/db_dependent/Koha/Items.t mode change 100644 => 100755 t/db_dependent/Koha/KeyboardShortcuts.t mode change 100644 => 100755 t/db_dependent/Koha/Libraries.t mode change 100644 => 100755 t/db_dependent/Koha/Library/OverDriveInfos.t mode change 100644 => 100755 t/db_dependent/Koha/MarcSubfieldStructures.t mode change 100644 => 100755 t/db_dependent/Koha/News.t mode change 100644 => 100755 t/db_dependent/Koha/Notices.t mode change 100644 => 100755 t/db_dependent/Koha/Objects.t mode change 100644 => 100755 t/db_dependent/Koha/Old.t mode change 100644 => 100755 t/db_dependent/Koha/Patron.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Attribute/Types.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Attributes.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Categories.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Category.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Consents.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Images.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Messages.t mode change 100644 => 100755 t/db_dependent/Koha/Patron/Relationship.t mode change 100644 => 100755 t/db_dependent/Koha/Patrons.t mode change 100644 => 100755 t/db_dependent/Koha/Patrons/Import.t mode change 100644 => 100755 t/db_dependent/Koha/Plugins/Patron.t mode change 100644 => 100755 t/db_dependent/Koha/Plugins/z_reset.t mode change 100644 => 100755 t/db_dependent/Koha/Pseudonymization.t mode change 100644 => 100755 t/db_dependent/Koha/Quotes.t mode change 100644 => 100755 t/db_dependent/Koha/REST/Plugin/Objects.t mode change 100644 => 100755 t/db_dependent/Koha/REST/Plugin/PluginRoutes.t mode change 100644 => 100755 t/db_dependent/Koha/REST/V1.t mode change 100644 => 100755 t/db_dependent/Koha/Reports.t mode change 100644 => 100755 t/db_dependent/Koha/Reviews.t mode change 100644 => 100755 t/db_dependent/Koha/SMS_Providers.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Elasticsearch.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t mode change 100644 => 100755 t/db_dependent/Koha/SearchEngine/Search.t mode change 100644 => 100755 t/db_dependent/Koha/SearchField.t mode change 100644 => 100755 t/db_dependent/Koha/SharedContent.t mode change 100644 => 100755 t/db_dependent/Koha/Statistics.t mode change 100644 => 100755 t/db_dependent/Koha/Subscription.t mode change 100644 => 100755 t/db_dependent/Koha/Subscription/Numberpatterns.t mode change 100644 => 100755 t/db_dependent/Koha/Subscription/Routinglists.t mode change 100644 => 100755 t/db_dependent/Koha/Suggestion.t mode change 100644 => 100755 t/db_dependent/Koha/Suggestions.t mode change 100644 => 100755 t/db_dependent/Koha/Tags.t mode change 100644 => 100755 t/db_dependent/Koha/Tags/Approvals.t mode change 100644 => 100755 t/db_dependent/Koha/Tags/Indexes.t mode change 100644 => 100755 t/db_dependent/Koha/Template/Plugin/Asset.t mode change 100644 => 100755 t/db_dependent/Koha/Template/Plugin/TablesSettings.t mode change 100644 => 100755 t/db_dependent/Koha/XSLT/Base.t mode change 100644 => 100755 t/db_dependent/Koha/XSLT/Security.t mode change 100644 => 100755 t/db_dependent/Koha/Z3950Responder/GenericSession.t mode change 100644 => 100755 t/db_dependent/Koha/Z3950Responder/Session.t mode change 100644 => 100755 t/db_dependent/Koha/Z3950Responder/Session2.t mode change 100644 => 100755 t/db_dependent/Koha/Z3950Responder/ZebraSession.t mode change 100644 => 100755 t/db_dependent/Koha/Z3950Servers.t mode change 100644 => 100755 t/db_dependent/Koha_Database.t mode change 100644 => 100755 t/db_dependent/Koha_Elasticsearch.t mode change 100644 => 100755 t/db_dependent/Labels/t_Batch.t mode change 100644 => 100755 t/db_dependent/Labels/t_Label.t mode change 100644 => 100755 t/db_dependent/Labels/t_Layout.t mode change 100644 => 100755 t/db_dependent/Labels/t_Profile.t mode change 100644 => 100755 t/db_dependent/Labels/t_Template.t mode change 100644 => 100755 t/db_dependent/Letters.t mode change 100644 => 100755 t/db_dependent/Letters/GetLetterTemplates.t mode change 100644 => 100755 t/db_dependent/Letters/GetLettersAvailableForALibrary.t mode change 100644 => 100755 t/db_dependent/Letters/TemplateToolkit.t mode change 100644 => 100755 t/db_dependent/LibraryGroups.t mode change 100644 => 100755 t/db_dependent/Log.t mode change 100644 => 100755 t/db_dependent/MarcModificationTemplates.t mode change 100644 => 100755 t/db_dependent/Members/GetAllIssues.t mode change 100644 => 100755 t/db_dependent/Members/IssueSlip.t mode change 100644 => 100755 t/db_dependent/Members/Statistics.t mode change 100644 => 100755 t/db_dependent/NewsChannels.t mode change 100644 => 100755 t/db_dependent/OAI/AndSets.t mode change 100644 => 100755 t/db_dependent/OAI/Server.t mode change 100644 => 100755 t/db_dependent/OAI/Sets.t mode change 100644 => 100755 t/db_dependent/Overdues.t mode change 100644 => 100755 t/db_dependent/Patron/Borrower_Discharge.t mode change 100644 => 100755 t/db_dependent/Patron/Borrower_Files.t mode change 100644 => 100755 t/db_dependent/Patron/Borrower_PrevCheckout.t mode change 100644 => 100755 t/db_dependent/Patron/HouseboundProfiles.t mode change 100644 => 100755 t/db_dependent/Patron/HouseboundRoles.t mode change 100644 => 100755 t/db_dependent/Patron/HouseboundVisits.t mode change 100644 => 100755 t/db_dependent/Patron/Messages.t mode change 100644 => 100755 t/db_dependent/Record/marcrecord2csv.t mode change 100644 => 100755 t/db_dependent/Reports/Guided.t mode change 100644 => 100755 t/db_dependent/Reserves/AutoUnsuspendReserves.t mode change 100644 => 100755 t/db_dependent/Reserves/CancelExpiredReserves.t mode change 100644 => 100755 t/db_dependent/Reserves/ReserveSlip.t mode change 100644 => 100755 t/db_dependent/RotatingCollections.t mode change 100644 => 100755 t/db_dependent/Search.t mode change 100644 => 100755 t/db_dependent/Search/History.t mode change 100644 => 100755 t/db_dependent/Serials/Claims.t mode change 100644 => 100755 t/db_dependent/Serials/Frequency.t mode change 100644 => 100755 t/db_dependent/Serials/GetFictiveIssueNumber.t mode change 100644 => 100755 t/db_dependent/Serials/GetNextDate.t mode change 100644 => 100755 t/db_dependent/Serials/GetNextSeq.t mode change 100644 => 100755 t/db_dependent/Serials/Numberpattern.t mode change 100644 => 100755 t/db_dependent/Serials/ReNewSubscription.t mode change 100644 => 100755 t/db_dependent/Serials_2.t mode change 100644 => 100755 t/db_dependent/ShelfBrowser.t mode change 100644 => 100755 t/db_dependent/Stats.t mode change 100644 => 100755 t/db_dependent/StockRotationItems.t mode change 100644 => 100755 t/db_dependent/StockRotationRotas.t mode change 100644 => 100755 t/db_dependent/StockRotationStages.t mode change 100644 => 100755 t/db_dependent/SuggestionEngine_ExplodedTerms.t mode change 100644 => 100755 t/db_dependent/Suggestions.t mode change 100644 => 100755 t/db_dependent/TablesSettings.t mode change 100644 => 100755 t/db_dependent/Template/Plugin/AuthorisedValues.t mode change 100644 => 100755 t/db_dependent/Template/Plugin/Branches.t mode change 100644 => 100755 t/db_dependent/Template/Plugin/Categories.t mode change 100644 => 100755 t/db_dependent/Template/Plugin/KohaDates.t mode change 100644 => 100755 t/db_dependent/Template/Plugin/To.t mode change 100644 => 100755 t/db_dependent/TestBuilder.t mode change 100644 => 100755 t/db_dependent/Upload.t mode change 100644 => 100755 t/db_dependent/UsageStats.t mode change 100644 => 100755 t/db_dependent/Utils/Datatables_Members.t mode change 100644 => 100755 t/db_dependent/Utils/Datatables_Virtualshelves.t mode change 100644 => 100755 t/db_dependent/Virtualshelves.t mode change 100644 => 100755 t/db_dependent/XSLT.t mode change 100644 => 100755 t/db_dependent/api/v1/acquisitions_funds.t mode change 100644 => 100755 t/db_dependent/api/v1/acquisitions_orders.t mode change 100644 => 100755 t/db_dependent/api/v1/acquisitions_vendors.t mode change 100644 => 100755 t/db_dependent/api/v1/advanced_editor_macros.t mode change 100644 => 100755 t/db_dependent/api/v1/auth.t mode change 100644 => 100755 t/db_dependent/api/v1/auth_basic.t mode change 100644 => 100755 t/db_dependent/api/v1/biblios.t mode change 100644 => 100755 t/db_dependent/api/v1/checkouts.t mode change 100644 => 100755 t/db_dependent/api/v1/cities.t mode change 100644 => 100755 t/db_dependent/api/v1/clubs_holds.t mode change 100644 => 100755 t/db_dependent/api/v1/holds.t mode change 100644 => 100755 t/db_dependent/api/v1/illrequests.t mode change 100644 => 100755 t/db_dependent/api/v1/items.t mode change 100644 => 100755 t/db_dependent/api/v1/libraries.t mode change 100644 => 100755 t/db_dependent/api/v1/patrons.t mode change 100644 => 100755 t/db_dependent/api/v1/patrons_accounts.t mode change 100644 => 100755 t/db_dependent/api/v1/patrons_password.t mode change 100644 => 100755 t/db_dependent/api/v1/return_claims.t mode change 100644 => 100755 t/db_dependent/api/v1/stockrotationstage.t mode change 100644 => 100755 t/db_dependent/check_kohastructure.t mode change 100644 => 100755 t/db_dependent/cronjobs/advance_notices_digest.t mode change 100644 => 100755 t/db_dependent/db_structure.t mode change 100644 => 100755 t/db_dependent/rollingloans.t mode change 100644 => 100755 t/db_dependent/selenium/administration_tasks.t mode change 100644 => 100755 t/db_dependent/selenium/authentication.t mode change 100644 => 100755 t/db_dependent/selenium/basic_workflow.t mode change 100644 => 100755 t/db_dependent/selenium/patrons_search.t mode change 100644 => 100755 t/db_dependent/selenium/regressions.t mode change 100644 => 100755 t/db_dependent/selenium/update_child_to_adult.t mode change 100644 => 100755 t/db_dependent/www/auth_values_input_www.t mode change 100644 => 100755 t/db_dependent/www/batch.t mode change 100644 => 100755 t/db_dependent/www/history.t mode change 100644 => 100755 t/db_dependent/www/regressions.t mode change 100644 => 100755 t/db_dependent/www/search_utf8.t mode change 100644 => 100755 t/etc/schema.pl mode change 100644 => 100755 t/template_filters.t mode change 100644 => 100755 t/timezones.t mode change 100644 => 100755 xt/author/icondirectories.t mode change 100644 => 100755 xt/author/podcorrectness.t mode change 100644 => 100755 xt/author/translatable-templates.t mode change 100644 => 100755 xt/author/valid-templates.t delete mode 100755 xt/fix-old-fsf-address delete mode 100644 xt/fix-old-fsf-address.exclude hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 14 22:29:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 20:29:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-2-ga4f7eaf961 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a4f7eaf9616613060e7766a82b6c398bf73839d7 (commit) from 60f26dfaf5e2ee164bb1682a0aece62eed05e83c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4f7eaf9616613060e7766a82b6c398bf73839d7 Author: Nick Clemens Date: Thu May 21 13:41:23 2020 +0000 Bug 25566: Add option to ignore found holds and use it when checking high holds To test: 1 - Find or create a record with 10 items 2 - Set sysprefs: decreaseLoanHighHolds - enable decreaseLoanHighHoldsDuration - 2 decreaseLoanHighHoldsValue - 2 decreaseLoanHighHoldsControl - 'over the number of holdable items'/dynamic 3 - Set circ rules to allow 1 hold per record on the relevant record 4 - Place 3 holds on the record 5 - Check one item in and confirm hold to set to waiting 6 - Issue to the patron with the waiting hold 7 - Get a notice that loan period is decreased 8 - Don't confirm the checkout 9 - Apply patch 10 - Restart all the things 11 - Repeat checkout, no decrease this time! Signed-off-by: Christopher Brannon Signed-off-by: Martin Renvoize (cherry picked from commit 96a871035043c7ffd93c61e756ee1ff89e3da0f0) Signed-off-by: Lucas Gass (cherry picked from commit d59536e289692537289460a9225cc0c0bce80a57) Signed-off-by: Aleisha Amohia (cherry picked from commit fe86de90479a4f6a6a52277490a83cf8e133dbba) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- C4/Reserves.pm | 29 ++++++++++++++++++----------- t/db_dependent/DecreaseLoanHighHolds.t | 26 ++++++++++++++++++++++---- t/db_dependent/Reserves/MultiplePerRecord.t | 7 +++++-- 4 files changed, 46 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 14 23:32:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 21:32:11 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-71-g8e86f81b41 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8e86f81b4130ce7d6a1e5556b2cfb1a2f19559d6 (commit) from e550f25a013f43bec8c2ee1694541dafd2a84a85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e86f81b4130ce7d6a1e5556b2cfb1a2f19559d6 Author: Katrin Fischer Date: Sat May 23 15:19:37 2020 +0000 Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit c0adeab58feaa7fb0b5c97e55b8356bb916aa163) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../marc21/mandatory/marc21_framework_DEFAULT.sql | 24 +++++++++++----------- .../optional/marc21_simple_bib_frameworks.sql | 3 +++ 2 files changed, 15 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 14 23:41:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 21:41:01 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-73-g5fa47568d5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5fa47568d596443eaceb380d1694ad08cf6ce102 (commit) via 246f3dbaa1bbdf1a145cc5e8ac0555b1b75c0015 (commit) from 8e86f81b4130ce7d6a1e5556b2cfb1a2f19559d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5fa47568d596443eaceb380d1694ad08cf6ce102 Author: Nick Clemens Date: Thu Aug 27 15:03:17 2020 +0000 Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b87dc492fe4ea009ad3c72aca43add0515d6da1c) Signed-off-by: Lucas Gass commit 246f3dbaa1bbdf1a145cc5e8ac0555b1b75c0015 Author: Nick Clemens Date: Thu Aug 27 15:03:07 2020 +0000 Bug 26309: Unit tests Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2e421ed7a4e9bd3336b8e2b1eb9200c8c6342462) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 9 +++------ t/Koha/SearchEngine/Elasticsearch.t | 12 +++++++++++- 2 files changed, 14 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 14 23:45:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 21:45:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-74-gb10162f3a2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b10162f3a2086be33abd3df45e717d7c6e902388 (commit) from 5fa47568d596443eaceb380d1694ad08cf6ce102 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b10162f3a2086be33abd3df45e717d7c6e902388 Author: David Cook Date: Thu Sep 3 05:40:57 2020 +0000 Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b729886216560fdf50d88dc8214c0dbb58720b5c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Sep 14 23:56:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 21:56:03 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-75-g6e01433358 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6e014333589b80be7b0060da8aa3e4e55cfb07ca (commit) from b10162f3a2086be33abd3df45e717d7c6e902388 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6e014333589b80be7b0060da8aa3e4e55cfb07ca Author: David Cook Date: Tue Sep 1 15:19:14 2020 +1000 Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit c53dfb5562a12c1a8d8b9d3d0c28cb17d001edb5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: svc/letters/preview | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 svc/letters/preview hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:01:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:01:05 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-77-g7a8b7ba2f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7a8b7ba2f42c9709301b321f3c8e05bc0af78487 (commit) via 4755e8ef5cc73583f270fb1fe22415f29def46ea (commit) from 6e014333589b80be7b0060da8aa3e4e55cfb07ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7a8b7ba2f42c9709301b321f3c8e05bc0af78487 Author: Katrin Fischer Date: Tue Sep 1 21:22:31 2020 +0200 Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 8a37842e1af3fdc9e5e4eb2eb6ec9190ed31915e) Signed-off-by: Lucas Gass commit 4755e8ef5cc73583f270fb1fe22415f29def46ea Author: Nick Clemens Date: Tue Sep 1 12:32:56 2020 +0000 Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit fde7bf5495dedf681acb3193891de44eec4d2bfa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:07:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:07:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-79-g67aa733726 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 67aa733726b13f0437bb11b6cb5d18220caba757 (commit) via 00570ae9690a33a9be62dc51aaffa9d3774281f9 (commit) from 7a8b7ba2f42c9709301b321f3c8e05bc0af78487 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67aa733726b13f0437bb11b6cb5d18220caba757 Author: Joonas Kylmälä Date: Fri Aug 21 16:23:38 2020 +0300 Bug 26271: Add null to the list of accepted account_line data types The database schema for accountlines table allows the manager_id/user_id column to be NULL. If request to /api/v1/patrons//account returns such an accountline where it is NULL we get 500 error as response. Adding NULL to allowed data types fixes this issue. To test: 1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it doesn't fail Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 089b85758614260b70f43509ccdbc6285629a883) Signed-off-by: Lucas Gass commit 00570ae9690a33a9be62dc51aaffa9d3774281f9 Author: Joonas Kylmälä Date: Fri Aug 21 16:21:42 2020 +0300 Bug 26271: Add failing test to reveal issue with patrons API endpoint When manager_id is null/undef the API returns error code 500. To test: 1) Notice failure when running prove t/db_dependent/api/v1/patrons_accounts.t Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 898cd3b82ee84682bdfad1c177e2eb6ae0881428) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: api/v1/swagger/definitions/account_line.json | 5 +++- t/db_dependent/api/v1/patrons_accounts.t | 36 +++++++++++++++++++++++++++- 2 files changed, 39 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:11:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:11:35 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-80-gc08642687d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c08642687d35305cda2948272335530c8fc76b3c (commit) from 67aa733726b13f0437bb11b6cb5d18220caba757 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c08642687d35305cda2948272335530c8fc76b3c Author: Nick Clemens Date: Tue Aug 18 13:33:33 2020 +0000 Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 1733944b34499c145c2ae4c68c70efc87a5bec27) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:17:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:17:26 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-81-gce09889709 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ce0988970945b063b514e26d41abd2fbe108177e (commit) from c08642687d35305cda2948272335530c8fc76b3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ce0988970945b063b514e26d41abd2fbe108177e Author: Andrew Fuerste-Henry Date: Thu Aug 27 18:03:14 2020 +0000 Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 89cc457ca25e0fbaccba28b249ceedeef6573abf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: reports/cat_issues_top.pl | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:22:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:22:24 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-82-g09b5ffe121 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 09b5ffe12178894946176588e81d6a1136bce710 (commit) from ce0988970945b063b514e26d41abd2fbe108177e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 09b5ffe12178894946176588e81d6a1136bce710 Author: Martin Renvoize Date: Wed Jul 22 13:28:44 2020 +0100 Bug 26041: Enable keyboard navigation without 'ctrl' This patch enables keyboard navigation using the arrow keys without the need to hold the control key for the jQuery UI datepicker. Test plan 1/ Navigate to an item in the opac and attempt to place a hold 2/ On the resultant screen, use keyboard navigation to trigger the 'Show more options' dropdown. 3/ Focus on one of the date inputs using keyboard navigation. 4/ Use 'ctrl + arrow' keys to navigate the datepicker. 5/ Note that prior to the patch using 'bare' arrow keys does not trigger anything 6/ Apply the patch and confirm that the datepicker can now be naviated using the arrow keys without holding the ctrl key. 7/ Confirm that using the ctrl key combinations continue to work as expected too. 8/ Signoff Signed-off-by: Brandon J Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit be92f7e79ce093e251c2489408dce3077f782c0d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:48:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:48:09 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-84-g765b5ed5f5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 765b5ed5f50c248ce822942f2df2a6eef631f2f5 (commit) via 5906f9c3fbb697f3aef0f102f3c5dcc76fcd1b59 (commit) from 09b5ffe12178894946176588e81d6a1136bce710 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 765b5ed5f50c248ce822942f2df2a6eef631f2f5 Author: Lucas Gass Date: Mon Sep 14 22:11:31 2020 +0000 Bug 16314: Compile CSS Signed-off-by: Lucas Gass commit 5906f9c3fbb697f3aef0f102f3c5dcc76fcd1b59 Author: Owen Leonard Date: Sat Jul 11 13:25:11 2020 +0000 Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit bdb64657f9c69387f264a333a7d040c9f1dba574) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 1 + cataloguing/value_builder/upload.pl | 1 + koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 9 +++++++++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 6 +++++- 5 files changed, 17 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 00:52:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 22:52:47 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-85-g6347ad75c8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6347ad75c8f48f450ce82042f664bbb2d2bcd03c (commit) from 765b5ed5f50c248ce822942f2df2a6eef631f2f5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6347ad75c8f48f450ce82042f664bbb2d2bcd03c Author: Nick Clemens Date: Fri Sep 4 13:18:53 2020 +0000 Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items Additionally, only include renewable items in 'Renew all' To test: 1 - Check out some items to a patron, ideally: Some not renewable because set for auto renewal Some not renewable because of holds Some renewable 2 - Confirm 'Renew selected' and 'Renew all' show on the opac 3 - Click 'Renew all' 4 - You get errors about the non-renewable items? 5 - Check in all renewable items 6 - Confirm you still see renew buttons 7 - Apply patch 8 - Refresh and you shoudl not see renew buttons 9 - Check out a renewable item 10 - Click 'Renew all' 11 - Renewable item is renewed with no error 12 - Try again with 'Renew selected' 13 - Confirm it works as expected Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 763cc4eb2e53f7a44a138d6162bfa4470a484bac) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +++- opac/opac-user.pl | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 01:00:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 23:00:10 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-89-g27580c6be5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 27580c6be59b923e33c6164a9da724d493640c85 (commit) via 495d8802bce37ceb6e25d8e064f64fa0caed1f73 (commit) via 4d59e1d0da988386a737564f996add103605156b (commit) via f5aa165c6e3fb2dce71c3943149b0a2fef611ca5 (commit) from 6347ad75c8f48f450ce82042f664bbb2d2bcd03c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 27580c6be59b923e33c6164a9da724d493640c85 Author: Marcel de Rooy Date: Fri Sep 4 09:33:13 2020 +0000 Bug 26007: (QA follow-up) Remove message on marc_subfields_structure Why? Since the combo has been disabled since a few releases. If you want to change this mapping, you should do it on Koha to MARC mappings. This change is no longer per framework, but over all frameworks. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit c95bb26327d11ecf8bf86dcd3996a94b2716da7c) Signed-off-by: Lucas Gass commit 495d8802bce37ceb6e25d8e064f64fa0caed1f73 Author: Marcel de Rooy Date: Fri Sep 4 09:09:00 2020 +0000 Bug 26007: (QA follow-up) Replace wrong link values from sql installer files Field 943$a has link value "130". This does not work; 130 is not a search index. It should be Title-uniform. Note: Only used on a search link in the intranet MARC detail page. In some cases "130" should be replaced by "Title-uniform", but sometimes 130 without quotes had to be replaced. Performed by two sed statements on git grep results. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit a937895fdadc9a90c53d31975ca7082516e5cdb9) Signed-off-by: Lucas Gass commit 4d59e1d0da988386a737564f996add103605156b Author: Marcel de Rooy Date: Fri Sep 4 08:38:24 2020 +0000 Bug 26007: (QA follow-up) Add index name to the q parameter The link constructed in MARC-detail is not consistent. It adds an index name but does not show in the query in the search box. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 10d8f8ba93571f590fc424b927b94035dfa0b9d2) Signed-off-by: Lucas Gass commit f5aa165c6e3fb2dce71c3943149b0a2fef611ca5 Author: Katrin Fischer Date: Sun Aug 30 22:31:32 2020 +0200 Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - ÃThe hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message Signed-off-by: David Nind Signed-off-by: Marcel de Rooy This commit message is not completely accurate. See the follow-ups. Signed-off-by: Jonathan Druart (cherry picked from commit 54941f8dc558911e4222f7325609839b7c6bae81) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../marc21/Obligatoire/marc21_framework_DEFAULT.sql | 2 +- .../marc21/Optionnel/marc21_simple_bib_frameworks.sql | 16 ++++++++-------- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../marc21/optional/marc21_simple_bib_frameworks.sql | 16 ++++++++-------- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +- .../marc21/optional/marc21_simple_bib_frameworks.sql | 16 ++++++++-------- .../mandatory/marc21_bibliographic_DEFAULT_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_AR_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_BKS_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_CF_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_IR_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_KT_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_SER_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_SR_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_VR_local.sql | 2 +- .../mandatory/marc21_bibliographic_DEFAULT_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_AR_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_BKS_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_CF_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_IR_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_KT_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_SER_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_SR_local.sql | 2 +- .../marc21/optional/marc21_bibliographic_VR_local.sql | 2 +- .../prog/en/modules/admin/koha2marclinks.tt | 1 + .../prog/en/modules/admin/marc_subfields_structure.tt | 6 +++++- .../prog/en/modules/catalogue/MARCdetail.tt | 2 +- 29 files changed, 54 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 01:23:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 Sep 2020 23:23:23 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-90-g14fb30ce61 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 14fb30ce61a0b0dee027d21c49ea418429b5dcfd (commit) from 27580c6be59b923e33c6164a9da724d493640c85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14fb30ce61a0b0dee027d21c49ea418429b5dcfd Author: Katrin Fischer Date: Sun May 24 01:27:49 2020 +0200 Bug 25129: Update German (de-DE) web installer sample files for 20.05 This translates the new notices and CSV profie for late orders, makes some minor changes to the patron category descriptions and numbering patterin labelling. To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors Bonus: - If you can speak German, you can check the translations as well :) Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit ef3b7eedc0efc726329f2f608c0f676e93fd5566) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../data/mysql/de-DE/mandatory/sample_notices.sql | 110 ++++++++++----------- .../de-DE/mandatory/sample_numberpatterns.sql | 10 +- .../data/mysql/de-DE/optional/csv_profiles.sql | 2 +- .../mysql/de-DE/optional/patron_categories.sql | 10 +- 4 files changed, 66 insertions(+), 66 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 05:23:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 03:23:54 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-4-gf2cd875db6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via f2cd875db6d076042222e9b3626ef88040880aee (commit) via 05e64bd4c8c9f0482015c518877eea3608b0155c (commit) from a4f7eaf9616613060e7766a82b6c398bf73839d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f2cd875db6d076042222e9b3626ef88040880aee Author: Mason James Date: Sun May 24 15:16:20 2020 +1200 Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 This patch removes version-specific packages from the debian/control file, which fixes a bug where koha-common can only be installed on the debian version that the package was built on Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 5d9a51332d0cc932a4f23d757bbd6f5c38282df6) Signed-off-by: Lucas Gass (cherry picked from commit 0639627c3234aad5ee2d45b933c43d9a10ed20c2) Signed-off-by: Aleisha Amohia (cherry picked from commit 248978bc6249b6a290f2ca1f76edebdac9348996) commit 05e64bd4c8c9f0482015c518877eea3608b0155c Author: Jonathan Druart Date: Tue Jul 21 12:36:17 2020 +0200 Bug 26033: Use pic.infini.fr instead of framapic https://framapic.org/ is closing """ Framapic will be closing its doors on Tuesday, January 12, 2021. You will find a similar service on this page. Uploading images is now disabled, but you can still retrieve your images on the My images page. """ https://framablog.org/2019/09/26/lets-de-frama-tify-the-internet/ https://framablog.org/2020/03/03/10-bonnes-raisons-de-fermer-certains-services-framasoft-la-5e-est-un-peu-bizarre/ (French) We can still use another service. However we may think about hosting the service ourself! Test plan: Modify a selenium script to make it fail (for instance modify the path for a find_element call) Run it Confirm that the screenshot has been uploaded correctly and that the link works Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart (cherry picked from commit 8aa907379eb54d360746c3e15051327a1e6cc1fe) Signed-off-by: Lucas Gass (cherry picked from commit e51c7a73c00b28d2e5091b021ced867fc5942b3b) Signed-off-by: Aleisha Amohia (cherry picked from commit 63e28d62bdeb3e37f82974c83ce8057574d13e3a) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: debian/list-deps | 9 +++++---- t/lib/Selenium.pm | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 05:34:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 03:34:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-5-g75951db152 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 75951db15206e9209992ae9433042ac4cb918544 (commit) from f2cd875db6d076042222e9b3626ef88040880aee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75951db15206e9209992ae9433042ac4cb918544 Author: Mason James Date: Mon Jun 1 17:20:17 2020 +1200 Bug 17084: Automatic debian/control updates update for 20.05 release cycle Signed-off-by: Jonathan Druart (cherry picked from commit b5626ab3f886ee7dd35af6d4f591bb532a2a9d86) Signed-off-by: Aleisha Amohia (cherry picked from commit 3a86cc90816f27c9041fe051a870c0f14276a6fe) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: debian/control | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 13:58:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 11:58:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-38-g5419c0b85d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5419c0b85d46b1ac109183d76cba88566861bbbd (commit) from 47e4752e5320067abd594c4bd1c4f7f8277aa65a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5419c0b85d46b1ac109183d76cba88566861bbbd Author: Katrin Fischer Date: Sat May 23 15:19:37 2020 +0000 Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit c0adeab58feaa7fb0b5c97e55b8356bb916aa163) Signed-off-by: Lucas Gass (cherry picked from commit 8e86f81b4130ce7d6a1e5556b2cfb1a2f19559d6) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: .../de-DE/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:04:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:04:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-39-g8ca23ac289 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8ca23ac2891e0231baace1b6e27a1e86bef0b27b (commit) from 5419c0b85d46b1ac109183d76cba88566861bbbd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ca23ac2891e0231baace1b6e27a1e86bef0b27b Author: David Cook Date: Thu Sep 3 05:40:57 2020 +0000 Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b729886216560fdf50d88dc8214c0dbb58720b5c) Signed-off-by: Lucas Gass (cherry picked from commit b10162f3a2086be33abd3df45e717d7c6e902388) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:08:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:08:50 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-40-g4eddf06c5b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4eddf06c5bd29786bb4b84d73f01ebe40ff690b1 (commit) from 8ca23ac2891e0231baace1b6e27a1e86bef0b27b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4eddf06c5bd29786bb4b84d73f01ebe40ff690b1 Author: David Cook Date: Tue Sep 1 15:19:14 2020 +1000 Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit c53dfb5562a12c1a8d8b9d3d0c28cb17d001edb5) Signed-off-by: Lucas Gass (cherry picked from commit 6e014333589b80be7b0060da8aa3e4e55cfb07ca) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: svc/letters/preview | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 svc/letters/preview hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:11:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:11:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-42-ga16860fef1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a16860fef11e719db5aeef8e1cc839fb47b9d40e (commit) via e33d8f4dc7e94448829f78b985000d223b2be80c (commit) from 4eddf06c5bd29786bb4b84d73f01ebe40ff690b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a16860fef11e719db5aeef8e1cc839fb47b9d40e Author: Katrin Fischer Date: Tue Sep 1 21:22:31 2020 +0200 Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 8a37842e1af3fdc9e5e4eb2eb6ec9190ed31915e) Signed-off-by: Lucas Gass (cherry picked from commit 7a8b7ba2f42c9709301b321f3c8e05bc0af78487) Signed-off-by: Aleisha Amohia commit e33d8f4dc7e94448829f78b985000d223b2be80c Author: Nick Clemens Date: Tue Sep 1 12:32:56 2020 +0000 Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit fde7bf5495dedf681acb3193891de44eec4d2bfa) Signed-off-by: Lucas Gass (cherry picked from commit 4755e8ef5cc73583f270fb1fe22415f29def46ea) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:13:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:13:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-44-g8df5f362ac Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8df5f362acef1d04f8ecf03db1ef38fbb770b9aa (commit) via f28cfa768253d1a15ba9bbba9f19f5b5e51d41ad (commit) from a16860fef11e719db5aeef8e1cc839fb47b9d40e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8df5f362acef1d04f8ecf03db1ef38fbb770b9aa Author: Joonas Kylmälä Date: Fri Aug 21 16:23:38 2020 +0300 Bug 26271: Add null to the list of accepted account_line data types The database schema for accountlines table allows the manager_id/user_id column to be NULL. If request to /api/v1/patrons//account returns such an accountline where it is NULL we get 500 error as response. Adding NULL to allowed data types fixes this issue. To test: 1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it doesn't fail Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 089b85758614260b70f43509ccdbc6285629a883) Signed-off-by: Lucas Gass (cherry picked from commit 67aa733726b13f0437bb11b6cb5d18220caba757) Signed-off-by: Aleisha Amohia commit f28cfa768253d1a15ba9bbba9f19f5b5e51d41ad Author: Joonas Kylmälä Date: Fri Aug 21 16:21:42 2020 +0300 Bug 26271: Add failing test to reveal issue with patrons API endpoint When manager_id is null/undef the API returns error code 500. To test: 1) Notice failure when running prove t/db_dependent/api/v1/patrons_accounts.t Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 898cd3b82ee84682bdfad1c177e2eb6ae0881428) Signed-off-by: Lucas Gass (cherry picked from commit 00570ae9690a33a9be62dc51aaffa9d3774281f9) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: api/v1/swagger/definitions/account_line.json | 5 +++- t/db_dependent/api/v1/patrons_accounts.t | 36 +++++++++++++++++++++++++++- 2 files changed, 39 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:16:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:16:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-45-g8c20104bf3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8c20104bf3d8fb9df2dc03f140ec74a407149dc9 (commit) from 8df5f362acef1d04f8ecf03db1ef38fbb770b9aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c20104bf3d8fb9df2dc03f140ec74a407149dc9 Author: Nick Clemens Date: Tue Aug 18 13:33:33 2020 +0000 Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 1733944b34499c145c2ae4c68c70efc87a5bec27) Signed-off-by: Lucas Gass (cherry picked from commit c08642687d35305cda2948272335530c8fc76b3c) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:19:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:19:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-46-ga0c6e9ac84 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a0c6e9ac842bca09d0f8612a31e5dd376b7dd712 (commit) from 8c20104bf3d8fb9df2dc03f140ec74a407149dc9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a0c6e9ac842bca09d0f8612a31e5dd376b7dd712 Author: Andrew Fuerste-Henry Date: Thu Aug 27 18:03:14 2020 +0000 Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 89cc457ca25e0fbaccba28b249ceedeef6573abf) Signed-off-by: Lucas Gass (cherry picked from commit ce0988970945b063b514e26d41abd2fbe108177e) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: reports/cat_issues_top.pl | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:20:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:20:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-47-g42a99cf83d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 42a99cf83d0e5add52d03205e5d16948a34b4379 (commit) from a0c6e9ac842bca09d0f8612a31e5dd376b7dd712 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42a99cf83d0e5add52d03205e5d16948a34b4379 Author: Martin Renvoize Date: Wed Jul 22 13:28:44 2020 +0100 Bug 26041: Enable keyboard navigation without 'ctrl' This patch enables keyboard navigation using the arrow keys without the need to hold the control key for the jQuery UI datepicker. Test plan 1/ Navigate to an item in the opac and attempt to place a hold 2/ On the resultant screen, use keyboard navigation to trigger the 'Show more options' dropdown. 3/ Focus on one of the date inputs using keyboard navigation. 4/ Use 'ctrl + arrow' keys to navigate the datepicker. 5/ Note that prior to the patch using 'bare' arrow keys does not trigger anything 6/ Apply the patch and confirm that the datepicker can now be naviated using the arrow keys without holding the ctrl key. 7/ Confirm that using the ctrl key combinations continue to work as expected too. 8/ Signoff Signed-off-by: Brandon J Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit be92f7e79ce093e251c2489408dce3077f782c0d) Signed-off-by: Lucas Gass (cherry picked from commit 09b5ffe12178894946176588e81d6a1136bce710) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:24:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:24:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-48-ga5e1b47998 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a5e1b479989e802cef2f0c70395617625e4ccf4c (commit) from 42a99cf83d0e5add52d03205e5d16948a34b4379 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5e1b479989e802cef2f0c70395617625e4ccf4c Author: Nick Clemens Date: Fri Sep 4 13:18:53 2020 +0000 Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items Additionally, only include renewable items in 'Renew all' To test: 1 - Check out some items to a patron, ideally: Some not renewable because set for auto renewal Some not renewable because of holds Some renewable 2 - Confirm 'Renew selected' and 'Renew all' show on the opac 3 - Click 'Renew all' 4 - You get errors about the non-renewable items? 5 - Check in all renewable items 6 - Confirm you still see renew buttons 7 - Apply patch 8 - Refresh and you shoudl not see renew buttons 9 - Check out a renewable item 10 - Click 'Renew all' 11 - Renewable item is renewed with no error 12 - Try again with 'Renew selected' 13 - Confirm it works as expected Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 763cc4eb2e53f7a44a138d6162bfa4470a484bac) Signed-off-by: Lucas Gass (cherry picked from commit 6347ad75c8f48f450ce82042f664bbb2d2bcd03c) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +++- opac/opac-user.pl | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 15 14:28:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Sep 2020 12:28:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-49-g1e487927fc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1e487927fc03a9f555005e35a0f0d5ad71558c44 (commit) from a5e1b479989e802cef2f0c70395617625e4ccf4c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e487927fc03a9f555005e35a0f0d5ad71558c44 Author: Jonathan Druart Date: Thu Aug 20 10:10:14 2020 +0200 Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml It was there already but not at the same place! Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a4998b7d5758b0bee682fa7485d66390a3657a20) Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass (cherry picked from commit 8305f582aafe348f5f2697fe5432e162989296b5) (cherry picked from commit 53c99fcb46b5486ff244cc2b07ba5fad28a3940d) Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: etc/koha-conf.xml | 4 ---- 1 file changed, 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 18 12:21:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 18 Sep 2020 10:21:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-1019-g3d06cbb55a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3d06cbb55aedc8296b82169a649c7c5dab831101 (commit) via e7d1ffbad3d517dcf509eec107a54510cca45b64 (commit) via b255ca7c6eec7be3027e6ade00d8477102062281 (commit) via 01b65975988e9ec1830499460b078ed1f108656f (commit) via 5cfbe318d84dbaf1af8699f3e499f2c3e312a7af (commit) via 0bfe336c7b0a8993411bd45b9e7c66228730f86d (commit) via 7ee2495f321198548b3ffbf983aa1d13f6c6c2cc (commit) via 8ede5cd3f93cb96e09f460e1ba965032e804077e (commit) via 642c29dc230239d4ae1eb718f423c77072aa1e81 (commit) via 4f3cb59a97df5fc954e9e807896e14af960237a9 (commit) via 5ece5d7c7f739cbf2d4b81be767ff89a8c1204f5 (commit) via 22f14a7b6d45f3bf5ad57bd52203d4cdef724ce7 (commit) via 0310e973a4c28a7e02baad03799eb40869ce4506 (commit) via f90afe5c22445fb47430f629491d09762beeb3f8 (commit) via 76cff7e528a673369a0ee1b88207a2dbe4fbf8ad (commit) via c53909567a31e2eae337ee029d1c9d7348f3874a (commit) via 55e18646db855a8cf14b1f7f9adae2729525a2ce (commit) via ad1aab0e4242f4ea774951703796892fb858e6df (commit) via 342b51629d29db5e9309dc599c67b413e19ebbb8 (commit) via 4cae9b49f3036c8500db702d031c8475f5fb673b (commit) via 19c5db66377fc6e30a56f365874387e682e6c4c7 (commit) via 22abdd8af669dde60211f38f6c27a73367afe910 (commit) via d1c8d7eccee6e75473bf7c780617d683f64e5229 (commit) via 3b273de5777ac7dd5bebac629dc8c88e6bdc962a (commit) via a02bd4f71c25207b38908887bae50bdf1c450a3b (commit) via 9db369fb58c1f2795f748e972397f1ecb882ce92 (commit) via 7d78cae2841ee4f60325cb7f31cecce27cab01e4 (commit) via 1bc7e5a645381ffc30f320624a705869a202c029 (commit) via 24556e73d279dd5f09e96bc674fcc61fd3cc8fbc (commit) via e5a959486f1ba8014b2020623cc304711bb856b7 (commit) via 2baad1a39d72f4cce4f4242753e6c041df410681 (commit) via 38be70b55d0c01d0d9b54af0ef386d3de90161d7 (commit) via 692b0958414474b48ef7242b65e697913dc99deb (commit) via f1c2974d7b3a20d03d7be4df45dde8e8c2d86ff0 (commit) via 40c5d06a502071f6e9ca3828d37c820855f0c039 (commit) via 8e397330f687bd0e9e39387e32a8a8acbbb3b31a (commit) via 89716a78e9a7ed4c80dddba916d52737c7f2b468 (commit) via 4b3657b3d6762d148b57324c7211ede743c15c5b (commit) via 99a640fd75118475f5443093a3b815e3ce148b8f (commit) via 15174e7bd3f03555ff0120385443157f3da39fe2 (commit) via 4c8b0b9eb65bbdc7ed67c815c2750949de7409cb (commit) from 51fd1db1cf8ee39d74be436d4bab83955a3c8a18 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d06cbb55aedc8296b82169a649c7c5dab831101 Author: Jonathan Druart Date: Fri Sep 18 11:38:57 2020 +0200 Bug 19889: (follow-up) update DB adjustments Fix fields order Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit e7d1ffbad3d517dcf509eec107a54510cca45b64 Author: Jonathan Druart Date: Fri Sep 18 09:46:10 2020 +0000 Bug 18958: DBRev 20.06.00.039 Signed-off-by: Jonathan Druart commit b255ca7c6eec7be3027e6ade00d8477102062281 Author: Nick Clemens Date: Tue Aug 25 10:35:02 2020 +0000 Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types MapItemsToHoldRequests has three sections: Local holds, item level holds, bib level holds Only one of them was setting the reserve_id. This patch makes al three set it and adds tests To test: 1 - Repeat test plan on bug 2 - sudo koha-mysql kohadev SELECT * FROM hold_fill_targets 3 - Ensure reserve_id is set at appropriate times 4 - prove -v t/db_dependent/HoldsQueue.t Signed-off-by: Marcel de Rooy Bug 18958: (QA follow-up) Fix number of tests In HoldsQueue.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 01b65975988e9ec1830499460b078ed1f108656f Author: Nick Clemens Date: Tue Aug 25 09:55:42 2020 +0000 Bug 18958: DBIC schema changes Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 5cfbe318d84dbaf1af8699f3e499f2c3e312a7af Author: Katrin Fischer Date: Sat Aug 22 03:12:36 2020 +0000 Bug 18958: (QA follow-up) Add missing comma to kohastructure.sql Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 0bfe336c7b0a8993411bd45b9e7c66228730f86d Author: Nick Clemens Date: Fri Aug 14 11:06:40 2020 +0000 Bug 18958: Make hold_fill_targets specific to reserves After looking at Marcel's comments, the problem is in our matching to hold_fill_targets - rather than adjusting to find filled/waiting holds we could ensure that hold_fill_targets only refers to the specific hold it is intended to This patch is clearer, if slightly less performant than last (we now return all the reserves and have to find the 'highest') Test Plan: 1 - Create and use a patron that can place multiple record level holds per record 2 - Create a record with X items, each at a different library 3 - Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4 - perl misc/cronjobs/holds/build_holdsqueue.pl 5 - Check in LibraryA's copy as LibraryA and confirm the hold 6 - Revisit request.pl for the record, notice the next hold in line is now item-specific 7 - Checkout the item to the patron, notice the remaining hold is marked waiting 8 - Attempt to place another hold for your patron, notice that it requires an item-specific hold 8 - Apply this patch 9 - Repeat steps 1-5 10 - Revisit request.pl for the record, notice the next hold in line has *not* become item-specific 11 - Checkout the item to the patron, ensure the first hold is filled and the second remains record level 12 - Repeat whole test plan without building holds queue to confirm holds are still treated correctly Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 7ee2495f321198548b3ffbf983aa1d13f6c6c2cc Author: Nick Clemens Date: Mon Aug 12 18:41:24 2019 +0000 Bug 18958: Unit tests Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy JD amended patch: perltidy and simplify item/biblio creation Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 8ede5cd3f93cb96e09f460e1ba965032e804077e Author: Joonas Kylmälä Date: Mon Sep 14 10:27:24 2020 +0300 Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch The "--commit" or "-c" parameter was incorrectly not used if it was passed to the koha-elasticsearch program. To test: 1) Before patch notice koha-elasticsearch --rebuild --commit 1 -v only commits every 5000 records 2) Apply patch and notice the above command commits every 1 record Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 642c29dc230239d4ae1eb718f423c77072aa1e81 Author: Andreas Roussos Date: Mon Sep 14 10:08:23 2020 +0200 Bug 26451: fix typo in bulkmarcimport.pl bulkmarcimport.pl displays a small typo when a MARC modification template is being used: "modofication". This patch fixes that. Test plan: apply the patch, and confirm the script no longer displays the typo. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 4f3cb59a97df5fc954e9e807896e14af960237a9 Author: Katrin Fischer Date: Thu Aug 27 07:30:54 2020 +0000 Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and dateexpiry fields are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Signed-off-by: David Nind Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 5ece5d7c7f739cbf2d4b81be767ff89a8c1204f5 Author: Owen Leonard Date: Wed Sep 9 15:58:04 2020 +0000 Bug 26421: Use Bootstrap screen reader text class for shelf browser messages This patch udpates the markup added by Bug 26039, replacing the "hidden" class, which is no longer functional with Bootstrap 4, with "sr-only," a class designed specifically for screen reader text. The patch also corrects a typo, "shelfbrowers" -> "shelf browser" To test, apply the patch and make sure the OPACShelfBrowser system preference is enabled. View the detail page for a bibliographic record with items. In the holdings table, you should see links labeled "Browse shelf." When you open the shelf browser there should be a link at the top that reads "Close shelf browser." If you have access to a screen reader, test that the hidden text is announced by the reader. "Browse shelf (Opens below)" and "Close shelf browser (Hides shelf browser)." Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 22f14a7b6d45f3bf5ad57bd52203d4cdef724ce7 Author: Marcel de Rooy Date: Tue Sep 15 12:09:56 2020 +0000 Bug 26464: Code correction in opac-main when news_id passed Theoretical change. If somehow the search would return more than one result, the code is wrong. The if test can be simplified: remove scalar and >0. We should not pass @array to one param. It would theoretically add wrong items or trigger an odd number warning. If it is only one, it is no problem. But it is buggy. Test plan: Pass an existing news_id to opac-main. Item visible? And pass a not-existing. Error message? Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 0310e973a4c28a7e02baad03799eb40869ce4506 Author: Jonathan Druart Date: Fri Jul 31 11:15:57 2020 +0200 Bug 10921: Prevent an order from a closed basket to be edited We don't allow editing of orders that are part of a closed basket, but we don't enforce the rule in the controller file. This patch use output_and_exit to stop the script and display an error to the end user. Test plan: Create a basket, add an order On the basket view you see the "Modify" link, open it in a separate tab => You can edit the basket Keep this tab open, get back to the other one and close the basket Reload the tab with the order edition form => You cannot longer edit the basket QA: Do we need a check in addorder.pl as well? Signed-off-by: Henry Bolshaw Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit f90afe5c22445fb47430f629491d09762beeb3f8 Author: Owen Leonard Date: Mon Jul 13 17:42:36 2020 +0000 Bug 15933: Add cataloguing plugin to search for existing publishers in other records This patch adds a new cataloging plugin for MARC21 installations, marc21_field-260b.pl. When enabled it provides autocomplete for publisher name, pulling existing data from biblioitems.publishercode. To test, apply the patch and enable the plugin: - Go to Administration -> MARC bibliographic framework -> MARC structure -> 260 -> Edit subfields -> Subfield b -> Other options. - Set "Plugin" to marc21_field_260b.pl. - Go to Cataloging and edit or create a record. - Under tab 2 click the field for 260$b. Start typing a publisher name. A dropdown should appear with matching publishers. - Selecting one of the results should populate the form field with that information. Signed-off-by: Sally Signed-off-by: Katrin Fischer Also works with 264$b. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 76cff7e528a673369a0ee1b88207a2dbe4fbf8ad Author: Jonathan Druart Date: Fri Sep 18 09:46:10 2020 +0000 Bug 24807: DBRev 20.06.00.038 Signed-off-by: Jonathan Druart commit c53909567a31e2eae337ee029d1c9d7348f3874a Author: Nick Clemens Date: Fri Jul 10 13:15:58 2020 +0000 Bug 24807: (follow-up) Add support for spaces as unknown characters Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 55e18646db855a8cf14b1f7f9adae2729525a2ce Author: Nick Clemens Date: Thu May 7 16:26:38 2020 +0000 Bug 24807: (follow-up) Fix spelling Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit ad1aab0e4242f4ea774951703796892fb858e6df Author: David Gustafsson Date: Mon Apr 20 13:03:24 2020 +0200 Bug 24807: Simplify with new and imporved value_callbacks Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 342b51629d29db5e9309dc599c67b413e19ebbb8 Author: David Gustafsson Date: Thu Apr 16 17:26:41 2020 +0200 Bug 24807: Refactor using tokenize_callbacks Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 4cae9b49f3036c8500db702d031c8475f5fb673b Author: Nick Clemens Date: Wed Apr 8 09:55:20 2020 +0000 Bug 24807: Add suppport for uncertain fields and ranges To test: 1 - Have some records with uncertain dates in the 008 19uu, 195u, etc. 2 - Index them in Elasticsearch 3 - Do a search that will return them 4 - Sort results by publication/copyright date 5 - Note odd results 6 - Apply patch 7 - Reindex 8 - Sorting should be improved Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 19c5db66377fc6e30a56f365874387e682e6c4c7 Author: David Gustafsson Date: Thu Apr 16 14:51:13 2020 +0200 Bug 24807: Update tests Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 22abdd8af669dde60211f38f6c27a73367afe910 Author: David Gustafsson Date: Thu Mar 5 11:35:32 2020 +0100 Bug 24807: Add database update script Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit d1c8d7eccee6e75473bf7c780617d683f64e5229 Author: David Gustafsson Date: Wed Mar 4 17:07:11 2020 +0100 Bug 24807: Add "year" type to improve sorting behaviour Add a "year" search field type. Fields with this type will only retain values that looks like years, so invalid values such as whitespace or word characters will not be indexed. This for instance improves the behaviour when sorting by "date-of-publication". If all values are indexed, records with junk data instead of valid years will appear first among the search results, drowning out more relevant hits. If assigning this field the "year" type these records will instead always appear last, regarless of sort order. To test: 1) Have at least two biblios, one with a valid year in 008 (pos 7-10) and another with an invalid one ("uuuu" for example) 2) Perform a wildcard search (*) and sort results by publication date. 3) The record with invalid year of pulication in 008 should appear first 4) Apply patch and run database updates 5) Reindex ElasticSearch 6) Perform the same search as in 2) 7) The record with the invalid year should now appear last Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 3b273de5777ac7dd5bebac629dc8c88e6bdc962a Author: Lucas Gass Date: Thu Aug 6 18:21:52 2020 +0000 Bug 25744: replace with in the staff interface This patch set attempts to replace all the tags with and all the tags with in the staff interface. I attempted to get all the templates, includes, and xslt files. To test: 1. Review the changes as best as possible, looking for mistakes. 2. grep for and in the modules, includes, and xslt folders. You should get nothing/ 3. If you grep '<\/i>' you should only see instances of Font Awesome. 4. If you grep '<\/b>' you should only see instances where caret is used. Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit a02bd4f71c25207b38908887bae50bdf1c450a3b Author: Lucas Gass Date: Thu Aug 6 17:29:54 2020 +0000 Bug 25744: Replace with in staff interface Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 9db369fb58c1f2795f748e972397f1ecb882ce92 Author: Fridolin Somers Date: Thu Jul 23 10:21:36 2020 +0200 Bug 26049: Replace li with span class results_summary in UNIMARC intranet XSLT In all XSLT for record display, fields are created with