[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-45-g73c246238b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  73c246238bc21aa48689a8027cd3ae01fb7f9232 (commit)
       via  b870bac520083283abb199a059ed767165ead677 (commit)
      from  3a4f76b60d880fabb5bb6637839d1a83e673e1d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 73c246238bc21aa48689a8027cd3ae01fb7f9232
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Aug 20 07:56:12 2020 -0400

    Bug 25903: Add unit tests
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 49f5200374e9a381ab7398730e42c0beefc0f2a4)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit b870bac520083283abb199a059ed767165ead677
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jun 30 14:37:21 2020 -0400

    Bug 25903: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server
    
    The 'summary' field in the patron information request specifies if detail information should be send for holds,
    overdues, fines, etc. The field is 10 characters in length (0-9). However, the SIP2 spec only defines indexes 0
    though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these undefined indexes. Apparently the
    7th field is often used to request 'Fees', as opposed to 'Fines' in some ILS. Some software that integrate via
    SIP try both the 5th and 7th indexes to ensure they get all fines and fees.
    
    The problem is that Koha's SIP server crashes if any 'summary' index beyond 5 is flagged. We should simply
    ignore flags beyond 5 and act as if no flags were sent.
    
    Test Plan:
    1) Enable SIP for your instance
    2) Send a patron information request with a summary flag in any index beyond 5.
       i.e.: 6300120200617    124846      Y   AOMIDAY|AA21030050054321
    3) Note the SIP server just closes the connection without a response
    4) Apply this patch
    5) Restart the SIP server
    6) Send the same request
    7) Note you get back the patron information response!
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Jeff Gaines <jgaine at arlingtonva.us>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit fd4dbba7fb25bb73bcee152c84e704f9796664fd)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/Sip/MsgType.pm        |  8 +++----
 t/db_dependent/SIP/Message.t | 56 +++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 59 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository