[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.09-14-gb1924d2127

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  b1924d212715c806650a85b781f5ebb3ee531b71 (commit)
      from  104fba4bb0e5dec1914978b324551e443eb51a40 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b1924d212715c806650a85b781f5ebb3ee531b71
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Sun Jun 14 22:41:03 2020 +0000

    Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded
    
    If 'Actual cost' has not been set then it has the value of 0.00 which
    Perl evaluates to true so this patchset resets it to 0, so the fallback
    to ecost_tax_included/ecost_tax_excluded happens.
    
    Test plan:
    1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax')
    2. Set 'Vendor price' = 10 and do not set 'Actual cost'
    3. Save order
    4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST
    column has value of -8.70
    
    5. Jump into the database:
    select tax_value_on_ordering from aqorders where
    ordernumber=<ordernumber>;
    [You can get the ordernumber from clicking on the 'Modify' line the item
    is listed in]
    6. Observe a negative value: -8.70
    
    7. Apply patch and restart plack
    8. Add a second item to the basket
    9. Set 'Vendor price' = 10 and don't set 'Actual cost'
    10. Save order
    11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST
    has value of 1.30
    12. Repeat step 5 and observe tax_value_on_ordering = 1.30
    13. Run t/Prices.t unit test:
    sudo koha-shell <instancename>
    prove t/Prices.t
    
    Sponsored-by: Horowhenua District Council, NZ
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 7b66b90fe707e8ac650a1c85d87560fc2f4a223d)
    (cherry picked from commit 3bbf6384492834055d38ac844521be6c02d503ab)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm |  1 +
 acqui/basket.pl   |  2 ++
 t/Prices.t        | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 54 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository