[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.03-79-g67aa733726
Git repo owner
gitmaster at git.koha-community.org
Tue Sep 15 00:07:33 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via 67aa733726b13f0437bb11b6cb5d18220caba757 (commit)
via 00570ae9690a33a9be62dc51aaffa9d3774281f9 (commit)
from 7a8b7ba2f42c9709301b321f3c8e05bc0af78487 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 67aa733726b13f0437bb11b6cb5d18220caba757
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Fri Aug 21 16:23:38 2020 +0300
Bug 26271: Add null to the list of accepted account_line data types
The database schema for accountlines table allows the
manager_id/user_id column to be NULL. If request to
/api/v1/patrons/<patron_id>/account returns such an accountline where
it is NULL we get 500 error as response. Adding NULL to allowed data
types fixes this issue.
To test:
1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it
doesn't fail
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 089b85758614260b70f43509ccdbc6285629a883)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
commit 00570ae9690a33a9be62dc51aaffa9d3774281f9
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Fri Aug 21 16:21:42 2020 +0300
Bug 26271: Add failing test to reveal issue with patrons API endpoint
When manager_id is null/undef the API returns error code 500.
To test:
1) Notice failure when running
prove t/db_dependent/api/v1/patrons_accounts.t
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 898cd3b82ee84682bdfad1c177e2eb6ae0881428)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
api/v1/swagger/definitions/account_line.json | 5 +++-
t/db_dependent/api/v1/patrons_accounts.t | 36 +++++++++++++++++++++++++++-
2 files changed, 39 insertions(+), 2 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list