[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-27-g0a56308fe5

Sun Sep 20 13:46:33 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  0a56308fe52a689193e60901edb1aed870e2fae6 (commit)
       via  f9eed86f7bf9eda16293ee1a283278ecaa295357 (commit)
       via  664aa36698ae0ad9ae33f5a7a7a8e8fa7924f1ae (commit)
       via  bad82e2a3cb7d2def220bc787c1f2d58c08ec6e2 (commit)
       via  cab5e5fd5a919a743d4a9733d75cac643a877ef1 (commit)
      from  ae866dae38dc380b1d3f1635e6832ac7a4c237b8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0a56308fe52a689193e60901edb1aed870e2fae6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jul 22 14:11:03 2020 +0200

    Bug 26043: Fix random failure from Holds.t

     #   Failed test 'Test ModReserveMinusPriority()'
     #   at t/db_dependent/Holds.t line 202.
     #          got: undef
     #     expected: '1605'
     # Looks like you failed 1 test of 66.

    It is coming from Koha::Patron->holds that is ordering by reservedate,
    so "sometimes" they are ordered in reverse (at least it's my
    understanding of the problem).

    Test plan:
    Run the test file several times (from 20 to 60x), it must never fail
    with this patch

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 80a611797bf67b263b6b84a6e931833ea336b6a5)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit c98a283d118bb936dc44db1b73cfeb8e45f89a22)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit c106d5a29d32572276489b5b1f3b8941ab17c778)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit f9eed86f7bf9eda16293ee1a283278ecaa295357
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jul 29 12:21:29 2020 +0000

    Bug 25762: Typo in linkitem.tt

    This patch corrects the same typo in two different templates:

    ’ -> ›

    If you want to test beyond examining the patch, apply the patch
    and go to Tools -> Rotating collections.

    - Add an item to a rotating collection.
    - In the browser's title bar (or the tab title if the title bar isn't
      shown) the separator between the rotating collection name and "Add or
      remove items" should be ">" instead of "`"
    - Enable the EasyAnalyticalRecords system preference.
    - View the detail page for a bibliographic record.
    - From the "Edit" menu, choose "Link to host record"
    - Check the title bar as you did previously.

    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 19f9bc0528ec0f5cdf000b5120138652b3ece57c)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit a8a7d8667edbe6d8b9ab19c33a6cd4ce1a8ca4f6)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 22809514f581dde652f2ab96dad1dc7cdfb5d1ac)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 664aa36698ae0ad9ae33f5a7a7a8e8fa7924f1ae
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Thu Jun 25 11:25:41 2020 +0400

    Bug 25873: Ignore malformed data for Elasticsearch integer fields

    If we try to put malformed data into an integer field, Elasticsearch
    rejects the whole document.
    Setting 'ignore_malformed' to true allows to ignore malformed data and
    process the other fields of the document normally

    https://www.elastic.co/guide/en/elasticsearch/reference/7.8/ignore-malformed.html

    Test plan:
    * Without the patch
      1. In search engine configuration, change the type of a text field to
      'Number' (for instance 'title')
      2. misc/search_tools/rebuild_elasticsearch.pl -d -b
      3. See that the index is empty (unless you have titles consisting only
      of digits)
    * With the patch
      1. misc/search_tools/rebuild_elasticsearch.pl -d -b
      2. Now records are correctly indexed

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit cb5acdc6702cef4668921ccf2537797358981fff)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 056eb8c74e0b01386a0a1127ed5fff5ef59390b1)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 9b9c56c3b28e4e5e1592b3a0102114d88418d958)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit bad82e2a3cb7d2def220bc787c1f2d58c08ec6e2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jul 30 12:00:03 2020 +0200

    Bug 25852: Improve C4::Creators::Lib reliability under plack

    This is certainly a major issue that leads to many side-effects.
    Under plack, the structure of the default values are not handled
    correctly.
    Package variables are used to store stuff like the "layout type". They
    are complex structures (arrays of hashes) and returned without being
    copied.
    When the caller (the controller script) retrieve them then modify the
    returned structures, it actually modifies the package's variables.

    One of the issue is:
    Create a new layout
    The script retrieve a structure with all "selected" flags are set to 0
    It select the first one as default (BAR as selected => 1)
    The user creates the new layout and will selected BIBBAR (for instance)
    If you then edit this new layout, the script will retrieve the
    "label_types" and set "selected" for BIBBAR. However BAR is still
    selected!
    The UI receives 2 selected and display the first selected one that has
    the selected option.

    Test plan:
    1. Create a layout type for Barcode/Biblio
    2. Choose fields to print and size of font
    3. Save
    4. Edit existing Layout
    => Withtout this patch "Barcode" is the preselected option
    => With this patch applied, the correct "Barcode/Biblio" option is
    selected

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 0a9d3f17d9e44b5326a42d14420d30243031629d)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit e2c9fdb5bd702e358aa5b7f86e1ddf80525a4128)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 0471bd6843974b473d266ced3c50b1c95f6695ea)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit cab5e5fd5a919a743d4a9733d75cac643a877ef1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jul 30 11:59:44 2020 +0200

    Bug 25852: Add tests

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit e330e4ec222f8ac3a04339a020509e30aa0bf3ab)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 57e3f2ed7b69e815743d817ac094600d3a40bec8)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 6f7e48d75f7161a4c34f3bf8ececff94b74fbc0b)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 C4/Creators/Lib.pm                                       | 16 ++++++++--------
 admin/searchengine/elasticsearch/field_config.yaml       |  1 +
 .../prog/en/modules/cataloguing/linkitem.tt              |  2 +-
 .../prog/en/modules/rotating_collections/addItems.tt     |  2 +-
 t/db_dependent/Creators/Lib.t                            |  7 ++++++-
 t/db_dependent/Holds.t                                   |  2 +-
 6 files changed, 18 insertions(+), 12 deletions(-)

hooks/post-receive
-- 
main Koha release repository