[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.04-2-g401133b5b1

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  401133b5b167708c4942d46d0ed164a2ceefbdfa (commit)
       via  5597b666e468af8708c82d2c0d06a6a133e82677 (commit)
      from  25cdee576318b8ee910a3f51979c9ea1137e5abe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 401133b5b167708c4942d46d0ed164a2ceefbdfa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Aug 24 14:24:39 2020 +0000

    Bug 25273: (follow-up) Don't die on unknown authtype
    
    We are guessing authtype code and inserting the heading built accorindg to C4::Heading
    
    If we can't identify the auth type, we can format the heading. There is a record in the koha test
    data that is missing the heading field so type cannot be idenfitied
    
    This prevents us from dying n a record where we cannot identify the type.
    
    Note: This code will also be triggered for custom authority types, higlighting
    that they won't link because of hardcoded mappings in C4::Heading. We must tackle this
    on a new bug
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 5a87514b2e44d64807422b29f719b29b0c9d1ba4)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 5597b666e468af8708c82d2c0d06a6a133e82677
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 28 12:19:56 2020 +0000

    Bug 25273: Make match-heading rely on authority type configuration
    
    The match-heading field is a special field used only by the linker, not accessible
    to staff or patrons via the interface. This field is used to store the constructed
    'search form' used for matching bib headings to authority fields.
    
    In bug 24269 I attempted to use the mappings defined in the inferface and also inject the search term.
    This did not work as too many subfields were indexed on their own and leading to false matches.
    In this bug we remove the mappings for this field, and create it ourselves during
    the indexing process. The C4::Headings module is still used to generate the correct form,
    however, the mappings are set based on the authority types in the system. This gives the user
    the ability to add new typoes, but prevents mapping changes from breaking linker functionality
    
    To test:
     1 - Start form a sample database with ElasticSearch working
     2 - Download via Z39.50 2 authorities, one of which is a narrower heading of the other, e.g.:
        Waterworks
        Waterworks - Costs
     3 - Place a heading for the broader term in a record. e.g. Waterworks
           In 650$a, without the cataloguing authority plugin. We don't want
           the link created now.
           You need syspref BiblioAddsAuthorities => allow
     4 - Make sure linker is set to default
     5 - Attempt to link the records
           misc/link_bibs_to_authorities.pl
     6 - Linking fails
     7 - Apply patch
     8 - refresh index settings (if using a custom file, remove 'match-heading')
           You can reset mappings in the UI or run this:
           misc/search_tools/rebuild_elasticsearch.pl -v -d -r
     9 - Reindex ES
    10 - Try to link again
    11 - It succeeds!
    12 - Run the tests
         prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Bug 25273: (follow-up)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit ce161fda9b7d47e3cfcbc73ddb877eed627d6313)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |  5 +-
 Koha/SearchEngine/Elasticsearch.pm                 | 35 ++++++-----
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |  2 +-
 admin/searchengine/elasticsearch/mappings.yaml     | 24 --------
 .../Koha/SearchEngine/Elasticsearch.t              | 70 +++++-----------------
 5 files changed, 39 insertions(+), 97 deletions(-)
 rename t/{ => db_dependent}/Koha/SearchEngine/Elasticsearch.t (94%)


hooks/post-receive
-- 
main Koha release repository