[koha-commits] main Koha release repository branch master updated. v20.05.00-1111-g1ac0850a33
Git repo owner
gitmaster at git.koha-community.org
Tue Sep 29 14:59:17 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 1ac0850a336d2bb3e5d0bd3ad990e61a34b3dd65 (commit)
via dc393dc6bee00170b0b5789691de6b24b06a73a7 (commit)
via 654eda8edc6fb82a13553b3e9b55ea1264177aca (commit)
via 45558c35e3a425f749029088424f1eedd898c938 (commit)
via 404767da8f45e4886aafbfa0142de8d9b9c5a0ec (commit)
via 0b7bd6ee28a2a62b32aa8ef1c99abcf4fdb76f7d (commit)
via 88c40e50975957b1de4b5e6b097555ee61ff062b (commit)
via 99506632a7f7ddbe9d5ba4164d0d40351a9eb914 (commit)
via 05537bcd8ea5bceb38805709eb29c2660edd0fa8 (commit)
via 72485629565dd76022e4202549defafec1dd2998 (commit)
via 701fde53ed703c751e37fd184de342838e8a9f2f (commit)
via 171e7bfc5103c63675766b504fb4cef530cb815f (commit)
via 8722bce9041c7108f27b26e8602aaf0b3564c855 (commit)
via 558e64eec0fa9d4e3b31e284038cbd223df8b0d8 (commit)
via 99befa42c80eddec6e49aa1a86b77e74f529f0bd (commit)
via f0275e6677891be3467dbfa34340665ed97605ec (commit)
via 8620d1ec4b99a6182d59ebe889504b4b87e991a8 (commit)
via 7fb705696f9f5d40d4a8463548fb950aaf7b9b20 (commit)
via 912d911db2eff822b3a964cc84f7d2653d696815 (commit)
via ea72b15480c7230c03e7620e9900dc32ae0691c5 (commit)
via 124560556efea775ceb04c77a0ef77cbc130f894 (commit)
via 111b14dc965d51561add33d94eaf18616a815e88 (commit)
via b1a3aeb0624700627a2cb4e1069190e596d50d12 (commit)
via d2afd19bc34b4cbd3d9c7d7b38a1d50cd79678e6 (commit)
via ee5914b9b9531a97c24b0acce230aeb315334557 (commit)
via 5fa99d7d59ffe65a3533c79a637b50f04e904736 (commit)
via 9e06e62a7fa59228d5aa8b4dcf16205dc33e8897 (commit)
via c2b14f6a1e1f4b80e2aab5ce111e67841b8b90a6 (commit)
via 22ff2118a703d6a2c03ffa02dbfb6b0c12765e69 (commit)
via f04ea65fa35a1f906a177b4a14e672ba4a4c3790 (commit)
via 8bf7c342bfaf7425f17427f6e82167f26c2311f8 (commit)
via 2c98f4849ddad3494e936a0b4ea39eca247dd9f2 (commit)
via 38566a861af1c1daf8fdf1a2b6137ae0c6391a7a (commit)
via 94f7ad3e6072e5138d80ff0b964425b109a22778 (commit)
via 1eb0fe4e5ea87423d4c3c936ad7320634a42c54e (commit)
via ac12b9c6485332f6ca34bb3d4a98c0c341bfe943 (commit)
via 2ac76aee66c5114a944bc0b00d952b3df5dad85a (commit)
via 9d056d0364cfdc96e5c8fc6a84f933db970ffbd0 (commit)
via 85b087718be83d32f2bf8a313971a2c4d46c2366 (commit)
via 7c2def7573d8b74763daebb1024bc2ad2016cb55 (commit)
via 1012bc97d402f5e00e54ee3984df28f5ad17325d (commit)
from a0e4e3b5f87fc4fa2af78ec1749429921e5e5ae9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1ac0850a336d2bb3e5d0bd3ad990e61a34b3dd65
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 29 11:17:34 2020 +0000
Bug 25320: (follow-up) Remove obsolete include file
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dc393dc6bee00170b0b5789691de6b24b06a73a7
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 18 14:28:38 2020 +0000
Bug 25320: Move translatable strings out of merge-record-strings.inc into merge-record.js
This patch eliminates the use of a separate include file containing
translatable strings in favor of embedding translatable strings in the
JavaScript itself.
To test, apply the patch and clear your browser cache if necessary.
- Perform a catalog search in the staff interface.
- Select two results to merge. Click Edit -> Merge records.
- Click "Next" on the "Merging records" page.
- On the "Source records" page click the second tab where all the
checkboxes are unchecked.
- Check the box for a tag which is non-repeatable, e.g. 245.
- You should see a message, "The field is non-repeatable and
already exists in the destination record. Therefore, you cannot add it."
- Check the box for a subfield which is non-repeatable, e.g. 245$a.
- You should see a message, "The subfield is non-repeatable and
already exists in the destination record. Therefore, you cannot
add it."
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from prog/js/merge-record.js for
translation, e.g.:
#: koha-tmpl/intranet-tmpl/prog/js/merge-record.js:72
msgctxt "Bibliographic record"
msgid ""
"The field is non-repeatable and already exists in the destination
record. "
"Therefore, you cannot add it."
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client and
repeat the test plan above. The translated string should appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 654eda8edc6fb82a13553b3e9b55ea1264177aca
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 29 11:29:29 2020 +0000
Bug 26291: (follow-up) Correct stray MSG instances
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 45558c35e3a425f749029088424f1eedd898c938
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 24 18:25:35 2020 +0000
Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js
This patch moves translatable strings out of z3950_search.inc into
z3950_search.js, wrapped in the double-underscore function for
translation.
To test, apply the patch and go to Cataloging.
- Click "New from Z39.50/SRU"
- In the search form, uncheck all search targets and submit the form.
You should get an error: "Please choose at least one external target"
- Peform a search which will return multiple pages of results.
- Test that you can enter a number in the "Go to page" form to
navigate to a specific page.
- Enter a non-number in the field and submit. You should get an error,
"The page entered is not a number."
- Enter a number in the field which is greater than the number of pages
of results. Submitting the form should trigger an error, "The page
should be a number between 1 and 10."
- Perform the same tests from the other Z39.50 search results
interfaces:
- Acquisitions -> Add to basket -> From an external source.
- Authorities -> New authority -> New from Z39.50/SRU.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/z3950_search.js for translation,
e.g.:
msgid "The page entered is not a number."
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 404767da8f45e4886aafbfa0142de8d9b9c5a0ec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 11:47:41 2020 +0200
Bug 26164: (and bug 26419) Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0b7bd6ee28a2a62b32aa8ef1c99abcf4fdb76f7d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 11:43:00 2020 +0200
Bug 26562: Removes 'searches' from localStorage on logout
A user recently logged in will inherit the "searches" item stored in localStorage.
To recreate:
Log in with user A, do some searches
Note that the "searches" item is filled in with the search queries
Logout and log in with user B
Note that the "searches" item is still there
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 88c40e50975957b1de4b5e6b097555ee61ff062b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 10:48:04 2020 +0200
Bug 26242: Remove one unused occurrences of MSG_NON_RESERVES_SELECTED
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 99506632a7f7ddbe9d5ba4164d0d40351a9eb914
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 1 11:51:25 2020 +0000
Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints
This patch changes the encoding of the data being used to define
jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug
prevents non-Latin-1 characters from being used when defining tab
controls. Using Template:Toolkit's "uri" filter converts the data to
usable characters.
To test, apply the patch and go to Administration -> MARC frameworks ->
MARC structure -> tag 952 -> Edit subfields.
- Under the "New" tab, add a subfield code which is outside the basic
Latin character set, e.g. £, §, æ.
- Save changes.
- Edit any subfield code to load the subfield constraints page again.
- Test that the subfield code tabs work correctly: Clicking each tab
should load only the corresponding panel.
- Test a variety of tabs including the one you created with the
non-Latin character.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 05537bcd8ea5bceb38805709eb29c2660edd0fa8
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Sep 12 17:24:36 2020 +0000
Bug 26431: Update NewsToolEditor system preference description
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 72485629565dd76022e4202549defafec1dd2998
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jul 30 12:38:22 2020 +0000
Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news
This patch modifies the news interface so that the user is offered a
choice of editing news items using the default editor as defined by the
NewsToolEditor system preference or the non-default one.
To test, apply the patch and go to Tools -> News.
- In the list of news items you should see an "Edit" split button in
each row.
- Clicking the "Edit" part of the button should open the edit view with
the correct editor as defined by the NewsToolEditor preference.
- Clicking the menu arrow on the button should offer the other editing
method:
- If NewsToolEditor is set to "WYSIWYG," the menu should offer "text
editor."
- If NewsToolEditor is set to "text editor," the menu should offer
"WYSIWYG editor."
- Test the button with the NewsToolEditor preference set to both options
and confirm that the button and menu work correctly.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 701fde53ed703c751e37fd184de342838e8a9f2f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Aug 20 20:10:40 2020 +0000
Bug 26261: Split calendar.inc into include file and JavaScript file
This patch moves most of the JavaScript out of calendar.inc and into a
new file, calendar.js. English strings in calendar.js are now wrapped in
the double-underscore function to allow for translation.
The patch shouldn't affect datepicker functionality in any way.
To test, apply the patch and test the datepicker in various contexts:
- Reports -> Statistics wizards -> Patrons
- Date of birth "from" and "to" should be linked so that the former
must come before the latter.
- Patrons -> Add or edit patron
- The date of birth field datepicker shouldn't allow you to pick a
future year from the dropdown.
- Tools -> Calendar.
- Test that the calendar tool works correctly.
- Test with various settings of the dateformat system preference.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/en/js/calendar.js for translation,
e.g.:
msgid "August"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and test the datepicker again. Translated strings like days of
the week and months should be correct.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 171e7bfc5103c63675766b504fb4cef530cb815f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Aug 8 13:15:43 2020 +0000
Bug 26164: Replace OPAC table sort icons with SVG
This patch modifies the OAPC CSS to convert table sorting icons from PNG
to SVG. These icons are added via background-image data-urls, so only
the SCSS file is modified.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).
- Clear your browser cache if necessary
- View any DataTable in the OPAC, for instance the table of
checkouts under the logged-in user's "your summary" tab.
- Confirm that the sorting icons in the table headers look
correct in each state: Sorted ascending, sorted descending, and
unsorted.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8722bce9041c7108f27b26e8602aaf0b3564c855
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jun 9 19:37:19 2020 +0000
Bug 26419: Replace OPAC Koha logo with SVG
This patch replaces the OPAC Koha logo PNG file with an SVG version.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Clear your browser cache if necessary.
- View any page in the OPAC. The Koha logo in the upper-left corner of
the screen should look good.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 558e64eec0fa9d4e3b31e284038cbd223df8b0d8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Aug 19 00:33:45 2020 +0000
Bug 26245: Remove unused functions from members.js
This patch removes some code from members.js which was unused.
To test, apply the patch and test that the process of adding or editing
a patron is unaffected. Check the Koha codebase for references to these
functions in JavaScript:
CheckDate
unique (note: Not the jQuery function)
check_manip_date
check_password
There should be none.
Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 99befa42c80eddec6e49aa1a86b77e74f529f0bd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Aug 1 00:37:32 2020 +0000
Bug 26120: Remove the use of jquery.checkboxes plugin from tags review template
This patch removes the use of the jquery.checkboxes plugin and improves
the handling of tag status markup so that the "Select all pending"
selection link works correctly.
To test, apply the patch and go to Tools -> Tags. To test properly you
should have multiple tags awaiting moderation.
- The initial view of tags moderation shows only tags awaiting
moderation. Test that the "select all," "clear all," and "Select all
pending" links work correctly.
- Click the "Approve" button for a tag, and the "Reject" button for
another tag.
- Test the "Select all pending" link again. Only the tags awaiting
moderation should be selected.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f0275e6677891be3467dbfa34340665ed97605ec
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Aug 5 17:27:58 2020 +0000
Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page
This patch removes the use of the jquery.checkboxes plugin from the
suggestions management page and replaces it with custom JS.
To test, apply the patch and go to Acquisitions -> Suggestions
Under each tab ("Accepted," "Pending," etc.), test that the "Check all"
and "Uncheck all" controls work correctly and only affect the table on
that tab.
Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8620d1ec4b99a6182d59ebe889504b4b87e991a8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 21 19:16:14 2020 +0000
Bug 26504: Remove the use of jquery.checkboxes plugin from checkout notes page
This patch removes the inclusion of the jquery.checkboxes plugin from
the checkout notes page. It is unused.
To test, apply the patch and confirm that the AllowCheckoutNotes system
preference is enabled.
- Go to Circulation -> Checkout notes.
- Confirm that the "Select all" and "Clear all" links work correctly.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7fb705696f9f5d40d4a8463548fb950aaf7b9b20
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 14 18:49:35 2020 +0000
Bug 24958: Remember last selected tab in SQL reports
This patch modifies the saved reports page so that it remembers, for the
duration of the browser session, the last active tab.
To test you should have multiple reports in multiple report groups.
Apply the patch and go to Reports -> Saved reports.
- Select a tab to filter the table of saved reports to a particular
report group.
- Navigate away from the page
- Return to the save reports page. The tab you previously selected
should be selected again.
- Restart your browser and return to the saved reports page. The tab
should no longer be preselected.
Update: The tabs filtering JavaScript has been moved to a separate
function so that the function can be triggered by both the "create"
event (when the tabs are initialized) and the "activate" event (when a
tab is selected).
Update II: Persistence is now enable through localStorage instead of
Cookies. The localStorage item is now cleared during the logOut
function.
Update III: The logOut() function in staff-global.js is now called by
auth.tt to ensure that tabs are not remembered across sessions.
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 912d911db2eff822b3a964cc84f7d2653d696815
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Aug 14 18:12:09 2020 +0000
Bug 26217: Move translatable strings out of templates into acq.js
This patch removes the definition of translatable strings out of
templates and into the JavaScript file, using the new JS i81n function.
To test:
- Apply the patch, go to acquisitions, and view a vendor.
- Click "Uncertain prices" in the sidebar menu.
- In the table of orders, enter something in the "price" form field
which isn't a valid price. You should get an error message.
- Test the validation of fund amounts: Go to Administration -> Budgets
and create an active budget if necessary.
- Add a fund to that budget. Try to save the fund with a fund amount
which exceed the amount in the budget.
- You should get an error message: "Fund amount exceeds period
allocation"
- Add a fund with valid data and then go to Administration -> Funds and
locate the fun you just created.
- Use the "Actions" menu to add a sub fund to that fund.
- Try to save this new fund with an amount which exceeds the amount in
the parent fund.
- You should get an error message, "Fund amount exceeds parent
allocation."
Note: I was unable to properly test the error message "New budget-parent
is beneath budget." I couldn't figure out how to trigger it.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/acq.js for translation, e.g.:
msgid "Fund amount exceeds period allocation"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ea72b15480c7230c03e7620e9900dc32ae0691c5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Aug 19 18:33:28 2020 +0000
Bug 26256: Move translatable strings out of templates and into serials-toolbar.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch and go to Serials and search for a subscription.
- Open the detail page for an open subscription.
- Click the "Close" button. You should get a confirmation, "Are you
sure you want to close this subscription?"
- Confirm that you want to close it.
- When the page reloads, click the "Reopen" button. You should get a
confirmation, "Are you sure you want to reopen this subscription?"
- Cancel.
- Choose Edit -> Delete subscription. You should get a confirmation,
"Are you sure you want to delete this subscription?"
- Perform the same tests from the "Serial collection" page.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js for translation,
e.g.:
msgid "Are you sure you want to delete this subscription?"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 124560556efea775ceb04c77a0ef77cbc130f894
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Sep 25 20:24:20 2020 +0000
Bug 26243: (QA follow-up) Switch quotes to avoid translation issues
The QA script warned about text in single quotes which can be
a problem for languages like French that need to be able to use
these quotes in their translations.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 111b14dc965d51561add33d94eaf18616a815e88
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 18 18:45:56 2020 +0000
Bug 26243: Move translatable strings out of templates and into circulation.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch and check out to a patron.
- If there are none on the account, add a new message using the "Add a
new message" link.
- Click "Delete" for that message.
- You should get a confirmation message, "Are you sure you want to
delete this message? This cannot be undone."
- If necessary, enable the ExportCircHistory system preference.
- Check out to a patron who has one or more items checked out.
- Wihtout checking any checkboxes, click the "Export" button at the
bottom of the page.
- You should get an error message, "You must select checkout(s) to
export."
- Add a restriction the patron's account.
- Delete the restriction. You should get a confirmation message, "Remove
restriction?"
- Perform the same tests from the patron detail page.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js for translation,
e.g.:
msgid "You must select checkout(s) to export"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b1a3aeb0624700627a2cb4e1069190e596d50d12
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 31 17:19:00 2020 +0000
Bug 26118: Move translatable strings out of tags/review.tt and into tags-review.js
This patch removes the section of the tags review template which defined
strings for translation. They can now be embedded in the JavaScript
file, wrapped in the __() function.
To test, apply the patch and clear your browser cache if necessary.
- Go to Tools -> Tags and perform some actions which will trigger the
use of translated strings in the interface. For instance:
- Approving and rejecting tags
- Testing tags which are approved, rejected, or unclassified.
- Status messages for these operations should work correctly.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js for
translation, e.g.:
msgid "Both subfield values should be filled or empty."
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client and
repeat the test plan above. The translated strings should appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d2afd19bc34b4cbd3d9c7d7b38a1d50cd79678e6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 14:26:58 2020 +0200
Bug 25321: Remove 2 remaining occurrences of strings.inc
They were used for browser.js
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee5914b9b9531a97c24b0acce230aeb315334557
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 29 11:12:23 2020 +0200
Bug 25321: Remove PLACE_HOLD from results.js
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5fa99d7d59ffe65a3533c79a637b50f04e904736
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Aug 21 12:11:11 2020 +0000
Bug 25321: Move translatable strings out of strings.inc into the corresponding JavaScript
This patch moves string definitions out of strings.inc and into the
corresponding JavaScript files.
To test, apply the patch and test various pages in the staff interface:
A few suggestions:
- Perform a catalog search and view the detail page for a bibliographic record.
- Confirm that the search results browser in the left-hand sidebar
work correctly and that the title attributes of the controls are
correct.
- Locate a patron with multiple checkouts. View the checkout page and
test the various controls in the table of checkouts: Renew, check in,
return claims, etc.
- View the list of holds on a patron's account. Test suspending and
resuming holds.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/checkouts.js for
translation, e.g.:
msgid "Checked in"
msgstr ""
- Edit the "msgstr" string however you want (it's just for
testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9e06e62a7fa59228d5aa8b4dcf16205dc33e8897
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 18 17:09:31 2020 +0000
Bug 26240: Move translatable strings out of sms_providers.tt and into sms_providers.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test you must have the SMSSendDriver preference populated ("Email" is
fine).
- Apply the patch and go to Administration -> SMS cellular providers.
- Click "New SMS provider."
- The legend on the form's fieldset should read "Add an SMS cellular
provider."
- Add an SMS provider.
- Edit an SMS provider.
- The legend on the form's fieldset should read "Edit provider <provider
name>"
- If necessary, edit a patron's SMS settings to use one of your existing
SMS providers.
- From the list of SMS providers, click to delete the provider which is
in use.
- The error message should read "Are you sure you want to delete
<provider name>? <number> patron(s) are using it!"
- Click to delete a provider which isn't in use. The error message
should read "Are you sure you want to delete <provider>?"
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/sms_providers.js for translation,
e.g.:
msgid "Add an SMS cellular provider"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c2b14f6a1e1f4b80e2aab5ce111e67841b8b90a6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 18 17:43:22 2020 +0000
Bug 26242: Move translatable strings out of results.tt and into results.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch and perform a catalog search which will return
multiple results.
- Without checking any checkboxes, click the "Add to Cart" button. You
should see a message, "No item was selected."
- The same should happen if you select an item from the "Add to list"
menu or click the "Place hold" button.
- Click the "Select all" link to check all checkboxes.
- Click the "Place hold" button.
- You will inevitably get a "One or more selected items cannot be placed
on hold." message. If you were to want to complete this process you
would have to painstakingly sift through each search result to find
which item couldn't be placed on hold so that you could uncheck the
corresponding checkbox. Luckily this test plan doesn't require you to
do that.
- If you don't get an error message you're living in a catalog utopia
unlike any I have ever seen.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/pages/results.js for translation,
e.g.:
msgid "Nothing is selected"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 22ff2118a703d6a2c03ffa02dbfb6b0c12765e69
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 18 15:11:10 2020 +0000
Bug 26237: Move translatable strings out of preferences.tt and into JavaScript files
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test (a non-comprehensive list):
- Apply the patch, go to Administration -> System preference
- Modify any system preference. "modified" should appear next to the
preference name.
- Click the "Save" button. You should get a message, "Saved preference
<pref name>"
- Hover your mouse over a section heading (e.g. "Features" under
Accounting). You should see a tooltip, "Click to collapse this
section."
- Click to collapse the section. The tooltip should change to "Click to
expand the section."
- Open a new tab for the staff interface and log out.
- In the original tab, modify and try to save a system preference. You
should get a message, "Error; your data might not have been saved."
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js for
translation, e.g.:
msgid "Saved preference %s"
msgstr ""
- Edit the "msgstr" string however you want (it's just for
testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff
client and repeat the test plan above. The translated strings
should appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f04ea65fa35a1f906a177b4a14e672ba4a4c3790
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 1 12:24:57 2020 +0000
Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js
This patch moves translatable strings out of members-menu.inc into
members-menu.js where they can be translated using the double-underscore
i18n function.
To test, apply the patch and go to Patrons.
- Expand the search options in the search header by clicking the [+]
link.
- Select "Date of birth" from the "Search fields" dropdown.
- A tooltip should appear above the search form, "Dates of birth
should be entered in the format..." with your current date format.
- Remove all "Adult" type patron categories but one.
- Check out to a child patron.
- From the "More" menu choose "Update child to adult patron."
- You should see a confirmation.
- From the checkout screen, from the "More" menu, choose "Renew patron"
- You should get a confirmation.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation,
e.g.:
msgid "Are you sure you want to renew this patron's registration?"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8bf7c342bfaf7425f17427f6e82167f26c2311f8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 4 19:10:50 2020 +0000
Bug 26395: Move translatable strings out of letter.tt into letter.js
This patch moves strings defined for translation in letter.tt
into letter.js for translation using the new double-underscore
i81n function.
Note, the "MSG_NO_NOTICE_FOUND" usage has been removed because it didn't
work.
To test, apply the patch and go to Tools -> Notices & Slips.
- Use the "Copy" dropdown to copy an existing notice to a specific
library.
- Save the copied notice.
- Return to the "All libraries" view on the Notices & Slips page.
- Repeat the same process above: Copy the same notice to the same
library.
- When you click save on the "Add notice" page you should get an error
message, "A letter with the code 'ACCTDETAILS' already exists for
<library>"
- From the "All libraries" view on the Notices & Slips page, copy the
text in the "Code" column of an existing notice.
- Click "New notice" and choose the module of the notice you copied
from.
- On the "Add notice" page, paste the code into the "Code" field and
enter a name in the "Name" field.
- Click "Save" without making any other changes. You should get an error
message, "Please fill at least one template."
- Enter some data into one of the message body fields but not message
subject, and click "Save" again.
- You should get an error, "Please specify title and content for
<notice>"
- Enter data in the message subject field and click "Save" again.
- You should get an error, "A default letter with the code <CODE>
already exists."
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/letter.js for translation,
e.g.:
msgid "Please fill at least one template."
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2c98f4849ddad3494e936a0b4ea39eca247dd9f2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 17 18:40:10 2020 +0000
Bug 26230: Move translatable strings out of item_search_fields.tt and into item_search_fields.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch, go to Administration -> Item search fields.
- If necessary, add a new search field.
- From the table of search fields, click the "Delete" button for one of
the fields.
- You should get a confirmation: "Are you sure you want to delete this
field?"
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate the string pulled from
koha-tmpl/intranet-tmpl/prog/js/item_search_fields.js for translation:
#: koha-tmpl/intranet-tmpl/prog/js/item_search_fields.js:18
msgid "Are you sure you want to delete this field?"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 38566a861af1c1daf8fdf1a2b6137ae0c6391a7a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 17 14:50:46 2020 +0000
Bug 26229: Move translatable strings out of categories.tt and into categories.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch, go to Administration -> Patron categories
- Click "New category"
- Enter some special characters in the "Category code" field, e.g.
"%^&*"
- Try to submit the form without filling in any other details.
- The category code field should have a validation message, "Category
code can only contain the following characters: letters, numbers, -
and _."
- The enrollment period fields should have a validation message, "Please
choose an enrollment period in months OR by date."
- Enter valid data and confirm that the form can be submitted.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/categories.js for translation, e.g.:
msgid "Please choose an enrollment period in months OR by date."
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 94f7ad3e6072e5138d80ff0b964425b109a22778
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 11 19:39:08 2020 +0000
Bug 26441: Move translatable strings out of catalog-strings.inc into catalog.js
This patch moves translatable strings out of catalog-strings.inc into
catalog.js, wrapped in the double-underscore function for
translation.
To test that each affected string correctly appears in the interface:
- View the details for a bibliographic record which has items attached.
- From the Edit menu, choose "Delete record." You should get an alert,
"X item(s) are attached to this record. You must delete all items
before deleting this record."
- From the Edit menu, choose "Delete all items." You should get an
alert, "Are you sure you want to delete the X attached items?"
- When logged in as a user with acquisitions and cataloging privileges,
view the details for a bibliographic record which is used in an order
in Acquisitions. Delete any items attached.
- Choose "Delete record" from the Edit menu. You should get an alert,
"Warning: This record is used in X order(s). Deleting it could cause
serious issues on acquisition module. Are you sure you want to delete
this record?"
- In Acquisitions, view a basket containing orders. Cancel the
order for a title in the basket. Open the detail page for the title in
the cancelled order. Try to delete it. You should get an confirmation,
"X deleted order(s) are using this record. Are you sure you want to
delete this record?"
- Perform the same test as a user with cataloging but not acquisitions
privileges. The alert should say "X deleted order(s) are using this
record. You need order managing permissions to delete this record."
- When logged in as a user with cataloging but not acquisitions
privileges, view the details for a bibliographic record which is used
in an order in Acquisitions. Delete any items attached.
- Choose "Delete record" from the Edit menu. You should get an alert, "X
order(s) are using this record. You need order managing permissions to
delete this record."
- View the details for a bibliographic record which has a hold.
- Choose "Delete all items" from the Edit menu. You should get an alert,
"X hold(s) on this record. You must delete all holds before deleting
all items."
- View the details for a bibliographic record which has no items.
- Choose "Delete record" from the Edit menu. You should get an alert,
"Are you sure you want to delete this record?"
- Choose "Edit items in a batch" from the Edit menu. You should get an
alert, "This record has no items."
I could not find any instance of the PopupZ3950Confirmed function in
catalog.js being triggered so I don't think the associated string can be
tested.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/catalog.js for
translation, e.g.:
msgid "This record has no items."
msgstr ""
- Edit the "msgstr" string however you want (it's just for
testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1eb0fe4e5ea87423d4c3c936ad7320634a42c54e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 17 13:04:27 2020 +0000
Bug 26225: Move translatable strings out of biblio_framework.tt and into biblio_framework.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch, go to Administration -> MARC bibliographic framework.
- Click Actions -> Export and save the file.
- Click Actions -> Import.
- Select a file which isn't CSV or ODS. You should get an error message,
"Please select a CSV (.csv) or ODS (.ods) spreadsheet file."
- Select the file you exported previously and click "Import." You should
see an error message, "Are you sure you want to replace the fields and
subfields for the default framework structure? ..."
- Click "OK." You should see a message in the modal window, "Importing
to framework:..."
- Edit your exported framework file in such a way that it isn't a valid
framework export.
- Repeat the process of importing the file. You should get an error
message, "Error importing the framework..."
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/biblio_framework.js for translation,
e.g.:
msgid "Please select a CSV (.csv) or ODS (.ods) spreadsheet file"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
https://bugs.koha-community.org/show_bug.cgi?id=26226
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ac12b9c6485332f6ca34bb3d4a98c0c341bfe943
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 17 12:26:39 2020 +0000
Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js
This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.
To test:
- Apply the patch, go to Administration -> Audio alerts.
- Click the "Delete selected alerts" button without checking any
checkboxes. You should see an error: "Check the box next to the alert
you want to delete."
- Check the checkbox for an existing sound and click "Delete selected
alerts." You should get a confirmation message, "Are you sure you want
to delete the selected audio alerts?"
- Click "New alert."
- Without filling any details, click the "Play sound" button. You should
see an error message, "Please select or enter a sound."
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.:
msgid "Are you sure you want to delete the selected audio alerts?"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2ac76aee66c5114a944bc0b00d952b3df5dad85a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Sep 1 13:46:35 2020 +0000
Bug 26339: Move translatable strings out of addorderiso2709.tt into addorderiso2709.js
This patch moves strings defined for translation in addorderiso2709.tt
into addorderiso2709.js for translation using the new double-underscore
i81n function.
To test, apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add orders from MARC file.
- Click "Add orders" next to a staged file.
- Without making any selections, click "Save." You should get an error,
"There is no record selected."
- Select a record and click "Save." You should get an error, "Some
budgets are not defined in item records."
- Enter a non-numeric value in the "Quantity" field and click "Save."
You should get an error, "1 quantity values are not filled in or are
not numbers."
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js for translation,
e.g.:
msgid "Some budgets are not defined in item records"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9d056d0364cfdc96e5c8fc6a84f933db970ffbd0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Aug 20 15:53:28 2020 +0000
Bug 25317: Move translatable strings out of additem.js.inc
This patch moves the definition of translatable strings out of
additem.js.inc and into additem.js using the new JS i81n function.
additem.js.inc is removed, being obsolete.
To test:
When creating an order:
- Go to Administration -> System preferences and set "AcqCreateItem" to
"when placing an order."
- Apply the patch and go to Acquisitions -> Vendor -> Add to basket ->
From a new (empty) record.
- In the "Item" section, confirm that the buttons at the bottom of the
form are correct: "Add item," "Clear," and "Add multiple items."
- Click "Add multiple items." The placeholder in the revealed form field
should read "Number of items to add." The corresponding button should
be labeled "Add."
- You should see a note, "NOTE: Fields listed in the 'UniqueItemsFields'
system preference will not be copied."
- Fill out the item entry form and add a number to the "multiple items"
field. Click "Add."
- A table of items should be displayed with "Edit" and "Delete" buttons
for each new item.
- Click one of the "Edit" buttons. The item form should be populated
with the item's data, with an "Update item" button at the bottom.
When receiving an order:
- Go to Administration -> System preferences and set "AcqCreateItem" to
"when receiving an order."
- Go to Acquisitions -> Vendor -> Receive shipments.
- Select or create an invoice.
- Click "Receive" on an order which has a quantity greater than 1.
- Add two items, duplicating in each at least one value which is marked
as unique by the "UniqueItemFields" system preference (e.g. fill in
the same barcode number for each item).
- Click "Save." You should get an alert about duplicated values, and
there should be an alert message on the page, "barcode 'XXX' is
duplicated."
- Edit one of the two items and change the barcode to one which already
exists in your database.
- Click "Save." An alert message should be shown on the page, "barcode
'XXX' already exists in the database."
- Note: I was unable to find out how to trigger this error, "You can't
receive any more items." It may be obsolete.
TESTING TRANSLATABILITY
- Update a translation, e.g. fr-FR:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g.
misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
koha-tmpl/intranet-tmpl/prog/js/additem.js for translation,
e.g.:
msgid "Add multiple items"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:
> perl translate install fr-FR
- Switch to your newly translated language in the staff client
and repeat the test plan above. The translated strings should
appear.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 85b087718be83d32f2bf8a313971a2c4d46c2366
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Sep 28 16:18:51 2020 +0200
Bug 7143: Update about page for new dev - Alexis Ripetti
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7c2def7573d8b74763daebb1024bc2ad2016cb55
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 31 09:43:09 2020 -0300
Bug 26322: Permissions not checked correctly for plugins
This patch fixes the logic in a condition to address the fact that
permissions are not checked for plugins. This was due to bad parenthesis
pairing and the lack of good tests for this.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> FAIL: Tests fail because of bad logic
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Verify the tests cover the use cases that are needed:
- Anonymous access
- Real user with wrong permissions (parameters => 1)
- Real user with right permissions (borrowers => 1)
=> SUCCESS: Needed use cases so we catch any regression are found
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1012bc97d402f5e00e54ee3984df28f5ad17325d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 31 09:36:56 2020 -0300
Bug 26322: Regression tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
Koha/REST/V1/Auth.pm | 2 +-
docs/contributors.yaml | 3 +
koha-tmpl/intranet-tmpl/js/browser.js | 12 +-
.../intranet-tmpl/prog/en/includes/additem.js.inc | 16 --
.../intranet-tmpl/prog/en/includes/calendar.inc | 216 +-------------------
.../prog/en/includes/catalog-strings.inc | 13 --
.../intranet-tmpl/prog/en/includes/js_includes.inc | 1 -
.../prog/en/includes/merge-record-strings.inc | 7 -
.../prog/en/includes/str/members-menu.inc | 7 -
.../intranet-tmpl/prog/en/includes/strings.inc | 61 ------
.../prog/en/includes/z3950_search.inc | 23 +--
.../prog/en/modules/acqui/addorderiso2709.tt | 6 -
.../prog/en/modules/acqui/neworderempty.tt | 1 -
.../prog/en/modules/acqui/orderreceive.tt | 1 -
.../prog/en/modules/acqui/uncertainprice.tt | 1 -
.../prog/en/modules/acqui/z3950_search.tt | 2 +-
.../prog/en/modules/admin/aqbudgets.tt | 7 -
.../prog/en/modules/admin/audio_alerts.tt | 5 -
.../prog/en/modules/admin/biblio_framework.tt | 4 -
.../prog/en/modules/admin/categories.tt | 2 -
.../prog/en/modules/admin/items_search_fields.tt | 3 -
.../en/modules/admin/marc_subfields_structure.tt | 6 +-
.../prog/en/modules/admin/preferences.tt | 14 --
.../prog/en/modules/admin/preferences/tools.pref | 4 +-
.../prog/en/modules/admin/sms_providers.tt | 6 -
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 +-
.../prog/en/modules/authorities/merge.tt | 1 -
.../prog/en/modules/catalogue/ISBDdetail.tt | 1 -
.../prog/en/modules/catalogue/MARCdetail.tt | 1 -
.../prog/en/modules/catalogue/detail.tt | 1 -
.../prog/en/modules/catalogue/labeledMARCdetail.tt | 1 -
.../prog/en/modules/catalogue/moredetail.tt | 1 -
.../prog/en/modules/catalogue/results.tt | 3 -
.../prog/en/modules/catalogue/stockrotation.tt | 1 -
.../prog/en/modules/cataloguing/addbiblio.tt | 1 -
.../prog/en/modules/cataloguing/additem.tt | 1 -
.../prog/en/modules/cataloguing/merge.tt | 1 -
.../en/modules/cataloguing/z3950_auth_search.tt | 2 +-
.../prog/en/modules/cataloguing/z3950_search.tt | 6 +-
.../prog/en/modules/circ/checkout-notes.tt | 1 -
.../prog/en/modules/circ/circulation.tt | 6 +-
.../prog/en/modules/members/moremember.tt | 6 +-
.../en/modules/reports/guided_reports_start.tt | 80 +++++---
.../prog/en/modules/serials/serials-collection.tt | 3 -
.../prog/en/modules/serials/serials-home.tt | 5 +-
.../prog/en/modules/serials/serials-search.tt | 3 -
.../prog/en/modules/serials/subscription-detail.tt | 3 -
.../prog/en/modules/suggestion/suggestion.tt | 12 +-
.../intranet-tmpl/prog/en/modules/tags/review.tt | 42 ++--
.../prog/en/modules/tools/koha-news.tt | 28 ++-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 6 -
koha-tmpl/intranet-tmpl/prog/js/acq.js | 8 +-
koha-tmpl/intranet-tmpl/prog/js/additem.js | 29 ++-
koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 10 +-
koha-tmpl/intranet-tmpl/prog/js/ajax.js | 8 +-
koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js | 8 +-
.../intranet-tmpl/prog/js/biblio_framework.js | 11 +-
koha-tmpl/intranet-tmpl/prog/js/calendar.js | 218 +++++++++++++++++++++
koha-tmpl/intranet-tmpl/prog/js/catalog.js | 26 +--
koha-tmpl/intranet-tmpl/prog/js/categories.js | 10 +-
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 78 ++++----
koha-tmpl/intranet-tmpl/prog/js/holds.js | 50 ++---
.../intranet-tmpl/prog/js/item_search_fields.js | 5 +-
koha-tmpl/intranet-tmpl/prog/js/letter.js | 13 +-
koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 14 +-
koha-tmpl/intranet-tmpl/prog/js/members.js | 90 ---------
koha-tmpl/intranet-tmpl/prog/js/merge-record.js | 4 +-
.../intranet-tmpl/prog/js/pages/circulation.js | 4 +-
.../intranet-tmpl/prog/js/pages/preferences.js | 26 +--
koha-tmpl/intranet-tmpl/prog/js/pages/results.js | 16 +-
.../intranet-tmpl/prog/js/pages/tags-review.js | 64 +++---
koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js | 8 +-
koha-tmpl/intranet-tmpl/prog/js/sms_providers.js | 8 +-
koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 +
koha-tmpl/intranet-tmpl/prog/js/z3950_search.js | 20 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss | 32 ++-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 30 ---
koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss | 23 ---
koha-tmpl/opac-tmpl/bootstrap/images/asc.gif | Bin 250 -> 0 bytes
koha-tmpl/opac-tmpl/bootstrap/images/ascdesc.gif | Bin 264 -> 0 bytes
koha-tmpl/opac-tmpl/bootstrap/images/desc.gif | Bin 61 -> 0 bytes
.../opac-tmpl/bootstrap/images/koha-green-logo.png | Bin 2125 -> 0 bytes
.../opac-tmpl/bootstrap/images/koha-green-logo.svg | 1 +
t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 40 +++-
tools/koha-news.pl | 11 +-
89 files changed, 659 insertions(+), 859 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/additem.js.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/calendar.js
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/asc.gif
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/ascdesc.gif
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/desc.gif
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/koha-green-logo.png
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/koha-green-logo.svg
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list