[Koha-cvs] CVS: koha/C4 Biblio.pm,1.12.2.2,1.12.2.3
Andrew Arensburger
arensb at users.sourceforge.net
Sat Oct 5 08:12:13 CEST 2002
Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv31196
Modified Files:
Tag: arensb-context
Biblio.pm
Log Message:
Added a whole mess of FIXME comments.
Index: Biblio.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Biblio.pm,v
retrieving revision 1.12.2.2
retrieving revision 1.12.2.3
diff -C2 -r1.12.2.2 -r1.12.2.3
*** Biblio.pm 5 Oct 2002 04:03:14 -0000 1.12.2.2
--- Biblio.pm 5 Oct 2002 06:12:10 -0000 1.12.2.3
***************
*** 2,5 ****
--- 2,8 ----
# $Id$
# $Log$
+ # Revision 1.12.2.3 2002/10/05 06:12:10 arensb
+ # Added a whole mess of FIXME comments.
+ #
# Revision 1.12.2.2 2002/10/05 04:03:14 arensb
# Added some missing semicolons.
***************
*** 473,476 ****
--- 476,480 ----
where bibid=? and tagorder=? order by subfieldorder
");
+ # FIXME - There's already a $sth2 in this scope.
my $sth2=$dbh->prepare("select subfieldvalue from marc_blob_subfield where blobidlink=?");
$sth->execute($bibid,$tagorder);
***************
*** 780,791 ****
--- 784,799 ----
$result=&MARCmarc2kohaOneField($sth,"biblio",$field,$record,$result);
}
+ # FIXME - There's already a $sth2 in this scope.
my $sth2=$dbh->prepare("SHOW COLUMNS from biblioitems");
$sth2->execute;
+ # FIXME - There's already a $field in this scope.
my $field;
while (($field)=$sth2->fetchrow) {
$result=&MARCmarc2kohaOneField($sth,"biblioitems",$field,$record,$result);
}
+ # FIXME - There's already a $sth2 in this scope.
my $sth2=$dbh->prepare("SHOW COLUMNS from items");
$sth2->execute;
+ # FIXME - There's already a $field in this scope.
my $field;
while (($field)=$sth2->fetchrow) {
***************
*** 1540,1543 ****
--- 1548,1552 ----
# FIXME - This is the same as &C4::Acquisitions::itemcount, but not
# the same as &C4::Search::itemcount
+ # Since they're both exported, acqui/acquire.pl doesn't compile with -w.
sub itemcount{
my ($biblio)=@_;
***************
*** 1584,1587 ****
--- 1593,1598 ----
}
+ # FIXME - This is in effect identical to &C4::Acquisitions::newbiblio.
+ # Pick one and stick with it.
sub newbiblio {
my ($biblio) = @_;
***************
*** 1592,1595 ****
--- 1603,1608 ----
}
+ # FIXME - This is in effect the same as &C4::Acquisitions::modbiblio.
+ # Pick one and stick with it.
sub modbiblio {
my ($biblio) = @_;
***************
*** 1599,1602 ****
--- 1612,1617 ----
} # sub modbiblio
+ # FIXME - This is in effect identical to &C4::Acquisitions::modsubtitle.
+ # Pick one and stick with it.
sub modsubtitle {
my ($bibnum, $subtitle) = @_;
***************
*** 1608,1611 ****
--- 1623,1627 ----
# FIXME - This is functionally identical to
# &C4::Acquisitions::modaddauthor
+ # Pick one and stick with it.
sub modaddauthor {
my ($bibnum, $author) = @_;
***************
*** 1615,1618 ****
--- 1631,1636 ----
+ # FIXME - This is in effect identical to &C4::Acquisitions::modsubject.
+ # Pick one and stick with it.
sub modsubject {
my ($bibnum, $force, @subject) = @_;
***************
*** 1622,1625 ****
--- 1640,1645 ----
} # sub modsubject
+ # FIXME - This is very similar to &C4::Acquisitions::modbibitem.
+ # Pick one and stick with it.
sub modbibitem {
my ($biblioitem) = @_;
***************
*** 1630,1633 ****
--- 1650,1655 ----
} # sub modbibitem
+ # FIXME - This is in effect identical to &C4::Acquisitions::modnote.
+ # Pick one and stick with it.
sub modnote {
my ($bibitemnum,$note)=@_;
***************
*** 1637,1641 ****
# FIXME - This is quite similar in effect to &C4::newbiblioitem,
! # except for the MARC stuff.
sub newbiblioitem {
my ($biblioitem) = @_;
--- 1659,1664 ----
# FIXME - This is quite similar in effect to &C4::newbiblioitem,
! # except for the MARC stuff. There's also a &newbiblioitem in
! # acqui.simple/addbookslccn.pl
sub newbiblioitem {
my ($biblioitem) = @_;
***************
*** 1649,1652 ****
--- 1672,1677 ----
}
+ # FIXME - This is in effect identical to &C4::Acquisitions::newsubject.
+ # Pick one and stick with it.
sub newsubject {
my ($bibnum)=@_;
***************
*** 1663,1666 ****
--- 1688,1693 ----
}
+ # FIXME - This is different from &C4::Acquisitions::newitems, though
+ # both are exported.
sub newitems {
my ($item, @barcodes) = @_;
***************
*** 1681,1684 ****
--- 1708,1714 ----
}
+ # FIXME - This appears to be functionally equivalent to
+ # &C4::Acquisitions::moditem.
+ # Pick one and stick with it.
sub moditem {
my ($item) = @_;
***************
*** 1695,1698 ****
--- 1725,1730 ----
}
+ # FIXME - This is the same as &C4::Acquisitions::Checkitems.
+ # Pick one and stick with it.
sub checkitems{
my ($count, at barcodes)=@_;
***************
*** 1712,1715 ****
--- 1744,1749 ----
}
+ # FIXME - This is identical to &C4::Acquisitions::countitems.
+ # Pick one and stick with it.
sub countitems{
my ($bibitemnum)=@_;
***************
*** 1725,1728 ****
--- 1759,1763 ----
# FIXME - This is just a wrapper around &OLDdelitem, and acts
# identically to &C4::Acquisitions::delitem
+ # Pick one and stick with it.
sub delitem{
my ($itemnum)=@_;
***************
*** 1731,1734 ****
--- 1766,1772 ----
}
+ # FIXME - This is functionally identical to
+ # &C4::Acquisitions::deletebiblioitem.
+ # Pick one and stick with it.
sub deletebiblioitem {
my ($biblioitemnumber) = @_;
***************
*** 1738,1741 ****
--- 1776,1781 ----
+ # FIXME - This is functionally identical to &C4::Acquisitions::delbiblio.
+ # Pick one and stick with it.
sub delbiblio {
my ($biblio)=@_;
***************
*** 1744,1747 ****
--- 1784,1789 ----
}
+ # FIXME - This is identical to &C4::Acquisitions::getitemtypes.
+ # Pick one and stick with it.
sub getitemtypes {
my $dbh = C4::Context->dbh;
***************
*** 1783,1786 ****
--- 1825,1830 ----
} # sub getbiblio
+ # FIXME - This is identical to &C4::Acquisitions::getbiblioitem.
+ # Pick one and stick with it.
sub getbiblioitem {
my ($biblioitemnum) = @_;
***************
*** 1803,1806 ****
--- 1847,1853 ----
} # sub getbiblioitem
+ # FIXME - This is identical to
+ # &C4::Acquisitions::getbiblioitembybiblionumber.
+ # Pick one and stick with it.
sub getbiblioitembybiblionumber {
my ($biblionumber) = @_;
***************
*** 1823,1826 ****
--- 1870,1876 ----
} # sub
+ # FIXME - This is identical to
+ # &C4::Acquisitions::getbiblioitembybiblionumber.
+ # Pick one and stick with it.
sub getitemsbybiblioitem {
my ($biblioitemnum) = @_;
***************
*** 1845,1848 ****
--- 1895,1900 ----
} # sub getitemsbybiblioitem
+ # FIXME - This is identical to &C4::Acquisitions::isbnsearch.
+ # Pick one and stick with it.
sub isbnsearch {
my ($isbn) = @_;
More information about the Koha-cvs
mailing list