[Koha-cvs] CVS: koha/C4/Circulation Circ2.pm,1.44,1.45

Andrew Arensburger arensb at users.sourceforge.net
Sun Oct 13 08:15:10 CEST 2002


Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv21111

Modified Files:
	Circ2.pm 
Log Message:
Added magic RCS string.
Added some FIXME comments.
Removed unused finalizer.


Index: Circ2.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Circ2.pm,v
retrieving revision 1.44
retrieving revision 1.45
diff -C2 -r1.44 -r1.45
*** Circ2.pm	11 Oct 2002 12:42:08 -0000	1.44
--- Circ2.pm	13 Oct 2002 06:15:08 -0000	1.45
***************
*** 1,4 ****
--- 1,6 ----
  package C4::Circulation::Circ2;
  
+ # $Id$
+ 
  #package to deal with Returns
  #written 3/11/99 by olwen at katipo.co.nz
***************
*** 1106,1109 ****
--- 1108,1112 ----
  		if ($accdata->{'amountoutstanding'} < $amountleft) {
  		    $newamtos = 0;
+ 		    # FIXME - -=
  		    $amountleft = $amountleft - $accdata->{'amountoutstanding'};
  		}  else {
***************
*** 1567,1570 ****
--- 1570,1574 ----
    my $total=0;
    while (my $data=$sth->fetchrow_hashref){
+     # FIXME = +=
      $total=$total+$data->{'sum(amountoutstanding)'};
    }
***************
*** 1581,1584 ****
--- 1585,1590 ----
  }
  
+ # FIXME - This is identical to &C4::Circulation::Renewals::renewstatus.
+ # Pick one and stick with it.
  sub renewstatus {
  # Stolen from Renewals.pm
***************
*** 1701,1704 ****
--- 1707,1712 ----
  }
  
+ # FIXME - A virtually identical function appears in
+ # C4::Circulation::Issues. Pick one and stick with it.
  sub createcharge {
  #Stolen from Issues.pm
***************
*** 1750,1753 ****
--- 1758,1763 ----
  # FIXME - This API is bogus: just return the record, or undef if none
  # was found.
+ # FIXME - There's also a &C4::Circulation::Returns::find_reserves, but
+ # that one looks rather different.
  sub find_reserves {
  # Stolen from Returns.pm
***************
*** 1815,1820 ****
      return ($resfound,$lastrec);
  }
- 
- END { }       # module clean-up code here (global destructor)
  
  1;
--- 1825,1828 ----





More information about the Koha-cvs mailing list