[Koha-cvs] CVS: koha/C4 BookShelves.pm,1.9,1.10

Ambrose Li acli at users.sourceforge.net
Wed Feb 5 11:05:06 CET 2003


Update of /cvsroot/koha/koha/C4
In directory sc8-pr-cvs1:/tmp/cvs-serv21249/C4

Modified Files:
	BookShelves.pm 
Log Message:
Converted a few SQL statements to use ? to fix a few strange SQL errors
Noted correct tab size


Index: BookShelves.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/BookShelves.pm,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -r1.9 -r1.10
*** BookShelves.pm	13 Oct 2002 08:29:18 -0000	1.9
--- BookShelves.pm	5 Feb 2003 10:05:02 -0000	1.10
***************
*** 1,2 ****
--- 1,5 ----
+ # -*- tab-width: 8 -*-
+ # Please use 8-character tabs for this file (indents are every 4 characters)
+ 
  package C4::BookShelves;
  
***************
*** 145,157 ****
  sub AddToShelf {
      my ($env, $itemnumber, $shelfnumber) = @_;
!     my $sth=$dbh->prepare("select * from shelfcontents where shelfnumber=$shelfnumber and itemnumber=$itemnumber");
!     $sth->execute;
      if ($sth->rows) {
  # already on shelf
      } else {
! 	$sth=$dbh->prepare("insert into shelfcontents (shelfnumber, itemnumber, flags) values ($shelfnumber, $itemnumber, 0)");
  			# FIXME - The default for 'flags' is NULL.
  			# Why set it to 0?
! 	$sth->execute;
      }
  }
--- 148,164 ----
  sub AddToShelf {
      my ($env, $itemnumber, $shelfnumber) = @_;
!     my $sth=$dbh->prepare("select * from shelfcontents
! 	where shelfnumber=? and itemnumber=?");
! 
!     $sth->execute($shelfnumber, $itemnumber);
      if ($sth->rows) {
  # already on shelf
      } else {
! 	$sth=$dbh->prepare("insert into shelfcontents
! 		(shelfnumber, itemnumber, flags) values (?, ?, 0)");
! 
  			# FIXME - The default for 'flags' is NULL.
  			# Why set it to 0?
! 	$sth->execute($shelfnumber, $itemnumber);
      }
  }
***************
*** 240,243 ****
--- 247,254 ----
  #
  # $Log$
+ # Revision 1.10  2003/02/05 10:05:02  acli
+ # Converted a few SQL statements to use ? to fix a few strange SQL errors
+ # Noted correct tab size
+ #
  # Revision 1.9  2002/10/13 08:29:18  arensb
  # Deleted unused variables.





More information about the Koha-cvs mailing list