[Koha-cvs] CVS: koha/C4 Z3950.pm,1.6,1.7

Mike Hansen wolfpac444 at users.sourceforge.net
Wed Feb 19 02:01:40 CET 2003


Update of /cvsroot/koha/koha/C4
In directory sc8-pr-cvs1:/tmp/cvs-serv14943/koha/C4

Modified Files:
	Z3950.pm 
Log Message:
Removed the unecessary $dbh argument from being passed.
Resolved a few minor FIXMEs.


Index: Z3950.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Z3950.pm,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -r1.6 -r1.7
*** Z3950.pm	13 Oct 2002 08:30:53 -0000	1.6
--- Z3950.pm	19 Feb 2003 01:01:06 -0000	1.7
***************
*** 86,93 ****
  =cut
  #'
  sub z3950servername {
      # inputs
      my (
- 	$dbh,		# FIXME - Unused argument
  	$srvid,		# server id number
  	$default,
--- 86,93 ----
  =cut
  #'
+ 
  sub z3950servername {
      # inputs
      my (
  	$srvid,		# server id number
  	$default,
***************
*** 99,113 ****
      $dbh = C4::Context->dbh;
  
! 	# FIXME - Fix indentation
! 	my $sti=$dbh->prepare("select name
! 		from z3950servers
! 		where id=?");
! 	$sti->execute($srvid);
! 	if ( ! $sti->err ) {
! 	    ($longname)=$sti->fetchrow;
! 	}
! 	if (! $longname) {
! 	    $longname="$default";
! 	}
  	return $longname;
  } # sub z3950servername
--- 99,114 ----
      $dbh = C4::Context->dbh;
  
!     my $sti=$dbh->prepare("
!         select name 
! 	from z3950servers 
! 	where id=?");
! 	
!     $sti->execute($srvid);
!     if ( ! $sti->err ) {
!         ($longname)=$sti->fetchrow;
!     }
!     if (! $longname) {
!         $longname="$default";
!     }
  	return $longname;
  } # sub z3950servername
***************
*** 151,156 ****
      # input
      my (
- 	$dbh,		# DBI handle
- 			# FIXME - Unused argument
  	$query,		# value to look up
  	$type,		# type of value ("isbn", "lccn", etc).
--- 152,155 ----
***************
*** 205,212 ****
  
  	my $serverlist='';
! 	# FIXME - $serverlist = join(" ", @serverlist);
! 	foreach (@serverlist) {
! 	    $serverlist.="$_ ";
!     	} # foreach
  	chop $serverlist;
  
--- 204,209 ----
  
  	my $serverlist='';
! 	
! 	$severlist = join(" ", @serverlist);
  	chop $serverlist;
  
***************
*** 275,278 ****
--- 272,279 ----
  #--------------------------------------
  # $Log$
+ # Revision 1.7  2003/02/19 01:01:06  wolfpac444
+ # Removed the unecessary $dbh argument from being passed.
+ # Resolved a few minor FIXMEs.
+ #
  # Revision 1.6  2002/10/13 08:30:53  arensb
  # Deleted unused variables.





More information about the Koha-cvs mailing list