[Koha-cvs] koha/C4 Members.pm [rel_2_2]

Joshua Ferraro jmf at kados.org
Tue Apr 4 01:43:20 CEST 2006


CVSROOT:	/sources/koha
Module name:	koha
Branch: 	rel_2_2
Changes by:	Joshua Ferraro <kados at savannah.gnu.org>	06/04/03 23:43:20

Modified files:
	C4             : Members.pm 

Log message:
	fixing a bug in the way that max is generated when finding the next
	borrowernumber. Now, using mysql 4.1 we can convert to an integer
	to get an accurate next value.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/koha/C4/Members.pm.diff?only_with_tag=rel_2_2&tr1=1.6.2.5&tr2=1.6.2.6&r1=text&r2=text

Patches:
Index: koha/C4/Members.pm
diff -u koha/C4/Members.pm:1.6.2.5 koha/C4/Members.pm:1.6.2.6
--- koha/C4/Members.pm:1.6.2.5	Tue Feb 21 18:50:42 2006
+++ koha/C4/Members.pm	Mon Apr  3 23:43:20 2006
@@ -259,7 +259,10 @@
 		
 			$cardnumber="V$cardnumber$rem";
 		} else {
-			my $sth=$dbh->prepare("select max(borrowers.cardnumber) from borrowers");
+			# MODIFIED BY JF: mysql4.1 allows casting as an integer, which is probably
+			# better. I'll leave the original in in case it needs to be changed for you
+			my $sth=$dbh->prepare("select max(cast(cardnumber as signed)) from borrowers");
+			#my $sth=$dbh->prepare("select max(borrowers.cardnumber) from borrowers");
 			$sth->execute;
 		
 			my ($result)=$sth->fetchrow;





More information about the Koha-cvs mailing list