[Koha-cvs] koha/C4 Suggestions.pm AuthoritiesMarc.pm

Chris Cormack chris at katipo.co.nz
Thu Feb 9 02:52:14 CET 2006


CVSROOT:	/sources/koha
Module name:	koha
Branch: 	
Changes by:	Chris Cormack <rangi at savannah.gnu.org>	06/02/09 01:52:14

Modified files:
	C4             : Suggestions.pm AuthoritiesMarc.pm 

Log message:
	Cleaning up some unessecary my statements

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/koha/C4/Suggestions.pm.diff?tr1=1.8&tr2=1.9&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/koha/koha/C4/AuthoritiesMarc.pm.diff?tr1=1.22&tr2=1.23&r1=text&r2=text

Patches:
Index: koha/C4/AuthoritiesMarc.pm
diff -u koha/C4/AuthoritiesMarc.pm:1.22 koha/C4/AuthoritiesMarc.pm:1.23
--- koha/C4/AuthoritiesMarc.pm:1.22	Fri Jan  6 16:39:37 2006
+++ koha/C4/AuthoritiesMarc.pm	Thu Feb  9 01:52:14 2006
@@ -121,7 +121,7 @@
 	# Finds the basic results without the NOT requests
 	my ($sql_tables, $sql_where1, $sql_where2) = create_request($dbh,\@normal_tags, \@normal_and_or, \@normal_operator, \@normal_value);
 
-	my $sth;
+
 
 	if ($sql_where2) {
 		$sth = $dbh->prepare("select distinct m1.authid from auth_header,$sql_tables where  m1.authid=auth_header.authid and auth_header.authtypecode=? and $sql_where2 and ($sql_where1)");
@@ -167,7 +167,7 @@
 		$summary =~ s/\n/<br>/g;
 
 		# find biblio MARC field using this authtypecode (to jump to biblio)
-		my $authtypecode = AUTHfind_authtypecode($dbh,$result[$counter]);
+		$authtypecode = AUTHfind_authtypecode($dbh,$result[$counter]);
 		my $sth = $dbh->prepare("select distinct tagfield from marc_subfield_structure where authtypecode=?");
 		$sth->execute($authtypecode);
 		my $tags_using_authtype;
@@ -937,8 +937,11 @@
 
 =cut
 
-# $Id: AuthoritiesMarc.pm,v 1.22 2006/01/06 16:39:37 tipaul Exp $
+# $Id: AuthoritiesMarc.pm,v 1.23 2006/02/09 01:52:14 rangi Exp $
 # $Log: AuthoritiesMarc.pm,v $
+# Revision 1.23  2006/02/09 01:52:14  rangi
+# Cleaning up some unessecary my statements
+#
 # Revision 1.22  2006/01/06 16:39:37  tipaul
 # synch'ing head and rel_2_2 (from 2.2.5, including npl templates)
 # Seems not to break too many things, but i'm probably wrong here.
Index: koha/C4/Suggestions.pm
diff -u koha/C4/Suggestions.pm:1.8 koha/C4/Suggestions.pm:1.9
--- koha/C4/Suggestions.pm:1.8	Fri Jan  6 16:39:37 2006
+++ koha/C4/Suggestions.pm	Thu Feb  9 01:52:14 2006
@@ -1,6 +1,6 @@
 package C4::Suggestions;
 
-# $Id: Suggestions.pm,v 1.8 2006/01/06 16:39:37 tipaul Exp $
+# $Id: Suggestions.pm,v 1.9 2006/02/09 01:52:14 rangi Exp $
 
 # Copyright 2000-2002 Katipo Communications
 #
@@ -248,8 +248,8 @@
 	my ($dbh,$biblionumber) = @_;
 	my $sth = $dbh->prepare("select suggestionid from suggestions where biblionumber=?");
 	$sth->execute($biblionumber);
-	my ($biblionumber) = $sth->fetchrow;
-	return $biblionumber;
+	my ($suggestionid) = $sth->fetchrow;
+	return $suggestionid;
 }
 
 =back





More information about the Koha-cvs mailing list